This patch fixes the following checkpatch.pl warnings:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2).
Signed-off-by: Kiran Padwal kiran.padwa...@gmail.com
---
drivers/staging/gdm724x/gdm_lte.c | 10 +-
1 file changed, 5 insertions(+), 5
Checkpatch fix - Add missing blank line after variable declaration
Signed-off-by: Kiran Padwal kiran.padwa...@gmail.com
---
drivers/staging/gdm724x/gdm_usb.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/gdm724x/gdm_usb.c
b/drivers/staging/gdm724x/gdm_usb.c
index
On Tue, Jul 22, 2014 at 12:26:42PM +0530, Kiran Padwal wrote:
This patch fixes the following checkpatch.pl warnings:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2).
Is that true here?
Have you tested this on the hardware to ensure it works
On 2014-07-21 19:48, H Hartley Sweeten wrote:
This parameter is never used by any of the comedi drivers that provide a
(*buf_change) callback. If the 'new_size' is needed in the callback it can
be found from the 's-async-prealloc_bufsz' as done in the ni_pcidio driver.
Remove the unused
On 18/07/14 16:33, Masanari Iida wrote:
This patch adds missing CR in dev_err message.
Signed-off-by: Masanari Iida standby2...@gmail.com
Acked-by: Martyn Welch martyn.we...@ge.com
---
drivers/staging/vme/devices/vme_pio2_gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 18/07/14 16:33, Masanari Iida wrote:
This patch fix spelling typo in printk message.
Signed-off-by: Masanari Iida standby2...@gmail.com
Acked-by: Martyn Welch martyn.we...@ge.com
---
drivers/staging/vme/devices/vme_pio2_gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On 18/07/14 16:33, Masanari Iida wrote:
This patch add missing CR in messages within vme_pio2_core.c
Signed-off-by: Masanari Iida standby2...@gmail.com
Acked-by: Martyn Welch martyn.we...@ge.com
---
drivers/staging/vme/devices/vme_pio2_core.c | 12 ++--
1 file changed, 6
On Sunday 20 July 2014 17:45:40 Chen Gang wrote:
Next, I shall:
- Remove HAS_IOMEM and NO_IOMEM from kernel, firstly.
- Try to make dummy IOMEM functions for score architecture.
- Continue discussing with UML for it.
Oh, sorry, I forgot, after remove IOMEM from kernel,
On 07/22/2014 06:32 PM, Arnd Bergmann wrote:
On Sunday 20 July 2014 17:45:40 Chen Gang wrote:
Next, I shall:
- Remove HAS_IOMEM and NO_IOMEM from kernel, firstly.
- Try to make dummy IOMEM functions for score architecture.
- Continue discussing with UML for it.
Oh, sorry, I
Removed redundant comments from 80211hdr.h header file
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/80211hdr.h |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/vt6655/80211hdr.h
b/drivers/staging/vt6655/80211hdr.h
index ba155cd..e05d135
Removed redundant comments and newlines from 80211mgr.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/80211mgr.h | 38 -
1 file changed, 38 deletions(-)
diff --git a/drivers/staging/vt6655/80211mgr.h
Removed redundant comments from aes_ccmp.h header file
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/aes_ccmp.h |9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/vt6655/aes_ccmp.h
b/drivers/staging/vt6655/aes_ccmp.h
index cc02e64..fe0c506
On Sat, Jul 19, 2014 at 11:55:39AM +0200, LABBE Corentin wrote:
Hello
The drivers/staging/sep/sep_main.c have lots of checkpatch issue.
This patch series solves them and since there are many, I have splitted
corrections in 4 patch.
Note that this work is done for the Eudyptulla
Move the proc entry controlling the boottotool flag to procfs. The field
appears in /sys/devices/platform/visorchipset/install/boottotool.
The boottotool flag controls s-Par behavior on the next boot of this guest.
Setting the flag will cause the guest to boot from the utility and installation
Move the chipsetready proc entry to sysfs under a new directory guest. This
entry is used by Unisys application software on the guest to acknowledge
completion of specific events for integration purposes, but these
acknowledgements are not required for the guest to operate correctly.
The store
Move the proc entry for controlling the toolaction field to sysfs. The field
appears in /sys/devices/platform/visorchipset/install/toolaction.
This field is used to tell s-Par which type of recovery tool action to perform
on the next guest boot-up. The meaning of the value is dependent on the
This patch set moves several interfaces in the visorchipset module from procfs
to sysfs, and removes the remaining proc interfaces from the module. It includes
documentation for the new interfaces in Documentation/ABI, and some code cleanup
in the new sysfs handler functions.
In version 2 of the
Move the /proc/visorchipset/parahotplug interface to sysfs under
/sys/devices/platform/visorchipset/guest/parahotplug.
The parahotplug interface is used to deal with recovery situations on s-Par
guest partitions. The command service partition will send a message to a guest
when a device that
Debugging information for the guest's channels was being exposed in proc.
Remove the code that creates these entries, which are no longer needed.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v2: patch location changed due to prior patches being revised.
The installer entry in /proc/visorchipset/installer was composed of three
separate fields as one entry. This patch removes the proc entry and associated
functions, and creates new fields with distinct entries under sysfs in the
visorchipset/install directory. The fields are:
textid: used
This patch adds a documentation file for all of the interfaces that were moved
to sysfs by the other patches in this set.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v2: whitespace errors were corrected.
.../Documentation/ABI/sysfs-platform-visorchipset | 74
This patch fix spelling typo in comments within rtw_mlme_ext.c
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git
This patch fix spelling typo in comments within rtw_mlme.c
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c
This patch fix spelling typo in comments within rtw_ap.c
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_ap.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c
This patch fix spelling typo in comments within
rtl8723au/core.
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8723au/core/rtw_efuse.c | 6 +++---
drivers/staging/rtl8723au/core/rtw_ieee80211.c | 2 +-
This patch fixes formatting and cleans up unneeded comments
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virthba/virthba.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
This patch fix spelling typo in comments within rtw_xmit.c
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c
This patch changes hmc5843.c to use regmap. This provides transparent caching
to the code as well as abstraction necessary to add support for SPI-based
hmc5983.
Signed-off-by: Josef Gajdusek a...@atx.name
---
drivers/staging/iio/magnetometer/Kconfig | 1 +
This patch splits hmc5843.c to multiple files - the interface-agnostic
hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is
another step to add support of SPI-enabled hmc5983.
Signed-off-by: Josef Gajdusek a...@atx.name
---
drivers/staging/iio/magnetometer/Kconfig
This patch adds support for the hmc5983 i2c interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek a...@atx.name
---
Changed structure of struct hmc5843_chip_info to include length of translation
arrays. Code previously using #defined constant has been changed accordingly.
This allows to integrate devices which do have different amounts of available
rates/scales.
Signed-off-by: Josef Gajdusek a...@atx.name
---
On 21/07/2014 17:16, Bjorn Helgaas wrote:
[+cc Jingoo]
On Fri, Jul 18, 2014 at 12:50 PM, James Bottomley
Anyway, it's PCI code ... let the PCI maintainer decide. However, if he
does want this do it as one big bang patch via either the PCI or Trivial
tree (latter because Jiří has
Replace use of NLMSG_SPACE(0) with NLMSG_HDRLEN as they are equivalent
and NLMSG_SPACE seems to be deprecated.
Signed-off-by: Himangi Saraogi himangi...@gmail.com
---
To send to: Greg Kroah-Hartman
gre...@linuxfoundation.org,de...@driverdev.osuosl.org,linux-ker...@vger.kernel.org
Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
linux.c:
drivers/staging/cxt1e1/linux.c:86:13: warning:
symbol 'error_flag' was not declared. Should it be static?
drivers/staging/cxt1e1/linux.c:91:13: warning:
symbol 'cxt1e1_max_mru' was not declared. Should it be
Those patches fix warnings reported by sparse on the vt6655
driver. This will allow to more easily find real errors with sparse
later if one appears.
Note that checkpatch does return an error for patch 1 and 2 (line over
80 characters) but the line length was not increased by this patch. If
Sparse reports that MimeThread is not used. Actually, it can be used
if THREAD is defined. By enclosing the MimeThread function into the
same #ifdef as the caller of MimeThread, this fixes the sparse
warnings.
Signed-off-by: Guillaume Clement gclem...@baobob.org
---
The IEEE11hbMgrRxAction is not exported and never used. Deleting it
allows to delete other functions that were only used by
IEEE11hbMgrRxAction.
This allows to fix several warnings reported by sparse.
Signed-off-by: Guillaume Clement gclem...@baobob.org
---
drivers/staging/vt6655/IEEE11h.c |
There is one function in aes_ccmp.c which is exported, but sparse sees
it unexported because it doesn't include the header that exports it.
Signed-off-by: Guillaume Clement gclem...@baobob.org
---
drivers/staging/vt6655/aes_ccmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote:
Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
linux.c:
drivers/staging/cxt1e1/linux.c:86:13: warning:
symbol 'error_flag' was not declared. Should it be static?
drivers/staging/cxt1e1/linux.c:91:13:
PortOffset was an unsigned long, but used as an pointer to io
memory. Sometimes it was not properly cast before use, which caused
many warning by sparse.
By updating its type to void __iomem *, and reflecting the changes
where it is needed, this removes most of those warnings.
Signed-off-by:
Some variables are used only in the context of their .c file, which
gives warnings with sparse.
Signed-off-by: Guillaume Clement gclem...@baobob.org
---
drivers/staging/vt6655/baseband.c| 14 +++---
drivers/staging/vt6655/bssdb.c | 4 ++--
drivers/staging/vt6655/card.c
On Tue, Jul 22, 2014 at 01:17:22PM -0700, Greg KH wrote:
On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote:
Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
linux.c:
I know you didn't name this variable, but wow, that's a horrid name for
a global variable
On Tue, Jul 22, 2014 at 04:56:59PM -0400, Jeff Oczek wrote:
On Tue, Jul 22, 2014 at 01:17:22PM -0700, Greg KH wrote:
On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote:
Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
linux.c:
I know you didn't name
On Tue, Jul 22, 2014 at 09:56:32AM -0400, Benjamin Romer wrote:
This patch adds a documentation file for all of the interfaces that were moved
to sysfs by the other patches in this set.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v2: whitespace errors were corrected.
On Tue, Jul 22, 2014 at 09:56:28AM -0400, Benjamin Romer wrote:
Move the chipsetready proc entry to sysfs under a new directory guest. This
entry is used by Unisys application software on the guest to acknowledge
completion of specific events for integration purposes, but these
On Tue, Jul 22, 2014 at 09:56:29AM -0400, Benjamin Romer wrote:
Move the /proc/visorchipset/parahotplug interface to sysfs under
/sys/devices/platform/visorchipset/guest/parahotplug.
The parahotplug interface is used to deal with recovery situations on s-Par
guest partitions. The command
This patch set:
changes ambiguous global names, such as error_flag to cxt1e1_error_flag
puts globals in header file to reduce externs used in c files as well as sparse
warnings
Jeff Oczek (2):
staging: cxt1e1: Prefix ambiguous variable names with 'cxt1e1_' for
clarity
staging: cxt1e1:
Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
linux.c:
drivers/staging/cxt1e1/linux.c:86:13: warning:
symbol 'cxt1e1_error_flag' was not declared. Should it be static?
drivers/staging/cxt1e1/linux.c:91:13: warning:
symbol 'cxt1e1_max_mru' was not declared. Should
Changed names of ambiguous sounding variable names as follows
error_flag - cxt1e1_error_flag
max_mtu_default - cxt1e1_max_mtu_default
max_txdesc_used - cxt1e1_max_txdesc_used
max_txdesc_default - cxt1e1_max_txdesc_default
max_rxdesc_used - cxt1e1_max_rxdesc_used
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return -ENOMEM from the kalloc error handling
case instead of 0.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/net/hyperv/netvsc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
A 'Missing a blank line after declarations' warning fixed by inserting
a blank line after struct pointer declaration.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/amplc_pc236.c |1 +
1 file changed, 1 insertion(+)
diff --git
Hi Martyn,
Thanks for your patience with me. I have a couple of questions for you:
0. I put the SBC with the right settings for Geographical addressing.
I did 2 tests by setting the board in each of the 2 slots available on
my rack and the geo address was detected as 0 in both the cases. This
52 matches
Mail list logo
