On Mon, Sep 22, 2014 at 10:00:55PM -0700, Dexuan Cui wrote:
v2: I added errno = 0; in the ioctl()
That does not belong in the changelog, put it below the --- line.
Also, you need a changelog description here, it can't be empty.
greg k-h
___
devel
On Sun, Sep 21, 2014 at 12:27:07AM +0100, Mike Roocroft wrote:
Fixed a coding style issue
Signed-off-by: Mike Roocroft mike.li...@btinternet.com
---
drivers/staging/skein/skein_block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Someone else already sent in this change,
On Mon, Sep 22, 2014 at 11:14:52PM -0700, Sorin Facaoaru wrote:
This patch fixes the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Sorin Facaoaru w...@sorin.cc
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
Someone
Reported-by: Joe Perches j...@perches.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 4b2ae49..b976c75
Reported-by: Joe Perches j...@perches.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index cd90831..0a927d2 100644
Reported-by: Joe Perches j...@perches.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index f5459ec..cd90831 100644
Some split lines are less than 80 chars if rejoined, so rejoin them.
Reported-by: Joe Perches j...@perches.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
-Original Message-
From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
ow...@vger.kernel.org] On Behalf Of Greg KH
Sent: Wednesday, September 24, 2014 14:32 PM
To: Dexuan Cui
Cc: linux-ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org;
o...@aepfle.de;
On Tue, Sep 23, 2014 at 02:07:17PM -0700, Joe Perches wrote:
On Tue, 2014-09-23 at 21:05 +0100, Mark Einon wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
checkpatch type modification you might consider:
Reduce logging line
Invent MMC_POWER_UNDEFINED to describe the initial host power_mode which
might be either off or turned on by an early driver such as BIOS or UEFI driver.
This lets the later mmc_power_off() do actual power-off things and power_mode
will be in a known state eventually.
Roger Tseng (2):
mmc:
Define new macro MMC_POWER_UNDEFINED for power_mode in struct mmc_ios.
It will also be set as the initial value of host-ios.power_mode in
mmc_start_host().
For hosts with MMC_CAP2_NO_PRESCAN_POWERUP, this makes the later
mmc_power_off() do real power-off things instead of NOP, and further
Set MMC_CAP2_NO_PRESCAN_POWERUP and MMC_CAP2_FULL_PWR_CYCLE for
rtsx_pci_sdmmc and rtsx_usb_sdmmc to reflect properties of Realtek
card reader hosts.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
drivers/mmc/host/rtsx_pci_sdmmc.c |1 +
drivers/mmc/host/rtsx_usb_sdmmc.c |1 +
2
On 24 September 2014 11:07, Roger Tseng rogera...@realtek.com wrote:
Define new macro MMC_POWER_UNDEFINED for power_mode in struct mmc_ios.
It will also be set as the initial value of host-ios.power_mode in
mmc_start_host().
For hosts with MMC_CAP2_NO_PRESCAN_POWERUP, this makes the later
On 24 September 2014 11:07, Roger Tseng rogera...@realtek.com wrote:
Set MMC_CAP2_NO_PRESCAN_POWERUP and MMC_CAP2_FULL_PWR_CYCLE for
rtsx_pci_sdmmc and rtsx_usb_sdmmc to reflect properties of Realtek
card reader hosts.
Signed-off-by: Roger Tseng rogera...@realtek.com
Thanks! Applied for
On Tue, Sep 23, 2014 at 09:22:08AM +0900, Daeseok Youn wrote:
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
On Wed, Sep 24, 2014 at 12:36:48PM +0300, Dan Carpenter wrote:
On Tue, Sep 23, 2014 at 09:22:08AM +0900, Daeseok Youn wrote:
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
static void dgap_release_remap(struct board_t *brd)
{
- release_mem_region(brd-membase, 0x20);
- release_mem_region(brd-membase + PCI_IO_OFFSET, 0x20);
- iounmap(brd-re_map_membase);
-
On Mon, Sep 22, 2014 at 08:58:14PM +0100, Mark Einon wrote:
static void et131x_rx_dma_memory_free(struct et131x_adapter *adapter)
{
u8 id;
- u32 index;
+ u32 ii;
Just use int i;. Making everything a u32 is a bad habbit and the
second 'i' character doesn't seem to stand for
On Wed, Sep 24, 2014 at 01:11:42PM +0300, Dan Carpenter wrote:
On Mon, Sep 22, 2014 at 08:58:14PM +0100, Mark Einon wrote:
static void et131x_rx_dma_memory_free(struct et131x_adapter *adapter)
{
u8 id;
- u32 index;
+ u32 ii;
Just use int i;. Making everything a u32 is a
Good Day,
We are village miners, we have AU Gold of 550kgs Dust/ Bars and 20,000 carats
of Rough Uncut Diamonds available ready and willing to sell to use the proceeds
to upgrade our mines by acquiring machinery ETC for increase in production. If
you are interested to do business with us,
On Wed, Sep 24, 2014 at 11:23:13AM +0100, Mark Einon wrote:
On Wed, Sep 24, 2014 at 01:11:42PM +0300, Dan Carpenter wrote:
On Mon, Sep 22, 2014 at 08:58:14PM +0100, Mark Einon wrote:
static void et131x_rx_dma_memory_free(struct et131x_adapter *adapter)
{
u8 id;
- u32 index;
+
From: Christoph Jaeger em...@christophjaeger.info
As these typedefs are only used once, there is no real need for them.
Signed-off-by: Christoph Jaeger em...@christophjaeger.info
---
drivers/staging/ozwpan/ozproto.h | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
This patch fixes the following sparse warnings:
drivers/staging/rtl8821ae/pci.c:52:4: warning: symbol '_rtl_mac_to_hwqueue' was
not declared. Should it be static?
drivers/staging/rtl8821ae/pci.c:365:6: warning: symbol
'rtl_pci_check_buddy_priv' was not declared. Should it be static?
On 09/22/2014 10:57 PM, Hui Zhu wrote:
The cause of this issue is when free memroy size is low and a lot of task is
trying to shrink the memory, the task that is killed by lowmemkiller cannot
get
CPU to exit itself.
Fix this issue with change the scheduling policy to SCHED_FIFO if a task's
Eliminate all checkpatch.pl warnings and checks from these files.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/periodic_work.h | 25 ++--
drivers/staging/unisys/visorutil/periodic_work.c | 155 +++
2 files changed, 83
This patch series addresses most of the checkpatch.pl warnings and checks
generated when run with the --strict option, in the include directory for the
Unisys drivers. Most of the issues were handled, with the exception of
CamelCase members of shared structs. These will be addressed in subsequent
Fix as many checkpatch.pl strict checks and warnings as possible, and fix
references to the renamed bus_device_info_init() function. The remaining
checks in this file are due to the names of members of structures defined in
another file. These will be corrected by subsequent patches.
Eliminate all checkpatch.pl strict warnings and checks from timskmod.h. Some of
these warnings were generated by a block of unused locking macros, so the
entire set of macros were removed.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/timskmod.h | 91
Remove the entire timskmodutils.h file as it had a lot of checkpatch.pl
strict warnings and checks, and nearly all of the functions were not used
anywhere.
The unisys_spar_platform variable was moved to timskmod.h. References to the
removed timskmodutils.h were switched to timskmod.h instead. The
Fix many of the checkpatch.pl strict warnings and checks generated. The
remaining strict checks require large-scale refactoring of structures, so
these will be fixed in subequent patches.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisqueue.h | 54
Fix all checkpatch.pl strict errors and checks. It was only a couple of
doubled blank lines.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uniklog.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include/uniklog.h
Fix as many checkpatch.pl strict warnings and checks as possible in uisutils.h,
as well as correcting references to renamed variables, structures, and
functions.
The remaining warnings are because of camel-cased members in structures defined
by other files. These will be corrected in subsequent
Remove a few double blank lines from uisthread.h to clean up all of the
checkpatch.pl output from this file.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/uisthread.h | 3 ---
1 file changed, 3 deletions(-)
diff --git
Fix all checkpatch.pl strict checks and warnings. The two typedefs were
removed and the doubled blank lines were corrected.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/guestlinuxdebug.h | 10 --
1 file changed, 4 insertions(+), 6
Gar. I hate to make you redo a lot of work but these need to be broken
up into one thing per patch. That rules is kind of vague so we
normally tell people to fix one type of checkpatch.pl warning at a time
as a simple way of explaining it.
But definitely fixing every checkpatch.pl warning in a
On Wed, Sep 24, 2014 at 11:56:19AM -0400, Benjamin Romer wrote:
+struct periodic_work *
+ visor_periodic_work_create(ulong jiffy_interval,
+struct workqueue_struct *workqueue,
+void (*workfunc)(void *),
+
On Wed, Sep 24, 2014 at 03:01:58PM +0300, Dan Carpenter wrote:
In vim you can just use the '*' key to search for a variable. The extra
i really needs to mean somethingi, it shouldn't just be there because
to work around a bad editor. Also there are lots of mii_ names in
this file so I'm
The for loop in this function increments two variables and has an unusual
starting index of 1 (not 0). Make it look more familiar.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 6 --
1 file changed, 4
Many of the functions and variables in the driver have been renamed and are now
more understandable, as well as defines added for various constants. Update /
remove some comments to reflect this.
Also many comments were unnecessary dialogue describing what is evident from
the code, or comments
On Wed, Sep 24, 2014 at 07:12:03PM +0300, Dan Carpenter wrote:
Gar. I hate to make you redo a lot of work but these need to be broken
up into one thing per patch. That rules is kind of vague so we
normally tell people to fix one type of checkpatch.pl warning at a time
as a simple way of
On Tue, Sep 23, 2014 at 07:12:09PM -0400, Elshad Mustafayev wrote:
Fixed a coding style issue.
Signed-off-by: Elshad Mustafayev elshad...@gmail.com
---
drivers/staging/android/binder.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Hi,
2014-09-24 18:42 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Wed, Sep 24, 2014 at 12:36:48PM +0300, Dan Carpenter wrote:
On Tue, Sep 23, 2014 at 09:22:08AM +0900, Daeseok Youn wrote:
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |1 +
Hi,
2014-09-24 18:45 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
static void dgap_release_remap(struct board_t *brd)
{
- release_mem_region(brd-membase, 0x20);
- release_mem_region(brd-membase + PCI_IO_OFFSET,
Declared cfg80211_infrastructure_mode method static to remove sparse warning
Signed-off-by: Rahul Garg rahul.lnm...@gmail.com
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
44 matches
Mail list logo
