[PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

Under high memory pressure and very high KVP R/W test pressure, the netlink recvfrom() may transiently return ENOBUFS to the daemon -- we found this during a 2-week stress test. We'd better not terminate the daemon on this failure, because a typical KVP user can re-try the R/W and hopefully it

Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

Dexuan Cui de...@microsoft.com writes: Under high memory pressure and very high KVP R/W test pressure, the netlink recvfrom() may transiently return ENOBUFS to the daemon -- we found this during a 2-week stress test. We'd better not terminate the daemon on this failure, because a typical KVP

RE: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

-Original Message- From: Vitaly Kuznetsov Sent: Wednesday, November 19, 2014 18:50 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; Haiyang Zhang

Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov Sent: Wednesday, November 19, 2014 18:50 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;

RE: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

-Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, November 19, 2014 20:41 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;

Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, November 19, 2014 20:41 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org;

RE: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

-Original Message- From: Vitaly Kuznetsov -- Vitaly OK, I can add this new check: (I'll send out the v2 tomorrow in case people have new comments) Thanks! --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -1770,8 +1770,15 @@ kvp_done:

Re: [PATCH] tools: hv: ignore ENOBUFS in the KVP daemon

Dexuan Cui de...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov -- Vitaly OK, I can add this new check: (I'll send out the v2 tomorrow in case people have new comments) Thanks! --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@

Re: [PATCH 03/10] staging: rtl8723au: rtw_put_snap23a(): Use put_unaligned to set protocol

Dan Carpenter dan.carpen...@oracle.com writes: On Mon, Nov 10, 2014 at 06:11:39PM -0500, jes.soren...@redhat.com wrote: diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c index 18a9f34..f8b1243 100644 ---

Re: [PATCH] staging: rtl8723au: fix sparse warning

Aleh Suprunovich b...@ahlamon.org writes: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol 'rtl8723a_EfusePgPacketRead' was not declared. Should it be static? Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current staging code. Before, it was available

[PATCH] staging:rtl8723au: fix sparse warning: incorrect type in assignment

Signed-off-by: Kinka Huang kinkabr...@gmail.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index 85d1eca..6c1a7fb 100644 ---

Re: [PATCH] staging:rtl8723au: fix sparse warning: incorrect type in assignment

Kinka Huang kinkabr...@gmail.com writes: Signed-off-by: Kinka Huang kinkabr...@gmail.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Eeeek, nice catch! Acked-by: Jes Sorensen jes.soren...@redhat.com diff --git

[PATCH v2 4/9] staging: panel: Use defined value or checking module params state

Avoid magic number and use a comparison with a defined value instead that checks whether module param has been set by the user to some value at loading time. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com --- v2: Don't introduce new macros for param value check

[PATCH v2 5/9] staging: panel: Start making module params read-only

Start decoupling module params from the actual device state, both for lcd and keypad, by keeping the params read-only and moving the device state to related structs. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com Acked-by: Willy Tarreau w...@1wt.eu --- drivers/staging/panel/panel.c | 35

[PATCH v2 7/9] staging: panel: Refactor LCD init code

Rework lcd_init method to make it a little bit more clear about the precedence of the params, move LCD geometry and pins layout to the LCD struct and thus make the LCD-related module params effectively read-only. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com ---

[PATCH v2 3/9] staging: panel: Remove magic numbers

Get rid of magic numbers indicating that the value of a module param is not set. Use a defined value instead. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com Acked-by: Willy Tarreau w...@1wt.eu --- drivers/staging/panel/panel.c | 22 -- 1 file changed, 12 insertions(+),

[PATCH v2 9/9] staging: panel: Move LCD-related state into struct lcd

Move more or less all LCD-related state into struct lcd in order to get better cohesion; use bool instead of int where it makes sense. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com Acked-by: Willy Tarreau w...@1wt.eu --- drivers/staging/panel/panel.c | 255

[PATCH v2 2/9] staging: panel: Call init function directly

Remove useless function and let the kernel call the actual init function directly. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com Acked-by: Willy Tarreau w...@1wt.eu --- drivers/staging/panel/panel.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH v2 8/9] staging: panel: Remove more magic number comparison

Use a defined value instead of magic number comparison for checking whether a module param value has been set. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com --- v2: Don't introduce new macros for param value check drivers/staging/panel/panel.c | 20 ++-- 1 file changed,

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote: Avoid magic number and use a comparison with a defined value instead that checks whether module param has been set by the user to some value at loading time. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com Acked-by: Willy

Re: [PATCH v2 6/9] staging: panel: Make two more module params read-only

On Wed, Nov 19, 2014 at 09:38:48PM +0100, Mariusz Gorski wrote: Make keypad_type and lcd_type module params read-only. This step also starts making it more clear what is the precedence of device params coming from different sources (device profile, runtime module param values etc).

Re: [PATCH v2 8/9] staging: panel: Remove more magic number comparison

On Wed, Nov 19, 2014 at 09:38:50PM +0100, Mariusz Gorski wrote: Use a defined value instead of magic number comparison for checking whether a module param value has been set. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com Acked-by: Willy Tarreau w...@1wt.eu

Re: [PATCH v2 7/9] staging: panel: Refactor LCD init code

On Wed, Nov 19, 2014 at 09:38:49PM +0100, Mariusz Gorski wrote: Rework lcd_init method to make it a little bit more clear about the precedence of the params, move LCD geometry and pins layout to the LCD struct and thus make the LCD-related module params effectively read-only. Signed-off-by:

Re: [PATCH v2 0/9] staging: panel: Refactor panel initialization

Hi Mariusz, On Wed, Nov 19, 2014 at 09:38:42PM +0100, Mariusz Gorski wrote: This set of patches focuses on making current initialization process easier to understand - especially it tries to emphasize what are the priorities of the params coming from different sources (Kconfig values, device

[PATCH RESEND] staging: skein: fixed sparse warnings related to static declarations

drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:100:5: warning: symbol

RE: [PATCH] hv: hv_fcopy: drop the obsolete message on transfer failure

-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of Dexuan Cui Sent: Tuesday, November 11, 2014 9:03 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org; o...@aepfle.de;

RE: [PATCH v2 2/2] Tools: hv: vssdaemon: skip all filesystems mounted readonly

-Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Monday, November 10, 2014 8:37 AM To: KY Srinivasan; Haiyang Zhang; Greg Kroah-Hartman Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Dexuan Cui Subject: [PATCH v2 2/2] Tools: hv:

RE: [PATCH v2 1/2] Tools: hv: vssdaemon: report freeze errors

-Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Monday, November 10, 2014 8:37 AM To: KY Srinivasan; Haiyang Zhang; Greg Kroah-Hartman Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Dexuan Cui Subject: [PATCH v2 1/2] Tools: hv:

[PATCH v2] tools: hv: ignore ENOBUFS and ENOMEM in the KVP daemon

Under high memory pressure and very high KVP R/W test pressure, the netlink recvfrom() may transiently return ENOBUFS to the daemon -- we found this during a 2-week stress test. We'd better not terminate the daemon on the failure, because a typical KVP user will re-try the R/W and hopefully it

Re: [PATCH] staging: fwserial: remove multiple blank lines

Hi Greg, 2014-11-11 15:40 GMT+08:00 Le Tan tamlokv...@gmail.com: This patch fixes the multiple blank lines issue complained by checkpatch.pl by removing useless blank lines. Signed-off-by: Le Tan tamlokv...@gmail.com --- drivers/staging/fwserial/fwserial.c | 3 --- 1 file changed, 3

RE: [PATCH] hv: hv_fcopy: drop the obsolete message on transfer failure

-Original Message- From: KY Srinivasan Sent: Thursday, November 20, 2014 6:59 AM diff --git a/drivers/hv/hv_fcopy.c b/drivers/hv/hv_fcopy.c index 23b2ce2..177122a 100644 --- a/drivers/hv/hv_fcopy.c +++ b/drivers/hv/hv_fcopy.c @@ -86,6 +86,15 @@ static void