On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote:
> Get rid of magic numbers in LCD commands and replace them with defined
> values, so that it's more obvious that the commands are doing.
>
it is not applying to next-20141205. is it based on staging-testing ?
thanks
sudip
> Signed-
On Fri, Dec 05, 2014 at 10:28:19PM +0100, Mariusz Gorski wrote:
> Get rid of magic numbers in LCD commands and replace them with defined
> values, so that it's more obvious that the commands are doing.
>
> Signed-off-by: Mariusz Gorski
> ---
> v2: Found and got rid of two more magic number usages
On Sat, Dec 06, 2014 at 01:46:52PM +0530, Sudip Mukherjee wrote:
> On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote:
> > Get rid of magic numbers in LCD commands and replace them with defined
> > values, so that it's more obvious that the commands are doing.
> >
> it is not applying
On Sat, Dec 06, 2014 at 01:51:12PM +0530, Sudip Mukherjee wrote:
> On Fri, Dec 05, 2014 at 10:28:19PM +0100, Mariusz Gorski wrote:
> > Get rid of magic numbers in LCD commands and replace them with defined
> > values, so that it's more obvious that the commands are doing.
> >
> > Signed-off-by: Ma
devendra.aaru wrote:
> You might consider not using camel case letters..
The purpose of patch 8 is to fix spacing errors across the entire file. The
camelcase names are fixed in later patches.
-- Ben
___
devel mailing list
de...@linuxdriverproject.org
First of all, these patches are *so* much better. Thank you very much!
On Fri, Dec 05, 2014 at 05:09:16PM -0500, Benjamin Romer wrote:
> Fix the declaration so it is a single line. Fix CamelCase parameter
> names:
>
> MajorDev => major_dev
In the original code there were two variables.
MajorDev
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, December 5, 2014 9:08 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com
> Subject: Re: [PATCH 1/1] Driv
Implement a clockevent device based on the timer support available on
Hyper-V.
In this version of the patch I have addressed Jason's review comments.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Jason Wang
---
arch/x86/include/uapi/asm/hyperv.h | 11 +
drivers/hv/hv.c|
On 2014/12/05, 3:41 PM, "Tristan Lelong" wrote:
>On Fri, Dec 05, 2014 at 01:27:23PM -0800, Greg KH wrote:
>> On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote:
>> > static ssize_t
>> > -fld_proc_hash_seq_write(struct file *file, const char *buffer,
>> > - size_t cou
On 2014/12/06, 12:16 AM, "Tristan Lelong" wrote:
>This patch replace the value '80' used in several files in the lustre
>source code
>with a define LUSTRE_MDT_MAXNAMELEN.
>
>This value is used in 4 different structures as the maximum len for a
>service name.
>According to the comments, these name
On Thu, Dec 04, 2014 at 09:54:29AM +, parths...@laer.in wrote:
> Hi again,
> Please note my new email parths...@laer.in . Also If you guys don't know
> there's a working source supplied by mediatek for mt7601. Please find the
> attached tarball. Also please apply this patch I mentioned about ea
On Sat, Dec 6, 2014 at 9:18 AM, Ben Romer wrote:
> devendra.aaru wrote:
>
>> You might consider not using camel case letters..
>
> The purpose of patch 8 is to fix spacing errors across the entire file. The
> camelcase names are fixed in later patches.
>
You are correct.
> -- Ben
___
Andreas,
On Sat, Dec 06, 2014 at 05:05:14PM +, Dilger, Andreas wrote:
> On 2014/12/05, 3:41 PM, "Tristan Lelong" wrote:
>
>
> Sorry, but I don't see where you get 80 from? fh_name is declared as a
> "const char *", and initialized in the declaration of fld_hash[]. I'd
> thought to reply t
On Sat, Dec 06, 2014 at 05:09:29PM +, Dilger, Andreas wrote:
> >
> >diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >index 74b4db9..7a55941 100644
> >--- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >+++ b/drivers/staging/lus
This patch replace the value '80' used in several files in the lustre source
code
with a define LUSTRE_MDT_MAXNAMELEN.
This value is used in 4 different structures as the maximum len for a service
name.
According to the comments, these names follow a convention which make it
possible
to use the
This patch fix a sparse warning in lustre sources
warning: incorrect type in argument 1 (different address spaces)
expected void [noderef] *to
got char *
This is done by adding the missing __user attribute on userland pointers inside
the LPROC_SEQ_FOPS like macros:
- LPROC_SEQ_FOPS
- LPR
On 2014-12-06 17:51, Greg Kroah-Hartman wrote:
On Thu, Dec 04, 2014 at 09:54:29AM +, parths...@laer.in wrote:
Hi again,
Please note my new email parths...@laer.in . Also If you guys don't
know
there's a working source supplied by mediatek for mt7601. Please find
the
attached tarball. Also
On Sun, Dec 07, 2014 at 04:38:16AM +, parths...@laer.in wrote:
> On 2014-12-06 17:51, Greg Kroah-Hartman wrote:
> >On Thu, Dec 04, 2014 at 09:54:29AM +, parths...@laer.in wrote:
> >>Hi again,
> >>Please note my new email parths...@laer.in . Also If you guys don't know
> >>there's a working
18 matches
Mail list logo
