Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

On Wed, Dec 31, 2014 at 09:40:13PM -0800, Joe Perches wrote: > On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote: > > On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote: > > > This patch fixes warnings/errors raised by checkpatch.pl relating to > > > whitespace > > > in r8192U_

Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote: > On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote: > > This patch fixes warnings/errors raised by checkpatch.pl relating to > > whitespace > > in r8192U_dm.c and additionally it removes inconsistent whitespace > > throughout

Re: [PATCH v2 3/4] staging: rtl8192u: remove redundant code

On Thu, Jan 01, 2015 at 10:19:56AM +0530, Sudip Mukherjee wrote: > On Wed, Dec 31, 2014 at 09:10:42PM +, Lorenzo Stoakes wrote: > > This patch fixes warnings/errors raised by checkpatch.pl relating to > > redundant > > code in r8192U_dm.c. > > > > Signed-off-by: Lorenzo Stoakes > > --- > >

Re: [PATCH v2 3/4] staging: rtl8192u: remove redundant code

On Wed, Dec 31, 2014 at 09:10:42PM +, Lorenzo Stoakes wrote: > This patch fixes warnings/errors raised by checkpatch.pl relating to redundant > code in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 176 > +-- >

Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote: > This patch fixes warnings/errors raised by checkpatch.pl relating to > whitespace > in r8192U_dm.c and additionally it removes inconsistent whitespace > throughout. > > Additionally some 0x00... padding has been added for alignmen

[PATCH v3 2/4] staging: rtl8192u: fix whitespace

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. Additionally some 0x00... padding has been added for alignment to the edca_setting_* variables. Signed-off-by: Lorenzo Stoakes --- drive

Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

On 31 December 2014 at 21:20, Joe Perches wrote: > It'd be nicer to use the same form and indentation > for both entries. > > Probably be nicer to use: > > static u32 edca_setting_DL[HT_IOT_PEER_MAX] = { > 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f > }; > static u32 edca_s

Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

On Wed, 2014-12-31 at 21:10 +, Lorenzo Stoakes wrote: > This patch fixes warnings/errors raised by checkpatch.pl relating to > whitespace > in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. [] > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c > b/drivers/staging

[PATCH v2 2/4] staging: rtl8192u: fix whitespace

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1606 +- 1 file changed, 625 in

[PATCH v2 4/4] staging: rtl8192u: Refactor heavy nesting

This patch fixes warnings raised by checkpatch.pl relating to heavily indented lines in r8192U_dm.c. It refactors a couple of else if cases to achieve the same outcome indented by one fewer tab. It additionally updateds comment positioning to be consistent across these cases. Signed-off-by: Lorenz

[PATCH v2 3/4] staging: rtl8192u: remove redundant code

This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 176 +-- 1 file changed, 84 insertions(+), 92 deletions(-) diff --git a/drivers/staging/r

[PATCH v2 1/4] staging: rtl8192u: fix comments

This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c and cleans up existing ANSI C comments. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 811 ++- 1 file changed, 420 insertions(+), 391 deletio

Re: [PATCH 1/4] staging: rtl8192u: fix comments

On 31 December 2014 at 19:23, Jeremiah Mahler wrote: > But this change is not related to C99 comments and you didn't > explain why this change was made in your log message. > It should probably be in a separate patch. Absolutely, I am currently fixing this and checking for any other instances whe

Re: [PATCH 1/4] staging: rtl8192u: fix comments

On 12/31, Lorenzo Stoakes wrote: > On 31 December 2014 at 19:00, Konrad Zapalowicz > wrote: > > > > You also fix the line length here which shall be the subject of a > > separate patch as this is not C99 comments related change. > > > > Apologies - I missed this, will prepare a v2 with this sepa

Re: [PATCH 1/4] staging: rtl8192u: fix comments

Lorenzo, On Wed, Dec 31, 2014 at 06:42:53PM +, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 841 > ++---

Re: [PATCH 1/4] staging: rtl8192u: fix comments

On 31 December 2014 at 19:00, Konrad Zapalowicz wrote: > > You also fix the line length here which shall be the subject of a > separate patch as this is not C99 comments related change. > Apologies - I missed this, will prepare a v2 with this separated out into a different patch. Relatedly, the i

Re: [PATCH 1/4] staging: rtl8192u: fix comments

On 12/31, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 841 > ++- > 1 file changed, 432 insertions(+

[PATCH v3] staging: lustre: libcfs: fix sparse warnings about static declaration

Fixes the following sparse warnings: drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: symbol 'libcfs_arch_init' was not declared. Should it be static? drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning: symbol 'libcfs_arch_cleanup' was not declared. Sho

Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

On Wed, Dec 31, 2014 at 11:40:29AM +0100, Konrad Zapalowicz wrote: > This lines are way too long. You should break the commit message line > around 72nd column so that it looks nice when emailed. > > You can also omit the filename from the topic line as this is already in > the diff. Thanks for t

[PATCH 2/4] staging: rtl8192u: fix whitespace

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1409 +- 1 file changed, 530 insertions(+), 879 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 3/4] staging: rtl8192u: remove redundant code

This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 160 +-- 1 file changed, 77 insertions(+), 83 deletions(-) diff --git a/drivers/staging/r

[PATCH 4/4] staging: rtl8192u: Refactor heavy nesting

This patch fixes warnings raised by checkpatch.pl relating to heavily indented lines in r8192U_dm.c. It refactors a couple of else if cases to achieve the same outcome indented by one fewer tab. It additionally updateds comment positioning to be consistent across these cases. Signed-off-by: Lorenz

[PATCH 1/4] staging: rtl8192u: fix comments

This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 841 ++- 1 file changed, 432 insertions(+), 409 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 2/3] staging: sm7xxfb: update TODO file

update the email addresses in the TODO file, also update the final destination of this driver. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/TODO | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm7xxfb/TODO b/drivers/staging/sm7xxfb/TODO

[PATCH 1/3] Revert "staging: sm7xxfb: remove driver"

This reverts commit "dc93c85235efa5201e9a3c116bc3fbd1afc1a182" Signed-off-by: Sudip Mukherjee --- Hi Greg K-H With reference to our discussion at https://lkml.org/lkml/2014/11/22/54 , now I have the hardware and I will be working on the code along with Teddy Wang. drivers/staging/Kconfig

[PATCH 3/3] MAINTAINERS: update for SM7XX driver

add myself and Teddy Wang as the Maintainer of the SM7XX FRAME BUFFER DRIVER. Signed-off-by: Sudip Mukherjee --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6e18e65..4ffe882 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9178,6 +9178,14

[PATCH] staging: xgifb: remove unnecessary check

the check for htotal and vtotal is not required as we have already checked for them and returned -EINVAL if any of them is zero. Signed-off-by: Sudip Mukherjee --- drivers/staging/xgifb/XGI_main_26.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/XGI_ma

Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

On 12/31, Serguey Parkhomovsky wrote: > Fixes the following sparse warnings: > > drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: > symbol 'libcfs_arch_init' was not declared. Should it be static? > drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning: >

[PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

Fixes the following sparse warnings: drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: symbol 'libcfs_arch_init' was not declared. Should it be static? drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning: symbol 'libcfs_arch_cleanup' was not declared. Sho

[PATCH 25/29] staging: fbtft: add fb_upd161704 driver

This commit adds the fb_upd161704 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig| 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_upd161704.c | 206 ++

[PATCH 23/29] staging: fbtft: add fb_tls8204 driver

This commit adds the fb_tls8204 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_tls8204.c | 176 +

[PATCH 12/29] staging: fbtft: add fb_ili9486 driver

This commit adds the fb_ili9486 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ili9486.c | 121 +

[PATCH 21/29] staging: fbtft: add fb_st7735r driver

This commit adds the fb_st7735r driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_st7735r.c | 195 +

[PATCH 15/29] staging: fbtft: add fb_s6d02a1 driver

This commit adds the fb_s6d02a1 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_s6d02a1.c | 168 +

[PATCH 16/29] staging: fbtft: add fb_s6d1121 driver

This commit adds the fb_s6d1121 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_s6d1121.c | 208 +

[PATCH 17/29] staging: fbtft: add fb_ssd1289 driver

This commit adds the fb_ssd1289 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ssd1289.c | 206 +

[PATCH 26/29] staging: fbtft: add fb_watterott driver

This commit adds the fb_watterott driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig| 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_watterott.c | 324 ++

[PATCH 29/29] staging: fbtft: add NOTES file

Add a NOTES file that documents which version of the original fbtft was used, and how the import was done. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/NOTES | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 drivers/staging/fbtft/NOTES diff --git a/drivers/staging/fbt

[PATCH 22/29] staging: fbtft: add fb_tinylcd driver

This commit adds the fb_tinylcd driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_tinylcd.c | 124 +

[PATCH 18/29] staging: fbtft: add fb_ssd1306 driver

This commit adds the fb_ssd1306 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ssd1306.c | 229 ++

[PATCH 20/29] staging: fbtft: add fb_ssd1351 driver

This commit adds the fb_ssd1351 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ssd1351.c | 258 ++

[PATCH 24/29] staging: fbtft: add fb_uc1701 driver

This commit adds the fb_uc1701 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile| 1 + drivers/staging/fbtft/fb_uc1701.c | 210 +

[PATCH 27/29] staging: fbtft: add flexfb driver

This commit adds the flexfb driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/flexfb.c | 593 + 3 files

[PATCH 28/29] staging: fbtft: add fbtft_device driver

This commit adds the fbtft_device driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig|4 + drivers/staging/fbtft/Makefile |3 + drivers/staging/fbtft/fbtft_device.c | 1444 +++

[PATCH 19/29] staging: fbtft: add fb_ssd1331 driver

This commit adds the fb_ssd1331 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ssd1331.c | 205 +

[PATCH 14/29] staging: fbtft: add fb_ra8875 driver

This commit adds the fb_ra8875 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 + drivers/staging/fbtft/Makefile| 1 + drivers/staging/fbtft/fb_ra8875.c | 331 ++

[PATCH 13/29] staging: fbtft: add fb_pcd8544 driver

This commit adds the fb_pcd8544 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_pcd8544.c | 177 +

[PATCH 08/29] staging: fbtft: add fb_ili9325 driver

This commit adds the fb_ili9325 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ili9325.c | 291 ++

[PATCH 11/29] staging: fbtft: add fb_ili9481 driver

This commit adds the fb_ili9481 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ili9481.c | 117 +

[PATCH 10/29] staging: fbtft: add fb_ili9341 driver

This commit adds the fb_ili9341 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ili9341.c | 179 +

[PATCH 09/29] staging: fbtft: add fb_ili9340 driver

This commit adds the fb_ili9340 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ili9340.c | 163 +

[PATCH 05/29] staging: fbtft: add fb_hx8347d driver

This commit adds the fb_hx8347d driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_hx8347d.c | 181 +

[PATCH 03/29] staging: fbtft: add fb_bd663474 driver

This commit adds the fb_bd663474 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_bd663474.c | 193 +

[PATCH 01/29] staging: fbtft: core support

This commit adds the core fbtft framework from https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/Kconfig |2 + drivers/staging/Makefile|1 + drivers/staging/fbtft/Kconfig |9 + drivers/staging/fbtft/Makefile |3

[PATCH 06/29] staging: fbtft: add fb_hx8353d driver

This commit adds the fb_hx8353d driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 ++ drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_hx8353d.c | 166 +

[PATCH 07/29] staging: fbtft: add fb_ili9320 driver

This commit adds the fb_ili9320 driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ili9320.c | 234 ++

[PATCH 04/29] staging: fbtft: add fb_hx8340bn driver

This commit adds the fb_hx8340bn driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_hx8340bn.c | 229 ++

[PATCH 00/29] staging: add drivers from the fbtft project

Hello Greg, Here is a proposal to include in the staging tree the drivers from the fbtft project at https://github.com/notro/fbtft. This project contains a number of drivers small TFT LCD display modules, which are not otherwise supported by the Linux kernel. This set of drivers appears to be quit

[PATCH 02/29] staging: fbtft: add fb_agm1264k-fl driver

This commit adds the fb_agm1264k-fl driver from the fbtft project at https://github.com/notro/fbtft. Signed-off-by: Thomas Petazzoni --- drivers/staging/fbtft/Kconfig | 6 + drivers/staging/fbtft/Makefile | 3 + drivers/staging/fbtft/fb_agm1264k-fl.c | 462 ++