[PATCH] staging: slicoss: remove slic_spinlock wrapper

2015-05-11 Thread David Matlack
As per TODO. This commit introduces no functional changes. Signed-off-by: David Matlack --- drivers/staging/slicoss/TODO | 1 - drivers/staging/slicoss/slic.h| 19 +++--- drivers/staging/slicoss/slicoss.c | 125 ++ 3 files changed, 65 insertions(+)

[PATCH V6 net-next 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

2015-05-11 Thread K. Y. Srinivasan
Based on the information given to this driver (via the xmit_more skb flag), we can defer signaling the host if more packets are on the way. This will help make the host more efficient since it can potentially process a larger batch of packets. Implement this optimization. Signed-off-by: K. Y. Srin

RE: [PATCH] staging: comedi: ni_mio_common: fix build warning

2015-05-11 Thread Hartley Sweeten
On Monday, May 11, 2015 12:04 PM, Ian Abbott wrote: >> >> Cc: Ian Abbott > > Minor niggle: that email address is malformed (comma instead of dot). I noticed that when I got a bounce. Fat fingered it, need more coffee... Thanks, Hartley ___ devel maili

Re: [PATCH] staging: comedi: ni_mio_common: fix build warning

2015-05-11 Thread Ian Abbott
On 11/05/15 18:22, H Hartley Sweeten wrote: The kbuild test robot detected a build warning causes by commit f878071a. drivers/staging/comedi/drivers/ni_mio_common.c:2274:34: warning: right-hand operand of comma expression has no effect [-Wunused-value] That line should have been terminat

[PATCH 1/1] Drivers: hv: balloon: Enable dynamic memory protocol negotiation with Windows 10 hosts

2015-05-11 Thread alexng
From: Alex Ng This enables dynamic protocol support on Windows 10 Hyper-V hosts. If the host does not support Windows 10 protocol, then it falls back to previous versions. The change allows guests on Windows 10 Hyper-V hosts to hot-add memory even when dynamic memory is not enabled on the gues

[PATCH] staging: comedi: ni_mio_common: fix build warning

2015-05-11 Thread H Hartley Sweeten
The kbuild test robot detected a build warning causes by commit f878071a. >> drivers/staging/comedi/drivers/ni_mio_common.c:2274:34: warning: right-hand operand of comma expression has no effect [-Wunused-value] That line should have been terminated by ';' and the following line removed. Not

RE: [PATCH 000/107] staging: comedi: tidy up ni_stc.h

2015-05-11 Thread Hartley Sweeten
On Saturday, May 09, 2015 10:07 AM, Greg KH wrote: > On Fri, May 01, 2015 at 02:58:25PM -0700, H Hartley Sweeten wrote: >> The ni_stc.h header contains the DAQ-STC and board specific register >> information used by ni_mio_common.c to provide the "guts" for the >> National Instruments MIO drivers ni

Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

2015-05-11 Thread David Miller
From: KY Srinivasan Date: Mon, 11 May 2015 08:59:53 + > > >> -Original Message- >> From: Joe Perches [mailto:j...@perches.com] >> Sent: Sunday, May 10, 2015 10:58 PM >> To: KY Srinivasan >> Cc: da...@davemloft.net; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org; de...@linu

Re: [PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

2015-05-11 Thread Don Zickus
On Sat, May 09, 2015 at 12:19:28PM +0300, Dan Carpenter wrote: > On Fri, May 08, 2015 at 04:07:03PM +0300, Dan Carpenter wrote: > > > > > > This function leaks hdr_info on later error paths. > > > > Never mind. I'm wrong. Sorry for the noise. > > > > To be honest, I think I was right original

Re: [PATCH 125/141] staging: unisys: Convert cmd functions to visor_device

2015-05-11 Thread Don Zickus
On Sat, May 09, 2015 at 12:06:32PM +0300, Dan Carpenter wrote: > On Sat, May 09, 2015 at 12:05:19PM +0300, Dan Carpenter wrote: > > On Sat, May 09, 2015 at 12:01:54PM +0300, Dan Carpenter wrote: > > > On Tue, May 05, 2015 at 06:37:42PM -0400, Benjamin Romer wrote: > > > > From: Don Zickus > > > >

Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param()

2015-05-11 Thread Dan Carpenter
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote: > + if (info_element->len >= 4 && > + info_element->data[0] == 0x00 && info_element->data[1] == 0x50 && > + info_element->data[2] == 0xf2 && info_element->data[3] == 0x01) { This if statement was actually easi

Re: [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max

2015-05-11 Thread Dan Carpenter
On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote: > Warninig is printed if precision is lost - it can't happen at moment as > all get_key implementations return either -1 or small buffers. > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtllib_wx.c | 5 ++

Re: [PATCH] staging: lustre: remove unused variable

2015-05-11 Thread Drokin, Oleg
Hello! On May 11, 2015, at 7:43 AM, Sudip Mukherjee wrote: > On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote: >> On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote: >>> - if (set->set_pga) { >>> - int len = set->set_oabufs * sizeof(*set->set_pga); >>> + if

Re: [PATCH] staging: panel: fix stackdump

2015-05-11 Thread Willy Tarreau
On Mon, May 11, 2015 at 04:42:19PM +0530, Sudip Mukherjee wrote: > if we load the module, unload and then again try to load the module, we > will get a stackdump. In the module_exit function we are unregistering > the device and releasing the parport. So when we reach the detach > function parport

Re: [PATCH] staging: lustre: remove unused variable

2015-05-11 Thread Sudip Mukherjee
On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote: > On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote: > > - if (set->set_pga) { > > - int len = set->set_oabufs * sizeof(*set->set_pga); > > + if (set->set_pga) > > OBD_FREE_LARGE(set->set_pga, len

Re: [PATCH] staging: lustre: remove unused variable

2015-05-11 Thread Dan Carpenter
On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote: > there variables were not used anywhere and was showing as build warning. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/lustre/lustre/lov/lov_request.c | 4 +--- > drivers/staging/lustre/lustre/obdclass/acl.c| 1 -

[PATCH] staging: panel: fix stackdump

2015-05-11 Thread Sudip Mukherjee
if we load the module, unload and then again try to load the module, we will get a stackdump. In the module_exit function we are unregistering the device and releasing the parport. So when we reach the detach function parport is already null and the unregister_reboot_notifier() is never called. Whe

[PATCH] staging: lustre: remove unused variable

2015-05-11 Thread Sudip Mukherjee
there variables were not used anywhere and was showing as build warning. Signed-off-by: Sudip Mukherjee --- drivers/staging/lustre/lustre/lov/lov_request.c | 4 +--- drivers/staging/lustre/lustre/obdclass/acl.c| 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/stagi

Re: Separating a driver into dependent models

2015-05-11 Thread Dan Carpenter
Yeah. This question is too broad. Every sub directory under drivers/ has a bunch of shared code and a bunch of hardware specific code. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/m

Separating a driver into dependent models

2015-05-11 Thread Josef Holzmayr
Hello, I’m currently looking into creating a driver for a family of fields interfaces that share a common hardware connector implementation. (http://www.anybus.com/products/abcc30.shtml). By the looks of it, I think it would make sense to separate the driver into a kind of „hardware interface“

Re: [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed

2015-05-11 Thread Christoph Hellwig
On Fri, Apr 24, 2015 at 05:23:23PM -0700, K. Y. Srinivasan wrote: > Set the SRB flags correctly when there is no data transfer. Looks good, Reviewed-by: Christoph Hellwig ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverp

RE: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host

2015-05-11 Thread KY Srinivasan
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Sunday, May 10, 2015 10:58 PM > To: KY Srinivasan > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@red

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-11 Thread Dan Carpenter
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: > Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY > checkpatch.pl warning. > It will prevent accidential "Fix" to ether_addr_copy(). > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtllib_rx

staging: unisys:

2015-05-11 Thread Valentin Rothberg
Hi Erik, your commit 53490b545cb0 ("staging: unisys: move periodic_work.c into the visorbus directory") is in today's linux-next tree (i.e., next-20150511). The commit removes the Kconfig option UNISYS_VISORUTIL but leaves one select untouched turning it into a nop, see: drivers

Re: [PATCH v2] staging: unisys: remove unused functions

2015-05-11 Thread Sudip Mukherjee
On Sun, May 10, 2015 at 03:01:30PM +0200, Greg Kroah-Hartman wrote: > On Fri, May 08, 2015 at 01:06:19PM +0530, Sudip Mukherjee wrote: > > these functions were just defined and never used. after removing the > > functions the variable visorchipset_cache_buffers_in_use is becoming > > unused, so rem