Re: My new email + some notes on mt7601

2015-05-24 Thread Stanislaw Gruszka
On Sat, May 23, 2015 at 05:15:04AM +, parths...@laer.in wrote: Let's let the existing rt2x00 driver developers weigh in here. It might just be a matter of adding support for the new device to the existing driver, and if so, we don't want to add a whole new, horrible vendor driver to

Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static

2015-05-24 Thread Jes Sorensen
tolga ceylan tolga.cey...@gmail.com writes: On 05/15/2015 09:22 PM, Tolga Ceylan wrote: visorchipset_file_init() and visorchipset_file_cleanup() functions do not seem to be used from anywhere else and now are declared as static. Sparse emitted not declared warnings for these two functions.

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-24 Thread Haggai Eran
On 24 May 2015 at 00:16, Larry Finger larry.fin...@lwfinger.net wrote: The driver is reporting a warning at kernel/time/timer.c:1096 due to calling del_timer_sync() while in interrupt mode. Such warnings are fixed by calling del_timer() instead. Signed-off-by: Larry Finger

Re: [PATCH 1/1] Drivers: hv: vmbus:Update preferred vmbus protocol version to windows 10.

2015-05-24 Thread Greg KH
On Fri, May 15, 2015 at 05:26:40PM -0700, K. Y. Srinivasan wrote: From: keith.ma...@microsoft.com keith.ma...@microsoft.com That's not a valid From: name that matches the signed-off-by line below :( Add support for Windows 10. Signed-off-by: Keith Mange keith.ma...@microsoft.com

Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static

2015-05-24 Thread Greg Kroah-Hartman
On Fri, May 15, 2015 at 09:22:21PM -0700, Tolga Ceylan wrote: visorchipset_file_init() and visorchipset_file_cleanup() functions do not seem to be used from anywhere else and now are declared as static. Sparse emitted not declared warnings for these two functions. Signed-off-by: Tolga

Re: [PATCH] staging: unisys: remove braces from single statement blocks

2015-05-24 Thread Greg KH
On Sun, May 17, 2015 at 03:46:36PM -0700, Isaac Assegai wrote: Remove the braces to satisfy this checkpatch warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Isaac Assegai isaac.a.trav...@gmail.com --- drivers/staging/unisys/virthba/virthba.c | 6

Re: [PATCH v3 1/2] staging: wilc1000: Add SDIO/SPI 802.11 driver

2015-05-24 Thread Greg KH
On Mon, May 11, 2015 at 02:30:56PM +0900, Johnny Kim wrote: This driver is for the wilc1000 which is a single chip IEEE 802.11 b/g/n device. The driver works together with cfg80211, which is the kernel side of configuration management for wireless devices because the wilc1000 chipset is

Re: [PATCH 13/44] staging: unisys: Move files out of common-spar

2015-05-24 Thread Greg KH
On Wed, May 13, 2015 at 01:22:07PM -0400, Benjamin Romer wrote: From: David Kershner david.kersh...@unisys.com Move last three files out of common-spar iochannel.h -- include (will be used by visorhba and visornic) version.h -- moved to include controlvmcompletionstatus.h -- moved to

[PATCH 1/1] staging: fwserial: fix resource leak

2015-05-24 Thread Vladimirs Ambrosovs
From: Vladimirs Ambrosovs rodriguez.twis...@gmail.com This patch fixes the leak, which was present in fwserial driver in the init function. in case the tty driver allocation failed the function returned error, leaving debugfs entry in the filesystem. To fix the issue additional error label was

Re: [PATCH] staging : comedi/drivers/pcl*.c: coding style fixes

2015-05-24 Thread Greg Kroah-Hartman
On Sun, May 24, 2015 at 12:42:43PM -0700, Matthew Needes wrote: pcl812.c / pcl816.c: Fixed indentation errors. Fixed lines exceeding 80 columns, spelling errors. That's multiple things in the same patch, please do this in separate patches, each one only doing one thing each.

Re: [PATCH v2] staging: comedi: fix coding style issues

2015-05-24 Thread Greg KH
On Wed, May 20, 2015 at 02:54:16PM +, Geliang Tang wrote: On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote: On 16/05/15 05:16, Geliang Tang wrote: 1) Fixed an error found by checkpatch.pl. ERROR: space required after that ',' (ctx:VxV) ./drivers/ni_mio_common.c:3764

Re: [PATCH 32/44 V2] staging: unisys: Move channel creation up the stack

2015-05-24 Thread Greg KH
On Mon, May 18, 2015 at 11:23:05AM -0400, Don Zickus wrote: Instead of creating a channel struct to temporarily hold the channel info and passing it through multiple functions until the device is created, just create the channel from the start. This allows us to remove the channel_info

[PATCH 1/1] staging: fwserial: fix resource leak

2015-05-24 Thread Vladimirs Ambrosovs
From: Vladimirs Ambrosovs rodriguez.twis...@gmail.com This patch fixes the leak, which was present in fwserial driver in the init function. in case the tty driver allocation failed the function returned error, leaving debugfs entry in the filesystem. To fix the issue additional error label was

[PATCH] staging : comedi/drivers/pcl*.c: coding style fixes

2015-05-24 Thread Matthew Needes
pcl812.c / pcl816.c: Fixed indentation errors. Fixed lines exceeding 80 columns, spelling errors. Verified code compiles. Signed-off-by: Matthew Needes mnee...@gmail.com --- drivers/staging/comedi/drivers/pcl812.c | 10 +- drivers/staging/comedi/drivers/pcl816.c | 2 +- 2

Re: [PATCH 1/4] ozwpan: Use proper check to prevent heap overflow

2015-05-24 Thread Greg Kroah-Hartman
On Wed, May 13, 2015 at 08:58:17PM +0200, Jason A. Donenfeld wrote: Since elt-length is a u8, we can make this variable a u8. Then we can do proper bounds checking more easily. Without this, a potentially negative value is passed to the memcpy inside oz_hcd_get_desc_cnf, resulting in a

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-24 Thread Larry Finger
On 05/24/2015 02:03 PM, Haggai Eran wrote: On 24 May 2015 at 00:16, Larry Finger larry.fin...@lwfinger.net wrote: The driver is reporting a warning at kernel/time/timer.c:1096 due to calling del_timer_sync() while in interrupt mode. Such warnings are fixed by calling del_timer() instead.

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-24 Thread Sudip Mukherjee
I haven't been using kernel v4.1 so I haven't seen this warning, but looking at the code it seems to originate from the two recent patches to remove _cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1] that changes del_timer_sync back to del_timer in more places.

Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

2015-05-24 Thread Sudip Mukherjee
On Sat, May 23, 2015 at 07:53:28PM -0700, tolga ceylan wrote: On 05/12/2015 08:55 PM, Tolga Ceylan wrote: snip I haven't gotten a response for this patch. Just checking back. no response means no one is having anything to say about it. Final say will be Greg's when he reviews that when he