On Wed, May 27, 2015 at 01:19:57AM +0300, Vladimirs Ambrosovs wrote:
@@ -685,15 +684,14 @@ static int iio_dummy_remove(int index)
/* Buffered capture related cleanup */
iio_simple_dummy_unconfigure_buffer(indio_dev);
- ret = iio_simple_dummy_events_unregister(indio_dev);
-
Delare request_cache variable as static. It is only used by
drivers/staging/lustre/lustre/ptlrpc/client.c, and its naming is common
which will lead to namespace pollution.
Signed-off-by: Simon Guo wei.guo.si...@gmail.com
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
1 file changed, 1
On Wed, May 27, 2015 at 11:37:19AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 01:29:31PM +0530, Sudip Mukherjee wrote:
tested again.
strange behaviour.
if i send your patch to checkpatch from mutt via pipe I am getting these
errors but if i save your patch to a file and then
KY Srinivasan k...@microsoft.com writes:
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Thursday, May 21, 2015 9:22 AM
To: de...@linuxdriverproject.org
Cc: KY Srinivasan; Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui;
Ingo Molnar; Paul E.
Am Mittwoch, 27. Mai 2015, 07:00:54 schrieb Shailendra Verma:
Fix spelling error in comment in function tegra_nvec_remove.
Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com
Acked-by: Marc Dietrich marvi...@gmx.de
---
drivers/staging/nvec/nvec.c |2 +-
1 file changed, 1
On Wed, May 27, 2015 at 01:19:58AM +0300, Vladimirs Ambrosovs wrote:
Check for zero was added to the module parameter instances to
avoid the allocation of array of zero values. Although it is a valid call,
we don't want to allocate ZERO_SIZE_PTR, so need to disallow this case.
The type of
Works for me. I don't know what's going wrong, but it seems some kind
of corruption on your end.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, May 27, 2015 at 11:59:21AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote:
As suggested by Sudip this patch removes the redundant 1360x768@60
option from the fb_videomode struct array.
this can be in the comments but should not be
On Wed, May 27, 2015 at 01:29:31PM +0530, Sudip Mukherjee wrote:
tested again.
strange behaviour.
if i send your patch to checkpatch from mutt via pipe I am getting these
errors but if i save your patch to a file and then apply checkpatch to
that file there is no error. This is the first time
Warnings reported by sparse:
drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: warning: symbol
'ptlrpc_ping' was not declared. Should it be static?
drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6: warning: symbol
'ptlrpc_update_next_ping' was not declared. Should it be static?
On Wed, May 27, 2015 at 05:38:42AM -0700, gre...@linuxfoundation.org wrote:
On Wed, May 27, 2015 at 11:49:47AM +0530, Sudip Mukherjee wrote:
May i know whats wrong with the patch ? I am able to apply it without
any issue.
ERROR: patch seems to be corrupt (line wrapped?)
#74: FILE:
On Tue, May 26, 2015 at 10:35:57AM +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 12:22:25PM +, Harisangam, Sharvari (S.) wrote:
Modified the if-else statements to remove unnecessary comparisons.
This change was detected with the help of coccinelle tool
Signed-off-by:
On Wed, May 27, 2015 at 11:49:47AM +0530, Sudip Mukherjee wrote:
On Wed, May 27, 2015 at 05:56:27AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath
Maybe the explanation should more like Make functions that are not used
in other files static, rather than just silencing a tool.
julia
On Wed, 27 May 2015, Marcus Folkesson wrote:
Warnings reported by sparse:
drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: warning: symbol
'ptlrpc_ping'
From: K. Y. Srinivasan k...@microsoft.com
Date: Tue, 26 May 2015 16:21:09 -0700
The current algorithm for deciding on the number of VRSS channels is
not optimal since we open up the min of number of CPUs online and the
number of VRSS channels the host is offering. So on a 32 VCPU guest
we
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, May 27, 2015 11:13 AM
To: KY Srinivasan
Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
Subject: Re:
The current algorithm for deciding on the number of VRSS channels is
not optimal since we open up the min of number of CPUs online and the
number of VRSS channels the host is offering. So on a 32 VCPU guest
we could potentially open 32 VRSS subchannels. Experimentation has
shown that it is best to
On Wed, May 27, 2015 at 07:02:51PM +0300, Dan Carpenter wrote:
Hello Don Zickus,
This is a semi-automatic email about new static checker warnings.
The patch 3032aeddd85e: staging: unisys: Convert bus functions to
pass bus_info pointer around from May 13, 2015, leads to the
following
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Wednesday, May 27, 2015 8:06 AM
To: KY Srinivasan
Cc: Vitaly Kuznetsov; Radim Krčmář; Peter Zijlstra; Haiyang Zhang; Rafael J.
Wysocki; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
Thomas
Hello Don Zickus,
This is a semi-automatic email about new static checker warnings.
The patch 3032aeddd85e: staging: unisys: Convert bus functions to
pass bus_info pointer around from May 13, 2015, leads to the
following Smatch complaint:
drivers/staging/unisys/visorbus/visorchipset.c:971
is against 4.0-rc5 (localversion-next is -next-20150527)
Signed-off-by: Nicholas Mc Guire hof...@osadl.org
---
As there is no documentation of the intended timeout it might be wrong
to convert it with msecs_to_jiffies - so someone that knows this driver
needs to check on the actual value - but in any
On Wed, May 27, 2015 at 02:37:14PM +, KY Srinivasan wrote:
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, May 27, 2015 2:15 AM
To: KY Srinivasan
Cc: de...@linuxdriverproject.org; Haiyang Zhang; linux-
ker...@vger.kernel.org;
On Wed, May 27, 2015 at 03:01:37PM +, Simmons, James A. wrote:
On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote:
@@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
if (nalloc * sizeof(*ifr) PAGE_CACHE_SIZE) {
toobig = 1;
This patch fix 2 spelling typos in printk within gdm72xx.
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/gdm72xx/gdm_wimax.c | 2 +-
drivers/staging/gdm72xx/netlink_k.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On Wed, May 27, 2015 at 04:47:56PM +0200, Marcus Folkesson wrote:
Warnings reported by sparse:
drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5:
warning: symbol 'ptlrpc_ping' was not declared. Should it be static?
drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6:
warning: symbol
Warnings reported by sparse:
drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5:
warning: symbol 'ptlrpc_ping' was not declared. Should it be static?
drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6:
warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static
Changes since v2:
Change commit message to be more descriptive (thanks to Julia for input)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
The comment about the v2 change should be under the ---, and not in a
separate message.
julia
On Wed, 27 May 2015, Marcus Folkesson wrote:
Warnings reported by sparse:
drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5:
warning: symbol 'ptlrpc_ping' was not declared. Should it be static?
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, May 27, 2015 2:15 AM
To: KY Srinivasan
Cc: de...@linuxdriverproject.org; Haiyang Zhang; linux-
ker...@vger.kernel.org; Dexuan Cui; Ingo Molnar; Paul E. McKenney; Rafael
J. Wysocki; Peter
On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote:
@@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
if (nalloc * sizeof(*ifr) PAGE_CACHE_SIZE) {
toobig = 1;
nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
-
On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote:
Hi,
On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs
rodriguez.twis...@gmail.com wrote:
This patch fixes the init function for the iio_simple_dummy driver.
The main issues were absence of kfree for the allocated array, and
On Wed, May 27, 2015 at 08:24:18PM +0300, Vladimirs Ambrosovs wrote:
On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote:
Hi,
On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs
rodriguez.twis...@gmail.com wrote:
This patch fixes the init function for the iio_simple_dummy
The same code is executed regardless ret value, so this test can be
removed.
Signed-off-by: Laurent Navet laurent.na...@gmail.com
---
drivers/staging/gdm72xx/usb_boot.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/usb_boot.c
b/drivers/staging/gdm72xx/usb_boot.c
From: mbambagini mario.bambag...@gmail.com
Signed-off-by: Mario Bambagini mario.bambag...@gmail.com
---
drivers/staging/sm750fb/sm750_accel.c | 695 +-
1 file changed, 354 insertions(+), 341 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c
On Wed, 2015-05-27 at 22:25 +0200, Laurent Navet wrote:
The same code is executed regardless ret value, so this test can be
removed.
[]
diff --git a/drivers/staging/gdm72xx/usb_boot.c
b/drivers/staging/gdm72xx/usb_boot.c
[]
@@ -255,8 +255,6 @@ static int em_wait_ack(struct usb_device
On Wed, May 27, 2015 at 5:25 PM, Laurent Navet laurent.na...@gmail.com wrote:
The same code is executed regardless ret value, so this test can be
removed.
Signed-off-by: Laurent Navet laurent.na...@gmail.com
---
drivers/staging/gdm72xx/usb_boot.c | 2 --
1 file changed, 2 deletions(-)
Fix:
drivers/staging/wilc1000/linux_wlan.c:18:22: fatal error:
asm/gpio.h: No such file or directory
Not every architecture has asm/gpio.h. Include linux/gpio.h instead.
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1
Don't split string literals, it makes them hard to grep for.
Will fix. The CWARN will go over 80 characters but from the recent emails
that is more acceptable.
If this is the only problem then this patch set it ready.
Normally the right thing to do here would be to send a fixed
[patch
On Tue, May 26, 2015 at 02:50:30PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The Kconfig dependency for this driver should include the kernel
configuration FB_MODE_HELPERS which defines the vesa_modes
structure.Without this dependency,the driver build generates a linker
error if build
On Wed, May 27, 2015 at 11:32:11AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 02:50:30PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The Kconfig dependency for this driver should include the kernel
configuration FB_MODE_HELPERS which defines the vesa_modes
structure.Without
On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote:
As suggested by Sudip this patch removes the redundant 1360x768@60
option from the fb_videomode struct array.
this can be in the comments but should not be there in the commit message.
regards
sudip
The removed option and
On Wed, May 27, 2015 at 05:56:27AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
replace kzalloc with devm_kzalloc thereby removing the
Hi,
On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs
rodriguez.twis...@gmail.com wrote:
This patch fixes the init function for the iio_simple_dummy driver.
The main issues were absence of kfree for the allocated array, and no
devices being removed in case the probe function fails, running
On Wed, May 27, 2015 at 12:07:06PM +, Harisangam, Sharvari (S.) wrote:
On Tue, May 26, 2015 at 10:35:57AM +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 12:22:25PM +, Harisangam, Sharvari (S.) wrote:
Modified the if-else statements to remove unnecessary comparisons.
This
On Wed, May 27, 2015 at 8:29 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Wed, May 27, 2015 at 08:24:18PM +0300, Vladimirs Ambrosovs wrote:
On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote:
Hi,
On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs
The wilc1000 driver uses definitions such as DEBUG_LEVEL, DEBUG,
and PRINT_INFO. This causes compile errors on S390 which has similar
definitions in its core code. Disable the driver for S390 instead
of giving the non-standard messaging code credit by trying to fix it.
Signed-off-by: Guenter
On Wed, 27 May 2015, Joe Perches wrote:
On Wed, 2015-05-27 at 22:25 +0200, Laurent Navet wrote:
The same code is executed regardless ret value, so this test can be
removed.
[]
diff --git a/drivers/staging/gdm72xx/usb_boot.c
b/drivers/staging/gdm72xx/usb_boot.c
[]
@@ -255,8 +255,6 @@
On Thu, 2015-05-28 at 07:43 +0200, Julia Lawall wrote:
On Wed, 27 May 2015, Joe Perches wrote:
Perhaps all of the uses like:
goto foo;
foo:
could be modified. There are ~150 in the kernel.
I wrote a semantic patch recently for that as well... Maybe I can take
care of it.
On Wed, May 27, 2015 at 11:29:43PM +0200, Mario Bambagini wrote:
From: mbambagini mario.bambag...@gmail.com
That doesn't match up with the name you used above, or in the
signed-off-by line.
Signed-off-by: Mario Bambagini mario.bambag...@gmail.com
---
You are going to have to be really
On Wed, May 27, 2015 at 11:25:07AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 01:19:58AM +0300, Vladimirs Ambrosovs wrote:
Check for zero was added to the module parameter instances to
avoid the allocation of array of zero values. Although it is a valid call,
we don't want to
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
replace kzalloc with devm_kzalloc thereby removing the corresponding
kfree.
your patch is corrupt and can not be applied.
But even then, can
On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
replace kzalloc with devm_kzalloc thereby removing the corresponding
kfree.
On Wed, May 27, 2015 at 01:07:17PM +0530, Sudip Mukherjee wrote:
On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath
(H.) wrote:
replace
On Wed, May 27, 2015 at 07:53:02AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Wed, May 27, 2015 at 01:07:17PM +0530, Sudip Mukherjee wrote:
On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May
54 matches
Mail list logo
