Allocate the receive bufer from the NUMA node assigned to the primary
channel.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
V2: Specify the tree for this patch.
drivers/net/hyperv/netvsc.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git
Allocate the send buffer in a NUMA aware way.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/netvsc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index d187965..06de98a 100644
---
Allocate both receive buffer and send buffer from the NUMA node assigned to the
primary channel.
K. Y. Srinivasan (2):
hv_netvsc: Allocate the receive buffer from the correct NUMA node
hv_netvsc: Allocate the sendbuf in a NUMA aware way
drivers/net/hyperv/netvsc.c | 11 +--
1
Add another helper function for binder_thread_read. All of the logic for
waiting for work to do has been pulled into this function.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 104 ++-
1 file changed, 66
Give every case in the switch statement its own dedicated function.
Remove the process argument to binder_transact, as it can be derived
from the thread argument as with all of the other newly created
functions.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c |
Add a dedicated function for handling errors.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 51
1 file changed, 34 insertions(+), 17 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
From: Lisa Du c...@marvell.com
There's one point was missed in the patch commit da49889deb34 (staging:
binder: Support concurrent 32 bit and 64 bit processes.). When configure
BINDER_IPC_32BIT, the size of binder_uintptr_t was 32bits, but size of
void * is 64bit on 64bit system. Correct it here.
Split up binder_thread_read into a function for waiting for work
and a function for processing the work nodes.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 96
1 file changed, 56 insertions(+), 40 deletions(-)
Add dedicated functions for every work type in the switch statement.
Refactor the loop logic to remove the while 1, and make it explicit
which work items cause the loop to exit.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 433
Duplicate errors can be returned to userspace when the thread
error code is left set when the read buffer runs out of space.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Add dedicated functions for handling the movement of fds, binder objects,
and references across processes.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 311 +--
1 file changed, 167 insertions(+), 144 deletions(-)
Pull the loop that translates the flat_binder_objects into a separate
function, binder_transaction_buffer_acquire.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 128 ---
1 file changed, 77 insertions(+), 51
Pull the logic that determines the target_node of a transaction into a
dedicated function.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 46 +++---
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git
Add a helper function to find a thread within a transaction stack.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
Add another helper function that adds log entries to failed log.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index
Hi Greg mailing-list members,
On Thu, 28 May 2015, Greg KH wrote:
In the future, always use scripts/get_maintainer.pl to determine who to
send patches to please.
Sorry, I did use the get_maintainer.pl script, but I did not want to
bother too many people, and I only picked Marek in CC: (I
Allocate the receive bufer from the NUMA node assigned to the primary
channel.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/netvsc.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/net/hyperv/netvsc.c
On Thu, May 28, 2015 at 10:23:35PM +0200, Arnd Bergmann wrote:
Subject: [PATCH] staging: wilc1000 dead code removal
After finding some build errors in wilc1000, I played some more with
the driver and eliminated a lot of unused code. This is all code
meant for OS abstraction. Since we know we
These patches drop gotos that jump to a label that is at the next
instruction, in the case that the label is not used elsewhere in the
function. The complete semantic patch that performs this transformation is
as follows:
// smpl
@r@
position p;
identifier l;
@@
if (...) goto l@p;
l:
From: Julia Lawall julia.law...@lip6.fr
Delete jump to a label on the next line, when that label is not
used elsewhere.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// smpl
@r@
identifier l;
@@
-if (...) goto l;
-l:
// /smpl
-Original Message-
From: K. Y. Srinivasan [mailto:k...@microsoft.com]
Sent: Thursday, May 28, 2015 2:56 PM
To: da...@davemloft.net; net...@vger.kernel.org; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com; jasow...@redhat.com
Cc: KY
Add helper functions for manipulating the transaction stack, and
for validating the transaction stack during binder transactions
and replies.
Signed-off-by: Riley Andrews riandr...@android.com
---
drivers/android/binder.c | 126 +--
1 file changed, 79
Subject: [PATCH] staging: wilc1000 dead code removal
After finding some build errors in wilc1000, I played some more with
the driver and eliminated a lot of unused code. This is all code
meant for OS abstraction. Since we know we are running Linux,
and which version we use, it can all be removed.
On Thu, May 28, 2015 at 09:50:23PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 09:39:14AM -0700, insop.s...@gainspeed.com wrote:
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath
(H.) wrote:
On Thu, May 28, 2015 at 09:39:14AM -0700, insop.s...@gainspeed.com wrote:
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function by introducing a new retval
-20150528.
drivers/staging/xgifb/XGI_main_26.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index 74e8820..943d463 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function by introducing a new retval
variable.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
Add static declarations to statisfy sparse warnings in:
drivers/staging/unisys/visorbus/visorbus_main.c
warning: symbol 'visorbus_debug' was not declared
warning: symbol 'visorbus_forcematch' was not declared
warning: symbol 'visorbus_forcenomatch' was not declared
warning: symbol
On Wed, May 27, 2015 at 07:02:51PM +0300, Dan Carpenter wrote:
Hello Don Zickus,
This is a semi-automatic email about new static checker warnings.
The patch 3032aeddd85e: staging: unisys: Convert bus functions to
pass bus_info pointer around from May 13, 2015, leads to the
following
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v2:Addressed the review comments by Sudhip Mukherjee as I had
missed out a few other
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v3: Fix alignment issues addressed by Dan Carpenter.
v2:Addressed the review
On Thu, May 28, 2015 at 08:54:12AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
I resend v3 but it seems there is a duplicate signature.Please dicard it
as well.I am sending v4 now.
v3 is fine. The duplicate sign-off is below the cut off line --- so it
will be removed automatically.
You didn't try to compile this.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, May 28, 2015 at 08:40:41AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
diff --git a/drivers/staging/sm750fb/Kconfig b/drivers/staging/sm750fb/Kconfig
index c40d088..59d7c52 100644
--- a/drivers/staging/sm750fb/Kconfig
+++ b/drivers/staging/sm750fb/Kconfig
@@ -1,6 +1,10 @@
On Thu, May 28, 2015 at 01:12:40AM +0300, Vladimirs Ambrosovs wrote:
On Wed, May 27, 2015 at 11:25:07AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 01:19:58AM +0300, Vladimirs Ambrosovs wrote:
Check for zero was added to the module parameter instances to
avoid the allocation of
On Thu, 28 May 2015, Joe Perches wrote:
On Thu, 2015-05-28 at 10:14 +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
Perhaps all of the uses like:
goto foo;
foo:
could be modified. There are ~150 in the kernel.
Joe, these are a kind
Since you're redoing this anyway.
On Tue, May 26, 2015 at 04:21:09PM -0700, K. Y. Srinivasan wrote:
diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index ddcc7f8..dd45440 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@
On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
On Wed, 2015-05-27 at 22:25 +0200, Laurent Navet wrote:
The same code is executed regardless ret value, so this test can be
removed.
[]
diff --git a/drivers/staging/gdm72xx/usb_boot.c
b/drivers/staging/gdm72xx/usb_boot.c
[]
Obviously, I endorse this idea. :) Every out label in this file is
a do-nothing label or a do-everything label, but with bugs. usb_boot()
should look like:
free_tx_buf:
kfree(tx_buf);
release_firm:
release_firmware(firm);
ret;
If we fail to allocate tx_buf then we
On Thu, May 28, 2015 at 11:45:28AM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 08:40:41AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
diff --git a/drivers/staging/sm750fb/Kconfig
b/drivers/staging/sm750fb/Kconfig
index c40d088..59d7c52 100644
---
On Thu, May 28, 2015 at 11:57:54AM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 08:54:12AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
I resend v3 but it seems there is a duplicate signature.Please dicard it
as well.I am sending v4 now.
v3 is fine. The duplicate sign-off
Modified the if-else statements to remove unnecessary comparisons in rxtx.c.
This change was detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari shari...@visteon.com
---
drivers/staging/vt6655/rxtx.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
On Thu, 2015-05-28 at 06:10 +, Harisangam, Sharvari (S.) wrote:
Modified the if-else statements to remove unnecessary comparisons.
This change was detected with the help of coccinelle tool
Your commit subject implies you are doing this for the
directory, not a single file.
If you are going
On Thu, 2015-05-28 at 10:33 +0200, Julia Lawall wrote:
On Thu, 28 May 2015, Joe Perches wrote:
I think these are very equivalent style to
the repeated:
ret = foo();
if (ret 0)
return ret;
...
ret = bar();
if (ret 0)
return ret;
On Thu, 2015-05-28 at 10:14 +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
Perhaps all of the uses like:
goto foo;
foo:
could be modified. There are ~150 in the kernel.
Joe, these are a kind of style. You're just directing a newbie
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v3: Fix alignment issues addressed by Dan Carpenter.
v2:Addressed the review
Modified the if-else statements to remove unnecessary comparisons.
This change was detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari shari...@visteon.com
---
drivers/staging/vt6655/rxtx.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/bridges/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vme/bridges/Kconfig b/drivers/vme/bridges/Kconfig
index 9331064..f6d8545 100644
---
buf_unalloc is essentially a vme_free_consistent:
1) image[i].kern_buf is never NULL in buf_alloc call
2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
Reorder code so that forward declarations are not needed.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/staging/vme/devices/vme_user.c | 139 ++---
1 file changed, 60 insertions(+), 79 deletions(-)
diff
This separates VME related constants that are a part of both kernel and
user space API into a common uapi header.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
include/linux/vme.h | 54 ++---
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/bridges/vme_ca91cx42.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vme/bridges/vme_ca91cx42.c
b/drivers/vme/bridges/vme_ca91cx42.c
index e9bd657..f692efc 100644
---
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/bridges/vme_ca91cx42.c | 17 ++---
drivers/vme/bridges/vme_tsi148.c | 15 +--
2 files changed, 27 insertions(+), 5 deletions(-)
diff --git
This makes vme_user_llseek ignore all minors that don't have llseek
implementation.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/staging/vme/devices/vme_user.c | 18 ++
1 file changed, 10 insertions(+), 8
Universe II datasheet defines following address space values
for LM_CTL[16:18]
000=A16
001=A24
010=A32
011,100,101=Reserved
110=User1
111=User2
Mask 516 is not the right one for matching [16:18], instead we should
use 716.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor
DMA lists on tsi148 weren't processed further than the first item
because of the broken logic. This regression was introduced in:
ac1a4f2caf7b071 Staging: VME: Ensure TSI148 link list descriptors...
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/vme.c | 5 +++--
include/linux/vme.h | 2 ++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 1b78d27..5670891 100644
---
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/staging/vme/devices/vme_user.c | 31 ---
1 file changed, 31 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
This introduces a new dma device that provides a single ioctl call that
provides DMA read and write functionality to the user space.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/staging/vme/devices/vme_user.c | 201
This moves DMA mapping of the first list element to vme_list_add, the
same place where other elements mappings occur. This prevents extra
mapping or over-unmapping in the cases when vme_list_exec is called more
or less than one time respectively.
Also adds dma_mapping_error check.
Signed-off-by:
The first item in this submission documents previously introduced
vme_master_mmap() call. Following, there are three fixes for the tsi148
driver's DMA. There was one bug that rendered it imposible to use DMA
lists with more than one item. The other was related to the place where
dma_map_single
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
Documentation/vme_api.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt
index ffe6e22..ca5b827 100644
---
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/vme.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 6bab2c4..1b78d27 100644
--- a/drivers/vme/vme.c
+++
On Thu, May 28, 2015 at 02:07:36PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 10:51:38AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function.remove return value check for
function that always return success.
Signed-off-by: Gujulan Elango Hari
On Thu, May 28, 2015 at 11:32:21AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The reason i did that was if the function doesn't hit any error
condition, then it needs to return 0. If the err variable is not
initialized to 0,I assume that it can take any value.Please correct me
if i am
remove redundant code in this function by introducing a new retval
variable.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git
On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function by introducing a new retval
variable.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
No the original code is quite bad but this patch makes it worse.
On Thu, May 28, 2015 at 10:19:40AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
fimage = kmalloc(sizeof(struct fpgaimage), GFP_KERNEL);
if (!fimage)
@@ -298,44 +299,41 @@ static int gs_fpgaboot(void)
err = gs_load_image(fimage, file);
if (err) {
goto
On Thu, May 28, 2015 at 02:37:43PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 11:32:21AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The reason i did that was if the function doesn't hit any error
condition, then it needs to return 0. If the err variable is not
initialized to
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function by introducing a new retval
variable.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
On Tue, May 26, 2015 at 04:34:55PM +0200, Jason A. Donenfeld wrote:
On Tue, May 26, 2015 at 4:06 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
You sure do like wrapping to a high value and testing the result for
wrapping instead of validating before doing the subtraction...
I do
Warnings reported by sparse:
drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5:
warning: symbol 'ptlrpc_ping' was not declared. Should it be static?
drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6:
warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static
remove redundant code in this function.remove return value check for
function that always return success.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v2:address review comments from Dan.Remove return value check
for the function gs_release_image as it always
On Thu, May 28, 2015 at 10:51:38AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function.remove return value check for
function that always return success.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v2:address review comments
This separates VME related constants that are a part of both kernel and
user space API into a common uapi header.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
include/linux/vme.h | 54 ++---
Checking for image[minor].resource != NULL is not needed since all
resources are allocated before device is created.
image[minor].users accounting is deleted because it's not being used.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
remove redundant code in this function.remove return value check for
function that always return success
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v3:Remove initialization of the 'err' variable.
v2:address review comments from Dan.Remove return value
buf_unalloc is essentially a vme_free_consistent:
1) image[i].kern_buf is never NULL in buf_alloc call
2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/bridges/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vme/bridges/Kconfig b/drivers/vme/bridges/Kconfig
index 9331064..f6d8545 100644
---
Check the return value of kcalloc first and then use the pointer.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_driver.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
On Thu, May 28, 2015 at 12:08:56PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function.remove return value check for
function that always return success
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
Looks good. Thanks!
regards,
dan
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/vme.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 6bab2c4..1b78d27 100644
--- a/drivers/vme/vme.c
+++
This introduces a new dma device that provides a single ioctl call that
provides DMA read and write functionality to the user space.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/staging/vme/devices/vme_user.c | 201
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/staging/vme/devices/vme_user.c | 31 ---
1 file changed, 31 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/vme.c | 5 +++--
include/linux/vme.h | 2 ++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 1b78d27..5670891 100644
---
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
---
drivers/vme/bridges/vme_ca91cx42.c | 17 ++---
drivers/vme/bridges/vme_tsi148.c | 15 +--
2 files changed, 27 insertions(+), 5 deletions(-)
diff --git
DMA lists on tsi148 weren't processed further than the first item
because of the broken logic. This regression was introduced in:
ac1a4f2caf7b071 Staging: VME: Ensure TSI148 link list descriptors...
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor Alekseev igor.aleks...@itep.ru
Universe II datasheet defines following address space values
for LM_CTL[16:18]
000=A16
001=A24
010=A32
011,100,101=Reserved
110=User1
111=User2
Mask 516 is not the right one for matching [16:18], instead we should
use 716.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
Cc: Igor
Check the return value of kzalloc return error if it fails.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index
On Thu, May 28, 2015 at 01:23:57PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
Check the return value of kzalloc return error if it fails.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_driver.c | 2 ++
1 file changed, 2 insertions(+)
On Thu, May 28, 2015 at 01:52:47PM +, KY Srinivasan wrote:
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Thursday, May 28, 2015 12:06 AM
To: KY Srinivasan
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-
ker...@vger.kernel.org;
The newly added wilc1000 driver lacks several Kconfig dependencies,
resulting in a multitude of randconfig build errors, e.g.:
drivers/built-in.o: In function `WILC_WFI_mgmt_tx_cancel_wait':
binder.c:(.text+0x12bd28): undefined reference to
`cfg80211_remain_on_channel_expired'
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Thursday, May 28, 2015 12:06 AM
To: KY Srinivasan
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com;
NL80211_IFTYPE_MAX represents the largest interface type number defined,
so declaring the array with that size will actually leave out the last
interface.
This causes invalid memory access whenever this array is used, which starts
happening at boot.
Signed-off-by: Sasha Levin
Le 28/05/2015 16:35, Arnd Bergmann a écrit :
The newly added wilc1000 driver lacks several Kconfig dependencies,
resulting in a multitude of randconfig build errors, e.g.:
drivers/built-in.o: In function `WILC_WFI_mgmt_tx_cancel_wait':
binder.c:(.text+0x12bd28): undefined reference to
current_pt_regs() returns regs of the userspace process and in case of
kernel crash this is not what we need to report. E.g. when we trigger
crash with sysrq we see the following:
...
RIP: 0010:[815b8696] [815b8696]
sysrq_handle_crash+0x16/0x20
RSP: 0018:8800db0a7d88
On Wed, 27 May 2015, Joe Perches wrote:
On Thu, 2015-05-28 at 07:43 +0200, Julia Lawall wrote:
On Wed, 27 May 2015, Joe Perches wrote:
Perhaps all of the uses like:
goto foo;
foo:
could be modified. There are ~150 in the kernel.
I wrote a semantic patch recently for
On Thu, May 28, 2015 at 05:24:56PM +0200, Xavier Roche wrote:
Local functions not used in other modules should be static, not extern.
(patch checked against linux-next and staging)
This line shouldn't be here, it should just be implied :)
Signed-off-by: Xavier Roche ro...@httrack.com
---
On Thu, 2015-05-28 at 18:21 +0200, Julia Lawall wrote:
On Wed, 27 May 2015, Joe Perches wrote:
On Thu, 2015-05-28 at 07:43 +0200, Julia Lawall wrote:
On Wed, 27 May 2015, Joe Perches wrote:
Perhaps all of the uses like:
goto foo;
foo:
could be modified.
On Thu, May 28, 2015 at 05:37:59PM +0200, Jason A. Donenfeld wrote:
On Thu, May 28, 2015 at 1:04 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
It's really not simpler to understand though.
Greg - do you want me to resubmit a v3 for this, or does it not really
matter and we can address
1 - 100 of 104 matches
Mail list logo
