Removed the braces of if else statements which contain only one
statement
Signed-off-by: Aparna Karuthodi
---
drivers/staging/dgnc/dgnc_tty.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c
b/drivers/staging/dgnc/dgnc_tty.c
in
On Fri, Jun 05, 2015 at 04:27:48PM -0700, Dennis Chen wrote:
> From 843d038eec5ac2c59d3138f19ae52828098c7d50 Mon Sep 17 00:00:00 2001
> From: Dennis Chen
> Date: Fri, 5 Jun 2015 15:42:37 -0700
> Subject: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style
> issue
>
> Fixed white
>From 843d038eec5ac2c59d3138f19ae52828098c7d50 Mon Sep 17 00:00:00 2001
From: Dennis Chen
Date: Fri, 5 Jun 2015 15:42:37 -0700
Subject: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style
issue
Fixed whitespace coding style issue.
Signed-off-by: Dennis Chen
---
drivers/stagin
Hello,
Please consider including mainline commit
dc45708ca9988656d706940df5fd102672c5de92 in the next v3.18.y, v4.0.y and
3.19.y-ckt stable releases. It was
included in the mainline tree as of v4.1-rc5. It has been tested and
confirmed to resolve the following bug:
http://bugs.launchpad.net/
On 06/05/2015 01:51 PM, Joseph Salisbury wrote:
> Hello,
>
> Please consider including mainline commit
> dc45708ca9988656d706940df5fd102672c5de92 in the next v3.18.y, v4.0.y and
> 3.19.y-ckt stable releases. It was
> included in the mainline tree as of v4.1-rc5. It has been tested and
> conf
On 06/03/2015 11:48 PM, Mutharaju, Prasanna (P.) wrote:
From: Prasanna Karthik
Fix reported by coccinelle compressing last two lines with single return
call
Signed-off-by: Prasanna Karthik
---
V2: Removed psta structure pointer which is not needed shown by compiler
Warning
---
---
dri
For DAS08/JR/16 and DAS08/JR/AO-16 boards, the 16-bit analog input
readings are assumed to be in a sign-magnitude format and need
converting to the COMEDI unsigned sample format. The expressions to do
the conversion look a little messy. Use a local variable `magnitude` to
make it easier to follow
Replace the boiler-plate Comedi module description string with something
more specific.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/driver
The `DAS08_DO_MASK` macro is a bitmask for the control register
corresponding to the digital output channels (except on "JR" boards).
Rename it to `DAS08_CONTROL_DO_MASK` and add a comment.
The `DAS08_OP(x)` macro takes a bitvector of the desired digital output
channel states and returns the corre
Use the preferred style for block comments. Squash double spaces after
the comment opening sequence for single-line comments.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/driv
`das08_ai_rinsn()` is the handler for Comedi `INSN_READ` instructions
for the AI subdevice. Rename the function to `das08_ai_insn_read()` for
consistency.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --gi
The "das08" module contains some comments outlining the register maps
for some of the ISA boards supported by this module in combination with
the "das08_isa" module. The comments are somewhat sporadically placed,
don't detail all the boards, and don't use the preferred block comment
style. If any
The `DAS08_STATUS` macro contains the offset to the read-only status
register. Rename it to `DAS08_STATUS_REG` and add a comment.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi
Replace double spaces with single spaces at the start of each line in
the copyright comment at the top of the file.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/stag
The `DAS08_MUX_MASK` macro is a bitmask for the control register
corresponding to the analog input multiplexor channel selection bits.
Rename it to `DAS08_CONTROL_MUX_MASK` and add a comment. Note that the
current setting of the multiplexor can also be read from the same bit
positions in the statu
The `DAS08AO_AO_LSB(x)` macro returns the offset to the analog output
low byte register for channel x (0 or 1) for "AOL", "AOM", and "AOH"
boards. The `DAS08AO_AO_MSB(x)` macro returns the offset to the
corresponding high byte register. Rename the macros to
`DAS08AOX_AO_LSB_REG(x)` and `DAS08AOX_
The `DAS08AO_GAIN_CONTROL` and `DAS08AO_GAIN_STATUS` macros hold the
offset to the "programmable gain" register on "PGL", "PGM", "PGH",
"AOL", "AOM" and "AOH" boards. Writing a code to this register sets the
gain for the current analog input channel (selected in the main control
register). The wr
`das08_pgh_gainlist[]`, `das08_pgl_gainlist[]`, and
`das08_pgm_gainlist[]` hold the gain codes indexed by range index for
various boards that support programmable gain. `das08_gainlist[]` is a
look-up table to find the appropriate gain list for a board. These are
all associated with the analog inp
The `DAS08JR_AO_LSB(x)` macro returns the offset to the analog output
low byte register for channel x (0 or 1) for "JR" boards with analog
output support. The `DAS08JR_AO_MSB(x)` macro returns the offset to the
corresponding high byte register. Rename the macros to
`DAS08JR_AO_LSB_REG(x)` and `DA
The `DAS08JR_DIO` macro contains the offset to the read-only digital
input register and write-only digital output register on the "JR"
boards. Replace the macro with two new macros (with the same numeric
value) named `DAS08JR_DI_REG` for the digital input register and
`DAS08JR_DO_REG` for the digi
`das08_di_rbits()` and `das08jr_di_rbits()` are handlers for the Comedi
`INSN_BITS` instruction for the digital input subdevice on "non-JR" and
"JR" boards, respectively. Rename them to `das08_di_insn_bits()` and
`das08jr_di_insn_bits()` respectively for consistency.
Signed-off-by: Ian Abbott
--
The `DAS08_CONTROL` macro contains the offset to the write-only control
register. Rename it to `DAS08_CONTROL_REG` and add a comment.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/co
The "das08" common module for DAS08 ISA, PCI, and PCMCIA drivers
includes a predefined set of AI range tables. The static board data (of
type `struct das08_board_struct`) for a particular board contains an
index in its `ai_pg` member (of type `enum das08_lrange`) indicating
which of the predefined
The `DAS08_EOC` macro contains a mask for the "end of A/D conversion"
bit in the status register. The logic is reverse sense in that the bit
is set to 1 while the conversion is in progress and set to 0 when the
conversion is complete. Rename the macro to `DAS08_STATUS_AI_BUSY` and
add a comment.
"AOL", "AOM", and "AOH" boards have a jumper that controls whether
analog output channels are updated simultaneously or individually. When
set to update individually, individual channels are updated when the
high byte register is written. When set to update simultaneously,
channels are not update
The `range_das08_pgl`, `range_das08_pgm`, and `range_das08_pgh`
variables define the analog input ranges for the "PGL", "PGM", and "PGH"
board variants, and are also used for the "AOL", "AOM", and "AOH" board
variants. Rename them to use the `das08_` prefix for consistency.
Signed-off-by: Ian Abb
`das08_do_wbits()` and `das08jr_do_wbits()` are handlers for the Comedi
`INSN_BITS` instruction for the digital output subdevice on "non-JR" and
"JR" boards, respectively. Rename them to `das08_do_insn_bits()` and
`das08jr_do_insn_bits()` respectively for consistency.
Signed-off-by: Ian Abbott
-
The `DAS08_INTE` macro contains a mask for the "INTE" bit in the control
register (except on "JR" boards). Setting it to 1 enables interrupts.
Setting it to 0 disables interrupts and clears the "IRQ" bit in the
status register. Rename the macro to `DAS08_CONTROL_INTE` and add a
comment. Also use
The `DAS08_IP()` macro takes a value read from the status register and
returns the state of the three digital input channels (except on "JR"
boards). Rename it to `DAS08_STATUS_DI()` and add a comment. Also
re-arrange the expression used to extract the state of the digital
inputs for consistency
The `DAS08_TRIG_12BIT` macro contains the offset to the write-only
software trigger register for 12-bit or 16-bit analog-to-digital
conversions. Rename the macro to `DAS08_AI_TRIG_REG` and add a comment.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.c | 4 ++--
1 file chang
The `DAS08_IRQ` macro contains a mask for the "IRQ" status bit. This is
set to 1 when a rising edge is detected on the external interrupt input
pin of the external connector (which may be jumpered to a pacer output).
It is cleared by setting the "INTE" control bit to 0. It is not used on
"JR" boa
"JR" boards with analog output channels have a jumper that controls
whether analog output channels are updated simultaneously or
individually. When set to update individually, individual channels are
updated when the high byte register is written. When set to update
simultaneously, channels are no
The `DAS08_LSB` and `DAS08_MSB` macros contain the offsets to the
least-significant and most-significant analog input data registers.
Rename them to `DAS08_AI_LSB_REG` and `DAS08_AI_MSB_REG` respectively
and add comments to document them.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/driv
The Comedi "das08.h" header file is included by drivers for the
ComputerBoards/MeasurementComputing and Keithley Metrabyte boards in the
DAS08 series. It does not compile cleanly when it is the first header
included by the ".c" file. It uses `struct comedi_device *` in the
parameter list of a fun
`das08_ai_rinsn()` handles Comedi `INSN_READ` instructions for the AI
subdevice. This programs the gain for the analog input channel if the
board has support for that, and acquires data from the channel. If
programmable gain is supported, the gain code is read from the array
pointed to by `devpri
The copyright header comment includes a single-line description saying
it is for "das08.c" and "das08_cs.c". However, it is also used by
"das08_isa.c" and "das08_pci.c". Update the description to say it is
for common DAS08 support, similar to description in "das08.c" (the
common module for the DA
Reformat remaining comments to use the preferred style for single-line
and block comments.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.h
b/drivers/staging/com
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/comedi/drive
Clean up the Comedi "das08" module a bit, mostly for consistent naming
of things.
01) staging: comedi: das08.h: reformat copyright comment
02) staging: comedi: das08.h: change description in copyright header
comment
03) staging: comedi: das08.h: reformat remaining comments
04) staging: comedi:
On Fri, Jun 05, 2015 at 06:04:14PM +0300, Dan Carpenter wrote:
> Sorry, I should have read on the later patches. That sounds fine.
Hi Dan,
No worries. I will take the blame for that. I should have communicated
that or done a better job making less confusing. :-(
Cheers,
Don
__
Sorry, I should have read on the later patches. That sounds fine.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Jun 05, 2015 at 10:45:59AM -0400, Jes Sorensen wrote:
> Sudip Mukherjee writes:
> > On Thu, Jun 04, 2015 at 09:22:45AM -0400, Benjamin Romer wrote:
> >> From: David Kershner
> >>
> >> Diagchannel.h is used primarily for the diagnostics channel. The
> >> diagnostics channel is not being u
Sudip Mukherjee writes:
> On Thu, Jun 04, 2015 at 09:22:36AM -0400, Benjamin Romer wrote:
>> This patch set contains the remaining changes from our driver cleanup
>> efforts. No functional changes have been made, only a rebase so that the
>> patches would apply.
> Hi,
> its not related to your thi
Sudip Mukherjee writes:
> On Thu, Jun 04, 2015 at 09:22:45AM -0400, Benjamin Romer wrote:
>> From: David Kershner
>>
>> Diagchannel.h is used primarily for the diagnostics channel. The
>> diagnostics channel is not being used by linux guests currently, so
>> the majority of the file is not neede
On Friday, June 05, 2015 at 03:57:03 PM, Stefan Wahren wrote:
> Am 05.06.2015 um 15:43 schrieb Marek Vasut:
> > On Thursday, June 04, 2015 at 08:44:31 PM, Stefan Wahren wrote:
> >> In order to provide a channel name to in kernel consumers add the
> >> datasheet names for every usable AD channel.
>
Instead of using a state machine and a switch with lots of
fall-trough, use gotos and cleanup the error handling loop.
That removes those two smatch warnings:
drivers/staging/media/lirc/lirc_imon.c:933 imon_probe() warn: possible
memory leak of 'context'
drivers/staging/media/lirc
Am 05.06.2015 um 15:43 schrieb Marek Vasut:
> On Thursday, June 04, 2015 at 08:44:31 PM, Stefan Wahren wrote:
>> In order to provide a channel name to in kernel consumers add the
>> datasheet names for every usable AD channel.
> Hi!
>
> Did you check those channel names for both MX28 and MX23? Note
On Thursday, June 04, 2015 at 08:44:31 PM, Stefan Wahren wrote:
> In order to provide a channel name to in kernel consumers add the
> datasheet names for every usable AD channel.
Hi!
Did you check those channel names for both MX28 and MX23? Note
that they do differ IIRC ;-)
Best regards,
Marek V
Dear Email User,
You have been selected as a winner at the on going JAGUAR AUTOMOBILE EMAIL
PROMOTION .Please
respond for more details.
Congratulations,
Mr. Jose Sebastian
2015 JAEP - Terms & Privacy
___
devel mailing list
de...@linuxdriverproject.or
On Fri, Jun 05, 2015 at 01:17:32PM +0200, Mariusz Masztalerczuk wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Mariusz Masztalerczuk
> ---
> drivers/staging/unisys/virthba/virthba.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
i think you need to update your tree. virth
Fixed a coding style issue.
Signed-off-by: Mariusz Masztalerczuk
---
drivers/staging/unisys/virthba/virthba.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/virthba/virthba.c
b/drivers/staging/unisys/virthba/virthba.c
index d9001cc..9892c63 1006
The indenting here causes a static checker warning:
drivers/staging/rtl8192e/rtllib_rx.c:626 RxReorderIndicatePacket()
warn: curly braces intended?
The code is actually correct, it's just that these lines were pushed in
an extra indent level by mistake in 35e33b0468ab ('staging: r
We know "rc == 0" so there is no need to check.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c
b/drivers/staging/lustre/lustre/fid/lproc_fid.c
index 41ab2ee..cc2201c 100644
--- a/drivers/staging/lustre/lustre/fid/lproc_fid.c
+++ b/drivers/staging/lustre/
We want to store a non-negative int here. The original code had a check
for unsigned long less than zero which is a mistake but also casting
from a positive long to an int can result in a negative number.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrp
I'm fine with merging this patch as is.
On Wed, Jun 03, 2015 at 04:43:26PM -0400, James Simmons wrote:
> + struct lnet_peer*msg_txpeer; /* peer I'm sending to */
> + struct lnet_peer*msg_rxpeer; /* peer I received from */
> +
> + void*msg_pri
On Wed, Jun 03, 2015 at 04:43:24PM -0400, James Simmons wrote:
> Currently the lnet headers used by user land contain various internal
> LNet structures that are only used by kernel space. Move the user land
> structures to headers used by user land. The kernel structures are
> relocated to headers
This whole patchset looks find to me.
Some tips for the future.
On Wed, Jun 03, 2015 at 04:43:20PM -0400, James Simmons wrote:
> From: John L. Hammond
>
> In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that
> __KERNEL__ is defined). Remove some common code only needed for user
>
Minor warnings spotted by checkpatch.pl in lustre regarding const correctness:
struct seq_operations should be const.
Signed-off-by: Xavier Roche
---
drivers/staging/lustre/lustre/llite/vvp_dev.c | 2 +-
drivers/staging/lustre/lustre/lmv/lproc_lmv.c | 2 +-
drivers/staging/lustre/lustre/lov/lov
58 matches
Mail list logo
