Re: [PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-17 Thread Vinay Simha
#if 0, but it's also obviously incorrect It supposed to be some tag #ifdef CONFIG_** . Could anybody in the loop can reply? i was just checking on style checks. Will skip this file , will take up later On Thu, Jul 16, 2015 at 9:27 AM, Joe Perches wrote: > On Thu, 2015-07-16 at 00:16 +0530, Vina

[PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-17 Thread Vinay Simha BN
scripts/checkpatch.pl kernel coding style fixes of WARNING WARNING: line over 80 characters Signed-off-by: Vinay Simha BN --- drivers/staging/sm750fb/ddk750_display.h | 10 +- drivers/staging/sm750fb/ddk750_hwi2c.h | 6 -- drivers/staging/sm750fb/ddk750_power.h | 6 +++--- dri

Re: [PATCH] sm750fb: coding style fixes lines over 80 chars

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 12:58 +0530, Vinay Simha BN wrote: > scripts/checkpatch.pl kernel coding style fixes of WARNING Please use checkpatch's --strict option until you know kernel style much better. > diff --git a/drivers/staging/sm750fb/sm750_accel.h > b/drivers/staging/sm750fb/sm750_accel.h []

Re: [PATCH v4] staging: rtl8192u: remove bool comparisons

2015-07-17 Thread Luis de Bethencourt
On Fri, Jul 17, 2015 at 11:34:45AM +0530, Sudip Mukherjee wrote: > On Thu, Jul 16, 2015 at 03:49:49PM +0200, Luis de Bethencourt wrote: > > Remove explicit true/false comparisons to bool variables. > > > > Signed-off-by: Luis de Bethencourt > > --- > > > > > diff --git a/drivers/staging/rtl8192u

[patch 2/2] Staging: rtl8192e: pointer math bug in rtllib_rx_DELBA()

2015-07-17 Thread Dan Carpenter
The "delba" variable is a pointer to struct rtllib_hdr_3addr so this pointer math bug means that we read nonsense data from beyond the end of the buffer. It could result in a oops if the memory is not mapped. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b

[patch 1/2] Staging: rtl8192u: pointer math bug in ieee80211_rx_DELBA()

2015-07-17 Thread Dan Carpenter
The "delba" variable is a pointer to struct rtl_80211_hdr_3addr so this addition here means we read nonsense data from beyond the end of the buffer. It could result in an oops if the memory is not mapped. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAPro

Re: [PATCH 1/4] staging: dgap: fix error path

2015-07-17 Thread Dan Carpenter
I don't think I like these at all. remove_one has always been buggy in that it removes everything. We should fix it to only remove one instead of formalizing the currect terrible behavior. regards, dan carpenter ___ devel mailing list de...@linuxdrive

[PATCH v5 1/2] staging: rtl8192u: remove bool comparisons

2015-07-17 Thread Luis de Bethencourt
Remove explicit true/false comparisons to bool variables. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++-- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4 ++-- dri

[PATCH v5 2/2] staging: rtl8192u: remove unneeded bool

2015-07-17 Thread Luis de Bethencourt
bool Reval is set to match the value of bHalfWirelessN24GMode just to this. The value can be returned directly. Removing uneeded bool. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/r8192U_core.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/

Re: [PATCH 1/4] staging: dgap: fix error path

2015-07-17 Thread Sudip Mukherjee
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote: > I don't think I like these at all. remove_one has always been buggy in > that it removes everything. We should fix it to only remove one instead > of formalizing the currect terrible behavior. Its already applied. I thought after th

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread Dexuan Cui
> From: K. Y. Srinivasan > Sent: Friday, July 17, 2015 3:17 > Subject: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed > during probe > diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h > ... > @@ -1116,6 +1127,9 @@ int rndis_filter_device_add(str

Re: [PATCH 1/4] staging: dgap: fix error path

2015-07-17 Thread Dan Carpenter
On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote: > On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote: > > I don't think I like these at all. remove_one has always been buggy in > > that it removes everything. We should fix it to only remove one instead > > of formalizi

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread Dexuan Cui
> From: K. Y. Srinivasan > Sent: Friday, July 17, 2015 3:17 > Subject: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed > during probe > > The current code returns from probe without waiting for the proper handling > of subchannels that may be requested. If the netvsc driver w

Re: [PATCH 1/4] staging: dgap: fix error path

2015-07-17 Thread Sudip Mukherjee
On Fri, Jul 17, 2015 at 01:05:55PM +0300, Dan Carpenter wrote: > On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote: > > On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote: > > > I don't think I like these at all. remove_one has always been buggy in > > > that it removes ev

Re: [PATCH 1/4] staging: dgap: fix error path

2015-07-17 Thread Dan Carpenter
On Fri, Jul 17, 2015 at 03:57:21PM +0530, Sudip Mukherjee wrote: > On Fri, Jul 17, 2015 at 01:05:55PM +0300, Dan Carpenter wrote: > > On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote: > > > On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote: > > > > I don't think I like th

Re: [PATCH v2] Drivers: Staging: dgnc: Fix Style Issues

2015-07-17 Thread Craig Inches
On Thu, Jul 16, 2015 at 11:13:43PM +0300, Dan Carpenter wrote: > On Fri, Jul 17, 2015 at 03:03:24AM +, Craig Inches wrote: > > Fixed multiple instances of: > > > > CHECK: Alignment should match open parenthesis > > CHECK: Blank lines aren't necessary before a close brace '}' > > CHECK: Please

Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-17 Thread Dan Carpenter
On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > By checking for the success of kzalloc we were able to remove the goto > label thus making the code more readable. > No... You've just changed error handling to success handling and added some new indent levels and made a tangled

[PATCH] staging: ion: ion_cma_heap: Don't directly use dma_common_get_sgtable

2015-07-17 Thread Jon Medhurst (Tixy)
Use dma_get_sgtable rather than dma_common_get_sgtable so a device's dma_ops aren't bypassed. This is essential in situations where a device uses an IOMMU and the physical memory is not contiguous (as the common function assumes). Signed-off-by: Jon Medhurst --- This also begs the question as to

Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-17 Thread Sudip Mukherjee
On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > By checking for the success of kzalloc we were able to remove the goto > > label thus making the code more readable. > > > > No... You've just changed error handl

Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-17 Thread Dan Carpenter
On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote: > On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > > By checking for the success of kzalloc we were able to remove the goto > > > label thus making

Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-17 Thread Sudip Mukherjee
On Fri, Jul 17, 2015 at 02:47:55PM +0300, Dan Carpenter wrote: > On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote: > > On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > > > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > > > By checking for the suc

[PATCH 1/2] staging: sm750fb: ddk750_power.c: Remove optionnal parentheses.

2015-07-17 Thread Antoine BLIN
Fix up "return is not a function, parentheses are not required" error found by the checkpatch.pl script. Signed-off-by: Antoine BLIN --- drivers/staging/sm750fb/ddk750_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/st

[PATCH 2/2] staging: sm750fb: ddk750_power.c: Split lines over 80 characters.

2015-07-17 Thread Antoine BLIN
Fix up "line over 80 characters" warning found by the checkpatch.pl script. Signed-off-by: Antoine BLIN --- drivers/staging/sm750fb/ddk750_power.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm75

[PATCH 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-07-17 Thread Sudip Mukherjee
Now since all cleanups are done and the code is ready to be merged lets move it out of staging into fbdev location. Signed-off-by: Sudip Mukherjee --- drivers/staging/Kconfig| 2 -- drivers/staging/Makefile | 1 - drivers/st

[PATCH 2/3] Documentation/fb: add documentation for sm712fb

2015-07-17 Thread Sudip Mukherjee
Create the documentation for SM712. Mention all the supported modes and how to use. Signed-off-by: Sudip Mukherjee --- Documentation/fb/sm712fb.txt | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/fb/sm712fb.txt diff --git a/Documentation/

[PATCH 3/3] MAINTAINERS: update maintainers list

2015-07-17 Thread Sudip Mukherjee
Now since sm712fb has moved out of staging update the maintainers list accordingly. Signed-off-by: Sudip Mukherjee --- MAINTAINERS | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8133cef..2c77c30 100644 --- a/MAINTAINERS +++ b

[PATCH 3/5] drivers: staging: rtl8192u: removed pointer check for kfree in r8192U_core.c

2015-07-17 Thread Joseph-Eugene Winzer
kfree() can handle NULL pointers itself, so the check is unnecessary. Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192

[PATCH 2/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-17 Thread Joseph-Eugene Winzer
Reformatting the code without introducing other warnings like 'Avoid unnecessary line continuations' or breaking strings. Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 809 ++--- 1 file changed, 536 insertions(+), 273 deletions(-) d

[PATCH 5/5] drivers: staging: rtl8192u: fixed coding style issues in r8192U_core.c

2015-07-17 Thread Joseph-Eugene Winzer
Fixed a few lines that were longer than 80 chars. Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 61 +++--- 1 file changed, 41 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8

[PATCH 1/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-17 Thread Joseph-Eugene Winzer
Fixing several coding style issues, like C99 Comment Style Trailing whitespaces Inconsistent spacing of operators Started to reformat comments/expressions for 80 character limit Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 1323

[PATCH 4/5] drivers: staging: rtl8192u: included linux/uaccess.h instead of asm/uaccess.h

2015-07-17 Thread Joseph-Eugene Winzer
Checkpatch didn't stop complaining about it and as linux/uaccess.h also includes asm/uaccess.h, there shouldn't be a problem. Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192

Re: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > The current code returns from probe without waiting for the proper handling > of subchannels that may be requested. If the netvsc driver were to be rapidly > loaded/unloaded, we can trigger a panic as the unload will be tearing > down state that may not have been ful

[RFC 2/9] android: add sync_fence_create_dma

2015-07-17 Thread John . C . Harrison
From: Maarten Lankhorst This allows users of dma fences to create a android fence. v2: Added kerneldoc. (Tvrtko Ursulin). Signed-off-by: Maarten Lankhorst Signed-off-by: Tvrtko Ursulin Cc: Maarten Lankhorst Cc: Daniel Vetter Cc: Jesse Barnes Cc: de...@driverdev.osuosl.org Cc: Riley Andrews

[RFC 1/9] staging/android/sync: Support sync points created from dma-fences

2015-07-17 Thread John . C . Harrison
From: Tvrtko Ursulin Debug output assumes all sync points are built on top of Android sync points and when we start creating them from dma-fences will NULL ptr deref unless taught about this. Signed-off-by: Tvrtko Ursulin Cc: Maarten Lankhorst Cc: de...@driverdev.osuosl.org Cc: Riley Andrews

Re: [Intel-gfx] [RFC 1/9] staging/android/sync: Support sync points created from dma-fences

2015-07-17 Thread Tvrtko Ursulin
On 07/17/2015 03:31 PM, john.c.harri...@intel.com wrote: From: Tvrtko Ursulin Debug output assumes all sync points are built on top of Android sync points and when we start creating them from dma-fences will NULL ptr deref unless taught about this. This is Maarten's code, just the patch had

Re: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-17 Thread Vitaly Kuznetsov
Dexuan Cui writes: >> From: David Miller >> Sent: Thursday, July 16, 2015 12:19 >> >> From: Dexuan Cui >> Date: Tue, 14 Jul 2015 03:00:48 -0700 >> >> > + pr_debug("hvsock_sk_destruct: called\n"); >> >> Debug logging just to state that a function is called is not appropriate, >> we have very s

Re: [PATCH] staging: ion: ion_cma_heap: Don't directly use dma_common_get_sgtable

2015-07-17 Thread Robin Murphy
Hi Tixy, On 17/07/15 12:01, Jon Medhurst (Tixy) wrote: Use dma_get_sgtable rather than dma_common_get_sgtable so a device's dma_ops aren't bypassed. This is essential in situations where a device uses an IOMMU and the physical memory is not contiguous (as the common function assumes). Signed-of

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Friday, July 17, 2015 3:01 AM > To: KY Srinivasan; da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; vkuzn...@redhat.com > C

Re: [PATCH 5/6] staging: rtl8188eu: stop using DBG_88E

2015-07-17 Thread Jakub Sitnicki
On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee wrote: > Stop using DBG_88E which is a custom macro for printing debugging > messages. Instead start using pr_debug and in the process define > pr_fmt. In the end, don't we want to use netdev_dbg() everywhere where we work with a struct net_

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Friday, July 17, 2015 3:07 AM > To: KY Srinivasan; da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; vkuzn...@redhat.com > C

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, July 17, 2015 7:13 AM > To: KY Srinivasan > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jaso

Re: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread Vitaly Kuznetsov
KY Srinivasan writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, July 17, 2015 7:13 AM >> To: KY Srinivasan >> Cc: da...@davemloft.net; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de

[PATCH v9 0/7] FPGA Manager Framework and Simple FPGA Bus

2015-07-17 Thread atull
From: Alan Tull This patchset adds two chunks plus documentation: * fpga manager core: exports ABI functions that write an image to a FPGA * DT Overlay support: simple-fpga-bus to handle FPGA from a DT overlay The core's ABI is minimal to start with: only 6 functions. This gives a common inte

[PATCH v9 1/7] staging: usage documentation for FPGA manager core

2015-07-17 Thread atull
From: Alan Tull Add a document on the new FPGA manager core. Signed-off-by: Alan Tull --- drivers/staging/fpga/Documentation/fpga-mgr.txt | 117 +++ 1 file changed, 117 insertions(+) create mode 100644 drivers/staging/fpga/Documentation/fpga-mgr.txt diff --git a/drivers/

[PATCH v9 2/7] staging: usage documentation for simple fpga bus

2015-07-17 Thread atull
From: Alan Tull Add a document spelling out usage of the simple fpga bus. Signed-off-by: Alan Tull --- .../staging/fpga/Documentation/simple-fpga-bus.txt | 48 1 file changed, 48 insertions(+) create mode 100644 drivers/staging/fpga/Documentation/simple-fpga-bus.txt di

[PATCH v9 6/7] staging: add simple-fpga-bus

2015-07-17 Thread atull
From: Alan Tull Add simple fpga bus. This is a bus that configures an fpga and its bridges before populating the devices below it. This is intended for use with device tree overlays. Note that FPGA bridges are seen as reset controllers so no special framework for FPGA bridges will need to be a

[PATCH v9 4/7] staging: fpga manager: add sysfs interface document

2015-07-17 Thread atull
From: Alan Tull Add documentation under drivers/staging for new fpga manager's sysfs interface. Signed-off-by: Alan Tull --- v5 : (actually second version, but keeping version numbers aligned with rest of patch series) Move document to drivers/staging/fpga/Documentation/ABI v6 :

[PATCH v9 5/7] staging: fpga manager core

2015-07-17 Thread atull
From: Alan Tull API to support programming FPGA. The following functions are exported as GPL: * fpga_mgr_buf_load Load fpga from image in buffer * fpga_mgr_firmware_load Request firmware and load it to the FPGA. * fpga_mgr_register * fpga_mgr_unregister FPGA device drivers can be adde

[PATCH v9 3/7] staging: add bindings document for simple fpga bus

2015-07-17 Thread atull
From: Alan Tull New bindings document for simple fpga bus. Signed-off-by: Alan Tull --- .../Documentation/bindings/simple-fpga-bus.txt | 61 1 file changed, 61 insertions(+) create mode 100644 drivers/staging/fpga/Documentation/bindings/simple-fpga-bus.txt diff --

[PATCH v9 7/7] staging: fpga manager: add driver for socfpga fpga manager

2015-07-17 Thread atull
From: Alan Tull Add driver to fpga manager framework to allow configuration of FPGA in Altera SoCFPGA parts. Signed-off-by: Alan Tull Acked-by: Michal Simek --- v2: fpga_manager struct now contains struct device fpga_manager_register parameters now take device v3: skip a version to align

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-17 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, July 17, 2015 9:10 AM > To: KY Srinivasan > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jaso

Re: [PATCH] staging: ion: ion_cma_heap: Don't directly use dma_common_get_sgtable

2015-07-17 Thread Jon Medhurst (Tixy)
On Fri, 2015-07-17 at 16:21 +0100, Robin Murphy wrote: > This also begs the question as to what happens if the memory region _is_ > > contiguous but is in highmem or an ioremapped region. Should a device > > always provide dma_ops for that case? Because I believe the current > > implementation of d

Re: [PATCH] staging: ion: ion_cma_heap: Don't directly use dma_common_get_sgtable

2015-07-17 Thread Laura Abbott
On 07/17/2015 08:21 AM, Robin Murphy wrote: Hi Tixy, On 17/07/15 12:01, Jon Medhurst (Tixy) wrote: Use dma_get_sgtable rather than dma_common_get_sgtable so a device's dma_ops aren't bypassed. This is essential in situations where a device uses an IOMMU and the physical memory is not contiguous

Re: [PATCH 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-07-17 Thread Greg Kroah-Hartman
On Fri, Jul 17, 2015 at 06:51:18PM +0530, Sudip Mukherjee wrote: > Now since all cleanups are done and the code is ready to be merged lets > move it out of staging into fbdev location. This is really hard for the fbdev developers to review. Care to just make up a single patch that adds the driver

Re: [PATCH v9 5/7] staging: fpga manager core

2015-07-17 Thread Randy Dunlap
On 07/17/15 08:51, at...@opensource.altera.com wrote: > From: Alan Tull > > --- > drivers/staging/Kconfig |2 + > drivers/staging/Makefile|1 + > drivers/staging/fpga/Kconfig| 14 ++ > drivers/staging/fpga/Makefile |8 + > drivers/staging/fpga/fpga-mgr.c | 37

Re: [PATCH v9 0/7] FPGA Manager Framework and Simple FPGA Bus

2015-07-17 Thread Jason Gunthorpe
On Fri, Jul 17, 2015 at 10:51:10AM -0500, at...@opensource.altera.com wrote: > From: Alan Tull > > This patchset adds two chunks plus documentation: > * fpga manager core: exports ABI functions that write an image to a FPGA > * DT Overlay support: simple-fpga-bus to handle FPGA from a DT overla

[GIT PULL] Staging driver fixes for 4.2-rc3

2015-07-17 Thread Greg KH
The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754: Linux 4.2-rc1 (2015-07-05 11:01:52 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.2-rc3 for you to fetch changes up to d309509f84725

Re: [PATCH v9 0/7] FPGA Manager Framework and Simple FPGA Bus

2015-07-17 Thread atull
On Fri, 17 Jul 2015, Jason Gunthorpe wrote: > On Fri, Jul 17, 2015 at 10:51:10AM -0500, at...@opensource.altera.com wrote: > > From: Alan Tull > > > > This patchset adds two chunks plus documentation: > > * fpga manager core: exports ABI functions that write an image to a FPGA > > * DT Overlay

Re: [PATCH v9 5/7] staging: fpga manager core

2015-07-17 Thread atull
On Fri, 17 Jul 2015, Randy Dunlap wrote: > On 07/17/15 08:51, at...@opensource.altera.com wrote: > > From: Alan Tull > > > > --- > > drivers/staging/Kconfig |2 + > > drivers/staging/Makefile|1 + > > drivers/staging/fpga/Kconfig| 14 ++ > > drivers/staging/fpga/Ma

Re: [PATCH v2 00/23] staging: rtl8192e: Various cleanups

2015-07-17 Thread Mateusz Kulikowski
On 16.07.2015 11:58, Dan Carpenter wrote: > On Tue, Jul 14, 2015 at 10:04:03PM +0200, Mateusz Kulikowski wrote: >> This series does some more cleanup for driver. >> >> Changes in V2: >> - Added patch 6/23 (Remove rtllib_stats structure as suggested by Dan) >> - Updated patch 22/23 (remove whitespac

Re: [PATCH v9 3/7] staging: add bindings document for simple fpga bus

2015-07-17 Thread Steffen Trumtrar
Hi! On Fri, Jul 17, 2015 at 10:51:13AM -0500, at...@opensource.altera.com wrote: > From: Alan Tull > > New bindings document for simple fpga bus. > > Signed-off-by: Alan Tull > --- > .../Documentation/bindings/simple-fpga-bus.txt | 61 > > 1 file changed, 61 insert

Re: [patch 2/2] Staging: rtl8192e: pointer math bug in rtllib_rx_DELBA()

2015-07-17 Thread Mateusz Kulikowski
n 17.07.2015 11:24, Dan Carpenter wrote: > The "delba" variable is a pointer to struct rtllib_hdr_3addr so this > pointer math bug means that we read nonsense data from beyond the end of > the buffer. It could result in a oops if the memory is not mapped. > > Signed-off-by: Dan Carpenter > > di

[PATCH 0/2] staging: lirc: mostly checkpatch cleanups

2015-07-17 Thread Maciek Borzecki
A tiny patch series that addresses warnings identified by checkpatch. The first patch fixes minor warning with unnecessary brakes around single statement block. The second patch does away with a custom dprintk() in favor of dev_dbg and pr_debug(). The patch is sent separately as the change is more

[PATCH 2/2] staging: media: lirc: lirc_serial: use dynamic debugs

2015-07-17 Thread Maciek Borzecki
Replace custom debug macro dprintk() with pr_debug() or dev_dbg(). Remove unused module param `debug`. This removes the following checkpatch warning: WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... +

[PATCH 1/2] staging: media: lirc: fix various checkpatch warnings

2015-07-17 Thread Maciek Borzecki
Remove unnecessary brakes where appropriate. This removes the following checkpatch warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Maciek Borzecki --- drivers/staging/media/lirc/lirc_imon.c | 8 drivers/staging/media/lirc/lirc_sasem.c | 4 ++--

Re: [PATCH v9 3/7] staging: add bindings document for simple fpga bus

2015-07-17 Thread Jason Gunthorpe
On Fri, Jul 17, 2015 at 09:49:13PM +0200, Steffen Trumtrar wrote: > What you are describing here is a virtual bus, that is not existing on > at least the Socfpga, right? I wouldn't get too hung up on bus or not bus, the HW these days doesn't even use busses. For AXI systems, which is all the ARM

Re: [PATCH v9 3/7] staging: add bindings document for simple fpga bus

2015-07-17 Thread atull
On Fri, 17 Jul 2015, Steffen Trumtrar wrote: > Hi! > > On Fri, Jul 17, 2015 at 10:51:13AM -0500, at...@opensource.altera.com wrote: > > From: Alan Tull > > > > New bindings document for simple fpga bus. > > > > Signed-off-by: Alan Tull > > --- > > .../Documentation/bindings/simple-fpga-bus.t

Re: [PATCH v9 7/7] staging: fpga manager: add driver for socfpga fpga manager

2015-07-17 Thread Moritz Fischer
Alan, it looks pretty good so far. I have worked with Michal and developed a Zynq equivalent against your last patchset which can be found in the Xilinx tree now. I just briefly glanced the changes below just two nits that caught my eye. I'll take a closer look while trying to update the zynq-fpg

Re: [PATCH v9 7/7] staging: fpga manager: add driver for socfpga fpga manager

2015-07-17 Thread atull
On Fri, 17 Jul 2015, Moritz Fischer wrote: Hi Moritz, > Alan, > > it looks pretty good so far. I have worked with Michal and developed a > Zynq equivalent against your last > patchset which can be found in the Xilinx tree now. > > I just briefly glanced the changes below just two nits that caug

Re: [PATCH 5/5] drivers: staging: rtl8192u: fixed coding style issues in r8192U_core.c

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote: > Fixed a few lines that were longer than 80 chars. [] > diff --git a/drivers/staging/rtl8192u/r8192U_core.c > b/drivers/staging/rtl8192u/r8192U_core.c [] > @@ -212,7 +212,9 @@ static void rtl819x_set_channel_map(u8 channel_plan, > st

Re: [PATCH 2/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote: > Reformatting the code without introducing other warnings > like 'Avoid unnecessary line continuations' or breaking strings. Very few of these seem to be improvements and many of them should likely be in separate patches. > diff --gi

Re: [PATCH v5 2/2] staging: rtl8192u: remove unneeded bool

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 11:35 +0200, Luis de Bethencourt wrote: > bool Reval is set to match the value of bHalfWirelessN24GMode just to > this. The value can be returned directly. Removing uneeded bool. trivia: > diff --git a/drivers/staging/rtl8192u/r8192U_core.c > b/drivers/staging/rtl8192u/r819

[PATCH v2 2/3] Documentation/fb: add documentation for sm712fb

2015-07-17 Thread Sudip Mukherjee
Create the documentation for SM712. Mention all the supported modes and how to use. Signed-off-by: Sudip Mukherjee --- Documentation/fb/sm712fb.txt | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/fb/sm712fb.txt diff --git a/Documentation/

[PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-07-17 Thread Sudip Mukherjee
Now since all cleanups are done and the code is ready to be merged lets move it out of staging into fbdev location. Signed-off-by: Sudip Mukherjee --- drivers/staging/Kconfig |2 - drivers/staging/Makefile |1 - drivers/staging/sm7xxfb/Kconfig | 13 - drivers/stagi

[PATCH v2 3/3] MAINTAINERS: update maintainers list

2015-07-17 Thread Sudip Mukherjee
Now since sm712fb has moved out of staging update the maintainers list accordingly. Signed-off-by: Sudip Mukherjee --- MAINTAINERS | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8133cef..2c77c30 100644 --- a/MAINTAINERS +++ b

Re: [PATCH 5/6] staging: rtl8188eu: stop using DBG_88E

2015-07-17 Thread Sudip Mukherjee
On Fri, Jul 17, 2015 at 05:33:55PM +0200, Jakub Sitnicki wrote: > On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee > wrote: > > Stop using DBG_88E which is a custom macro for printing debugging > > messages. Instead start using pr_debug and in the process define > > pr_fmt. > > In the end,

Re: [PATCH 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-07-17 Thread Sudip Mukherjee
On Fri, Jul 17, 2015 at 09:52:35AM -0700, Greg Kroah-Hartman wrote: > On Fri, Jul 17, 2015 at 06:51:18PM +0530, Sudip Mukherjee wrote: > > Now since all cleanups are done and the code is ready to be merged lets > > move it out of staging into fbdev location. > > This is really hard for the fbdev d

[PATCH] staging: lirc: sasem: fix whitespace style issue

2015-07-17 Thread Adi Ratiu
Signed-off-by: Adi Ratiu --- drivers/staging/media/lirc/lirc_sasem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c index 8ebee96..c14ca7e 100644 --- a/drivers/staging/media/lirc/lirc_sasem.c ++