Re: [PATCH] staging: ft1000: Remove boolean comparisons

2015-10-26 Thread Luis de Bethencourt
On 25/10/15 02:20, Greg KH wrote: > On Sun, Oct 18, 2015 at 09:58:15PM +0100, Luis de Bethencourt wrote: >> Boolean tests do not need explicit comparison to true or false. >> >> Signed-off-by: Luis de Bethencourt >> --- >> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c

[PATCH 13/19] staging: sm750fb: use 'struct sm750_dev *' instead of 'void *'

2015-10-26 Thread Mike Rapoport
Use proper 'struct sm750_dev *' type instead of 'void *' Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index

[PATCH 05/19] staging: sm750fb: merge sm750_hw.h into sm750.h

2015-10-26 Thread Mike Rapoport
There is no actual need to split type definitions and global function declarations between lots of small headers. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 1 - drivers/staging/sm750fb/sm750.h| 88 +-

[PATCH 12/19] staging: sm750fb: replace lynx_share with sm750_dev in function calls

2015-10-26 Thread Mike Rapoport
Use sm750_dev rather than lynx_share as parameter for hw_sm750_map, hw_sm750_inithw and hw_sm750_initAccel functions. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 15 --- drivers/staging/sm750fb/sm750.h| 6 +++---

[PATCH 07/19] staging: sm750fb: rename 'struct sm750_dev' variables to sm750_dev

2015-10-26 Thread Mike Rapoport
Use consistent naming for 'struct sm750_dev' variables Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 66 +++--- drivers/staging/sm750fb/sm750_hw.c | 18 +-- 2 files changed, 42 insertions(+), 42

[PATCH 04/19] staging: sm750fb: remove unused smi_indent variable

2015-10-26 Thread Mike Rapoport
The smi_indent variable is only declared, but never used. Remove it. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 2 -- drivers/staging/sm750fb/sm750.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c

[PATCH 09/19] staging: sm750fb: remove unused PROC_SPEC_* typedefs

2015-10-26 Thread Mike Rapoport
The PROC_SPEC* typedefs are not used and can be removed Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index ad20a8a..46c236e

[PATCH 08/19] staging: sm750fb: merge struct sm750_state into struct sm750_dev

2015-10-26 Thread Mike Rapoport
The struct sm750_state is never used on its own. Merge it into the struct sm750_dev. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 40 +++--- drivers/staging/sm750fb/sm750.h| 17 +++-

[PATCH 10/19] staging: sm750fb: replace lynx_share with sm750_dev in lynxfb_par

2015-10-26 Thread Mike Rapoport
Use sm750_dev instead of lynx_share in the private data of the frambuffer device. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 18 +- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_hw.c | 6 +++--- 3

[PATCH 03/19] staging: sm750fb: replace PADDING macro with ALIGN

2015-10-26 Thread Mike Rapoport
The custom macro PADDING differs from standard kernel ALIGN only in parameters order. Replace PADDING with ALIGN and remove it's definition. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 8 drivers/staging/sm750fb/sm750.h| 2 --

[PATCH 06/19] staging: sm750fb: rename struct sm750_share to sm750_dev

2015-10-26 Thread Mike Rapoport
The struct sm750_share represents the device state and name sm750_dev seems more appropriate. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 16 drivers/staging/sm750fb/sm750.h| 4 ++-- drivers/staging/sm750fb/sm750_hw.c | 8

[PATCH 01/19] staging: sm750fb: replace lynx_cursor methods with function calls

2015-10-26 Thread Mike Rapoport
The methods in lynx_cursor always use the same implementation and there is no point to use redirection rather than direct function call. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 34 ++

[PATCH 02/19] staging: sm750fb: remove unused SPC_SM750 define

2015-10-26 Thread Mike Rapoport
The SPC_SM750 define is not used and can be removed Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index c2c217f..2a785ca 100644 ---

[PATCH 11/19] staging: sm750fb: remove hw_sm750_getVMSize function

2015-10-26 Thread Mike Rapoport
The hw_sm750_getVMSize wraps ddk750_getVMSize without any added functionality. Call ddk750_getVMSize directly and remove hw_sm750_getVMSize. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.h| 1 - drivers/staging/sm750fb/sm750_hw.c | 13 ++---

[PATCH 14/19] staging: sm750fb: use sm750_dev with pci_{get, set}_drvdata

2015-10-26 Thread Mike Rapoport
Use sm750_dev as private driver data for the PCI device Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c

Re: [PATCH] staging:lustre: Prevent duplicate CT registrations

2015-10-26 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 03:59:14PM -0400, James Simmons wrote: > diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c > b/drivers/staging/lustre/lustre/lmv/lmv_obd.c > index 635a93c..d6d70d8 100644 > --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c > +++

Re: [PATCH 05/21] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

2015-10-26 Thread Dan Carpenter
On Sat, Oct 24, 2015 at 08:42:29PM +0700, Ivan Safonov wrote: > diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c > b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c > index 98bdc95..735e24b 100644 > --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c > +++

Re: [PATCH 5/5] staging:lustre: Update license and copyright for kernel comm

2015-10-26 Thread Xose Vazquez Perez
James Simmons wrote: > From: frank zago > > Point to the right place for GNU license. Update Intel copyright. > Update Nathan Rutmans email address. This was broken out of the > original patch 14270. > > [...] > > - * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf >

[PATCH 0/2] staging: lustre: remove OBD_PAGE_ALLOC/FREE and friends

2015-10-26 Thread Mike Rapoport
Hi, These patches replace usage of OBD_PAGE_ALLOC and OBD_PAGE_FREE with alloc_page and __free_page respectively and remove the OBD_PAGE_ALLOC/FREE and supporting macros Mike Rapoport (2): staging: lustre: get rid of OBD_PAGE_ALLOC/FREE staging: lustre: remove unused OBD_PAGE_ALLOC/FREE and

[PATCH 1/2] staging: lustre: get rid of OBD_PAGE_ALLOC/FREE

2015-10-26 Thread Mike Rapoport
Use alloc_page and __free_page instead Signed-off-by: Mike Rapoport --- drivers/staging/lustre/lustre/obdecho/echo_client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c

[PATCH 2/2] staging: lustre: remove unused OBD_PAGE_ALLOC/FREE and friends

2015-10-26 Thread Mike Rapoport
The OBD_PAGE_ALLOC/FREE and related macros are not used and can be removed Signed-off-by: Mike Rapoport --- .../staging/lustre/lustre/include/obd_support.h| 30 -- 1 file changed, 30 deletions(-) diff --git

[PATCH 16/19] staging: sm750fb: remove unused field in lynx_cursor

2015-10-26 Thread Mike Rapoport
The lynx_share field in lynx_cursor structure is never used and can be removed. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 1 - drivers/staging/sm750fb/sm750.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c

[PATCH 17/19] staging: sm750fb: merge lynx_share into sm750_dev

2015-10-26 Thread Mike Rapoport
Both struct lynx_share and struct sm750_dev reprsent some parts of the SM750 graphics adapter. There is no point to keep these parts in different structures. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 209 +

[PATCH 15/19] staging: sm750fb: fix wrong indentation

2015-10-26 Thread Mike Rapoport
Fix wrong indentation of a line in lynxfb_set_fbinfo Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index

[PATCH 18/19] staging: sm750fb: remove '#ifdef CAP_EXP*' conditionals

2015-10-26 Thread Mike Rapoport
There are several occurencies of '#ifdef CAP_EXP', spelled differently each time. None of these is ever defined and therefore they enclose dead code that can be removed. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 18 -- 1 file

[PATCH 19/19] staging: sm750fb: remove unused fields from struct sm750_dev

2015-10-26 Thread Mike Rapoport
The {x,y}LCD fields of struct sm750_dev are not used and can be removed. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index

Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc

2015-10-26 Thread glen lee
On 2015년 10월 26일 17:23, Greg KH wrote: On Mon, Oct 26, 2015 at 11:08:43AM +0900, glen lee wrote: On 2015년 10월 25일 10:29, Greg KH wrote: On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote: Use netdev private member wilc instead of g_linux_wlan and Change argument wilc with dev in the

Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc

2015-10-26 Thread Greg KH
On Mon, Oct 26, 2015 at 11:08:43AM +0900, glen lee wrote: > > > On 2015년 10월 25일 10:29, Greg KH wrote: > >On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote: > >>Use netdev private member wilc instead of g_linux_wlan and Change argument > >>wilc > >>with dev in the function

Re: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Dan Carpenter
A few style issues and error handling bugs. See below. On Sun, Oct 25, 2015 at 05:41:23PM -0500, Lijun Pan wrote: > +static int fsl_mc_restool_dev_open(struct inode *inode, struct file *filep) > +{ > + struct fsl_mc_device *root_mc_dev; > + int error = 0; > + struct fsl_mc_io

Re: [PATCH 04/21] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

2015-10-26 Thread Dan Carpenter
On Sat, Oct 24, 2015 at 08:34:55PM +0700, Ivan Safonov wrote: > min macro better conveys the meaning of the code. > Don't these introduce warnings that min_t() is more appropriate? regards, dan carpetner ___ devel mailing list

Re: [PATCH v3 4/7] PCI: Record an fwnode associated with root PCI buses, optionally

2015-10-26 Thread kbuild test robot
Hi Jake, [auto build test ERROR on next-20151022 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/New-paravirtual-PCI-front-end-for-Hyper-V-VMs/20151027-072118 config:

Re: [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h

2015-10-26 Thread Laura Abbott
On 10/25/15 3:16 PM, Dzonatans Melgalvis wrote: Fixed checkpatch.pl warning about comment block coding style. The right aligned comments aren't great style. How about moving the comments (with the correct style) right above the macro they are describing. Signed-off-by: Dzonatans Melgalvis

[PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()

2015-10-26 Thread Punit Vara
This patch is to the host_interface.c that fixes up following warning by checkpatch.pl: -Prefer eth_broadcast_addr() over memset() Signed-off-by: Punit Vara --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 7/7] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

2015-10-26 Thread jakeo
From: Jake Oshins This patch introduces a new driver which exposes a root PCI bus whenever a PCI Express device is passed through to a guest VM under Hyper-V. The device can be single- or multi-function. The interrupts for the devices are managed by an IRQ domain,

[PATCH v3 4/7] PCI: Record an fwnode associated with root PCI buses, optionally

2015-10-26 Thread jakeo
From: Jake Oshins This patch allows a PCI front-end implementation to supply an fwnode_handle associated with a root PCI bus, optionally. If supplied, the PCI driver records this. This patch supports the next patch in the series, which looks up an IRQ domain through this

[PATCH v3 5/7] PCI: irqdomain: Look up IRQ domain by fwnode_handle

2015-10-26 Thread jakeo
From: Jake Oshins The existing PCI code looks for an IRQ domain associated with a root PCI bus by looking in the Open Firmware tree. This patch introduces a second way to identify the associated IRQ domain, if the lookup in the OF tree fails. The handle used for the IRQ

[PATCH v3 2/7] drivers:hv: Export hv_do_hypercall()

2015-10-26 Thread jakeo
From: Jake Oshins This patch exposes the function that hv_vmbus.ko uses to make hypercalls. This is necessary for retargeting an interrupt when it is given a new affinity. Signed-off-by: Jake Oshins --- drivers/hv/hv.c | 20

[PATCH v3 3/7] PCI: Make it possible to implement a PCI MSI IRQ Domain in a module.

2015-10-26 Thread jakeo
From: Jake Oshins The Linux kernel already has the concept of IRQ domain, wherein a component can expose a set of IRQs which are managed by a particular interrupt controller chip or other subsystem. The PCI driver exposes the notion of an IRQ domain for Message-Signaled

[PATCH v3 0/7] New paravirtual PCI front-end for Hyper-V VMs

2015-10-26 Thread jakeo
From: Jake Oshins This patch series updates the one sent on Sept. 10, mostly by rebasing on Mark Zyngier's changes around IRQ domains and the OF tree. First, export functions that allow correlating Hyper-V virtual processors and Linux cpus, along with the means for invoking

[PATCH v3 1/7] drivers:hv: Export a function that maps Linux CPU num onto Hyper-V proc num

2015-10-26 Thread jakeo
From: Jake Oshins This patch exposes the mapping between Linux CPU number and Hyper-V virtual processor number. This is necessary because the hypervisor needs to know which virtual processors to target when making a mapping in the Interrupt Redirection Table in the I/O MMU.

[PATCH v3 6/7] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

2015-10-26 Thread jakeo
From: Jake Oshins This defines the channel type for PCI front-ends in Hyper-V VMs. Signed-off-by: Jake Oshins --- include/linux/hyperv.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h

Re: [PATCH v3 5/7] PCI: irqdomain: Look up IRQ domain by fwnode_handle

2015-10-26 Thread kbuild test robot
Hi Jake, [auto build test ERROR on next-20151022 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/New-paravirtual-PCI-front-end-for-Hyper-V-VMs/20151027-072118 config:

Re: [PATCH v3 7/7] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

2015-10-26 Thread kbuild test robot
Hi Jake, [auto build test WARNING on next-20151022 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/New-paravirtual-PCI-front-end-for-Hyper-V-VMs/20151027-072118 config:

[PATCH v2] staging: rtl8188eu: ternary operator (?:) replaced by min_t macro in efuse_read_phymap_from_txpktbuf

2015-10-26 Thread Ivan Safonov
min_t macro better conveys the meaning of the code. Signed-off-by: Ivan Safonov --- Changes in v2: - big patchset splitted into some small independent patches. - min replaced by min_t. drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Scott Wood
On Sun, 2015-10-25 at 17:41 -0500, Lijun Pan wrote: > The kernel support for the restool (a user space resource management > tool) is a driver for the /dev/dprc.N device file. > Its purpose is to provide an ioctl interface, > which the restool uses to interact with the MC bus driver > and with the

Re: [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()

2015-10-26 Thread Greg KH
On Tue, Oct 27, 2015 at 01:21:46AM +0530, Punit Vara wrote: > This patch is to the host_interface.c that fixes up following > warning by checkpatch.pl: > > -Prefer eth_broadcast_addr() over memset() > > Signed-off-by: Punit Vara > --- >

Re: [PATCH 4/5] staging: fsl-mc: bus rescan attribute to sync kernel with MC

2015-10-26 Thread Greg KH
On Sun, Oct 25, 2015 at 05:41:22PM -0500, Lijun Pan wrote: > Introduce the rescan attribute as a bus attribute to > synchronize the fsl-mc bus objects and the MC firmware. > > To rescan the fsl-mc bus, e.g., > echo 1 > /sys/bus/fsl-mc/rescan > > Signed-off-by: Lijun Pan

Re: [PATCH v3 4/7] PCI: Record an fwnode associated with root PCI buses, optionally

2015-10-26 Thread kbuild test robot
Hi Jake, [auto build test ERROR on next-20151022 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/New-paravirtual-PCI-front-end-for-Hyper-V-VMs/20151027-072118 config:

[PATCH v2 2/2] staging: rtl8188eu: ternary operator (?:) replaced by min kernel macro

2015-10-26 Thread Ivan Safonov
min macro better conveys the meaning of the code. Signed-off-by: Ivan Safonov --- Changes in v2: - big patchset splitted into some small independent patches. - before replacing (?:) to macro min variables given to the appropriate type.

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Stuart Yoder
> -Original Message- > From: Lijun Pan [mailto:lijun@freescale.com] > Sent: Sunday, October 25, 2015 5:41 PM > To: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org; > linux-ker...@vger.kernel.org > Cc: Yoder Stuart-B08248; katz Itai-RM05202; Rivera Jose-B46482;

[PATCH v3 19/23] staging/rdma/hfi: modify workqueue for parallelism

2015-10-26 Thread ira . weiny
From: Mike Marciniszyn The workqueue is currently single threaded per port which for a small number of SDMA engines is ok. For hfi1, the there are up to 16 SDMA engines that can be fed descriptors in parallel. This patch: - Converts to use alloc_workqueue - Changes

[PATCH v3 22/23] staging/rdma/hfi1: add additional rc traces

2015-10-26 Thread ira . weiny
From: Mike Marciniszyn Add additional rc traces to aid in debugging rc retry logic. Reviewed-by: Dennis Dalessandro Signed-off-by: Mike Marciniszyn Signed-off-by: Ira Weiny ---

[PATCH v3 17/23] staging/rdma/hfi1: Add irqsaves in the packet processing path

2015-10-26 Thread ira . weiny
From: Dean Luick In preparation for threading the receive interrupt, add irqsaves in the packet processing path. When the receive interrupt is threaded, the packet processing path is no longer guaranteed to have IRQs disabled. Add irqsaves where needed on several locks in

[PATCH v3 18/23] staging/rdma/hfi1: Thread the receive interrupt.

2015-10-26 Thread ira . weiny
From: Dean Luick When under heavy load, the receive interrupt handler can run too long with IRQs disabled. Add a mixed-mode threading scheme. Initially process packets in the handler for quick responses (latency). If there are too many packets to process move to a thread

[PATCH v3 09/23] staging/rdma/hfi1: Add a schedule in send thread

2015-10-26 Thread ira . weiny
From: Dean Luick When under heavy load, the send handler can run too long without allowing other tasks to run. Add a conditional resched to break this up. Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick

[PATCH v3 14/23] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-10-26 Thread ira . weiny
From: Mitko Haralanov Expected receives work by user-space libraries (PSM) calling into the driver with information about the user's receive buffer and have the driver DMA-map that buffer and program the HFI to receive data directly into it. This is an expensive

[PATCH v3 20/23] staging/rdma/hfi1: Load SBus firmware once per ASIC

2015-10-26 Thread ira . weiny
From: Easwar Hariharan Using fw_sbus_load to control SBus firmware load doesn't scale across multiple HFI1 cards in a single system. This patch ensures that the SBus firmware is loaded once per ASIC. Reviewed-by: Dean Luick Reviewed-by: Dennis

[PATCH v3 08/23] staging/rdma/hfi1: Reset firmware instead of reloading Sbus

2015-10-26 Thread ira . weiny
From: Caz Yokoyama Reset firmware instead of reloading Sbus firmware if it's already done for this ASIC. To work around thermal polling problem in firmware, don't reload Sbus firmware, instead, reset the firmware on the initialization of the second HFI. Reviewed-by:

[PATCH v3 13/23] staging/rdma/hfi1: Wrong cast breaks desired pointer arithmetic

2015-10-26 Thread ira . weiny
From: Mitko Haralanov The address being mapped into a process's memory for notification events was improperly calculated due to cast that was happening too early. dd->events is a pointer and should have been casted to unsigned long after the pointer arithmetic was

[PATCH v3 12/23] staging/rdma/hfi1: Macro code clean up

2015-10-26 Thread ira . weiny
From: Mitko Haralanov Clean up the context and sdma macros and move them to a more logical place in hfi.h Signed-off-by: Mitko Haralanov Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/hfi.h | 22

[PATCH v3 10/23] staging/rdma/hfi1: Fix port bounce issues with 0.22 DC firmware

2015-10-26 Thread ira . weiny
From: Easwar Hariharan The DC firmware overwrites the enable_lane_tx register and does not update it on a host request to go to Poll. This causes an infinite loop through the LNI state machine if a link width downgrade occurs. This patch re-sets the enable_lane_tx

[PATCH v3 05/23] staging/rdma/hfi1: Remove QSFP_ENABLED from HFI capability mask

2015-10-26 Thread ira . weiny
From: Easwar Hariharan The QSFP interface code has been running without issues and the flag is never set to off. This patch removes the QSFP_ENABLED bit from HFI1_CAP. Reviewed-by: Mike Marciniszyn Signed-off-by: Easwar Hariharan

[PATCH v3 15/23] staging/rdma/hfi1: Allow tuning of SDMA interrupt rate

2015-10-26 Thread ira . weiny
From: Mitko Haralanov The SDMA engines were configured to generate progress interrupts every time they processed N/2 descriptors (where N is the size of the descriptor queue). This interval was too infrequent, leading to degraded performance. This commit adds a module

[PATCH v3 11/23] staging/rdma/hfi1: Prevent silent data corruption with user SDMA

2015-10-26 Thread ira . weiny
From: Mitko Haralanov User SDMA keeps track of progress into the submitted IO vectors by tracking an offset into the vectors when packets are submitted. This offset is updated after a successful submission of a txreq to the SDMA engine. The same offset was used when

[PATCH v3 06/23] staging/rdma/hfi1: Add coalescing support for SDMA TX descriptors

2015-10-26 Thread ira . weiny
From: Niranjana Vishwanathapura This fixes transmit errors when the number of scatter gather elements in the request is more that the number of per packet descriptors supported by the hardware, allocate and coalesce the extra scatter gather elements into a

[PATCH v3 07/23] staging/rdma/hfi1: close shared context security hole

2015-10-26 Thread ira . weiny
From: Jareer Abdel-Qader Driver does not verify userid for shared context assignments, allowing malicious user access. Reviewed by: Mike Marciniszyn Signed-off-by: Jareer H Abdel-Qader Signed-off-by:

[PATCH v3 02/23] staging/rdma/hfi1: Fix code to reset ASIC CSRs on FLR

2015-10-26 Thread ira . weiny
From: Easwar Hariharan The ASIC registers were not reset on FLR, and the code to protect the ASIC block against multiple initializations by peer HFIs did not extend to multiple ASICs in a system. This patch addresses this gap. Reviewed-by: Dean Luick

[PATCH v3 16/23] staging/rdma/hfi1: Increase SDMA descriptor queue size

2015-10-26 Thread ira . weiny
From: Ignacio Hernandez A value of 2048 increased PSM performance while not impacting verbs performance. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Signed-off-by: Ignacio Hernandez

[PATCH v3 01/23] staging/rdma/hfi1: Fix regression in send performance

2015-10-26 Thread ira . weiny
From: Mike Marciniszyn The clear_ahg call is new in hfi1 vs qib. For small messages the progress routine always builds one and clears out the ahg state when the queue has gone to empty which is the predominant case for small messages. Inline the routine and avoid

[PATCH v3 00/23] staging/rdma/hfi1: Fix bugs and performance issues

2015-10-26 Thread ira . weiny
From: Ira Weiny The following are fixes to the hfi1 driver for stability, security, and performance. Changes from v2: Rebased to latest staging-next Update commit messages Squashed these patches together:

[PATCH v3 04/23] staging/rdma/hfi1: Prevent host software lock up

2015-10-26 Thread ira . weiny
From: Vennila Megavannan If packets stop egressing the hardware link, software can lock up. Implement a timeout for send context halt recovery. This patch increases the timeout for packet egress to 500 us and timer resets to zero if the packet occupancy changes.

[PATCH v3 03/23] staging/rdma/hfi1: Extend the offline timeout

2015-10-26 Thread ira . weiny
From: Dean Luick The latest version of the 8051 firmware will wait longer when bringing the link down. Extend the driver's timeout to go with that. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick

[PATCH v3 21/23] staging/rdma/hfi1: Add unit # to verbs txreq cache name

2015-10-26 Thread ira . weiny
From: Jubin John The name used to create the verbs txreq cache was not qualified with the unit number. This causes a panic when destroying the cache on a dual HFI systems. Create a unique name with the unit number with this patch Reviewed-by: Mike Marciniszyn

Re: [PATCH 05/21] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

2015-10-26 Thread Ivan Safonov
On 10/26/2015 04:06 PM, Dan Carpenter wrote: On Sat, Oct 24, 2015 at 08:42:29PM +0700, Ivan Safonov wrote: diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c index 98bdc95..735e24b 100644 ---

Re: [PATCH 05/21] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

2015-10-26 Thread Dan Carpenter
On Mon, Oct 26, 2015 at 08:41:06PM +0700, Ivan Safonov wrote: > On 10/26/2015 04:06 PM, Dan Carpenter wrote: > >On Sat, Oct 24, 2015 at 08:42:29PM +0700, Ivan Safonov wrote: > >>diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c > >>b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c >

[PATCH 06/10] staging: fsl-mc: Populate the IRQ pool for an MC bus instance

2015-10-26 Thread J. German Rivera
Scan the corresponding DPRC container to get total count of IRQs needed by all its child DPAA2 objects. Then, preallocate a set of MSI IRQs with the DPRC's ICID (GIT-ITS device Id) to populate the the DPRC's IRQ pool. Each child DPAA2 object in the DPRC and the DPRC object itself will allocate

[PATCH 05/10] staging: fsl-mc: Changed DPRC built-in portal's mc_io to be atomic

2015-10-26 Thread J. German Rivera
The DPRC built-in portal's mc_io is used to send commands to the MC to program MSIs for MC objects. This is done by the fsl_mc_msi_write_msg() callback, which is invoked by the generic MSI layer with interrupts disabled. As a result, the mc_io used in fsl_mc_msi_write_msg needs to be an atomic

[PATCH 04/10] staging: fsl-mc: Extended MC bus allocator to include IRQs

2015-10-26 Thread J. German Rivera
All the IRQs for DPAA2 objects in the same DPRC must use the ICID of that DPRC, as their device Id in the GIC-ITS. Thus, all these IRQs must share the same ITT table in the GIC. As a result, a pool of IRQs with the same device Id must be preallocated per DPRC (fsl-mc bus instance). So, the fsl-mc

[PATCH v2] staging: rtl8188eu: sizeof/sizeof replaced by ARRAY_SIZE kernel macro

2015-10-26 Thread Ivan Safonov
ARRAY_SIZE shorter and more difficult to create bugs. Signed-off-by: Ivan Safonov --- Changes in v2: - big patchset splitted into some small independent patches drivers/staging/rtl8188eu/hal/mac_cfg.c| 2 +- drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +-

[PATCH 00/10] staging: fsl-mc: MC bus MSI support

2015-10-26 Thread J. German Rivera
This patch series addresses the following item from the TODO list for the MC bus driver to exit staging: * Interrupt support. For meaningful driver support we need interrupts, and thus need message interrupt support by the bus driver. MC Bus MSI Support Architecture

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Stuart Yoder
> -Original Message- > From: Lijun Pan [mailto:lijun@freescale.com] > Sent: Sunday, October 25, 2015 5:41 PM > To: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org; > linux-ker...@vger.kernel.org > Cc: Yoder Stuart-B08248; katz Itai-RM05202; Rivera Jose-B46482;

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Lijun Pan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, October 26, 2015 1:20 AM > To: Pan Lijun-B44306 > Cc: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org; > linux-ker...@vger.kernel.org; Yoder

[PATCH 10/10] staging: fsl-mc: Added MSI support to the MC bus driver

2015-10-26 Thread J. German Rivera
Initialize/Cleanup ITS-MSI support for the MC bus driver at driver init/exit time. Associate an MSI domain with each DPAA2 child device. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/bus/mc-bus.c | 12 1 file changed, 12 insertions(+) diff

[PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error path

2015-10-26 Thread J. German Rivera
Destroy mc_io in error path in dprc_probe() only if the mc_io was created in this function. Minor refactoring in error labels. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/bus/dprc-driver.c | 21 - 1 file changed, 16 insertions(+),

[PATCH 03/10] staging: fsl-mc: Added GICv3-ITS support for FSL-MC MSIs

2015-10-26 Thread J. German Rivera
Added platform-specific MSI support layer for FSL-MC devices. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/bus/Makefile| 1 + .../staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 127 +

[PATCH 02/10] staging: fsl-mc: Added generic MSI support for FSL-MC devices

2015-10-26 Thread J. German Rivera
Created an MSI domain for the fsl-mc bus-- including functions to create a domain, find a domain, alloc/free domain irqs, and bus specific overrides for domain and irq_chip ops. Signed-off-by: J. German Rivera --- drivers/staging/fsl-mc/bus/Kconfig | 1 +

[PATCH 09/10] staging: fsl-mc: Added DPRC interrupt handler

2015-10-26 Thread J. German Rivera
The interrupt handler for DPRC IRQs is added. DPRC IRQs are generated for hot plug events related to DPAA2 objects in a given DPRC. These events include, creating/destroying DPAA2 objects in the DPRC, changing the "plugged" state of DPAA2 objects and moving objects between DPRCs. Signed-off-by:

[PATCH v2] staging: rtl8188eu: clamp kernel macro used in proc_get_rx_signal

2015-10-26 Thread Ivan Safonov
To limit the range of integers there is clamp macro. Signed-off-by: Ivan Safonov --- Changes in v2: - big patchset splitted into some small independent patches. drivers/staging/rtl8188eu/core/rtw_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v2] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

2015-10-26 Thread Ivan Safonov
min (or max) kernel macro better conveys the meaning of the code. Signed-off-by: Ivan Safonov --- Changes in v2: - big patchset splitted into some small independent patches. drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 6 ++

[PATCH] staging: rtl8188eu: fixed width data types replaced by int

2015-10-26 Thread Ivan Safonov
There is no need to use fixed width data types. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c

[PATCH v2] staging: rtl8188eu: ternary operator (?:) replaced by min_t/max_t kernel macro

2015-10-26 Thread Ivan Safonov
min_t macro better conveys the meaning of the code. Signed-off-by: Ivan Safonov --- Changes in v2: - big patchset splitted into some small independent patches. - min replaced by min_t. drivers/staging/rtl8188eu/core/rtw_ap.c| 2 +-