On Wed, Nov 04, 2015 at 11:14:57PM -0500, jubin.j...@intel.com wrote:
> From: Sebastian Sanchez
>
> Replacing dd_dev_info() for hfi1_cdbg() to avoid generating syslog
> output for every context that is open by PSM.
>
Just delete it... People get scared about deleting debug code but you
can add
On Wed, Nov 04, 2015 at 09:10:11PM -0500, ira.we...@intel.com wrote:
> From: Vennila Megavannan
>
> Add a module paramter to toggle prescan/Fast ECN Detection.
>
> In addition change the PRESCAN_RXQ Kconfig default to "yes".
>
> Reviewed-by: Arthur Kepner
> Reviewed-by: Mike Marciniszyn
> Signe
Dear Dan,
Because Greg say,
- 'This series doesn't apply probably because I didn't take your previous
series.
Please resend after you refresh and resend that one."
So resend :)
Thanks, BR
Leo
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Thursd
On Wed, Nov 04, 2015 at 09:06:08PM -0500, ira.we...@intel.com wrote:
> +#define CCE_PCIE_CTRL_XMT_MARGIN_GEN1_GEN2_OVERWRITE_ENABLE_MASK 0x1ull
There is absolutely no point to having a variable name which is nine
bajillion characters long since we are not able to use it and have to
instead use ma
Why are you resending these?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch fixes build warning and error reported by kbuild test robot.
It is fixed by including netdevice.h.
>> drivers/staging/wilc1000/wilc_wlan_if.h:940:27: warning: 'struct net_device'
declared inside parameter list
int wilc_wlan_init(struct net_device *dev, wilc_wlan_inp_t *inp);
>> dri
From: Leo Kim
This patch rename QueueCount variable of mac_xmit function to queue_count
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a
From: Leo Kim
This patch renames pMacHeader of function get_if_handler to mac_header
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/
From: Leo Kim
This patch rename pu8UdpBuffer variable of mac_xmit function to udp_buf
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/
From: Leo Kim
This patch remove goto feature from linux_wlan_start_firmware function.
Goto feature is return result.
So, remove goto functions and it was replaced with the return value directly.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 7 +++--
From: Leo Kim
This patch rename Set_machw_change_vir_if function to set_machw_change_vir_if
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6
From: Leo Kim
This patch rename s32Error variable of mac_ioctl function to ret
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drive
From: Leo Kim
This patch rename host_int_get_MacAddress function to hif_get_mac_address
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/host_interface.h | 2 +-
drivers/staging/
From: Leo Kim
This patch removes goto from mac_open function. If address is invalid, goto
handles deinit process and return result.
So, just call deinit process and return the error value directly instead of
goto statement.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wi
From: Leo Kim
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/d
From: Leo Kim
This patch remove goto feature from linux_wlan_firmware_download function.
Goto feature is return result.
So, remove goto functions and it was replaced with the return value directly.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 8 ++
From: Leo Kim
This patch fixes the warnings reported by checkpatch.pl
for Missing a blank line after declarations.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/wilc1000/linux_wlan
From: Leo Kim
This patch renames pBSSID of function linux_wlan_set_bssid to bssid
to avoid CamelCase naming convention.
Also, prototype linux_wlan_set_bssid in wilc_wfi_cfgoperations.c is moved to
wilc_wfi_netdevice.h.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc100
From: Leo Kim
This patch remove goto feature from wlan_initialize_threads function.
Goto feature is 'wilc->close=0' & return result.
So, remove goto feature and it was replaced with the return value directly,
as well as removed unused ret variable.
Also, execute 'wilc->close=0' before return.
Si
From: Leo Kim
This patch renames Bssid1 of function get_if_handler to bssid1
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/st
From: Leo Kim
This patch renames Bssid of function get_if_handler to bssid
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/stag
From: Leo Kim
This patch renames GetIfHandler function name to get_if_handler
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/
From: Leo Kim
This patch removes do-nothing if condition case.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index ae
From: Leo Kim
This patch removes unused defines from linux_wlan.c file.
- NM73131
- PLAT_CLM9722
Two defines are support custom feature that don't used anymore.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 10 ++
1 file changed, 2 insert
From: Leo Kim
This patch fixes add to spaces around that '&&' or '||'.
Reported by checkpatch.pl for spaces required around that '&&' or '||'
(ctx:VxE).
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 5 ++---
1 file changed, 2 insertions(+), 3 dele
From: Leo Kim
This patch removes extern resolve_disconnect_aberration in c file and move
it to proper header file. Rename argument also to match with declaration.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.h | 2 +-
drivers/staging/wilc1000/linu
From: Leo Kim
This patch removes the warnings reported by checkpatch.pl
for line over 80 characters.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 40 +++
1 file changed, 27 insertions(+), 13 deletions(-)
diff --git
From: Leo Kim
This patch renames pstrWFIDrv of function dev_state_ev_handler to hif_drv
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
From: Leo Kim
There are over-commenting in the linux_wlan.c file and most of them
are not helpful to explain what the code does and generate 80 ending
line over warnings. So, all of comments and commented codes are removed in
this patch. Comment will be added if necessary with the preferred Linux
From: Leo Kim
This patch renames pstrWFIDrv of function mac_close to hif_drv
to avoid CamelCase naming convention.
And, some debug print modification that has been included name 'pstrWFIDrv'.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 8
From: Leo Kim
This patch renames pstrWFIDrv of function wilc_set_multicast_list to hif_drv
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --gi
From: Leo Kim
This patch fixes the checks reported by checkpatch.pl
for Blank lines aren't necessary after an open brace '{' and
Blank lines aren't necessary before a close brace '}'.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 21 ---
From: Leo Kim
This patch renames pIP_Add_buff of function dev_state_ev_handler to ip_addr_buf
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-
From: Leo Kim
This patch replace explicit NULL comparison with ! or unmark
operator to simplify code.
Reported by checkpatch.pl for comparison to NULL could be written "!XXX" or
"XXX".
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 45 +
From: Leo Kim
This patch renames pstrWFIDrv of function linux_wlan_init_test_config to hif_drv
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
From: Leo Kim
This patch renames gau8MulticastMacAddrList variable to multicast_mac_addr_list
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 5 +++--
drivers/staging/wilc1000/linux_wlan.c | 11 -
From: Leo Kim
This patch renames strHostIFCfgParamAttr of fuction Handle_CfgParam
to cfg_param_attr to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 154 --
1 file changed, 83 inser
From: Leo Kim
This patch renames pstrHostIfSetMacAddress of fuction Handle_SetMacAddress
to set_mac_addr to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Leo Kim
This patch renames pu8IPAddr of fuction Handle_set_IPAddress to ip_addr
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --
From: Leo Kim
This patch remove unused define CUSTOMER_PLATFORM from linux_wlan.c.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/stag
From: Leo Kim
This patch removes parameter pu8IPAddr of fuction Handle_get_IPAddress because
it is not used in the function. Remove argument in the function call also.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 inse
From: Leo Kim
This patch changes return type of Handle_wait_msg_q_empty from s32 with void
because return value is not used.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drive
From: Leo Kim
This patch renames pstrHostIfGetMacAddress of fuction Handle_GetMacAddress
to get_mac_addr to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Leo Kim
This patch renames firmwareIPAddress of fuction Handle_set_IPAddress to
firmware_ip_addr to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: jareer.h.abdel-qader
During driver load the thermal sensor needs to be reset prior
to initialization of the sensor. This prevents a possible sensor lock
up which can cause the wrong temperature value to be reported.
This fix leads to remove disabling thermal polling from
reset_asic_csrs() f
From: Dean Luick
B0 dual port parts require the SBus firmware to always be
downloaded.
Remove reset of the SBus Master spico. It is not necessary
since the SBus firmware download already does that.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
driv
From: Vennila Megavannan
Some BIOS implementations turn off extended tags in DevCtl (a RW
field) even though it was originally set and is advertised in DevCap
Fix is to set it in the driver
Reviewed-by: Dean Luick
Reviewed-by: Mike Marciniszyn
Reviewed-by: Ashutosh Dixit
Signed-off-by: Vennil
From: Easwar Hariharan
The FLR on driver load asserts the QSFP reset pin and the driver does
not deassert it after. This patch allows the external QSFP cable to exit
reset by writing 1 to all the QSFP pins.
Reviewed-by: Dean Luick
Signed-off-by: Easwar Hariharan
Signed-off-by: Jubin John
---
From: Sebastian Sanchez
Replacing dd_dev_info() for hfi1_cdbg() to avoid generating syslog
output for every context that is open by PSM.
Reviewed-by: Mitko Haralanov
Signed-off-by: Sebastian Sanchez
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/file_ops.c | 10 +-
drivers
On Thu, Nov 05, 2015 at 11:22:47AM +0900, glen lee wrote:
>
> On 2015년 11월 05일 05:41, Greg KH wrote:
> >On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote:
> >>This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52
> >>, and use it instead of g_linux_wlan. Pass wilc to th
On 2015년 11월 05일 05:41, Greg KH wrote:
On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote:
This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52
, and use it instead of g_linux_wlan. Pass wilc to the functions as well.
The void type wilc will be changed with struct wi
From: Arthur Kepner
To more rapidly respond to Explicit Congestion Notifications, prescan the
receive queue, and process FECNs, and BECNs first. When a UC, or RC packet
containing a FECN, or BECN is found, immediately react to the ECN (either by
returning a CNP, or adjusting the injection rate).
From: Arthur Kepner
When HFI1_CAP_DMA_RTAIL is toggled off the "prescan head" can get out of sync
with the receive context's "head". This happens when, after prescan_rxq() newly
arrived packets are then received, and processed by an RX interrupt handler.
This is an unavoidable race, and to avoid
From: Vennila Megavannan
Add a module paramter to toggle prescan/Fast ECN Detection.
In addition change the PRESCAN_RXQ Kconfig default to "yes".
Reviewed-by: Arthur Kepner
Reviewed-by: Mike Marciniszyn
Signed-off-by: Vennila Megavannan
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/K
From: Ira Weiny
The following 3 patches fix the ECN detection and add a module parameter to
turn the prescan of the receive queue on and off.
Arthur Kepner (2):
staging/rdma/hfi1: don't cache "prescan head"
staging/rdma/hfi1: optionally prescan rx queue for {B,F}ECNs - UC, RC
Vennila Megava
On Thu, Nov 05, 2015 at 10:39:59AM +0900, glen lee wrote:
> >>+int wilc_wlan_cfg_set(struct net_device *dev, int start, u32 wid, u8
> >>*buffer,
> >>+ u32 buffer_size, int commit, u32 drvHandler)
> >> {
> >>wilc_wlan_dev_t *p = &g_wlan;
> >>u32 offset;
> >>int ret_size
From: Dean Luick
Correctly set half-swing for integrated devices. A0 needs all fields set for
CcePcieCtrl. B0 and later only need a few fields set.
Reviewed-by: Stuart Summers
Signed-off-by: Dean Luick
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/chip_registers.h | 11 +
driv
On 2015년 11월 05일 05:46, Greg KH wrote:
On Fri, Oct 30, 2015 at 06:47:10PM +0900, Glen Lee wrote:
This patch adds new argument net_device and use netdev private data member
wilc instead of g_linux_wlan, pass dev to the functions also.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/cor
Hi James,
[auto build test WARNING on: staging/staging-next]
[also build test WARNING on: next-20151104]
[cannot apply to: v4.3]
url:
https://github.com/0day-ci/linux/commits/James-Simmons/staging-lustre-wrong-parameter-to-cfs_hash_keycpy/20151105-024407
config: m68k-allmodconfig (attached
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: f0c94bc642d5ff9fbfd18edcf71b9db165e365d3
commit: 30135ce26df214c03c3a9bfe25bcd8f56020bc50 [2491/2494] staging: wilc1000:
wilc_wlan_init: add argument struct net_device
config: i386-allyesconfig (att
Hi James,
[auto build test WARNING on: staging/staging-next]
[also build test WARNING on: next-20151104]
[cannot apply to: v4.3]
url:
https://github.com/0day-ci/linux/commits/James-Simmons/staging-lustre-wrong-parameter-to-cfs_hash_keycpy/20151105-024407
config: i386-randconfig-b0-11050505
Remove wrapper function mfree_sta_priv_lock() that can be replaced by a
direct call to mfree_all_stainfo().
Signed-off-by: Amitoj Kaur Chawla
---
Changes in v2:
-Removed trailing whitespace
drivers/staging/rtl8712/rtl871x_sta_mgt.c | 9 ++---
1 file changed, 2 insertions(+), 7 dele
On Wed, Nov 04, 2015 at 09:36:30PM +0100, Philippe Loctaux wrote:
> Fixed a comment issue.
What comment issue would that be?
And please always use get_maintainer.pl to determine who to cc: patches
to.
thanks,
greg k-h
___
devel mailing list
de...@linu
This patch removes the c2_print_macaddr() wrapper function which calls
the pr_debug standard kernel function only.
c2_print_macaddr() has been replaced by directly calling pr_debug().
Signed-off-by: Amitoj Kaur Chawla
---
Changes in v2:
-Removed comment added in previous version
Changes
On Fri, Oct 30, 2015 at 08:17:37AM +0900, Chaehyun Lim wrote:
> This patch changes return type of host_int_del_beacon from s32 to int.
> The result variable gets return value from wilc_mq_send that has return
> type of int. It should be changed return type of this function as well
> as data type of
On Tue, Nov 03, 2015 at 04:20:58PM +0900, Glen Lee wrote:
> This patch changes WID_TYPE with wid_type which is preferred style.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/coreconfigurator.h | 2 +-
> drivers/staging/wilc1000/wilc_wlan_if.h | 2 +-
> 2 files changed, 2 inser
On Mon, Nov 02, 2015 at 05:50:44PM +0900, Glen Lee wrote:
> From: Leo Kim
>
> This patch renames pu8IPAddr of fuction Handle_set_IPAddress to ip_addr
> to avoid CamelCase naming convention.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/host_interface.c
On Fri, Oct 30, 2015 at 06:47:10PM +0900, Glen Lee wrote:
> This patch adds new argument net_device and use netdev private data member
> wilc instead of g_linux_wlan, pass dev to the functions also.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 3 +-
> driver
On Fri, Oct 30, 2015 at 06:47:09PM +0900, Glen Lee wrote:
> Adds argument struct net_device and use netdev private data member wilc
> instead of g_linux_wlan, pass dev to the functions as well.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 3 ++-
> drivers/sta
On Fri, Oct 30, 2015 at 06:47:08PM +0900, Glen Lee wrote:
> This patch adds new argument struct net_device and pass dev to the function
> as well.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 3 +-
> drivers/staging/wilc1000/coreconfigurator.h | 3 +-
> d
On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote:
> This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52
> , and use it instead of g_linux_wlan. Pass wilc to the functions as well.
> The void type wilc will be changed with struct wilc when SDIO and SPI
> modules are re
On Thu, Oct 29, 2015 at 12:18:51PM +0900, Glen Lee wrote:
> This patch rename os_context to wilc because it is used as struct wilc and
> move os_private from struct wilc_wlan_os_context_t to struct wilc_wlan_inp_t.
> Finally, delete wilc_wlan_os_context_t.
>
> Signed-off-by: Glen Lee
> ---
> dri
Fixed a comment issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.c
b/drivers/staging/comedi/drivers/adv_pci_dio.c
>Hello Dan,
>
>Thanks to report this. This issue was fixed in our code but not up streamed
>yet. The patch is available
>http://git.whamcloud.com/?p=fs%2Flustre->release.git;a=commit;h=d47f00d5a420b594b49564b2e00efca4602c3fb5
I just pushed a proper patch just a bit ago.
___
>On Tue, Nov 03, 2015 at 05:49:00PM -0600, Frank Zago wrote:
>> Yes, but for consistency, all 4 functions should be changed.
>
>Thanks for the review. I will send a v2.
Greg merged your original patch so it will be a new patch.
___
devel mailing list
d
From: Fan Yong
There are some race conditions when check/use cfs_fail_val.
For example: when inject failure stub for LFSCK test as following:
764 if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_DELAY2) &&
765 cfs_fail_val > 0) {
766 struct l_wait_info lwi;
767
768 lwi = LWI_TIMEOUT
From: frank zago
The function libcfs_debug_set_level is used only internally so no reason
to expose it in libcfs_private.h. This is broken out from LU-5829 patch
http://review.whamcloud.com/13319.
Signed-off-by: frank zago
---
.../lustre/include/linux/libcfs/libcfs_private.h |2 --
1 fil
From: Liang Zhen
page_collection::pc_lock is supposed to protect race between
functions called by smp_call_function(), however we don't have
this use-case for ages and page_collection only lives in stack
of thread, so it is safe to remove it.
Signed-off-by: Liang Zhen
Intel-bug-id: https://jira
From: Sebastien Buisson
Fix 'error handling' issues found by Coverity version 6.5.1:
Unchecked return value (CHECKED_RETURN)
Calling function without checking return value.
Signed-off-by: Sebastien Buisson
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3427
Reviewed-on: http://review.whamc
The modinfo data has gone stale for the author information.
This patch changes all the MODULE_AUTHOR to OpenSFS.
Signed-off-by: James Simmons
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204
Reviewed-on: http://review.whamcloud.com/16132
Reviewed-by: Frank Zago
Reviewed-by: Andreas Dilge
From: Dmitry Eremin
Buffer overflow of string buffer due to non null terminated string.
Use strlcpy() when it's justifiable.
Use sizeof(var) instead of constants.
Signed-off-by: Dmitry Eremin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-on: http://review.whamcloud.com/9389
From: frank zago
A lot of symbols don't need to be exported at all because they are
only used in the module they belong to.
Signed-off-by: frank zago
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5829
Reviewed-on: http://review.whamcloud.com/13319
Reviewed-by: James Simmons
Reviewed-by:
From: Liang Zhen
cfs_hash_rehash_key() passed wrong parameter to cfs_hash_keycpy,
hnode should be the second parameter not the third one.
Signed-off-by: Liang Zhen
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4362
Reviewed-on: http://review.whamcloud.com/8509
Reviewed-by: Bobi Jam
Revie
For UMP and SMP machines the struct cfs_cpt_table are
defined differently. In the case handled by this patch
nodemask is defined as a integer for the UMP case and
as a pointer for the SMP case. This will cause a problem
for ost_setup which reads the nodemask directly. Instead
we create a UMP versio
From: Dmitry Eremin
The imp->imp_connection really could be NULL, we better check for it
before dereferencing it in taht call to libcfs_nid2str_r.
Signed-off-by: Dmitry Eremin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6507
Reviewed-on: http://review.whamcloud.com/14808
Reviewed-by: Bo
On Tue, Nov 03, 2015 at 05:49:00PM -0600, Frank Zago wrote:
> Yes, but for consistency, all 4 functions should be changed.
Thanks for the review. I will send a v2.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://drive
On Wed, Nov 04, 2015 at 03:07:13PM +, Simmons, James A. wrote:
> >On Tue, Nov 03, 2015 at 07:46:07PM -0800, Greg Kroah-Hartman wrote:
> >> On Mon, Nov 02, 2015 at 12:22:07PM -0500, James Simmons wrote:
> >> > Cleanup all the unneeded white space in libcfs_hash.h.
> >> >
> >> > Signed-off-by: J
On Wed, Nov 04, 2015 at 09:09:11PM +0700, Ivan Safonov wrote:
> These macros does not used.
I can not understand this sentance.
>
> Signed-off-by: Ivan Safonov
> ---
> drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 7 --
> drivers/staging/rtl8188eu/include/HalVerDef.h | 33
> -
Rename these functions so they have namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers
Rename these functions so they have namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/d
Counters 1 and 2 of the 8254 are cascaeded to create the 32-bit timer
used for the analog input pacer trigger. The base clock to these counters
is 10 MHz.
Counter 0 is available to the user for general purpose use. This counter
can use either an internal 1 MHz clock or an external clock. The
(*ins
An (*insn_read) can only happen if the subdevice is in a non-busy state,
i.e. an async command is not running. The board reset and subdevice
(*cancel) will ensure that the control bits (devpriv->ctrl) are already
cleared.
The (*insn_read) only needs to enable the software trigger before reading
sa
Change the return type to void, this function always succeeds and the
caller does not check the return value anyway.
Fix the initial programming of the control register. The SW bit enables
the software trigger and should not be set here. Setting CNT0 selects the
external clock source for counter 0
For aesthetics, post-increment the 'subdev' index when used to get a
comedi_subdevice pointer instead of incrementing it after the subdevice
is initialized.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 18 +---
The (*cancel) operation should do just that. Remove the setting of the SW bit
which enables the software trigger.
For aesthetics, rename the function so it has namespace associated with the
driver and add a couple comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
Rename this function so it has namespace associated with the driver.
For aesthetics, move the function so it is located in the middle of
the analog input support functions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c
The SDF_GROUND and SDF_COMMON flags are not needed for the analog output
subdevice. Just remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
The analog outputs can use an external reference to create the D/A output
range. Add an entry to the comedi_lrange table for it and modify the
(*insn_write) to support it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c |
Rename these functions so they have namespace associated with the driver.
For aesthetics, move the functions so they are not located in the middle
of the analog input/output support functions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/dr
Rename this function so it has namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ad
1 - 100 of 134 matches
Mail list logo
