Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-18 Thread Hannes Reinecke
On 12/13/2015 09:28 PM, K. Y. Srinivasan wrote: For FC devices managed by this driver, atttach the appropriate transport template. This will allow us to create the appropriate sysfs files for these devices. With this we can publish the wwn for both the port and the node. Signed-off-by: K. Y.

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-18 Thread Hannes Reinecke
On 12/13/2015 09:28 PM, K. Y. Srinivasan wrote: On the interrupt path, we repeatedly establish the pointer to the storvsc_device. Fix this. Signed-off-by: K. Y. Srinivasan Reviewed-by: Long Li Reviewed-by: Johannes Thumshirn

[PATCH 1/1] staging: coding style cleanups for staging/panel driver

2015-12-18 Thread Bijosh T
From: Bijosh T This patch fixes coding style errors for staging/panel driver. Signed-off-by: Bijosh T --- drivers/staging/panel/panel.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/panel/panel.c

[PATCH] staging:dgnc:Creating and destroying sysfs files properly

2015-12-18 Thread Salah Triki
Delegate creation and destruction of sysfs files to device and driver layers in order to eliminate races. Signed-off-by: Salah Triki --- drivers/staging/dgnc/dgnc_driver.c | 11 ++-- drivers/staging/dgnc/dgnc_sysfs.c | 118 ++---

Re: [PATCH V3 1/4] scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet

2015-12-18 Thread Hannes Reinecke
On 12/13/2015 09:28 PM, K. Y. Srinivasan wrote: The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux match the Window's definition. Signed-off-by: K. Y. Srinivasan Reviewed-by: Johannes Thumshirn Reviewed-by: Long Li

Re: [PATCH V3 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

2015-12-18 Thread Hannes Reinecke
On 12/13/2015 09:28 PM, K. Y. Srinivasan wrote: The function storvsc_channel_init() repeatedly interacts with the host to extract various channel properties. Refactor this code to eliminate code repetition. Signed-off-by: K. Y. Srinivasan Reviewed-by: Long Li

[PATCH] staging: wilc1000: fix a bug when unload driver

2015-12-18 Thread Glen Lee
kernel crashes when load and unload driver several times. I used git bisect to track down and found that removing NULL setting caused the panic. This reverts only related codes of the patch(a4ab1ade75a3). Fixes: a4ab1ade75a3 ("staging: wilc1000: replace drvHandler and hWFIDrv with hif_drv")

Re: [PATCH] staging:dgnc:Creating and destroying sysfs files properly

2015-12-18 Thread kbuild test robot
Hi Salah, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.4-rc5 next-20151217] url: https://github.com/0day-ci/linux/commits/Salah-Triki/staging-dgnc-Creating-and-destroying-sysfs-files-properly/20151218-171643 config: i386-randconfig-i0-201550 (attached

[PATCH V2] staging: dgnc: Creating and destroying sysfs files properly

2015-12-18 Thread Salah Triki
Delegate creation and destruction of sysfs files to device and driver layers in order to eliminate races. Signed-off-by: Salah Triki --- drivers/staging/dgnc/dgnc_driver.c | 11 ++-- drivers/staging/dgnc/dgnc_sysfs.c | 118 ++---

[no subject]

2015-12-18 Thread Muthoot Finance Pvt. Ltd
Get your CHRISTMAS loan at @ 3%. Apply Now for 48hours Approval. Contact us via e-Mail: muthootfinancceh...@gmail.com if interested. (Serious Inquiry Only) === Holen Sie sich Ihre WEIHNACHTS Darlehen zu @ 3%. Jetzt bewerben fьr 48 Stunden Zulassung. Kontaktieren Sie uns per E-Mail:

Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver

2015-12-18 Thread Willy Tarreau
On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote: > From: Bijosh T > > This patch fixes coding style errors for staging/panel driver. > > Signed-off-by: Bijosh T Acked-by: Willy Tarreau Thanks Bijosh, Willy

[PATCH 5/5] staging: media: lirc: use new parport device model

2015-12-18 Thread Sudip Mukherjee
Modify lirc_parallel driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 100 +++-- 1 file changed, 65 insertions(+), 35 deletions(-) diff --git

[PATCH 3/5] staging: media: lirc: space around operator

2015-12-18 Thread Sudip Mukherjee
checkpatch complains about missing space around operators. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH 4/5] staging: media: lirc: place operator on previous line

2015-12-18 Thread Sudip Mukherjee
checkpatch complains about the logical operator, which should be on the previous line. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 1/5] staging: media: lirc: replace NULL comparisons with !var

2015-12-18 Thread Sudip Mukherjee
A NULL comparison can be written as if (var) or if (!var). Reported by checkpatch. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/5] staging: media: lirc: no space after cast

2015-12-18 Thread Sudip Mukherjee
checkpatch complains about space after type cast. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_parallel.c

[PATCH] staging: update panel driver's author address

2015-12-18 Thread Willy Tarreau
I'm realizing that I sometimes miss e-mails sent to my old address, so better update it. Since I only have the relevant hardware at my work place, let's use this address so that I can test code if needed. Signed-off-by: Willy Tarreau --- MAINTAINERS| 2 +-

Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-18 Thread James Bottomley
On Fri, 2015-12-18 at 09:49 +0100, Hannes Reinecke wrote: > What I would like to see is a clear separation here: > - Disable FC disk handling if FC attributes are not configured > - Add a module parameter allowing to disable FC attributes even if > they are compiled in. Remember: this is a

RE: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-18 Thread KY Srinivasan
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, December 18, 2015 12:52 AM > To: KY Srinivasan ; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; > jbottom...@parallels.com;

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-18 Thread James Bottomley
On Fri, 2015-12-18 at 16:20 +, KY Srinivasan wrote: > > > -Original Message- > > From: Hannes Reinecke [mailto:h...@suse.de] > > Sent: Friday, December 18, 2015 12:52 AM > > To: KY Srinivasan ; gre...@linuxfoundation.org; > > linux- > > ker...@vger.kernel.org;

RE: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-18 Thread KY Srinivasan
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, December 18, 2015 12:49 AM > To: KY Srinivasan ; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; > jbottom...@parallels.com;

[PATCH 1/1] staging: coding style cleanups for staging/panel driver

2015-12-18 Thread Bijosh Thykkoottathil
From: Bijosh Thykkoottathil This patch fixes coding style errors for staging/panel driver. Signed-off-by: Bijosh Thykkoottathil --- drivers/staging/panel/panel.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] staging: wilc1000: fix bug in sdio/spi

2015-12-18 Thread Greg KH
On Thu, Nov 12, 2015 at 11:35:26AM +0900, Glen Lee wrote: > sdio_init and wilc_spi_init always return error, so it fails everytime. > Fix this by removing else statement. > > This fixes c1af9db78950a778ec18343c5c5a6d4cfbf58a61, > bacd388547f55eb415ce266c8723cc6f1281a25d Please fix up how these

Re: [PATCH 1/4] staging: wilc1000: remove define COMPLEMENT_BOOT

2015-12-18 Thread Greg KH
On Thu, Nov 19, 2015 at 11:05:58AM +0900, Glen Lee wrote: > This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed > by the following commit but the define was not removed. So remove completely. > > b46d68825c2d3af70ad18b53dfed6516e393b7fa Please fix this up and resend

Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup()

2015-12-18 Thread Greg Kroah-Hartman
On Sat, Dec 05, 2015 at 01:04:34AM +0300, Alexey Khoroshilov wrote: > If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(), > it calls release_bus() and continues execution. But it leads to double > release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex. > > The

Re: [PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

2015-12-18 Thread Greg KH
On Tue, Dec 01, 2015 at 11:49:55PM -0300, Mario J. Rugiero wrote: > struct set_multicast uses (implicitly) sizeof(bool) to determine how many > bytes to copy in > Handle_SetMulticastFilter. Since that is implementation defined, it triggered > sparse to > rightfully complain about shifting a

Re: [PATCH] Staging: comedi: pcmcia: fixed a line with over 80 chars

2015-12-18 Thread Greg KH
On Sun, Dec 13, 2015 at 05:40:34PM +0100, Philippe Loctaux wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: line over 80 characters > > Signed-off-by: Philippe Loctaux > --- > drivers/staging/comedi/comedi_pcmcia.h | 6 -- > 1 file changed, 4

Re: [PATCH 3/4] staging: wilc1000: Fix typo in linux_wlan.c

2015-12-18 Thread Greg KH
On Mon, Nov 23, 2015 at 10:41:19PM +0900, Masanari Iida wrote: > This patch fix some spelling typo in wilc1000.c. > > Signed-off-by: Masanari Iida > Acked-by: Randy Dunlap > --- > drivers/staging/wilc1000/linux_wlan.c | 16 > 1

Re: [PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

2015-12-18 Thread Mario J. Rugiero
El 18/12/15 a las 19:50, Greg KH escribió: On Tue, Dec 01, 2015 at 11:49:55PM -0300, Mario J. Rugiero wrote: struct set_multicast uses (implicitly) sizeof(bool) to determine how many bytes to copy in Handle_SetMulticastFilter. Since that is implementation defined, it triggered sparse to

Re: [PATCH 2/3] staging/rdma/hfi1: Fix module parameter spelling

2015-12-18 Thread Jubin John
On Fri, Dec 18, 2015 at 09:42:20AM +0300, Dan Carpenter wrote: > Nice. Whenever you see a bug like this, you should report it to > kernel-janitors because you know that 10 other people have made the same > mistake. Sure, I will do that for similar bugs. > > I will take care of it. Thank you. >

Re: [PATCH 01/12] staging: wilc1000: pass vif to hostIFthread

2015-12-18 Thread Greg KH
On Mon, Dec 14, 2015 at 02:46:52PM +0900, Glen Lee wrote: > We will pass vif, which is currently being used as net_device, instead of > hif_dev. This is the first step to use index of vif to pass to the driver. > Add new argument vif to all the functions that send message to hostIFthread > and >

Re: [PATCH 3/6] staging: wilc1000: wilc_wlan.c: remove hif_func of wilc_wlan_dev_t

2015-12-18 Thread Greg KH
On Fri, Nov 20, 2015 at 04:56:33PM +0900, Glen Lee wrote: > hif_func of wilc_wlan_dev_t is duplicate because we have same struct > wilc_hif_func ops of struct wilc which is available in wilc_wlan.c. > Rename ops of struct wilc with hif_func and remove hif_func of > wilc_wlan_dev_t, > and use

Re: [PATCH 1/4] staging: wilc1000: linux_wlan_spi.c: return linux error value

2015-12-18 Thread Greg KH
On Wed, Nov 25, 2015 at 06:35:26PM +0900, Glen Lee wrote: > return linux error value instead of 0 or 1 and use -EINVAL. Related codes > also changed together. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/linux_wlan_spi.c | 14 +++--- >

Re: [PATCH 2/5] staging: wilc1000: remove unneeded function

2015-12-18 Thread Greg KH
On Thu, Nov 26, 2015 at 02:04:00PM +0900, Glen Lee wrote: > wilc_spi_init in linux_wlan_spi.c is unneeded. It just return true. Rename > _wilc_spi_init in wlan_spi.c to wilc_spi_init. > > Signed-off-by: Glen Lee Series did not apply :(

Re: [PATCH 01/10] staging: wilc1000: sdio/spi: use device print api instead of custom one

2015-12-18 Thread Greg KH
On Mon, Nov 23, 2015 at 06:47:59PM +0900, Glen Lee wrote: > This patch use device print api instead of driver defined print. Remove > varialbe dPrint as well. String "[wilc sdio]" and "[wilc spi]" are also > removed > from all the print statment if exist because it shows which device the message

Re: [PATCH v4 00/58] mtd: nand: refactor the NAND subsystem (part 1)

2015-12-18 Thread Brian Norris
Hi, On Thu, Dec 10, 2015 at 08:59:44AM +0100, Boris Brezillon wrote: > Hello, > > This huge series aims at clarifying the relationship between the mtd and > nand_chip structures and hiding NAND framework internals to NAND > controller drivers. > > The first part of the series (patch 1 to 4) is

Re: [PATCH v4 55/58] mtd: nand: add helpers to access ->priv

2015-12-18 Thread Brian Norris
Hi Boris, On Thu, Dec 10, 2015 at 09:00:39AM +0100, Boris Brezillon wrote: > Add two helpers to access the field reserved for private controller data. > This makes it clearer what this field is reserved for and ease future > refactoring. I agree with the refactoring part, but I'm not sure about

Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver

2015-12-18 Thread Willy Tarreau
On Sat, Dec 19, 2015 at 11:55:13AM +0530, Sudip Mukherjee wrote: > On Fri, Dec 18, 2015 at 08:01:58AM -0800, Greg KH wrote: > > On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote: > > > From: Bijosh T > > > > > > This patch fixes coding style errors for

RE: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-18 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Friday, December 18, 2015 8:48 AM > To: KY Srinivasan ; Hannes Reinecke ; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; >

solutions for your business

2015-12-18 Thread Joe Franklin
Hello, Do you need more business? Do you need more sales? We can generate you new buying leads and increase your sales by our target marketing mailing service. It will grow your business sales 1-2 times than what it is now. Please reply for pricing and proposal. Thanks, Joe Franklin Email:

Re: [PATCH 1/1] staging: coding style cleanups for staging/panel driver

2015-12-18 Thread Sudip Mukherjee
On Fri, Dec 18, 2015 at 08:01:58AM -0800, Greg KH wrote: > On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote: > > From: Bijosh T > > > > This patch fixes coding style errors for staging/panel driver. > > > > Signed-off-by: Bijosh T > > I