From: David Binder
Initializes previously uninitialized variables that were flagged
as being problematic by Smatch.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
From: Alexander Curtin
This adds kerneldoc style comments to the visor_driver struct since
it's shared between multiple modules.
Signed-off-by: Alexander Curtin
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 65 --
From: Alexander Curtin
The visor_device struct is used between multiple drivers, so this
adds kerneldoc comments to the fields.
Signed-off-by: Alexander Curtin
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 45 +++
For 'struct visor_driver' and 'struct visor_device':
* unused members have been removed
* kernel-doc comments have been added
Alexander Curtin (2):
staging: unisys: include: Added kernel-doc for struct visor_driver
staging: unisys: include: Added kerneldoc comments to visor_device
Tim Sel
From: Tim Sell
The build_date and build_time fields are not used, and have been removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b/driver
This patch changes data type of result variable from s32 to int. result
is used to get return value from wilc_send_config_pkt that has return
type of int.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() functions are used as result,
others are used as ret. It will be changed as ret in all handle_*()
functions to match variable name.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc100
When handle_set_ip_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_inter
On Tue, Apr 19, 2016 at 5:36 AM, Dan Carpenter wrote:
> On Tue, Apr 19, 2016 at 02:24:47AM +0900, Mark Laws wrote:
>> Sorry, I don't understand--which part are you suggesting we remove?
>
> The call to i8042_controller_check() or move it to the probe function or
> something. Why must we have the
On 04/17/2016 05:35 PM, Tobin C Harding wrote:
drivers/staging/android/ion/ion.c calls BUG_ON in places where WARN_ON will
suffice.
This patch replaces two such occurences. Two other occurences remain.
You got the logic flow correct but I'd prefer to keep the BUG_ON.
It's catching actual bugs
On Tue, Apr 19, 2016 at 02:24:47AM +0900, Mark Laws wrote:
> On Tue, Apr 19, 2016 at 1:54 AM, Dan Carpenter
> wrote:
> > So if the user inserts the module without a keyboard then in the
> > original code they would just put a keyboard in and try again. Now they
> > have to do an extra rmmod. Wh
The struct mite_channel 'dir' member specifies if the dma is input
or output. Wrap the mite_sync_input_dma() and mite_sync_output_dma()
functions with a single mite_sync_dma() so that the drivers don't
have to worry about the sync direction.
The functions that actually sync the input/output dma cu
Most of the mite registers are only accessed by the mite driver.
There is no reason to expose the register/bit info. Remove this
info from the header.
For aesthetics, convert the bit info enums into defines and use
the BIT() macro to define them. Tidy up the inline functions for
the retry limit an
The functions that get the number of bytes written to and read from
memory are only used internally by the mite driver when syncing the
dma channel. Make them static and remove the exports.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/driver
This member of mite_struct is only used to map the mite I/O window.
For aesthetics, remove it and use a local variable instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 7 ---
drivers/staging/comedi/drivers/mite
Introduce a helper function to handle the ack of a LINKC interrupt.
Tidy up the drivers that use the new helper.
The mite_get_status() function is not only used by the mite driver.
Make it static and remove the export.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
Add a comment to fix the checkpatch.pl issue:
CHECK: spinlock_t definition without comment
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/mite.h
For aesthetics, convert the register/bit enums into defines and
use the BIT() macro to define the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.h | 88 +--
1 file changed, 44 insertions(+), 4
The mite_release_channel() will disarm and reset the mite channel.
Remove the redundant calls in ni_pcidio_release_di_mite_channel().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 2 --
1 file changed, 2 deletions(-)
di
Prior to calling this function pci_ioremap_bar() is called. If the
pci_resource_len(), i.e. the 'size', was 0 the ioremap would fail
so this function would never be called. So the first BUG_ON() can
never occur.
The 'order' returned by ilog2() will always be > 0 so the second
BUG_ON() will also ne
This function is only called by the mite driver. Remove the inline
function from the header and make it static in the driver.
Use the function in mite_prep_dma() instead of duplicating the code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/
Rename the CamelCase symbols to fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.h
b/driv
This member of mite_struct is set but never used. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 1 -
drivers/staging/comedi/drivers/mite.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/c
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 29 +++--
drivers/staging/comedi/drivers/mite.h | 17 +
2 files changed, 24 insertions(+), 22 deletions(-)
d
This exported function is not used by any of the comedi drivers. The
only call point in mite.c is commented out. Remove the unused function
and the export.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 9 -
drivers/st
This macro is not used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
b/drivers/staging/comedi/drivers/mite.c
index ceaf1ec.
Fix all the checkpatch.pl issues and tidy up this driver.
H Hartley Sweeten (15):
staging: comedi: mite: Prefer 'unsigned int' to bare use of 'unsigned'
staging: comedi: mite: remove TOP_OF_PAGE() macro
staging: comedi: mite: remove mite_dma_tcr()
staging: comedi: mite: don't export intern
Hi, how are you? My name is J Eric Denials, External Financial Auditor at
Lloyds Banking Group plc., London. It is a pleasure to contact you at this time
through this medium. I have a cool and legitimate deal to do with you as you're
a foreigner, it will be mutually beneficial to both. If you’re
Hi, how are you? My name is J Eric Denials, External Financial Auditor at
Lloyds Banking Group plc., London. It is a pleasure to contact you at this time
through this medium. I have a cool and legitimate deal to do with you as you're
a foreigner, it will be mutually beneficial to both. If you’re
> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
> Sent: Monday, April 18, 2016 10:00 AM
> To: KY Srinivasan ; Alexander Duyck
>
> Cc: David Miller ; Netdev
> ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; Robo Bot
> ; Jason Wang ;
> e..
--
Hello,
I'm looking for someone who can handle my business & personal errands at
his/her spare time as I keep travelling a lot. Someone who can offer me
these
services mentioned below:
* Mail services (Receive my mails and drop them off at UPS or USPS)
* Shop for Gifts
* Bill payment (pa
Hi, how are you? My name is J Eric Denials, External Financial Auditor at
Lloyds Banking Group plc., London. It is a pleasure to contact you at this time
through this medium. I have a cool and legitimate deal to do with you as you're
a foreigner, it will be mutually beneficial to both. If you’re
Hi, how are you? My name is J Eric Denials, External Financial Auditor at
Lloyds Banking Group plc., London. It is a pleasure to contact you at this time
through this medium. I have a cool and legitimate deal to do with you as you're
a foreigner, it will be mutually beneficial to both. If you’re
On Tue, Apr 19, 2016 at 1:54 AM, Dan Carpenter wrote:
> So if the user inserts the module without a keyboard then in the
> original code they would just put a keyboard in and try again. Now they
> have to do an extra rmmod. What about if we just removed the test for
> if the keyboard is present?
On Mon, 2016-04-18 at 16:52 +, KY Srinivasan wrote:
[]
> > > +bool ixgbevf_on_hyperv(struct ixgbe_hw *hw)
> > > +{
> > > + if (hw->mbx.ops.check_for_msg == NULL)
> > > + return true;
> > > + else
> > > + return false;
> > > +}
trivia:
bool func(...)
{
So if the user inserts the module without a keyboard then in the
original code they would just put a keyboard in and try again. Now they
have to do an extra rmmod. What about if we just removed the test for
if the keyboard is present?
On Tue, Apr 19, 2016 at 12:23:36AM +0900, Mark Laws wrote:
>
> -Original Message-
> From: Alexander Duyck [mailto:alexander.du...@gmail.com]
> Sent: Monday, April 18, 2016 9:18 AM
> To: KY Srinivasan
> Cc: David Miller ; Netdev
> ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; Robo Bot
> ; Jason Wang ;
> e...@mellan
On Sun, Apr 17, 2016 at 10:22 PM, K. Y. Srinivasan wrote:
> On Hyper-V, the VF/PF communication is a via software mediated path
> as opposed to the hardware mailbox. Make the necessary
> adjustments to support Hyper-V.
>
> Signed-off-by: K. Y. Srinivasan
> ---
> V2: Addressed most of the
As explained in 1407814240-4275-1-git-send-email-de...@microsoft.com:
> hyperv_keyboard invokes serio_interrupt(), which needs a valid serio
> driver like atkbd.c. atkbd.c depends on libps2.c because it invokes
> ps2_command(). libps2.c depends on i8042.c because it invokes
> i8042_check_port_ow
Hi,
Please keep me Cc:ed in any replies as I'm not on these lists.
Description of the fix is in the commit message for the patch.
Discussion:
Given that most distributions were already statically linking i8042.c,
having it not unload even if there is no i8042 device seems a better fix
than the
Sua caixa de correio excedeu o limite de armazenamento, que é de 20 GB
como conjunto pelo administrador, você está atualmente em execução no
20,9 GB, você pode não ser capaz de Enviar ou receber novas mensagens
até que você re-validar sua caixa de correio. Para Revalide sua caixa
de correio, po
On Mon, 18 Apr 2016 17:32:49 +0300
Roger Quadros wrote:
> Boris,
>
> On 30/03/16 19:14, Boris Brezillon wrote:
> > Implementing the mtd_ooblayout_ops interface is the new way of exposing
> > ECC/OOB layout to MTD users.
> >
> > Signed-off-by: Boris Brezillon
> > ---
> > drivers/mtd/nand/omap2
Boris,
On 30/03/16 19:14, Boris Brezillon wrote:
> Implementing the mtd_ooblayout_ops interface is the new way of exposing
> ECC/OOB layout to MTD users.
>
> Signed-off-by: Boris Brezillon
> ---
> drivers/mtd/nand/omap2.c | 194
> +++
> 1 file change
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Monday, April 18, 2016 5:59 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; Haiyang Zhang
> ; Alex Ng (LIS) ; Cathy
> Avery ; de...@linuxdriverproject.org
> Subject: Re: [PATCH 0/2] Drivers: hv:
Vitaly Kuznetsov writes:
> Hi,
>
> I found an issue (crash) while testing memory hotplug on WS2016TP4 host.
> It should be easily reproducible with the following test sequence
> (4.6-rc2):
>
> 1) Start a VM with 4 vCPUs in 4 NUMA nodes, 4096Mb of RAM.
> 2) Enable memory auto onlining with
>
On Sun, 2016-04-17 at 21:35 +, Drokin, Oleg wrote:
> On Apr 17, 2016, at 10:11 AM, Panos Vlachos wrote:
> > Fixed one coding style issue in the
> > file router_proc.c (Lustre staging driver)
> Perhaps it's best to reference what the issue is.
> I.e. "Fix too long line in …"
> and then in the ac
46 matches
Mail list logo
