Re: [PATCH] android: binder: Disable preemption while holding the global binder lock

On Sat, Sep 10, 2016 at 10:28 AM, Greg Kroah-Hartman wrote: > On Sat, Sep 10, 2016 at 06:37:29PM +0200, Thomas Gleixner wrote: >> On Sat, 10 Sep 2016, Peter Zijlstra wrote: >> >> > On Sat, Sep 10, 2016 at 09:16:59AM -0700, Christoph Hellwig wrote: >> > > On Thu, Sep

[PATCH] hv: do not lose pending heartbeat vmbus packets

From: Long Li The host keeps sending heartbeat packets independent of guest responding to them. In some situations, there might be multiple heartbeat packets pending in the ring buffer. Don't lose them, read them all. Signed-off-by: Long Li ---

drivers: staging: vme: Fixed some code style warnings

Signed-off-by: Andrew Kanner --- drivers/staging/vme/devices/vme_pio2_core.c | 12 ++-- drivers/staging/vme/devices/vme_user.c | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2_core.c

[PATCH 2/2] pci-hyperv: properly handle device eject

From: Long Li A PCI_EJECT message can arrive at the same time we are calling pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message, in this case we could potentailly modify the bus from two places. Properly lock the bus access. Signed-off-by:

[PATCH 1/2] pci-hyperv: properly handle pci bus remove

From: Long Li hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is already removed before the call, so we don't need to rescan the bus in the workqueue scheduled from

Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue

On Mon, 2016-09-12 at 19:07 +0100, Ian Abbott wrote: > On 12/09/16 18:29, Namrata A Shettar wrote: > > This patch fixes the checkpatch.pl issue: > -Please don't use multiple blank lines [] > diff --git a/drivers/staging/comedi/comedi_pcmcia.c [] > @@ -18,7 +18,6 @@ > >  

[RFCv3][PATCH 0/5] Cleanup Ion mapping/caching

Hi, This is v3 on the attempt to remove the misuse of the DMA cache APIS from Ion. As from before: The APIs created are kernel_force_cache_clean and kernel_force_cache_invalidate. They force a clean and invalidate of the cache, respectively. The aim was to take the semantics of dma_sync and turn

[RFCv3][PATCH 5/5] staging: ion: Add support for syncing with DMA_BUF_IOCTL_SYNC

dma_buf added support for a userspace syncing ioctl. It is implemented by calling dma_buf_begin_cpu_access and dma_buf_end_cpu_access. Ion currently lacks cache operations on this code path. Add them for compatibility with the dma_buf ioctl. Signed-off-by: Laura Abbott ---

[RFCv3][PATCH 4/5] staging: android: ion: Convert to the kernel_force_cache APIs

Now that there exists a proper set of cache sync APIs, move away from the dma_sync and do less bad things. Signed-off-by: Laura Abbott --- v3: Rebased to latest-next --- drivers/staging/android/ion/ion.c | 22 --

[RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

arm64 may need to guarantee the caches are synced. Implement versions of the kernel_force_cache API to allow this. Signed-off-by: Laura Abbott --- v3: Switch to calling cache operations directly instead of relying on DMA mapping. --- arch/arm64/include/asm/cacheflush.h | 8

[RFCv3][PATCH 1/5] Documentation: Introduce kernel_force_cache_* APIs

Some frameworks (e.g. Ion) may need to do explicit cache management to meet performance/correctness requirements. Rather than piggy-back on another API and hope the semantics don't change, introduce a set of APIs to force a page to be cleaned/invalidated in the cache. Signed-off-by: Laura Abbott

[RFCv3][PATCH 2/5] arm: Impelment ARCH_HAS_FORCE_CACHE

arm64 may need to guarantee the caches are synced. Implement versions of the kernel_force_cache API for v7. Other versions are stubbed out and can be added as appropriate. Signed-off-by: Laura Abbott --- v3: Switch to force implementations per CPU instead of relying on

[PATCH] staging: rtl8712: fix block comments

This patch fixes the following checkpatch.pl warning: Block comments use * on subsequent lines Signed-off-by: Shaily Sangwan --- drivers/staging/rtl8712/rtl8712_recv.h | 14 +- drivers/staging/rtl8712/rtl871x_cmd.h | 264 - 2 files

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep 2016,

Re: [PATCH 00/26] constify local structures

On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at

Re: [PATCH] staging: squash lines for simple wrapper functions

Masahiro Yamada writes: > Remove unneeded variables and assignments. > > While we are here, clean up the following as well: > - refactor rtl8723a_get_bcn_valid() a bit > - remove unneeded casts in sii164Get{Vendor,Device}ID() > > Signed-off-by: Masahiro Yamada

Re: [PATCHv3 1/3] devicetree: bindings for Ion

On 08/30/16 17:04, Laura Abbott wrote: > This adds a base set of devicetree bindings for the Ion memory > manager. This supports setting up the generic set of heaps and > their properties. > > Signed-off-by: Laura Abbott > --- > drivers/staging/android/ion/devicetree.txt |

Re: [PATCH 00/26] constify local structures

On Mon, Sep 12, 2016 at 03:52:08PM +0200, Julia Lawall wrote: > > > On Mon, 12 Sep 2016, Felipe Balbi wrote: > > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep

Re: [PATCH] staging: rtl8712: fix coding style error reported from checkpatch

On Mon, 2016-09-12 at 21:02 +0300, Omri Arad wrote: [] > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c [] > @@ -1976,9 +1976,9 @@ static int r871x_get_ap_info(struct net_device *dev, >   if (pdata->length >= 32) { >  

Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue

On 12/09/16 18:29, Namrata A Shettar wrote: This patch fixes the checkpatch.pl issue: -Please don't use multiple blank lines Signed-off-by: Namrata A Shettar > --- drivers/staging/comedi/comedi_pcmcia.c | 1 -

[PATCH] staging: rtl8712: fix coding style error reported from checkpatch

removed the following: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line WARNING: Statements should start on a tabstop Signed-off-by: Omri Arad --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 4 ++-- 1 file changed, 2

Re: [PATCH resend] staging: comedi: comedi_fops: coding style fixes

On 12/09/16 14:18, Matias Mucciolo wrote: From: Matias Mucciolo Those three lines are unnecessary, especially the initial blank line. I'm not sure whether Greg will ask you to fix it up. - Fixed coding style in comedi_fops.c Symbolic to octal permission.

[PATCH 4.4 123/192] [PATCH 127/135] x86/hyperv: Avoid reporting bogus NMI status for Gen2 instances

4.4-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 1e2ae9ec072f3b7887f456426bc2cf23b80f661a ] Generation2 instances don't support reporting the NMI status on port 0x61, read from there returns 'ff' and we end up reporting nonsensical

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Remove ternary operator

On Mon, Sep 12, 2016 at 8:14 PM, Jes Sorensen wrote: > On 09/12/16 09:58, Bhumika Goyal wrote: >> Relational and logical operators evaluate to either true or false. >> Explicit conversion is not needed so remove the ternary operator. >> Done using coccinelle: >> >> @r@ >>

Re: [PATCH resend] staging: comedi: comedi_fops: coding style fixes

Hi Ian yes its a coding style issue(checkpatch.pl WARN) and reference: https://lwn.net/Articles/696229/ (sorry about the noise.) -- Matias Mucciolo Area de Infraestructura. Piedras 737 C.A.B.A SUTEBA On Monday 12 September 2016 16:52:59 Ian Abbott wrote: > On 12/09/16 14:18, Matias

Re: [PATCH] android: binder: Disable preemption while holding the global binder lock

Thanks for the reviews. We'll come up with a different solution. On Sat, Sep 10, 2016 at 10:28 AM, Greg Kroah-Hartman wrote: > On Sat, Sep 10, 2016 at 06:37:29PM +0200, Thomas Gleixner wrote: >> On Sat, 10 Sep 2016, Peter Zijlstra wrote: >> >> > On Sat, Sep 10, 2016

Re: [PATCH resend] staging: comedi: comedi_fops: coding style fixes

On 12/09/16 14:18, Matias Mucciolo wrote: From: Matias Mucciolo - Fixed coding style in comedi_fops.c Symbolic to octal permission. Signed-off-by: Matias Mucciolo --- drivers/staging/comedi/comedi_fops.c | 6 +++--- 1 file changed, 3

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Remove ternary operator

On 09/12/16 09:58, Bhumika Goyal wrote: > Relational and logical operators evaluate to either true or false. > Explicit conversion is not needed so remove the ternary operator. > Done using coccinelle: > > @r@ > expression A,B; > symbol true,false; > binary operator b = {==,!=,&&,||,>=,<=,>,<}; >

[PATCH 0/2] staging: most: fix issues of core

This patch set is needed to fix issues of the core module of the MOST driver. Andrey Shvetsov (2): staging: most: core: show all linked channels staging: most: core: constify structure member drivers/staging/most/mostcore/core.c | 18 +-

[PATCH 1/2] staging: most: core: show all linked channels

This patch is needed to have all linked channels being reported by the show() function of the attribute file add_link. Currently user space can only read back the latest link that has been established to a certain channel. Signed-off-by: Andrey Shvetsov Signed-off-by:

[PATCH 2/2] staging: most: core: constify structure member

From: Andrey Shvetsov This patch adds the const qualifier to the declaration of the member name_suffix of structure most_channel_capability. It is needed since it points to string literals. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian

[PATCH] staging: vme/devices: vme_user.c: fix: converted decimal permissions to octal

Ran checkpatch.pl -f vme_user.c Fixed: ERROR: Use 4 digit octal (0777) not decimal permissions Signed-off-by: Ryan Swan --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c

[PATCH] Staging: rtl8188eu: Remove ternary operator

Relational and logical operators evaluate to either true or false. Explicit conversion is not needed so remove the ternary operator. Done using coccinelle: @r@ expression A,B; symbol true,false; binary operator b = {==,!=,&&,||,>=,<=,>,<}; @@ - (A b B) ? true : false + A b B Signed-off-by:

Re: [PATCH 00/26] constify local structures

On Mon, Sep 12, 2016 at 3:43 PM, Felipe Balbi wrote: > Jarkko Sakkinen writes: >> On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >>> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >>> > On Sun, Sep 11, 2016 at 03:05:42PM

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia

Re: [PATCH 00/26] constify local structures

Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >>

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > > Constify local structures. > > > > > > > > The

[PATCH resend] staging: comedi: comedi_fops: coding style fixes

From: Matias Mucciolo - Fixed coding style in comedi_fops.c Symbolic to octal permission. Signed-off-by: Matias Mucciolo --- drivers/staging/comedi/comedi_fops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 00/26] constify local structures

On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > Constify local structures. > > > > > > The semantic patch that makes this change is as follows: > > >

Re: [PATCH] stagging:iio:ad9834: add devicetree property support

Hi, Thanks for the patch. On 09/11/2016 12:52 PM, Gwenhael Goavec-Merou wrote: > +static struct ad9834_platform_data *ad9834_parse_dt(struct spi_device *spi) > +{ > + struct ad9834_platform_data *pdata; > + struct device_node *np = spi->dev.of_node; > + > + pdata = devm_kzalloc(>dev,

Re: [PATCH v3 07/21] staging: unisys: Move vbushelper.h contents to visorbus_private.h

On Fri, Sep 02, 2016 at 04:41:31PM -0400, David Kershner wrote: > From: Bryan Thompson > > The contents of vbushelper.h are now only used by visorbus, so it no longer > needs to be a general include file and it can be incorporated in the > visorbus private header. > >

Re: [PATCH v3 00/21] Clean up header files and remove unused structures

On Fri, Sep 02, 2016 at 04:41:24PM -0400, David Kershner wrote: > This patch series starts the process of addressing the issues > raised by Greg-KH on 08/21/2016, more patches will be coming. > > This patch series removes unused defines and structures in visorbus. > > It also combines and

Re: [PATCH] staging: dgnc: dgnc_sysfs *_ATTR() macros convert

On Fri, Sep 09, 2016 at 12:42:33PM -0300, Matias Mucciolo wrote: > > Convert DRIVER_ATTR() macro with DRIVER_ATTR_RO/RW and > DEVICE_ATTR() macro with DEVICE_ATTR_RO() Nice, I like seeing this type of change. greg k-h ___ devel mailing list

Re: [PATCH 1/1] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

On Sat, Sep 03, 2016 at 04:16:29PM +0530, Nadim Almas wrote: > Fixed coding style issue > > Signed-off-by: Nadim Almas > --- > drivers/staging/dgnc/dgnc_neo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_neo.c

Re: [PATCH] Staging: wlan-ng: improve code aspect in p80211req_mibset_mibget()

On Tue, Sep 06, 2016 at 07:30:50PM +0300, Claudiu Beznea wrote: > This patch improves code aspect in p80211req_mibset_mibget() function > by removing accolades which followed case statements. To do so, > some data variable ware declared at the beginning of the > function and also pstr and key

Re: [PATCH 2/2] staging: sm750fb: fix block comment style and spelling issues in ddk750_chip.c

On Sun, Sep 04, 2016 at 09:04:10PM +0300, Moshe Green wrote: > Fix the following warning types: > - line length > - block comment line * prefix > - trailing */ on a separate line > found by the checkpatch.pl tool in multiple block comments. > > Fix a single spelling error in a comment. > >

Re: [PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c

On Sun, Sep 04, 2016 at 09:03:27PM +0300, Moshe Green wrote: > Fix multiple line length warnings found by the checkpatch.pl tool > in ddk750_chip.c. > > Signed-off-by: Moshe Green > --- > drivers/staging/sm750fb/ddk750_chip.c | 18 -- > 1 file changed, 12

Re: [PATCH] staging: comedi: comedi_fops: coding style fixes

On Thu, Sep 08, 2016 at 03:27:49PM -0300, Matias Mucciolo wrote: > > - Fixed coding style in comedi_fops.c Symbolic to octal permission. > > Signed-off-by: Matias Mucciolo > Reviewed-by: Ian Abbott > --- > drivers/staging/comedi/comedi_fops.c | 6

Re: [PATCH] staging: emxx_udc: Remove unnecessary blank line

On Mon, Sep 12, 2016 at 03:47:12PM +0530, Rehas Sachdeva wrote: > This patch fixes the checkpatch.pl warning: > Blank lines aren't necessary before a close brace '}' > > Signed-off-by: Rehas Sachdeva > --- > drivers/staging/emxx_udc/emxx_udc.c | 1 - > 1 file changed, 1

Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings

On Fri, Sep 09, 2016 at 08:50:35PM +0530, Nayeemahmed Badebade wrote: > Added __acquires / __releases sparse locking annotations > to lock_res_and_lock and unlock_res_and_lock functions in > l_lock.c, to fix below sparse warnings: > > l_lock.c:47:22: warning: context imbalance in

Re: [PATCHv3 0/3] Devicetree bindings for Ion

On Tue, Aug 30, 2016 at 05:04:26PM -0700, Laura Abbott wrote: > Hi, > > This is a long overdue resend and slight update from the last version[1] of > Ion devicetree bindings. > > The goal here is to keep the Ion bindings minimalist. I experimented with > dropping all but a dummy devicetree node

Re: [PATCH] Fix checkpatch.pl error in lowmemkiller.c

On Fri, Sep 02, 2016 at 10:28:48PM +0530, Chinmay Nivsarkar wrote: > This patch fixes checkpatch.pl error WARNING: line over 80 characters #95: > FILE: drivers/staging/android/lowmemorykiller.c:95: > > Signed-off-by: Chinmay Nivsarkar > --- >

[PATCH] staging: emxx_udc: Remove unnecessary blank line

This patch fixes the checkpatch.pl warning: Blank lines aren't necessary before a close brace '}' Signed-off-by: Rehas Sachdeva --- drivers/staging/emxx_udc/emxx_udc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

Re: [PATCH] staging/android: mark sync_timeline_create() static

On Mon, Sep 05, 2016 at 08:40:25AM +0800, Baoyou Xie wrote: > > > On 4 September 2016 at 23:41, Sudip Mukherjee > wrote: > > On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > >

Re: [PATCH] staging: ks7010: mark symbols static where possible

On Thu, Sep 08, 2016 at 07:37:24PM +0800, Baoyou Xie wrote: > We get 3 warnings when building kernel with W=1: > drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for > 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes] > drivers/staging/ks7010/ks7010_sdio.c:121:6:

Re: [PATCH] Fix checkpatch.pl error in drivers:staging:ks7010:ks_wlan_net.c

On Sun, Sep 11, 2016 at 02:37:07PM +0530, Chinmay Nivsarkar wrote: > Fixes error foo * bar should be foo *bar in line #843 > > Signed-off-by: Chinmay Nivsarkar > --- > drivers/staging/ks7010/ks_wlan_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Does not

Re: [PATCH] staging: ks7010: mark symbols static where possible

On Sun, Sep 04, 2016 at 02:38:39PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/staging/ks7010/ks_hostif.c:72:6: warning: no previous prototype for > 'ks_wlan_hw_wakeup_task' [-Wmissing-prototypes] > drivers/staging/ks7010/ks_hostif.c:1508:6: warning: no

Re: [PATCH 1/5] staging: ks7010: Fix coding style warning in ks7010_sdio.c

On Sat, Sep 03, 2016 at 10:35:48PM +0530, Sabitha George wrote: > This patch fixes the coding style warning ' braces {} are not > necessary for single statement blocks' found by checkpatch.pl > > Signed-off-by: Sabitha George > --- >

Re: [PATCH 4/5] staging: ks7010: Fix warnings on printk() usage

On Sat, Sep 03, 2016 at 10:51:49PM +0530, Sabitha George wrote: > This patch fixes the following warnings on ks7010_sdio.c > 1. printk() should include KERN_ facility level > 2. Prefer [subsystem eg: netdev]_err([subsystem]dev, ... > then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... >

Re: [PATCH 00/26] constify local structures

On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > Constify local structures. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > Just my two cents but: > > 1. You *can* use a static

[PATCH] [media] pulse8-cec: avoid uninitialized data use

Building with -Wmaybe-uninitialized reveals the use on an uninitialized variable containing the physical address of the device whenever firmware before version 2 is used: drivers/staging/media/pulse8-cec/pulse8-cec.c: In function 'pulse8_connect':

Re: [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions

On Fri, Sep 02, 2016 at 02:57:44PM +0200, Luca Ceresoli wrote: > These functions have been declared without any implementation since > the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there > has been no mention of them in following commits. > > Signed-off-by: Luca Ceresoli

Re: [PATCH v3 1/6] staging: rtl8723au: remove unimplemented functions declaration

On Tue, Sep 06, 2016 at 06:36:52PM +0200, Luca Ceresoli wrote: > These functions have been declared without any implementation since > the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there > has been no mention of them in following commits. > > Signed-off-by: Luca Ceresoli

Re: [PATCH] rtlbt: Add RTL8822BE Bluetooth device

Hi Larry, > The RTL8822BE is a new Realtek wifi and BT device. Support for the BT > part is hereby added. > > As this device is similar to most of the other Realtek BT devices, the > changes are minimal. The main difference is that the 8822BE needs a > configuration file for enabling and

Re: [PATCH] staging: vme/devices: vme_user.c: fix: converted decimal permissions to octal

On Sun, Sep 11, 2016 at 03:40:30PM -0400, Ryan Swan wrote: > From: ryan If your email client is ok (and yours seems to be), you don't need this line as it would rename the author of the patch. This name needs to match the signed-off-by: line exactly. > > Ran checkpatch.pl