Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread Dan Carpenter
On Mon, Dec 19, 2016 at 08:47:50AM -0800, Bruce Korb wrote: > On Mon, Dec 19, 2016 at 8:22 AM, James Simmons > >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_

[PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

2016-12-19 Thread Larry Finger
With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb"), the method used to free an skb was changed because the kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() guards against a NULL value for the argument. Routine dev_kfree_skb_irq() does not, and

[PATCH 2/2] staging: greybus: loopback_test: Fix race preventing test completion

2016-12-19 Thread Bryan O'Donoghue
commit 9250c0ee2626 ("greybus: Loopback_test: use poll instead of inotify") changes the flow of determining when to break out of a loop polling for loopback test completion. The clause is_complete() which determines if all tests are complete - as used is subject to a race condition where one of th

[PATCH 0/2] staging: greybus: loopback fixes and updates

2016-12-19 Thread Bryan O'Donoghue
Two simple patches here resulting from using greybus on gbsim and developing support for async. I found a bug in the user-space tool and while doing that decided to update the kernel thread to be better behaved when waiting for test completions. Bryan O'Donoghue (2): staging: greybus: loopback:

[PATCH 1/2] staging: greybus: loopback: use gb_loopback_async_wait_all don't spin

2016-12-19 Thread Bryan O'Donoghue
Currently the greybus-loopback thread logic spins around waiting for send_count == iteration_max which on real hardware doesn't make a difference to us but in simulation is excruciatingly slow, anti-social and bad manners. Use the existing gb_loopback_async_wait_all() function to gate continuing wh

Re: [PATCH v2] fix code alignment with open parenthesis

2016-12-19 Thread Scott Matheina
On 12/19/2016 12:35 AM, Greg KH wrote: On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote: These changes where identified by checkpatch.pl as needed changes to align the code with the linux development coding style. The several lines of text where aligned with the precending parent

Re: [PATCH 4/4] vmbus: document numa_node sysfs

2016-12-19 Thread Stephen Hemminger
On Mon, 19 Dec 2016 18:44:12 + KY Srinivasan wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, December 19, 2016 10:21 AM > > To: Vitaly Kuznetsov ; KY Srinivasan > > ; Haiyang Zhang > > Cc: de...@linuxdriverproject.org; S

Re: [PATCH] staging: vc04_services: Fix bracing on single statement blocks

2016-12-19 Thread Eric Anholt
Aaron Moore writes: > Fix coding style issue caught by checkpatch.pl relating to braces on > single statement blocks. This issue was corrected in 3 locations. > > Signed-off-by: Aaron Moore Reviewed-by: Eric Anholt signature.asc Description: PGP signature

RE: [PATCH 4/4] vmbus: document numa_node sysfs

2016-12-19 Thread KY Srinivasan
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, December 19, 2016 10:21 AM > To: Vitaly Kuznetsov ; KY Srinivasan > ; Haiyang Zhang > Cc: de...@linuxdriverproject.org; Stephen Hemminger > > Subject: [PATCH 4/4] vmbus: document numa_node

Re: [PATCH] staging: comedi: cb_pcidas64: Fixed coding issue about multiple line dereferencing

2016-12-19 Thread kbuild test robot
Hi devendra, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.9 next-20161219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/devendra-sharma/staging-comedi

[PATCH 4/4] vmbus: document numa_node sysfs

2016-12-19 Thread Stephen Hemminger
Update ABI to include numa_node. Signed-off-by: Stephen Hemminger --- Documentation/ABI/stable/sysfs-bus-vmbus | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-bus-vmbus b/Documentation/ABI/stable/sysfs-bus-vmbus index 183d14420152..dfd76b8c36aa 100644

[PATCH v2 0/4] expose numa_node and update sysfs ABI docs

2016-12-19 Thread Stephen Hemminger
Same patch, but with more documentation Stephen Hemminger (4): vmbus: expose numa_node via sysfs vmbus: fix documentation of sysfs path vmbus: document sysfs ABI for bind/unbind vmbus: document numa_node sysfs Documentation/ABI/stable/sysfs-bus-vmbus | 44 +++-

[PATCH 2/4] vmbus: fix documentation of sysfs path

2016-12-19 Thread Stephen Hemminger
With commit 9a56e5d6a0ba ("Drivers: hv: make VMBus bus ids persistent") the name of vmbus devices in sysfs changed to be (in 4.9-rc1): /sys/bus/vmbus/vmbus-6aebe374-9ba0-11e6-933c-00259086b36b The sysfs ABI documentation was not updated. Signed-off-by: Stephen Hemminger --- Documentation/

[PATCH 3/4] vmbus: document sysfs ABI for bind/unbind

2016-12-19 Thread Stephen Hemminger
Bind/unbind support was added by commit 381b803a68deb28 ("vmbus: add support for dynamic device id's"). Signed-off-by: Stephen Hemminger --- Documentation/ABI/stable/sysfs-bus-vmbus | 24 1 file changed, 24 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-bus-v

[PATCH 1/4] vmbus: expose numa_node via sysfs

2016-12-19 Thread Stephen Hemminger
Provide numa node information via sysfs for devices on Hyper-V vmbus. This is for some NUMA aware applications (like DPDK). This is already done in PCI. Signed-off-by: Stephen Hemminger --- drivers/hv/vmbus_drv.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/hv/vm

Re: [PATCH] staging: comedi: cb_pcidas64: Fixed coding issue about multiple line dereferencing

2016-12-19 Thread Ian Abbott
On 19/12/2016 15:14, devendra sharma wrote: Fixed coding issue about multiple line dereferencing Signed-off-by: Devendra Sharma --- drivers/staging/comedi/drivers/cb_pcidas64.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) I guess this is version 3 of the patch? di

Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay

2016-12-19 Thread Ozgur Karatas
19.12.2016, 08:35, "Greg KH" : > On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote: >>  These changes where identified by checkpatch.pl as needed changes to >>  align the code with the linux development coding style. The several >>  lines of text where aligned with the precending paren

Re: [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments

2016-12-19 Thread Ian Abbott
On 19/12/2016 14:36, devendra sharma wrote: Added comments before memory barrier Signed-off-by: Devendra Sharma --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/dri

Re: [PATCH] staging: comedi: ni_670x: using the BIT(x) macro

2016-12-19 Thread Ian Abbott
On 16/12/2016 20:20, Saber Rezvani wrote: Fix the checkpatch.pl issue: CHECK: Prefer using the BIT macro replacing bit shifting on 1 with the BIT(x) macro. Signed-off-by: Saber Rezvani --- drivers/staging/comedi/drivers/ni_670x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks

Re: [PATCH] staging: comedi: ni_at_ao: using the BIT(x) macro

2016-12-19 Thread Ian Abbott
On 16/12/2016 20:06, Saber Rezvani wrote: Fix the checkpatch.pl issue: CHECK: Prefer using the BIT macro replacing bit shifting on 1 with the BIT(x) macro. Signed-off-by: Saber Rezvani --- drivers/staging/comedi/drivers/ni_at_ao.c | 62 +++ 1 file changed, 31 inse

Re: [PATCH 3/3] staging: comedi: cb_pcidas64: use preferred kernel type u32

2016-12-19 Thread Ian Abbott
On 16/12/2016 19:15, Saber Rezvani wrote: Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Saber Rezvani --- drivers/staging/comedi/drivers/cb_pcidas64.c | 38 ++-- 1 file changed, 19 insertions(+), 19 deletions(-) Thanks!

Re: [PATCH 2/3] staging: comedi: cb_pcidas64: use preferred kernel type u16

2016-12-19 Thread Ian Abbott
On 16/12/2016 19:15, Saber Rezvani wrote: Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u16' over 'uint16_t' Signed-off-by: Saber Rezvani --- drivers/staging/comedi/drivers/cb_pcidas64.c | 58 ++-- 1 file changed, 29 insertions(+), 29 deletions(-) Thanks!

Re: [PATCH 1/3] staging: comedi: cb_pcidas64: use preferred kernel type u8

2016-12-19 Thread Ian Abbott
On 16/12/2016 19:15, Saber Rezvani wrote: Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u8' over 'uint8_t' Signed-off-by: Saber Rezvani --- drivers/staging/comedi/drivers/cb_pcidas64.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) Thanks!

Re: [PATCH] vmbus: expose numa_node via sysfs

2016-12-19 Thread Stephen Hemminger
On Mon, 19 Dec 2016 17:07:25 + KY Srinivasan wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, December 19, 2016 8:20 AM > > To: Greg KH > > Cc: KY Srinivasan ; Haiyang Zhang > > ; Vitaly Kuznetsov ; > > de...@linuxdriverp

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> On Mon, Dec 19, 2016 at 8:22 AM, James Simmons > >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_lock > >> *req, __u64 *flags, > >> int added = (mode

Re: [lustre-devel] [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> James, > > > This should be a purely syntactical change, to help out tools - for GCC, I'm > pretty sure the meaning of { > } and { NULL } are the same.  Also, I don't think struct randomization does > what you're thinking. Yep. I misread his commit message. That is why it didn't make sense

RE: [PATCH] vmbus: expose numa_node via sysfs

2016-12-19 Thread KY Srinivasan
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, December 19, 2016 8:20 AM > To: Greg KH > Cc: KY Srinivasan ; Haiyang Zhang > ; Vitaly Kuznetsov ; > de...@linuxdriverproject.org > Subject: Re: [PATCH] vmbus: expose numa_node via sysfs >

[PATCH] staging: lustre: headers: potential UAPI headers

2016-12-19 Thread James Simmons
Not for landing. This is the purposed UAPI headers with the removal of unlikely and debugging macros. This is just for feedback to see if this is acceptable for the upstream client. Signed-off-by: James Simmons --- .../lustre/lustre/include/lustre/lustre_fid.h | 353 + .

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-19 Thread James Simmons
> On Tue, Dec 13, 2016 at 12:55:01AM +, Dilger, Andreas wrote: > > On Dec 12, 2016, at 13:00, James Simmons wrote: > > > > > > > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > >>> In order for lustre_idl.h to be usable for both user > > >>> land and kernel space it

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread Bruce Korb
On Mon, Dec 19, 2016 at 8:22 AM, James Simmons >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_lock >> *req, __u64 *flags, >> int added = (mode == LCK_NL);

Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring

2016-12-19 Thread James Simmons
> A recent clean-up declared och_flags as a int rather than fmode_t. This > lead to the following sparse warning: > > drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted > fmode_t degrades to integer > > This patch fixes this issue. Acked-by: James Simmons > Fixes: 0a12009

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook > --- > driver

Re: [PATCH] vmbus: expose numa_node via sysfs

2016-12-19 Thread Stephen Hemminger
On Sat, 17 Dec 2016 23:56:11 -0800 Greg KH wrote: > On Fri, Dec 16, 2016 at 02:54:48PM -0800, Stephen Hemminger wrote: > > From: Stephen Hemminger > > > > Provide numa node information via sysfs for devices on Hyper-V > > (same as PCI). > > This is for some NUMA aware applications (like DPDK).

[PATCH] staging: comedi: cb_pcidas64: Fixed coding issue about multiple line dereferencing

2016-12-19 Thread devendra sharma
Fixed coding issue about multiple line dereferencing Signed-off-by: Devendra Sharma --- drivers/staging/comedi/drivers/cb_pcidas64.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb

[PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments

2016-12-19 Thread devendra sharma
Added comments before memory barrier Signed-off-by: Devendra Sharma --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c index c9eb26f..c3b5236 10064

Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue

2016-12-19 Thread Dan Carpenter
On Sun, Dec 18, 2016 at 04:46:50PM +, Afonso Bordado wrote: > Converts from CamelCase to the recommended style. > > Signed-off-by: Afonso Bordado > --- > drivers/staging/emxx_udc/emxx_udc.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/sta

Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

2016-12-19 Thread Dan Carpenter
He's talking about the final close curly brace }. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

2016-12-19 Thread Luca Coelho
On Thu, 2016-12-15 at 07:15 +0200, Michael S. Tsirkin wrote: > That's the default now, no need for makefiles to set it. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/bluetooth/Makefile| 2 -- > drivers/net/can/Makefile | 1