Re: [PATCH 07/14] vmbus: remove conditional locking of vmbus_write

On Fri, Jan 27, 2017 at 10:36:16AM -0800, Stephen Hemminger wrote: > On Fri, 27 Jan 2017 18:08:35 + > KY Srinivasan wrote: > > > > -Original Message- > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Monday, January 23, 2017 5:40 PM > >

[PATCH v2] Staging: speakup - syle fix permissions to octal

A style fix across whole driver. changed permissions to octal style, found using checkpatch Signed-off-by: Derek Robson --- First version had spaces before praenthesis, now fixed in this version. drivers/staging/speakup/main.c | 4 ++--

[PATCH] Staging: speakup - syle fix permissions to octal

A style fix across whole driver. changed permissions to octal style, found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/speakup/main.c | 4 ++-- drivers/staging/speakup/speakup.h| 4 ++-- drivers/staging/speakup/speakup_acntpc.c | 26

[RFC] vmbus: lockless ring write

On Fri, 27 Jan 2017 18:08:35 + KY Srinivasan wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, January 23, 2017 5:40 PM > > To: KY Srinivasan ; Haiyang Zhang > >

Re: [RFC] vmbus: lockless ring write

On Fri, 27 Jan 2017 16:01:37 -0800 Stephen Hemminger wrote: > On Fri, 27 Jan 2017 18:08:35 + > KY Srinivasan wrote: > > > > -Original Message- > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Monday,

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: > Generated with checkpatch.pl --fix-inplace and git add -p out of the > results. Maybe another. > diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c > b/drivers/staging/media/platform/bcm2835/mmal-vchiq.c [] > @@ -239,7 +239,7

[PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the module.

This is derived from the downstream tree's build system, but with just a single Kconfig option. For now the driver only builds on 32-bit arm -- the aarch64 build breaks due to the driver using arm-specific cache flushing functions. Signed-off-by: Eric Anholt ---

[PATCH 5/6] staging: bcm2835-v4l2: Apply many whitespace fixes from checkpatch.

Generated with checkpatch.pl --fix-inplace, some manual fixes for cases where checkpatch fixed one out of multiple lines of mis-indented function parameters, and then git add -p out of the results. I skipped some fixes that should probably instead be replaced with the BIT() macro. Signed-off-by:

[PATCH 2/6] staging: bcm2835-v4l2: Update the driver to the current VCHI API.

49bec49fd7f2 ("staging: vc04_services: remove vchiq_copy_from_user") removed the flags/msg_handle arguments, which were unused, and pushed the implementation of copying using memcpy vs copy_from_user to the caller. Signed-off-by: Eric Anholt ---

[PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

Generated with checkpatch.pl --fix-inplace and git add -p out of the results. Signed-off-by: Eric Anholt --- drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 +++--- drivers/staging/media/platform/bcm2835/mmal-vchiq.c | 12 ++-- 2 files changed, 9

[PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Here's my first pass at importing the camera driver. There's a bunch of TODO left to it, most of which is documented, and the rest being standard checkpatch fare. Unfortunately, when I try modprobing it on my pi3, the USB network device dies, consistently. I'm not sure what's going on here yet,

[PATCH 4/6] staging: bcm2835-v4l2: Add a TODO file for improvements we need.

Signed-off-by: Eric Anholt --- drivers/staging/media/platform/bcm2835/TODO | 39 + 1 file changed, 39 insertions(+) create mode 100644 drivers/staging/media/platform/bcm2835/TODO diff --git a/drivers/staging/media/platform/bcm2835/TODO

RE: [Resend PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject

> -Original Message- > From: Long Li [mailto:lon...@exchange.microsoft.com] > Sent: Monday, January 23, 2017 9:46 PM > To: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas > Cc: de...@linuxdriverproject.org;

Re: [PATCH 07/14] vmbus: remove conditional locking of vmbus_write

On Fri, 27 Jan 2017 18:08:35 + KY Srinivasan wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, January 23, 2017 5:40 PM > > To: KY Srinivasan ; Haiyang Zhang > >

RE: [Resend PATCH 1/2 v3] pci-hyperv: properly handle pci bus remove

> -Original Message- > From: Long Li [mailto:lon...@exchange.microsoft.com] > Sent: Monday, January 23, 2017 9:45 PM > To: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas > Cc: de...@linuxdriverproject.org;

[PATCH] staging: rtl8188eu: Fix coding style issues

Convert leading spaces to tabs Signed-off-by: William Blough --- drivers/staging/rtl8188eu/core/rtw_security.c | 128 +- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c

RE: [PATCH 07/14] vmbus: remove conditional locking of vmbus_write

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, January 23, 2017 5:40 PM > To: KY Srinivasan ; Haiyang Zhang > > Cc: de...@linuxdriverproject.org; Stephen Hemminger >

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 05:43:47PM +0300, Dan Carpenter wrote: > Heh. I would just leave this one alone for now. > > Everyone hates all the potential changes more than we hate going over > 80 characters. > > regards, > dan carpenter > Understood. Thanks Maxime

RE: [PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, January 19, 2017 7:12 AM > To: Cathy Avery > Cc: KY Srinivasan ; Haiyang Zhang > ; j...@linux.vnet.ibm.com; >

Re: [PATCH] greybus: Fix coding stye error

Heh. I would just leave this one alone for now. Everyone hates all the potential changes more than we hate going over 80 characters. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 05:13:01PM +0300, Dan Carpenter wrote: > I guess I'm not a fan of really long prefixes... I've complained before > to other people so don't feel special. Prefixes are something that > people add without thinking as if they always make the code better and > I do blame JAVA

Re: [PATCH] greybus: Fix coding stye error

I guess I'm not a fan of really long prefixes... I've complained before to other people so don't feel special. Prefixes are something that people add without thinking as if they always make the code better and I do blame JAVA influence for this... The "_interface" really doesn't add anything

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 04:24:47PM +0300, Dan Carpenter wrote: > On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote: > > On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > > > The name sucks is what I'm saying. Please fix it eventually. > > > > I disagree. The name uses a

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote: > On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > > The name sucks is what I'm saying. Please fix it eventually. > > I disagree. The name uses a common prefix that reflects the object it is > working on. This should

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > The name sucks is what I'm saying. Please fix it eventually. I disagree. The name uses a common prefix that reflects the object it is working on. This should not be changed. As it is currently named, the function is also

Re: [PATCH] greybus: Fix coding stye error

The name sucks is what I'm saying. Please fix it eventually. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 03:29:30PM +0300, Dan Carpenter wrote: > On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibel...@gmail.com wrote: > > From: Maxime Rossi Bellom > > > > Split line before funtion argument. > > > > Error was reported by checkpatch.pl as > > WARNING:

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibel...@gmail.com wrote: > From: Maxime Rossi Bellom > > Split line before funtion argument. > > Error was reported by checkpatch.pl as > WARNING: line over 80 characters > > Signed-off-by: Maxime Rossi Bellom

[PATCH] staging: lustre: lnet: Fix coding style errors

From: Maxime Rossi Bellom Replace a mix of tabs and spaces indentation by tabs only. Errors were reported by checkpatch.pl as WARNING: Statements should start on a tabstop WARNING: suspect code indent for conditional statement Signed-off-by: Maxime Rossi Bellom

Re: Hi

- Original Message - Sent: Fri, 27 Jan 2017 04:59:49 -0500 (EST) Subject: Hi Attention is needed ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibel...@gmail.com wrote: > From: Maxime Rossi Bellom > > Split line before funtion argument. > > Error was reported by checkpatch.pl as > WARNING: line over 80 characters > > Signed-off-by: Maxime Rossi Bellom

[PATCH] greybus: Fix coding stye error

From: Maxime Rossi Bellom Split line before funtion argument. Error was reported by checkpatch.pl as WARNING: line over 80 characters Signed-off-by: Maxime Rossi Bellom --- drivers/staging/greybus/fw-management.c | 3 ++- 1 file changed, 2

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Tue, Jan 24, 2017 at 03:57:54PM +, Bryan O'Donoghue wrote: > On 24/01/17 15:09, Johan Hovold wrote: > > > Bryan, if you could consider my review feedback and respin your last > > three patches on top of my timeout patch, I think we should be good. > > Sure thing Bryan, can I get an