Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > > > Since the API is completely documented, I see no reason we or > > > > anybody > > > > couldn't essentially rewrite the driver while it's in > > > > staging.  I > > > > just > > > > think

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On 03/20/2017 10:23 AM, Philipp Zabel wrote: Hi Steve, Russell, On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: The same document says:

Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Hi unknown, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.11-rc3 next-20170320] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/unknown/staging-radio-bcm2048-Fix

[PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

Resolving 2 checkpatch warnings generated due to: CHECK: spaces preferred around that '-' Signed-off-by: Matthew Giassa --- drivers/staging/vt6656/rf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6656/rf.c

[PATCH] staging: vt6656: rf.c: resolve all checkpatch issues.

These patches address a few outstanding checkpatch warnings/errors in rf.c, mainly due to space/indentation (style) issues. --- drivers/staging/vt6656/rf.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) --- ___ devel mailing

[PATCH 1/2] staging: vt6656: rf.c: alignment should match open parentheses

Resolving 5 instances of checkpatch error/warning statements generated due to: ERROR: code indent should use tabs where possible CHECK: Alignment should match open parenthesis Signed-off-by: Matthew Giassa --- drivers/staging/vt6656/rf.c | 11 ++- 1 file changed, 6

[PATCH v2 4/6] staging: media: atomisp: fix build errors when PM is disabled

The function atomisp_restore_iumit_reg is unused when PM is disabled. Adding __maybe_unused to the function definition avoids a warning. The function atomisp_mrfld_power_down is defined only when PM is enabled. So in atomisp_pci_probe, it should be called only when PM is enabled. Signed-off-by:

[PATCH 10/10] staging: ks7010: rename return value identifier

Driver uses multiple identifier names for the same task (retval, ret, rc). It would be easier to read the code if a single task is identified with a single name. 'ret' is the most common return value identifier name found in the kernel tree, following the principle of least surprise using 'ret' is

[PATCH 07/10] staging: ks7010: make goto labels uniform

Driver uses different label forms for similar purposes. It would be more clear if single use case has uniform label. 'out' is generic and adds no meaning to label. Documentation/process/coding-style.rst: Choose label names which say what the goto does or why the goto exists. Rename labels so as

[PATCH 06/10] staging: ks7010: return directly on error

Function uses goto label with no clean up code. In this case we should just return directly. Remove goto statement, return directly on error. Signed-off-by: Tobin C. Harding --- '/* length check fail */' comment added because preceding line is a standard function return value

[PATCH 08/10] staging: ks7010: remove non-zero comparison

Comparison, does not equal zero, is redundant 'if (foo != 0)' is equal to 'if (foo)' Typical kernel coding style is to use the shorter form. Remove unnecessary non-zero comparison. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010_sdio.c | 4 ++--

[PATCH 09/10] staging: ks7010: remove zero comparison

Comparison, equal to zero, is redundant 'if (foo == 0)' is equal to 'if (!foo)' Typical kernel coding style is to use the shorter form. Remove unnecessary zero comparison. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_wlan_net.c | 4 ++-- 1 file changed, 2

[PATCH 04/10] staging: ks7010: fix checkpatch BRACES

Checkpatch emits CHECK: Unbalanced braces around else statement. Statements in question are single statements so we do not need braces. Checkpatch also warns about multiple line dereference for this code. Fix if/else/else if statement use of braces. Fix function argument layout at the same time

[PATCH 00/10] staging: ks7010: audit return statements

Driver return statement code exhibits a degree of uncleanliness. Driver return statement code is non-uniform in its use of identifiers, both variables and goto labels. goto statements occasionally are used with out clean up code instead of returning directly. Variables are defined (at

[PATCH 03/10] staging: ks7010: fix checkpatch PARENTHESIS_ALIGNMENT

Checkpatch emits CHECK: Alignment should match open parenthesis. Fix alignment to open parenthesis in line with kernel coding style. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- drivers/staging/ks7010/ks_wlan_net.c | 16 2

[PATCH 01/10] staging: ks7010: fix checkpatch LINE_SPACING

Checkpatch emits CHECK: Please use a blank line after function/struct/union/enum declarations. Add blank line after function definition. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_wlan_net.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 02/10] staging: ks7010: fix checkpatch SPACING

Checkpatch emits CHECK: No space is necessary after a cast. Remove unnecessary space after cast. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/michael_mic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.c

[PATCH 05/10] staging: ks7010: fix checkpatch MULTIPLE_ASSIGNMENTS

Checkpatch emits CHECK: multiple assignments should be avoided. Move multiple line assignment to individual lines. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 0/6] staging: ks7010: clean up return statement code

On Tue, Mar 14, 2017 at 09:20:11PM +1100, Tobin C. Harding wrote: [snip] Drop this series please. (patch 1 of set already merged). thanks, Tobin. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 0/5] staging: vc04_services: camera driver maintance

On Mon, 2017-03-20 at 23:40 +0300, Dan Carpenter wrote: > On Mon, Mar 20, 2017 at 07:53:18AM -0700, Michael Zoran wrote: > > On Mon, 2017-03-20 at 16:57 +0300, Dan Carpenter wrote: > > > On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote: > > > > On Mon, 2017-03-20 at 13:55 +0300, Dan

Re: [PATCH 4/6] staging: media: atomisp: fix build when PM is disabled

On Thu, 16 Mar 2017 17:50:10 + Alan Cox wrote: > > + if (IS_ENABLED(CONFI_PM)) { > > I think not. > > Please actually test build both ways at the very least. > > Alan > I did test and it did compile both ways. I didn't think about checking the output of the

[PATCH 4/4 V2] staging: atomisp: remove redudant condition in if-statement

The V4L2_FIELD_ANY is zero, so the (!field) is same meaning with (field == V4L2_FIELD_ANY) in if-statement. Signed-off-by: Daeseok Youn --- V2: one(2/4) of this series was updated so I tried to send them again. drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c |

[PATCH 3/4 V2] staging: atomisp: remove useless condition in if-statements

The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if- statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY', it could not enter the next if-statement. But the "next" if-statement has the condition to check whether the css_pipe_id equals to 'CSS_PIPE_ID_COPY' or

[PATCH 2/4 V2] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

If v4l2_subdev_call() gets the global frame interval values, it returned 0 and it could be checked whether numerator is zero or not. If the numerator is not zero, the fps could be calculated in this function. If not, it just returns 0. Signed-off-by: Daeseok Youn --- V2:

[PATCH 1/4 V2] staging: atomisp: remove else statement after return

It doesn't need to have else statement after return. Signed-off-by: Daeseok Youn --- V2: one(2/4) of this series was updated so I tried to send them again. drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

2017-03-20 22:11 GMT+09:00 walter harms : > > > Am 20.03.2017 13:51, schrieb DaeSeok Youn: >> 2017-03-20 21:04 GMT+09:00 walter harms : >>> >>> >>> Am 20.03.2017 11:59, schrieb Daeseok Youn: If v4l2_subdev_call() gets the global frame interval values, it

RE: [PATCH] HV: properly delay KVP packets when negotiation is in progress

> -Original Message- > From: Long Li > Sent: Sunday, March 19, 2017 7:49 PM > To: 'Vitaly Kuznetsov' > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org;

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote: > --8<-- > >From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001 > From: Philipp Zabel > Date: Mon, 20 Mar 2017 17:10:21 +0100 > Subject: [PATCH] media: imx: csi: add sink

Re: [PATCH 0/5] staging: vc04_services: camera driver maintance

On Mon, Mar 20, 2017 at 07:53:18AM -0700, Michael Zoran wrote: > On Mon, 2017-03-20 at 16:57 +0300, Dan Carpenter wrote: > > On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote: > > > On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote: > > > > I'm not going to review this because it

[PATCH v3] vmbus: fix missed ring events on boot

During initialization, the channel initialization code schedules the tasklet to scan the VMBUS receive event page (i.e. simulates an interrupt). The problem was that it invokes the tasklet on a different CPU from where it normally runs and therefore if an event is present, it will clear the bit

[PATCH v3] staging: ad7606: Replace mlock with driver private lock

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with a lock in the devices

RE: [PATCH v2] vmbus: fix missed ring events on boot

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, March 18, 2017 9:55 PM > To: gre...@linuxfoundation.org; KY Srinivasan ; > Haiyang Zhang > Cc: sta...@vger.kernel.org;

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On 03/20/2017 07:00 AM, Philipp Zabel wrote: On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: The above paragraph suggests we skip any rectangles that are not supported. In our case that would be 3. and 4.,

Re: [PATCH v3] staging: ad7606: Replace mlock with driver private lock

On 03/20/2017 07:56 PM, Arushi Singhal wrote: [...] > @@ -413,6 +413,7 @@ int ad7606_probe(struct device *dev, int irq, void > __iomem *base_address, > st = iio_priv(indio_dev); > > st->dev = dev; > + mutex_init(>lock); This is nitpicking, but putting this in the middle of the

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

On Mon, 2017-03-20 at 11:54 -0700, Michael Zoran wrote: > On Mon, 2017-03-20 at 10:28 -0700, Michael Zoran wrote: > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > Michael Zoran writes: > > > > > > > > > Since the API is completely documented, I see no reason

[PATCH v2] staging: ad7606: Replace mlock with driver private lock

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with a lock in the devices

[PATCH v3] staging: ad7606: Replace mlock with driver private lock

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with a lock in the devices

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

On Mon, 2017-03-20 at 10:28 -0700, Michael Zoran wrote: > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > Michael Zoran writes: > > > > > > > Since the API is completely documented, I see no reason we or > > > > > anybody > > > > > couldn't essentially rewrite the

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, Mar 20, 2017 at 06:40:21PM +0100, Philipp Zabel wrote: > On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > > I have tripped over a bug in media-ctl when specifying both a crop and > > compose rectangle - the --help output suggests that "," should be used > > to separate

[PATCH 4.9 52/93] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Vitaly Kuznetsov [ Upstream commit 59107e2f48831daedc46973ce4988605ab066de3 ] There is a feature in Hyper-V ('Debug-VM --InjectNonMaskableInterrupt') which injects NMI to

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > > > Scaling support is optional. When supported by a

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Mon, 20 Mar 2017 16:10:03 + Russell King - ARM Linux escreveu: > On Mon, Mar 20, 2017 at 12:39:38PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 20 Mar 2017 14:24:25 +0100 > > Hans Verkuil escreveu: > > > I don't think this control

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > > > Since the API is completely documented, I see no reason we or > > > > anybody > > > > couldn't essentially rewrite the driver while it's in > > > > staging.  I > > > > just > > > > think

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

Hi Steve, Russell, On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > > > Scaling support is optional.

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

Michael Zoran writes: >> > Since the API is completely documented, I see no reason we or >> > anybody >> > couldn't essentially rewrite the driver while it's in staging.  I >> > just >> > think it would be best for everyone if the new version was a drop >> > in >> >

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, Mar 20, 2017 at 02:17:05PM +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > > > Scaling support is optional. When supported

Re: [RESEND PATCH] staging: ad7606: Replace mlock with driver private lock

On 03/20/2017 04:22 PM, Arushi Singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect

Re: [PATCH v5 00/39] i.MX Media Driver

On Mon, Mar 20, 2017 at 05:29:07PM +0100, Philipp Zabel wrote: > According to the documentation [1], you are doing the right thing: > > The struct v4l2_subdev_frame_interval pad references a non-existing > pad, or the pad doesn’t support frame intervals. > > But v4l2_subdev_call returns

Re: [PATCH v5 00/39] i.MX Media Driver

On Mon, 2017-03-20 at 15:43 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:20:16PM +0100, Philipp Zabel wrote: > > To set and read colorimetry information: > > https://patchwork.linuxtv.org/patch/39350/ > > Thanks, I've applied all four of your patches, but there's a side

Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

On Mon, Mar 20, 2017 at 4:05 PM, Stephen Hemminger wrote: > On Mon, 20 Mar 2017 10:32:19 +0100 > Arnd Bergmann wrote: > >> -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) >> +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/

Re: outreachy

On Mon 2017-03-20 11:30:08, Greg KH wrote: > On Mon, Mar 20, 2017 at 11:20:32AM +0100, Pavel Machek wrote: > > Hi! > > > > > > > Hah! That's the joy of being a maintainer of a driver in staging. > > > > > Even > > > > > if you filter out outreachy, you are going to get a lot of "basic > > > >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Mon, Mar 20, 2017 at 12:39:38PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 20 Mar 2017 14:24:25 +0100 > Hans Verkuil escreveu: > > I don't think this control inheritance patch will magically prevent you > > from needed a plugin. > > Yeah, it is not just control

[PATCH] staging: ad7759: Replace mlock with driver private lock

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with a lock in the devices

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote: >> On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: >>> It's what I have - remember, not everyone is happy to constantly replace >>> their distro packages with random new

Re: [PATCH v5 00/39] i.MX Media Driver

On Mon, Mar 20, 2017 at 02:20:16PM +0100, Philipp Zabel wrote: > To set and read colorimetry information: > https://patchwork.linuxtv.org/patch/39350/ Thanks, I've applied all four of your patches, but there's a side effect from that. Old media-ctl (modified by me): - entity 53: imx219 0-0010

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

On Mon, 2017-03-20 at 12:33 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 20 Mar 2017 08:11:41 -0700 > Michael Zoran escreveu: > > > On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 20 Mar 2017 04:08:21 -0700 > > > Michael Zoran

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Mon, 20 Mar 2017 14:24:25 +0100 Hans Verkuil escreveu: > On 03/14/2017 11:21 AM, Mauro Carvalho Chehab wrote: > > Em Tue, 14 Mar 2017 08:55:36 +0100 > > Hans Verkuil escreveu: > > > >> On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote: > >>> Hi

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Em Mon, 20 Mar 2017 08:11:41 -0700 Michael Zoran escreveu: > On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 20 Mar 2017 04:08:21 -0700 > > Michael Zoran escreveu: > > > > > On Mon, 2017-03-20 at 07:58 -0300, Mauro

[RESEND PATCH] staging: ad7606: Replace mlock with driver private lock

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with a lock in the devices

[PATCH 2/2] staging: ade7754: Clean up #includes

Alphabetize and separate kernel and subsystem headers. Signed-off-by: simran singhal --- drivers/staging/iio/meter/ade7754.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/meter/ade7754.c

[PATCH 0/2] staging: iio: ade7754: Header file maintenance

Collapse header file into source, and clean up includes in implementation. simran singhal (2): staging: ade7754: Move header content to implementation file staging: ade7754: Clean up #includes drivers/staging/iio/meter/ade7754.c | 98 ++---

[PATCH 1/2] staging: ade7754: Move header content to implementation file

The contents of ade7754.h are only used in ade7754.c. Move the header contents to the implementation file, and delete the header file. Signed-off-by: simran singhal --- drivers/staging/iio/meter/ade7754.c | 87 ++-

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 20 Mar 2017 04:08:21 -0700 > Michael Zoran escreveu: > > > On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote: > > > Em Sun, 19 Mar 2017 22:11:07 -0300 > > > Mauro Carvalho Chehab

Re: [PATCH v5 03/39] [media] dt/bindings: Add bindings for OV5640

On Thu, Mar 09, 2017 at 08:52:43PM -0800, Steve Longerbeam wrote: > Add device tree binding documentation for the OV5640 camera sensor. > > Signed-off-by: Steve Longerbeam > --- > .../devicetree/bindings/media/i2c/ov5640.txt | 45 > ++ > 1

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Mon, 20 Mar 2017 14:10:30 +0100 Hans Verkuil escreveu: > On 03/17/2017 03:37 PM, Russell King - ARM Linux wrote: > > On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote: > >> On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: > >> [...] > >>> The

Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

On Mon, 20 Mar 2017 10:32:19 +0100 Arnd Bergmann wrote: > -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) > +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void) > { Why keep the comment? ___ devel mailing

Re: [PATCH v5 02/39] [media] dt-bindings: Add bindings for i.MX media driver

+Ramiro On Thu, Mar 09, 2017 at 08:52:42PM -0800, Steve Longerbeam wrote: > Add bindings documentation for the i.MX media driver. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 74 > + > 1 file

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Em Mon, 20 Mar 2017 04:08:21 -0700 Michael Zoran escreveu: > On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 19 Mar 2017 22:11:07 -0300 > > Mauro Carvalho Chehab escreveu: > > > > > Em Sun, 19 Mar 2017 10:04:28 -0700

Re: [PATCH 0/5] staging: vc04_services: camera driver maintance

On Mon, 2017-03-20 at 16:57 +0300, Dan Carpenter wrote: > On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote: > > On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote: > > > I'm not going to review this because it has kbuild errors. > > > > > > regards, > > > dan carpenter > > > > >

RE:

Are you in need of a loan for business / personal loan? Apply now by email, note, this offer is for serious minded people Only: web.loanf...@gmail.com ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'

[add Mauro to CC] Am 20.03.2017 um 15:08 schrieb Colin King: From: Colin Ian King Currently, if pservice is null then service is set to NULL and immediately afterwards service is dereferenced causing a null pointer dereference. Fix this by bailing out early of the

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > The same document says: > > > > Scaling support is optional. When supported by a subdev, the crop > > rectangle on the subdev's sink pad is scaled to the

Re: [PATCH v5 00/39] i.MX Media Driver

On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote: > On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: > > It's what I have - remember, not everyone is happy to constantly replace > > their distro packages with random new stuff. > > This is a compliance test, which is

[PATCH] staging: iio: adc: Replace mlock with driver private lock

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with a lock in the devices

[PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'

From: Colin Ian King Currently, if pservice is null then service is set to NULL and immediately afterwards service is dereferenced causing a null pointer dereference. Fix this by bailing out early of the function with a null return. Detected by CoverityScan,

[PATCH v5] staging:sm750fb: Code readability is improved.

New variables are added to make the code more readable. Signed-off-by: Arushi Singhal --- changes in v5 -try to make the code much more readable. - defined the variable at the top of a block. - change the variable from temp to tmp.

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: > > The above paragraph suggests we skip any rectangles that are not > > supported. In our case that would be 3. and 4., since the CSI can't > > compose into a larger

Re: [PATCH 0/5] staging: vc04_services: camera driver maintance

On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote: > On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote: > > I'm not going to review this because it has kbuild errors. > > > > regards, > > dan carpenter > > > > Hi, can you e-mail out the errors or send them to me. It worked

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:01:58PM +0100, Hans Verkuil wrote: >> On 03/19/2017 06:54 PM, Steve Longerbeam wrote: >>> >>> >>> On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: What did you do with: ioctl(3,

Re: [PATCH v5 00/39] i.MX Media Driver

On Mon, Mar 20, 2017 at 02:01:58PM +0100, Hans Verkuil wrote: > On 03/19/2017 06:54 PM, Steve Longerbeam wrote: > > > > > > On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: > >> What did you do with: > >> > >> ioctl(3, VIDIOC_REQBUFS, {count=0, type=0 /* V4L2_BUF_TYPE_??? */, > >>

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/14/2017 11:21 AM, Mauro Carvalho Chehab wrote: > Em Tue, 14 Mar 2017 08:55:36 +0100 > Hans Verkuil escreveu: > >> On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote: >>> Hi Sakari, >>> >>> I started preparing a long argument about it, but gave up in favor of a >>>

Re: [PATCH v5 00/39] i.MX Media Driver

On Sun, 2017-03-19 at 12:14 +, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: > > >0:00:01.955927879 20954 0x15ffe90 INFOv4l2 > >

Re: [PATCH v5 00/39] i.MX Media Driver

On Sat, 2017-03-18 at 12:58 -0700, Steve Longerbeam wrote: > > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: > > Hi Steve, > > > > I've just been trying to get gstreamer to capture and h264 encode > > video from my camera at various frame rates, and what I've discovered > > does not

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

Am 20.03.2017 13:51, schrieb DaeSeok Youn: > 2017-03-20 21:04 GMT+09:00 walter harms : >> >> >> Am 20.03.2017 11:59, schrieb Daeseok Youn: >>> If v4l2_subdev_call() gets the global frame interval values, >>> it returned 0 and it could be checked whether numerator is zero or not.

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/17/2017 03:37 PM, Russell King - ARM Linux wrote: > On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote: >> On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: >> [...] >>> The big question, waiting for an answer on the last 8 years is >>> who would do that? Such person

Re: [PATCH v4] staging: sm750fb: Code readability is improved

On Mon, Mar 20, 2017 at 06:25:19PM +0530, Arushi Singhal wrote: > On Mon, Mar 20, 2017 at 5:58 PM, Dan Carpenter > wrote: > > > On Sun, Mar 19, 2017 at 09:19:20PM +0530, Arushi Singhal wrote: > > > New variables are added to make the code more readable. > > > > > >

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/19/2017 06:54 PM, Steve Longerbeam wrote: > > > On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: >> On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >>> Right, imx-media-capture.c (the "standard" v4l2 user interface module) >>> is not implementing

[PATCH v7] staging: adis16060_core: Replace mlock with buf_lock and refactor code

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with buf_lock in the devices

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

2017-03-20 21:04 GMT+09:00 walter harms : > > > Am 20.03.2017 11:59, schrieb Daeseok Youn: >> If v4l2_subdev_call() gets the global frame interval values, >> it returned 0 and it could be checked whether numerator is zero or not. >> >> If the numerator is not zero, the fps could be

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/19/2017 01:14 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: >>> 0:00:01.955927879 20954 0x15ffe90 INFOv4l2 >>>

Re: [PATCH v4] staging: sm750fb: Code readability is improved

On Sun, Mar 19, 2017 at 09:19:20PM +0530, Arushi Singhal wrote: > New variables are added to make the code more readable. > > Signed-off-by: Arushi Singhal > --- > changes in v4 > -try to make the code much more readable. > - defined the variable at the top of

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: > The above paragraph suggests we skip any rectangles that are not > supported. In our case that would be 3. and 4., since the CSI can't > compose into a larger frame. I hadn't realised that the crop selection > currently happens on

Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Also fix your From header. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

Am 20.03.2017 11:59, schrieb Daeseok Youn: > If v4l2_subdev_call() gets the global frame interval values, > it returned 0 and it could be checked whether numerator is zero or not. > > If the numerator is not zero, the fps could be calculated in this function. > If not, it just returns 0. > >

Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

The subject is too long. On Mon, Mar 20, 2017 at 10:02:33PM +1100, unknown wrote: > Signed-off-by: Eddie Youseph You need to have a changelog. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Hi Mauro, Am 20.03.2017 um 11:58 schrieb Mauro Carvalho Chehab: Em Sun, 19 Mar 2017 22:11:07 -0300 Mauro Carvalho Chehab escreveu: Em Sun, 19 Mar 2017 10:04:28 -0700 Michael Zoran escreveu: A working DT that I tried this morning with the

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Sun, 2017-03-19 at 12:08 -0700, Steve Longerbeam wrote: > > On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote: > > On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: > >> From: Philipp Zabel > >> > >> The csi_try_crop call in set_fmt should compare

Re: [PATCH] staging: wilc1000: Fix sparse warning in wilc_wfi_cfgoperations.c

On Sun, Mar 19, 2017 at 11:17:08PM -0700, Jacob Zachariah wrote: > Fix the following warning reported by sparse: > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect > type in assignment (different base types) >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/17/2017 12:55 PM, Sakari Ailus wrote: > Hi Russell, > > On 03/17/17 13:42, Russell King - ARM Linux wrote: >> On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: >>> We're all very driver-development-driven, and userspace gets very little >>> attention in general. So before just

Re: [PATCH 3/4] staging: atomisp: remove useless condition in if-statements

On Mon, Mar 20, 2017 at 08:00:06PM +0900, Daeseok Youn wrote: > The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if- > statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY', > it could not enter the next if-statement. But the "next" if-statement > has the

  1   2   >