On Fri, Mar 31, 2017 at 02:00:13PM -0700, Doug Anderson wrote:
> On Fri, Mar 31, 2017 at 12:29 PM, Greg KH wrote:
> BTW: I presume that nobody has decided that it would be a wise idea to
> pick the OOM reaper code back to any stable trees? It seemed a bit
> too scary to me, so I wrote a dumber (b
On Sat, Apr 01, 2017 at 04:32:39AM +0100, Al Viro wrote:
> On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> > Replace string with formatted arguments in the dev_warn() call. It removes
> > the checkpatch warning:
> >
> > WARNING: Prefer using "%s", __func__ to embedded function na
On Sat, 2017-04-01 at 05:08 +0100, Al Viro wrote:
> On Fri, Mar 31, 2017 at 08:52:50PM -0700, Joe Perches wrote:
>
> > > MILD SUGGESTION: don't spell the function name out in format strings;
> > > "this_function: foo is %d", n
> > > might be better off as
> > > "%s: foo is %d", __func__, n
> >
On Sat, 2017-04-01 at 04:32 +0100, Al Viro wrote:
> On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> > Replace string with formatted arguments in the dev_warn() call. It removes
> > the checkpatch warning:
> >
> > WARNING: Prefer using "%s", __func__ to embedded function names
[]
On Fri, Mar 31, 2017 at 08:52:50PM -0700, Joe Perches wrote:
> > MILD SUGGESTION: don't spell the function name out in format strings;
> > "this_function: foo is %d", n
> > might be better off as
> > "%s: foo is %d", __func__, n
> > in case you ever move it to another function or rename yo
On Sat, 2017-04-01 at 04:46 +0100, Al Viro wrote:
> On Fri, Mar 31, 2017 at 08:36:22PM -0700, Joe Perches wrote:
> > On Sat, 2017-04-01 at 04:32 +0100, Al Viro wrote:
> > > On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> > > > Replace string with formatted arguments in the dev_warn()
On Fri, Mar 31, 2017 at 08:36:22PM -0700, Joe Perches wrote:
> On Sat, 2017-04-01 at 04:32 +0100, Al Viro wrote:
> > On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> > > Replace string with formatted arguments in the dev_warn() call. It removes
> > > the checkpatch warning:
> > >
> >
On Fri, 2017-03-31 at 20:18 -0700, Chewie Lin wrote:
> These are good points, but any feedback on the dev_warn() call itself?
> I was trying to fix the checkpatch warning on my first try.
Using "%s" with a long string is generally inefficient.
Compare the compiled object size of
printf("%
On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> Replace string with formatted arguments in the dev_warn() call. It removes
> the checkpatch warning:
>
> WARNING: Prefer using "%s", __func__ to embedded function names
> #417: FILE: main_usb.c:417:
> +
On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote:
> On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote:
> > fixed a coding style error/warning.
> >
> > Signed-off-by: Chewie Lin
> > ---
> > drivers/staging/vt6656/main_usb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Fri, Mar 31, 2017 at 07:45:09PM -0700, Joe Perches wrote:
> On Fri, 2017-03-31 at 19:15 -0700, Randy Dunlap wrote:
> > On 03/31/17 18:59, Chewie Lin wrote:
> > > Replace string with formatted arguments in the dev_warn() call. It removes
> > > the checkpatch warning:
> > >
> > > WARNING: Prefe
On Fri, 2017-03-31 at 19:15 -0700, Randy Dunlap wrote:
> On 03/31/17 18:59, Chewie Lin wrote:
> > Replace string with formatted arguments in the dev_warn() call. It removes
> > the checkpatch warning:
> >
> > WARNING: Prefer using "%s", __func__ to embedded function names
> > #417: FILE: m
As the event_attrs field of iio_info structures is constant, so these
attribute_group structures can also be declared constant.
File size before:
textdata bss dec hex filename
150641528 0 1659240d0
drivers/staging/iio/light/tsl2x7x_core.o
File size after:
t
On Fri, 2017-03-31 at 18:59 -0700, Chewie Lin wrote:
> Replace string with formatted arguments in the dev_warn() call. It removes
> the checkpatch warning:
>
> WARNING: Prefer using "%s", __func__ to embedded function names
> #417: FILE: main_usb.c:417:
> +
On 03/31/17 18:59, Chewie Lin wrote:
> Replace string with formatted arguments in the dev_warn() call. It removes
> the checkpatch warning:
>
> WARNING: Prefer using "%s", __func__ to embedded function names
> #417: FILE: main_usb.c:417:
> +"usb_device_res
Replace string with formatted arguments in the dev_warn() call. It removes
the checkpatch warning:
WARNING: Prefer using "%s", __func__ to embedded function names
#417: FILE: main_usb.c:417:
+"usb_device_reset fail status=%d\n", status);
tot
Hi all:
Better and improved changelog version 3.
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
drivers/staging/vt6656/main_usb.c: checkpatch warning
drivers/staging/vt6656/m
On 03/31/17 13:58, Chewie Lin wrote:
> Replace string with formatted arguments in the dev_warn() call. It removes
> the checkpatch warning.
Tell us what the warning was.
and then see if the patch fixes that warning.
> Signed-off-by: Chewie Lin
> ---
> drivers/staging/vt6656/main_usb.c | 2 +-
>
Hi,
On Fri, Mar 31, 2017 at 12:29 PM, Greg KH wrote:
> On Fri, Mar 31, 2017 at 10:53:41AM -0700, Douglas Anderson wrote:
>> Sometimes when we're out of memory the OOM killer decides to kill a
>> process that's in binder_thread_read(). If we happen to be waiting
>> for work we'll get the kill sig
Replace string with formatted arguments in the dev_warn() call. It removes
the checkpatch warning.
Signed-off-by: Chewie Lin
---
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_
Hi greg and forest:
I hate to bother but one more, with better changelog.
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
drivers/staging/vt6656/main_usb.c: checkpatch warning
On Fri, Mar 31, 2017 at 10:53:41AM -0700, Douglas Anderson wrote:
> Sometimes when we're out of memory the OOM killer decides to kill a
> process that's in binder_thread_read(). If we happen to be waiting
> for work we'll get the kill signal and wake up. That's good. ...but
> then we try to grab
checkpatch gives WARNING: Avoid line continuations in quoted strings.
Trivial fix by removing line continuations and adding another quote at
the start of next line.
Signed-off-by: Prasant Jalan
---
drivers/staging/sm750fb/sm750.c | 18 +-
1 file changed, 9 insertions(+), 9 delet
lynxfb_suspend() & lynxfb_resume() return on errors while holding
console_lock.
Adding 'goto' such that proper cleanups can be done before returning
from function and therefore console_lock can be released before
returning.
Signed-off-by: Prasant Jalan
---
drivers/staging/sm750fb/sm750.c | 12 +
On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote:
> fixed a coding style error/warning.
>
> Signed-off-by: Chewie Lin
> ---
> drivers/staging/vt6656/main_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c
> b/drivers/staging/vt66
Fixes: 5b6f9b95f7ae ("staging: unisys: visorbus: get rid of create_bus_type.")
Kernel day0 testing robot reported a kernel BUG at drivers/base/driver.c!
with the following call stack:
[ 14.963563] [ cut here ]
[ 14.967298] kernel BUG at drivers/base/driver.c:153!
[ 1
Sometimes when we're out of memory the OOM killer decides to kill a
process that's in binder_thread_read(). If we happen to be waiting
for work we'll get the kill signal and wake up. That's good. ...but
then we try to grab the binder lock before we return. That's bad.
The problem is that someo
On Fri, Mar 31, 2017 at 10:56:28AM -0400, David Kershner wrote:
> Fixes: 5b6f9b95f7ae ("staging: unisys: visorbus: get rid of create_bus_type.")
>
> Kernel day0 testing robot reported a kernel BUG at drivers/base/driver.c!
> with the following call stack:
>
> [ 14.963563] [ cut here
Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:
@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)
Signed-off-by: simran
Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:
@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)
Signed-off-by: simran
Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:
@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)
Signed-off-by: simran
This patch-series removes some type conversions like casting a pointer to a
pointer of same type,
casting to the original type using addressof(&) operator etc.
simran singhal (3):
staging: iio: accel: Remove useless type conversion
staging: iio: frequency: Remove useless type conversion
sta
Fixes: 5b6f9b95f7ae ("staging: unisys: visorbus: get rid of create_bus_type.")
Kernel day0 testing robot reported a kernel BUG at drivers/base/driver.c!
with the following call stack:
[ 14.963563] [ cut here ]
[ 14.967298] kernel BUG at drivers/base/driver.c:153!
[ 1
From: Andrey Shvetsov
Despite the user payload may not be bigger than (2**16 - 1) bytes, the
final packet size may be bigger because of the gap space needed for the
controller.
This patch removes the temporary variables of the type u16 that are used
to hold the offsets that may be bigger than 2*
From: Andrey Shvetsov
Currently, when the channel disappears whereas the character device is
open by an application, the character device will be destroyed only
after the application closes the character device.
When the channel appears again before the application closes the
channel, the channe
The function store_value is about writing a value, but the code has been
passing ro_regs array to get_static_reg_addr, which prevented setting
the writable registers.
Noticed when trying to setup the EUI48.
Signed-off-by: Alex Riesen
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-
From: Andrey Shvetsov
The final size of the buffer used for the streaming transfer consists of
the size for the user payload (buffer_size) and the size for the gaps
needed by the controller (extra_len).
The current implementation of the hdm_configure_channel() corrects the
buffer size down to th
From: Andrey Shvetsov
This patch replaces 13 temporary variables representing the attributes
to control the channel with an array of 13 elements to keep the
corresponding code compact.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/mostcore/core.c | 61
From: Andrey Shvetsov
This patch replaces three temporary variables representing the
attributes to control the links between the AIMs and HDMs with an array
of three elements to keep the corresponding code compact.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/stag
From: Andrey Shvetsov
Currently there are following properties of the AIM to control the links
to the HDMs:
- write-only "remove_link" used to remove one link from a list,
- read/write "add_link" used to add one link into a list and list all
links.
This patch moves the read functionality
From: Andrey Shvetsov
This patch replaces the use of a macro MOST_CHNL_ATTR in the macro
create_channel_attribute with a macro __ATTR_RW.
Additionally, this patch removes not anymore used macro MOST_CHNL_ATTR.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/
From: Andrey Shvetsov
This patch replaces the use of a macro MOST_CHNL_ATTR in the macro
create_show_channel_attribute with a macro __ATTR_RO.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/mostcore/core.c | 36
1 fi
From: Andrey Shvetsov
This patch replaces the name store_remove_link by the remove_link_store
in the comment for the corresponding function.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
From: Andrey Shvetsov
This patch replaces the name store_add_link by the add_link_store in the
comment for the corresponding function.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Andrey Shvetsov
This patch replaces the use of a macro create_inst_attribute for the
attribute interface with a macro __ATTR_RO.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/mostcore/core.c | 6 --
1 file changed, 4 insertions(+), 2 deletion
From: Andrey Shvetsov
This patch replaces the use of a macro create_inst_attribute for the
attribute value with a macro __ATTR_RO.
Additionally, this patch removes not anymore used macros MOST_INST_ATTR
and create_inst_attribute.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
-
Removed Free Software Foundation's address from the copyright notice
and replaced it with a link to http://www.gnu.org/licenses
Signed-off-by: Riku Salminen
---
drivers/staging/nvec/nvec-keytable.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec-ke
On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote:
> fix a checkpatch warning:
> WARNING: Prefer using "%s", __func__ to embedded function names
>
> Signed-off-by: Chewie Lin
> ---
> drivers/staging/vt6656/main_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
Remove unnecessary log messages in the driver which were just tracking
function entry and exits.
Signed-off-by: Aishwarya Pant
---
There are many functions here like:
bcm2835_audio_setup(..)
bcm2835_audio_flush_playback_buffers(..)
bcm2835_audio_flush_buffers(..)
which are not doing any work. Sh
Hi,
> The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is
> a SDW-823 and should use the ks7010 driver.
Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for
which no driver is known:
https://wikidevi.com/wiki/Spectec_SDW-821_%28MediaTek%29
For SDW-821 (SD s
On Fri, 31 Mar 2017 03:01:12 -0700
Chewie Lin wrote:
> fix a checkpatch warning:
> WARNING: Prefer using "%s", __func__ to embedded function names
__func__, so:
> - "usb_device_reset fail status=%d\n", status);
> + "%s=%d\n", "usb_device_reset fail stat
On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote:
>
> > The code is untested, I have hardware in the mail.
>
> Cool!
The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is
a SDW-823 and should use the ks7010 driver. I am going to attempt to
get it running on a Raspber
Change the name of function from adis16060_spi_write_than_read()
to adis16060_spi_write_then_read(). change "than" to "then" as
its time depended.
Signed-off-by: simran singhal
---
v2:
-Change the subject.
-Add signed-off-by.
drivers/staging/iio/gyro/adis16060_core.c | 4 ++--
1 file ch
fix a checkpatch warning:
WARNING: Prefer using "%s", __func__ to embedded function names
Signed-off-by: Chewie Lin
---
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
ind
Hi greg k-h and forest:
Sorry about all the spam I've been sending earlier. One more try.
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
fixed a checkpatch warning
drivers/staging/v
On Thu, Mar 30, 2017 at 10:16:05PM -0700, Joe Perches wrote:
> On Fri, 2017-03-31 at 15:47 +1100, Tobin C. Harding wrote:
> > ks7010 currently uses a custom implementation of the Michael MIC
> > algorithm. The kernel has an implementation of this algorithm
> > already, we should use it.
>
> ok, tr
On Fri, Mar 31, 2017 at 01:40:29AM -0700, Chewie Lin wrote:
> fixed a coding style error/warning.
Worst changelog and subject: line ever :)
Please go read the links that my patchbot sent you last time you
submitted this change. You didn't do so for some odd reason :(
thanks,
greg k-h
_
fixed a coding style error/warning.
Signed-off-by: Chewie Lin
---
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index 9e074e9..2d9e7af 100644
--- a/drivers/staging/vt665
Hi,
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
fixed a checkpatch warning
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.10.0
__
> The code is untested, I have hardware in the mail.
Cool!
> If any one is interested and has any comments I would really like to
> hear them. I am open to all suggestions (even down to trivial coding
> style issues).
I'll just repeat that the key move to get this driver out of staging is
to ge
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Mar 30, 2017 at 09:51:53AM -0400, Cathy Avery wrote:
> Hi,
>
> So which commit is moving
61 matches
Mail list logo
