Re: [PATCH 2/3] Documentation: Move visorbus documentation from staging to Documentation/

On Mon, 05 Jun 2017, David Kershner wrote: > This patch simply does a git mv of the > drivers/staging/unisys/Documentation directory to Documentation. Up to Jon, of course, but I wouldn't add any new files directly under Documentation, and especially not something as specific as this. BR, Jani.

[BUGFIX PATCH] staging: ccree: fix buffer copy

Fix a bug where the copying of scatterlist buffers incorrectly ignored bytes to skip in a scatterlist and ended 1 byte short. This fixes testmgr hmac and hash test failures currently obscured by hash import/export not being supported. Fixes: abefd6741d ("staging: ccree: introduce CryptoCell HW dr

RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

Hi Greg, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, June 03, 2017 11:41 AM > > On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Laurentiu Tudor > > > > Several macros didn't had macro params enclosed in par

[driver-core:bus_type_removal 15/15] drivers/tty/serdev/core.c:265:2: error: unknown field 'dev_attrs' specified in initializer

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git bus_type_removal head: 98bcb3d030381f6f32f8952eeac289a63a13f07d commit: 98bcb3d030381f6f32f8952eeac289a63a13f07d [15/15] driver-core: remove struct bus_type.dev_attrs config: ia64-allmodconfig (attached as .config) c

[driver-core:bus_type_removal 15/15] drivers/tty/serdev/core.c:265:2: warning: initialization from incompatible pointer type

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git bus_type_removal head: 98bcb3d030381f6f32f8952eeac289a63a13f07d commit: 98bcb3d030381f6f32f8952eeac289a63a13f07d [15/15] driver-core: remove struct bus_type.dev_attrs config: x86_64-randconfig-i0-201723 (attached as

Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

On Sun, Jun 4, 2017 at 1:49 PM, Greg KH wrote: > On Sun, Jun 04, 2017 at 05:02:08AM +0530, srishti sharma wrote: >> Added * on subsequent lines of a comment block. >> >> Signed-off-by: srishti sharma >> --- >> drivers/staging/ccree/cc_crypto_ctx.h | 2 +- >> 1 file changed, 1 insertion(+), 1 del

[driver-core:class_groups_removal 3/7] drivers/mtd/ubi/build.c:116:2: error: initialization from incompatible pointer type

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git class_groups_removal head: 0e917470c6fbd8ad8eb957c663aecc25b859c7fb commit: 8c103093703b767ff463d04c78569e4abf9fbbc8 [3/7] mtd: use class_groups instead of class_attrs config: x86_64-randconfig-x019-201723 (attached

RE: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

Hi Greg, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, June 03, 2017 11:40 AM > > On Wed, May 31, 2017 at 01:58:52PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Stuart Yoder > > Your subject says 'v4' yet the other patches here in the se

[driver-core:class_groups_removal 3/7] drivers/mtd/ubi/build.c:116:2: warning: initialization from incompatible pointer type

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git class_groups_removal head: 0e917470c6fbd8ad8eb957c663aecc25b859c7fb commit: 8c103093703b767ff463d04c78569e4abf9fbbc8 [3/7] mtd: use class_groups instead of class_attrs config: xtensa-allmodconfig (attached as .config

Re: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

On Tue, Jun 06, 2017 at 02:03:44PM +, Laurentiu Tudor wrote: > Hi Greg, > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Saturday, June 03, 2017 11:40 AM > > > > On Wed, May 31, 2017 at 01:58:52PM +0300, laurentiu.tu...@nxp.com wrote: > > > Fro

RE: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, June 06, 2017 5:20 PM > To: Laurentiu Tudor > > On Tue, Jun 06, 2017 at 02:03:44PM +, Laurentiu Tudor wrote: > > Hi Greg, > > > > > -Original Message- > > > From: Greg KH [mailto:gre...

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > This patchset moves drivers/staging/unisys/include to > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to > drivers/virt/visorbus. Um, are you thinking it is ready to be moved? Have you asked for another review?

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > This patchset moves drivers/staging/unisys/include to > > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to > > drivers/virt/visorbus. > > Um, are you t

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Tue, Jun 06, 2017 at 04:53:22PM +0200, Greg KH wrote: > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > > This patchset moves drivers/staging/unisys/include to > > > include/linux/visorbus, and moves drivers/staging

[PATCH 08/18] staging: fsl-dpaa2/eth: Always call napi_gro_receive()

The function itself checks whether GRO support is enabled and acts accordingly, so we don't need to verify it in the driver as well. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/s

[PATCH 07/18] staging: fsl-dpaa2/eth: Don't use GFP_DMA

Don't use GFP_DMA when allocating memory for the hash key, as we don't actually need to allocate from the lowest zone. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/e

[PATCH 00/18] staging: fsl-dpaa2/eth: Code cleanup and minor fixes

This patch series contains fixes for a few minor bugs and code cleanup and cosmetics. No significant functional changes. Ioana Radulescu (18): staging: fsl-dpaa2/eth: Add "static" keyword where needed staging: fsl-dpaa2/eth: Initialize variable before use staging: fsl-dpaa2/eth: Fix return t

[PATCH 13/18] staging: fsl-dpaa2/eth: Remove unused fields from priv struct

Remove the dpni_id and buffer_layout fields from device's private structure. They're only used at probe so we don't need to store them for further use. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 33 +- drivers/staging/fsl-dpaa2/eth

[PATCH 04/18] staging: fsl-dpaa2/eth: Remove incorrect error path

Not having Rx hashing distribution enabled for an interface is a valid configuration and shouldn't be treated as an error. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl

[PATCH 10/18] staging: fsl-dpaa2/eth: Defer probing if no DPIOs found

If the Ethernet driver doesn't find any DPIO devices during probe, it may be either because there's none available or because they haven't been probed yet. Request deferred probing in case it's the latter. Signed-off-by: Bharat Bhushan Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa

[PATCH 14/18] staging: fsl-dpaa2/eth: Only store bpid in priv struct

We only need to know the buffer pool id, so save exactly that in the device's private structure, instead of the entire DPBP attributes struct. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 12 +++- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2

[PATCH 16/18] staging: fsl-dpaa2/eth: Errors checking update

On the egress path, frame errors are reported using both a FD control field and the frame annotation status. The current code only handles FAS errors. Update to look at both fields when accounting Tx errors. Signed-off-by: Bogdan Purcareata Signed-off-by: Ioana Radulescu --- Note: Checkpatch com

[PATCH 06/18] staging: fsl-dpaa2/eth: Minor cleanup in dpaa2_eth_set_hash

We already have a variable for the DMA mapping device, so use that directly. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/stagi

[PATCH 02/18] staging: fsl-dpaa2/eth: Initialize variable before use

In dpni_get_irq_status(), status is both in and out parameter, so initialize before use. Issue found through static analysis tool. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 18/18] staging: fsl-dpaa2/eth: Update number of netdev queues

Currently, the netdevice is allocated with a default number of Rx/Tx queues equal to CONFIG_NR_CPUS, meaning the maximum number of cores supported by the current kernel. The actual number of queues is reflected by the DPNI object attribute, so update the netdevice configuration based on that. Sign

[PATCH 12/18] staging: fsl-dpaa2/eth: Add accessor for FAS field

Introduce a helper macro for accessing the frame annotation status field in a frame buffer. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 31 -- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 6 + 2 files changed, 20 insertions

[PATCH 01/18] staging: fsl-dpaa2/eth: Add "static" keyword where needed

Make a couple of locally used functions and structures static. Issue found through static analysis tool. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 6 +++--- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 -- drivers/staging/fsl-dpaa2/ethernet

[PATCH 09/18] staging: fsl-dpaa2/eth: Reset dpbp

Reset the buffer pool object before using it, like we do for the other DPAA2 objects. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl

[PATCH 17/18] staging: fsl-dpaa2/eth: Refactor MAC address setup

The driver logic for allocating a MAC address to a net device is complicated enough to deserve a function of its own. While here, cleanup a bit the code comments. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 46 -- 1 file changed, 29

[PATCH 05/18] staging: fsl-dpaa2/eth: Add error message newlines

A few error/warning messages lacked a newline at the end of the text. Add it for improved consistency and cosmetics. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 +++--- drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 6 +++--- 2 files

[PATCH 03/18] staging: fsl-dpaa2/eth: Fix return type of ndo_start_xmit

ndo_start_xmit() returns a value of type netdev_tx_t. Update our ndo function to use the correct type. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-et

[PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields

Reorder fields in the device's private structure such that the ones most used on the hotpath are at the beginning of the structure. This brings a small performance improvement due to better cache usage. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 26 +

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Tue, Jun 06, 2017 at 04:54:30PM +0200, Greg KH wrote: > On Tue, Jun 06, 2017 at 04:53:22PM +0200, Greg KH wrote: > > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > > > This patchset moves drivers/staging/unisys/i

[PATCH 11/18] staging: fsl-dpaa2/eth: Update ethtool stats names

Add a label to the ethtool statistics counters, to differentiate between hardware counters and driver specific ones. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/

Re: [PATCH 16/18] staging: fsl-dpaa2/eth: Errors checking update

On Tue, 2017-06-06 at 10:00 -0500, Ioana Radulescu wrote: > On the egress path, frame errors are reported using both a FD control > field and the frame annotation status. The current code only handles > FAS errors. Update to look at both fields when accounting Tx errors. [] > Note: Checkpatch com

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Tue, Jun 06, 2017 at 08:33:49AM -0700, Joe Perches wrote: > On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote: > > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > > I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you > > > have 2 tabs for your 'struct attribute' va

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Tue, Jun 06, 2017 at 08:52:27AM -0700, Joe Perches wrote: > On Tue, 2017-06-06 at 17:39 +0200, Greg KH wrote: > > On Tue, Jun 06, 2017 at 08:33:49AM -0700, Joe Perches wrote: > > > On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote: > > > > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote:

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Tue, 2017-06-06 at 17:39 +0200, Greg KH wrote: > On Tue, Jun 06, 2017 at 08:33:49AM -0700, Joe Perches wrote: > > On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote: > > > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > > > I noticed that in drivers/staging/unisys/visorbus/visorbus_ma

[PATCH] atomisp: ensure that status values > 7 are reported as errors

From: Colin Ian King The current code checks if a status value is greater than 7 and sets the status string as "ERROR" and then over writes the string based on the bottom 3 bits of the value. Instead, fix this by only checking on the bottom 3 bits of the value if the value is less than 8. Detect

Re: [PATCH] atomisp: ensure that status values > 7 are reported as errors

Am 06.06.2017 18:30, schrieb Colin King: > From: Colin Ian King > > The current code checks if a status value is greater than 7 and > sets the status string as "ERROR" and then over writes the > string based on the bottom 3 bits of the value. Instead, fix this by > only checking on the bottom 3

RE: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, June 6, 2017 11:06 AM > To: Kershner, David A > Cc: cor...@lwn.net; t...@linutronix.de; mi...@kernel.org; akpm@linux- > foundation.org; jes.soren...@gmail.com; linux-ker...@vger.kernel.org; > linux-

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote: > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you > > have 2 tabs for your 'struct attribute' variables, which is really odd. [] > Also, many of the attribute callba

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Tue, Jun 06, 2017 at 06:20:17PM +, Kershner, David A wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, June 6, 2017 11:06 AM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutronix.de; mi...@kernel.org; akpm@linux-

[driver-core:bus_type_removal 8/16] arch/powerpc/platforms/ps3/system-bus.c:480:18: error: 'ps3_system_bus_attrs' undeclared here (not in a function)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git bus_type_removal head: 4fe33425a6308e00d6bbe641e66abd3e78f45c3a commit: 5e6ce1375ec9909a33dd94942e8c85eaa52edf58 [8/16] powerpc: ps3: use dev_groups and not dev_attrs for bus_type config: powerpc-defconfig (attached

[driver-core:bus_type_removal 10/16] arch/powerpc/platforms/pseries/vio.c:1579:26: error: conflicting types for 'vio_dev_attrs'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git bus_type_removal head: 4fe33425a6308e00d6bbe641e66abd3e78f45c3a commit: 3b481f66e778743703a6cfea4c4bcdb4bbd138ad [10/16] powerpc: vio: use dev_groups and not dev_attrs for bus_type config: powerpc-defconfig (attached

[driver-core:bus_type_removal 11/16] arch/powerpc/platforms/pseries/vio.c:1002:23: error: 'cmo_allocs_failed_show' undeclared here (not in a function)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git bus_type_removal head: 4fe33425a6308e00d6bbe641e66abd3e78f45c3a commit: ded32ca684d535165ce291bf5cfb9d2f2eae1550 [11/16] powerpc: vio_cmo: use dev_groups and not dev_attrs for bus_type config: powerpc-defconfig (atta

Re: [PATCH 3/3] drivers: virt: Add visorbus to the drivers/virt directory

Hi David, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.12-rc4 next-20170606] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/David-Kershner/move-visorbus-out

[PATCH] Drivers: vt6655 - style fix

Fixed "function definition" issues Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/vt6655/card.h| 30 ++--- drivers/staging/vt6655/channel.h | 4 +-- drivers/staging/vt6655/mac.h | 58 drivers/staging/vt6655