Re: [PATCH 00/24] staging: ccree: more cleanup patches

2017-11-14 Thread Gilad Ben-Yossef
On Tue, Nov 14, 2017 at 11:48 AM, Dan Carpenter wrote: > On Tue, Nov 14, 2017 at 11:33:20AM +0200, Gilad Ben-Yossef wrote: >> On Mon, Nov 13, 2017 at 8:33 PM, Dan Carpenter >> wrote: >> > These cleanups look nice. Thanks. >> > >> > I hope you

[PATCH] binder: fix proc->files use-after-free

2017-11-14 Thread Todd Kjos
proc->files cleanup is initiated by binder_vma_close. Therefore a reference on the binder_proc is not enough to prevent the files_struct from being released while the binder_proc still has a reference. This can lead to an attempt to dereference the stale pointer obtained from proc->files prior to

Re: [PATCH net-next v2 0/2] retire IPX and NCPFS

2017-11-14 Thread David Miller
From: Stephen Hemminger Date: Tue, 14 Nov 2017 08:37:13 -0800 > These are both old decrepit protocols that need to be sent > to pasture. These need to go to gregkh and his staging/ tree, not net-next. ___ devel mailing list

RE: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, November 14, 2017 11:58 AM > To: Stephen Hemminger > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; KY Srinivasan

[PATCH 1/1] tools/hv: add install target to Makefile

2017-11-14 Thread kys
From: Vitaly Kuznetsov Makefiles usually come with 'install' target included so each distro doesn't need to implement the procedure from scratch. Add it to tools/hv. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan

[PATCH 1/1] hv: kvp: Avoid reading past allocated blocks from KVP file

2017-11-14 Thread kys
From: Paul Meyer While reading in more than one block (50) of KVP records, the allocation goes per block, but the reads used the total number of allocated records (without resetting the pointer/stream). This causes the records buffer to overrun when the refresh reads

[PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues

2017-11-14 Thread Chase Metzger
Fix if/else if and braces in function DIO0_irq_handler to comply with the kernel coding style. Signed-off-by: Chase Metzger --- drivers/staging/pi433/pi433_if.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git

[PATCH 0/2] Drivers: hv: vmbbus: Miscellaneous cleanup

2017-11-14 Thread kys
From: K. Y. Srinivasan Miscellaneous cleanup. Michael Kelley (1): Drivers: hv: vmbus: Remove x86-isms from arch independent drivers Stephen Hemminger (1): vmbus: make hv_get_ringbuffer_availbytes local arch/x86/hyperv/hv_init.c | 21 ++---

[PATCH 2/2] vmbus: make hv_get_ringbuffer_availbytes local

2017-11-14 Thread kys
From: Stephen Hemminger hv_get_ringbuffer_availbytes is only used by the debug info routine so make it static. Also, add READ_ONCE() to avoid any possible issues with potentially volatile index values. Signed-off-by: Stephen Hemminger

[PATCH 1/2] Drivers: hv: vmbus: Remove x86-isms from arch independent drivers

2017-11-14 Thread kys
From: Michael Kelley hv_is_hypercall_page_setup() is used to check if Hyper-V is initialized, but a 'hypercall page' is an x86 implementation detail that isn't necessarily present on other architectures. Rename to the architecture independent hv_is_hyperv_initialized()

Re: [PATCH net-next 2/2] ncpfs: move net/ncpfs to drivers/staging/ncpfs

2017-11-14 Thread Petr Vandrovec
On Tue, Nov 14, 2017 at 5:14 AM, Matthew Wilcox wrote: > On Sun, Nov 12, 2017 at 11:22:27AM -0800, Stephen Hemminger wrote: >> The Netware Core Protocol is a file system that talks to >> Netware clients over IPX. Since IPX has been dead for many years >> move the file system

Re: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Vitaly Kuznetsov
Stephen Hemminger writes: > On Tue, 14 Nov 2017 16:22:05 +0100 > Vitaly Kuznetsov wrote: > > Yes, this looks like a real issue. > >> +/* Query hardware capabilities if we're called from netvsc_probe() */ >> +if (!net->hw_features) { >> +

[PATCH net-next v2 2/2] ncpfs: move net/ncpfs to drivers/staging/ncpfs

2017-11-14 Thread Stephen Hemminger
The Netware Core Protocol is a file system that talks to Netware clients over IPX. Since IPX has been dead for many years move the file system into staging for eventual interment. Signed-off-by: Stephen Hemminger --- v2 add a TODO (don't touch me) file MAINTAINERS

[PATCH net-next v2 1/2] ipx: move Novell IPX protocol support into staging

2017-11-14 Thread Stephen Hemminger
The Netware IPX protocol is very old and no one should still be using it. It is time to move it into staging for a while and eventually decommision it. Signed-off-by: Stephen Hemminger --- v2 add a TODO (don't touch me) file MAINTAINERS

Re: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Stephen Hemminger
On Tue, 14 Nov 2017 16:22:05 +0100 Vitaly Kuznetsov wrote: Yes, this looks like a real issue. > + /* Query hardware capabilities if we're called from netvsc_probe() */ > + if (!net->hw_features) { > + ret = rndis_netdev_set_hwcaps(net_device,

[PATCH net-next v2 0/2] retire IPX and NCPFS

2017-11-14 Thread Stephen Hemminger
These are both old decrepit protocols that need to be sent to pasture. Stephen Hemminger (2): ipx: move Novell IPX protocol support into staging ncpfs: move net/ncpfs to drivers/staging/ncpfs MAINTAINERS| 5 ++--- drivers/staging/Kconfig

Re: [PATCH net-next v2] net: move decnet to staging

2017-11-14 Thread Joe Perches
On Mon, 2017-11-13 at 12:25 -0800, Eric Dumazet wrote: > On Mon, 2017-11-13 at 11:32 -0800, Joe Perches wrote: > > On Mon, 2017-11-13 at 09:11 -0800, Stephen Hemminger wrote: > > > Support for Decnet has been orphaned for some time. > > > In the interest of reducing the potential bug surface and

[PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Vitaly Kuznetsov
rndis_filter_device_add() is called both from netvsc_probe() when we initially create the device and from set channels/mtu/ringparam routines where we basically remove the device and add it back. hw_features is reset in rndis_filter_device_add() and filled with host data. However, we lose all

Re: [PATCH 0/9] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2017-11-14 Thread Arnd Bergmann
On Fri, Nov 10, 2017 at 11:42 PM, Deepa Dinamani wrote: > The series is a preparation series for individual architectures > to use 64 bit time_t syscalls in compat and 32 bit emulation modes. > > This is a follow up to the series Arnd Bergmann posted: >

[PATCH 2/2] Drivers: hv: vmbus: Fix a rescind issue

2017-11-14 Thread kys
From: K. Y. Srinivasan The current rescind processing code will not correctly handle the case where the host immediately rescinds a channel that has been offerred. In this case, we could be blocked in the open call and since the channel is rescinded, the host will not respond

[PATCH 0/2] Drivers: hv: vmbus: Miscellaneous fixes

2017-11-14 Thread kys
From: K. Y. Srinivasan Miscellaneous fixes. Dexuan Cui (1): vmbus: unregister device_obj->channels_kset K. Y. Srinivasan (1): Drivers: hv: vmbus: Fix a rescind issue drivers/hv/channel.c | 10 -- drivers/hv/channel_mgmt.c |7 ---

[PATCH 1/2] vmbus: unregister device_obj->channels_kset

2017-11-14 Thread kys
From: Dexuan Cui Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") Without the patch, a device can't be thoroughly destroyed, because vmbus_device_register() -> kset_create_and_add() still holds a reference to the hv_device's device.kobj. Signed-off-by: Dexuan Cui

Re: [PATCH net-next 2/2] ncpfs: move net/ncpfs to drivers/staging/ncpfs

2017-11-14 Thread Matthew Wilcox
On Sun, Nov 12, 2017 at 11:22:27AM -0800, Stephen Hemminger wrote: > The Netware Core Protocol is a file system that talks to > Netware clients over IPX. Since IPX has been dead for many years > move the file system into staging for eventual interment. Should probably cc Petr on this ... (added)

Re: [PATCH 00/24] staging: ccree: more cleanup patches

2017-11-14 Thread Dan Carpenter
On Tue, Nov 14, 2017 at 11:33:20AM +0200, Gilad Ben-Yossef wrote: > On Mon, Nov 13, 2017 at 8:33 PM, Dan Carpenter > wrote: > > These cleanups look nice. Thanks. > > > > I hope you do a mass remove of likely/unlikely in a patch soon. > > Whenever, I see one of those in

Re: [PATCH 00/24] staging: ccree: more cleanup patches

2017-11-14 Thread Gilad Ben-Yossef
On Mon, Nov 13, 2017 at 8:33 PM, Dan Carpenter wrote: > These cleanups look nice. Thanks. > > I hope you do a mass remove of likely/unlikely in a patch soon. > Whenever, I see one of those in a + line I always have to remind myself > that you're planning to do it in a

Re: [PATCH 07/24] staging: ccree: remove unneeded cast

2017-11-14 Thread Gilad Ben-Yossef
On Mon, Nov 13, 2017 at 5:41 PM, Joe Perches wrote: > > On Mon, 2017-11-13 at 14:45 +, Gilad Ben-Yossef wrote: > > Remove uneeded cast from writel_relaxed parameter. > [] > > diff --git a/drivers/staging/ccree/ssi_request_mgr.c > > b/drivers/staging/ccree/ssi_request_mgr.c