[PATCH 1/4] staging: ccree: Remove a attribute group from a kobject

All attribute group created during sys_init_dir() should be removed in sys_free_dir() Signed-off-by: Arvind Yadav --- drivers/staging/ccree/ssi_sysfs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.c

[PATCH 4/4] staging: most: Remove a attribute group from a kobject

All attribute group created during dim2_sysfs_probe() should be removed in dim2_sysfs_destroy(). Signed-off-by: Arvind Yadav --- drivers/staging/most/hdm-dim2/dim2_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/most/hdm-dim2/dim2_sysfs.c

[PATCH 2/4] staging: lustre: ldlm: Remove a attribute group from a kobject

All attribute group created during ldlm_setup() should be removed in ldlm_cleanup(). Signed-off-by: Arvind Yadav --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 0/4] Remove a attribute group from a kobject

Arvind Yadav (4): [PATCH 1/4] staging: ccree: Remove a attribute group from a kobject [PATCH 2/4] staging: lustre: ldlm: Remove a attribute group from a kobject [PATCH 3/4] staging: lustre: obdclass: Remove a attribute group from a kobject [PATCH 4/4] staging: most: Remove a attribute

[PATCH 3/4] staging: lustre: obdclass: Remove a attribute group from a kobject

All attribute group created during class_procfs_init() should be removed. if class_procfs_init() will fail and also in class_procfs_clean(). Signed-off-by: Arvind Yadav --- drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +++ 1 file changed, 3

Re: [PATCH v2] staging: rtl8188eu: Fix private WEXT IOCTL calls

On Sat, Nov 25, 2017 at 02:29:36AM +0100, ishraq.i.ash...@gmail.com wrote: > + > + ret = 0; > + Sorry, I wasn't clear before. When I said don't initialize "ret" to zero, I just meant that in that specific case we initialized "ret" and then immediately reassigned it with: ret =

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

Thanks for doing this. This needs to be folded in with the earlier patch you send and then resend it as a V2 patch. https://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb I added Johannes to the CC list again because this is sort of his fault... To be honest,

[PATCH v2] staging: rtl8188eu: Fix private WEXT IOCTL calls

From: Ishraq Ibne Ashraf Commit 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback") breaks private WEXT IOCTL calls of this driver as these are not invoked through ndo_do_ioctl interface anymore. As a result hostapd stops working with this driver. In this

[PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

From: Ishraq Ibne Ashraf Apply changes suggested by Dan Carpenter --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 1052 1 file changed, 536 insertions(+), 516 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

On Fri, Nov 24, 2017 at 04:02:09PM +0300, Dan Carpenter wrote: > On Fri, Nov 24, 2017 at 09:20:20AM +1100, Tobin C. Harding wrote: > > My current favourite review of all time was done by you on a what was > > at the time a pretty hard patch for me. It was > > > > Nope > > > > Wow... I know

Re: [staging:staging-testing 104/105] drivers/staging//fsl-mc/bus/fsl-mc-bus.c:663:9: warning: 'error' may be used uninitialized in this function

On Sat, Nov 25, 2017 at 01:01:18AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: f3145c023966af8e207b6b3cdb6187c35e7f9e95 > commit: 657582b9e91728b91307ef6ba6f069ed0b67c7b4 [104/105] staging: fsl-mc: > add

[staging:staging-testing 104/105] drivers/staging//fsl-mc/bus/fsl-mc-bus.c:663:9: warning: 'error' may be used uninitialized in this function

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: f3145c023966af8e207b6b3cdb6187c35e7f9e95 commit: 657582b9e91728b91307ef6ba6f069ed0b67c7b4 [104/105] staging: fsl-mc: add support for device type config: powerpc-allyesconfig (attached as .config)

RE: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

Hi Greg, > -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Friday, November 24, 2017 9:29 PM > To: Laurentiu Tudor > Cc: Bharat Bhushan ; Ruxandra Ioana Radulescu >

Re: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

On Wed, Nov 22, 2017 at 10:49:50AM +, Laurentiu Tudor wrote: > > > On 11/22/2017 09:48 AM, Bharat Bhushan wrote: > > As per APIs each mc-portal is of 64K size while currently > > 16bits (type u16) is used to store size of mc-portal. > > In these cases upper bit of portal size gets truncated.

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

On Tue, Nov 21, 2017 at 03:04:34PM +0100, Christian Gromm wrote: > This patch set fixes bugs and integrates the driver to the kernel's device > model by revising its architecture. Part of this change is rearranging the > directory layout, renaming of files and folders and thereby creating a >

Re: [PATCH 3/4] staging: lustre: fixed signedness of lov

On Wed, Nov 22, 2017 at 08:38:30PM +0100, Stefano Manni wrote: > sparse warning on lov_obd.c: > warning: incorrect type in argument 3 (different signedness) > expected int *res > got unsigned int [usertype] *i > > sparse warning on lov_offset.c: > warning: incorrect type in argument 4 (different

Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

On Sat, Nov 18, 2017 at 06:46:38PM +0100, Fabian Baumanis wrote: > Removed uneccessary parantheses which were sorrounding two > if-statements. > > Signed-off-by: Fabian Baumanis > --- >  drivers/staging/comedi/drivers/adl_pci9118.c | 3 +-- >  1 file changed, 1 insertion(+),

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

On 24.11.2017 16:31, Greg KH wrote: On Tue, Nov 21, 2017 at 03:04:34PM +0100, Christian Gromm wrote: This patch set fixes bugs and integrates the driver to the kernel's device model by revising its architecture. Part of this change is rearranging the directory layout, renaming of files and

Re: [PATCH 20/50] staging: most: core: remove struct device

On Fri, Nov 24, 2017 at 04:10:40PM +0100, Greg KH wrote: > On Wed, Nov 22, 2017 at 06:31:19PM +0530, PrasannaKumar Muralidharan wrote: > > Hi Christian, > > > > On 21 November 2017 at 19:34, Christian Gromm > > wrote: > > > This patch takes out the struct device of

Re: [PATCH 09/50] staging: most: remove proprietary kobjects

On Tue, Nov 21, 2017 at 03:04:43PM +0100, Christian Gromm wrote: > This patch removes the proprietary kobjects used by the driver modules and > replaces them with device structs. The patch is needed to have the driver > being integrated into the kernel's device model. > > Signed-off-by: Christian

Re: [PATCH 42/50] staging: most: core: fix data type

On Tue, Nov 21, 2017 at 03:05:16PM +0100, Christian Gromm wrote: > This patch fixes the type used to manage the channels of an > registered MOST interface. > > Signed-off-by: Christian Gromm > --- > drivers/staging/most/core.h | 2 +- > 1 file changed, 1

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

On Wed, Nov 22, 2017 at 06:30:42PM +0530, PrasannaKumar Muralidharan wrote: > Hi Christian, > > On 21 November 2017 at 19:34, Christian Gromm > wrote: > > This patch set fixes bugs and integrates the driver to the kernel's device > > model by revising its

Re: [PATCH 08/50] staging: most: video: rename module

On Tue, Nov 21, 2017 at 03:04:42PM +0100, Christian Gromm wrote: > This patch renames the folder of the video module. It is needed > to clean up the directory layout of the driver. > > Signed-off-by: Christian Gromm I've applied the first 8 of these patches, but I

Re: [PATCH 20/50] staging: most: core: remove struct device

On Wed, Nov 22, 2017 at 06:31:19PM +0530, PrasannaKumar Muralidharan wrote: > Hi Christian, > > On 21 November 2017 at 19:34, Christian Gromm > wrote: > > This patch takes out the struct device of struct most_aim, because it is > > not needed. > > Patch 9 adds

Re: [PATCH V2 23/29] staging: rts5208: deprecate pci_get_bus_and_slot()

On Wed, Nov 22, 2017 at 05:49:18PM -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot()

Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

On Fri, Nov 24, 2017 at 09:20:20AM +1100, Tobin C. Harding wrote: > My current favourite review of all time was done by you on a what was > at the time a pretty hard patch for me. It was > > Nope > Wow... I know I've said that to other people but I can't believe I sent that to *you*...

Re: [PATCH 1/4] staging: lustre: fixed signedness of some socklnd params

On Fri, Nov 24, 2017 at 12:47:21AM +0100, Stefano Manni wrote: > I've made the module param nsched signed because the > ksock_tunables.ksnd_nscheds (the real container) is signed too. Yeah. I know. And it's way more involved and controversial to change ksock_tunables. > > I definitely agree