[PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro

2018-03-04 Thread Arushi Singhal
Using pr_() is more concise than printk(KERN_). Replace printks having a log level with the appropriate pr_*() macros. Signed-off-by: Arushi Singhal --- drivers/staging/ipx/af_ipx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging

[PATCH] staging: pi433: fix CamelCase for address_filtering enum

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 12 ++-- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c

[PATCH] staging: pi433: fix CamelCase for packetFormat enum

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 8 drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 2 +- drivers/staging

[PATCH] staging: pi433: fix CamelCase for Address variables

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/driv

[PATCH] staging: pi433: fix CamelCase for afterSyncInterrupt

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi4

[PATCH] staging: pi433: fix CamelCase for paRamp enum

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH] staging: pi433: fix CamelCase for flag enum

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vid

[PATCH] staging: comedi: "dont" is changed to "don't"

2018-03-04 Thread Arushi Singhal
"dont" is changed to "don't" in messages, "dont" is not correct english. Signed-off-by: Arushi Singhal --- drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +- drivers/staging/comedi/drivers/das16.c | 2 +- drivers/staging/comedi/drivers/das16m1.c | 2 +- 3 files changed, 3 insertions(

Re: [Outreachy kernel] [PATCH] staging: comedi: "dont" is changed to "don't"

2018-03-04 Thread Julia Lawall
On Sun, 4 Mar 2018, Arushi Singhal wrote: > "dont" is changed to "don't" in messages, "dont" is not correct > english. The change is fine, but please rewrite the commit log in the imperative. julia > > Signed-off-by: Arushi Singhal > --- > drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +-

[PATCH v3 0/4] adis16209 driver cleanup

2018-03-04 Thread Shreeya Patel
This patchset has been introduced for the cleanup of adis16209 driver. This patchset cleans up miscellaneous code fragments and improves the code readability. Changes in v3 -Combine some patches into one from the previous series and add some more comments in patch *[1/4]. Introduce a new patch *

[PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

2018-03-04 Thread Shreeya Patel
Remove some unnecessay comments and group the control register and register field macros together. Some of the register names does not make it's puporse very clear and hence, add some comments for more information. Also there are certain unit based comments which are not providing sufficient inform

[PATCH v3 2/4] Staging: iio: adis16209: Change some macro names

2018-03-04 Thread Shreeya Patel
Make some of the macro names according to the names given in the datasheet of the adis16209 driver. Signed-off-by: Shreeya Patel --- Changes in v3 -Introduce this new patch for v3 of the series. drivers/staging/iio/accel/adis16209.c | 48 +-- 1 file changed, 2

[PATCH v3 3/4] Staging: iio: adis16209: Adjust a switch statement

2018-03-04 Thread Shreeya Patel
Adjust a switch block to explicitly match channels and return -EINVAL as default case which makes the code semantically more clear. Signed-off-by: Shreeya Patel --- Changes in v3 -After split patch. drivers/staging/iio/accel/adis16209.c | 10 -- 1 file changed, 8 insertions(+), 2 del

[PATCH v3 4/4] Staging: iio: adis16209: Use sign_extend32 function

2018-03-04 Thread Shreeya Patel
Use sign_extend32 function instead of manually coding it. Signed-off-by: Shreeya Patel --- Changes in v3 -After split patch. drivers/staging/iio/accel/adis16209.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging

Re: [PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

2018-03-04 Thread Himanshu Jha
Hi Shreeya, On Sun, Mar 04, 2018 at 06:06:22PM +0530, Shreeya Patel wrote: > Remove some unnecessay comments and group the control > register and register field macros together. > Some of the register names does not make it's puporse > very clear and hence, add some comments for more > information

Re: [PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

2018-03-04 Thread Shreeya Patel
On Sun, 2018-03-04 at 18:26 +0530, Himanshu Jha wrote: > Hi Shreeya, > > On Sun, Mar 04, 2018 at 06:06:22PM +0530, Shreeya Patel wrote: > > > > Remove some unnecessay comments and group the control > > register and register field macros together. > > Some of the register names does not make it's

Re: [PATCH] staging: pi433: fix CamelCase for packetFormat enum

2018-03-04 Thread Greg Kroah-Hartman
On Sun, Mar 04, 2018 at 10:55:56AM +0100, Valentin Vidic wrote: > Fixes checkpatch warnings: > > CHECK: Avoid CamelCase: > CHECK: Avoid CamelCase: > CHECK: Avoid CamelCase: > > Signed-off-by: Valentin Vidic > --- Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent

Re: [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro

2018-03-04 Thread Greg KH
On Sun, Mar 04, 2018 at 02:29:35PM +0530, Arushi Singhal wrote: > Using pr_() is more concise than printk(KERN_). > Replace printks having a log level with the appropriate pr_*() macros. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/ipx/af_ipx.c | 2 +- > 1 file changed, 1 insertion(

[PATCH 2/3] staging: lustre: Replace "to to" with "to"

2018-03-04 Thread Arushi Singhal
This patch replace "to to" with "to". Signed-off-by: Arushi Singhal --- drivers/staging/lustre/lustre/include/cl_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/include/cl_object.h b/drivers/staging/lustre/lustre/include/cl_object.h ind

[PATCH 0/3] staging: lustre: cleanup

2018-03-04 Thread Arushi Singhal
Spellcheck the comments. Remove the repeated, consecutive words with single word. Arushi Singhal (3): staging: lustre: Replace "be be" with "be" staging: lustre: Replace "to to" with "to" staging: lustre: Replace "dont" with "don't" drivers/staging/lustre/lnet/libcfs/debug.c |

[PATCH 1/3] staging: lustre: Replace "be be" with "be"

2018-03-04 Thread Arushi Singhal
This patch replace "be be" with "be". Signed-off-by: Arushi Singhal --- drivers/staging/lustre/lnet/libcfs/debug.c | 2 +- drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/libcfs/

[PATCH 3/3] staging: lustre: Replace "dont" with "don't"

2018-03-04 Thread Arushi Singhal
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't". Signed-off-by: Arushi Singhal --- drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/fld/fld_cache.c b/drivers/staging/lustre/lust

[PATCH 0/3] staging: media: cleanup

2018-03-04 Thread Arushi Singhal
Spellcheck the comments. Remove the repeated, consecutive words with single word. Arushi Singhal (3): staging: media: Replace "be be" with "be" staging: media: Replace "cant" with "can't" staging: media: Replace "dont" with "don't" drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_

[PATCH 2/3] staging: media: Replace "cant" with "can't"

2018-03-04 Thread Arushi Singhal
Replace "cant" with "can't". "cant" is not same as "Can not" or "Can't". Signed-off-by: Arushi Singhal --- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/stag

[PATCH 1/3] staging: media: Replace "be be" with "be"

2018-03-04 Thread Arushi Singhal
This patch replace "be be" with "be". Signed-off-by: Arushi Singhal --- drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h b/drivers/

[PATCH 3/3] staging: media: Replace "dont" with "don't"

2018-03-04 Thread Arushi Singhal
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't". Signed-off-by: Arushi Singhal --- drivers/staging/media/atomisp/pci/atomisp2/mmu/isp_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/mmu/isp_mmu.c b/drive

Re: [Outreachy kernel] [PATCH 0/3] staging: media: cleanup

2018-03-04 Thread Julia Lawall
On Sun, 4 Mar 2018, Arushi Singhal wrote: > Spellcheck the comments. > Remove the repeated, consecutive words with single word. For the series: Acked-by: Julia Lawall But please look out for things to change in the code, not just in the comments. julia > > Arushi Singhal (3): > staging:

Re: [Outreachy kernel] [PATCH 0/3] staging: lustre: cleanup

2018-03-04 Thread Julia Lawall
On Sun, 4 Mar 2018, Arushi Singhal wrote: > Spellcheck the comments. > Remove the repeated, consecutive words with single word. > > Arushi Singhal (3): > staging: lustre: Replace "be be" with "be" > staging: lustre: Replace "to to" with "to" > staging: lustre: Replace "dont" with "don't"

Re: [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h

2018-03-04 Thread Helge Deller
On 16.01.2018 03:18, Deepa Dinamani wrote: > All the current architecture specific defines for these > are the same. Refactor these common defines to a common > header file. > > The new common linux/compat_time.h is also useful as it > will eventually be used to hold all the defines that > are nee

[PATCH v2] staging: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Indentation is also changed, to fix the checkpatch issue. Signed-off-by: Arushi Singhal --- changes in v2 *In previous version printk was changed to

Re: [Outreachy kernel] [PATCH v2] staging: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. Why did you choose this function? > It's better to use actual device name as a prefix in error messages. What does this message relate to. > Indentation is also change

[PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Indentation is also changed, to fix the checkpatch issue if line is not exceding 80 characters. Signed-off-by: Arushi Singhal --- .../rtl8192u/ieee

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

2018-03-04 Thread Tobin C. Harding
On Fri, Mar 02, 2018 at 12:05:03PM +0300, Dan Carpenter wrote: > There are so many rules for kernel developers to deal with. Is it worse > to go over the 80 character limit or align the parameters properly? Is > it OK to start the subject with a lower case letter? I get in trouble > for using th

THE TRUTH ABOUT YOUR FUNDS!!

2018-03-04 Thread Patricia Frantisek
I am Mrs Patricia Frantisek, I am a US citizen, 54 years Old. I reside here in Sunny-Dale Ave. My residential address is as follows. 1934 Sunny-Dale Ave,San Francisco,Ca 94134 , United States, am thinking of relocating since I am now rich. I am one of those that took part in the Compensation in

THE TRUTH ABOUT YOUR FUNDS!!

2018-03-04 Thread Patricia Frantisek
I am Mrs Patricia Frantisek, I am a US citizen, 54 years Old. I reside here in Sunny-Dale Ave. My residential address is as follows. 1934 Sunny-Dale Ave,San Francisco,Ca 94134 , United States, am thinking of relocating since I am now rich. I am one of those that took part in the Compensation in

Re: [PATCH PATCH net v2 0/9] hv_netvsc: minor fixes

2018-03-04 Thread David Miller
From: Stephen Hemminger Date: Fri, 2 Mar 2018 13:49:00 -0800 > These are improvements to netvsc driver. They aren't functionality > changes so not targeting net-next; and they are not show stopper > bugs that need to go to stable either. > > v2 >- drop the irq flags patch, defer it to net-n

[PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Signed-off-by: Arushi Singhal --- changes in v2 *In v1 printk was changed to pr_*macro(), which is used in kernel instead of calling printk() directl

[PATCH v2] staging: comedi: Replace "dont" with "don't

2018-03-04 Thread Arushi Singhal
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't". Signed-off-by: Arushi Singhal --- changes in v2 *Commit log is rewrite in the imperative. drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +- drivers/staging/comedi/drivers/das16.c | 2 +- drivers/staging/comedi/driv

[PATCH V2 00/12] Drivers: hv: Miscellaneous fixes

2018-03-04 Thread kys
From: "K. Y. Srinivasan" Miscellaneous fixes. V2: Only the patch "Drivers: hv: vmbus: Implement Direct Mode for stimer0" has been modified to address review comments from Dan Carpenter. Dexuan Cui (1): tools: hv: fix compiler warnings about major/target_fname Haiyang Zhang (2

[PATCH V2 02/12] hyper-v: use GFP_KERNEL for hv_context.hv_numa_map

2018-03-04 Thread kys
From: Jia-Ju Bai The kzalloc function is called with GFP_ATOMIC. But according to driver call graph, it is not in atomic context, namely no spinlock is held nor in an interrupt handler. This GFP_ATOMIC is unnecessary, and replace with GFP_KERNEL. Signed-off-by: Jia-Ju Bai Reviewed-by: Vitaly K

[PATCH V2 01/12] tools/hv: Fix IP reporting by KVP daemon with SRIOV

2018-03-04 Thread kys
From: Haiyang Zhang On Hyper-V the VF NIC has the same MAC as the related synthetic NIC. VF NIC can work under the synthetic NIC transparently, without its own IP address. The existing KVP daemon only gets IP from the first NIC matching a MAC address, and may not be able to find the IP in this ca

[PATCH V2 07/12] hv_vmbus: Correct the stale comments regarding cpu affinity

2018-03-04 Thread kys
From: Haiyang Zhang The comments doesn't match what the current code does, also have a typo. This patch corrects them. Signed-off-by: Haiyang Zhang Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 6 ++ include/linux/hyperv.h| 2 +- 2 files changed, 3 insertions(+), 5 d

[PATCH V2 11/12] hv_balloon: fix bugs in num_pages_onlined accounting

2018-03-04 Thread kys
From: Vitaly Kuznetsov Our num_pages_onlined accounting is buggy: 1) In case we're offlining a memory block which was present at boot (e.g. when there was no hotplug at all) we subtract 32k from 0 and as num_pages_onlined is unsigned get a very big positive number. 2) Commit 6df8d9aaf3af (

[PATCH V2 12/12] hv_balloon: trace post_status

2018-03-04 Thread kys
From: Vitaly Kuznetsov Hyper-V balloon driver makes non-trivial calculations to convert Linux's representation of free/used memory to what Hyper-V host expects to see. Add a tracepoint to see what's being sent and where the data comes from. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. S

[PATCH V2 03/12] hv: Synthetic typo correction

2018-03-04 Thread kys
From: Joe Perches Just a trivial tyop fix. Signed-off-by: Joe Perches Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index b6cacc4cccf2..31142b72f1b9 100644 --- a/drivers/hv/hv.c +++ b/d

[PATCH V2 04/12] tools: hv: fix compiler warnings about major/target_fname

2018-03-04 Thread kys
From: Dexuan Cui This patch fixes the below warnings with new glibc and gcc: hv_vss_daemon.c:100:13: warning: In the GNU C Library, "major" is defined by . For historical compatibility, it is currently defined by as well, but we plan to remove this soon. To use "major", include directly. h

[PATCH V2 09/12] hv_balloon: fix printk loglevel

2018-03-04 Thread kys
From: Vitaly Kuznetsov We have a mix of different ideas of which loglevel should be used. Unify on the following: - pr_info() for normal operation - pr_warn() for 'strange' host behavior - pr_err() for all errors. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/

[PATCH V2 06/12] vmbus/ring_buffer: remove some redundant helper function.

2018-03-04 Thread kys
From: "lantianyu1...@gmail.com" Some hv_get/set** helper functions in ring_buffer code are only called once or not used. This patch is to clear up these codes. Signed-off-by: Tianyu Lan Signed-off-by: K. Y. Srinivasan --- drivers/hv/ring_buffer.c | 49 -

[PATCH V2 05/12] tools: hv: include string.h in hv_fcopy_daemon

2018-03-04 Thread kys
From: Olaf Hering The usage of strchr requires inclusion of string.h. Fixes: 0c38cda64aec ("tools: hv: remove unnecessary header files and netlink related code") Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_fcopy_daemon.c | 1 + 1 file changed, 1 insertion(+) d

[PATCH V2 08/12] Drivers: hv: vmbus: Implement Direct Mode for stimer0

2018-03-04 Thread kys
From: Michael Kelley The 2016 version of Hyper-V offers the option to operate the guest VM per-vcpu stimer's in Direct Mode, which means the timer interupts on its own vector rather than queueing a VMbus message. Direct Mode reduces timer processing overhead in both the hypervisor and the guest,

[PATCH V2 10/12] hv_balloon: simplify hv_online_page()/hv_page_online_one()

2018-03-04 Thread kys
From: Vitaly Kuznetsov Instead of doing pfn_to_page() and continuosly casting page to unsigned long just cache the pfn of the page with page_to_pfn(). Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c | 27 +-- 1 file changed,

[PATCH 1/1] Drivers: hv: vmbus: Fix ring buffer signaling

2018-03-04 Thread kys
From: Michael Kelley Fix bugs in signaling the Hyper-V host when freeing space in the host->guest ring buffer: 1. The interrupt_mask must not be used to determine whether to signal on the host->guest ring buffer 2. The ring buffer write_index must be read (via hv_get_bytes_to_write) *after

RE: [PATCH 2/3] PCI: hv: serialize the present/eject work items

2018-03-04 Thread Dexuan Cui
> From: Michael Kelley (EOSG) > Sent: Saturday, March 3, 2018 08:10 > > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Dexuan Cui > > Sent: Friday, March 2, 2018 4:21 PM > > When we hot-remove the device, we first receive a PCI_EJECT message and > > then receive a PCI

[PATCH] staging: bcm2835-audio: Release resources on module_exit()

2018-03-04 Thread Kirill Marinushkin
In the current implementation, `rmmod snd_bcm2835` does not release resources properly. It causes an oops when trying to list sound devices. This commit fixes it. Steps to reproduce: $ rmmod snd_bcm2835 $ aplay -L [ 138.648130] Unable to handle kernel paging request at virtual address 7f1

Re: [PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Greg KH
On Mon, Mar 05, 2018 at 09:47:40AM +0530, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > > Signed-off-by: Arushi Singhal > --- > changes in v2 > *In v1 printk was cha

Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Greg KH
On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > Indentation is also changed, to fix the checkpatch issue if line is not > exce

[PATCH 1/6 v2] staging: pi433: fix CamelCase for packetFormat enum

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- v2: order patches so they apply correctly drivers/staging/pi433/pi433_if.c | 8 drivers/staging/pi433/rf69.c | 8 drivers/stagin

[PATCH 3/6] staging: pi433: fix CamelCase for afterSyncInterrupt

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi4

[PATCH 4/6] staging: pi433: fix CamelCase for address_filtering enum

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 12 ++-- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c

[PATCH 6/6] staging: pi433: fix CamelCase for paRamp enum

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH 2/6] staging: pi433: fix CamelCase for flag enum

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vid

[PATCH 5/6] staging: pi433: fix CamelCase for Address variables

2018-03-04 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/driv

Re: [Outreachy kernel] [PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > > Signed-off-by: Arushi Singhal > --- > changes in v2 > *In v1 printk was changed to pr_*macro(),

Re: [Outreachy kernel] [PATCH v2] staging: comedi: Replace "dont" with "don't

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace "dont" with "don't". > "Dont" is not same as "Do not" or "Don't". > > Signed-off-by: Arushi Singhal Acked-by: Julia Lawall > --- > changes in v2 > *Commit log is rewrite in the imperative. > > drivers/staging/comedi/drivers/cb_pcidas64.c |

[PATCH v2] staging: rtl8192u: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Indentation is also changed, to fix the checkpatch issue if line is not exceding 80 characters. Signed-off-by: Arushi Singhal --- changes in v2 *cha

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. I asked several questions about the above two lines, which as far as I can see haven't been answere

[PATCH 02/11] Staging: iio: accel: Add a blank space before returns

2018-03-04 Thread Himanshu Jha
Adding a blank space before/after some returns improves readability. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c index 0f6a204..0fae8aa

[PATCH 03/11] Staging: iio: accel: Remove unnecessary comments

2018-03-04 Thread Himanshu Jha
Remove unnecessary comments since the definitions are pretty clear with their macro names. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 82 +-- 1 file changed, 10 insertions(+), 72 deletions(-) diff --git a/drivers/staging/iio/accel/adi

[PATCH 04/11] Staging: iio: accel: Rename few macro definitions

2018-03-04 Thread Himanshu Jha
Rename few macros with appropriate names specifying their usage/function. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel

[PATCH 01/11] Staging: iio: accel: Prefer alphabetical sequence of header files

2018-03-04 Thread Himanshu Jha
Arrange header files in alphabetical sequence to improve readability. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c ind

[PATCH 00/11] staging: iio: accel: adis16201 driver cleanup

2018-03-04 Thread Himanshu Jha
The following patch series cleans up miscellaneous code fragments and then the driver is moved from staging to mainline IIO subsytem directory. Note that the last patch to move driver is *not* generated using '-M' flag, which is used for detecting renames, since it may help reviewers to suggest mor

[PATCH 06/11] Staging: iio: accel: Reverse christmas tree

2018-03-04 Thread Himanshu Jha
Prefer reverse christmas tree ordering of declarations to improve readability. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis1620

[PATCH 07/11] Staging: iio: accel: Adjust arguments to match open parentheses

2018-03-04 Thread Himanshu Jha
In adis16201_read_raw() adjust an argument to match an open parentheses using tabs. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis162

[PATCH 09/11] Staging: iio: accel: Use sign_extend32 function

2018-03-04 Thread Himanshu Jha
Use sign_extned32() for 32 bit sign extending rather than hard coding the same. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16

[PATCH 05/11] Staging: iio: accel: Add _REG suffix to registers

2018-03-04 Thread Himanshu Jha
Addition of _REG suffix to the register definitions allows a distinction between registers and register fields. The various registers and its field bits are grouped together to improve readability and easy indentification. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 1

[PATCH 08/11] Staging: iio: accel: Use switch statement than if-else

2018-03-04 Thread Himanshu Jha
Use switch statement instead of if-else pair to explicitly match the only two channels present. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/stagin

[PATCH 10/11] Staging: iio: accel: Add comments about units in data read function

2018-03-04 Thread Himanshu Jha
Clarify the conversion and formation of resultant data in the adis16201_read_raw() with sufficient comments. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/stag

[PATCH 11/11] Staging: iio: accel: Move adis16201 driver out of staging subsystem

2018-03-04 Thread Himanshu Jha
Move the adis16201 driver out of staging directory and merge to the mainline IIO subsystem. Signed-off-by: Himanshu Jha --- drivers/iio/accel/Kconfig | 12 ++ drivers/iio/accel/Makefile| 1 + drivers/iio/accel/adis16201.c | 323 +