Greg deleted your patch already...
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Baoquan,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Hi Baoquan,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:
> +/* PTP nominal frequency 1GHz */
> +#define DPAA2_PTP_NOMINAL_FREQ_PERIOD_NS 1
Nit: Frequency is the inverse of the period. It can be one or the
other, not both.
Why not call it simply DPAA2_PTP_CLK_PERIOD_NS?
You haven't
On Wed, 25 Apr 2018, Christoph Hellwig wrote:
>
> -/*
> - * /proc/nubus stuff
> - */
> -
I don't think that the introduction of proc_create_single{,_data} alters
the value of that comment. That comment and similar comments in the same
file do have a purpose, which is to keep separate the
On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote:
>The struct resource uses singly linked list to link siblings. It's not
>easy to do reverse iteration on sibling list. So replace it with list_head.
>
Hi, Baoquan
Besides changing the data structure, I have another proposal to do the
On Tue, Apr 24, 2018 at 06:06:53PM +0200, Christoph Hellwig wrote:
> On Tue, Apr 24, 2018 at 08:19:16AM -0700, Andrew Morton wrote:
> > > > I want to ask if it is time to start using poorman function overloading
> > > > with _b_c_e(). There are millions of allocation functions for example,
> > > >
On 25/04/2018 17:48:14+0200, Christoph Hellwig wrote:
> And stop trying to get a reference on the submodule, procfs code deals
> with release after and unloaded module and thus removed proc entry.
small typo here^
>
> Signed-off-by: Christoph Hellwig
Acked-by: Alexandre
From: "K. Y. Srinivasan"
Support enhanced IPI enlightenments (to target more than 64 CPUs).
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_apic.c | 49 --
arch/x86/include/asm/hyperv-tlfs.h | 1 +
From: "K. Y. Srinivasan"
Implement APIC related enlightenments.
K. Y. Srinivasan (5):
X86: Hyper-V: Enlighten APIC access
X86: Hyper-V: Enable IPI enlightenments
X86: Hyper-V: Enhanced IPI enlightenment
X86: Hyper-V: Consolidate code for converting cpumask to vpset
From: "K. Y. Srinivasan"
Consolidate code for converting cpumask to vpset.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_apic.c | 2 +-
arch/x86/hyperv/mmu.c | 45 +++---
From: "K. Y. Srinivasan"
Hyper-V supports hypercalls to implement IPI; use them.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_apic.c | 125 +
arch/x86/hyperv/hv_init.c | 17 +
From: "K. Y. Srinivasan"
Hyper-V supports MSR based APIC access; implement
the enlightenment.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/Makefile| 2 +-
arch/x86/hyperv/hv_apic.c | 98 +
On Wed, Apr 25, 2018 at 01:00:09AM -0400, Mimi Zohar wrote:
> On Tue, 2018-04-24 at 23:42 +, Luis R. Rodriguez wrote:
> > On Tue, Apr 24, 2018 at 12:07:01PM -0400, Mimi Zohar wrote:
> > > On Tue, 2018-04-24 at 17:09 +0200, Hans de Goede wrote:
> > > > On 23-04-18 23:11, Luis R. Rodriguez
Defined function as static which are used only in single file. And also removed
their declaration from header file.
Below function are changed to static
wilc_wlan_initialize()
wilc_wlan_deinitialize()
wilc_wlan_get_firmware()
Signed-off-by: Ajay Singh
---
Cleanup patch to remove unused element from 'wilc_priv' structure.
Below elements are removed in 'wilc_priv' structure:
struct WILC_WFI_packet *ppool;
struct WILC_WFI_packet *rx_queue; /* List of incoming packets */
int rx_int_enabled;
int tx_packetlen;
u8 *tx_packetdata;
struct napi_struct
Reorder the functions in linux_wlan.c file to avoid having explicit
declaration of static functions. Forward declaration is avoided
with the help of reordering the function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 106
Cleanup patch to remove unnecessary inner block {\* *\} in
handle_remain_on_chan().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git
Rename P2P_LISTEN_STATE variable to avoid using uppercase for variable
name to follow linux coding style.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Rename the mac status macro to follow the same naming style. Also move
them to keep together.
Renamed like below
>From > To
WILC_MAC_STATUS_INIT -> MAC_STATUS_INIT
MAC_CONNECTED > MAC_STATUS_CONNECTED
MAC_DISCONNECTED -> MAC_STATUS_DISCONNECTED
Cleanup patch to remove the unused enum.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
b/drivers/staging/wilc1000/wilc_wfi_netdevice.h
Rename wilc1000_wlan_init() & wilc1000_wlan_deinit() function to avoid
unecessary 'wilc1000' prefix in function to be inline with other
function naming convension.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 10 +-
Cleanup patch to have struct name as per linux coding style.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
Cleanup patch to follow name as per linux coding style.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
Cleanup patch to remove unused #define.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_if.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h
b/drivers/staging/wilc1000/wilc_wlan_if.h
index eb8d819..e8a56f4
Cleanup patch to remove the unused variable.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
Cleanup patch to remove the unnecessary use of '==' check used in if
conditions.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 12 ++--
drivers/staging/wilc1000/wilc_spi.c | 6 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
This patch series contains fixes to remove the unused code. It also has patches
to reorganize the function and simplify the function logic.
Ajay Singh (21):
staging: wilc1000: replace crc7_byte() with inline macro CRC7_BYTE
staging: wilc1000: align the #define in wilc_spi file
staging:
Remove below #define which are not used in code:
WILC_MAC_STATUS_READY
WILC_MAC_STATUS_CONNECT
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_if.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h
Cleanup patch to align the #define used in wilc_spi.c file by adding the
tabs.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git
Cleanup patch to remove the 'cmd' variable in wilc_spi.c. Instead of
using cmd now passing the command directly.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Cleanup patch to remove the unused typedef and also removed the
unecessary comment about that typedef.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.h
Cleanup patch to remove the unnecessary {/**/} block in
wilc_parse_network_info().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/coreconfigurator.c | 77 ++---
1 file changed, 37 insertions(+), 40 deletions(-)
diff --git
Cleanup patch to simplify the if conditions logic in spi_data_write().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c
Cleanup patch to remove the unused variables in
wilc_parse_network_info(). The value is assinged to these local
variables but assinged value is not used in that function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/coreconfigurator.c | 7 ---
1 file
Replace the function call for crc7_byte() with macro CRC7_BYTE.
crc7_byte() was called in close while(), so replaced it with macro to
avoid extra functional call depth.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 7 ++-
1 file changed, 2
W dniu 2018-04-24 o 15:18, Luc Van Oostenryck pisze:
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van
W dniu 2018-04-24 o 15:18, Luc Van Oostenryck pisze:
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van
Hi Luc,
I'm resending this since last time I only send it to staging ml.
Could you, please, change the "return 0;"s inside wilc_mac_xmit() with
"return NETDEV_TX_OK" ?
Thank you,
Claudiu
On 24.04.2018 15:18, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an
On 04/24/2018 08:43 PM, vji...@codeaurora.org wrote:
From: Vijayanand Jitta
An issue is observed where mallocs are failing due to overcommit failure.
The failure happens when there is high ION page pool since ION page
pool is not considered reclaimable by the overcommit
The driver proc file hasn't been writeable for a long time, so this is
just dead code.
Signed-off-by: Christoph Hellwig
---
drivers/ide/ide-proc.c | 46 --
1 file changed, 46 deletions(-)
diff --git a/drivers/ide/ide-proc.c
Just set up the show callback in the tty_operations, and use
proc_create_single_data to create the file without additional
boilerplace code.
Signed-off-by: Christoph Hellwig
---
drivers/ide/ide-cd.c | 15 +---
drivers/ide/ide-disk_proc.c | 62 ++--
And switch to proc_create_single_data.
Signed-off-by: Christoph Hellwig
---
drivers/isdn/capi/kcapi.c | 3 ++-
drivers/isdn/gigaset/capi.c| 16 +---
drivers/isdn/hardware/avm/avmcard.h| 4 ++--
drivers/isdn/hardware/avm/b1.c | 17
And use proc private data directly instead of doing a detour
through seq->private and private state.
Signed-off-by: Christoph Hellwig
---
net/bluetooth/af_bluetooth.c | 40 +---
1 file changed, 5 insertions(+), 35 deletions(-)
diff --git
Just set up the show callback in the tty_operations, and use
proc_create_single_data to create the file without additional
boilerplace code.
Signed-off-by: Christoph Hellwig
---
arch/ia64/hp/sim/simserial.c| 15 +--
arch/xtensa/platforms/iss/console.c | 15
Signed-off-by: Christoph Hellwig
---
fs/proc/array.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/fs/proc/array.c b/fs/proc/array.c
index ae2c807fd719..b34796b562ef 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -677,7 +677,7 @@
And remove proc boilerplate code.
Signed-off-by: Christoph Hellwig
---
net/atm/proc.c | 72 +-
1 file changed, 13 insertions(+), 59 deletions(-)
diff --git a/net/atm/proc.c b/net/atm/proc.c
index f272b0f59d82..0b0495a41bbe 100644
---
And use proc private data directly instead of doing a detour
through seq->private.
Signed-off-by: Christoph Hellwig
---
net/netfilter/xt_hashlimit.c | 92 +++-
1 file changed, 18 insertions(+), 74 deletions(-)
diff --git
And remove proc boilerplate code.
Signed-off-by: Christoph Hellwig
---
net/netfilter/x_tables.c | 42 ++--
1 file changed, 6 insertions(+), 36 deletions(-)
diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
index
And use proc private data directly instead of doing a detour
through seq->private.
Signed-off-by: Christoph Hellwig
---
net/core/neighbour.c | 31 ++-
1 file changed, 6 insertions(+), 25 deletions(-)
diff --git a/net/core/neighbour.c
And stop trying to get a reference on the submodule, procfs code deals
with release after and unloaded module and thus removed proc entry.
Signed-off-by: Christoph Hellwig
---
drivers/rtc/rtc-proc.c | 33 ++---
1 file changed, 2 insertions(+), 31
Variants of proc_create{,_data} that directly take a struct seq_operations
and deal with network namespaces in ->open and ->release. All callers of
proc_create + seq_open_net converted over, and seq_{open,release}_net are
removed entirely.
Signed-off-by: Christoph Hellwig
---
And use the root resource directly from the proc private data.
Signed-off-by: Christoph Hellwig
---
kernel/resource.c | 43 +--
1 file changed, 5 insertions(+), 38 deletions(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index
Use remove_proc_subtree to remove the whole subtree on cleanup, and
unwind the registration loop into individual calls. Switch to use
proc_create_seq where applicable.
Signed-off-by: Christoph Hellwig
---
fs/afs/proc.c | 134 ++
1
And use proc private data directly instead of doing a detour
through seq->private.
Signed-off-by: Christoph Hellwig
---
drivers/net/bonding/bond_procfs.c | 36 ++-
1 file changed, 6 insertions(+), 30 deletions(-)
diff --git
Use remove_proc_subtree to remove the whole subtree on cleanup, and
unwind the registration loop into individual calls. Switch to use
proc_create_seq where applicable.
Signed-off-by: Christoph Hellwig
---
fs/ext4/ext4.h| 2 +-
fs/ext4/mballoc.c | 29
And use proc private data directly instead of doing a detour
through seq->private.
Signed-off-by: Christoph Hellwig
---
.../net/wireless/intersil/hostap/hostap_ap.c | 70 ++---
.../net/wireless/intersil/hostap/hostap_hw.c | 17 +--
.../wireless/intersil/hostap/hostap_proc.c
Use remove_proc_subtree to remove the whole subtree on cleanup, and
unwind the registration loop into individual calls. Switch to use
proc_create_seq where applicable.
Signed-off-by: Christoph Hellwig
---
fs/jfs/jfs_debug.c| 43 ++-
Unwind the registration loop into individual calls. Switch to use
proc_create_single where applicable.
Signed-off-by: Christoph Hellwig
---
drivers/staging/rtl8192u/r8192U_core.c | 67 ++
1 file changed, 14 insertions(+), 53 deletions(-)
diff --git
Use remove_proc_subtree to remove the whole subtree on cleanup, and
unwind the registration loop into individual calls. Switch to use
proc_create_single.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/megaraid.c | 140 +++-
Use remove_proc_subtree to remove the whole subtree on cleanup, and
unwind the registration loop into individual calls. Switch to use
proc_create_seq where applicable.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/sg.c | 124 +-
1
Use remove_proc_subtree to remove the whole subtree on cleanup, and
unwind the registration loop into individual calls. Switch to use
proc_create_seq where applicable.
Signed-off-by: Christoph Hellwig
---
drivers/misc/sgi-gru/gruprocfs.c | 81 ++--
1
Remove the pointless ping_seq_afinfo indirection and make the code look
like most other protocols.
Signed-off-by: Christoph Hellwig
---
include/net/ping.h | 11 --
net/ipv4/ping.c| 50 +-
net/ipv6/ping.c| 35
Use remove_proc_subtree to remove the whole subtree on cleanup, and
unwind the registration loop into individual calls. Switch to use
proc_create_seq where applicable.
Signed-off-by: Christoph Hellwig
Reviewed-by: Rafael J. Wysocki
---
Variant of proc_create_data that directly take a seq_file show
callback and deals with network namespaces in ->open and ->release.
All callers of proc_create + single_open_net converted over, and
single_{open,release}_net are removed entirely.
Signed-off-by: Christoph Hellwig
---
The shole seq_file sequence already operates under a single RCU lock pair,
so move the pid namespace lookup into it, and stop grabbing a reference
and remove all kinds of boilerplate code.
Signed-off-by: Christoph Hellwig
---
net/ipv6/ip6_flowlabel.c | 28
This helper deals with single_{open,release}_net internals and thus
belongs here.
Signed-off-by: Christoph Hellwig
---
include/linux/seq_file_net.h | 13 +
include/net/ip_vs.h | 12
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git
Just use the address family from the proc private data instead of copying
it into per-file data.
Signed-off-by: Christoph Hellwig
---
net/netfilter/x_tables.c | 39 +++
1 file changed, 11 insertions(+), 28 deletions(-)
diff --git
Remove a couple indirections to make the code look like most other
protocols.
Signed-off-by: Christoph Hellwig
---
net/kcm/kcmproc.c | 71 ---
1 file changed, 17 insertions(+), 54 deletions(-)
diff --git a/net/kcm/kcmproc.c
Avoid most of the afinfo indirections and just call the proc helpers
directly.
Signed-off-by: Christoph Hellwig
---
include/net/tcp.h | 11 ++
net/ipv4/tcp_ipv4.c | 85 +
net/ipv6/tcp_ipv6.c | 27 +-
3 files changed, 53
Pass the hashtable to the proc private data instead of copying
it into the per-file private data.
Signed-off-by: Christoph Hellwig
---
include/net/raw.h | 4
net/ipv4/raw.c| 36
net/ipv6/raw.c| 6 --
3 files changed, 16
Variants of proc_create{,_data} that directly take a struct seq_operations
argument and drastically reduces the boilerplate code in the callers.
All trivial callers converted over.
Signed-off-by: Christoph Hellwig
---
arch/ia64/hp/common/sba_iommu.c | 15 +-
Variants of proc_create{,_data} that directly take a seq_file show
callback and drastically reduces the boilerplate code in the callers.
All trivial callers converted over.
Signed-off-by: Christoph Hellwig
---
arch/arm/kernel/dma.c | 14 +---
Remove a couple indirections to make the code look like most other
protocols.
Signed-off-by: Christoph Hellwig
---
include/net/udp.h | 20 --
net/ipv4/udp.c | 99 +-
net/ipv4/udplite.c | 21 +++---
net/ipv6/udp.c | 30
Variant of proc_create_data that directly take a struct seq_operations
argument + a private state size and drastically reduces the boilerplate
code in the callers.
All trivial callers converted over.
Signed-off-by: Christoph Hellwig
---
fs/locks.c | 16
Common code for creating a regular file. Factor out of proc_create_data, to
be reused by other functions soon.
Signed-off-by: Christoph Hellwig
---
fs/proc/generic.c | 44 +---
fs/proc/internal.h | 2 ++
2 files changed, 27 insertions(+),
Return registered entry on success, return NULL on failure and free the
passed in entry. Also expose it in internal.h as we'll start using it
in proc_net.c soon.
Signed-off-by: Christoph Hellwig
---
fs/proc/generic.c | 44 ++--
Otherwise we will leak a reference to the network namespace.
Signed-off-by: Christoph Hellwig
---
net/can/bcm.c | 2 +-
net/can/proc.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/can/bcm.c b/net/can/bcm.c
index ac5e5e34fee3..8073fa14e143 100644
Could you, please, change the "return 0;"s inside wilc_mac_xmit() with
"return NETDEV_TX_OK" ?
Thank you,
Claudiu
On 24.04.2018 15:18, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation
On Wed, Apr 25, 2018 at 03:49:19PM +0200, Greg KH wrote:
> On Tue, Apr 24, 2018 at 03:49:55PM +0200, Sergio Paracuellos wrote:
> > The summary text for the GPL is not needed since the SPDX identifier
> > is a legally binding shorthand that can be used instead.
> >
> > Signed-off-by: Sergio
Make use of ether_addr_copy instead of memcpy for copying
ethernet address data in ks_wlan_set_wap function and avoid
an 'else' just changing if logic to check invalid values first.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 14
This commit removes a blank line which is included between
declarations and it has not sense at all.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
This commit refactors ks_wlan_translate_scan function with
the following changes:
- reorder local variables
- use ether_addr_copy to copy ethernet addresses
- change style in 'current_ev' variable assignments
- make use of some ternaries avoiding if-else code
- use preferred
Instead of manually memcpy ethernet addresses use ether_addr_copy
function for this purpose.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Change if logic to handle invalid case for operation_mode
at first avoiding an 'else' path.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
The if-else code in ks_wlan_get_power function is not needed
at all and can be achieved with a simple boolean assignation.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
To avoid a long line align values in static array
frequency_list array.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
Use ether_addr_copy to copy ethernet addresses instead
of a custom memcpy. This improves readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Use ether_addr_copy to copy ethernet addresses instead of
using custom memcpy for that.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
This commit change logic to simplify conditional paths in
ks_wlan_set_power_mgmt function. It handles invalid's first
and just finally assign a valid value.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 23 ---
1
Change if logic to handle invalid values first and just
assign at the end the valid one if it is the case.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
This commit refactors ks_wlan_set_cts_mode function to
handle invalid values first and then assign the good
one changing a bit logic to use a ternary operator.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 17 ++---
1 file
Change if condition to handle invalid value first and
avoid nonsense else's path improving readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
This patch series includes some new cleanups in code.
It also includes a remaining patch (PATCH 1/16) about
SPDX identifiers in files which wasn't be applied.
Sergio Paracuellos (16):
staging: ks7010: add SPDX identifiers to all files
staging: ks7010: refactor ks_wlan_set_beacon_lost
This commit changes logic to handle invalid values first
and just assign valid ones afterwards.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the all of the staging ks7010 files to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which
On Tue, Apr 24, 2018 at 03:18:21PM +0200, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
On Tue, Apr 24, 2018 at 03:49:55PM +0200, Sergio Paracuellos wrote:
> The summary text for the GPL is not needed since the SPDX identifier
> is a legally binding shorthand that can be used instead.
>
> Signed-off-by: Sergio Paracuellos
> ---
>
Now that the SPDX tag is in all gdm724x files, that identifies the
license in a specific and legally-defined manner. So the extra GPL text
wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel describe the GPL
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the all of the staging gdm724x files to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which
1 - 100 of 112 matches
Mail list logo