Re: [PATCH v6 00/15] staging: mt7621-pci: avoid custom pci config read and writes

On Tue, Jul 31, 2018 at 03:25:43PM +1000, NeilBrown wrote: > On Tue, Jul 31 2018, Sergio Paracuellos wrote: > > > On Tue, Jul 31, 2018 at 08:55:52AM +1000, NeilBrown wrote: > >> On Mon, Jul 30 2018, Sergio Paracuellos wrote: > >> > >> > This patch series include an attempt to avoid the use of

Re: [PATCH v6 00/15] staging: mt7621-pci: avoid custom pci config read and writes

On Tue, Jul 31 2018, Sergio Paracuellos wrote: > On Tue, Jul 31, 2018 at 08:55:52AM +1000, NeilBrown wrote: >> On Mon, Jul 30 2018, Sergio Paracuellos wrote: >> >> > This patch series include an attempt to avoid the use of custom >> > read and writes in driver code and use PCI subsystem common

Re: [PATCH v6 00/15] staging: mt7621-pci: avoid custom pci config read and writes

On Tue, Jul 31, 2018 at 08:55:52AM +1000, NeilBrown wrote: > On Mon, Jul 30 2018, Sergio Paracuellos wrote: > > > This patch series include an attempt to avoid the use of custom > > read and writes in driver code and use PCI subsystem common ones. > > > > In order to do this 'map_bus' callback is

Re: [PATCH v6 00/15] staging: mt7621-pci: avoid custom pci config read and writes

On Tue, Jul 31, 2018 at 08:55:52AM +1000, NeilBrown wrote: > On Mon, Jul 30 2018, Sergio Paracuellos wrote: > > > This patch series include an attempt to avoid the use of custom > > read and writes in driver code and use PCI subsystem common ones. > > > > In order to do this 'map_bus' callback is

[PATCH char-misc 1/1] Drivers: hv: vmbus: Make synic_initialized flag per-cpu

From: Michael Kelley The synic_initialized flag is part of the global hv_context structure. But the Hyper-V synthetic interrupt controller is fundamentally a per-cpu device, and other synic related fields are in hv_per_cpu_context. In a multi-CPU system, synic_initialized gets set multiple

Re: [PATCH v6 00/15] staging: mt7621-pci: avoid custom pci config read and writes

On Mon, Jul 30 2018, Sergio Paracuellos wrote: > This patch series include an attempt to avoid the use of custom > read and writes in driver code and use PCI subsystem common ones. > > In order to do this 'map_bus' callback is implemented and also > data structures for driver are included. The

Re: [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h

On Fri, Jul 27 2018, Nishad Kamdar wrote: > Replace explicit shifting with BIT macro in board.h. > Issue found by checkpatch. > > Signed-off-by: Nishad Kamdar Reviewed-by: NeilBrown Thanks, NeilBrown > --- > drivers/staging/mt7621-mmc/board.h | 8 > 1 file changed, 4 insertions(+),

[PATCH char-misc 1/1] Drivers: hv: vmbus: Remove use of slow_virt_to_phys()

From: Michael Kelley slow_virt_to_phys() is only implemented for arch/x86. Remove its use in arch independent Hyper-V drivers, and replace with test for vmalloc() address followed by appropriate v-to-p function. This follows the typical pattern of other drivers and avoids the need to implement

Re: [PATCH v5] Staging: octeon-usb: Using defined error codes and applying coding style.

Yes reseeding in a better way seems logical, i even got lost with the patch series. I will return with more consistent series. On Mon, 30 Jul 2018 at 11:51, Greg Kroah-Hartman wrote: > > On Mon, Jul 30, 2018 at 01:29:36AM +0300, Georgios Tsotsos wrote: > > Replaced -1 with defined error code

Re: [PATCH v4 net-next] hv_netvsc: Add per-cpu ethtool stats for netvsc

From: Yidong Ren Date: Mon, 30 Jul 2018 17:09:45 + > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters already exist in current code. Exposing > these counters

Re: [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style

On Mon, Jul 30, 2018 at 11:11:38AM +0200, Greg KH wrote: > On Sun, Jul 29, 2018 at 10:07:33PM +0100, John Whitmore wrote: > > Remove the typedef of the structure cmpk_txfb_t. This clears the > > checkpatch issue with defining new types. > > > > Additionally the type is renamed from cmpk_txfb_t to

Re: [PATCH 04/13] staging: gasket: core: allow root access based on user namespace

Hi Todd, On Sun, Jul 29, 2018 at 12:37 PM Todd Poynor wrote: > @@ -1064,7 +1067,8 @@ static int gasket_open(struct inode *inode, struct file > *filp) > char task_name[TASK_COMM_LEN]; > struct gasket_cdev_info *dev_info = > container_of(inode->i_cdev, struct

Re: [PATCH v4 net-next] hv_netvsc: Add per-cpu ethtool stats for netvsc

On Mon, 30 Jul 2018 17:09:45 + Yidong Ren wrote: > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters already exist in current code. Exposing > these counters will

Re: [PATCH 8/8] staging: rtl8188eu: use is_broadcast_ether_addr

On 07/29/18 22:05, Joe Perches wrote: On Sun, 2018-07-29 at 20:21 +0200, Michael Straube wrote: On 07/29/18 19:59, Joe Perches wrote: On Sun, 2018-07-29 at 19:42 +0200, Michael Straube wrote: On 07/29/18 19:21, Joe Perches wrote: On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote: Use

[PATCH v4 net-next] hv_netvsc: Add per-cpu ethtool stats for netvsc

From: Yidong Ren This patch implements following ethtool stats fields for netvsc: cpu_tx/rx_packets/bytes cpu_vf_tx/rx_packets/bytes Corresponding per-cpu counters already exist in current code. Exposing these counters will help troubleshooting performance issues. for_each_present_cpu() was

for your website photos

We are an image editing service provider having more than 10 years of industry experience. We use latest techniques for photo editing to meet international quality standards. We are committed to deliver reliable photo processing services. Production of 1000+ images within single working day

[PATCH v6 09/15] staging: mt7621-pci: review includes putting them in alphabethic order

There are some includes that are being used that are not really needed to correct driver compilation. Remove them and reorder the rest alphabetically. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 22 -- 1 file changed, 8 insertions(+), 14

[PATCH v6 08/15] staging: mt7621-pci: avoid register duplication per controller using pcie_[read|write]

Use pcie_[read|write] fucntions to read and write controller registers. Define those only by offset and pass controller offset + register offset relative to base address to functions. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 70

[PATCH v6 13/15] staging: mt7621-pci: rename RALINK_PCI_CONFIG_DATA_VIRTUAL_REG definition

RALINK_PCI_CONFIG_DATA_VIRTUAL_REG is a very long name. Make it a bit shorter renaming it to RALINK_PCI_CONFIG_DATA. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v6 14/15] staging: mt7621-pci: remove remaining pci_legacy dependant code

pcibios_* remaining code is not neccessary at all. We can use map_irq set to of_irq_parse_and_map_pci driver 'probe' function. Remove this code. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 33 + 1 file changed, 1 insertion(+),

[PATCH v6 11/15] staging: mt7621-pci: remove RALINK_PCI_BASE from remaining definitions

RALINK_PCI_BASE has no sense and this driver has base address readed and mapped from device tree. Remove remaining uses of it and change code to use pcie_read and pcie_write functions in places where this was being used. Signed-off-by: Sergio Paracuellos ---

[PATCH v6 12/15] staging: mt7621-pci: use BIT macro in preprocessor definitions

Some preprocessor definitions are using a custom implementation of BIT macro. Just use linux kernel BIT macro instead. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH v6 15/15] staging: mt7621-dts: add pcie controller port registers

The pcie node of the device tree only contains registers for the host-bridge and pcie port 0. Add the pcie port 1 and pcie port 2 also. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v6 10/15] staging: mt7621-pci: use pcie_[read|write] in RALINK_PCI_PCICFG_ADDR and RALINK_PCI_PCIMSK_ADDR

RALINK_PCI_PCICFG_ADDR and RALINK_PCI_PCIMSK_ADDR are defined to be directly referenced for read and write. Use pcie_read and pcie_write instead changing its definition to a simple relative offset to pcie base address. Signed-off-by: Sergio Paracuellos ---

[PATCH v6 07/15] staging: mt7621-pci: remove unused macros

There some macros that are not being used. Remove them. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c

[PATCH v6 06/15] staging: mt7621-pci: simplify write_config function

write_config function is always called with bus and func being 0. Avoid those params and just use 0 inside the function. Review parameter types changing for more proper ones. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 20 +--- 1 file changed,

[PATCH v6 04/15] staging: mt7621-pci: use pcie_[read|write] in [write|read]_config

Instead of custom macros use pcie_read and pcie_write functions. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 67 - 1 file changed, 32 insertions(+), 35 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c

[PATCH v6 00/15] staging: mt7621-pci: avoid custom pci config read and writes

This patch series include an attempt to avoid the use of custom read and writes in driver code and use PCI subsystem common ones. In order to do this 'map_bus' callback is implemented and also data structures for driver are included. The regs base address is being readed from device tree and the

[PATCH v6 03/15] staging: mt7621-pci: add pcie_write and pcie_read helpers

Introdice this functions to make easier to write/read to/from an offset relative to base address Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c

[PATCH v6 01/15] staging: mt7621-pci: use generic kernel pci subsystem read and write

map_bus callback is called before every .read/.write operation. Implement it and change custom read write operations for the pci subsystem generics. Make the probe function to don't use legacy stuff and request bus resources directly. Get pci register base and ranges from device tree. The driver

[PATCH v6 05/15] staging: mt7621-pci: simplify read_config function

read_config function is always called with bus and func being 0. Avoid those params and just use 0 inside the function. Return readed value instead pass a reference parameter. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 32 +++- 1

[PATCH v6 02/15] staging: mt7621-pci: remove dead code derived to not use custom reads and writes

Driver is using now pci subsystem generics reads and writes and requesting bus resources without using legacy code functions. Because of this there is a lot of dead code that can be removed. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 153

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

On Mon, Jul 30, 2018 at 12:09:14PM +0200, Michael Straube wrote: > On 07/30/18 11:27, Michael Straube wrote: > > On 07/30/18 11:02, Greg KH wrote: > > > On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: > > > > The function rtw_handle_tkip_mic_err() is never used, so remove it. > >

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

On Mon, Jul 30, 2018 at 03:40:24PM +0530, Ajay Singh wrote: > Hi Dan, > > On Mon, 30 Jul 2018 11:41:13 +0300 > Dan Carpenter wrote: > > > On Fri, Jul 20, 2018 at 04:35:24AM +0530, Ajay Singh wrote: > > > Hi Dan, > > > > > > On Thu, 19 Jul 2018 12:27:44 +0300 > > > Dan Carpenter wrote: > > >

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

Hi Dan, On Mon, 30 Jul 2018 11:41:13 +0300 Dan Carpenter wrote: > On Fri, Jul 20, 2018 at 04:35:24AM +0530, Ajay Singh wrote: > > Hi Dan, > > > > On Thu, 19 Jul 2018 12:27:44 +0300 > > Dan Carpenter wrote: > > > > > On Thu, Jul 19, 2018 at 04:15:01AM +0530, Ajay Singh wrote: > > > > diff

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

On 07/30/18 11:27, Michael Straube wrote: On 07/30/18 11:02, Greg KH wrote: On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: The function rtw_handle_tkip_mic_err() is never used, so remove it. Discovered by cppcheck. That's a bad tool then, as this is used, and the build

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 11:49 AM, Stefan Wahren wrote: > Am 30.07.2018 um 11:43 schrieb Carlos Maiolino: >> On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren >> wrote: >>> i think easiest the way would be to get a recent Raspbian Lite ( >>> https://www.raspberrypi.org/downloads/raspbian/ ), >>>

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

Am 30.07.2018 um 11:43 schrieb Carlos Maiolino: > On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren > wrote: >> i think easiest the way would be to get a recent Raspbian Lite ( >> https://www.raspberrypi.org/downloads/raspbian/ ), >> build the kernel with bcm2835_defconfig, modify config.txt to

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren wrote: > Hi Carlos, > > Am 30.07.2018 um 11:25 schrieb Carlos Maiolino: >> >> On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren >> wrote: >>> >>> Hi Carlos, >>> >>> >>> Am 30.07.2018 um 11:08 schrieb Carlos Maiolino: On Mon, Jul 30, 2018 at

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

Hi Carlos, Am 30.07.2018 um 11:25 schrieb Carlos Maiolino: On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren wrote: Hi Carlos, Am 30.07.2018 um 11:08 schrieb Carlos Maiolino: On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

On 07/30/18 11:02, Greg KH wrote: On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: The function rtw_handle_tkip_mic_err() is never used, so remove it. Discovered by cppcheck. That's a bad tool then, as this is used, and the build breaks when this patch is applied :( I've

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren wrote: > Hi Carlos, > > > Am 30.07.2018 um 11:08 schrieb Carlos Maiolino: >> >> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: >>> >>> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote: Fix several sparse warnings

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

Hi Carlos, Am 30.07.2018 um 11:08 schrieb Carlos Maiolino: On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote: Fix several sparse warnings regarding different address space assignments, like example below, by properly annotating

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 11:08:06AM +0200, Carlos Maiolino wrote: > On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: > > On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote: > >> Fix several sparse warnings regarding different address space > >> assignments, like example below, by

Re: [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style

On Sun, Jul 29, 2018 at 10:07:33PM +0100, John Whitmore wrote: > Remove the typedef of the structure cmpk_txfb_t. This clears the > checkpatch issue with defining new types. > > Additionally the type is renamed from cmpk_txfb_t to cmd_pkt_tx_feedback > removing the '_t' as the typedef has been

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: > On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote: >> Fix several sparse warnings regarding different address space >> assignments, like example below, by properly annotating pointers >> expected to carry user space addresses. >> >>

Re: [PATCH] Staging: fbtft: fbtft-sysfs: fixed a 80 char line coding style issue Staging: fbtft: flexfb: fixed a 80 char line coding style issue

On Sun, Jul 29, 2018 at 05:11:53PM +0400, Sepehrdad Sh wrote: > > On Sun, Jul 29, 2018, 12:03 Greg KH > wrote: > >On Sat, Jul 28, 2018 at 10:08:28PM +0400, sepehrdad@gmail.com > wrote: > > From: sepehrdad sh

Re: [PATCH] Staging: emxx_udc: fixed checkpatch warnings

On Sun, Jul 29, 2018 at 04:58:08PM +0400, sepehrdad@gmail.com wrote: > From: sepehrdad sh > > Fixed and cleaned up checkpatch coding style errors. > > Signed-off-by: Sepehrdad Sh > --- > drivers/staging/emxx_udc/emxx_udc.c | 309 +--- > 1 file changed, 146

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: > The function rtw_handle_tkip_mic_err() is never used, so remove it. > Discovered by cppcheck. That's a bad tool then, as this is used, and the build breaks when this patch is applied :( I've dropped it now. thanks, greg k-h

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote: > Fix several sparse warnings regarding different address space > assignments, like example below, by properly annotating pointers > expected to carry user space addresses. > > warning: incorrect type in argument 1 (different

Re: [PATCH v5] Staging: octeon-usb: Using defined error codes and applying coding style.

On Mon, Jul 30, 2018 at 01:29:36AM +0300, Georgios Tsotsos wrote: > Replaced -1 with defined error code EINVAL > > Signed-off-by: Georgios Tsotsos > --- > v2: Apply coding style to function cvmx_usb_poll_channel > v3: Break down function cvmx_usb_poll_channel > v4: Return defined error code and

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

On Fri, Jul 20, 2018 at 04:35:24AM +0530, Ajay Singh wrote: > Hi Dan, > > On Thu, 19 Jul 2018 12:27:44 +0300 > Dan Carpenter wrote: > > > On Thu, Jul 19, 2018 at 04:15:01AM +0530, Ajay Singh wrote: > > > diff --git a/drivers/staging/wilc1000/wilc_wlan.c > > >

Re: [PATCH v5 01/16] staging: mt7621-pci: use generic kernel pci subsystem read and write

On Mon, Jul 30, 2018 at 05:05:15PM +1000, NeilBrown wrote: > On Mon, Jul 30 2018, Sergio Paracuellos wrote: > > > On Mon, Jul 30, 2018 at 03:20:47PM +1000, NeilBrown wrote: > >> On Fri, Jul 27 2018, Sergio Paracuellos wrote: > >> > >> > map_bus callback is called before every .read/.write

Re: [PATCH v5 01/16] staging: mt7621-pci: use generic kernel pci subsystem read and write

On Mon, Jul 30 2018, Sergio Paracuellos wrote: > On Mon, Jul 30, 2018 at 03:20:47PM +1000, NeilBrown wrote: >> On Fri, Jul 27 2018, Sergio Paracuellos wrote: >> >> > map_bus callback is called before every .read/.write operation. >> > Implement it and change custom read write operations for the

Re: [PATCH 17/32] staging: gasket: annotate ioctl arg with __user

On Thu, Jul 19, 2018 at 07:44:53PM -0700, Todd Poynor wrote: > >> @@ -549,7 +549,7 @@ struct gasket_driver_desc { > >>* return -EINVAL. Should return an error status (either -EINVAL or > >>* the error result of the ioctl being handled). > >>*/ > >> - long

Re: [PATCH] staging: erofs: use the wrapped PTR_ERR_OR_ZERO instead of open code

On 2018/7/30 9:51, Gao Xiang wrote: > Just clean up and logic doesn't change. > > Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050766.html > Fixes: d72d1ce60174 ("staging: erofs: add namei functions") > Reported-by: kbuild test robot > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu

Re: [PATCH v5 01/16] staging: mt7621-pci: use generic kernel pci subsystem read and write

On Mon, Jul 30, 2018 at 03:20:47PM +1000, NeilBrown wrote: > On Fri, Jul 27 2018, Sergio Paracuellos wrote: > > > map_bus callback is called before every .read/.write operation. > > Implement it and change custom read write operations for the > > pci subsystem generics. Make the probe function to