[PATCH] staging: rtl8188eu: Fix spelling mistake

2018-08-20 Thread Bhaskar Singh
This patch fix spelling mistakes in TODO. Signed-off-by: Bhaskar Singh --- drivers/staging/rtl8188eu/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/TODO b/drivers/staging/rtl8188eu/TODO index 7581e25f231d..5faa0a9bba25 100644 ---

[PATCH v2] staging: rtl8188eu: Removed code valid for 5GHz

2018-08-20 Thread Bhaskar Singh
This patch removes support for channels > 14. That is from the TODO which says: -find and remove remaining code valid only for 5HGz. Most of obvious ones have been removed, but things like channel > 14 still exist. Signed-off-by: Bhaskar Singh --- Changes in v2: - Make

[PATCH v2] staging: rtl8188eu: Removed a function and coded inline

2018-08-20 Thread Bhaskar Singh
This patch removed function named rtw_malloc2d. I removed this function because this function is used exactly once and function call have some overhead also. Maybe this will improve code runtime slightly. Signed-off-by: Bhaskar Singh --- Changes in v2: - Incorporated comments from Dan

[RFC RFT PATCH v4 3/4] gpiolib: Pass array info to get/set array functions

2018-08-20 Thread Janusz Krzysztofik
In order to make use of array info obtained from gpiod_get_array() and speed up processing of arrays matching single GPIO chip layout, that information must be passed to get/set array functions. Extend the functions' API with that additional parameter and update all users. Pass NULL if a user

[RFC RFT PATCH v4 4/4] gpiolib: Implement fast processing path in get/set array

2018-08-20 Thread Janusz Krzysztofik
Certain GPIO descriptor arrays returned by gpio_get_array() may contain information on direct mapping of array members to pins of a single GPIO chip in hardware order. In such cases, bitmaps of values can be passed directly from/to the chip's .get/set_multiple() callbacks without wasting time on

[RFC RFT PATCH 0/4] gpiolib: speed up GPIO array processing

2018-08-20 Thread Janusz Krzysztofik
This series is a follow up of the former "mtd: rawnand: ams-delta: Use gpio-omap accessors for data I/O" which already contained some changes to gpiolib. Those previous attempts were commented by Borris Brezillon who suggested using GPIO API modified to accept bitmaps, and by Linus Walleij who

[RFC RFT PATCH v4 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-08-20 Thread Janusz Krzysztofik
Most users of get/set array functions iterate consecutive bits of data, usually a single integer, while or processing array of results obtained from or building an array of values to be passed to those functions. Save time wasted on those iterations by changing the functions' API to accept

[RFC RFT PATCH v4 2/4] gpiolib: Identify arrays matching GPIO hardware

2018-08-20 Thread Janusz Krzysztofik
Certain GPIO array lookup results may map directly to GPIO pins of a single GPIO chip in hardware order. If that condition is recognized and handled efficiently, significant performance gain of get/set array functions may be possible. While processing a request for an array of GPIO descriptors,

[PATCH] vmbus: don't return values for uninitalized channels

2018-08-20 Thread kys
From: Stephen Hemminger For unsupported device types, the vmbus channel ringbuffer is never initialized, and therefore reading the sysfs files will return garbage or cause a kernel OOPS. Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") Signed-off-by: Stephen Hemminger Signed-off-by:

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Joe Perches
On Sun, 2018-08-19 at 13:34 +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > > Fixed four debug macros and their usages. Replaced printk with > > dev_ without __func__ or __LINE__ or current->comm and > > current->pid. Further removed the do {}

[PATCH 2/2] staging: rtl8712u: Fix compiler warning about strncpy

2018-08-20 Thread Larry Finger
When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger ---

[PATCH 1/2] staging: rtl8192e: Fix compiler warning about strncpy

2018-08-20 Thread Larry Finger
When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- drivers/staging/rtl8192e/rtllib_softmac.c |

[PATCH 0/2] staging: Fix some warnings from strncpy()

2018-08-20 Thread Larry Finger
When the size argument in a call to strncpy() is the size of the destimation, gcc8 issues a warning. These patches fix the potential problem by replacing the strncpy() with strlcpy(). Signed-off-by: Larry Finger Larry Finger (2): staging: rtl8192e: Fix compiler warning about strncpy

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Nishad Kamdar
On Sun, Aug 19, 2018 at 01:34:01PM +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > > Fixed four debug macros and their usages. Replaced printk with > > dev_ without __func__ or __LINE__ or current->comm and > > current->pid. Further removed the

Re: [PATCH] staging: rtl8188eu: Removed a function and coded inline

2018-08-20 Thread Bhaskar Singh
On Mon, Aug 20, 2018 at 12:35:46PM +0300, Dan Carpenter wrote: > On Sun, Aug 19, 2018 at 12:36:40AM +0530, Bhaskar Singh wrote: > > This patch removed function named rtw_malloc2d. > > > > I removed this function because this function is used exactly once and > > function call have some overhead

Re: [PATCH] staging: rtl8188eu: Removed code valid for 5GHz

2018-08-20 Thread Dan Carpenter
On Mon, Aug 20, 2018 at 06:25:39PM +0530, Bhaskar Singh wrote: > On Mon, Aug 20, 2018 at 12:50:43PM +0300, Dan Carpenter wrote: > > On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote: > > > This patch removed code which are valid for IEEE 802.11a i.e. 5GHz. > > > > I would be

Re: [PATCH] staging: rtl8188eu: Removed code valid for 5GHz

2018-08-20 Thread Bhaskar Singh
On Mon, Aug 20, 2018 at 12:50:43PM +0300, Dan Carpenter wrote: > On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote: > > This patch removed code which are valid for IEEE 802.11a i.e. 5GHz. > > I would be uncomfortable accepting this kind of change without an Ack > from the maintainers.

Re: [PATCH] staging: rtl8188eu: Removed code valid for 5GHz

2018-08-20 Thread Dan Carpenter
On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote: > This patch removed code which are valid for IEEE 802.11a i.e. 5GHz. I would be uncomfortable accepting this kind of change without an Ack from the maintainers. The messes up the indenting so we can accept it anyway. regards, dan

Re: [PATCH] staging: rtl8188eu: Type cast function argument

2018-08-20 Thread Dan Carpenter
On Sat, Aug 18, 2018 at 07:54:09PM +0530, Bhaskar Singh wrote: > This patch might suppress some warrning. > Which warning? You should find out which program is generating the warning and delete it from your computer because that is a nonsense warning. regards, dan carpenter

Re: [PATCH] staging: rtl8188eu: Removed a function and coded inline

2018-08-20 Thread Dan Carpenter
On Sun, Aug 19, 2018 at 12:36:40AM +0530, Bhaskar Singh wrote: > This patch removed function named rtw_malloc2d. > > I removed this function because this function is used exactly once and > function call have some overhead also. > > Maybe this will improve code runtime slightly. > >

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Dan Carpenter
On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > #define N_MSG(evt, fmt, args...) > /* > -do {\ > -if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \ > -printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \ > -host->id, ##args ,

Re: [PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-20 Thread Stefan Agner
On 20.08.2018 10:09, Boris Brezillon wrote: > Hi Stefan, > > On Mon, 20 Aug 2018 09:57:47 +0200 > Stefan Agner wrote: > >> On 19.08.2018 13:26, Boris Brezillon wrote: >> > Hi Stefan, >> > >> > On Sat, 18 Aug 2018 10:30:13 +0200 >> > Stefan Agner wrote: >> > >> >> > diff --git

Re: [PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-20 Thread Boris Brezillon
Hi Stefan, On Mon, 20 Aug 2018 09:57:47 +0200 Stefan Agner wrote: > On 19.08.2018 13:26, Boris Brezillon wrote: > > Hi Stefan, > > > > On Sat, 18 Aug 2018 10:30:13 +0200 > > Stefan Agner wrote: > > > >> > diff --git a/drivers/mtd/nand/raw/tegra_nand.c > >> >

Re: [PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-20 Thread Stefan Agner
On 19.08.2018 13:26, Boris Brezillon wrote: > Hi Stefan, > > On Sat, 18 Aug 2018 10:30:13 +0200 > Stefan Agner wrote: > >> > diff --git a/drivers/mtd/nand/raw/tegra_nand.c >> > b/drivers/mtd/nand/raw/tegra_nand.c >> > index 5dcee20e2a8c..bcc3a2888c4f 100644 >> > ---