Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

2018-09-05 Thread Gao Xiang
Hi David, Al, On 2018/9/6 7:25, Stephen Rothwell wrote: > Hi all, > > On Wed, 29 Aug 2018 09:44:03 +1000 Stephen Rothwell > wrote: >> >> On Tue, 28 Aug 2018 22:13:02 +0800 Chao Yu wrote: >>> >>> On 2018/8/28 21:05, Greg Kroah-Hartman wrote: On Tue, Aug 28, 2018 at 04:56:43PM +0800,

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

2018-09-05 Thread Stephen Rothwell
Hi all, On Wed, 29 Aug 2018 09:44:03 +1000 Stephen Rothwell wrote: > > On Tue, 28 Aug 2018 22:13:02 +0800 Chao Yu wrote: > > > > On 2018/8/28 21:05, Greg Kroah-Hartman wrote: > > > On Tue, Aug 28, 2018 at 04:56:43PM +0800, Chao Yu wrote: > > >> > > >> On 2018/8/28 14:28, Gao Xiang wrote:

[PATCH v8 3/4] gpiolib: Pass array info to get/set array functions

2018-09-05 Thread Janusz Krzysztofik
In order to make use of array info obtained from gpiod_get_array() and speed up processing of arrays matching single GPIO chip layout, that information must be passed to get/set array functions. Extend the functions' API with that additional parameter and update all users. Pass NULL if a user

[PATCH v8 2/4] gpiolib: Identify arrays matching GPIO hardware

2018-09-05 Thread Janusz Krzysztofik
Certain GPIO array lookup results may map directly to GPIO pins of a single GPIO chip in hardware order. If that condition is recognized and handled efficiently, significant performance gain of get/set array functions may be possible. While processing a request for an array of GPIO descriptors,

[PATCH v8 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-09-05 Thread Janusz Krzysztofik
Most users of get/set array functions iterate consecutive bits of data, usually a single integer, while processing array of results obtained from, or building an array of values to be passed to those functions. Save time wasted on those iterations by changing the functions' API to accept bitmaps.

[PATCH v8 4/4] gpiolib: Implement fast processing path in get/set array

2018-09-05 Thread Janusz Krzysztofik
Certain GPIO descriptor arrays returned by gpio_get_array() may contain information on direct mapping of array members to pins of a single GPIO chip in hardware order. In such cases, bitmaps of values can be passed directly from/to the chip's .get/set_multiple() callbacks without wasting time on

[PATCH v8 0/4] gpiolib: speed up GPIO array processing

2018-09-05 Thread Janusz Krzysztofik
The goal is to boost performance of get/set array functions while processing GPIO arrays which represent pins of a signle chip in hardware order. If resulting performance is close to PIO, GPIO API can be used for data I/O without much loss of speed. Created and tested on a low end Amstrad

[PATCH v2 2/2] staging: rtl8188eu: remove unnecessary parentheses in rtw_led.c

2018-09-05 Thread Michael Straube
Remove unnecessary parentheses from conditionals. Also clears 'Alignment should match open parenthesis' checkpatch issue. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_led.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-05 Thread Michael Straube
Remove emtpy if statement from 'if - else if' by moving all conditions into a single if. Also clears a line over 80 characters checkpatch warning. Signed-off-by: Michael Straube --- v2: changed patch 1/2 that was wrong. drivers/staging/rtl8188eu/core/rtw_led.c | 6 +++--- 1 file changed, 3

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-05 Thread Paul Kocialkowski
Hi and thanks for the review! Le lundi 03 septembre 2018 à 11:11 +0200, Hans Verkuil a écrit : > On 08/28/2018 09:34 AM, Paul Kocialkowski wrote: > > +static int cedrus_request_validate(struct media_request *req) > > +{ > > + struct media_request_object *obj, *obj_safe; > > + struct

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-09-05 Thread Paul Kocialkowski
Hi, Le mardi 28 août 2018 à 22:08 -0300, Ezequiel Garcia a écrit : > On Tue, 2018-08-28 at 09:34 +0200, Paul Kocialkowski wrote: > > +static const struct v4l2_m2m_ops cedrus_m2m_ops = { > > + .device_run = cedrus_device_run, > > + .job_abort = cedrus_job_abort, > > +}; > > + > > I

Re: [linux-sunxi] [PATCH v8 3/8] dt-bindings: media: Document bindings for the Cedrus VPU driver

2018-09-05 Thread Paul Kocialkowski
Hi, Le mardi 28 août 2018 à 16:47 +0200, Corentin Labbe a écrit : > On Tue, Aug 28, 2018 at 09:34:19AM +0200, Paul Kocialkowski wrote: > > This adds a device-tree binding document that specifies the > > properties > > used by the Cedurs VPU driver, as well as examples. > > typo Cedurs=>Cedrus

Re: [PATCH v8 1/8] media: v4l: Add definitions for MPEG2 slice format and metadata

2018-09-05 Thread Paul Kocialkowski
Hi Hans, Le lundi 03 septembre 2018 à 10:32 +0200, Hans Verkuil a écrit : > This looks very nice. I have two more comments, but they can be added > using a follow-up patch (unless you need a v9 anyway): I suppose I'll send a v9 to keep things in order here. And thanks for the review! > On

Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-05 Thread Dan Carpenter
On Wed, Sep 05, 2018 at 01:44:43PM +0200, Michael Straube wrote: > On 9/5/18 10:13 AM, Dan Carpenter wrote: > > On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote: > > > > > > case LED_CTL_SITE_SURVEY: > > > - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && > > >

Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-05 Thread Michael Straube
On 9/5/18 10:13 AM, Dan Carpenter wrote: On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote: case LED_CTL_SITE_SURVEY: - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv, _FW_LINKED))) { - ; - }

Re: [PATCH] ANDROID: binder: Add BINDER_GET_NODE_INFO_FOR_REF ioctl.

2018-09-05 Thread Martijn Coenen
On Wed, Sep 5, 2018 at 11:09 AM, Dan Carpenter wrote: > What's the reserved for? On 64 bit systems there is a 4 byte struct > hole between weak_count and reserved. There's many more pieces of information that we hold for a node. While we don't have a use for most of that now, we may want some

Re: [PATCH] staging: most: video: fix registration of an empty comp core_component

2018-09-05 Thread Colin Ian King
On 05/09/18 11:06, Alexander Stein wrote: > On Wednesday, September 5, 2018, 11:46:05 AM CEST Colin King wrote: >> From: Colin Ian King >> >> Currently we have structrues comp (which is empty) and comp_info being >> used to register and deregister the component. This mismatch in naming >>

Re: [PATCH] staging: most: video: fix registration of an empty comp core_component

2018-09-05 Thread Alexander Stein
On Wednesday, September 5, 2018, 11:46:05 AM CEST Colin King wrote: > From: Colin Ian King > > Currently we have structrues comp (which is empty) and comp_info being > used to register and deregister the component. This mismatch in naming > occurred from a previous commit that renamed aim_info

[PATCH] staging: most: video: fix registration of an empty comp core_component

2018-09-05 Thread Colin King
From: Colin Ian King Currently we have structrues comp (which is empty) and comp_info being used to register and deregister the component. This mismatch in naming occurred from a previous commit that renamed aim_info to comp. Fix this to use consistent component naming in line with most/net,

Re: [PATCH] ANDROID: binder: Add BINDER_GET_NODE_INFO_FOR_REF ioctl.

2018-09-05 Thread Dan Carpenter
On Wed, Sep 05, 2018 at 09:33:46AM +0200, Martijn Coenen wrote: > diff --git a/include/uapi/linux/android/binder.h > b/include/uapi/linux/android/binder.h > index bfaec6903b8bc..a54a680ff2936 100644 > --- a/include/uapi/linux/android/binder.h > +++ b/include/uapi/linux/android/binder.h > @@

Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-05 Thread Dan Carpenter
On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote: > Remove empty if statement from 'if - else if' and replace the > else if with if. Remove the now unused variable pmlmepriv. > Also clears line over 80 characters and CamelCase checkpatch > issues. > > Signed-off-by: Michael Straube

[PATCH] ANDROID: binder: Add BINDER_GET_NODE_INFO_FOR_REF ioctl.

2018-09-05 Thread Martijn Coenen
This allows the context manager to retrieve information about nodes that it holds a reference to, such as the current number of references to those nodes. Such information can for example be used to determine whether the servicemanager is the only process holding a reference to a node. This

Re: yield() and cond_resched() do not yield to another thread

2018-09-05 Thread Stephen Hemminger
On Tue, 4 Sep 2018 21:16:07 +0800 fei phung wrote: > Hi everyone, > > I am working on https://github.com/promach/riffa/tree/full_duplex > > While I modifying the linux driver, I faced some issue using yield(). > > Why riffa_driver.c yield() function >

Re: yield() and cond_resched() do not yield to another thread

2018-09-05 Thread Stephen Hemminger
On Tue, 4 Sep 2018 21:16:07 +0800 fei phung wrote: > Hi everyone, > > I am working on https://github.com/promach/riffa/tree/full_duplex > > While I modifying the linux driver, I faced some issue using yield(). > > Why riffa_driver.c yield() function >

Re: [PATCH v7 3/4] gpiolib: Pass array info to get/set array functions

2018-09-05 Thread kbuild test robot
Hi Janusz, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.19-rc2 next-20180905] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v7 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-09-05 Thread kbuild test robot
Hi Janusz, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.19-rc2 next-20180905] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux