Re: [PATCH 00/12] net: Introduce ndo_get_port_parent_id()

2019-02-04 Thread Ido Schimmel
On Mon, Feb 04, 2019 at 03:36:21PM -0800, Florian Fainelli wrote: > Hi all, > > Based on discussion with Ido and feedback from Jakub there are clearly > two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: > > - PF/VF drivers which typically only implement return the port's paren

[PATCH 08/12] staging: wilc1000: avoid use of 'hif_deinit_lock' static variable

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Avoid use of static variable 'hif_deinit_lock' and move it as part of wilc struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 20 +--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 ++ 2 files changed, 11 insertions(+), 1

[PATCH 00/12] staging: wilc1000: changes to address mainline review comments

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh This series contains pending patches from #9 till #15 from previous series[1]. Also added 5 new patches to avoid the use of unnecessary static variables for few leftovers. [1]. https://patchwork.kernel.org/cover/10794463/ https://patchwork.kernel.org/patch/10794479/ Ajay S

[PATCH 03/12] staging: wilc1000: refactor code to use cookie information

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Make use of cookie information to pass to wpa_s and handle cookie value received in the cfg80211_ops callbacks. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 72 +++ drivers/staging/wilc1000/host_interface.h | 13

[PATCH 05/12] staging: wilc1000: avoid use of interface names for validation

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Avoid use of interface name i.e 'wlan0' & 'p2p0' to check the interface type in dev_state_ev_handler(). Now making use of netdev_ops and iface type to know interface. Reorder the functions to avoid the forward declaration after the above changes Signed-off-by: Ajay Singh --- d

[PATCH 04/12] staging: wilc1000: use random number for cookie instead of pointer

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Use random number to assign to cookie value. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_w

[PATCH 02/12] staging: wilc1000: refactor linux_wlan_init_test_config()

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Refactor linux_wlan_init_test_config() to use correct endianness for wid values and remove unnecessary code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 200 +--- drivers/staging/wilc1000/wilc_wlan_if.h | 1 - 2 files c

[PATCH 10/12] staging: wilc1000: move static variable 'wlan_channel' to 'wilc' struct

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Avoid use of static variable 'wlan_channel' by moving it inside the wilc structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 36 --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + 2 files changed, 20 inser

[PATCH 12/12] staging: wilc1000: define p2p related static variable as constants

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Add constant qualifer for 'p2p_vendor_spec' & 'p2p_oui' static variable because they are treated like constant values. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 06/12] staging: wilc1000: add check before performing operation on net_device

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Before calling an operation on net_device check if that interface is available. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers

[PATCH 11/12] staging: wilc1000: move 'curr_channel' static variable in 'wilc' struct

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Avoid the use of static variable and move it as part of wilc structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 22 -- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + 2 files changed, 13 insertions(+), 10

[PATCH 07/12] staging: wilc1000: remove unused struct 'add_sta_param'

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Remove 'add_sta_param' structure as its not used now. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h

[PATCH 09/12] staging: wilc1000: avoid use of static variable in linux_mon.c

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Define local variable for 'srcadd' & 'bssid' static variables and use ether_addr_copy() to copy value into them. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc

[PATCH 01/12] staging: wilc1000: remove use of 'terminated_handle' static variable

2019-02-04 Thread Ajay.Kathat
From: Ajay Singh Remove use of 'terminated_handle' variable and set the 'hif_drv' to NULL once it's free. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/host_in

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-04 Thread Stefan Roese
On 04.02.19 09:53, Mark Brown wrote: On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote: It is extremely common in the kernel for a file to start // SPDX-License-Identifier. and to have that immediately followed by a comment lile: /* * . * Yes, there

Re: [PATCH 09/12] netdevsim: Implement ndo_get_port_parent_id()

2019-02-04 Thread Jakub Kicinski
On Mon, 4 Feb 2019 15:36:30 -0800, Florian Fainelli wrote: > netdevsim only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a > great candidate to be converted to use the ndo_get_port_parent_id() NDO > instead of implementing switchdev_port_attr_get(). > > Signed-off-by: Florian Fainell

Re: [PATCH 07/12] nfp: Implement ndo_get_port_parent_id()

2019-02-04 Thread Jakub Kicinski
On Mon, 4 Feb 2019 15:36:28 -0800, Florian Fainelli wrote: > NFP only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a > great candidate to be converted to use the ndo_get_port_parent_id() NDO > instead of implementing switchdev_port_attr_get(). > > Signed-off-by: Florian Fainelli Ac

Re: [PATCH 01/15] staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable

2019-02-04 Thread Ajay.Kathat
Hi Kalle, On 2/4/2019 7:08 PM, Kalle Valo wrote: > writes: > >> From: Ajay Singh >> >> Avoid use of static variable for monitor net_device and move it inside >> wilc structure. >> >> Signed-off-by: Ajay Singh > > [...] > >> --- a/drivers/staging/wilc1000/linux_mon.c >> +++ b/drivers/staging/

Re: [PATCH 3/3] media: imx: Allow BT.709 encoding for IC routes

2019-02-04 Thread Steve Longerbeam
Sorry this patch isn't working, it's not possible to set BT.709 encoding, working on a fix for v2. Steve On 2/3/19 11:47 AM, Steve Longerbeam wrote: The IC now supports BT.709 Y'CbCr encoding, in addition to existing BT.601 encoding, so allow both, for pipelines that route through the IC. Re

[PATCH 09/12] netdevsim: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
netdevsim only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). Signed-off-by: Florian Fainelli --- drivers/net/netdevsim/netdev.c | 22 ++ 1

[PATCH 04/12] net/mlx5e: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
mlx5e only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). Signed-off-by: Florian Fainelli --- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 31 +++

[PATCH 08/12] rocker: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/roc

[PATCH 11/12] net: dsa: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
DSA implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 18

[PATCH 06/12] mscc: ocelot: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
Ocelot only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID as a valid switchdev attribute getter, convert it to use ndo_get_port_parent_id() and get rid of the switchdev_ops::switchdev_port_attr_get altogether. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mscc/ocelot.c | 33 --

[PATCH 12/12] net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID

2019-02-04 Thread Florian Fainelli
Now that we have a dedicated NDO for getting a port's parent ID, get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID and convert all callers to use the NDO exclusively. This is a preliminary change to getting rid of switchdev_ops eventually. Signed-off-by: Florian Fainelli --- include/net/switchdev.h

[PATCH 10/12] staging: fsl-dpaa2: ethsw: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
ethsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Signed-off-by: Florian Fainelli --- drivers/staging/fsl-dpaa2/ethsw

[PATCH 00/12] net: Introduce ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
Hi all, Based on discussion with Ido and feedback from Jakub there are clearly two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: - PF/VF drivers which typically only implement return the port's parent ID, yet have to implement switchdev_port_attr_get() just for that - Ether

[PATCH 07/12] nfp: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
NFP only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). Signed-off-by: Florian Fainelli --- .../ethernet/netronome/nfp/nfp_net_common.c | 4 +--- .../net/eth

[PATCH 01/12] net: Introduce ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
In preparation for getting rid of switchdev_ops, create a dedicated NDO operation for getting the port's parent identifier. There are essentially two classes of drivers that need to implement getting the port's parent ID which are VF/PF drivers with a built-in switch, and pure switchdev drivers suc

[PATCH 05/12] mlxsw: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Signed-off-by: Florian Fainelli --- .../net/ethernet/mellanox/mlxsw

[PATCH 02/12] bnxt: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
BNXT only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). The conversion is straight forward here since the PF and VF code use the same getter. Signed-off-by: Flor

[PATCH 03/12] liquidio: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
Liquidio only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). Signed-off-by: Florian Fainelli --- .../net/ethernet/cavium/liquidio/lio_main.c | 22

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-04 Thread NeilBrown
On Mon, Feb 04 2019, Mark Brown wrote: > On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote: > >> It is extremely common in the kernel for a file to start >>// SPDX-License-Identifier. > >> and to have that immediately followed by a comment lile: > >> /* >> * . >> *

[PATCH] Staging: rtl8723bs: remove some dead code

2019-02-04 Thread Dan Carpenter
"psecnetwork" is the address of &psecuritypriv->sec_bss. Since ->sec_bss isn't the first member of the struct that means that "psecnetwork" can't be NULL. We can just remove this dead code. Signed-off-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 1 file changed,

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-02-04 Thread Mani, Rajmohan
Hi Sakari, [snip] > > > > > fail_stop_pipeline: > > > > > @@ -543,6 +546,8 @@ static void ipu3_vb2_stop_streaming(struct > > > > vb2_queue *vq) > > > > > dev_err(&imgu->pci_dev->dev, > > > > > "failed to stop subdev streaming\n"); > > > > > > > > > > + mut

RE: [PATCH v4] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-02-04 Thread Michael Kelley
From: Kimberly Brown Sent: Sunday, February 3, 2019 11:13 PM > > Counter values for per-channel interrupts and ring buffer full > conditions are useful for investigating performance. > > Expose counters in sysfs for 2 types of guest to host interrupts: > 1) Interrupts caused by the channel's ou

Re: [PATCH 3/3] staging/android: simplify handle_vsoc_cond_wait

2019-02-04 Thread Joel Fernandes
I think you sent to wrong address of Alistair on these and other patches. Corrected address. On Fri, Feb 01, 2019 at 06:39:03AM +0100, Hugo Lefeuvre wrote: > simplify handle_vsoc_cond_wait (drivers/staging/android/vsoc.c) using newly > added wait_event_freezable_hrtimeout helper and remove useles

Re: [PATCH 1/6] staging: rtl8192e: rename structure members to avoid camel case - style

2019-02-04 Thread Greg KH
On Mon, Feb 04, 2019 at 04:25:43AM -0800, Himadri Pandya wrote: > struct rt_dot11d_info { > - bool bEnabled; > + bool b_enabled; Please think about _what_ you are renaming. Does your new name make any sense? Why was the "b" there in the first place? Why keep it? These are not to be ju

[PATCH][V2] staging: rtl8192u: remove redundant nul check on pointer dev

2019-02-04 Thread Colin King
From: Colin Ian King There is a null check on pointer dev which implies it may be null, however dev can never be null as it is set in rtl8192_usb_probe via the call to usb_set_intfdata. Detected by CoverityScan, CID#143078 ("Dereference after null check") Fixes: 8fc8598e61f6 ("Staging: Added Re

Re: [PATCH] staging: rtl8192u: fix a null pointer dereference on a null dev pointer

2019-02-04 Thread Colin Ian King
On 03/02/2019 11:31, Dan Carpenter wrote: > On Sat, Feb 02, 2019 at 10:56:27PM +, Colin King wrote: >> From: Colin Ian King >> >> There is an earlier null check on pointer dev which implies it may be null, >> however the assignment of pointer pref and the call to free_ieee82011 on >> a null de

Re: [PATCH 01/15] staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable

2019-02-04 Thread Kalle Valo
writes: > From: Ajay Singh > > Avoid use of static variable for monitor net_device and move it inside > wilc structure. > > Signed-off-by: Ajay Singh [...] > --- a/drivers/staging/wilc1000/linux_mon.c > +++ b/drivers/staging/wilc1000/linux_mon.c > @@ -18,8 +18,6 @@ struct wilc_wfi_radiotap_cb

[PATCH 4/6] staging: rtl8192e: rename function parameters to avoid camelcase - style

2019-02-04 Thread Himadri Pandya
Fix checkpatch warning: Avoid CamelCase by renaming following parameters of function dot11d_update_country_ie pTaddr -> p_taddr CoutryIeLen -> coutry_ie_len pCoutryIe -> p_coutry_ie Signed-off-by: Himadri Pandya --- drivers/staging/rtl8192e/dot11d.c | 14 +++--- d

[PATCH 5/6] staging: rtl8192e: rename local variables to avoid camelcase - style

2019-02-04 Thread Himadri Pandya
Fix checkpatch warning: Avoid CameCase by renaming following local variables of function dot11d_update_country_ie NumTriples -> num_triples MaxChnlNum -> max_chnl_num pTriple -> p_triple Signed-off-by: Himadri Pandya --- drivers/staging/rtl8192e/dot11d.c | 30

[PATCH 2/6] staging: rtl8192e: rename functions to avoid camelcase -style

2019-02-04 Thread Himadri Pandya
Fix checkpatch warning: Avoid CamelCase by renaming following functions cpMacAddr -> cp_mac_addr Dot11d_Channelmap -> dot11d_channel_map Dot11d_Reset -> dot11d_reset Dot11d_UpdateCountryIe -> dot11d_update_country_ie DOT11D_ScanComplete -> dot11d_scan_complet

[PATCH 6/6] staging: rtl8192e: rename structure members to avoid camelcase - style

2019-02-04 Thread Himadri Pandya
Fix checkpatch warning: Avoid CamelCase by renaming following structure members of struct rtllib_device pDot11dInfo -> p_dot11d_info bGlobalDomain -> b_global_domain IbssStartChnl -> ibss_start_chnl Signed-off-by: Himadri Pandya --- drivers/staging/rtl8192e/dot11d.c

[PATCH 3/6] staging: rtl8192e: rename macro arguments to avoid camelcase - style

2019-02-04 Thread Himadri Pandya
Fix checkpatch warning: Avoid CamelCase by renaming following macro arguments __pIeeeDev -> __p_ieee_dev __pTa -> __p_ta Signed-off-by: Himadri Pandya --- drivers/staging/rtl8192e/dot11d.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) dif

[PATCH 1/6] staging: rtl8192e: rename structure members to avoid camel case - style

2019-02-04 Thread Himadri Pandya
Fix checkpacth warning: Avoid CamelCase by renaming following structure members of struct chnl_txpow_triple FirstChnl -> first_chnl NumChnls -> num_chnls MaxTxPwrInDbm -> max_tx_pwr_in_dbm and members for struct rt_dot11d_info bEnabled -> b_enabled CountryIe

Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

2019-02-04 Thread Ajay.Kathat
Hi Greg, On 2/4/2019 5:09 PM, Greg KH wrote: > On Mon, Feb 04, 2019 at 12:47:23PM +0300, Dan Carpenter wrote: >> On Mon, Feb 04, 2019 at 09:42:36AM +, ajay.kat...@microchip.com wrote: >>> >>> >>> On 2/4/2019 1:43 PM, Dan Carpenter wrote: On Sat, Feb 02, 2019 at 07:17:13PM +, ajay.kat.

Hello Dear

2019-02-04 Thread Mrs Mimi Aminu
Hello Dear Am a dying woman here in the hospital, i was diagnose as a cancer patient 2 years ago. I am from (Zarqa) Jordan, a business woman dealing with Gold Exportation. I have a charitable and unfufilment project that am about to handover to you, hope to hear from you Regard Mrs Mimi Ami

[PATCH v12 06/13] ARM: dts: imx7s: add mipi phy power domain

2019-02-04 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arc

[PATCH v12 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2019-02-04 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1186 2 files changed, 1187 insertions(+) create mode

[PATCH v12 10/13] media: imx7.rst: add documentation for i.MX7 media driver

2019-02-04 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers/inde

[PATCH v12 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node

2019-02-04 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva --- arch/arm/bo

[PATCH v12 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2019-02-04 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v12 12/13] media: video-mux: add bayer formats

2019-02-04 Thread Rui Miguel Silva
Add non vendor bayer formats to the allowed format array. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel Acked-by: Sakari Ailus --- drivers/media/platform/video-mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/media/platform/video-mux.c b/dr

[PATCH v12 11/13] media: staging/imx: add i.MX7 entries to TODO file

2019-02-04 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324 10

[PATCH v12 13/13] media: MAINTAINERS: add entry for Freescale i.MX7 media driver

2019-02-04 Thread Rui Miguel Silva
Add maintainer entry for the imx7 media csi, mipi csis driver, dt-bindings and documentation. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 51029a425dbe..ad267b3dd18b 100644

[PATCH v12 04/13] media: staging/imx7: add imx7 CSI subdev driver

2019-02-04 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7-media-csi.c | 1365 +++

[PATCH v12 02/13] media: staging/imx: rearrange group id to take in account IPU

2019-02-04 Thread Rui Miguel Silva
Some imx system do not have IPU, so prepare the imx media drivers to support this kind of devices. Rename the group ids to include an _IPU_ prefix, add a new group id to support systems with only a CSI without IPU, and also rename the create internal links to make it clear that only systems with IP

[PATCH v12 01/13] media: staging/imx: refactor imx media device probe

2019-02-04 Thread Rui Miguel Silva
Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile| 1 + .../

[PATCH v12 03/13] media: dt-bindings: add bindings for i.MX7 media driver

2019-02-04 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- .../devicetree/bindings/media/imx7-csi.txt| 45 ++ .../bindings/media/imx7-mipi-csi2.txt

[PATCH v12 00/13] media: staging/imx7: add i.MX7 media driver

2019-02-04 Thread Rui Miguel Silva
Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case. T

[PATCH v12 07/13] ARM: dts: imx7s: add multiplexer controls

2019-02-04 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file

Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

2019-02-04 Thread Greg KH
On Mon, Feb 04, 2019 at 12:47:23PM +0300, Dan Carpenter wrote: > On Mon, Feb 04, 2019 at 09:42:36AM +, ajay.kat...@microchip.com wrote: > > > > > > On 2/4/2019 1:43 PM, Dan Carpenter wrote: > > > On Sat, Feb 02, 2019 at 07:17:13PM +, ajay.kat...@microchip.com wrote: > > >> From: Ajay Sing

Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

2019-02-04 Thread Dan Carpenter
On Mon, Feb 04, 2019 at 09:42:36AM +, ajay.kat...@microchip.com wrote: > > > On 2/4/2019 1:43 PM, Dan Carpenter wrote: > > On Sat, Feb 02, 2019 at 07:17:13PM +, ajay.kat...@microchip.com wrote: > >> From: Ajay Singh > >> > >> The value of 'vif_num'(interface count) starts with 0, so modi

Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

2019-02-04 Thread Ajay.Kathat
On 2/4/2019 1:43 PM, Dan Carpenter wrote: > On Sat, Feb 02, 2019 at 07:17:13PM +, ajay.kat...@microchip.com wrote: >> From: Ajay Singh >> >> The value of 'vif_num'(interface count) starts with 0, so modified the >> loop conditions to execute for all interface. >> >> Signed-off-by: Ajay Sing

Re: [PATCH][next] media: staging: intel-ipu3: fix unsigned comparison with < 0

2019-02-04 Thread Sakari Ailus
On Sat, Feb 02, 2019 at 10:12:41PM +, Colin Ian King wrote: > ping? I seem to have applied this to a wrong branch, it'll now be part of my next pull request to Mauro. Thanks! > > On 22/12/2018 11:49, Colin King wrote: > > From: Colin Ian King > > > > The comparison css->pipes[pipe].bindex

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-04 Thread Mark Brown
On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote: > It is extremely common in the kernel for a file to start >// SPDX-License-Identifier. > and to have that immediately followed by a comment lile: > /* > * . > * Yes, there was a lot of automated conversion AFAIC

Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

2019-02-04 Thread Dan Carpenter
On Sat, Feb 02, 2019 at 07:17:13PM +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > The value of 'vif_num'(interface count) starts with 0, so modified the > loop conditions to execute for all interface. > > Signed-off-by: Ajay Singh The right thing to do is to change ->vif_num =