Re: [Patch v4] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

On Thu, May 23, 2019 at 11:40:09PM +0530, Hariprasad Kelam wrote: > Function "rtw_sta_flush" always returns 0 value. So change > return type of rtw_sta_flush from int to void. Odd line wrapping :( Also your subject line is missing a trailing '"' character :( v5? thanks, greg k-h _

Re: [PATCH] staging: fieldbus: anybuss: Remove variables

On Fri, May 24, 2019 at 11:33:28AM +0530, Nishka Dasgupta wrote: > The local variable cd, used in multiple functions, is immediately passed > to another function call, whose result is returned. As that is the only > use of cd, it can be replaced with its variable. > Issue found with Coccinelle. >

Re: [PATCH 1/2] staging: gdm724x: Remove initialisation

On Fri, May 24, 2019 at 11:30:25AM +0530, Nishka Dasgupta wrote: > The initial value of return variable ret, -1, is never used and hence > can be removed. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/gdm724x/gdm_usb.c | 2 +- > 1 file changed, 1 inser

Re: [PATCH 2/2] staging: gdm724x: Remove variable

On Fri, May 24, 2019 at 11:30:26AM +0530, Nishka Dasgupta wrote: > The return variable is used only twice (in two different branches), and > both times it is assigned the same constant value. These can therefore > be merged into the same assignment, placed at the point that both > these branches (a

Re: [PATCH] staging: ks7010: Remove initialisation

On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote: > As the initial value of the return variable result is never used, it can > be removed. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/ks7010/ks7010_sdio.c | 2 +- > 1 file changed, 1 ins

Re: [PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'

On Fri, May 24, 2019 at 03:02:48AM +, Geordan Neukum wrote: > On Fri, May 24, 2019 at 2:38 AM Geordan Neukum wrote: > > + depends on MFD_CORE > > In order for this to work in menuconfig, this either needs to be a > select or I need to > add a prompt to MFD_CORE. I don't have strong feel

Re: [PATCH] staging/gasket: Fix string split

On Thu, May 23, 2019 at 05:46:39PM +0200, Tianzheng Li wrote: > This patch removes unnecessary quoted string splits. > > Reported-by: Jie Zhang > Signed-off-by: Tianzheng Li > --- > drivers/staging/gasket/gasket_core.c | 6 ++ > drivers/staging/gasket/gasket_ioctl.c | 3 +-- >

Re: [PATCH] staging: iio: adis16240: add of_match_table entry

On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote: > > This patch adds of_match_table entry in device driver in order to > enable spi fallback probing. > > Signed-off-by: Rodrigo Ribeiro > Reviewed-by: Marcelo Schmitt > --- > drivers/staging/iio/accel/adis16240.c | 1 + > 1 file changed, 1

[PATCH] staging: fieldbus: anybuss: Remove variables

The local variable cd, used in multiple functions, is immediately passed to another function call, whose result is returned. As that is the only use of cd, it can be replaced with its variable. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/fieldbus/anybuss/host.

[PATCH 2/2] staging: gdm724x: Remove variable

The return variable is used only twice (in two different branches), and both times it is assigned the same constant value. These can therefore be merged into the same assignment, placed at the point that both these branches (and no other) go to. The return variable itself can be removed. Issue foun

[PATCH 1/2] staging: gdm724x: Remove initialisation

The initial value of return variable ret, -1, is never used and hence can be removed. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/gdm724x/gdm_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers

[PATCH] staging: ks7010: Remove initialisation

As the initial value of the return variable result is never used, it can be removed. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/dr

Re: [PATCH] staging: mt7621-pci: pci-mt7621: Remove unneeded variable err

Hi Hariprasad, On Thu, May 23, 2019 at 8:35 PM Hariprasad Kelam wrote: > > devm_request_pci_bus_resources function will return -EBUSY/-ENOMEM > in fail case and returns 0 on success. > > So no need to store return value in err variable. > > Signed-off-by: Hariprasad Kelam > --- > drivers/stagi

[PATCH] staging: ks7010: Remove initialisation

The initial value of return variable ret is never used, so it can be removed. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/stagi

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Greg, On Fri, May 24, 2019 at 2:35 AM Greg Ungerer wrote: > > Hi Sergio, > > On 23/5/19 3:26 pm, Sergio Paracuellos wrote: > > On Thu, May 23, 2019 at 4:11 AM Greg Ungerer wrote: > >> On 22/5/19 4:27 pm, Sergio Paracuellos wrote: > >> [snip] > >>> There are some big changes between 4.20 and 5

[PATCH] staging: iio: adis16240: add of_match_table entry

This patch adds of_match_table entry in device driver in order to enable spi fallback probing. Signed-off-by: Rodrigo Ribeiro Reviewed-by: Marcelo Schmitt --- drivers/staging/iio/accel/adis16240.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/accel/adis16240.c b/drive

Re: [PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'

On Fri, May 24, 2019 at 2:38 AM Geordan Neukum wrote: > + depends on MFD_CORE In order for this to work in menuconfig, this either needs to be a select or I need to add a prompt to MFD_CORE. I don't have strong feelings either way, but all other Kconfig options which are related to the MFD_

[PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'

The kpc2000 core makes calls against functions conditionally exported upon selection of the kconfig symbol MFD_CORE. Therefore, the kpc2000 core depends upon the mfd_core, and that dependency must be tracked in Kconfig to avoid potential build issues. Signed-off-by: Geordan Neukum --- v2 changes

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Sergio, On 23/5/19 3:26 pm, Sergio Paracuellos wrote: On Thu, May 23, 2019 at 4:11 AM Greg Ungerer wrote: On 22/5/19 4:27 pm, Sergio Paracuellos wrote: [snip] There are some big changes between 4.20 and 5.x. One is the use of PERST_N instead of using gpio. This PERT_N stuff is used now on

Re: [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem

On Thu, 2019-05-23 at 16:23 -0400, Sven Van Asbroeck wrote: > On Thu, May 23, 2019 at 4:00 PM Joe Perches wrote: > > trivia: anybuss looks like a misspelling. > > It might be better as anybus-s. > This came up as well during the review process. When we insert a separator, > the include files start

[PATCH v2 2/2] MAINTAINERS: Add entry for anybuss drivers

Add myself as the maintainer of the anybuss bus driver, and its client drivers. Signed-off-by: Sven Van Asbroeck --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 50e164041e94..2b9223be10b6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1491

[PATCH v2 1/2] MAINTAINERS: Add entry for fieldbus subsystem

Add myself as the maintainer of the fieldbus subsystem. Signed-off-by: Sven Van Asbroeck --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5cfbea4ce575..50e164041e94 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14905,6 +14905,12 @@ L:

Re: [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem

On Thu, May 23, 2019 at 4:00 PM Joe Perches wrote: > patch 2/2 specifically covers the anybuss directory, > but the Documentation directory has no matching pattern. Thank you for spotting that, I will re-spin the set. > > trivia: anybuss looks like a misspelling. > It might be better as anybus-s

Re: [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem

On Thu, 2019-05-23 at 15:53 -0400, Sven Van Asbroeck wrote: > Add myself as the maintainer of the fieldbus subsystem. [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -14905,6 +14905,11 @@ L: linux-er...@lists.ozlabs.org > S: Maintained > F: drivers/staging/erofs/ > > +STAGING - FIELDB

[PATCH 2/2] MAINTAINERS: Add entry for anybuss drivers

Add myself as the maintainer of the anybuss bus driver, and its client drivers. Signed-off-by: Sven Van Asbroeck --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1cac53bced08..68d49623186f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1491

[PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem

Add myself as the maintainer of the fieldbus subsystem. Signed-off-by: Sven Van Asbroeck --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5cfbea4ce575..1cac53bced08 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14905,6 +14905,11 @@ L:

[PATCH] staging: mt7621-pci: pci-mt7621: Remove unneeded variable err

devm_request_pci_bus_resources function will return -EBUSY/-ENOMEM in fail case and returns 0 on success. So no need to store return value in err variable. Signed-off-by: Hariprasad Kelam --- drivers/staging/mt7621-pci/pci-mt7621.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) di

[Patch v4] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

Function "rtw_sta_flush" always returns 0 value. So change return type of rtw_sta_flush from int to void. Same thing applies for rtw_hostapd_sta_flush Signed-off-by: Hariprasad Kelam -- Changes v2 - change return type of rtw_sta_flush Changes v3 - fix indentaion issue Chang

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

On Thu, May 23, 2019 at 09:02:11AM -0400, Sven Van Asbroeck wrote: > On Thu, May 23, 2019 at 5:09 AM Dan Carpenter > wrote: > > > > Sven, you should add yourself to the MAINTAINERS file. > > Greg, what do you think? Yes! ___ devel mailing list de...@l

[Patch v3] staging: rtl8723bs: core: rtw_mlme_ext: fix warning Unneeded variable: "ret"

This patch fixes below warnings reported by coccicheck drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1888:14-17: Unneeded variable: "ret". Return "_FAIL" on line 1920 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:466:5-8: Unneeded variable: "res". Return "_SUCCESS" on line 494 Signed-off-by: Hari

Re: [PATCH] staging: most: usb: Remove variable frame_size

On Thu, May 23, 2019 at 06:53:34PM +0530, Nishka Dasgupta wrote: > Remove variable frame_size as its multiple usages are all independent of > each other and so can be returned separately. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/most/usb/usb.c | 1

[PATCH] staging/gasket: Fix string split

This patch removes unnecessary quoted string splits. Reported-by: Jie Zhang Signed-off-by: Tianzheng Li --- drivers/staging/gasket/gasket_core.c | 6 ++ drivers/staging/gasket/gasket_ioctl.c | 3 +-- drivers/staging/gasket/gasket_page_table.c | 14 ++ 3 files change

Re: [PATCH] staging/gasket: Fix string split

On Thu, May 23, 2019 at 05:11:56PM +0200, 李天正 wrote: > Hello， > we are doing a project in the university and we cooperated to make this > patch. Some warnings are found by Mr.Zhang. Use the Reported-by to show who found the bug or Co-developed-by: if you both wrote code. regards, dan carpenter _

Printing logo on products

Hi, I am following up on my previous attempt to contact you. We wanted to check to see if you need any LOGO promotional products for your business? Our company manufactures USB Flash Drives that are custom printed with your logo. They make the perfect marketing tool for your business or organiza

[PATCH] staging: most: usb: Remove variable frame_size

Remove variable frame_size as its multiple usages are all independent of each other and so can be returned separately. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/most/usb/usb.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --gi

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

On Thu, May 23, 2019 at 5:09 AM Dan Carpenter wrote: > > Sven, you should add yourself to the MAINTAINERS file. Greg, what do you think? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverd

[PATCH v2] staging: pi433: Remove unnecessary variable

The variable retval is assigned constant values twice, and can therefore be replaced by its values. Signed-off-by: Nishka Dasgupta --- Changes in v2: - Add Wei Yongjun to the recipients list - Fix From and Signed-off-by fields drivers/staging/pi433/pi433_if.c | 5 ++--- 1 file changed, 2 insert

[PATCH v2 9/9] staging: kpc2000: remove unnecessary oom message

Fixes checkpatch.pl warning "Possible unnecessary 'out of memory' message". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc20

[PATCH v2 8/9] staging: kpc2000: remove unnecessary include in cell_probe.c

Fixes checkpatch.pl warning "Use #include instead of ". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c index 682d61da5

[PATCH v2 2/9] staging: kpc2000: use __func__ in debug messages

Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using '', this function's name, in a string". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/staging/

[PATCH v2 0/9] Fix more coding style issues in staging/kpc2000

Hi, These patches fixes a few more minor coding style issues found in staging/kpc2000/cell_probe.c. There are only two more types of checkpatch.pl warnings left in this file with these patches applied: "line over 80 characters" and "Macro argument reuse". Changed in v2: don't bother fixing the __

[PATCH v2 6/9] staging: kpc2000: use kzalloc(sizeof(var)...) in cell_probe.c

Fixes checkpatch.pl warning "Prefer kzalloc(sizeof(*kudev)...) over kzalloc(sizeof(struct kpc_uio_device)...)" Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_

[PATCH v2 5/9] staging: kpc2000: remove extra blank lines in cell_probe.c

Fixes checkpatch.pl warnings "Please don't use multiple blank lines". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.

[PATCH v2 7/9] staging: kpc2000: remove unnecessary braces in cell_probe.c

Fixes checkpatch.pl warnings "braces {} are not necessary for single statement blocks". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/

[PATCH v2 4/9] staging: kpc2000: fix alignment issues in cell_probe.c

Fixes checkpatch.pl warnings "Alignment should match open parenthesis" and "Lines should not end with a '('". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 34 +--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers/staging

[PATCH v2 1/9] staging: kpc2000: add blank line after declarations

Fixes checkpatch.pl warning "Missing a blank line after declarations". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_prob

[PATCH v2 3/9] staging: kpc2000: add missing asterisk in comment

Fixes checkpatch.pl error "code indent should use tabs where possible". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2

Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages

On Thu, May 23, 2019 at 02:09:37PM +0200, Simon Sandström wrote: > On Thu, May 23, 2019 at 01:55:53PM +0200, Greg KH wrote: > > On Thu, May 23, 2019 at 01:36:07PM +0200, Simon Sandström wrote: > > > Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using > > > '', this function's nam

[PATCH] staging: pi433: Remove unnecessary return variable

From: Nishka Dasgupta The variable retval is initialised to 0 and assigned a constant value later. Both of these can be returned separately, hence retval can be removed. Signed-off-by: Nishka Dasgupta --- drivers/staging/pi433/pi433_if.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(

Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages

On Thu, May 23, 2019 at 01:55:53PM +0200, Greg KH wrote: > On Thu, May 23, 2019 at 01:36:07PM +0200, Simon Sandström wrote: > > Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using > > '', this function's name, in a string". > > > > Signed-off-by: Simon Sandström > > --- > > dr

Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages

On Thu, May 23, 2019 at 01:36:07PM +0200, Simon Sandström wrote: > Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using > '', this function's name, in a string". > > Signed-off-by: Simon Sandström > --- > drivers/staging/kpc2000/kpc2000/cell_probe.c | 22 +--- >

[PATCH 4/8] staging: kpc2000: fix alignment issues in cell_probe.c

Fixes checkpatch.pl warnings "Alignment should match open parenthesis" and "Lines should not end with a '('". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 34 +--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers/staging

[PATCH 6/8] staging: kpc2000: use kzalloc(sizeof(var)...) in cell_probe.c

Fixes checkpatch.pl warning "Prefer kzalloc(sizeof(*kudev)...) over kzalloc(sizeof(struct kpc_uio_device)...)" Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_

[PATCH 0/8] Fix more coding style issues in staging/kpc2000

Hi, These patches fixes a few more minor coding style issues found in staging/kpc2000/cell_probe.c. There are only two more types of checkpatch.pl warnings left in this file with these patches applied: "line over 80 characters" and "Macro argument reuse". - Simon Simon Sandström (8): staging:

[PATCH 5/8] staging: kpc2000: remove extra blank lines in cell_probe.c

Fixes checkpatch.pl warnings "Please don't use multiple blank lines". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.

[PATCH 8/8] staging: kpc2000: remove unnecessary include in cell_probe.c

Fixes checkpatch.pl warning "Use #include instead of ". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c index b1ce1e715

[PATCH 1/8] staging: kpc2000: add blank line after declarations

Fixes checkpatch.pl warning "Missing a blank line after declarations". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_prob

[PATCH 2/8] staging: kpc2000: use __func__ in debug messages

Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using '', this function's name, in a string". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 22 +--- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH 7/8] staging: kpc2000: remove unnecessary braces in cell_probe.c

Fixes checkpatch.pl warnings "braces {} are not necessary for single statement blocks". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/

[PATCH 3/8] staging: kpc2000: add missing asterisk in comment

Fixes checkpatch.pl error "code indent should use tabs where possible". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

On Thu, May 23, 2019 at 09:27:02AM +0100, Jeremy Sowden wrote: > On 2019-05-23, at 13:51:18 +0530, Nishka Dasgupta wrote: > > On 23/05/19 12:52 PM, Greg KH wrote: > > > On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > > > Also, you forgot to cc: Sven on this patch, please always u

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

On 23/05/19 1:57 PM, Jeremy Sowden wrote: On 2019-05-23, at 13:51:18 +0530, Nishka Dasgupta wrote: On 23/05/19 12:52 PM, Greg KH wrote: On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, the only operation pe

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

On Thu, May 23, 2019 at 01:51:18PM +0530, Nishka Dasgupta wrote: > > > On 23/05/19 12:52 PM, Greg KH wrote: > > On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > > > In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, > > > the only operation performed before ret

Re: [PATCH] staging: fieldbus: anybuss: Remove variable

On Thu, May 23, 2019 at 01:52:29PM +0530, Nishka Dasgupta wrote: > > > On 23/05/19 12:52 PM, Greg KH wrote: > > On Thu, May 23, 2019 at 12:35:26PM +0530, Nishka Dasgupta wrote: > > > Variable client, assigned to priv->client, is used only once in a > > > function argument; hence, it can be remove

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

On 2019-05-23, at 13:51:18 +0530, Nishka Dasgupta wrote: > On 23/05/19 12:52 PM, Greg KH wrote: > > On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > > > In the functions export_reset_0 and export_reset_1 in > > > arcx-anybus.c, the only operation performed before return is > > > p

Re: [PATCH] staging: fieldbus: anybuss: Remove variable

On 23/05/19 12:52 PM, Greg KH wrote: On Thu, May 23, 2019 at 12:35:26PM +0530, Nishka Dasgupta wrote: Variable client, assigned to priv->client, is used only once in a function argument; hence, it can be removed and the function argument replaced with priv->client directly. Issue found with C

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

On 23/05/19 12:52 PM, Greg KH wrote: On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, the only operation performed before return is passing the variable cd (which takes the value of a function call on one of

Re: [PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c

On Thu, May 23, 2019 at 09:27:59AM +0200, Greg KH wrote: > On Thu, May 23, 2019 at 09:26:25AM +0200, Greg KH wrote: > > > > This chunk does not match what you said this commit did :( > > > > Please fix up and resend. > > Actually, wait, rebase and resend after I apply your other patches. > I'll

Re: [PATCH] staging: pi433: cleanup to adhere with linux coding style

On Wed, May 22, 2019 at 06:06:22PM -0700, Shobhit Kukreti wrote: > The linux coding style emphasizes on a limit of 80 characters > per line. Cleaned up several over 80 character warnings in following files: > > pi433_if.c > pi433_if.h > rf69.c > > Signed-off-by: Shobhit Kukreti > --- > drivers/

Re: [PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c

On Thu, May 23, 2019 at 09:26:25AM +0200, Greg KH wrote: > On Wed, May 22, 2019 at 10:58:44PM +0200, Simon Sandström wrote: > > Use tabs instead of spaces for indentation. > > > > Signed-off-by: Simon Sandström > > --- > > drivers/staging/kpc2000/kpc2000/cell_probe.c | 574 +-- >

Re: [PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c

On Wed, May 22, 2019 at 10:58:44PM +0200, Simon Sandström wrote: > Use tabs instead of spaces for indentation. > > Signed-off-by: Simon Sandström > --- > drivers/staging/kpc2000/kpc2000/cell_probe.c | 574 +-- > 1 file changed, 287 insertions(+), 287 deletions(-) > > diff --git

Re: [PATCH v3] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

On Wed, May 22, 2019 at 10:41:37PM +0530, Hariprasad Kelam wrote: > Function "rtw_sta_flush" always returns 0 value. > So change return type of rtw_sta_flush from int to void. > > Same thing applies for rtw_hostapd_sta_flush > > Signed-off-by: Hariprasad Kelam > -- > Changes v2 - >c

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, > the only operation performed before return is passing the variable cd > (which takes the value of a function call on one of the parameters) as > argument to anot

Re: [PATCH] staging: fieldbus: anybuss: Remove variable

On Thu, May 23, 2019 at 12:35:26PM +0530, Nishka Dasgupta wrote: > Variable client, assigned to priv->client, is used only once in a > function argument; hence, it can be removed and the function argument > replaced with priv->client directly. > Issue found with Coccinelle. > > Signed-off-by: Nish

Re: [PATCH v2] staging: rtl8723bs: core: rtw_mlme_ext: fix warning Unneeded variable: "ret"

On Wed, May 22, 2019 at 11:25:01PM +0530, Hariprasad Kelam wrote: > This patch fixes below warnings reported by coccicheck > > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1888:14-17: Unneeded > variable: "ret". Return "_FAIL" on line 1920 > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:466:5-8:

Re: [PATCH] staging: unisys: visornic: Replace GFP_ATOMIC with GFP_KERNEL

On Wed, May 22, 2019 at 10:35:30PM +0530, Hariprasad Kelam wrote: > As per below information > > GFP_KERNEL FLAG > > This is a normal allocation and might block. This is the flag to use in > process context code when it is safe to sleep. > > GFP_ATOMIC FLAG > > The allocation is high-priority

[PATCH] staging: fieldbus: anybuss: Remove variable

Variable client, assigned to priv->client, is used only once in a function argument; hence, it can be removed and the function argument replaced with priv->client directly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/fieldbus/anybuss/hms-profinet.c | 4 +--- 1