[PATCH] staging: qlge: qlge_dbg.c: Remove trailing semicolon from macro

2020-04-23 Thread Rylan Dmello
Fix checkpatch.pl warning: macros should not use a trailing semicolon Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 1795533cbd3a..216b13d8

[PATCH 2/2] staging: vt6656: Remove preamble_type setting from vnt_tx_packet.

2020-04-23 Thread Malcolm Priestley
preamble_type is set in vnt_bss_info_changed no need to set it here. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index 7e15534e52ff..f56a2b02fe36 100644 --

[PATCH 1/2] staging: vt6656: Remove set short time in vnt_init_registers.

2020-04-23 Thread Malcolm Priestley
The short time is set in vnt_bss_info_changed no need to set it here. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/main_usb.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 4bca0b99cf45

[PATCH] staging: vt6656: rxtx: remove duration_id and void returns.

2020-04-23 Thread Malcolm Priestley
duration_id is not used by driver anymore so remove the returns and set all functions in path to void. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 78 --- 1 file changed, 36 insertions(+), 42 deletions(-) diff --git a/drivers/staging/vt66

[PATCH v2] staging:r8188eu: avoid skb_clone for amsdu to msdu conversion

2020-04-23 Thread Ivan Safonov
skb clones use same data buffer, so tail of one skb is corrupted by beginning of next skb. Signed-off-by: Ivan Safonov --- Changes in v2: - long line in the commit message is divided into two parts. drivers/staging/rtl8188eu/core/rtw_recv.c | 19 ++- 1 file changed, 6 insertion

[PATCH] Staging: rtl8188eu: core: rtw_pwrctrl: fixed a coding style issue

2020-04-23 Thread carlosteniswarrior
From: Carlos Guerrero Álvarez Fixed a checkpatch.pl warning: the constant should be in the right side of the comparison. Signed-off-by: Carlos Guerrero Álvarez --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r

[PATCH v2] staging: vt6656: Add formula to the vnt_rf_addpower function

2020-04-23 Thread Oscar Carter
Use a formula to calculate the return value of the vnt_rf_addpower function instead of the "if" statement with literal values for every case. Signed-off-by: Oscar Carter --- Changelog v1 -> v2 - Change the type of "base" variable from s32 to int as Dan Carpenter suggested. - Remove the "--" pos

[PATCH v3 1/2] staging: vt6656: Check the return value of vnt_control_out_* calls

2020-04-23 Thread Oscar Carter
Check the return value of vnt_control_out_* function calls. When necessary modify the function prototype to be able to return the new checked error code. It's safe to modify all the function prototypes without fix the call because the only change is the return value from void to int. If before the

[PATCH v3 2/2] staging: vt6656: Remove functions' documentation

2020-04-23 Thread Oscar Carter
Remove the functions' documentation as the names of the functions are clear enought. Also, the actual documentation it's not correct in all cases. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/card.c | 79 -- drivers/staging/vt6656/mac.c | 52 -

[PATCH v3 0/2] staging: vt6656: Check the return value of vnt_control_out_* calls

2020-04-23 Thread Oscar Carter
This patch series checks the return value of vnt_control_out_* function calls. The first patch checks the return value and when necessary modify the function prototype to be able to return the new checked error code. The second patch removes the documentation of functions that their prototype has

HELLO

2020-04-23 Thread Ken
Hello Please can you assist me for a shipment/sales of Raw Gold Bar in your Country. SPECIFICATION.Karat: 22 +,Purity: 96.6%,Raw Gold Bar,Origin:Ghana Price: $35,000 per 1kg Regards. Lucas Duru ___ devel mailing list de...@linuxdriverproject.org http://d

Re: [PATCH v2 1/2] staging: vt6656: Check the return value of vnt_control_out_* calls

2020-04-23 Thread Oscar Carter
On Thu, Apr 23, 2020 at 01:40:32PM +0200, Greg Kroah-Hartman wrote: > On Sun, Apr 19, 2020 at 12:48:20PM +0200, Oscar Carter wrote: > > Check the return value of vnt_control_out_* function calls. When > > necessary modify the function prototype to be able to return the new > > checked error code. >

Re: [PATCH v2 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging

2020-04-23 Thread Johan Jonker
Hi Helen, > clocks: > items: > - description: ISP clock > - description: ISP AXI clock clock > - description: ISP AXI clock wrapper clock > - description: ISP AHB clock clock Too many clocks here ^ Too many spaces here ^ > - descr

Re: [PATCH] staging:r8188eu: avoid skb_clone for amsdu to msdu conversion

2020-04-23 Thread Ivan Safonov
On 4/23/20 2:29 PM, Greg Kroah-Hartman wrote: On Sat, Apr 18, 2020 at 11:41:12AM +0300, Ivan Safonov wrote: skb clones use same data buffer, so tail of one skb is corrupted by beginning of next skb. Please properly wrap your changelog text at the correct column (72). Also, your subject: line

Re: [PATCH v2 7/9] media: MAINTAINERS: rkisp1: add path to dt-bindings

2020-04-23 Thread Johan Jonker
Hi Helen, On 4/3/20 6:15 PM, Helen Koike wrote: > The Rockchip ISP bindings was moved out of staging. > Update MAINTAINERS file with the new path. > > Suggested-by: Johan Jonker > Signed-off-by: Helen Koike > --- > > V2: > - This is a new patch in the series > --- > MAINTAINERS | 1 + > 1 fil

Re: [PATCH v2 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging

2020-04-23 Thread Johan Jonker
Hi Helen, make ARCH=arm dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml SCHEMA Documentation/devicetree/bindings/processed-schema-examples.yaml SCHEMA Documentation/devicetree/bindings/processed-schema.yaml CHKDT Documentation/devicetree/bindin

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-23 Thread Nicolas Boichat
Hi, Just commenting on the mode_fixup function that was added in v7. On Tue, Feb 25, 2020 at 2:15 PM Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > The ANX7625 can support both USB T

Re: [PATCH v2 1/2] staging: vt6656: Check the return value of vnt_control_out_* calls

2020-04-23 Thread Greg Kroah-Hartman
On Sun, Apr 19, 2020 at 12:48:20PM +0200, Oscar Carter wrote: > Check the return value of vnt_control_out_* function calls. When > necessary modify the function prototype to be able to return the new > checked error code. > > It's safe to modify all the function prototypes without fix the call > b

Re: [PATCH] staging:r8188eu: avoid skb_clone for amsdu to msdu conversion

2020-04-23 Thread Greg Kroah-Hartman
On Sat, Apr 18, 2020 at 11:41:12AM +0300, Ivan Safonov wrote: > skb clones use same data buffer, so tail of one skb is corrupted by beginning > of next skb. Please properly wrap your changelog text at the correct column (72). Also, your subject: line does not have the correct driver name :( >

Re: [PATCH] staging: wfx: cleanup long lines in data_tx.c

2020-04-23 Thread Dan Carpenter
On Thu, Apr 23, 2020 at 09:29:28AM +, Jerome Pouiller wrote: > > req->data_flags.fc_offset = offset; > > if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) > > req->data_flags.after_dtim = 1; > > @@ -517,7 +523,8 @@ void wfx_tx_confirm_cb(struct wfx_vif *wvif

Re: [PATCH] staging: wfx: cleanup long lines in data_tx.c

2020-04-23 Thread Jerome Pouiller
Hello Suraj, Thank you for your contribution. On Wednesday 22 April 2020 17:39:00 CEST Suraj Upadhyay wrote: > > Break lines with length over 80 characters to conform > to the linux coding style. Issue found by checkpatch. > > Signed-off-by: Suraj Upadhyay > --- > drivers/staging/wfx/data_tx.