[PATCH] qlge.h: Adding the missing blank line after declarations

2020-06-26 Thread B K Karthik
Signed-off-by: B K Karthik --- drivers/staging/qlge/qlge.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index fc8c5ca8935d..0b971a633001 100644 --- a/drivers/staging/qlge/qlge.h +++ b/drivers/staging/qlge/qlge.h @@ -2224,6 +2224,7 @

Re: [PATCH 4/4] staging: rtl8188eu: Replace function name with __func__

2020-06-26 Thread Greg KH
On Fri, Jun 26, 2020 at 11:36:42AM -0400, Brooke Basile wrote: > Fix the following checkpatch warning: > WARNING: Prefer using '"%s...", __func__' to using 'rtw_get_bcn_info', > this function's name, in a string > > Signed-off-by: Brooke Basile > --- > drivers/staging/rtl8188eu/core/rtw_i

Re: [PATCH] fbtft-bus.c: Removing that prohibited space before ')'

2020-06-26 Thread Joe Perches
On Sat, 2020-06-27 at 00:51 -0400, B K Karthik wrote: > fbtft-bus.c: > > fixing ERROR: space prohibited before that close parenthesis ')' by removing > that space and ',' in line 65 and 67. [] > diff --git a/drivers/staging/fbtft/fbtft-bus.c > b/drivers/staging/fbtft/fbtft-bus.c > index 63c65dd6

Re: [PATCH] fbtft-bus.c: Removing that prohibited space before ')'

2020-06-26 Thread Greg Kroah-Hartman
On Sat, Jun 27, 2020 at 12:51:50AM -0400, B K Karthik wrote: > fbtft-bus.c: > > fixing ERROR: space prohibited before that close parenthesis ')' by removing > that space and ',' in line 65 and 67. > > Signed-off-by: B K Karthik > --- > drivers/staging/fbtft/fbtft-bus.c | 4 ++-- > 1 file chang

Re: [PATCH] fbtft-bus.c:

2020-06-26 Thread Greg Kroah-Hartman
On Sat, Jun 27, 2020 at 12:50:04AM -0400, B K Karthik wrote: > fbtft-bus.c: > > fixing ERROR: space prohibited before that close parenthesis ')' by removing > that space and ',' in line 65 and 67. > > Signed-off-by: B K Karthik > --- > drivers/staging/fbtft/fbtft-bus.c | 4 ++-- > 1 file chang

Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

2020-06-26 Thread Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I incl

[PATCH] fbtft-bus.c: Removing that prohibited space before ')'

2020-06-26 Thread B K Karthik
fbtft-bus.c: fixing ERROR: space prohibited before that close parenthesis ')' by removing that space and ',' in line 65 and 67. Signed-off-by: B K Karthik --- drivers/staging/fbtft/fbtft-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-b

[PATCH] fbtft-bus.c:

2020-06-26 Thread B K Karthik
fbtft-bus.c: fixing ERROR: space prohibited before that close parenthesis ')' by removing that space and ',' in line 65 and 67. Signed-off-by: B K Karthik --- drivers/staging/fbtft/fbtft-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-b

Re: [PATCH 2/2] staging: qlge: fix else after return or break

2020-06-26 Thread Joe Perches
On Sat, 2020-06-27 at 07:57 +0800, Coiby Xu wrote: > On Thu, Jun 25, 2020 at 03:13:14PM -0700, Joe Perches wrote: > > On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote: > > > Remove unnecessary elses after return or break. > > > > unrelated trivia: [] > > looks like all of these could use netdev_e

Re: [PATCH 2/2] staging: qlge: fix else after return or break

2020-06-26 Thread Coiby Xu
On Thu, Jun 25, 2020 at 03:13:14PM -0700, Joe Perches wrote: On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote: Remove unnecessary elses after return or break. unrelated trivia: diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c [] @@ -1391,12 +1391,11 @@ static

Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

2020-06-26 Thread B K KARTHIK PES2201800185STUDENT ECE DeptPESU EC Campus
Oh, I'm sorry but wouldn't it be helpful if we had a file that lists all drivers that are scheduled for removal? I personally feel that it would help out all kernel newbies. I've been trying to complete task10 in the eudyptula challenge, and the patches either get thrown out by greg's patch-bot, or

Re: [PATCH 0/7] Some atomisp fixes and improvements

2020-06-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Jun 2020 17:52:16 +0200 Mauro Carvalho Chehab escreveu: > Em Fri, 26 Jun 2020 18:00:21 +0300 > Andy Shevchenko escreveu: > > > On Fri, Jun 26, 2020 at 04:04:52PM +0200, Mauro Carvalho Chehab wrote: > > > Those patches are meant to improve device detection by the atomisp driver, > > >

Re: [PATCH 0/7] Some atomisp fixes and improvements

2020-06-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Jun 2020 18:00:21 +0300 Andy Shevchenko escreveu: > On Fri, Jun 26, 2020 at 04:04:52PM +0200, Mauro Carvalho Chehab wrote: > > Those patches are meant to improve device detection by the atomisp driver, > > relying on ACPI bios when possible. > > > > It also adds a basis for using ACPI

[PATCH 4/4] staging: rtl8188eu: Replace function name with __func__

2020-06-26 Thread Brooke Basile
Fix the following checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'rtw_get_bcn_info', this function's name, in a string Signed-off-by: Brooke Basile --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

[PATCH 3/4] staging: rtl8188eu: Fix indentation

2020-06-26 Thread Brooke Basile
Fix the following checkpatch warning: WARNING: suspect code indent for conditional statements (16, 32) Signed-off-by: Brooke Basile --- .../staging/rtl8188eu/core/rtw_ieee80211.c| 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/

[PATCH 1/4] staging: rtl8188eu: Fix comment formatting

2020-06-26 Thread Brooke Basile
Fix the following checkpatch warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Brooke Basile --- .../staging/rtl8188eu/core/rtw_ieee80211.c| 26 --- 1 file changed, 17 insert

[PATCH 2/4] staging: rtl8188eu: Fix strings split across lines

2020-06-26 Thread Brooke Basile
Fix the following checkpatch warning: WARNING: quoted string split across lines Signed-off-by: Brooke Basile --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c

Re: [PATCH 0/7] Some atomisp fixes and improvements

2020-06-26 Thread Andy Shevchenko
On Fri, Jun 26, 2020 at 04:04:52PM +0200, Mauro Carvalho Chehab wrote: > Those patches are meant to improve device detection by the atomisp driver, > relying on ACPI bios when possible. > > It also adds a basis for using ACPI PM, but only if the DSDT tables have > a description about how to turn o

Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

2020-06-26 Thread Greg Kroah-Hartman
On Fri, Jun 26, 2020 at 04:36:52PM +0200, Hans Verkuil wrote: > On 26/06/2020 16:32, B K Karthik wrote: > > fixing ERROR: space prohibited before that ',' (ctx:WxW) > > > > Signed-off-by: B K Karthik > > usbvision is another driver that is scheduled for removal by the end of the > year, > so I

Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

2020-06-26 Thread Hans Verkuil
On 26/06/2020 16:32, B K Karthik wrote: > fixing ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: B K Karthik usbvision is another driver that is scheduled for removal by the end of the year, so I won't apply this patch. > --- > drivers/staging/media/usbvision/usbvision-i2

[PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

2020-06-26 Thread B K Karthik
fixing ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: B K Karthik --- drivers/staging/media/usbvision/usbvision-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/usbvision/usbvision-i2c.c b/drivers/staging/media/usbvision/usbvision

[PATCH 2/7] media: atomisp: Prepare sensor support for ACPI PM

2020-06-26 Thread Mauro Carvalho Chehab
Add support code for this driver to use ACPI power management. Yet, at least with known devices, this won't work without further changes. The rationale is that the ACPI handling code checks for the _PR? tables in order to know what is required to switch the device from power state D0 (_PR0) up to

[PATCH 3/7] media: atomisp: properly parse CLK PMIC on newer devices

2020-06-26 Thread Mauro Carvalho Chehab
Newer devices don't place the PMIC CLK line inside an EFI var. Instead, those are found at the _PR0 table. Add a parser for it, using info stored via the DSDT table. Signed-off-by: Mauro Carvalho Chehab --- .../media/atomisp/pci/atomisp_gmin_platform.c | 66 ++- 1 file changed,

[PATCH 0/7] Some atomisp fixes and improvements

2020-06-26 Thread Mauro Carvalho Chehab
Those patches are meant to improve device detection by the atomisp driver, relying on ACPI bios when possible. It also adds a basis for using ACPI PM, but only if the DSDT tables have a description about how to turn on the resources needed by the cameras. At least on the device I'm using for test

[PATCH 5/7] media: atomisp: print info if gpio0 and gpio2 were detected

2020-06-26 Thread Mauro Carvalho Chehab
If the ACPI DSDT tables provide _CRS for the camera, the GPIO core code should be able to handle them automatically. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/media/at

[PATCH 4/7] media: atomisp: fix call to g_frame_interval

2020-06-26 Thread Mauro Carvalho Chehab
The media core has now a check if fi->pad is bigger than zero or bigger than sd->entity.num_pads, if the media controller is defined. This causes a call to g_frame_interval to return -EINVAL. Fix it by first cleaning up the struct. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media

[PATCH 7/7] media: atomisp: place all gpio parsing together

2020-06-26 Thread Mauro Carvalho Chehab
Instead of parsing GPIO for two exceptions inside the logic which would be trying to use the GPIO, move the init code to the routine which adds a new gmin device. Move the notes to it too, as this helps to identify where those two GPIO settings are used, explaining why they're defaulting to -1 whe

[PATCH 6/7] media: atomisp: split add from find subdev

2020-06-26 Thread Mauro Carvalho Chehab
There's only one place where a subdev can be added: when the sensor driver registers it. Trying to do it elsewhere will cause problems, as the detection code needs to access the I2C bus in order to probe some things. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atom

[PATCH 1/7] media: atomisp: reorganize the code under gmin_subdev_add()

2020-06-26 Thread Mauro Carvalho Chehab
The gmin_subdev_add() currently doesn't use ACPI device power management. In order to prepare for adding support for it, let's shift some things, placing the PM-related stuff at the end of the probing logic. Let's also store the current gs on a temporary var, in order to simplify the source code.

Re: [PATCH v7 00/17] wilc1000: move out of staging

2020-06-26 Thread Greg KH
On Fri, Jun 26, 2020 at 08:34:48AM +0300, Kalle Valo wrote: > Greg KH writes: > > > On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote: > >> Greg KH writes: > >> > >> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote: > >> >> writes: > >> >> > >> >> > From: Ajay Singh > >>

Re: [PATCH v2 4/4] media: staging: tegra-vde: Power-cycle hardware on probe

2020-06-26 Thread Dmitry Osipenko
26.06.2020 10:48, Thierry Reding пишет: > On Wed, Jun 24, 2020 at 06:08:47PM +0300, Dmitry Osipenko wrote: >> VDE partition is left turned ON after bootloader on most devices, hence >> let's ensure that it's turned OFF in order to lower power leakage while >> hardware is idling by turning it ON and

Re: [PATCH v2 0/4] Tegra Video Decoder driver power management corrections

2020-06-26 Thread Dmitry Osipenko
26.06.2020 09:58, Hans Verkuil пишет: > On 26/06/2020 02:17, Dmitry Osipenko wrote: >> 24.06.2020 18:23, Dmitry Osipenko пишет: >>> 24.06.2020 18:16, Hans Verkuil пишет: On 24/06/2020 17:08, Dmitry Osipenko wrote: > Hello, > > This small series addresses a Runtime PM issue that was

Re: [PATCH 2/2] staging: qlge: fix else after return or break

2020-06-26 Thread Coiby Xu
On Thu, Jun 25, 2020 at 03:13:14PM -0700, Joe Perches wrote: On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote: Remove unnecessary elses after return or break. unrelated trivia: diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c [] @@ -1391,12 +1391,11 @@ static

Re: [PATCH 2/2] staging: qlge: fix else after return or break

2020-06-26 Thread Coiby Xu
On Fri, Jun 26, 2020 at 11:34:36AM +0300, Dan Carpenter wrote: On Fri, Jun 26, 2020 at 05:57:55AM +0800, Coiby Xu wrote: @@ -1404,11 +1403,10 @@ static void ql_dump_cam_entries(struct ql_adapter *qdev) pr_err("%s: Failed read of mac index register\n",

Re: [PATCH] wilc1000: move wilc driver out of staging

2020-06-26 Thread Ajay.Kathat
On 26/06/20 11:21 am, Kalle Valo wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > writes: > >> From: Ajay Singh >> >> WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The >> WILC1000 connects to Microchip AVR/SMART MCUs, S

Project Financing / Loan. 11

2020-06-26 Thread Mr. Mark Johnson
Hello, I am the investment officer of an investment company who are ready to fund projects in the form of debt finance. The company grant loan to both corporate and private entities at a low interest rate of 3% ROI per annual. The terms are very flexible and interesting. Kindly revert back i

Re: [PATCH 2/2] staging: qlge: fix else after return or break

2020-06-26 Thread Dan Carpenter
On Fri, Jun 26, 2020 at 05:57:55AM +0800, Coiby Xu wrote: > @@ -1404,11 +1403,10 @@ static void ql_dump_cam_entries(struct ql_adapter > *qdev) > pr_err("%s: Failed read of mac index register\n", > __func__); > return;

Re: [PATCH v2 4/4] media: staging: tegra-vde: Power-cycle hardware on probe

2020-06-26 Thread Thierry Reding
On Wed, Jun 24, 2020 at 06:08:47PM +0300, Dmitry Osipenko wrote: > VDE partition is left turned ON after bootloader on most devices, hence > let's ensure that it's turned OFF in order to lower power leakage while > hardware is idling by turning it ON and OFF during of the driver's probe. > > Signe

Re: [PATCH v2 2/4] media: staging: tegra-vde: Runtime PM is always available on Tegra

2020-06-26 Thread Thierry Reding
On Wed, Jun 24, 2020 at 06:08:45PM +0300, Dmitry Osipenko wrote: > Runtime PM is always available on Tegra nowadays since commit 40b2bb1b132a > ("ARM: tegra: enforce PM requirement"), hence the case of unavailable RPM > doesn't need to be handled. > > Signed-off-by: Dmitry Osipenko > --- > drive

Re: [PATCH v2 3/4] media: staging: tegra-vde: Turn ON power domain on shutdown

2020-06-26 Thread Thierry Reding
On Wed, Jun 24, 2020 at 06:08:46PM +0300, Dmitry Osipenko wrote: > On some devices bootloader isn't ready to a clamped VDE power, and thus, > machine hangs on a warm reboot (CPU reset). The VDE power partition is > turned ON by default on a cold boot, hence VDE driver should keep power > partition

Re: [PATCH 1/1] staging: media: soc_camera: Adding parentheses to macro defination at line 241, Clearing alignment issues at lines 410 and 1270, fixing return values at EPOLLERR

2020-06-26 Thread Hans Verkuil
The soc_camera driver obsolete and depends on BROKEN. And in fact, I'm working on removing it. So I'll drop this patch for those reasons. Regards, Hans On 25/06/2020 17:35, B K Karthik wrote: > staging: media: soc_camera: soc_camera.c: Clearing coding-style problem > "Macros with complex