Re: [PATCH] staging: rtl8192e: Fixed the space and indentation coding styles

2020-07-19 Thread Greg KH
On Fri, Jul 17, 2020 at 08:34:51PM +0530, Darshan D V wrote: > rtllib_crypt_ccmp.c: Fixed the error - space required before the > open parenthesis '(' on line #281. > > rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for > conditional statements on line #338 > > Signed-off-by: Darsha

Re: [PATCH] staging: wlan-ng: properly check endpoint types

2020-07-19 Thread Greg KH
On Sat, Jul 18, 2020 at 08:58:36AM -0700, Rustam Kovhaev wrote: > As syzkaller detected, wlan-ng driver submits bulk urb without checking > that the endpoint type is actually bulk, add usb_urb_ep_type_check() > > Reported-and-tested-by: syzbot+c2a1fa67c02faa0de...@syzkaller.appspotmail.com > Link:

Re: [PATCH] Staging: rtl8188eu: core: Fix coding style issue

2020-07-19 Thread Greg KH
On Sat, Jul 18, 2020 at 04:01:25PM +0530, Anoop1507 wrote: > From: Anoop S > > This fixes the following checkpatch.pl warning > WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this > function's name, in a string. > > Signed-off-by: Anoop S It would be great to have your

Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues

2020-07-19 Thread Greg Kroah-Hartman
On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote: > fixed multiple parentheses coding style issues reported by checkpatch. > > Signed-off-by: B K Karthik > --- > drivers/staging/rtl8188eu/include/ieee80211.h | 4 +-- > .../staging/rtl8188eu/include/osdep_service.h | 4 +-- > drivers

Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues

2020-07-19 Thread B K Karthik
On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman wrote: > > On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote: > > fixed multiple parentheses coding style issues reported by checkpatch. > > > > Signed-off-by: B K Karthik > > --- > > drivers/staging/rtl8188eu/include/ieee80211.h | 4

[PATCH 1/2] staging: rtl8192e: Fixed a coding style error

2020-07-19 Thread Darshan D V
rtllib_crypt_ccmp.c: Fixed the error - space required before the open parenthesis '(' on line #281. Signed-off-by: Darshan D V --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c

[PATCH 2/2] staging: rtl8192e: Fixed a coding style warning

2020-07-19 Thread Darshan D V
rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for conditional statements on line #338 Signed-off-by: Darshan D V --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.

Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues

2020-07-19 Thread Greg Kroah-Hartman
On Sun, Jul 19, 2020 at 05:35:04AM -0400, B K Karthik wrote: > On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman > wrote: > > > > On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote: > > > fixed multiple parentheses coding style issues reported by checkpatch. > > > > > > Signed-off-by: B

Re: [PATCH 1/2] staging: rtl8192e: Fixed a coding style error

2020-07-19 Thread Greg KH
On Sun, Jul 19, 2020 at 04:25:56PM +0530, Darshan D V wrote: > rtllib_crypt_ccmp.c: Fixed the error - space required before the > open parenthesis '(' on line #281. What does this mean for a changelog text? And why is it indented? Did you read the section in the submitting patches docume

Re: [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning

2020-07-19 Thread Greg KH
On Sun, Jul 19, 2020 at 04:25:57PM +0530, Darshan D V wrote: > rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for > conditional statements on line #338 You can't send two patches that do two different things, yet have the same exact subject: line :( _

[PATCH for v5.9] media: omap: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH] media: atomisp: fix mask and shift operation on ISPSSPM0

2020-07-19 Thread Mauro Carvalho Chehab
Em Thu, 16 Jul 2020 15:51:38 +0100 Colin King escreveu: > From: Colin Ian King > > Currently the check on bits 25:24 on ISPSSPM0 is always 0 because > the mask and shift operations are incorrect. Fix this by shifting > by MRFLD_ISPSSPM0_ISPSSS_OFFSET (24 bits right) and then masking > with RFLD

[PATCH] staging: rtl8188eu: add spaces around operators in header files

2020-07-19 Thread Michael Straube
Add spaces around operators in the header files to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube --- .../rtl8188eu/include/hal8188e_rate_adaptive.h | 4 ++-- drivers/staging/rtl8188eu/include/odm_types.h| 6 +++--- drivers/staging/rtl8188eu/inclu

[PATCH 1/2] staging: rtl8192e: add space before open parenthesis

2020-07-19 Thread Darshan D V
rtllib_crypt_ccmp.c: Fix the coding style error by adding a space before open parenthesis '(' in a conditional statement. Signed-off-by: Darshan D V --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl

[PATCH 2/2] staging: rtl8192e: add proper code indent

2020-07-19 Thread Darshan D V
rtllib_crypt_ccmp.c: As the code indent for a conditional statement is not according to the preferred coding style for the linux kernel, add code indent as necessary after a conditional statement. Signed-off-by: Darshan D V --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- 1 file changed

[PATCH for v5.9] staging: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH] Staging: rtl8188eu: core: Fix coding style issue

2020-07-19 Thread Anoop S
On Sun, Jul 19, 2020 at 11:24:37AM +0200, Greg KH wrote: > On Sat, Jul 18, 2020 at 04:01:25PM +0530, Anoop1507 wrote: > > From: Anoop S > > > > This fixes the following checkpatch.pl warning > > WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this > > function's name, in a

[PATCH v3] staging: kpc2000: Replace depracated MSI APIs

2020-07-19 Thread Suraj Upadhyay
Replace depracated MSI IRQ enabler and disabler with pci_alloc_irq_vectors and pci_free_irq_vectors respectively. Compile tested. Signed-off-by: Suraj Upadhyay --- Changes: v3: Replaced the disabler for MSI IRQ too with pci_free_irq_vectors. v2: Fix the undefined varia

[PATCH v2] staging: media: atomisp: Replace depracated MSI APIs

2020-07-19 Thread Suraj Upadhyay
Replace depracated MSI IRQ enabler and disabler with pci_alloc_irq_vectors and pci_free_irq_vectors respectively. And as a result handle the returned error as appropriate. Compile tested. Signed-off-by: Suraj Upadhyay --- Change: v2: Replace the MSI IRQ disabler too. --- drivers/staging/

[PATCH v2] staging: rts5208: rtsx: Replace depracated MSI API

2020-07-19 Thread Suraj Upadhyay
Replace depracated MSI IRQ enablers and disablers with pci_alloc_irq_vectors and pci_free_irq_vectors respectively. Compile tested. Signed-off-by: Suraj Upadhyay --- Changes: v2: Replace MSI IRQ disablers too. --- drivers/staging/rts5208/rtsx.c | 12 ++-- 1 file changed, 6 insert

Re: [PATCH] android: binder.h: drop a duplicated word

2020-07-19 Thread Christian Brauner
On Sat, Jul 18, 2020 at 05:27:38PM -0700, Randy Dunlap wrote: > Drop the repeated word "the" in a comment. > > Signed-off-by: Randy Dunlap > Cc: Greg Kroah-Hartman > Cc: Arve Hjønnevåg > Cc: Todd Kjos > Cc: Martijn Coenen > Cc: Joel Fernandes > Cc: Christian Brauner > Cc: Hridya Valsaraju

Re: [PATCH] staging: wlan-ng: properly check endpoint types

2020-07-19 Thread Rustam Kovhaev
On Sun, Jul 19, 2020 at 11:23:38AM +0200, Greg KH wrote: > On Sat, Jul 18, 2020 at 08:58:36AM -0700, Rustam Kovhaev wrote: > > As syzkaller detected, wlan-ng driver submits bulk urb without checking > > that the endpoint type is actually bulk, add usb_urb_ep_type_check() > > > > Reported-and-teste

My COVID-19 Donation

2020-07-19 Thread newsletters
Greetings, My name is Guang Huiqing the owner of Luen Yick Mfg Co Ltd Wuhan China. I am in the hospital suffering from complications due to covid 19 (coronavirus). I am in the intensive care unit and the doctor told me that I may not survive. My husband died of COVID 19 and his wish before he

My COVID-19 Donation

2020-07-19 Thread newsletters
Greetings, My name is Guang Huiqing the owner of Luen Yick Mfg Co Ltd Wuhan China. I am in the hospital suffering from complications due to covid 19 (coronavirus). I am in the intensive care unit and the doctor told me that I may not survive. My husband died of COVID 19 and his wish before he

Re: [PATCH] staging: media: ipu3: Replace depracated MSI API.

2020-07-19 Thread Bingbu Cao
Upadhyay, Thanks for your patch. Please correct the typo in message. On 7/18/20 9:32 PM, Suraj Upadhyay wrote: > Replace depracated psi_enable_msi with pci_alloc_irq_vectors. > And as a result modify how the returned value is handled. > > Signed-off-by: Suraj Upadhyay > --- > drivers/staging/m

My COVID-19 Donation

2020-07-19 Thread newsletters
Greetings, My name is Guang Huiqing the owner of Luen Yick Mfg Co Ltd Wuhan China. I am in the hospital suffering from complications due to covid 19 (coronavirus). I am in the intensive care unit and the doctor told me that I may not survive. My husband died of COVID 19 and his wish before he

[PATCH] staging: dpaa2-ethsw: fix switch/case fallthrough warning

2020-07-19 Thread Marian Posteuca
Fix the fallthrough warning that is reported by checkpatch. Signed-off-by: Marian Posteuca --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index 2f

Re: [PATCH] staging: dpaa2-ethsw: fix switch/case fallthrough warning

2020-07-19 Thread Joe Perches
On Mon, 2020-07-20 at 08:30 +0300, Marian Posteuca wrote: > Fix the fallthrough warning that is reported by checkpatch. > > Signed-off-by: Marian Posteuca > --- > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/f

[PATCH v2] staging: dpaa2-ethsw: fix switch/case fallthrough warning

2020-07-19 Thread Marian Posteuca
Fix the fallthrough warning that is reported by checkpatch. Signed-off-by: Marian Posteuca --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index 2fb7