On Tue, Jan 05, 2021 at 10:05:47AM +0800, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 6 ++
> 1 fil
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Signed-off-by: Zheng Yongjun
---
.../vc04_services/interface/vchiq_arm/vchiq_connected.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
a/drivers/staging/vc0
On 04/01/2021 18:31, Dan Carpenter wrote:
On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote:
The addition of the local 'userdata' pointer to
vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor
WAITING modes are used, in which case the value provided by the
caller is
On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote:
> The addition of the local 'userdata' pointer to
> vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor
> WAITING modes are used, in which case the value provided by the
> caller is replaced with a NULL.
>
> Fixes: 418
Am 04.01.21 um 13:09 schrieb Phil Elwell:
> The addition of the local 'userdata' pointer to
> vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor
> WAITING modes are used, in which case the value provided by the
> caller is replaced with a NULL.
>
> Fixes: 4184da4f316a ("staging:
According to the binding documentation pinctrl related nodes
must use '-pins$' and ''^(.*-)?pinmux$'' as names. Change all
to properly match them. Also default state is for consumer
nodes and shall be removed from here.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-dts/mt7621.dtsi
On Fri, Dec 25, 2020 at 07:02:15PM +0800, Xin Ji wrote:
> +static int anx7625_aux_dpcd_read(struct anx7625_data *ctx,
> + u8 addrh, u8 addrm, u8 addrl,
> + u8 len, u8 *buf)
> +{
> + struct device *dev = &ctx->client->dev;
> + int ret
On Mon, Jan 04, 2021 at 03:45:36PM +0100, Sergio Paracuellos wrote:
> Hi,
>
> On Mon, Jan 4, 2021 at 3:39 PM Linus Walleij wrote:
> >
> > On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos
> > wrote:
> >
> > > After this driver was moved from staging into pinctrl subsytems
> > > some reviews for
On Mon, Jan 04, 2021 at 03:34:10PM +0300, Dan Carpenter wrote:
> There is a Smatch warning for this, but I hadn't looked at the results
> in a while. :/ I'm not sure how many are valid. Some kind of
> annotation would be nice.
> drivers/usb/class/usblp.c:593 usblp_ioctl() error: doing dma on th
Hi,
On Mon, Jan 4, 2021 at 3:39 PM Linus Walleij wrote:
>
> On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos
> wrote:
>
> > After this driver was moved from staging into pinctrl subsytems
> > some reviews for bindigns and driver itself comes from Ron Herring
> > and Dan Carpenter. Get rid of a
On Fri, Dec 25, 2020 at 05:54:45PM +0800, Song Chen wrote:
> Macro is not supposed to have flow control in it's
> statement, remove.
>
It took me a long time to figure out what this commit message is saying.
It turns out that it is inspired by checkpatch. Forget all that nonsense
about "imperati
On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos
wrote:
> After this driver was moved from staging into pinctrl subsytems
> some reviews for bindigns and driver itself comes from Ron Herring
> and Dan Carpenter. Get rid of all the comments to properly be in
> a good shape before merge window.
On Thu, Dec 24, 2020 at 09:25:28PM +0800, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_connected.c| 3 +--
> 1 fil
On Wed, Dec 23, 2020 at 10:11:29PM +0800, Zheng Yongjun wrote:
> Signed-off-by: Zheng Yongjun
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_connected.c| 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
> a/drivers/staging/vc04_services/interface/vchiq_arm/vch
The recent change to the bulk transfer compat function missed the fact
the relevant ioctl command is VCHIQ_IOC_QUEUE_BULK_TRANSMIT32, not
VCHIQ_IOC_QUEUE_BULK_TRANSMIT, as any attempt to send a bulk block
to the VPU would have shown.
Fixes: a4367cd2b231 ("staging: vchiq: convert compat bulk transf
Of course, Smatch didn't trigger any warnings in the wfx driver. I need
to try re-write this check to use the cross function database so
function pointers are handled.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://dr
The recent batch of vchiq improvements broke bulk transfers in two ways:
1. The userdata associated with a transfer was lost in the case that a
non-blocking mode was used.
2. The 64-bit ioctl compatibility shim for a bulk transfer used the
wrong ioctl command.
This patch set fixes both of
On Tue, Dec 22, 2020 at 10:02:09PM +0100, Jérôme Pouiller wrote:
> On Tuesday 22 December 2020 16:27:01 CET Greg Kroah-Hartman wrote:
> >
> > On Tue, Dec 22, 2020 at 05:10:11PM +0200, Kalle Valo wrote:
> > > Jerome Pouiller writes:
> > >
> > > > +/*
> > > > + * Internal helpers.
> > > > + *
> > >
The addition of the local 'userdata' pointer to
vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor
WAITING modes are used, in which case the value provided by the
caller is replaced with a NULL.
Fixes: 4184da4f316a ("staging: vchiq: fix __user annotations")
Signed-off-by: Phil
19 matches
Mail list logo
