On Fri, 29 Jan 2021 16:26:12 +0200
Andy Shevchenko wrote:
> On Fri, Jan 29, 2021 at 3:56 PM carlis wrote:
> > On Fri, 29 Jan 2021 12:23:08 +0200
> > Andy Shevchenko wrote:
>
> We are almost there, I have no idea what Noralf or others are going to
> say though.
>
> ...
>
> > Hi, I apologize
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the whole source string.
This silences the related checkpa
allnoconfig
i386 randconfig-a001-20210129
i386 randconfig-a002-20210129
i386 randconfig-a004-20210129
i386 randconfig-a005-20210129
i386 randconfig-a003-20210129
i386 randconfig-a006
Also use KBUILD_MODNAME for module name.
This driver is only used by RALINK MIPS MT7621 SoCs. Tested by building
against that target using OpenWrt with Linux 5.10.10.
Fixes the following error:
error: the following would cause module name conflict:
drivers/dma/mediatek/mtk-hsdma.ko
drivers/st
From: Emmanuel Arias
> Sent: 29 January 2021 20:02
>
> Fix coding style using __packed sentece instead of
> __attribute__((__packed__)).
>
> Signed-off-by: Emmanuel Arias
> ---
> drivers/staging/media/allegro-dvt/allegro-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -
Fix coding style using __packed sentece instead of
__attribute__((__packed__)).
Signed-off-by: Emmanuel Arias
---
drivers/staging/media/allegro-dvt/allegro-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c
b/drivers/stagi
Hi Greg/Mark/Lee/Vinod,
Another rebase , also the top of staging-testing.
This series contain the remaining patches for USB to start working,
except for a final DTS patch.
Patches 1 and 2 convert the SPMI and regulator
drivers to use regmap and simplifies the logic by using
regmap helpers.
Patc
Now that the driver was ported to use regmap, let's use
some help functions in order to simplify the code a little
bit.
Suggested-by: Mark Brown
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/hi6421v600-regulator.c | 45 ++-
1 file changed, 3 insertions(+), 42 d
This driver is ready for mainstream. So, move it out of staging.
Signed-off-by: Mauro Carvalho Chehab
---
.../mfd}/hisilicon,hi6421-spmi-pmic.yaml | 0
MAINTAINERS| 7 +++
drivers/mfd/Kconfig| 16
driver
The phy USB3 driver for Hisilicon 970 (hi3670) is ready
for mainstream. Mode it from staging into the main driver's
phy/ directory.
Signed-off-by: Mauro Carvalho Chehab
---
.../bindings/phy/hisilicon,hi3670-usb3.yaml | 0
MAINTAINERS | 9
The Hisilicon 6421v600 SPMI driver is ready for mainstream.
So, move it from staging.
Signed-off-by: Mauro Carvalho Chehab
---
.../spmi}/hisilicon,hisi-spmi-controller.yaml | 0
MAINTAINERS | 7 +++
drivers/spmi/Kconfig
This driver is ready for mainstream. Move it out of staging.
Signed-off-by: Mauro Carvalho Chehab
---
MAINTAINERS | 7 +--
drivers/regulator/Kconfig| 9 +
drivers/regulator/Makefile | 1
The conversion to regmap introduced a regression at the code
which reads from the IRQ register. Address that.
Fixes: 8148fe6afb24 ("staging: hikey9xx: spmi driver: convert to regmap")
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 2 +-
1 file changed, 1 i
Cleanup the error handling code, making the messages more
consistent and removing an uneeded call to free_irq().
While here, also remove debug messages and make the
error messages more consistent.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 50 +++-
- When referring to regmap, rename map to regmap
- inside hi6421-spmi-pmic, call private data struct as
ddata.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 104 +-
.../staging/hikey9xx/hi6421v600-regulator.c
At PMIC subsystem, C89 comments are preferred over C99.
While here, also update the copyrights of the header file.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 14 +++---
include/linux/mfd/hi6421-spmi-pmic.h| 1 +
2 files changed, 8 inse
Remove the IRQ list from the header, as this is used only
inside the driver itself. Also, get rid of two unused
defines.
The net result is that only struct hi6421_spmi_pmic remains
on it, as this is used by the regulator driver.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/
- Use BIT() and GENMASK();
- Remove duplicated mask definitions;
- Simplify the code under IRQ handler;
- Add a few extra blank lines to make easier to see
spin_lock/spin_unlock;
- Remove debug code;
- Fix a few minor coding style issues.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/stagin
Make it clearer about how the IRQ registers are filled by adding
a table with them, with two macros used to calculate the mask
register.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 39 +
1 file changed, 32 insertions(+), 7 deletions(
Instead of doing its own SPMI I/O implementation, use the
already-existing regmap one.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/Kconfig | 2 +
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 115 ++
.../staging/hikey9xx/hi6421v600-regulator
Em Fri, 29 Jan 2021 16:45:11 +0100
Greg Kroah-Hartman escreveu:
> On Fri, Jan 29, 2021 at 04:03:36PM +0100, Mauro Carvalho Chehab wrote:
> > Instead of doing its own SPMI I/O implementation, use the
> > already-existing regmap one.
> >
> > Signed-off-by: Mauro Carvalho Chehab
> > ---
> > drive
On Wed, Jan 06, 2021 at 01:08:15PM +0100, Johan Hovold wrote:
> On Wed, Jan 06, 2021 at 01:04:04PM +0100, Johan Hovold wrote:
> > On Tue, Jan 05, 2021 at 04:19:02PM +0100, Greg Kroah-Hartman wrote:
> > > The correct user/kernel api for vibrator devices is the Input rumble
> > > api, not a random sy
On Fri, Jan 29, 2021 at 04:03:36PM +0100, Mauro Carvalho Chehab wrote:
> Instead of doing its own SPMI I/O implementation, use the
> already-existing regmap one.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 115 ++
> .../staging
The Hisilicon 6421v600 SPMI driver is ready for mainstream.
So, move it from staging.
Signed-off-by: Mauro Carvalho Chehab
---
.../spmi/hisilicon,hisi-spmi-controller.yaml | 75
MAINTAINERS | 7 +
drivers/spmi/Kconfig | 9 +
Hi Greg/Mark/Lee/Vinod,
Another rebase , also the top of staging-testing,
This series contain the remaining patches for USB to start working,
except for a final DTS patch.
Patches 1 and 2 convert the SPMI and regulator
drivers to use regmap and simplifies the logic by using
regmap helpers.
Patc
The phy USB3 driver for Hisilicon 970 (hi3670) is ready
for mainstream. Mode it from staging into the main driver's
phy/ directory.
Signed-off-by: Mauro Carvalho Chehab
---
.../bindings/phy/hisilicon,hi3670-usb3.yaml | 73 ++
MAINTAINERS | 9 +-
drivers/phy
This driver is ready for mainstream. So, move it out of staging.
Signed-off-by: Mauro Carvalho Chehab
---
.../mfd/hisilicon,hi6421-spmi-pmic.yaml | 135
MAINTAINERS | 7 +
drivers/mfd/Kconfig | 15 +
drivers/mfd/Makefi
Make it clearer about how the IRQ registers are filled by adding
a table with them, with two macros used to calculate the mask
register.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 38 +
1 file changed, 31 insertions(+), 7 deletions(
Now that the driver was ported to use regmap, let's use
some help functions in order to simplify the code a little
bit.
Suggested-by: Mark Brown
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/hi6421v600-regulator.c | 45 ++-
1 file changed, 3 insertions(+), 42 d
- When referring to regmap, rename map to regmap
- inside hi6421-spmi-pmic, call private data struct as
ddata.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 104 +-
.../staging/hikey9xx/hi6421v600-regulator.c
This driver is ready for mainstream. Move it out of staging.
Signed-off-by: Mauro Carvalho Chehab
---
MAINTAINERS | 7 +-
drivers/regulator/Kconfig | 8 +
drivers/regulator/Makefile| 1 +
drivers/regulator/hi6421v600
Cleanup the error handling code, making the messages more
consistent and removing an uneeded call to free_irq().
While here, also remove debug messages and make the
error messages more consistent.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 48 +++-
- Use BIT() and GENMASK();
- Remove duplicated mask definitions;
- Simplify the code under IRQ handler;
- Add a few extra blank lines to make easier to see
spin_lock/spin_unlock;
- Remove debug code;
- Fix a few minor coding style issues.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/stagin
Instead of doing its own SPMI I/O implementation, use the
already-existing regmap one.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 115 ++
.../staging/hikey9xx/hi6421v600-regulator.c | 26 ++--
include/linux/mfd/hi6421-spmi-pmic.h
Remove the IRQ list from the header, as this is used only
inside the driver itself. Also, get rid of two unused
defines.
The net result is that only struct hi6421_spmi_pmic remains
on it, as this is used by the regulator driver.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/
At PMIC subsystem, C89 comments are preferred over C99.
While here, also update the copyrights of the header file.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 14 +++---
include/linux/mfd/hi6421-spmi-pmic.h| 1 +
2 files changed, 8 inse
The conversion to regmap introduced a regression at the code
which reads from the IRQ register. Address that.
Fixes: 8148fe6afb24 ("staging: hikey9xx: spmi driver: convert to regmap")
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 2 +-
1 file changed, 1 i
Em Fri, 29 Jan 2021 13:29:10 +
Lee Jones escreveu:
> On Fri, 29 Jan 2021, Mauro Carvalho Chehab wrote:
>
> > Hi Lee,
> >
> > Em Wed, 27 Jan 2021 11:05:37 +
> > Lee Jones escreveu:
>
> > > > +static const struct mfd_cell hi6421v600_devs[] = {
> > > > + { .name = "hi6421v600-regu
On Fri, Jan 29, 2021 at 3:56 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
We are almost there, I have no idea what Noralf or others are going to
say though.
...
> Hi, I apologize for what I said in the previous two emails. I missed
> one email you sent before,
On Fri, Jan 29, 2021 at 2:54 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > > On Thu, 28 Jan 2021 16:33:02 +0200
> > > Andy Shevchenko wrote:
...
> > This one is not like I suggested.
> I don't think I have
On Fri, Jan 29, 2021 at 2:47 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > > On Thu, 28 Jan 2021 16:33:02 +0200
> > > Andy Shevchenko wrote:
> > > > On Thu, Jan 28, 2021 at 2:58 PM Carlis
> > > > wrote:
...
On Fri, 29 Jan 2021 12:23:08 +0200
Andy Shevchenko wrote:
> On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > On Thu, 28 Jan 2021 16:33:02 +0200
> > Andy Shevchenko wrote:
> > > On Thu, Jan 28, 2021 at 2:58 PM Carlis
> > > wrote:
> > >
> > > Thanks for your contribution, my comments below.
>
On Fri, 29 Jan 2021, Mauro Carvalho Chehab wrote:
> Hi Lee,
>
> Em Wed, 27 Jan 2021 11:05:37 +
> Lee Jones escreveu:
>
> > On Tue, 19 Jan 2021, Mauro Carvalho Chehab wrote:
> >
> > > This driver is ready for mainstream. So, move it out of staging.
> > >
>
> > Replied to an earlier submis
On Thu, Jan 28, 2021 at 07:45:51PM +, Jonathan Cameron wrote:
> On Mon, 25 Jan 2021 15:08:17 +0100
> Greg KH wrote:
>
> > On Sun, Jan 24, 2021 at 11:31:59AM -0800, Linus Torvalds wrote:
> > > On Sun, Jan 24, 2021 at 4:58 AM Greg KH
> > > wrote:
> > > >
> > > > David Lechner (1):
> > > >
Hi Lee,
Em Wed, 27 Jan 2021 11:05:37 +
Lee Jones escreveu:
> On Tue, 19 Jan 2021, Mauro Carvalho Chehab wrote:
>
> > This driver is ready for mainstream. So, move it out of staging.
> >
> Replied to an earlier submission where I was able to reply in-line.
Sorry! Infradead seemed to have
On Fri, 29 Jan 2021 12:23:08 +0200
Andy Shevchenko wrote:
> On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > On Thu, 28 Jan 2021 16:33:02 +0200
> > Andy Shevchenko wrote:
> > > On Thu, Jan 28, 2021 at 2:58 PM Carlis
> > > wrote:
> > >
> > > Thanks for your contribution, my comments below.
>
On Fri, 29 Jan 2021 12:23:08 +0200
Andy Shevchenko wrote:
> On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > On Thu, 28 Jan 2021 16:33:02 +0200
> > Andy Shevchenko wrote:
> > > On Thu, Jan 28, 2021 at 2:58 PM Carlis
> > > wrote:
> > >
> > > Thanks for your contribution, my comments below.
>
On Fri, Jan 29, 2021 at 12:23:08PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > On Thu, 28 Jan 2021 16:33:02 +0200
> > Andy Shevchenko wrote:
> > > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
> > >
> > > Thanks for your contribution, my comments below.
> >
On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> On Thu, 28 Jan 2021 16:33:02 +0200
> Andy Shevchenko wrote:
> > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
> >
> > Thanks for your contribution, my comments below.
> >
> > > From: zhangxuezhi
> >
> > You probably have to configure your Git to u
On 0129, Greg Kroah-Hartman wrote:
> [SNIP]
> > Yes, because it's copying the source strings to fixed size buffers in
> > ethtool_drvinfo, so truncation would be fine here (as it's the driver name
> > and
> > other identity related stuff).
>
> So there is no need to make this change, or it is re
On Fri, Jan 29, 2021 at 02:38:33PM +0530, Kumar Kartikeya Dwivedi wrote:
> On 0129, Greg Kroah-Hartman wrote:
> > On Fri, Jan 29, 2021 at 01:51:55PM +0530, Kumar Kartikeya Dwivedi wrote:
> > > [Forgot to reply-all]
> > >
> > > On 0129, Greg Kroah-Hartman wrote:
> > > > On Fri, Jan 29, 2021 at 12:1
On 0129, Greg Kroah-Hartman wrote:
> On Fri, Jan 29, 2021 at 01:51:55PM +0530, Kumar Kartikeya Dwivedi wrote:
> > [Forgot to reply-all]
> >
> > On 0129, Greg Kroah-Hartman wrote:
> > > On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote:
> > > > Fixes checkpatch warnings for us
On Fri, Jan 29, 2021 at 01:51:55PM +0530, Kumar Kartikeya Dwivedi wrote:
> [Forgot to reply-all]
>
> On 0129, Greg Kroah-Hartman wrote:
> > On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote:
> > > Fixes checkpatch warnings for usage of strlcpy.
> >
> > What warning would tha
[Forgot to reply-all]
On 0129, Greg Kroah-Hartman wrote:
> On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote:
> > Fixes checkpatch warnings for usage of strlcpy.
>
> What warning would that be?
>
5dbdb2d87c294401a22e6a6002f08ebc9fbea38b
https://git.kernel.org/pub/scm/linu
On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote:
> Fixes checkpatch warnings for usage of strlcpy.
What warning would that be?
And if we could just search/replace for this, why hasn't that already
happened for the whole tree?
thanks,
greg k-h
55 matches
Mail list logo
