[PATCH] fix coding style of drivers/staging/rtl8192u/r8190_rtl8256.c

2021-02-15 Thread Du Cheng
use __func__ macro instead of literal function name in RT_TRACE() in * phy_set_rf8256_bandwidth() * phy_rf8256_config_para_file() remove unnecessary return at the end of phy_set_rf8256_ofdm_tx_power() Signed-off-by: Du Cheng --- drivers/staging/rtl8192u/r8190_rtl8256.c | 7 +++ 1 file

[PATCH] staging: wlan-ng: Remove unused function pointer typedef freebuf_method_t

2021-02-15 Thread Chen Lin
From: Chen Lin Remove the 'freebuf_method_t' typedef as it is not used. Signed-off-by: Chen Lin --- drivers/staging/wlan-ng/p80211conv.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.h b/drivers/staging/wlan-ng/p80211conv.h index 827002c..15fd635

Re: Sound issues with the 5.10.x kernel (alsa)

2021-02-15 Thread Diederik de Haas
On maandag 8 februari 2021 13:22:56 CET Stefan Wahren wrote: > Currently i cannot see any of the fixes by Phil > Elwell in linux-stable. Maybe they won't apply and needs to be backport > manually. > > Just for reference here are the revelant patches: > >

[PATCH 4/6] staging: rtl8723bs: remove DBG_COUNTER calls from core/rtw_recv.c

2021-02-15 Thread Phillip Potter
Remove all DBG_COUNTER macro calls from core/rtw_recv.c, as the corresponding variables are only ever written to and not used. This makes the code cleaner, and is necessary prior to removing the DBG_COUNTER definition itself. Signed-off-by: Phillip Potter ---

[PATCH 5/6] staging: rtl8723bs: remove DBG_COUNTER definition from rtw_debug.h

2021-02-15 Thread Phillip Potter
Remove DBG_COUNTER macro definition from include/rtw_debug.h, as all uses of it have now been removed and it is no longer required. The DBG_COUNTER incremented values were never actually used anywhere else in the driver. Signed-off-by: Phillip Potter ---

[PATCH 6/6] staging: rtl8723bs: remove rx_logs/tx_logs/int_logs from drv_types.h

2021-02-15 Thread Phillip Potter
Remove the rx_logs/tx_logs/int_logs struct definitions and their inclusion within struct adapter as fields, from include/drv_types.h. They were conditionally compiled based on CONFIG_DBG_COUNTER which now has no other users in the driver, and were only ever accessed in a write only fashion via the

[PATCH 2/6] staging: rtl8723bs: remove DBG_COUNTER calls from os_dep/xmit_linux.c

2021-02-15 Thread Phillip Potter
Remove all DBG_COUNTER macro calls from os_dep/xmit_linux.c, as the corresponding variables are only ever written to and not used. This makes the code cleaner, and is necessary prior to removing the DBG_COUNTER definition itself. Signed-off-by: Phillip Potter ---

[PATCH 3/6] staging: rtl8723bs: remove DBG_COUNTER calls from core/rtw_xmit.c

2021-02-15 Thread Phillip Potter
Remove all DBG_COUNTER macro calls from core/rtw_xmit.c, as the corresponding variables are only ever written to and not used. This makes the code cleaner, and is necessary prior to removing the DBG_COUNTER definition itself. Signed-off-by: Phillip Potter ---

[PATCH 0/6] staging: rtl8723bs: remove DBG_COUNTER

2021-02-15 Thread Phillip Potter
This patch set removes all calls of the DBG_COUNTER macro from the driver, as the macro only increments the relevant values, which are never then used anywhere else. It then removes the DBG_COUNTER macro definition itself. In addition, it removes rx_logs/tx_logs/int_logs struct definitions from

[PATCH 1/6] staging: rtl8723bs: remove DBG_COUNTER calls from os_dep/recv_linux.c

2021-02-15 Thread Phillip Potter
Remove all DBG_COUNTER macro calls from os_dep/recv_linux.c, as the corresponding variables are only ever written to and not used. This makes the code cleaner, and is necessary prior to removing the DBG_COUNTER definition itself. Signed-off-by: Phillip Potter ---

[PATCH] staging: rtl8192e: Fix comparisons to NULL

2021-02-15 Thread Davidson Francis
Checkpatch prefers the shorter version (x / !x) over (!= NULL / == NULL), respectively. Signed-off-by: Davidson Francis --- drivers/staging/rtl8192e/rtllib_wx.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH v2] staging: rtl8192e: fix typo in a function name

2021-02-15 Thread William Durand
There is a typo here where it says "qurey" but "query" was intended. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index

Re: [PATCH v1 0/9] x86/platform: Remove SFI framework and users

2021-02-15 Thread Rafael J. Wysocki
On Thu, Feb 11, 2021 at 4:45 PM Hans de Goede wrote: > > Hi, > > On 2/11/21 4:24 PM, Rafael J. Wysocki wrote: > > On Thu, Feb 11, 2021 at 2:50 PM Andy Shevchenko > > wrote: > >> > >> This is last part of Intel MID (SFI based) removal. We have no more users > >> of it > >> in the kernel and

Re: [PATCH] staging: rtl8192e: fix typo in a function name

2021-02-15 Thread William Durand
> On Sat, Feb 13, 2021 at 09:20:14AM +, William Durand wrote: > > Other function names use the verb 'query' so this function should > > probably use it too and that's what this patch is about. I didn't > > find any other occurrence and the code compiles. > > > > It's really just assumed that

[GIT PULL] Staging/IIO driver patches for 5.12-rc1

2021-02-15 Thread Greg KH
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04: Linux 5.11-rc5 (2021-01-24 16:47:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.12-rc1 for you to fetch changes up to

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-02-15 Thread Andy Shevchenko
On Tue, Feb 2, 2021 at 3:52 AM Carlis wrote: > On Mon, 1 Feb 2021 19:40:21 +0200 > Andy Shevchenko wrote: > > > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote: > > > On Fri, 29 Jan 2021 16:26:12 +0200 > > > Andy Shevchenko wrote: > > > > On Fri, Jan 29, 2021 at 3:56 PM carlis > > > > wrote: > >

Re: [PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 05:02:50PM +0200, Alaa Emad wrote: > sorry ,i thought it needs to change the description so i resent . If so, then say what you changed below the --- line and make it a v2 patch, like the Documentation tells you to do, right? > please guide me how to fix this or it is

Re: [PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 04:36:52PM +0200, Alaa Emad wrote: > This patch fix the following issues in hi6421-spmi-pmic.c file: > > drivers/staging/hikey9xx/hi6421-spmi-pmic.c:51: WARNING: please, no space > before tabs > drivers/staging/hikey9xx/hi6421-spmi-pmic.c:52: WARNING: please, no space >

[PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

2021-02-15 Thread Alaa Emad
This patch fix the following issues in hi6421-spmi-pmic.c file: drivers/staging/hikey9xx/hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs drivers/staging/hikey9xx/hi6421-spmi-pmic.c:52: WARNING: please, no space before tabs drivers/staging/hikey9xx/hi6421-spmi-pmic.c:53: WARNING:

[PATCH v4] ks7010: enclose non-trivial defines in parentheses

2021-02-15 Thread shivang upadhyay
Checkpatch complains that parentheses are missing: "Macros with complex values should be enclosed in parentheses". Fixed that. Signed-off-by: shivang upadhyay --- Previous versions of the patch were rejected due to lack of discription in patch emails. drivers/staging/ks7010/ks_hostif.h | 24

Re: [PATCH] staging:wlan-ng: use memdup_user instead of kmalloc/copy_from_user

2021-02-15 Thread Dan Carpenter
On Mon, Feb 15, 2021 at 09:44:24AM +0100, Michal Hocko wrote: > On Sat 13-02-21 15:05:28, Ivan Safonov wrote: > > memdup_user() is shorter and safer equivalent > > of kmalloc/copy_from_user pair. > > > > Signed-off-by: Ivan Safonov > > --- > > drivers/staging/wlan-ng/p80211netdev.c | 28

[PATCH] staging: rtl8723bs: Remove unused function pointer typedef wi_act_func

2021-02-15 Thread Chen Lin
From: Chen Lin Remove the 'wi_act_func' typedef as it is not used. Signed-off-by: Chen Lin --- drivers/staging/rtl8723bs/include/rtw_mp.h |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_mp.h b/drivers/staging/rtl8723bs/include/rtw_mp.h index

Re: [PATCH] staging: rtl8192e: fix typo in a function name

2021-02-15 Thread Dan Carpenter
On Sat, Feb 13, 2021 at 09:20:14AM +, William Durand wrote: > Other function names use the verb 'query' so this function should > probably use it too and that's what this patch is about. I didn't > find any other occurrence and the code compiles. > It's really just assumed that the code

Re: [PATCH] staging:wlan-ng: use memdup_user instead of kmalloc/copy_from_user

2021-02-15 Thread Michal Hocko
On Sat 13-02-21 15:05:28, Ivan Safonov wrote: > memdup_user() is shorter and safer equivalent > of kmalloc/copy_from_user pair. > > Signed-off-by: Ivan Safonov > --- > drivers/staging/wlan-ng/p80211netdev.c | 28 -- > 1 file changed, 13 insertions(+), 15 deletions(-) >

Re: [PATCH v3] ks7010: enclosed non-trivial defines in parentheses

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 05:15:34PM +0530, shivang upadhyay wrote: > checkpatch.pl complains about missing parentheses > "Macros with complex values should be enclosed in parentheses". > fixed that > > > Signed-off-by: shivang upadhyay > --- > drivers/staging/ks7010/ks_hostif.h | 24

[PATCH v3] ks7010: enclosed non-trivial defines in parentheses

2021-02-15 Thread shivang upadhyay
checkpatch.pl complains about missing parentheses "Macros with complex values should be enclosed in parentheses". fixed that Signed-off-by: shivang upadhyay --- drivers/staging/ks7010/ks_hostif.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [greybus-dev] [PATCH 1/1] staging: greybus: Added do - while in multi statement macro

2021-02-15 Thread Dan Carpenter
On Thu, Feb 11, 2021 at 03:40:39PM +0530, Viresh Kumar wrote: > On 11-02-21, 11:00, Greg KH wrote: > > On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote: > > > This patch add fixes an checkpatch error for "Macros with multiple > > > statements > > > should be enclosed in a do -

Re: [PATCH -next] staging: nvec: minor coding style fix

2021-02-15 Thread Thierry Reding
On Fri, Feb 12, 2021 at 10:34:23AM +0300, Fatih Yildirim wrote: > Fix for the below coding style warning. > Warning: Move const after static - use 'static const int' > > Signed-off-by: Fatih Yildirim > --- > drivers/staging/nvec/nvec_power.c | 2 +- > 1 file changed, 1 insertion(+), 1