Re: [PATCH] Staging: pi433: Updated bitrate range from datasheet

2024-03-03 Thread Greg KH
On Mon, Mar 04, 2024 at 02:28:02AM +0530, Aman Sharma wrote: > From a0528708b209739f0d566401bdd428e215abf366 Mon Sep 17 00:00:00 2001 > From: Aman Sharma > Date: Mon, 4 Mar 2024 00:44:06 +0530 > Subject: [PATCH] Staging: pi433: Updated bitrate range from datasheet Why is this all here in the

Re: [PATCH] staging: ks7010: remove unnecesary parentheses

2023-03-30 Thread Greg KH
On Fri, Mar 31, 2023 at 01:04:59AM +0800, Joel C. Chang wrote: > On Thu, Mar 30, 2023 at 02:49:54PM +0200, Greg KH wrote: > > On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote: > > > Remove parentheses not needed in if statement > > > >

Re: [PATCH] staging: ks7010: remove unnecessary parentheses

2023-03-30 Thread Greg KH
On Thu, Mar 30, 2023 at 08:48:28PM +0800, Joel Camilo Chang Gonzalez wrote: > Remove redundant parentheses > > Signed-off-by: Joel Camilo Chang Gonzalez > --- > drivers/staging/ks7010/ks_wlan_net.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [PATCH] staging: ks7010: remove unnecesary parentheses

2023-03-30 Thread Greg KH
On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote: > Remove parentheses not needed in if statement > > Signed-off-by: Joel Camilo Chang Gonzalez > --- > drivers/staging/ks7010/ks_hostif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: Missing patch for Partial crash when loading driver rtl8192e

2022-10-11 Thread Greg KH
On Tue, Oct 11, 2022 at 09:43:46PM +0200, Philipp Hortmann wrote: > Hi, > > yesterday I did a git pull. > > when I tried to load the driver rtl8192e I had the below partial crash. > > I was able to fix it with this patch: > >

Re: [PATCH] Staging: Android: ashmem.c: Fixed missing const modifier

2022-09-15 Thread Greg KH
On Thu, Sep 15, 2022 at 08:58:27PM +1200, Jonathan Bergh wrote: > Fixed missing const modifier line 370 > > Signed-off-by: Jonathan Bergh > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c >

Re: Confirmation for subscribe linux-usb

2022-08-24 Thread Greg KH
On Wed, Aug 24, 2022 at 02:36:55PM +0800, Hu Xiaoying wrote: > submit patch > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept

Re: [RESEND PATCH v3 0/1] Binder: add TF_UPDATE_TXN to replace outdated txn

2022-06-15 Thread Greg KH
On Wed, Jun 15, 2022 at 11:05:23AM -0700, Li Li wrote: > On Thu, May 26, 2022 at 10:50 PM Greg KH wrote: > > > > On Thu, May 26, 2022 at 03:00:17PM -0700, Li Li wrote: > > > From: Li Li > > > > > > Resend [Patch v3] with cover letter in case my previou

Re: [PATCH v2] Binder: add TF_UPDATE_TXN to replace outdated txn

2022-05-19 Thread Greg KH
On Thu, May 19, 2022 at 11:34:54AM -0700, Li Li wrote: > From: Li Li > > When the target process is busy, incoming oneway transactions are > queued in the async_todo list. If the clients continue sending extra > oneway transactions while the target process is frozen, this queue can > become too

Re: [PATCH v1] Binder: add TF_UPDATE_TXN

2022-05-19 Thread Greg KH
On Wed, May 18, 2022 at 05:06:23PM -0700, Li Li wrote: > From: Li Li Note, your subject does not say what TF_UPDATE_TXN is, so it's a bit hard to determine what is happening here. Can you clean that up a bit and sumarize what this new addition does? > > When the target process is busy,

Re: [PATCH v1] pinctrl: ralink: rt2880: Check for return value of devm_kcalloc()

2022-03-29 Thread Greg KH
On Tue, Mar 29, 2022 at 03:50:12PM +0800, QintaoShen wrote: > The memory allocation function devm_kcalloc() may return NULL pointer, > so it is better to add a check for 'p->func[i]->pins' to avoid possible > NULL pointer dereference. > > Signed-off-by: QintaoShen > --- >

Re: [PATCH] Staging: rtl871: rtl871x_mlme: fixed coding style issues

2021-12-28 Thread Greg KH
On Sat, Dec 25, 2021 at 11:32:39PM -0500, Agam Kohli wrote: > Fixed multiple line dereferences > > Signed-off-by: Agam Kohli > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 125 ++--- > 1 file changed, 49 insertions(+), 76 deletions(-) > > diff --git

Re: [PATCH] binder: fix async_free_space accounting for empty parcels

2021-12-21 Thread Greg KH
On Mon, Dec 20, 2021 at 11:06:09AM -0800, Todd Kjos wrote: > On Mon, Dec 20, 2021 at 11:02 AM Todd Kjos wrote: > > > > In 4.13, commit 74310e06be4d ("android: binder: Move buffer out of area > > shared with user space") > > fixed a kernel structure visibility issue. As part of that patch, > >

Re: [PATCH v3 1/1] staging: ion: Prevent incorrect reference counting behavour

2021-11-27 Thread Greg KH
On Fri, Nov 26, 2021 at 10:33:35AM +, Lee Jones wrote: > Supply additional checks in order to prevent unexpected results. > > Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") > Suggested-by: Dan Carpenter > Signed-off-by: Lee Jones > --- > Destined for v4.4.y and v4.9.y > >

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

2021-11-26 Thread Greg KH
On Fri, Nov 26, 2021 at 08:56:27AM +, Lee Jones wrote: > On Fri, 26 Nov 2021, Dan Carpenter wrote: > > > On Thu, Nov 25, 2021 at 06:18:22PM +0300, Dan Carpenter wrote: > > > I had thought that ->kmap_cnt was a regular int and not an unsigned > > > int, but I would have to pull a stable tree

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

2021-11-25 Thread Greg KH
On Thu, Nov 25, 2021 at 01:03:46PM +, Lee Jones wrote: > On Thu, 25 Nov 2021, Greg KH wrote: > > > On Thu, Nov 25, 2021 at 12:46:23PM +, Lee Jones wrote: > > > On Thu, 25 Nov 2021, Greg KH wrote: > > > > > > > On Thu, Nov 25, 2021 at 12:02:34P

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

2021-11-25 Thread Greg KH
On Thu, Nov 25, 2021 at 12:46:23PM +, Lee Jones wrote: > On Thu, 25 Nov 2021, Greg KH wrote: > > > On Thu, Nov 25, 2021 at 12:02:34PM +, Lee Jones wrote: > > > Supply additional checks in order to prevent unexpected results. > > > > > > Fixes: b89

Re: [PATCH 1/1] staging: ion: Prevent incorrect reference counting behavour

2021-11-25 Thread Greg KH
On Thu, Nov 25, 2021 at 12:02:34PM +, Lee Jones wrote: > Supply additional checks in order to prevent unexpected results. > > Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf") > Signed-off-by: Lee Jones > --- > drivers/staging/android/ion/ion.c | 3 +++ > 1 file changed, 3

Re: [PATCH] binder: fix test regression due to sender_euid change

2021-11-24 Thread Greg KH
On Fri, Nov 19, 2021 at 03:39:59PM -0800, Todd Kjos wrote: > On Fri, Nov 19, 2021 at 3:00 PM Paul Moore wrote: > > > > On Fri, Nov 12, 2021 at 1:07 PM Todd Kjos wrote: > > > > > > This is a partial revert of commit > > > 29bc22ac5e5b ("binder: use euid from cred instead of using task"). > > >

Re: [PATCH 0/3] binder: Prevent untranslated sender data from being copied to target

2021-11-24 Thread Greg KH
On Tue, Nov 23, 2021 at 11:17:34AM -0800, Todd Kjos wrote: > Binder copies transactions directly from the sender buffer > to the target buffer and then fixes up BINDER_TYPE_PTR and > BINDER_TYPE_FDA objects. This means there is a brief time > when sender pointers and fds are visible to the target

Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

2021-11-19 Thread Greg KH
On Fri, Nov 19, 2021 at 02:36:44PM +0100, Alberto Merciai wrote: > driver-core$ ./scripts/get_maintainer.pl drivers/staging/vt6655/device.h > Forest Bond (odd fixer:STAGING - VIA VT665X > DRIVERS) > Greg Kroah-Hartman (supporter:STAGING SUBSYSTEM) > Alberto Merciai >

Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

2021-11-19 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

2021-11-18 Thread Greg KH
On Thu, Nov 18, 2021 at 09:27:18PM +0100, Alberto Merciai wrote: > Replace camelcase variable "uCurrRSSI" (current Received Signal Strength > Indicator) into linux kernel coding style equivalent > variable "current_rssi". > > Signed-off-by: Alberto Merciai > --- > > v2 > - correct mailing list

Re: [PATCH v2] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

2021-11-17 Thread Greg KH
On Tue, Nov 16, 2021 at 12:31:02AM +0100, Alberto Merciai wrote: > Replace camelcase variable "uCurrRSSI" (current Received Signal Strength > Indicator) into linux kernel coding style equivalent > variable "current_rssi". > > Signed-off-by: Alberto Merciai > --- Sent to the wrong mailing list,

Re: [PATCH v4] staging: vt6655: fix camelcase in wCurrentRate

2021-11-17 Thread Greg KH
On Mon, Nov 15, 2021 at 03:08:56PM +0100, Alberto Merciai wrote: > Replace camelcase word variable "wCurrentRate" into linux kernel coding > style equivalent "current_rate". > > Signed-off-by: Alberto Merciai Does not apply to my tree. Please rebase against the staging-next branch and resend.

Re: [PATCH] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

2021-11-15 Thread Greg KH
On Sun, Nov 14, 2021 at 05:40:48PM +0100, Alberto Merciai wrote: > Replace camelcase variable "uCurrRSSI" (current Received Signal Strength > Indicator) into linux kernel coding style equivalent Odd line break :( And trailing whitespace :( > variable "current_rssi". > > References: >

Re: [PATCH v3] staging: vt6655: fix camelcase in wCurrentRate

2021-11-15 Thread Greg KH
On Sun, Nov 14, 2021 at 10:09:35AM +0100, Alberto Merciai wrote: > Replace camelcase word variable "wCurrentRate" into linux kernel coding > style equivalent "current_rate". > > References: > https://www.kernel.org/doc/html/latest/process/coding-style.html We all know the kernel coding style, no

Re: [PATCH v2] staging: vt6655: fix camelcase in wCurrentRate

2021-11-14 Thread Greg KH
On Sun, Nov 14, 2021 at 09:20:29AM +0100, Alberto Merciai wrote: > Replace camelcase word variable "wCurrentRate" into linux kernel coding > style equivalent "current_rate". > > References: > https://www.kernel.org/doc/html/latest/process/coding-style.html >

Re: [PATCH] staging: vt6655: fix camelcase in wCurrentRate

2021-11-13 Thread Greg KH
On Sat, Nov 13, 2021 at 06:09:42PM +0100, Alberto Merciai wrote: > Signed-off-by: Alberto Merciai > --- > drivers/staging/vt6655/device.h | 2 +- > drivers/staging/vt6655/device_main.c | 12 +-- > drivers/staging/vt6655/rxtx.c| 134 +-- > 3 files changed,

Re: [PATCH 4.4 2/2] binder: use cred instead of task for selinux checks

2021-11-12 Thread Greg KH
On Fri, Nov 12, 2021 at 05:11:38PM +0100, Greg KH wrote: > On Wed, Nov 10, 2021 at 02:59:10PM -0800, Todd Kjos wrote: > > commit 52f88693378a58094c538662ba652aff0253c4fe upstream. > > > > Since binder was integrated with selinux, it has passed > > 'str

Re: [PATCH 4.4 2/2] binder: use cred instead of task for selinux checks

2021-11-12 Thread Greg KH
On Wed, Nov 10, 2021 at 02:59:10PM -0800, Todd Kjos wrote: > commit 52f88693378a58094c538662ba652aff0253c4fe upstream. > > Since binder was integrated with selinux, it has passed > 'struct task_struct' associated with the binder_proc > to represent the source and target of transactions. > The

Re: [PATCH] staging: rtl8723bs: Remove redundant indentation

2021-11-05 Thread Greg KH
On Tue, Nov 02, 2021 at 04:12:59PM +0800, hoshinomorimor...@gmail.com wrote: > From: Hoshinomori-Owari > > Remove redundant indentation in > drivers/staging/rtl8723bs/core/rtw_ap.c:1139. > Issue found by checkpatch.pl > > Signed-off-by: Hoshinomori-Owari > --- >

Re: [PATCH] staging: comedi: Cleaned a bit of code that was not required

2021-10-27 Thread Greg KH
On Wed, Oct 27, 2021 at 03:32:34PM -0400, vaatsalya shrivastava wrote: > Warning found by checkpatch.pl script. Please be specific as to what you did. > > Signed-off-by: vaatsalya shrivastava "V" and "S"? > --- > drivers/comedi/drivers/dt2815.c| 2 +- >

Re: [PATCH v2] binder: use cred instead of task for selinux checks

2021-10-05 Thread Greg KH
On Tue, Oct 05, 2021 at 09:53:31AM -0400, Paul Moore wrote: > On Tue, Oct 5, 2021 at 9:31 AM Greg KH wrote: > > On Fri, Oct 01, 2021 at 10:55:21AM -0700, Todd Kjos wrote: > > > Save the struct cred associated with a binder process > > > at initial open to avoi

Re: [PATCH v2] binder: use cred instead of task for selinux checks

2021-10-05 Thread Greg KH
On Fri, Oct 01, 2021 at 10:55:21AM -0700, Todd Kjos wrote: > Save the struct cred associated with a binder process > at initial open to avoid potential race conditions > when converting to a security ID. > > Since binder was integrated with selinux, it has passed > 'struct task_struct' associated

Re: [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Greg KH
On Thu, Sep 23, 2021 at 10:18:14PM +0800, Cheng Chao wrote: > Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up > cached buffer alloc") > the commit e7f63771b60e introduced the bug which didn't test page which maybe > NULL. > and previous logic was right. > > the

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Greg KH
On Wed, Sep 22, 2021 at 08:17:15PM +0800, Cheng Chao wrote: > I notice that v4.9.283 has released, but this patch is not merged. > It's exactly a bug. Can you please resend this and include all of the information in this thread in the changelog comment explaining why this is only needed for this

Re: [PATCH] binder: make sure fd closes complete

2021-09-14 Thread Greg KH
On Fri, Sep 03, 2021 at 12:38:26PM -0700, Todd Kjos wrote: > On Fri, Sep 3, 2021 at 1:06 AM Dan Carpenter wrote: > > > > On Thu, Sep 02, 2021 at 08:35:35AM -0700, Todd Kjos wrote: > > > On Tue, Aug 31, 2021 at 12:24 AM Martijn Coenen wrote: > > > > > > > > On Mon, Aug 30, 2021 at 9:51 PM 'Todd

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-11 Thread Greg KH
On Sat, Sep 11, 2021 at 07:21:15PM +0800, Cheng Chao wrote: > kernel panic is here: > > Unable to handle kernel paging request at virtual address b038 > pgd = d9d94000 > [b038] *pgd= > Internal error: Oops: 2805 [#1] PREEMPT SMP ARM > ... > task: daa2dd00 task.stack: da194000 > PC

Re: [PATCH v2 1/1] binder: fix freeze race

2021-09-10 Thread Greg KH
On Thu, Sep 09, 2021 at 11:17:42PM -0700, Li Li wrote: > On Thu, Sep 9, 2021 at 10:38 PM Greg KH wrote: > > > > On Thu, Sep 09, 2021 at 08:53:16PM -0700, Li Li wrote: > > > struct binder_frozen_status_info { > > > __u32pid; > > &

Re: [PATCH v2 1/1] binder: fix freeze race

2021-09-09 Thread Greg KH
On Thu, Sep 09, 2021 at 08:53:16PM -0700, Li Li wrote: > From: Li Li > > Currently cgroup freezer is used to freeze the application threads, and > BINDER_FREEZE is used to freeze the corresponding binder interface. > There's already a mechanism in ioctl(BINDER_FREEZE) to wait for any > existing

Re: [PATCH] binder: make sure fd closes complete

2021-09-02 Thread Greg KH
On Thu, Sep 02, 2021 at 08:35:35AM -0700, Todd Kjos wrote: > On Tue, Aug 31, 2021 at 12:24 AM Martijn Coenen wrote: > > > > On Mon, Aug 30, 2021 at 9:51 PM 'Todd Kjos' via kernel-team > > wrote: > > > > > > During BC_FREE_BUFFER processing, the BINDER_TYPE_FDA object > > > cleanup may close 1 or

Re: [PATCH] staging/ks7010: Fix coding style problems [Version 2]

2021-08-16 Thread Greg KH
On Mon, Aug 16, 2021 at 08:04:47PM +0200, Leon Krieg wrote: > By doing some last-second wording changes directly in the diff I've > screwed up and managed to use spaces instead of tabs for the Kconfig file. > This is embarrassing! > > Signed-off-by: Leon Krieg > --- >

Re: [PATCH] staging/ks7010: Fix coding style problems

2021-08-16 Thread Greg KH
On Mon, Aug 16, 2021 at 07:55:03PM +0200, Leon Krieg wrote: > Sorry to bother you with this low-effort patch but I'd really like to get > my feet in the water and this whole process is making me nervous. I'd > really appreciate you taking the time to look over this diff and > hopefully I did not

[GIT PULL] Staging driver fixes for 5.14-rc5

2021-08-08 Thread Greg KH
The following changes since commit 2734d6c1b1a089fb593ef6a23d4b70903526fe0c: Linux 5.14-rc2 (2021-07-18 14:13:49 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.14-rc5 for you to fetch changes up to

Re: [PATCH] Drivers: comedi: Lindented files.

2021-07-23 Thread Greg KH
On Fri, Jul 23, 2021 at 12:09:27AM +0300, vpuh1 wrote: > Indented files in drivers/comedi directory using scripts/Lindent. > > Signed-off-by: Artem Baxtiarov Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to

[GIT PULL] Staging / IIO driver updates for 5.14-rc1

2021-07-05 Thread Greg KH
The following changes since commit 009c9aa5be652675a06d5211e1640e02bbb1c33d: Linux 5.13-rc6 (2021-06-13 14:43:10 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.14-rc1 for you to fetch changes up to

[GIT PULL] Staging driver fixes for 5.13-rc6

2021-06-12 Thread Greg KH
The following changes since commit 8124c8a6b35386f73523d27eacb71b5364a68c4c: Linux 5.13-rc4 (2021-05-30 11:58:25 -1000) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.13-rc6 for you to fetch changes up to

[GIT PULL] Staging/IIO driver fixes for 5.13-rc4

2021-05-29 Thread Greg KH
The following changes since commit d07f6ca923ea0927a1024dfccafc5b53b61cfecc: Linux 5.13-rc2 (2021-05-16 15:27:44 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.13-rc4 for you to fetch changes up to

Re: [PATCH] Fixed a coding style issue - missing a blank line after declarations

2021-05-22 Thread Greg KH
On Sat, May 22, 2021 at 08:49:50PM +0900, tco0427 wrote: > --- > drivers/staging/rtl8723bs/core/rtw_cmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c > b/drivers/staging/rtl8723bs/core/rtw_cmd.c > index e1a8f8b47edd..40d99644ddc7 100644 >

Re: [PATCH 00/17] Add an experimental driver for Intel NUC leds

2021-05-17 Thread Greg KH
On Mon, May 17, 2021 at 11:02:58AM +0200, Mauro Carvalho Chehab wrote: > Em Mon, 17 May 2021 10:18:57 +0200 > Greg KH escreveu: > > > On Sun, May 16, 2021 at 12:53:28PM +0200, Mauro Carvalho Chehab wrote: > > > Hi Greg, > > > > > > This series add supp

Re: [PATCH 01/17] staging: add support for NUC WMI LEDs

2021-05-17 Thread Greg KH
On Sun, May 16, 2021 at 12:53:29PM +0200, Mauro Carvalho Chehab wrote: > Some Intel Next Unit of Computing (NUC) machines have > software-configured LEDs that can be used to display a > variety of events: > > - Power State > - HDD Activity > - Ethernet > - WiFi > -

Re: [PATCH 00/17] Add an experimental driver for Intel NUC leds

2021-05-17 Thread Greg KH
On Sun, May 16, 2021 at 12:53:28PM +0200, Mauro Carvalho Chehab wrote: > Hi Greg, > > This series add support for the LEDs found at Intel NUCs since > NUC version 6. > > On several NUC models, the function of the LEDs are programmable, > which allow them to indicate several different hardware

[GIT PULL] Staging/IIO driver fixes for 5.13-rc2

2021-05-16 Thread Greg KH
The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.13-rc2 for you to fetch changes up to

Re: [PATCH] staging: rtl8192e: fix array of flexible structures

2021-04-28 Thread Greg KH
On Wed, Apr 28, 2021 at 12:28:44AM +0530, Jitendra wrote: > On Tue, Apr 27, 2021 at 08:10:20PM +0200, Greg KH wrote: > > On Tue, Apr 27, 2021 at 11:19:45PM +0530, Jitendra Khasdev wrote: > > > This patch fixes sparse warning "array of flexible structures" > &g

Re: [PATCH] staging: rtl8192e: fix array of flexible structures

2021-04-27 Thread Greg KH
On Tue, Apr 27, 2021 at 11:19:45PM +0530, Jitendra Khasdev wrote: > This patch fixes sparse warning "array of flexible structures" > for rtllib.h. > > eg. drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of > flexible structures > > Signed-off-by: Jitendra Khasdev > --- >

Re: [GIT PULL] Staging/IIO driver updates for 5.13-rc1

2021-04-27 Thread Greg KH
On Mon, Apr 26, 2021 at 11:18:49AM -0700, Linus Torvalds wrote: > On Mon, Apr 26, 2021 at 8:11 AM Greg KH wrote: > > > > Yeah, merge issues with other trees are hard to resolve in the single > > tree here, not much I can just yet, have to wait for them to hit Linus's > >

Re: [GIT PULL] Staging/IIO driver updates for 5.13-rc1

2021-04-26 Thread Greg KH
On Tue, Apr 27, 2021 at 12:26:48AM +1000, Stephen Rothwell wrote: > Hi Greg, > > On Mon, 26 Apr 2021 14:46:10 +0200 Greg KH wrote: > > > > All of these have been in linux-next for a while with no reported > > issues. > > There was just these: >

[GIT PULL] Staging driver fix for 5.12-rc6

2021-04-03 Thread Greg KH
The following changes since commit 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b: Linux 5.12-rc4 (2021-03-21 14:56:43 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.12-rc6 for you to fetch changes up to

Re: [PATCH] staging: fbtft: change snprintf() to scnprintf()

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 09:05:01AM +, Carlis wrote: > From: Xuezhi Zhang > > show() must not use snprintf() when formatting the value to > be returned to user space. Why not? The code is just fine as-is. > > Signed-off-by: Xuezhi Zhang > --- > drivers/staging/fbtft/fbtft-sysfs.c | 2 +-

Re: Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 08:28:02PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > > > > > > > On T

Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > > > > > > > On T

Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > > Use receive_fd() to receive file from another process instead of > > > c

Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > Use receive_fd() to receive file from another process instead of > combination of get_unused_fd_flags() and fd_install(). This simplifies > the logic and also makes sure we don't miss any security stuff. But no logic is simplified

Re: [PATCH 0/2] Export receive_fd() to modules and do some cleanups

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 05:09:30PM +0800, Xie Yongji wrote: > This series starts from Christian's comments on the series[1]. > We'd like to export receive_fd() which can not only be used by > our module in the series[1] but also allow further cleanups > like patch 2 does. But binder can not be a

Re: [PATCH 1/2] file: Export receive_fd() to modules

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 05:09:31PM +0800, Xie Yongji wrote: > Export receive_fd() so that some modules can use > it to pass file descriptor across processes without > missing any security stuffs. > > Signed-off-by: Xie Yongji > --- > fs/file.c| 6 ++ > include/linux/file.h | 7

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-28 Thread Greg KH
On Tue, Mar 23, 2021 at 02:05:23PM +0200, Eli Billauer wrote: > On 22/03/21 13:11, Greg KH wrote: > > > > > XILLYBUS and XILLYBUS_PCIE are currently enabled as M in several Linux > > > distributions. Making them depend on, rather than select XILLYBUS_CLASS is > &g

Re: [PATCH] staging: gasket: remove it from the kernel

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 03:46:10PM +0100, Jan Kiszka wrote: > On 15.03.21 17:10, Rob Springer wrote: > > Acked-by: Rob Springer > > > > > > On Mon, Mar 15, 2021 at 8:44 AM wrote: > >> > >> From: Greg Kroah-Hartman > >> > >> As none of the proposed things that need to be changed in the gasket

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 07:03:39PM +0800, Jian Dong wrote: > On Thu, 25 Mar 2021 11:29:06 +0100 > Greg KH wrote: > > > On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > > > From: Jian Dong > > > > > > fixes coccicheck Error: > > >

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > From: Jian Dong > > fixes coccicheck Error: > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > fw is NULL but dereferenced. > > if procedure goto label directly, ret will be nefative, so the fw is NULL > and the

Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment

2021-03-23 Thread Greg KH
On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote: > Fixed alignment of multi-line comment. > Added a * for each line of the comment. > > Signed-off-by: Abhishek C > --- > drivers/android/binder.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH v2 0/9] fix extern declarations checkpatch issues

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 01:56:27PM +0100, Fabio Aiuto wrote: > Fix extern declaration issues warned by checkpatch. Nit, we have a new mailing list, you might want to use that now instead of driverdev in the future, thanks! greg k-h ___ devel mailing

Re: [PATCH] staging: rtl8723bs: Trivial typo fix

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 06:38:35AM +0530, Bhaskar Chowdhury wrote: > > s/netowrk/network/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c

Re: [PATCH v3] drivers: most: add ALSA sound driver

2021-03-23 Thread Greg KH
On Tue, Feb 09, 2021 at 11:13:47AM +0100, Christian Gromm wrote: > This patch moves the ALSA sound driver out of the staging area and adds it > to the stable part of the MOST driver. Modifications to the Makefiles and > Kconfigs are done accordingly to not break the build. > > Signed-off-by:

Re: [PATCH] staging: wimax: Mundane typo fixes

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 09:14:43PM -0700, Randy Dunlap wrote: > On 3/22/21 6:06 PM, Bhaskar Chowdhury wrote: > > > > s/procesing/processing/ > > s/comunication/communication/ > > > > Signed-off-by: Bhaskar Chowdhury > > drivers/staging/wimax/ is in the process of being deleted. It's already

Re: [PATCH 05/11] staging: rtl8723bs: remove argument in recv_indicatepkts_pkt_loss_cnt

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote: > remove debug_priv argument so function prototype can be > easily moved away > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > >

Re: [PATCH 04/11] staging: rtl8723bs: moved function prototypes out of core/rtw_recv.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:42PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 1190: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:1190: > +signed int validate_recv_mgnt_frame(struct adapter *padapter, union > recv_frame

Re: [PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40: > +u8 rtw_do_join(struct adapter *padapter); > > WARNING: externs should be

Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: > +bool > > moved two function prototypes in include/rtw_efuse.h > > Signed-off-by:

Re: [PATCH 11/11] staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:49PM +0100, Fabio Aiuto wrote: > remove unnecessary extern. > > The function is defined static in os_dep/os_intfs.c and used only once > in the same file > > remove also a blank line That needs to go to a separate patch :(

Re: [PATCH] staging: rtl8723bs: Mundane typo fixes

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 12:58:08PM +0530, Bhaskar Chowdhury wrote: > > s/stoping/stooping/ Huh? Are you _sure_ that is the correct replacement? Last I looked it wasn't... greg k-h ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v4 2/2] staging: Add driver for XillyUSB (Xillybus variant for USB)

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 01:01:54PM +0200, Eli Billauer wrote: > Hello, Greg. > > Thanks for your comments. I'd like to address a couple of them. > > First, there's the lockless FIFO that is implemented in the driver: > > On 21/03/21 14:23, Greg KH wrote: > > > &g

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 01:02:04PM +0200, Eli Billauer wrote: > On 21/03/21 14:24, Greg KH wrote: > > > +config XILLYBUS_CLASS > > > > + tristate > > > > + > > > >config XILLYBUS > > > > tristate &quo

[GIT PULL] Staging/IIO driver fixes for 5.12-rc4

2021-03-21 Thread Greg KH
The following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0: Linux 5.12-rc3 (2021-03-14 14:41:02 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.12-rc4 for you to fetch changes up to

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-21 Thread Greg KH
On Thu, Mar 11, 2021 at 11:50:32AM +0200, eli.billa...@gmail.com wrote: > +EXPORT_SYMBOL(xillybus_init_chrdev); Given the license for this code, perhaps EXPORT_SYMBOL_GPL()? I have to ask :) thanks, greg k-h ___ devel mailing list

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-21 Thread Greg KH
On Thu, Mar 11, 2021 at 11:50:32AM +0200, eli.billa...@gmail.com wrote: > From: Eli Billauer > > This patch is a preparation for adding another related driver, XillyUSB. > In order to share some code between the existing Xillybus driver and the > one to be added, some functions are moved to

Re: [PATCH v4 2/2] staging: Add driver for XillyUSB (Xillybus variant for USB)

2021-03-21 Thread Greg KH
On Thu, Mar 11, 2021 at 11:50:33AM +0200, eli.billa...@gmail.com wrote: > From: Eli Billauer > > The XillyUSB driver is the USB variant for the Xillybus FPGA IP core. > Even though it presents a nearly identical API on the FPGA and host, > it's almost a complete rewrite of the driver: The

Re: [PATCH] rtl8188eu: Removed Unnecessary ftrace-like logging

2021-03-19 Thread Greg KH
On Thu, Mar 18, 2021 at 08:05:27PM +, Paul McQuade wrote: > prefer using ftrace You need to say more here than just this please. Also please fix up your subject line to have "staging:" in it, otherwise it gets easily lost. thanks, greg k-h ___

Re: [PATCH] rtsx_chip.c:Fix usleep_range is preferred over udelay

2021-03-18 Thread Greg KH
On Thu, Mar 18, 2021 at 04:38:37PM +0530, Akshith A V wrote: > changed udelay to usleep_range Trailing whitespace and odd line wrap :( > because usleep_range is preferred over udelay by checkpatch.pl > > Signed-off-by: Akshith A V > --- > drivers/staging/rts5208/rtsx_chip.c | 2 +- > 1 file

Re: staging: rtl8723bs: prefer ftrace

2021-03-18 Thread Greg KH
On Thu, Mar 18, 2021 at 10:14:15AM +0100, Fabio Aiuto wrote: > Hi, > > some suggestions before diving in a new task. > The following checkpatch issue: > > -- > WARNING: Unnecessary ftrace-like logging - prefer using ftrace > #559: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:559: > +

Re: staging: rtl8723bs: remove unused code blocks completed?

2021-03-17 Thread Greg KH
On Wed, Mar 17, 2021 at 10:59:32AM +0100, Fabio Aiuto wrote: > Hi, > > I'm trying to search other unused code blocks: > > grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' > drivers/staging/rtl8723bs/ > > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) >

Re: [PATCH 00/15] staging: rtl8723bs: remove unused code blocks

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 11:13:49AM +0100, Fabio Aiuto wrote: > Remove unused code blocks as required in TODO file > > Fabio Aiuto (15): > staging: rtl8723bs: remove unused code blocks conditioned by never set > CONFIG_AUTO_AP_MODE > staging: rtl8723bs: remove unused code blocks

Re: [PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote: > remove conditional code blocks checked by unused CONFIG_PM > > cleaning required in TODO file: > > find and remove code blocks guarded by never set CONFIG_FOO defines > > Signed-off-by: Fabio Aiuto > --- >

Re: [PATCH] staging: rts5208: add empty line in general.c

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 07:12:20PM +0800, Hao Peng wrote: > Add one empty line upon return for easy reading. Why? Is this really needed? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: rtl8192e: remove extra lines in rtl819x_BAProc.c

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 07:04:18PM +0800, Hao Peng wrote: > Remove extra lines in rtl819x_BAProc.c. > > Signed-off-by: Hao Peng Same issue here, please fix up the changelog text. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: rtl8192e: remove extra space in rtl819x_BAProc.c

2021-03-16 Thread Greg KH
On Mon, Mar 15, 2021 at 06:33:20PM +0800, Hao Peng wrote: > Remove extra spaces in rtl819x_BAProc.c. That says what you did, but not _why_ you are doing this. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in

Re: [PATCH v2] staging:rtl8723bs:core:rtw_wlan_util:fixed indentation coding style issue

2021-03-16 Thread Greg KH
On Sun, Mar 14, 2021 at 09:58:55PM +0530, Shreya wrote: > Fixed the indentation of the else part of the conditional statement. > > Signed-off-by: Shreya > --- > v1 -> v2: > Changed name in signed-off-by to match name in From No, change it the other way around, you had your "real" name in the

Re: [PATCH] staging: rtl8192u: remove extra lines

2021-03-16 Thread Greg KH
On Tue, Mar 16, 2021 at 05:59:22PM +0800, zhaoxiao wrote: > Remove extra lines in the struct r8192_private_args. > > Signed-off-by: zhaoxiao > --- > drivers/staging/rtl8192u/r8192U_wx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_wx.c >

driverdev mailing list is moving!

2021-03-15 Thread Greg KH
Hi all, After almost 14 years of being hosted by OSUOSL, the driverdev mailing list is moving to lists.linux.dev. This should help out with the occasional mailman issues that driverdev had at times, and is one of the first lists to help stress-test the new linux.dev mailing lists infrastructure.

Re: [PATCH] staging: rtl8192u: remove extra lines

2021-03-15 Thread Greg KH
On Mon, Mar 15, 2021 at 03:27:59PM +0800, zhaoxiao wrote: > Remove extra lines in many functions in r8192U_wx.c. > Signed-off-by: zhaoxiao You did mor than just remove extra lines :( Also we need an extra line right before your signed-off-by line, as checkpatch should have warned you about.

  1   2   3   4   5   6   7   8   9   10   >