On Mon, Aug 12, 2024 at 11:16:27PM -0700, Li Li wrote:
> On Mon, Aug 12, 2024 at 10:13 PM Greg KH wrote:
> >
> > On Mon, Aug 12, 2024 at 02:18:44PM -0700, Li Li wrote:
> > > From: Li Li
> >
> > Sorry, but I can not parse your Subject: line at all. Please use
On Mon, Aug 12, 2024 at 02:18:44PM -0700, Li Li wrote:
> From: Li Li
Sorry, but I can not parse your Subject: line at all. Please use
vowels, we don't have a lack of them :)
Also look at how other patches are formatted for these files to get an
idea of how to create a good subject line.
> Froz
On Mon, Mar 04, 2024 at 02:28:02AM +0530, Aman Sharma wrote:
> From a0528708b209739f0d566401bdd428e215abf366 Mon Sep 17 00:00:00 2001
> From: Aman Sharma
> Date: Mon, 4 Mar 2024 00:44:06 +0530
> Subject: [PATCH] Staging: pi433: Updated bitrate range from datasheet
Why is this all here in the chan
On Fri, Mar 31, 2023 at 01:04:59AM +0800, Joel C. Chang wrote:
> On Thu, Mar 30, 2023 at 02:49:54PM +0200, Greg KH wrote:
> > On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote:
> > > Remove parentheses not needed in if statement
> > >
>
On Thu, Mar 30, 2023 at 08:48:28PM +0800, Joel Camilo Chang Gonzalez wrote:
> Remove redundant parentheses
>
> Signed-off-by: Joel Camilo Chang Gonzalez
> ---
> drivers/staging/ks7010/ks_wlan_net.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/sta
On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote:
> Remove parentheses not needed in if statement
>
> Signed-off-by: Joel Camilo Chang Gonzalez
> ---
> drivers/staging/ks7010/ks_hostif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s
On Tue, Oct 11, 2022 at 09:43:46PM +0200, Philipp Hortmann wrote:
> Hi,
>
> yesterday I did a git pull.
>
> when I tried to load the driver rtl8192e I had the below partial crash.
>
> I was able to fix it with this patch:
>
> https://lore.kernel.org/netdev/20220926233458.5316-1-yin31...@gmail.c
On Thu, Sep 15, 2022 at 08:58:27PM +1200, Jonathan Bergh wrote:
> Fixed missing const modifier line 370
>
> Signed-off-by: Jonathan Bergh
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c
> b/drive
On Wed, Aug 24, 2022 at 02:36:55PM +0800, Hu Xiaoying wrote:
> submit patch
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
wri
On Wed, Jun 15, 2022 at 11:05:23AM -0700, Li Li wrote:
> On Thu, May 26, 2022 at 10:50 PM Greg KH wrote:
> >
> > On Thu, May 26, 2022 at 03:00:17PM -0700, Li Li wrote:
> > > From: Li Li
> > >
> > > Resend [Patch v3] with cover letter in case my previou
On Thu, May 19, 2022 at 11:34:54AM -0700, Li Li wrote:
> From: Li Li
>
> When the target process is busy, incoming oneway transactions are
> queued in the async_todo list. If the clients continue sending extra
> oneway transactions while the target process is frozen, this queue can
> become too l
On Wed, May 18, 2022 at 05:06:23PM -0700, Li Li wrote:
> From: Li Li
Note, your subject does not say what TF_UPDATE_TXN is, so it's a bit
hard to determine what is happening here. Can you clean that up a bit
and sumarize what this new addition does?
>
> When the target process is busy, incomin
On Tue, Mar 29, 2022 at 03:50:12PM +0800, QintaoShen wrote:
> The memory allocation function devm_kcalloc() may return NULL pointer,
> so it is better to add a check for 'p->func[i]->pins' to avoid possible
> NULL pointer dereference.
>
> Signed-off-by: QintaoShen
> ---
> drivers/pinctrl/ralink/
On Sat, Dec 25, 2021 at 11:32:39PM -0500, Agam Kohli wrote:
> Fixed multiple line dereferences
>
> Signed-off-by: Agam Kohli
> ---
> drivers/staging/rtl8712/rtl871x_mlme.c | 125 ++---
> 1 file changed, 49 insertions(+), 76 deletions(-)
>
> diff --git a/drivers/staging/rtl87
On Mon, Dec 20, 2021 at 11:06:09AM -0800, Todd Kjos wrote:
> On Mon, Dec 20, 2021 at 11:02 AM Todd Kjos wrote:
> >
> > In 4.13, commit 74310e06be4d ("android: binder: Move buffer out of area
> > shared with user space")
> > fixed a kernel structure visibility issue. As part of that patch,
> > siz
On Fri, Nov 26, 2021 at 10:33:35AM +, Lee Jones wrote:
> Supply additional checks in order to prevent unexpected results.
>
> Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
> Suggested-by: Dan Carpenter
> Signed-off-by: Lee Jones
> ---
> Destined for v4.4.y and v4.9.y
>
> drivers/
On Fri, Nov 26, 2021 at 08:56:27AM +, Lee Jones wrote:
> On Fri, 26 Nov 2021, Dan Carpenter wrote:
>
> > On Thu, Nov 25, 2021 at 06:18:22PM +0300, Dan Carpenter wrote:
> > > I had thought that ->kmap_cnt was a regular int and not an unsigned
> > > int, but I would have to pull a stable tree to
On Thu, Nov 25, 2021 at 01:03:46PM +, Lee Jones wrote:
> On Thu, 25 Nov 2021, Greg KH wrote:
>
> > On Thu, Nov 25, 2021 at 12:46:23PM +, Lee Jones wrote:
> > > On Thu, 25 Nov 2021, Greg KH wrote:
> > >
> > > > On Thu, Nov 25, 2021 at 12:02:34P
On Thu, Nov 25, 2021 at 12:46:23PM +, Lee Jones wrote:
> On Thu, 25 Nov 2021, Greg KH wrote:
>
> > On Thu, Nov 25, 2021 at 12:02:34PM +, Lee Jones wrote:
> > > Supply additional checks in order to prevent unexpected results.
> > >
> > > Fixes: b89
On Thu, Nov 25, 2021 at 12:02:34PM +, Lee Jones wrote:
> Supply additional checks in order to prevent unexpected results.
>
> Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
> Signed-off-by: Lee Jones
> ---
> drivers/staging/android/ion/ion.c | 3 +++
> 1 file changed, 3 insertions(+
On Fri, Nov 19, 2021 at 03:39:59PM -0800, Todd Kjos wrote:
> On Fri, Nov 19, 2021 at 3:00 PM Paul Moore wrote:
> >
> > On Fri, Nov 12, 2021 at 1:07 PM Todd Kjos wrote:
> > >
> > > This is a partial revert of commit
> > > 29bc22ac5e5b ("binder: use euid from cred instead of using task").
> > > Set
On Tue, Nov 23, 2021 at 11:17:34AM -0800, Todd Kjos wrote:
> Binder copies transactions directly from the sender buffer
> to the target buffer and then fixes up BINDER_TYPE_PTR and
> BINDER_TYPE_FDA objects. This means there is a brief time
> when sender pointers and fds are visible to the target
>
On Fri, Nov 19, 2021 at 02:36:44PM +0100, Alberto Merciai wrote:
> driver-core$ ./scripts/get_maintainer.pl drivers/staging/vt6655/device.h
> Forest Bond (odd fixer:STAGING - VIA VT665X
> DRIVERS)
> Greg Kroah-Hartman (supporter:STAGING SUBSYSTEM)
> Alberto Merciai
> (commit_signer:2/2=100%,au
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I includ
On Thu, Nov 18, 2021 at 09:27:18PM +0100, Alberto Merciai wrote:
> Replace camelcase variable "uCurrRSSI" (current Received Signal Strength
> Indicator) into linux kernel coding style equivalent
> variable "current_rssi".
>
> Signed-off-by: Alberto Merciai
> ---
>
> v2
> - correct mailing list
On Tue, Nov 16, 2021 at 12:31:02AM +0100, Alberto Merciai wrote:
> Replace camelcase variable "uCurrRSSI" (current Received Signal Strength
> Indicator) into linux kernel coding style equivalent
> variable "current_rssi".
>
> Signed-off-by: Alberto Merciai
> ---
Sent to the wrong mailing list, p
On Mon, Nov 15, 2021 at 03:08:56PM +0100, Alberto Merciai wrote:
> Replace camelcase word variable "wCurrentRate" into linux kernel coding
> style equivalent "current_rate".
>
> Signed-off-by: Alberto Merciai
Does not apply to my tree. Please rebase against the staging-next
branch and resend.
On Sun, Nov 14, 2021 at 05:40:48PM +0100, Alberto Merciai wrote:
> Replace camelcase variable "uCurrRSSI" (current Received Signal Strength
> Indicator) into linux kernel coding style equivalent
Odd line break :(
And trailing whitespace :(
> variable "current_rssi".
>
> References:
> https://w
On Sun, Nov 14, 2021 at 10:09:35AM +0100, Alberto Merciai wrote:
> Replace camelcase word variable "wCurrentRate" into linux kernel coding
> style equivalent "current_rate".
>
> References:
> https://www.kernel.org/doc/html/latest/process/coding-style.html
We all know the kernel coding style, no
On Sun, Nov 14, 2021 at 09:20:29AM +0100, Alberto Merciai wrote:
> Replace camelcase word variable "wCurrentRate" into linux kernel coding
> style equivalent "current_rate".
>
> References:
> https://www.kernel.org/doc/html/latest/process/coding-style.html
> https://www.cse.iitk.ac.in/users/dsrkg/
On Sat, Nov 13, 2021 at 06:09:42PM +0100, Alberto Merciai wrote:
> Signed-off-by: Alberto Merciai
> ---
> drivers/staging/vt6655/device.h | 2 +-
> drivers/staging/vt6655/device_main.c | 12 +--
> drivers/staging/vt6655/rxtx.c| 134 +--
> 3 files changed, 7
On Fri, Nov 12, 2021 at 05:11:38PM +0100, Greg KH wrote:
> On Wed, Nov 10, 2021 at 02:59:10PM -0800, Todd Kjos wrote:
> > commit 52f88693378a58094c538662ba652aff0253c4fe upstream.
> >
> > Since binder was integrated with selinux, it has passed
> > 'struct
On Wed, Nov 10, 2021 at 02:59:10PM -0800, Todd Kjos wrote:
> commit 52f88693378a58094c538662ba652aff0253c4fe upstream.
>
> Since binder was integrated with selinux, it has passed
> 'struct task_struct' associated with the binder_proc
> to represent the source and target of transactions.
> The conv
On Tue, Nov 02, 2021 at 04:12:59PM +0800, hoshinomorimor...@gmail.com wrote:
> From: Hoshinomori-Owari
>
> Remove redundant indentation in
> drivers/staging/rtl8723bs/core/rtw_ap.c:1139.
> Issue found by checkpatch.pl
>
> Signed-off-by: Hoshinomori-Owari
> ---
> drivers/staging/rtl8723bs/core/
On Wed, Oct 27, 2021 at 03:32:34PM -0400, vaatsalya shrivastava wrote:
> Warning found by checkpatch.pl script.
Please be specific as to what you did.
>
> Signed-off-by: vaatsalya shrivastava
"V" and "S"?
> ---
> drivers/comedi/drivers/dt2815.c| 2 +-
> drivers/staging/vme/devices/vm
On Tue, Oct 05, 2021 at 09:53:31AM -0400, Paul Moore wrote:
> On Tue, Oct 5, 2021 at 9:31 AM Greg KH wrote:
> > On Fri, Oct 01, 2021 at 10:55:21AM -0700, Todd Kjos wrote:
> > > Save the struct cred associated with a binder process
> > > at initial open to avoi
On Fri, Oct 01, 2021 at 10:55:21AM -0700, Todd Kjos wrote:
> Save the struct cred associated with a binder process
> at initial open to avoid potential race conditions
> when converting to a security ID.
>
> Since binder was integrated with selinux, it has passed
> 'struct task_struct' associated
On Thu, Sep 23, 2021 at 10:18:14PM +0800, Cheng Chao wrote:
> Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up
> cached buffer alloc")
> the commit e7f63771b60e introduced the bug which didn't test page which maybe
> NULL.
> and previous logic was right.
>
> the e7f63771b6
On Wed, Sep 22, 2021 at 08:17:15PM +0800, Cheng Chao wrote:
> I notice that v4.9.283 has released, but this patch is not merged.
> It's exactly a bug.
Can you please resend this and include all of the information in this
thread in the changelog comment explaining why this is only needed for
this o
On Fri, Sep 03, 2021 at 12:38:26PM -0700, Todd Kjos wrote:
> On Fri, Sep 3, 2021 at 1:06 AM Dan Carpenter wrote:
> >
> > On Thu, Sep 02, 2021 at 08:35:35AM -0700, Todd Kjos wrote:
> > > On Tue, Aug 31, 2021 at 12:24 AM Martijn Coenen wrote:
> > > >
> > > > On Mon, Aug 30, 2021 at 9:51 PM 'Todd Kj
On Sat, Sep 11, 2021 at 07:21:15PM +0800, Cheng Chao wrote:
> kernel panic is here:
>
> Unable to handle kernel paging request at virtual address b038
> pgd = d9d94000
> [b038] *pgd=
> Internal error: Oops: 2805 [#1] PREEMPT SMP ARM
> ...
> task: daa2dd00 task.stack: da194000
> PC
On Thu, Sep 09, 2021 at 11:17:42PM -0700, Li Li wrote:
> On Thu, Sep 9, 2021 at 10:38 PM Greg KH wrote:
> >
> > On Thu, Sep 09, 2021 at 08:53:16PM -0700, Li Li wrote:
> > > struct binder_frozen_status_info {
> > > __u32pid;
> > &
On Thu, Sep 09, 2021 at 08:53:16PM -0700, Li Li wrote:
> From: Li Li
>
> Currently cgroup freezer is used to freeze the application threads, and
> BINDER_FREEZE is used to freeze the corresponding binder interface.
> There's already a mechanism in ioctl(BINDER_FREEZE) to wait for any
> existing t
On Thu, Sep 02, 2021 at 08:35:35AM -0700, Todd Kjos wrote:
> On Tue, Aug 31, 2021 at 12:24 AM Martijn Coenen wrote:
> >
> > On Mon, Aug 30, 2021 at 9:51 PM 'Todd Kjos' via kernel-team
> > wrote:
> > >
> > > During BC_FREE_BUFFER processing, the BINDER_TYPE_FDA object
> > > cleanup may close 1 or
On Mon, Aug 16, 2021 at 08:04:47PM +0200, Leon Krieg wrote:
> By doing some last-second wording changes directly in the diff I've
> screwed up and managed to use spaces instead of tabs for the Kconfig file.
> This is embarrassing!
>
> Signed-off-by: Leon Krieg
> ---
> drivers/staging/ks7010/Kcon
On Mon, Aug 16, 2021 at 07:55:03PM +0200, Leon Krieg wrote:
> Sorry to bother you with this low-effort patch but I'd really like to get
> my feet in the water and this whole process is making me nervous. I'd
> really appreciate you taking the time to look over this diff and
> hopefully I did not sc
The following changes since commit 2734d6c1b1a089fb593ef6a23d4b70903526fe0c:
Linux 5.14-rc2 (2021-07-18 14:13:49 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.14-rc5
for you to fetch changes up to c7b65650c7f4
On Fri, Jul 23, 2021 at 12:09:27AM +0300, vpuh1 wrote:
> Indented files in drivers/comedi directory using scripts/Lindent.
>
> Signed-off-by: Artem Baxtiarov
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manual
The following changes since commit 009c9aa5be652675a06d5211e1640e02bbb1c33d:
Linux 5.13-rc6 (2021-06-13 14:43:10 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.14-rc1
for you to fetch changes up to 77ad1f0e99bd
The following changes since commit 8124c8a6b35386f73523d27eacb71b5364a68c4c:
Linux 5.13-rc4 (2021-05-30 11:58:25 -1000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.13-rc6
for you to fetch changes up to e9de1ecadeab
The following changes since commit d07f6ca923ea0927a1024dfccafc5b53b61cfecc:
Linux 5.13-rc2 (2021-05-16 15:27:44 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.13-rc4
for you to fetch changes up to 54732a5322ff
On Sat, May 22, 2021 at 08:49:50PM +0900, tco0427 wrote:
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index e1a8f8b47edd..40d99644ddc7 100644
> ---
On Mon, May 17, 2021 at 11:02:58AM +0200, Mauro Carvalho Chehab wrote:
> Em Mon, 17 May 2021 10:18:57 +0200
> Greg KH escreveu:
>
> > On Sun, May 16, 2021 at 12:53:28PM +0200, Mauro Carvalho Chehab wrote:
> > > Hi Greg,
> > >
> > > This series add supp
On Sun, May 16, 2021 at 12:53:29PM +0200, Mauro Carvalho Chehab wrote:
> Some Intel Next Unit of Computing (NUC) machines have
> software-configured LEDs that can be used to display a
> variety of events:
>
> - Power State
> - HDD Activity
> - Ethernet
> - WiFi
> - Po
On Sun, May 16, 2021 at 12:53:28PM +0200, Mauro Carvalho Chehab wrote:
> Hi Greg,
>
> This series add support for the LEDs found at Intel NUCs since
> NUC version 6.
>
> On several NUC models, the function of the LEDs are programmable,
> which allow them to indicate several different hardware eve
The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:
Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.13-rc2
for you to fetch changes up to ba9c25d94dea
On Wed, Apr 28, 2021 at 12:28:44AM +0530, Jitendra wrote:
> On Tue, Apr 27, 2021 at 08:10:20PM +0200, Greg KH wrote:
> > On Tue, Apr 27, 2021 at 11:19:45PM +0530, Jitendra Khasdev wrote:
> > > This patch fixes sparse warning "array of flexible structures"
> &g
On Tue, Apr 27, 2021 at 11:19:45PM +0530, Jitendra Khasdev wrote:
> This patch fixes sparse warning "array of flexible structures"
> for rtllib.h.
>
> eg. drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of
> flexible structures
>
> Signed-off-by: Jitendra Khasdev
> ---
> drivers/stagin
On Mon, Apr 26, 2021 at 11:18:49AM -0700, Linus Torvalds wrote:
> On Mon, Apr 26, 2021 at 8:11 AM Greg KH wrote:
> >
> > Yeah, merge issues with other trees are hard to resolve in the single
> > tree here, not much I can just yet, have to wait for them to hit Linus's
>
On Tue, Apr 27, 2021 at 12:26:48AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Mon, 26 Apr 2021 14:46:10 +0200 Greg KH wrote:
> >
> > All of these have been in linux-next for a while with no reported
> > issues.
>
> There was just these:
>
The following changes since commit 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b:
Linux 5.12-rc4 (2021-03-21 14:56:43 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.12-rc6
for you to fetch changes up to e78836ae76d2
On Fri, Apr 02, 2021 at 09:05:01AM +, Carlis wrote:
> From: Xuezhi Zhang
>
> show() must not use snprintf() when formatting the value to
> be returned to user space.
Why not? The code is just fine as-is.
>
> Signed-off-by: Xuezhi Zhang
> ---
> drivers/staging/fbtft/fbtft-sysfs.c | 2 +-
On Thu, Apr 01, 2021 at 08:28:02PM +0800, Yongji Xie wrote:
> On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote:
> >
> > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote:
> > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote:
> > > >
> > > > On T
On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote:
> On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote:
> >
> > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote:
> > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote:
> > > >
> > > > On T
On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote:
> On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote:
> >
> > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote:
> > > Use receive_fd() to receive file from another process instead of
> > > combina
On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote:
> Use receive_fd() to receive file from another process instead of
> combination of get_unused_fd_flags() and fd_install(). This simplifies
> the logic and also makes sure we don't miss any security stuff.
But no logic is simplified here,
On Thu, Apr 01, 2021 at 05:09:30PM +0800, Xie Yongji wrote:
> This series starts from Christian's comments on the series[1].
> We'd like to export receive_fd() which can not only be used by
> our module in the series[1] but also allow further cleanups
> like patch 2 does.
But binder can not be a m
On Thu, Apr 01, 2021 at 05:09:31PM +0800, Xie Yongji wrote:
> Export receive_fd() so that some modules can use
> it to pass file descriptor across processes without
> missing any security stuffs.
>
> Signed-off-by: Xie Yongji
> ---
> fs/file.c| 6 ++
> include/linux/file.h | 7 ++
On Tue, Mar 23, 2021 at 02:05:23PM +0200, Eli Billauer wrote:
> On 22/03/21 13:11, Greg KH wrote:
> >
> > > XILLYBUS and XILLYBUS_PCIE are currently enabled as M in several Linux
> > > distributions. Making them depend on, rather than select XILLYBUS_CLASS is
> >
On Thu, Mar 25, 2021 at 03:46:10PM +0100, Jan Kiszka wrote:
> On 15.03.21 17:10, Rob Springer wrote:
> > Acked-by: Rob Springer
> >
> >
> > On Mon, Mar 15, 2021 at 8:44 AM wrote:
> >>
> >> From: Greg Kroah-Hartman
> >>
> >> As none of the proposed things that need to be changed in the gasket
>
On Thu, Mar 25, 2021 at 07:03:39PM +0800, Jian Dong wrote:
> On Thu, 25 Mar 2021 11:29:06 +0100
> Greg KH wrote:
>
> > On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote:
> > > From: Jian Dong
> > >
> > > fixes coccicheck Error:
> > >
On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote:
> From: Jian Dong
>
> fixes coccicheck Error:
>
> drivers/staging/greybus/bootrom.c:301:41-45: ERROR:
> fw is NULL but dereferenced.
>
> if procedure goto label directly, ret will be nefative, so the fw is NULL
> and the if(conditi
On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote:
> Fixed alignment of multi-line comment.
> Added a * for each line of the comment.
>
> Signed-off-by: Abhishek C
> ---
> drivers/android/binder.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers
On Tue, Mar 23, 2021 at 01:56:27PM +0100, Fabio Aiuto wrote:
> Fix extern declaration issues warned by checkpatch.
Nit, we have a new mailing list, you might want to use that now instead
of driverdev in the future, thanks!
greg k-h
___
devel mailing lis
On Tue, Mar 23, 2021 at 06:38:35AM +0530, Bhaskar Chowdhury wrote:
>
> s/netowrk/network/
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c
>
On Tue, Feb 09, 2021 at 11:13:47AM +0100, Christian Gromm wrote:
> This patch moves the ALSA sound driver out of the staging area and adds it
> to the stable part of the MOST driver. Modifications to the Makefiles and
> Kconfigs are done accordingly to not break the build.
>
> Signed-off-by: Chris
On Mon, Mar 22, 2021 at 09:14:43PM -0700, Randy Dunlap wrote:
> On 3/22/21 6:06 PM, Bhaskar Chowdhury wrote:
> >
> > s/procesing/processing/
> > s/comunication/communication/
> >
> > Signed-off-by: Bhaskar Chowdhury
>
> drivers/staging/wimax/ is in the process of being deleted.
It's already go
On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote:
> remove debug_priv argument so function prototype can be
> easily moved away
>
> Signed-off-by: Fabio Aiuto
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> dif
On Mon, Mar 22, 2021 at 03:31:42PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch issues:
>
> WARNING: externs should be avoided in .c files
> 1190: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:1190:
> +signed int validate_recv_mgnt_frame(struct adapter *padapter, union
> recv_frame
On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch issues:
>
> WARNING: externs should be avoided in .c files
> 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40:
> +u8 rtw_do_join(struct adapter *padapter);
>
> WARNING: externs should be avoided
On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch issues:
>
> WARNING: externs should be avoided in .c files
> 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35:
> +bool
>
> moved two function prototypes in include/rtw_efuse.h
>
> Signed-off-by: Fa
On Mon, Mar 22, 2021 at 03:31:49PM +0100, Fabio Aiuto wrote:
> remove unnecessary extern.
>
> The function is defined static in os_dep/os_intfs.c and used only once
> in the same file
>
> remove also a blank line
That needs to go to a separate patch :(
__
On Mon, Mar 22, 2021 at 12:58:08PM +0530, Bhaskar Chowdhury wrote:
>
> s/stoping/stooping/
Huh?
Are you _sure_ that is the correct replacement? Last I looked it
wasn't...
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.l
On Mon, Mar 22, 2021 at 01:01:54PM +0200, Eli Billauer wrote:
> Hello, Greg.
>
> Thanks for your comments. I'd like to address a couple of them.
>
> First, there's the lockless FIFO that is implemented in the driver:
>
> On 21/03/21 14:23, Greg KH wrote:
> >
On Mon, Mar 22, 2021 at 01:02:04PM +0200, Eli Billauer wrote:
> On 21/03/21 14:24, Greg KH wrote:
> > > +config XILLYBUS_CLASS
> > > > + tristate
> > > > +
> > > >config XILLYBUS
> > > > tristate "Xill
The following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0:
Linux 5.12-rc3 (2021-03-14 14:41:02 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.12-rc4
for you to fetch changes up to 2cafd46a714a
On Thu, Mar 11, 2021 at 11:50:32AM +0200, eli.billa...@gmail.com wrote:
> +EXPORT_SYMBOL(xillybus_init_chrdev);
Given the license for this code, perhaps EXPORT_SYMBOL_GPL()?
I have to ask :)
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverpro
On Thu, Mar 11, 2021 at 11:50:32AM +0200, eli.billa...@gmail.com wrote:
> From: Eli Billauer
>
> This patch is a preparation for adding another related driver, XillyUSB.
> In order to share some code between the existing Xillybus driver and the
> one to be added, some functions are moved to xilly
On Thu, Mar 11, 2021 at 11:50:33AM +0200, eli.billa...@gmail.com wrote:
> From: Eli Billauer
>
> The XillyUSB driver is the USB variant for the Xillybus FPGA IP core.
> Even though it presents a nearly identical API on the FPGA and host,
> it's almost a complete rewrite of the driver: The framewo
On Thu, Mar 18, 2021 at 08:05:27PM +, Paul McQuade wrote:
> prefer using ftrace
You need to say more here than just this please.
Also please fix up your subject line to have "staging:" in it, otherwise
it gets easily lost.
thanks,
greg k-h
___
dev
On Thu, Mar 18, 2021 at 04:38:37PM +0530, Akshith A V wrote:
> changed udelay to usleep_range
Trailing whitespace and odd line wrap :(
> because usleep_range is preferred over udelay by checkpatch.pl
>
> Signed-off-by: Akshith A V
> ---
> drivers/staging/rts5208/rtsx_chip.c | 2 +-
> 1 file c
On Thu, Mar 18, 2021 at 10:14:15AM +0100, Fabio Aiuto wrote:
> Hi,
>
> some suggestions before diving in a new task.
> The following checkpatch issue:
>
> --
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> #559: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:559:
> + DBG_871
On Wed, Mar 17, 2021 at 10:59:32AM +0100, Fabio Aiuto wrote:
> Hi,
>
> I'm trying to search other unused code blocks:
>
> grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_'
> drivers/staging/rtl8723bs/
>
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
> drivers/sta
On Mon, Mar 15, 2021 at 11:13:49AM +0100, Fabio Aiuto wrote:
> Remove unused code blocks as required in TODO file
>
> Fabio Aiuto (15):
> staging: rtl8723bs: remove unused code blocks conditioned by never set
> CONFIG_AUTO_AP_MODE
> staging: rtl8723bs: remove unused code blocks conditioned
On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote:
> remove conditional code blocks checked by unused CONFIG_PM
>
> cleaning required in TODO file:
>
> find and remove code blocks guarded by never set CONFIG_FOO defines
>
> Signed-off-by: Fabio Aiuto
> ---
> drivers/staging/rtl8723bs
On Mon, Mar 15, 2021 at 07:12:20PM +0800, Hao Peng wrote:
> Add one empty line upon return for easy reading.
Why? Is this really needed?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driver
On Mon, Mar 15, 2021 at 07:04:18PM +0800, Hao Peng wrote:
> Remove extra lines in rtl819x_BAProc.c.
>
> Signed-off-by: Hao Peng
Same issue here, please fix up the changelog text.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linu
On Mon, Mar 15, 2021 at 06:33:20PM +0800, Hao Peng wrote:
> Remove extra spaces in rtl819x_BAProc.c.
That says what you did, but not _why_ you are doing this.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what is needed in or
On Sun, Mar 14, 2021 at 09:58:55PM +0530, Shreya wrote:
> Fixed the indentation of the else part of the conditional statement.
>
> Signed-off-by: Shreya
> ---
> v1 -> v2:
> Changed name in signed-off-by to match name in From
No, change it the other way around, you had your "real" name in the
sig
On Tue, Mar 16, 2021 at 05:59:22PM +0800, zhaoxiao wrote:
> Remove extra lines in the struct r8192_private_args.
>
> Signed-off-by: zhaoxiao
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
> b/drivers/
1 - 100 of 4990 matches
Mail list logo
