Kalle Valo writes:
> Jes Sorensen writes:
>
>> Joe Perches writes:
>>> I think it'd be nicer to use dev_dbg for all these cases
>>> and as well use some new macro that includes the test
>>>
>>> Something like:
>>>
>>&g
Larry Finger writes:
> On 09/17/2016 03:59 PM, Jes Sorensen wrote:
>> Larry Finger writes:
>>> As soon as debugging is turned on, the logs are filled with messages
>>> reporting the interrupt status. As this quantity is usually zero, this
>>> output is not nee
Larry Finger writes:
> As soon as debugging is turned on, the logs are filled with messages
> reporting the interrupt status. As this quantity is usually zero, this
> output is not needed. In fact, there will be a report if the status is
> not zero, thus the debug line in question could probably b
Joe Perches writes:
> On Sat, 2016-09-17 at 12:09 -0500, Larry Finger wrote:
>> As soon as debugging is turned on, the logs are filled with messages
>> reporting the interrupt status. As this quantity is usually zero, this
>> output is not needed. In fact, there will be a report if the status is
>
Masahiro Yamada writes:
> Remove unneeded variables and assignments.
>
> While we are here, clean up the following as well:
> - refactor rtl8723a_get_bcn_valid() a bit
> - remove unneeded casts in sii164Get{Vendor,Device}ID()
>
> Signed-off-by: Masahiro Yamada
> ---
>
> drivers/staging/andro
On 09/12/16 09:58, Bhumika Goyal wrote:
> Relational and logical operators evaluate to either true or false.
> Explicit conversion is not needed so remove the ternary operator.
> Done using coccinelle:
>
> @r@
> expression A,B;
> symbol true,false;
> binary operator b = {==,!=,&&,||,>=,<=,>,<};
>
From: Jes Sorensen
Hi,
I sent Greg the full version of this patch, removing the old rtl8723au
driver. I didn't want to spam the list with a 2M+ patch so this is the
summary version.
Cheers,
Jes
This driver is superseded by rtl8xxxu and has been marked as scheduled
for deletion sinc
Joe Perches writes:
> On Tue, 2016-09-06 at 12:00 -0400, Jes Sorensen wrote:
>
>> Nothing wrong with these patches, however I intend to post a patch to
>> remove this driver soon, so it's kind of a waste of your time to spend
>> too many cycles on it.
>
> It
Matthias Beyer writes:
> This patchset fixes some errors and warnings reported by checkpatch.pl.
>
> Matthias Beyer (5):
> drivers: staging: rtl8723au: core: Fix checkpatch.pl errors
> drivers: staging: rtl8723au: core: simplify if-break-else
> drivers: staging: rtl8723au: core: Refactor poi
sunbing writes:
> On Aug 11, 2016, at 23:25, Jes Sorensen wrote:
>
>> Bing Sun writes:
>>> Fixed sparse parse error:
>>> Expected constant expression in case statement.
>>>
>>> Signed-off-by: Bing Sun
>>> ---
>>> drivers/stagi
Bing Sun writes:
> Fixed sparse parse error:
> Expected constant expression in case statement.
>
> Signed-off-by: Bing Sun
> ---
> drivers/staging/rtl8723au/os_dep/os_intfs.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/os_dep/os_
Shiva Kerdel writes:
> Fixed some coding style issues that were detected as errors.
>
> Signed-off-by: Shiva Kerdel
You have already been told this once by Greg. Describe what you are
fixing in the commit message, and don't fix more than one type of bug
per commit.
Jes
> ---
> drivers/staging
Baole Ni writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the ro
Stefan Lippers-Hollmann writes:
> Hi
>
> On 2016-07-20, Arnd Bergmann wrote:
>> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote:
>> > Arnd Bergmann writes:
>> > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote:
>> >
ion to clarify the types and simplify
> the check while removing the warning.
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/staging/rtl8192e/rtl819x_Qos.h| 3 ---
> drivers/staging/rtl8192e/rtl819x_TSProc.c | 5 +
> 2 files changed, 5 insertions(+), 3 deletions(-)
Lo
Arnd Bergmann writes:
> On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote:
>> Arnd Bergmann writes:
>> Well it really all depends on how much time I have and how much others
>> step up and help contribute to the code. For rtl8xxxu my plans are as
>> f
Colin King writes:
> From: Colin Ian King
>
> BT_Active and BT_State are being masked with 0x00ff so it the subsequent
> comparisons with 0x are therefore a buggy check. Instead, check them
> against 0x00ff.
>
> Unfortunately I couldn't find a datasheet or hardware to see if 0xff
Arnd Bergmann writes:
> On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote:
>> Arnd Bergmann writes:
>> I think that would be better, albeit not a big issue.
>
> Ok, and since Kalle applied the first patch to his tree, I'm now sending
> a series of three
Arnd Bergmann writes:
> On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote:
>> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c
>> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c
>> > index 2c8a526773ed..e0a2fe5e6148 100644
>> > --- a/dr
; 3 files changed, 11 insertions(+), 11 deletions(-)
Looks good to me
Acked-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Arnd Bergmann writes:
> Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of
> incorrect code that results from 'char' being unsigned here, e.g.
>
> staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always
> false due to limited range of data type [-Werror
Binoy Jayan writes:
> Hi,
>
> These are a set of patches which removes semaphores from:
>
> drivers/staging/rtl8723au
>
> These are part of a bigger effort to eliminate all semaphores
> from the linux kernel.
>
> They build correctly (individually and as a whole).
> NB: I have not tested this as
Greg KH writes:
> On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote:
>> > Ok, but still no need to put it under arch/ anything, it should go in
>> > drivers/ like all other drivers and busses are, no matter what the arch
>> > it happens to run on is.
>
Greg KH writes:
> On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote:
>> Greg KH writes:
>> > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote:
>> >> This patchset moves the visorbus driver
>> >> (fromdrivers/staging/unisys/visor
Greg KH writes:
> On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote:
>> This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus)
>> and its dependent headers files (from drivers/staging/unisys/include)
>> out of staging into the main kernel tree.
>>
>> The visorb
Jandy Gou writes:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-off-by: Jandy Gou
> ---
> drivers/sta
From: Jes Sorensen
Hi,
I think it is time to get rid of the vendor rtl8723au driver. I
haven't heard any complaints about rtl8xxxu not being able to support
the rtl8723au as well as the old driver.
To give users a little time to migrate and raise their voices, lets
start by marki
From: Jes Sorensen
This driver is deprecated and superseded by rtl8xxxu. It will be
removed in a future kernel release.
Add a warning to Kconfig and at device init time to notify users and
allow them time to switch over.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/Kconfig
tw_wlan_util.c | 10 --
> drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 2 --
> 2 files changed, 12 deletions(-)
Acked-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tl8723au/core/rtw_recv.c| 25 -
> drivers/staging/rtl8723au/include/rtw_recv.h | 2 --
> 2 files changed, 27 deletions(-)
Looks reasonable to me.
Acked-by: Jes Sorensen
Jes
> diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c
> b/drivers/stagi
Jandy Gou writes:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-off-by: Jandy Gou
> ---
> drivers/staging/
Xose Vazquez Perez writes:
> People should not waste time and energy working on this staging driver.
> A replacement(rtl8xxxu) using the kernel wireless stack already was merged
> in the 4.3 kernel.
>
> Cc: Jes Sorensen
> Cc: Larry Finger
> Cc: Kalle Valo
> Cc: Greg Kr
Julian Calaby writes:
> Hi Jandy,
>
> On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou
> wrote:
>> make C=1 M=drivers/staging/rtl8723au/
>>
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
>> restricted __le16
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast
Joe Perches writes:
> On Fri, 2016-03-18 at 13:42 -0400, Jes Sorensen wrote:
>> Xose Vazquez Perez writes:
>> > People should not waste time and energy working on this staging driver.
>> > A replacement(rtl8xxxu) using the kernel wireless stack already was me
David Kershner writes:
> Visordriver_probe_device gotos were messy, clean them up.
>
> Signed-off-by: David Kershner
> Signed-off-by: Timothy Sell
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drive
ariable bound on line 1620 cannot be NULL
>
> Signed-off-by: Cihangir Akturk
> ---
> drivers/staging/rtl8723au/core/rtw_mlme.c | 13 ++---
> 1 file changed, 2 insertions(+), 11 deletions(-)
Looks fine to me
Acked-by: Jes Sorensen
_
--
> 2 files changed, 22 insertions(+), 53 deletions(-)
This looks fine to me. When these changes gets large, it may be better
to break them down into multiple patches as it's easier to debug if
there is a bug somewhere.
Acked-by: Jes Sorensen
>
> diff --git a/drivers/sta
Geliang Tang writes:
> On Wed, Feb 17, 2016 at 12:28:33PM -0500, Jes Sorensen wrote:
>> kbuild test robot writes:
>> > All errors (new ones prefixed by >>):
>> >
>> >drivers/staging/rtl8723au/core/rtw_recv.c: In function
>> > 'rtw_fr
kbuild test robot writes:
> Hi Geliang,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.5-rc4 next-20160217]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the system]
>
> url:
> https://github.com/0day-ci/lin
Julian Calaby writes:
> Hi Geliang,
>
> On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang wrote:
>> This patch cleans whitespaces and blank lines surrounding
>> list_for_each_entry*().
>
> It does a lot more than this, including:
> - Removing some unnecessary brackets
> - Whitespace changes well awa
ing in v1.
> ---
> drivers/staging/rtl8723au/core/rtw_recv.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
I assume this requires patch 1/3 applied first?
Acked-by: Jes Sorensen
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c
> b/drivers/staging/rtl87
Geliang Tang writes:
> Use list_for_each_entry*() instead of list_for_each*() to simplify
> the code.
>
> Signed-off-by: Geliang Tang
> ---
> Changes in v3:
> - split it into three patches.
> Changes in v2:
> - drop the coding style fixing in v1.
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c
Geliang Tang writes:
> Use list_for_each_entry*() instead of list_for_each*() to simplify
> the code.
>
> Signed-off-by: Geliang Tang
> ---
> Changes in v2:
> - drop the coding style fixing in v1.
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 92
> ++-
> drive
Joe Perches writes:
> On Mon, 2016-02-01 at 07:29 -0500, Jes Sorensen wrote:
>> Joe Perches writes:
> []
>> > so this could be transformed into something like:
>> >
>> > int rtw_get_bit_value_from_ieee_value23a(u8 val)
>> > {
>>
Joe Perches writes:
> On Sun, 2016-01-31 at 09:36 -0500, Jes Sorensen wrote:
>> Rakhi Sharma writes:
>> > Fixed the space and brace coding style error.
>> > ERROR: space required before that '='
>> > ERROR: that open brace { should be on the previou
Geliang Tang writes:
> Use list_for_each_entry*() instead of list_for_each*() to simplify
> the code. Fix coding style by the way.
>
> Signed-off-by: Geliang Tang
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 166
> --
> drivers/staging/rtl8723au/core/rtw_mlme.
Rakhi Sharma writes:
> Fixed the space and brace coding style error.
> ERROR: space required before that '='
> ERROR: that open brace { should be on the previous line.
>
> Signed-off-by: Rakhi Sharma
> ---
> drivers/staging/rtl8723au/core/rtw_ieee80211.c | 4 ++--
> 1 file changed, 2 insertions(
Bhaktipriya Shridhar writes:
> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Bhaktipriya Shridhar
> ---
> Changes in v2:
>- Removed the unnecessary blank lines.
> drivers/staging/rtl8723a
Julian Calaby writes:
> Hi Bhaktipriya,
>
> On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen wrote:
>> Bhaktipriya Shridhar writes:
>> If you insist on pushing this rather unncessary change, please do it
>> properly, and remove the blank line before the return stateme
Bhaktipriya Shridhar writes:
> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Bhaktipriya Shridhar
> ---
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 --
> 1 file changed, 10 de
Julian Calaby writes:
> Hi Sven,
>
> On Tue, Jan 5, 2016 at 2:29 AM, Sven Dziadek wrote:
>> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> index 1662c03c..57f5941 100644
>> --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> +++ b
> .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 24
> drivers/staging/rtl8723au/hal/usb_halinit.c| 6 ++--
> 3 files changed, 15 insertions(+), 47 deletions(-)
Looks fine to me.
Acked-by: Jes Sorensen
_
Sven Dziadek writes:
> Remove byte order conversions.
> Conversion is already done in usb_ops_linux.c when accessing usb port.
> The deleted lines convert to little-endian and then call FillH2CCmd to
> convert back. Additionally, they are applied to wrong types and
> process wrong parts of variabl
; Signed-off-by: Luis de Bethencourt
> ---
> drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jes Sorensen
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> b/drivers/staging/rtl8723au/core/rtw_w
Larry Finger writes:
> On 10/23/2015 05:44 AM, Xose Vazquez Perez wrote:
>> Hi,
>>
>> Support for RTL8723AU devices was added to
>> wireless-drivers-next.git recently:
>> https://marc.info/?l=linux-wireless&m=144541406318463
>> commit:
>> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless
Jacob Kiefer writes:
> From: Jacob Kiefer
>
> Changed rssi_cmd interface to accept le32 param instead of
> unnecessary u8 * conversion. Updated existing calls to rssi_cmd.
> This patch pushes responsibility to caller to convert to
> le32. This cleans up the code quite a bit.
> Also removed magic
Mateusz Kulikowski writes:
> Firmware was not released properly if kmemdup fails.
>
> Addresses-Coverity-Id: 1269118
> Signed-off-by: Mateusz Kulikowski
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
A
Pinkesh Badjatiya writes:
> Removed trailing spaces.
> Fixed some errors from checkpatch.pl verification.
> No changes made to actual functional code.
>
> Signed-off-by: Pinkesh Badjatiya
> ---
> drivers/staging/rtl8723au/include/rtw_cmd.h | 162
> ++--
> 1 file changed,
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 46 ++---
1 file changed, 19 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
From: Jes Sorensen
This eliminates the ugly Hal_EEValueCheck() function
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 42 ++-
1 file changed, 11 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c
b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c
index
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 27 +++--
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
From: Jes Sorensen
Hi,
Reading through some of the rate setup code, I was forced to clean up
some of the components to be able to read it properly.
Cheers,
Jes
Jes Sorensen (6):
staging: rtl8723au: Simplify eeprom content checking
staging: rtl8723au: Eliminate dummy ccxPowerIndexCheck
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 32 +
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c
b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
index 7fa9780..8764538 100644
--- a
Michał Bartoszkiewicz writes:
> The values passed to le32_to_cpu are already in the correct byte order.
> This fixes four "cast to restricted __le32" sparse warnings.
>
> Signed-off-by: Michał Bartoszkiewicz
> ---
> drivers/staging/rtl8723au/core/rtw_security.c | 8
> 1 file changed, 4
Luca Ceresoli writes:
> Signed-off-by: Luca Ceresoli
> Cc: Greg Kroah-Hartman
> Cc: Jes Sorensen
> Cc: Larry Finger
> ---
> drivers/staging/rtl8723au/include/rtw_cmd.h | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Jes Sorensen
-
> 1 file changed, 2 insertions(+), 5 deletions(-)
Works for me
Acked-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Sudip Mukherjee writes:
> On Tue, Aug 25, 2015 at 08:33:55AM -0400, Jes Sorensen wrote:
>> Sudip Mukherjee writes:
>> > On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote:
>> >> In cases where visorbus is compiled directly into the kernel, if
>> &g
Sudip Mukherjee writes:
> On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote:
>> In cases where visorbus is compiled directly into the kernel, if
>> visorbus registration fails for any reason, it is still possible for
>> other drivers to call visorbus_register_visor_driver(), which cou
it.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Johannes Postma writes:
> On 06/08/15 at 08:21am, Jes Sorensen wrote:
>>
>> Looks OK to me. Probably worth changing the *(usPtr + index) to be
>> usPtr[index] as well to make the code easier to read.
>>
>> Jes
>>
>
> Thank you for reviewing. I
Johannes Postma writes:
> usPtr is used as __le16 *, but was defined as u16 *.
> This was reported by sparse as:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1850:29: warning: cast to
> restricted __le16
>
> This patch fixes the type of usPtr.
>
> Signed-off-by: Johannes Postma
> ---
> dr
Ting-Chih Hsiao writes:
> remove spaces at the start of a line
> align enum variable with other parameters
>
> Signed-off-by: Ting-Chih Hsiao
Acked-by: Jes Sorensen
> ---
> drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 2 +-
> 1 file changed, 1 insertion(+), 1
"Joglekar, Tejas (T.)" writes:
> From: Joglekar Tejas
>
> This patch fixes the error given by checkpatch.pl
>
> Signed-off-by: Joglekar Tejas
> ---
> drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723au/co
Steve Pennington writes:
> Repaced calls to htons and memcpy with a single call to put_unaligned_be16
You may want an 'l' in replaced, but not a biggie to me.
> to fix the following sparse warning:
> drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in
> assignment (dif
Steve Pennington writes:
> Repaced call to htons with call to cpu_to_be16s to fix the
> following sparse warning:
> drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in
> assignment (different base types)
> drivers/staging/rtl8723au/core/rtw_recv.c:1557:21:expected un
"Kershner, David A" writes:
>> -Original Message-
>> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>> Sent: Wednesday, July 15, 2015 8:16 AM
>> To: Romer, Benjamin M
>> Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org;
>> jes.soren...@redhat.com; *S-Par-Mainta
Michel von Czettritz writes:
> On 07/01/2015 10:31 PM, Jes Sorensen wrote:
>> Michel von Czettritz writes:
>>> Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
>>> cast and results in an sparse warning.
>>>
>>> Since param and ma
Dan Carpenter writes:
> On Tue, Jun 30, 2015 at 11:54:02PM +0200, Michel von Czettritz wrote:
>> Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
>> cast and results in an sparse warning.
>>
>> Since param and mask won't be changed, the implicit cast can be avoided
>> by crea
Michel von Czettritz writes:
> Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
> cast and results in an sparse warning.
>
> Since param and mask won't be changed, the implicit cast can be avoided
> by creating local variables.
>
> Signed-off-by: Michel von Czettritz
> ---
>
David Decotigny writes:
> The code shows a couple inconsistencies (described in commit
> descriptions) which would not be an issue on little-endian cpus, but
> could cause breakage on non-LE cpus. Note: I could not test on real
> hardware, these patches created based on sparse reports.
>
> Hostory
1 deletion(-)
Looks straight forward.
Acked-by: Jes Sorensen
Jes
> diff --git a/drivers/staging/rtl8723au/hal/odm.c
> b/drivers/staging/rtl8723au/hal/odm.c
> index f354f5e..6b9dbef 100644
> --- a/drivers/staging/rtl8723au/hal/odm.c
> +++ b/drivers/staging/rtl8723au/hal/odm.c
> @@
"Kershner, David A" writes:
>> -Original Message-
>> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>> Sent: Friday, June 19, 2015 8:55 AM
>> To: Kershner, David A
>> Cc: gre...@linuxfoundation.org; jes.soren...@redhat.com; *S-Par-
>> Maintainer; driverdev-devel@linuxdriverproject.o
Sudip Mukherjee writes:
> On Mon, Jun 15, 2015 at 11:30:41AM +0200, Daniele Alessandrelli wrote:
>> On June 15, 2015 7:47:41 AM GMT+02:00, Sudip Mukherjee
>> wrote:
>> >On Sun, Jun 14, 2015 at 11:26:35PM +0200, Daniele Alessandrelli wrote:
>>
>> >> - u16 Signature; /* 92C0: test chip; 92C, 88C0:
itions */
> u16 Version;/* FW Version */
> u8 Subversion; /* FW Subversion, default 0x00 */
> - u16 Rsvd1;
> + u8 Rsvd1;
I had to look through this one a bit
Nicholas Mc Guire writes:
> On Sat, 13 Jun 2015, Jes Sorensen wrote:
>
>> Nicholas Mc Guire writes:
>> > scanning for trivial bug-patters with coccinelle spatches returned:
>> > ./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395
>> >WARNING: cond
Nicholas Mc Guire writes:
> scanning for trivial bug-patters with coccinelle spatches returned:
> ./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395
> WARNING: condition with no effect (if branch == else)
>
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c - line numbers from 4.1-rc7
Luca Ceresoli writes:
> The is_valid_p2p_probereq is never referenced in the function body.
>
> Signed-off-by: Luca Ceresoli
> Cc: Greg Kroah-Hartman
> Cc: Jes Sorensen
> Cc: Larry Finger
> ---
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 8 +++-
> 1 file
Fabian Frederick writes:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick
> ---
> drivers/staging/rtl8723au/core/rtw_wlan_util.c | 12 +++-
> 1 file changed, 3 insertions(+), 9 deletions(-)
Please make sure
Sudip Mukherjee writes:
> On Thu, Jun 04, 2015 at 09:22:36AM -0400, Benjamin Romer wrote:
>> This patch set contains the remaining changes from our driver cleanup
>> efforts. No functional changes have been made, only a rebase so that the
>> patches would apply.
> Hi,
> its not related to your thi
Sudip Mukherjee writes:
> On Thu, Jun 04, 2015 at 09:22:45AM -0400, Benjamin Romer wrote:
>> From: David Kershner
>>
>> Diagchannel.h is used primarily for the diagnostics channel. The
>> diagnostics channel is not being used by linux guests currently, so
>> the majority of the file is not neede
Juston Li writes:
> change cast to __le16 to fix the following warning:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to
> restricted __le16
>
> Signed-off-by: Juston Li
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
> 1 file changed, 1 insertion(
tolga ceylan writes:
> On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
>> visorchipset_file_init() and visorchipset_file_cleanup() functions
>> do not seem to be used from anywhere else and now are declared
>> as static. Sparse emitted "not declared" warnings for these two
>> functions.
>>
>> Signed-o
Wim de With writes:
> This is a patch that fixes the function declarations in
> visorbus/visorchipset.c by removing newlines after the function return
> type
This patch doesn't fix things, it makes things worse!
If you want to post patches to this, do it properly and check the output
first.
NAC
"Gujulan Elango, Hari Prasath (H.)" writes:
> On Thu, May 07, 2015 at 10:09:59AM -0400, Jes Sorensen wrote:
>> "Gujulan Elango, Hari Prasath (H.)" writes:
>> > On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
>> >> On Thu, Ma
t; 1 file changed, 1 insertion(+), 1 deletion(-)
Looks fine to me
Acked-by: Jes Sorensen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Joe Perches writes:
> On Thu, 2015-05-07 at 10:08 -0400, Jes Sorensen wrote:
>> Dan Carpenter writes:
>> > On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
>> >> NACK!
>> > SHOUTING!
>> It's normal to write NACK in upper case
>
&g
"Gujulan Elango, Hari Prasath (H.)" writes:
> On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
>> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
>> > "Gujulan Elango, Hari Prasath (H.)" writes:
>> > > Remove the
Dan Carpenter writes:
> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
>> "Gujulan Elango, Hari Prasath (H.)" writes:
>> > Remove the goto and return error directly thereby removing a variable
>> >
>> > Signed-off-by: Hari Prasath
1 - 100 of 745 matches
Mail list logo
