[PATCH] staging: r8188eu: Add new USB ID

2014-08-24 Thread Larry Finger
The Elecom WDC-150SU2M uses this chip. Reported-by: Hiroki Kondo komp...@gmail.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers

Re: [PATCH] staging: rtl8723au: Fix static symbol sparse warning

2014-08-01 Thread Larry Finger
On 08/01/2014 08:06 AM, Miguel Oliveira wrote: Fix sparse warning: drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol 'efuse_GetCurrentSize23a' was not declared. Should it be static? Signed-off-by: Miguel Oliveira cmro...@gmail.com ---

Re: Realtek RTL8821ae driver

2014-07-21 Thread Larry Finger
On 07/21/2014 09:10 PM, Greg KH wrote: On Mon, Jul 21, 2014 at 08:50:26PM -0400, Chris Murphy wrote: Problem: On Asus TX201LA running 15.6 kernel x86_64, driver repeatedly disconnects and reconnects. Dual boot same machine on Win 8.1 is very stable. Behavior starts as soon as Linux is booted

[PATCH V2] staging: rtl8192ee: Fix setting highest n rate

2014-07-16 Thread Larry Finger
that the TX MCS map will equal 0x0c, thus the second test can be ignored. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- V2 - Remove extraneous parenthesis drivers/staging/rtl8192ee/base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192ee

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-21 Thread Larry Finger
On 06/20/2014 09:52 PM, Nick Krause wrote: Is this patch being merged or is this not an issue. I am confused did I make a mistake in my patch or is there being a different patch being merged. Thank Nick On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches j...@perches.com wrote: On Fri, 2014-06-20 at

Re: Fwd: Re: Anybody working on rtl8712?

2014-06-21 Thread Larry Finger
On 06/21/2014 12:52 PM, Christian Lamparter wrote: On Saturday, June 21, 2014 06:45:07 PM Kristina Martšenko wrote: On 20/06/14 23:52, Christian Lamparter wrote: On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote: Kristina wrote: I'm helping Greg do a bit of cleanup in the

Re: Anybody working on rtl8712?

2014-06-20 Thread Larry Finger
On 06/20/2014 10:40 AM, Kristina Martšenko wrote: Hi Larry and Florian, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving rtl8712 out of staging in over a year. Are there any plans to clean it up and move it out soon? Because

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Larry Finger
On 06/09/2014 10:39 AM, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I

Re: [PATCH linux-next] staging: r8192ee: Adapt flush function prototype

2014-06-07 Thread Larry Finger
...@laposte.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Larry Finger larry.fin...@lwfinger.net Ah yes, all the benefits of adding a new driver in one tree (staging) that depends of changes in another (wireless). I have been maintaining this patch in my own source for several weeks

Re: randconfig build error with next-20140527, in drivers/staging/rtl8192ee

2014-05-27 Thread Larry Finger
42e4c20f114c71e12cdf35d9b5dd60d2546c7d57 yesterday in staging-next. If it has not reached linux-next, the attached patch should fix the problem. Thanks, Larry From d10ca90ffaf99f43bb61d5b4001f6a6acfde3454 Mon Sep 17 00:00:00 2001 From: Larry Finger larry.fin...@lwfinger.net Date: Mon, 26 May 2014 13

Re: [staging: r8192ee] WARNING: CPU: 0 PID: 1 at net/mac80211/rate.c:43 ieee80211_rate_control_register()

2014-05-26 Thread Larry Finger
On 05/26/2014 09:55 AM, Jet Chen wrote: Jet, 0day kernel testing robot got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next commit 0629f3b8c33899140b48d5897259eab8ebae78ca Author: Larry Finger larry.fin

Re: [PATCH 4/4] staging: r8192ee: Turn on build of the new driver

2014-05-26 Thread Larry Finger
On 05/26/2014 01:06 PM, Ben Hutchings wrote: On Wed, 2014-05-21 at 16:25 -0500, Larry Finger wrote: [...] --- /dev/null +++ b/drivers/staging/rtl8192ee/Kconfig @@ -0,0 +1,8 @@ +config R8192EE + tristate Realtek RTL8192EE Wireless Network Adapter depends on MAC80211 PCI (at least

[PATCH 3/3] staging: r8821ae: Fix potential problem with rate control registration

2014-05-26 Thread Larry Finger
The zero day testing facility reported a problem with duplicate registration of the rate-control algorithm. Although not yet reported, this driver needs the same fix. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8821ae/rc.c | 2 +- 1 file changed, 1 insertion

[PATCH 1/3] staging: r8192ee: Fix kernel WARN splat associated with rate control

2014-05-26 Thread Larry Finger
name is used for the rtlwifi drivers in the regular wireless tree, and the staging drivers r8192ee and r8821ae. The fix is to rename the algorithm used in r8192ee. Reported-by: Jet Chen jet.c...@intel.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Tested-by: Jet Chen jet.c...@intel.com

[PATCH 2/3] staging: r8192ee: Fix build errors when PCI is not available

2014-05-26 Thread Larry Finger
-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8192ee/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/rtl8192ee/Kconfig b/drivers/staging/rtl8192ee/Kconfig index 92c5f44..beb07ac2 100644 --- a/drivers/staging/rtl8192ee/Kconfig +++ b

[PATCH 0/4] New driver for Realtek RTL8192EE

2014-05-21 Thread Larry Finger
, and the problems have been fixed. The code needs additional polishing before it can be merged into the regular wireless tree; however, that should not take more than a single cycle. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (4): staging: r8192ee: Add source files for core driver

Re: [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-05-20 Thread Larry Finger
On 05/20/2014 04:31 PM, Rickard Strandqvist wrote: There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

New driver for Realtek RTL8192EE

2014-05-16 Thread Larry Finger
Greg, This E-mail is to prepare you for a new Realtek RTL8192EE driver that I intend to submit early next week. I hope it will be in time for kernel 3.16. This device is incorporated in the recently introduced Lenovo T440s tablet, and from the correspondence that I have received, there have

Re: [PATCH 1/5] staging: rtl8188eu: fix potential leak in rtw_wx_read32()

2014-04-28 Thread Larry Finger
Engelmayer cenge...@gmx.at Acked-by: Larry Finger larry.fin...@lwfinger.net This Ack is valid for all 5 patches. Larry --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread Larry Finger
On 04/22/2014 09:14 AM, Dan Carpenter wrote: On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote: Hi dan it's just a cleanup patch and i also tested all patches of this patch series on the hardware (TP-LINK TL-WN723N). my mistake i should have added Tested-by tag for all patches.

[PATCH] staging: r8188eu: Fix some sparse warnings

2014-04-17 Thread Larry Finger
'process_pwrbit_data' was not declared. Should it be static? drivers/staging/rtl8188eu/core/rtw_recv.c:1828:5: warning: symbol 'enqueue_reorder_recvframe' was not declared. Should it be static? Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net

[PATCH 1/2 V2] staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0

2014-04-16 Thread Larry Finger
Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparison against eapol_type would always fail. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org

[PATCH 2/2 V2] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-16 Thread Larry Finger
Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparison against eapol_type would always fail. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org

Re: [PATCH] staging: r8723au: Add missing initialization of change_inx in sort algorithm

2014-04-10 Thread Larry Finger
on the stack, the array may not be sorted correctly. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- Acked-by: Larry Finger larry.fin...@lwfinger.net Geert, Thanks for this. I wonder why my gcc on x86_64 did not flag this problem. Larry drivers/staging/rtl8723au/core/rtw_wlan_util.c |2

[PATCH 3/3] staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0

2014-04-09 Thread Larry Finger
Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparition against eapol_type would always fail. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org

[PATCH 0/3] Fix some bugs in staging drivers

2014-04-09 Thread Larry Finger
While analyzing parts of the recently merged r8723au driver, Jes Sorensen found two bugs that are found in other Reaktek drivers in staging. This set of patches fixes them. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (3): staging: r8188eu: Calling rtw_get_stainfo

[PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-09 Thread Larry Finger
Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparition against eapol_type would always fail. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org

Re: staging-next: r8723au: Kconfig related nitpicks

2014-04-07 Thread Larry Finger
On 04/07/2014 04:08 AM, Paul Bolle wrote: Larry, 0) I stumbled on two minor Kconfig related issues in the r8723au driver in staging-next. 1) drivers/staging/rtl8723au/include/drv_types.h Why is CONFIG_BR_EXT used? I couldn't find a Kconfig symbol BR_EXT nor a preprocessor define for

[PATCH] staging: r8723au: Fix build problem when RFKILL is not selected

2014-04-06 Thread Larry Finger
. My suspicion is that this particular error is caused by a kbuild bug, or that the selection of INPUT by ACPI_CMPC is wrong. In any case, that will be solved separately. Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen

[PATCH] staging: r8188eu: fix coccinelle warnings

2014-03-16 Thread Larry Finger
From: Fengguang Wu fengguang...@intel.com drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8030:3-9: Replace memcpy with struct assignment Generated by: coccinelle/misc/memcpy-assign.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net

[PATCH] staging: r8188eu: Add new device ID

2014-02-24 Thread Larry Finger
From: Manu Gupta manugu...@gmail.com The D-Link DWA-123 REV D1 with USB ID 2001:3310 uses this driver. Signed-off-by: Manu Gupta manugu...@gmail.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-16 Thread Larry Finger
On 02/15/2014 02:41 PM, Greg KH wrote: On Sat, Feb 15, 2014 at 12:38:11PM -0800, Greg KH wrote: I've applied this series up to here. Nevermind, the others applied, so I've merged them, just not this patch. I have split this patch into two parts that I will send tomorrow. The first one just

Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-15 Thread Larry Finger
On 02/15/2014 04:41 AM, Dan Carpenter wrote: On Fri, Feb 14, 2014 at 04:54:14PM -0600, Larry Finger wrote: diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c index 1fa5370..d5f6a32 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 02/13] staging: r8188eu: Remove pointless alignment entry in recv_frame

2014-02-14 Thread Larry Finger
This alignment entry in union recv_frame does nothing. It certainly dues not ensure alignment. Suggested-by: jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: jes.soren...@redhat.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - 1 file changed, 1

[PATCH 00/13] Cleanups for r8188eu

2014-02-14 Thread Larry Finger
the disk file every time the device reinits. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (12): staging: r8188eu: Remove unnecessary list_head entry from recv_frame union staging: r8188eu: Remove pointless alignment entry in recv_frame staging: r8188eu: Remove

[PATCH 04/13] staging: r8188eu: Remove pkt_to_recv{frame, data, mem} routines

2014-02-14 Thread Larry Finger
These functions are not called from the outside source. Suggested-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 38 1 file

[PATCH 01/13] staging: r8188eu: Remove unnecessary list_head entry from recv_frame union

2014-02-14 Thread Larry Finger
Struct recv_frame_hdr already contains a list head. This one is pointless. Suggested-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/core/rtw_recv.c| 7 --- drivers

[PATCH 05/13] staging: r8188eu: Remove unused get_rxbuf_desc()

2014-02-14 Thread Larry Finger
Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/include

[PATCH 06/13] staging: r8188eu: Remove get_recvframe_len()

2014-02-14 Thread Larry Finger
This simple routine is replaced by a simple access of the len member. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +- drivers/staging

[PATCH 09/13] staging: r8188eu: Remove wrapper _exit_critical_mutex()

2014-02-14 Thread Larry Finger
This wrapper is a simple call to mutex_exit(). Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 7 --- drivers

[PATCH 13/13] staging: r8188eu: Make firmware buffer persistent

2014-02-14 Thread Larry Finger
From: Stas Sergeev s...@users.sourceforge.net The present code reloads the firmware file from the disk every time the interface re-inits. Change to hold the firmware in memory, and only download to the device. Signed-off-by: Stas Sergeev s...@users.sourceforge.net Signed-off-by: Larry Finger

[PATCH 07/13] staging: r8188eu: Remove get_recvframe_data()

2014-02-14 Thread Larry Finger
...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/core/rtw_recv.c | 6 ++ drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +- drivers/staging/rtl8188eu/include/rtw_recv.h| 9 - 3 files

[PATCH 11/13] staging: r8188eu: Remove wrapper routine _init_workitem()

2014-02-14 Thread Larry Finger
This is simply another name for INIT_WORK(). Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- drivers/staging/rtl8188eu/core/rtw_led.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 6 -- 3 files changed

[PATCH 08/13] staging: r8188eu: Remove unused union

2014-02-14 Thread Larry Finger
Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/rtw_xmit.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_xmit.h b/drivers/staging/rtl8188eu/include/rtw_xmit.h index 1ac1dd3..62f5db1 100644 --- a/drivers

[PATCH 12/13] staging: r8188eu: Remove wrapper routine _set_workitem()

2014-02-14 Thread Larry Finger
This is simply a wrapper around schedule_work(). Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_led.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers

[PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

2014-02-14 Thread Larry Finger
This wrapper returned the result of mutex_lock_interruptible(); however, none of the callers checked the returned value. As a result of a gcc upgrade to version 4.8.1, two false unitialized variable warnings appeared. To silence the warnings, they are initialized to 0. Signed-off-by: Larry

[PATCH] staging: r8188eu: Fix Smatch warnings

2014-02-12 Thread Larry Finger
here is one remaining buffer overflow message that I believe to be an error in Smatch. These warnings were reported by the 0-DAY kernel build testing backend. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 32

[PATCH] staging: r8188eu: Fix more Smatch warnings and errors

2014-02-12 Thread Larry Finger
' could be null (see line 4469) Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_recv.c | 7 +++ drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 18 +- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging

[PATCH] staging: rtl8821ae: Fix potential infinite loop

2014-02-12 Thread Larry Finger
Smatch reports the following: drivers/staging/rtl8821ae/rtl8821ae/hw.c:153 _rtl8821ae_set_fw_clock_on() info: ignoring unreachable code. Upon investigation, the code in this region has the capability of creating an infinite loop. Signed-off-by: Larry Finger larry.fin...@lwfinger.net

Re: [PATCH 1/2] drivers:staging:rtl8821ae: Fixed few coding style erors and warnings

2014-02-09 Thread Larry Finger
, it will be submitted to the drivers/net/wireless tree of the regular kernel, and it should be there by 3.15. That said, Acked-by: Larry Finger larry.fin...@lwfinger.net Larry --- drivers/staging/rtl8821ae/wifi.h | 450 --- 1 file changed, 226 insertions(+), 224

Re: [PATCH 2/2] vers:staging:rtl8821ae: Fixed multiple coding style erors and warnings

2014-02-09 Thread Larry Finger
On 02/09/2014 01:30 AM, Surendra Patil wrote: Fixed multiple coding style errors and warnings wifi.h:1077: WARNING: please, no space before tabs wifi.h:762: WARNING: missing space after struct definition wifi.h:972: WARNING: please, no spaces at the start of a line wifi.h:1825: WARNING:

Re: [PATCH] drivers:statging:rtl8821ae Fixed few coding style errors

2014-02-09 Thread Larry Finger
On 02/09/2014 02:29 AM, Surendra Patil wrote: Fixed few coding style errors in header files base.h:58: WARNING: please, no space before tabs base.h:81: ERROR: (foo*) should be (foo *) pci.h:338: ERROR: foo * bar should be foo *bar pci.h:151: ERROR: do not use C99 // comments Signed-off-by:

[PATCH 0/6] Various cleanups of r8188eu

2014-02-09 Thread Larry Finger
As has been noted, this driver is very rough. This set of patches is intended to smooth some of the rough edges. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (6): staging: r8188eu: Replace wrapper around _rtw_memcmp() staging: r8188eu: Remove dead file staging

[PATCH 3/6] staging: r8188eu: Remove some dead code from headers

2014-02-09 Thread Larry Finger
The headers for this driver contain a number of unused structs and macros that are removed. File include/ioctl_cfg80211.h is now empty and was deleted. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/ioctl_cfg80211.h | 107

[PATCH] staging: r8188eu: Fix missing header

2014-02-07 Thread Larry Finger
. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 + drivers/staging/rtl8188eu/core/rtw_mp.c| 1 + drivers/staging/rtl8188eu/core/rtw_recv.c | 1 + drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 1 + drivers/staging/rtl8188eu

Re: [PATCH] staging: r8188eu: Fix missing header

2014-02-07 Thread Larry Finger
On 02/07/2014 06:04 PM, Greg KH wrote: On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote: Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled staging: r8188eu: Remove wrappers around vmalloc and vzalloc and commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled staging

[PATCH V2] staging: r8188eu: Fix missing header

2014-02-07 Thread Larry Finger
. This problem was reported by the kbuild test robot. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- V2 - add attribution to the build robot --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 + drivers/staging/rtl8188eu/core/rtw_mp.c| 1 + drivers/staging/rtl8188eu/core

[PATCH 08/12] staging: r8188eu: Remove wrappers around vfree

2014-02-06 Thread Larry Finger
Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 5 ++--- drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2

[PATCH 11/12] staging: r8188eu: Remove ODM_SetTimer

2014-02-06 Thread Larry Finger
This wrapper is not used. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 5 - drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c

[PATCH 12/12] staging: r8188eu: Remove ODM_InitializeTimer

2014-02-06 Thread Larry Finger
This wrapper is not used. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 8 drivers/staging/rtl8188eu/include/odm_interface.h | 4 2 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 05/12] staging: r8188eu: Remove ODM_Write2Byte

2014-02-06 Thread Larry Finger
This routine is the equivalent of rtw_write16. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 +++- drivers/staging/rtl8188eu/hal/odm_interface.c| 6 -- drivers/staging/rtl8188eu/include/odm_interface.h| 2 -- 3

Re: [patch 1/2] staging: r8188eu: array overflow in rtw_mp_ioctl_hdl()

2014-02-06 Thread Larry Finger
On 02/03/2014 04:38 PM, Dan Carpenter wrote: MAX_MP_IOCTL_SUBCODE (35) and mp_ioctl_hdl (32 elements) are no longer in sync. It leads to a bogus pointer dereference. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Larry Finger larry.fin...@lwfinger.net Larry diff --git

[PATCH 06/12] staging: r8188eu: Remove ODM_Write4Byte

2014-02-06 Thread Larry Finger
This routine is the equivalent of rtw_write32. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 2 +- drivers/staging/rtl8188eu/hal/odm_interface.c | 7 --- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 3 files

[PATCH 09/12] staging: r8188eu: Remove ODM_AllocateMemory

2014-02-06 Thread Larry Finger
This wrapper for vzalloc() is not used. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 00/12] Remove several pointless wrapper routines

2014-02-06 Thread Larry Finger
The driver contains a large number of wrapper routines. None of them are needed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (12): staging: r8188eu: Remove ODM_Read1Byte staging: r8188eu: Remove ODM_Read2Byte staging: r8188eu: Remove ODM_Read4Byte staging: r8188eu

[PATCH 01/12] staging: r8188eu: Remove ODM_Read1Byte

2014-02-06 Thread Larry Finger
This is essentially a synonym for rtw_read8. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 6 +++--- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 3 files

[PATCH 10/12] staging: r8188eu: Remove ODM_CompareMemory

2014-02-06 Thread Larry Finger
This routine is a wrapper for _rtw_memcmp(), which is a wrapper for memcmp. In a later change, _rtw_memcmp will be removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++-- drivers/staging/rtl8188eu/hal/odm_interface.c | 5

[PATCH 02/12] staging: r8188eu: Remove ODM_Read2Byte

2014-02-06 Thread Larry Finger
This routine is never used. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

Re: rtl8821ae.

2014-02-04 Thread Larry Finger
On 02/04/2014 08:41 AM, Andrea Merello wrote: Yes, I attach a cumulative patch for latest version of my work. When I will send this asking for merge in kernel, I will split it in some patches, because I also also included fix and improvements for other already supported cards (not directly

Re: rtl8821ae.

2014-02-03 Thread Larry Finger
On 02/02/2014 12:07 PM, Stefan Lippers-Hollmann wrote: Hi [ CC'ing the relevant parties ] On Sunday 02 February 2014, Dave Jones wrote: On Sun, Feb 02, 2014 at 03:41:27AM -0800, scan-ad...@coverity.com wrote: Please find the latest report on new defect(s) introduced to Linux found with

[PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

2014-02-02 Thread Larry Finger
There is a typo in the device list that interchanges the vendor and product codes for one of the entries. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

2014-02-02 Thread Larry Finger
On 02/02/2014 03:04 PM, Randy Dunlap wrote: On 02/02/2014 12:07 PM, Larry Finger wrote: There is a typo in the device list that interchanges the vendor and product codes for one of the entries. You also changed 0x7b8 to 0x7bb. Did you mean to do that? No, I did not. Thanks for catching

Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

2014-02-02 Thread Larry Finger
On 02/02/2014 03:26 PM, Greg KH wrote: On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote: There is a typo in the device list that interchanges the vendor and product codes for one of the entries. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu

Re: [patch] staging: r8821ae: a couple macro expansion bugs

2014-01-28 Thread Larry Finger
On 01/28/2014 09:01 AM, Greg Kroah-Hartman wrote: On Tue, Jan 28, 2014 at 05:46:30PM +0300, Dan Carpenter wrote: On Tue, Jan 28, 2014 at 03:14:21PM +0100, walter harms wrote: Am 28.01.2014 15:00, schrieb Dan Carpenter: These macros need parentheses, otherwise it causes a macro expansion bug

Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues

2014-01-02 Thread Larry Finger
On 01/02/2014 11:03 AM, Tim Jester-Pfadt wrote: Fixed indentation coding style issues on rtw_io.c Signed-off-by: Tim Jester-Pfadt t...@gmx.de --- drivers/staging/rtl8188eu/core/rtw_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] Staging: rtl8188eu: Fixed coding style issues

2014-01-02 Thread Larry Finger
On 01/02/2014 02:46 PM, Tim Jester-Pfadt wrote: Fixed indentation coding style issues on rtw_io.c Signed-off-by: Tim Jester-Pfadt t...@gmx.de --- drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 31/31] staging: r8188eu: Fix smatch error

2014-01-02 Thread Larry Finger
On 01/02/2014 02:44 AM, Dan Carpenter wrote: On Sun, Dec 22, 2013 at 05:37:02PM -0600, Larry Finger wrote: Smatch shows the following: CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer overflow 'pstapriv

Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues

2013-12-30 Thread Larry Finger
deletions(-) Acked-by: Larry Finger larry.fin...@lwfinger.net Larry diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h index eb6f0e5..3d1dfcc 100644 --- a/drivers/staging/rtl8188eu/include/rtw_io.h +++ b/drivers/staging/rtl8188eu/include/rtw_io.h

[PATCH] staging: r8712u: Set device type to wlan

2013-12-24 Thread Larry Finger
The latest version of NetworkManager does not recognize the device as wireless without this change. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org --- drivers/staging/rtl8712/usb_intf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers

Re: [PATCH 3/7] staging: rtl8188eu: Drop print of build date/time

2013-12-23 Thread Larry Finger
(); Acked-by: Larry Finger larry.fin...@lwfinger.net Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/31] staging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os

2013-12-22 Thread Larry Finger
Each of the uses in the code asks for a sleep of 100 usec or so. On Linux, these are converted to msleep(1). Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers

[PATCH 07/31] staging: r8188eu: Replace wrappers for atomic_inc and atomic_inc_return

2013-12-22 Thread Larry Finger
Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++-- drivers/staging/rtl8188eu/include/osdep_service.h | 4 drivers/staging/rtl8188eu/include/usb_ops.h | 2 +- drivers/staging/rtl8188eu/os_dep/osdep_service.c

[PATCH 02/31] staging: r8188eu: Replace wrapper rtw_yield_os

2013-12-22 Thread Larry Finger
a simple yield() is sufficient. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 2 -- drivers/staging/rtl8188eu/os_dep

[PATCH 11/31] staging: r8188eu: Remove wrapper around mutex_destroy

2013-12-22 Thread Larry Finger
Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 1 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 5 - drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 ++-- 4

[PATCH 08/31] staging: r8188eu: Remove daemonize conditional

2013-12-22 Thread Larry Finger
The current kernels do not include this entry point. Delete the call. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/osdep_service.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers

[PATCH 03/31] staging: r8188eu: Remove wrapper code for rtw_suspend_lock_init, rtw_suspend_lock_uninit, rtw_lock_suspend, and rtw_unlock_suspend

2013-12-22 Thread Larry Finger
All of these routines are empty. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/osdep_service.h | 5 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 16 drivers/staging/rtl8188eu/os_dep/rtw_android.c| 2 -- drivers

[PATCH 05/31] staging: r8188eu: Replace wrapper around atomic_set()

2013-12-22 Thread Larry Finger
Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 1 - drivers/staging/rtl8188eu/include/usb_ops.h | 2 +- drivers

[PATCH 20/31] staging: r8188eu: Remove even more empty routines

2013-12-22 Thread Larry Finger
-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm.c | 56 - drivers/staging/rtl8188eu/hal/odm_HWConfig.c| 4 +- drivers/staging/rtl8188eu/include/odm.h | 4 -- drivers/staging/rtl8188eu/include/odm_precomp.h | 7 4

[PATCH 15/31] staging: r8188eu: Remove macro ODM_GetRFReg

2013-12-22 Thread Larry Finger
This one is a duplicate od macro PHY_QueryRFReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++-- drivers/staging/rtl8188eu/hal/odm.c | 4 ++-- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers

[PATCH 21/31] staging: r8188eu: Simplify code concerning SupportPlatform

2013-12-22 Thread Larry Finger
This member of struct odm_dm_struct is always set to ODM_CE in this driver. As a result, a number of switch and if statements can be simplified. In addition, a number of routines are no longer used and can be removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging

[PATCH 14/31] staging: r8188eu: Remove macro ODM_SetRFReg

2013-12-22 Thread Larry Finger
It is a duplicate of macro PHY_SetRFReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 32 +++--- drivers/staging/rtl8188eu/hal/odm.c| 8 +++--- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c

[PATCH 28/31] staging: r8188eu: Fix sparse warning in core/rtw_pwrctrl.c

2013-12-22 Thread Larry Finger
Sparse reports the following: CHECK drivers/staging/rtl8188eu/core/rtw_pwrctrl.c drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:525:6: warning: symbol 'rtw_free_pwrctrl_priv' was not declared. Should it be static? That routine is not used and has been deleted. Signed-off-by: Larry Finger

[PATCH 18/31] staging: r8188eu: Remove - number of dummy and unused routines

2013-12-22 Thread Larry Finger
These routines include: ODM_StartWorkItem() ODM_StopWorkItem() ODM_FreeWorkItem() ODM_ScheduleWorkItem() ODM_IsWorkItemScheduled() Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 20 drivers/staging/rtl8188eu

[PATCH 19/31] staging: r8188eu: Remove more empty routines

2013-12-22 Thread Larry Finger
This batch includes ODM_StartWorkItem ODM_StopWorkItem ODM_FreeWorkItem ODM_AcquireSpinLoc ODM_ReleaseSpinLock ODM_ReleaseTimer ODM_ReleaseAllTimers Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm.c | 7 --- drivers/staging

[PATCH 17/31] staging: r8188eu: Remove macro ODM_GetMACReg

2013-12-22 Thread Larry Finger
This is equivalent to PHY_GetBBReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 8 drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 3 files changed, 4

[PATCH 29/31] staging: r8188eu: Fix sparse warning in core/rtw_xmit.c

2013-12-22 Thread Larry Finger
] *fctrl drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23:got restricted __le16 *noident Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c

[PATCH 13/31] staging: r8188eu: Remove macro ODM_GetBBReg

2013-12-22 Thread Larry Finger
This one is a duplicate of PHY_QueryBBReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 68 +++ drivers/staging/rtl8188eu/hal/odm.c | 49 drivers/staging/rtl8188eu/hal

[PATCH 31/31] staging: r8188eu: Fix smatch error

2013-12-22 Thread Larry Finger
Smatch shows the following: CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer overflow 'pstapriv-sta_aid' 32 = 32 Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core

[PATCH 26/31] staging: r8188eu: Eliminate enum ODM_RADIO_PATH in favor of rf_radio_path

2013-12-22 Thread Larry Finger
There are two different enum statements that have been combined. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 4 +-- drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 32 +++--- drivers/staging/rtl8188eu/hal

[PATCH 09/31] staging: r8188eu: Replace wrapper around sema_init

2013-12-22 Thread Larry Finger
Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++--- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++--- drivers/staging/rtl8188eu/include/osdep_service.h | 1

<    1   2   3   4   5   6   >