This routine is the equivalent of rtl_write6.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 23 +-
drivers/staging/rtl8188eu/hal/odm.c| 3 ++-
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 4 +++-
drivers
This wrapper is not used.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 5 -
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
b/drivers/staging
This routine is never used.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
b/drivers/staging
This is essentially a synonym for rtw_read8.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 6 +++---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
3 files changed, 3 insertions(+), 11
This routine is a wrapper for _rtw_memcmp(), which is a wrapper for memcmp.
In a later change, _rtw_memcmp will be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++--
drivers/staging/rtl8188eu/hal/odm_interface.c | 5 -
drivers/staging
t digit of the address and the NUL terminator so it was already a bit
broken.
Signed-off-by: Dan Carpenter
Nothing seems to be broken.
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index de
On 02/04/2014 01:57 PM, Andrea Merello wrote:
Sorry, my fault.. you had already reported me the iowrite16 vs
iowrite8 for anaparam3 issue, but I forgot to fix it :(
If you are reasonably sure that a 16bits-wide write is OK on the
rtl8187b hardware (In reference code I have here only 8bits are
wr
Andrea,
After applying the latest patch, I get the following warning and errors when
building the USB driver rtl8187:
CC drivers/video/fbmon.o
drivers/net/wireless/rtl818x/rtl8187/dev.c: In function ‘rtl8187_set_anaparam’:
drivers/net/wireless/rtl818x/rtl8187/dev.c:595:3: warning: passi
On 02/04/2014 08:41 AM, Andrea Merello wrote:
Yes, I attach a cumulative patch for latest version of my work.
When I will send this asking for merge in kernel, I will split it in
some patches, because I also also included fix and improvements for
other already supported cards (not directly relat
On 02/02/2014 12:07 PM, Stefan Lippers-Hollmann wrote:
Hi
[ CC'ing the relevant parties ]
On Sunday 02 February 2014, Dave Jones wrote:
On Sun, Feb 02, 2014 at 03:41:27AM -0800, scan-ad...@coverity.com wrote:
>
> Please find the latest report on new defect(s) introduced to Linux found
wit
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries. This exchange was determined
by noticing that the vendor code is 0x07b8 for Abocom at
http://www.linux-usb.org/usb.ids.
Signed-off-by: Larry Finger
---
V2 - fix typo in revised version that
On 02/02/2014 03:26 PM, Greg KH wrote:
On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote:
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2
On 02/02/2014 03:04 PM, Randy Dunlap wrote:
On 02/02/2014 12:07 PM, Larry Finger wrote:
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries.
You also changed 0x7b8 to 0x7bb.
Did you mean to do that?
No, I did not. Thanks for catching that
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
On 01/28/2014 09:01 AM, Greg Kroah-Hartman wrote:
On Tue, Jan 28, 2014 at 05:46:30PM +0300, Dan Carpenter wrote:
On Tue, Jan 28, 2014 at 03:14:21PM +0100, walter harms wrote:
Am 28.01.2014 15:00, schrieb Dan Carpenter:
These macros need parentheses, otherwise it causes a macro expansion bug
adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 01/02/2014 02:44 AM, Dan Carpenter wrote:
On Sun, Dec 22, 2013 at 05:37:02PM -0600, Larry Finger wrote:
Smatch shows the following:
CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer
overflow 'pst
On 01/02/2014 03:05 AM, Dan Carpenter wrote:
On Sun, Dec 22, 2013 at 05:36:55PM -0600, Larry Finger wrote:
--- a/drivers/staging/rtl8188eu/include/odm_interface.h
+++ b/drivers/staging/rtl8188eu/include/odm_interface.h
@@ -51,7 +51,7 @@ ODM_REG(DIG,_pDM_Odm)
#define _cat(_name, _ic_type
On 01/02/2014 02:46 PM, Tim Jester-Pfadt wrote:
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io
On 01/02/2014 11:03 AM, Tim Jester-Pfadt wrote:
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt
---
drivers/staging/rtl8188eu/core/rtw_io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
b/dri
(-)
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h
b/drivers/staging/rtl8188eu/include/rtw_io.h
index eb6f0e5..3d1dfcc 100644
--- a/drivers/staging/rtl8188eu/include/rtw_io.h
+++ b/drivers/staging/rtl8188eu/include/rtw_io.h
@@ -123,7 +123,7 @@ struct _io_ops
The latest version of NetworkManager does not recognize the device as wireless
without this change.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8712/usb_intf.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/rtl8712/usb_intf.c
b/drivers/staging
865,7 +865,6 @@ static int __init rtw_drv_entry(void)
RT_TRACE(_module_hci_intfs_c_, _drv_err_, ("+rtw_drv_entry\n"));
DBG_88E(DRV_NAME " driver version=%s\n", DRIVERVERSION);
- DBG_88E("build time: %s %s\n", __DATE__, __TIME__);
rtw_sus
: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c | 12 +---
drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 35 +++
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 5 +---
drivers/staging/rtl8188eu/include/odm.h | 24
Any routines that are empty as a result of these changes are also removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 11 ---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 7 ---
drivers/staging/rtl8188eu/core/rtw_sreset.c | 2
This member of struct odm_dm_struct is always set to ODM_RTL8188E for this
driver. Accordingly, the code can be simplified. A number of routines
now are no longer needed and are deleted.
Signed-off-by: Larry Finger
---
.../staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 +-
drivers/staging
This header contains a number of routines that do not to be available
globally. Once this change was made, a number of the routines were not
used, and could be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c | 67 -
drivers
This driver only handles RTL8188EU with USB interface, thus several hardware
defines and macros can be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 --
drivers/staging/rtl8188eu/hal/rtl8188e_mp.c | 18 +++--
drivers/staging/rtl8188eu
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 7 -
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 35 ---
2 files changed, 42 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging
This is the same as macro PHY_SetBBReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 14 +++---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 3 ---
3 files changed, 7 insertions
There are two different enum statements that have been combined.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 4 +--
drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 32 +++---
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 6
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++---
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++---
drivers/staging/rtl8188eu/include/osdep_service.h | 1 -
drivers/staging/rtl8188eu
/rtw_br_ext.c:1157:64: warning: cast to
restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to
restricted __be16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_br_ext.c | 43 +++--
1 file changed, 22 insertions(+), 21
Smatch shows the following:
CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer
overflow 'pstapriv->sta_aid' 32 <= 32
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.
This is equivalent to PHY_GetBBReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 8
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
3 files changed, 4 insertions(+), 12
] *fctrl
drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8188eu/core
This one is a duplicate of PHY_QueryBBReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 68 +++
drivers/staging/rtl8188eu/hal/odm.c | 49
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:525:6: warning: symbol
'rtw_free_pwrctrl_priv' was not declared. Should it be static?
That routine is not used and has been deleted.
Signed-off-by: La
These routines include:
ODM_StartWorkItem()
ODM_StopWorkItem()
ODM_FreeWorkItem()
ODM_ScheduleWorkItem()
ODM_IsWorkItemScheduled()
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 20
drivers/staging/rtl8188eu/include/odm_interface.h | 10
This batch includes
ODM_StartWorkItem
ODM_StopWorkItem
ODM_FreeWorkItem
ODM_AcquireSpinLoc
ODM_ReleaseSpinLock
ODM_ReleaseTimer
ODM_ReleaseAllTimers
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c | 7 ---
drivers/staging/rtl8188eu/hal/odm_interface.c
This member of struct odm_dm_struct is always set to ODM_CE in this driver.
As a result, a number of switch and if statements can be simplified. In
addition, a number of routines are no longer used and can be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c
It is a duplicate of macro PHY_SetRFReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 32 +++---
drivers/staging/rtl8188eu/hal/odm.c| 8 +++---
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 6 ++--
drivers/staging
: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c | 56 -
drivers/staging/rtl8188eu/hal/odm_HWConfig.c| 4 +-
drivers/staging/rtl8188eu/include/odm.h | 4 --
drivers/staging/rtl8188eu/include/odm_precomp.h | 7
4 files changed, 1 insertion
This one is a duplicate od macro PHY_QueryRFReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++--
drivers/staging/rtl8188eu/hal/odm.c | 4 ++--
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:152:6: warning: symbol
'rtw_mfree_all_stainfo' was not declared. Should it be static?
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 1 -
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 5 -
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 ++--
4 files changed, 3
This set of patches removes a number of wrappers around standard routines,
cleans up some sparse warhings, and also removed a smatch warning.
Signed-off-by: Larry Finger
Larry Finger (31):
staging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os
staging: r8188eu: Replace wrapper
All of these routines are empty.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 5 -
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 16
drivers/staging/rtl8188eu/os_dep/rtw_android.c| 2 --
drivers/staging/rtl8188eu/os_dep
a simple yield() is sufficient.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 5
The current kernels do not include this entry point. Delete the call.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188eu/include
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 1 -
drivers/staging/rtl8188eu/include/usb_ops.h | 2 +-
drivers/staging/rtl8188eu/os_dep
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/drv_types.h | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 22 ++
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +-
drivers
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++--
drivers/staging/rtl8188eu/include/osdep_service.h | 4
drivers/staging/rtl8188eu/include/usb_ops.h | 2 +-
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 10 --
4 files
Each of the uses in the code asks for a sleep of 100 usec or so. On Linux,
these are converted to msleep(1).
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/hal
Please tell me if the following fixes are appropriate. In particular, I am
uncertain of
the __force attributes.
Thanks,
Larry
Sparse lists the following:
CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1156:63: warning: restricted
__sum16 deg
A line in the P2P code had been removed in the process of converting the vendor
driver to a form suitable for the kernel. The output of this call was ignored,
and the initial analysis incorrectly determined that the call had no other
effect.
Signed-off-by: Larry Finger
---
drivers/staging
block was removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c| 12
drivers/staging/rtl8188eu/core/rtw_debug.c | 1 -
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8
drivers/staging/rtl8188eu/core/rtw_recv.c | 1 -
drivers
A recent set of patches revealed that a line of code had been incorrectly
removed in an earlier edit. That line is added back. In addition, a
configuration
problem resulted in a number of "unused variable" warnings.
Signed-off-by: Larry Finger
Larry Finger (2):
staging: r8188e
On 12/20/2013 02:34 PM, Greg KH wrote:
Nah, I just switched to 4.8 and rebuilt all of the different kernel
trees on this box with it, so I'll stay there for now.
The problem wasn't the fault of gcc 4.8. I only use the staging tree to base
patches to send to you, and my .config in that director
On 12/20/2013 01:18 PM, Greg KH wrote:
On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote:
On 12/20/2013 10:58 AM, Greg KH wrote:
With this series applied, I get a ton of "unused variable" warnings, can
you please fix them up now too?
Strange, but I don't get any.
On 12/20/2013 10:58 AM, Greg KH wrote:
With this series applied, I get a ton of "unused variable" warnings, can
you please fix them up now too?
Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909
[gcc-4_8-branch revision 202388] from openSUSE 13.1. What version are you
On 12/20/2013 01:14 AM, Dan Carpenter wrote:
On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger
@@ -1509,10 +1509,6 @@ _func_enter_;
rtw_p2p_set_state(pwdinfo
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu
There are two such wrappers - _enter_critical() and _enter_critical_ex().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_xmit.c | 8
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mp.c| 4 ++--
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 10 +-
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 12 ++--
drivers/staging/rtl8188eu/hal/odm_interface.c | 5
Again there are two - _exit_critical() and _exit_critical_ex().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_xmit.c | 8
drivers
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 4 ++--
drivers/staging/rtl8188eu/core/rtw_mlme.c | 14 +++---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 16
drivers/staging/rtl8188eu/core/rtw_mp.c| 4
This wrapper does nothing on Linux. When calls to it were removed, a number of
routines became empty and could also be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 -
drivers/staging/rtl8188eu/core/rtw_cmd.c | 1 -
drivers/staging
Each instance may bre replaced by udelay
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c | 6 +++---
drivers/staging/rtl8188eu/hal/odm.c| 10 -
drivers/staging/rtl8188eu/hal
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 8
drivers/staging
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 38
drivers/staging/rtl8188eu/core/rtw_br_ext.c | 16 +++
drivers/staging/rtl8188eu/core/rtw_cmd.c | 12
Because the original driver was designed to build for Windows, FreeBSD, and
Linux,
there are wrappers for many of the OS primitives. These patches remove a number
of them.
Signed-off-by: Larry Finger
Larry Finger (11):
staging: r8188eu: Remove pointless thread_exit macro
staging: r8188eu
Two code lines were accidentally deleted. Restore them.
Signed-off-by: Larry Finger
Cc: Stable
---
V2 - rewrite silly commit message.
drivers/staging/rtl8188eu/core/rtw_ap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging
Two code lines were accidentally deleted in the code. Restore them.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu/core/rtw_ap.c
On 10/24/2013 05:10 AM, Dan Carpenter wrote:
I have looked at how this is called from ioctl_private_call() and it
seems like these are actual user pointers and the code is buggy. The
patch silences the warnings instead of fixing the bugs.
Thanks for the review.
Greg - please drop this one and
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_ieee80211.c
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1593:14: warning: cast to
restricted __le16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/ieee80211.h | 16
1 file changed
/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
b/drivers/staging/rtl8188eu
This set of patches resubmits the set of fixes for sparse warnings. The two that
were criticized have been removed, and this set should not have white-space
damage.
Signed-off-by: Larry Finger
Larry Finger (5):
staging: r8188eu: Fix sparse warnings in ioctl_linux.c
staging: r8188eu: Fix
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:expected unsigned
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 41
/rtl8188eu/os_dep/ioctl_linux.c:3949:38:expected void const
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3949:38:got void [noderef]
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3963:9: warning: cast removes
address space of expression
Signed-off-by: Larry Finger
*
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:expected unsigned short
*fctrl
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:got restricted __le16
*
Signed-off-by: Larry
On 10/23/2013 08:10 PM, Chen Gang wrote:
> On 10/24/2013 12:06 AM, Larry Finger wrote:
>> On 10/23/2013 03:52 AM, Chen Gang wrote:
>>> If command line use EXTRA_CFLAGS (e.g. "EXTRA_CFLAGS=-mmedium-calls"
>>> for arc architecture, with allmodconfig), it can not
c)/include
With that change, you may add
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
The latest version of NetworkManager does not recognize the device as wireless
without this change.
Signed-off-by: Larry Finger
Cc: Stable a [3.12+]
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/rtl8188eu/os_dep
On 10/18/2013 05:08 PM, Ben Hutchings wrote:
On Fri, 2013-10-18 at 16:34 -0500, Larry Finger wrote:
Sparse checking results in the following warnings:
CHECK drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes
The driver places a 254-byte buffer on the stack when writing long output.
To reduce stack usage, a buffer of the required length is acquired using
kmemdup().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 58 +++
1 file changed, 42
/rtl8188eu/os_dep/ioctl_linux.c:3949:38:expected void const
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3949:38:got void [noderef]
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3963:9: warning: cast removes
address space of expression
Signed-off-by: Larry Finger
/rtl8188eu/core/rtw_br_ext.c:1166:69: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1166:69:expected restricted
__sum16 [usertype] check
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1166:69:got int
Signed-off-by: Larry Finger
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:expected unsigned
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 41
__le16
*
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:expected unsigned short
*fctrl
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:got restricted __le16
*
Signed-off-by: Larry
/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
b/drivers/staging/rtl8188eu
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_ieee80211.c
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1593:14: warning: cast to
restricted __le16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/ieee80211.h | 16
1 file
Sparse shows the following warning:
CHECK drivers/staging/rtl8188eu/core/rtw_wlan_util.c
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1635:25: warning: cast to
restricted __le16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
1 file changed, 1
The latest version of NetworkManager does not recognize the device as wireless
without this change.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers
.
Signed-off-by: Larry Finger
---
Larry Finger (9):
staging: r8188eu: Set device type to wlan
staging: r8188eu: Fix Sparse warnings in rtw_wlan_util
staging: r8188eu: Fix sparse warnings in ioctl_linux.c
staging: r8188eu: Fix sparse warnings in rtw_ieee80211.c
staging: r8188eu: Fix sparse
event_callback = wlanevents[evt_code].event_callback;
+ if (event_callback)
+ event_callback(padapter, (u8 *)peventbuf);
pevt_priv->evt_done_cnt++;
_abort_event_:
return;
Acked-by: Larry Finger
Thanks,
Larry
_
} else if (_rtw_memcmp(pIE->data, EPIGRAM_OUI, 3)) {
-epigram_vendor_flag = 1;
+ epigram_vendor_flag = 1;
if (ralink_vendor_flag) {
DBG_88E("l
ist_head *phead, *plist;
union recv_frame *prframe;
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
u32 j, tmp, change_inx;
+ u32 j, tmp, change_inx = false;
/* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */
for (i = 0; i < 4; i++) {
Acked-by: Larry Finger
This warning has not shown up on my x86_64 system with gcc 4.7.2. What
ar
501 - 600 of 621 matches
Mail list logo
