taking
a reference on state->services[j].
Signed-off-by: Marcelo Diop-Gonzalez
---
.../interface/vchiq_arm/vchiq_arm.c | 25 +-
.../interface/vchiq_arm/vchiq_core.c | 222 +-
.../interface/vchiq_arm/vchiq_core.h | 12 +-
3 files changed, 140 insertion
On Thu, Jan 2, 2020 at 11:34 AM Greg KH wrote:
>
> On Thu, Jan 02, 2020 at 11:24:09AM -0500, Marcelo Diop-Gonzalez wrote:
> > Hi, I noticed couple minor bugs while looking around in
> > drivers/staging/vc04_services/*:
> >
> > 1. When opening "/dev/vchiq&
Hi, I noticed couple minor bugs while looking around in
drivers/staging/vc04_services/*:
1. When opening "/dev/vchiq", vchiq_debugfs_add_instance() adds a debugfs
directory named after the tgid of the process who opened the file. But
there are collisions if you try opening it multiple times from
ess and the appropriate error
code otherwise, and return nonzero errors to the user.
Reviewed-by: Dan Carpenter
Signed-off-by: Marcelo Diop-Gonzalez
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 5 +-
.../interface/vchiq_arm/vchiq_arm.c | 35 +++---
.../interface/vchiq_arm/vchiq_cor
eclaration in the middle of code.
Signed-off-by: Marcelo Diop-Gonzalez
---
.../interface/vchiq_arm/vchiq_arm.c | 41 ++-
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging/vc0
On Tue, Nov 12, 2019 at 6:09 PM Greg KH wrote:
>
> On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> > This allows the removal of the struct rpi_firmware* member
> > from struct vchiq_drvdata.
> >
> > Signed-off-by: Marcelo Diop-Gonzal
On Wed, Nov 13, 2019 at 12:32 AM Greg KH wrote:
>
> On Tue, Nov 12, 2019 at 06:29:55PM -0500, Marcelo Diop-Gonzalez wrote:
> > On Tue, Nov 12, 2019 at 6:09 PM Greg KH wrote:
> > >
> > > On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
&
On Tue, Nov 12, 2019 at 6:09 PM Greg KH wrote:
>
> On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> > This allows the removal of the struct rpi_firmware* member
> > from struct vchiq_drvdata.
> >
> > Signed-off-by: Marcelo Diop-Gonzal
It could be confusing to return 1 on success and 0 on error
given the style elswhere.
Signed-off-by: Marcelo Diop-Gonzalez
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_shim.c| 2 +-
.../staging/vc04_services/interface/vchiq_arm/vchiq_util.c| 4 ++--
2 files changed, 3
