Re: [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names

2015-07-20 Thread Marek Vasut
On Monday, July 20, 2015 at 09:00:32 AM, Dan Carpenter wrote: On Mon, Jul 20, 2015 at 12:06:11AM +0200, Marek Vasut wrote: On Sunday, July 19, 2015 at 10:49:47 PM, Dan Carpenter wrote: On Sun, Jul 19, 2015 at 11:33:43PM +0300, Dan Carpenter wrote: I didn't necessarily read the thread

Re: [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names

2015-07-19 Thread Marek Vasut
On Sunday, July 19, 2015 at 11:45:29 AM, Jonathan Cameron wrote: On 18/07/15 16:38, Marek Vasut wrote: On Saturday, July 18, 2015 at 02:30:40 PM, Stefan Wahren wrote: This patch series does some clean up in mxs-lradc and finally add the datasheet names for every usable channel. Changes

Re: [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names

2015-07-19 Thread Marek Vasut
-by tags as a reward, only as added responsibility. Yeah, that's a good point. If you review code and it turns out to be crap, then the value of your R-B and A-B decreases. Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names

2015-07-18 Thread Marek Vasut
: mxs-lradc: add datasheet name for every usable channel .../bindings/staging/iio/adc/mxs-lradc.txt |2 +- drivers/staging/iio/adc/mxs-lradc.c| 122 +--- 2 files changed, 82 insertions(+), 42 deletions(-) Entire series Reviewed-by: Marek Vasut ma

Re: [PATCH 5/6] iio: mxs-lradc: reorder header includes

2015-07-18 Thread Marek Vasut
On Saturday, July 18, 2015 at 02:30:45 PM, Stefan Wahren wrote: This patch reorder the header includes alphabetically. You call that operation sort :) Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH] iio: mxs-lradc: add datasheet name for every usable channel

2015-06-05 Thread Marek Vasut
On Thursday, June 04, 2015 at 08:44:31 PM, Stefan Wahren wrote: In order to provide a channel name to in kernel consumers add the datasheet names for every usable AD channel. Hi! Did you check those channel names for both MX28 and MX23? Note that they do differ IIRC ;-) Best regards, Marek

Re: [PATCH] iio: mxs-lradc: add datasheet name for every usable channel

2015-06-05 Thread Marek Vasut
On Friday, June 05, 2015 at 03:57:03 PM, Stefan Wahren wrote: Am 05.06.2015 um 15:43 schrieb Marek Vasut: On Thursday, June 04, 2015 at 08:44:31 PM, Stefan Wahren wrote: In order to provide a channel name to in kernel consumers add the datasheet names for every usable AD channel. Hi

Re: [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string

2015-01-27 Thread Marek Vasut
...@spectrumdigital.se Makes sense, thanks! Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/4] iio: mxs-lradc: fix interactions between the touchscreen and the ADC

2015-01-25 Thread Marek Vasut
On Sunday, January 25, 2015 at 05:28:18 PM, Kristina Martšenko wrote: These patches fix some issues with using the touchscreen and reading other ADC channels at the same time. [...] Hi! Thanks! Entire series Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut

Re: [PATCH 1/4] iio: mxs-lradc: separate touchscreen and buffer virtual channels

2015-01-19 Thread Marek Vasut
On Monday, January 19, 2015 at 08:02:03 PM, Kristina Martšenko wrote: On 18/01/15 02:19, Marek Vasut wrote: On Saturday, January 17, 2015 at 01:22:08 AM, Kristina Martšenko wrote: Hi! Hi! Hi! Good stuff, thank you! Just minor nitpicks below. [...] diff --git a/drivers

Re: [PATCH 0/4] iio: mxs-lradc: fix interactions between the touchscreen and the ADC

2015-01-19 Thread Marek Vasut
a couple of variable resistors to simulate it (haha) :) Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] iio: mxs-lradc: make ADC reads not unschedule touchscreen conversions

2015-01-18 Thread Marek Vasut
at least a bit ;-) Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] iio: mxs-lradc: separate touchscreen and buffer virtual channels

2015-01-17 Thread Marek Vasut
this kind of a N:M mapping ? What do you all think please ? Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] iio: mxs-lradc: make ADC reads not unschedule touchscreen conversions

2015-01-17 Thread Marek Vasut
off. This is tested and fixes the issue on i.MX28, but hasn't been tested on i.MX23. Signed-off-by: Kristina Martšenko kristina.martse...@gmail.com Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut ___ devel mailing list de

Re: [PATCH 4/4] iio: mxs-lradc: only update the buffer when its conversions have finished

2015-01-17 Thread Marek Vasut
, including when the buffer's own conversions have not yet finished. So let's only push to the buffer when its conversions are ready. Signed-off-by: Kristina Martšenko kristina.martse...@gmail.com Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut

Re: [PATCH 2/4] iio: mxs-lradc: make ADC reads not disable touchscreen interrupts

2015-01-17 Thread Marek Vasut
to change it again this patch. Reviewed-by: Marek Vasut ma...@denx.de Thanks! Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers/staging/iio/adc/Kconfig: Let MXS_LRADC depend on HAS_IOMEM

2014-07-13 Thread Marek Vasut
-by: Chen Gang gang.chen.5...@gmail.com Acked-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-12 Thread Marek Vasut
/input/serio/olpc_apsp.ko] undefined! ERROR: devm_ioremap_resource [drivers/input/serio/arc_ps2.ko] undefined! This stuff should go through different trees, so I'd suggest to split this into multiple patches. Thanks for catching this stuff ! Best regards, Marek Vasut

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-04 Thread Marek Vasut
with the TS part of the code but I can investigate if you don't have any idea. You are right. I have seen the same behaviour here a few times. Currently I'm short in time to dig deeper into this issue, but I will try to do so. Hi guys, is this still broken? Best regards, Marek Vasut

Re: [PATCH] imx-drm: parallel-display: honor 'native-mode' property when selecting video mode from DT

2014-01-13 Thread Marek Vasut
, the patch does not change the behaviour of this driver on the affected platforms. Signed-off-by: Lothar Waßmann l...@karo-electronics.de Looks OK to me, thanks. Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut ___ devel mailing list

Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-09 Thread Marek Vasut
On Tuesday, December 03, 2013 at 12:44:52 PM, Shawn Guo wrote: On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: Add DRM flags for the LCD display clock polarity so the pixelclk-active DT property can be properly handled by drivers using the DRM API. Signed-off-by: Marek Vasut

Re: [PATCHv5][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:07 PM, Denis Carikli wrote: [...] Can you please explain the correction here ? Why is it needed ? What was the problem ? Thanks! Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCHv5][ 4/8] staging: imx-drm: Use de-active and pixelclk-active display-timings.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:08 PM, Denis Carikli wrote: If de-active and/or pixelclk-active properties were set in the display-timings DT node, they were not used. Instead the data-enable and the pixel data clock polarity were hardcoded. This change is needed for making the

Re: [PATCHv5][ 5/8] staging: imx-drm: parallel display: add regulator support.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:09 PM, Denis Carikli wrote: Cc: Dan Carpenter dan.carpen...@oracle.com Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell

Re: [PATCHv5][ 6/8] ARM: dts: mbimx51sd: Add display support.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:10 PM, Denis Carikli wrote: The CMO-QVGA, DVI-SVGA and DVI-VGA are added. Cc: Shawn Guo shawn@linaro.org Cc: Sascha Hauer ker...@pengutronix.de Cc: linux-arm-ker...@lists.infradead.org Cc: Eric Bénard e...@eukrea.com Signed-off-by: Denis Carikli

Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-03 Thread Marek Vasut
Hello Russell, On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: Add DRM flags for the LCD display clock polarity so the pixelclk-active DT property can be properly handled by drivers using the DRM API. I still say that not even this should be part of the DRM mode API

[PATCH 2/3] imx-drm: ipuv3-crtc: Make DISP_CLK polarity configurable

2013-12-02 Thread Marek Vasut
This patch makes the LCD display clock polarity configurable via DT so in case board needs different DISP_CLK clock polarity, it can use the 'pixelclk-active' DT prop to do such adjustment. Signed-off-by: Marek Vasut ma...@denx.de Cc: Dave Airlie airl...@gmail.com Cc: Greg Kroah-Hartman gre

[PATCH 3/3] ARM: dts: imx53: Switch DISP_CLK polarity on M53EVK

2013-12-02 Thread Marek Vasut
-by: Marek Vasut ma...@denx.de Cc: Dave Airlie airl...@gmail.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Philipp Zabel p.za...@pengutronix.de Cc: Sascha Hauer s.ha...@pengutronix.de Cc: Shawn Guo shawn@linaro.org --- arch/arm/boot/dts/imx53-m53evk.dts | 1 + 1 file changed, 1

[PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-02 Thread Marek Vasut
Add DRM flags for the LCD display clock polarity so the pixelclk-active DT property can be properly handled by drivers using the DRM API. Signed-off-by: Marek Vasut ma...@denx.de Cc: Dave Airlie airl...@gmail.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Philipp Zabel p.za

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2013-10-01 Thread Marek Vasut
off trail and in fact a couple of the patch descriptions say that they are untested on i.MX28. Jonathan Tested-by: Marek Vasut ma...@denx.de on M28EVK Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2013-09-23 Thread Marek Vasut
must be handled Comments are welcome. On M28EVK: Tested-by: Marek Vasut ma...@denx.de Acked-by: Marek Vasut ma...@denx.de Thanks! Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org

Re: [PATCH 4/6] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC touchscreen driver

2013-09-16 Thread Marek Vasut
make the code more consistent so personally I would prefer it to be there. I can change it. Anyone here with objections against such a change? Regards Juergen Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Marek Vasut
: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk While this driver is placed in IIO within staging at the moment, these changes are definitely input related. Hence I have cc'd Dmitry and the input list. I am personaly

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Marek Vasut
Dear Jürgen Beisert, Hi Marek, On Monday 16 September 2013 16:23:48 Marek Vasut wrote: On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: On 09/11/13 09:18, Juergen Beisert wrote: For battery driven systems it is a very bad idea to collect the touchscreen data

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Marek Vasut
Dear Juergen Beisert, Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Marek Vasut
, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Marek Vasut
Dear Jürgen Beisert, Hi Marek, On Tuesday 10 September 2013 10:22:36 Marek Vasut wrote: On Monday 09 September 2013 18:04:19 Marek Vasut wrote: Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Signed-off

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Marek Vasut
Dear Jürgen Beisert, Hi Marek, On Monday 09 September 2013 18:04:19 Marek Vasut wrote: Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker

Re: [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-06 Thread Marek Vasut
for development to monitor the statemachine... :) But you are right, I will remove them. You can put them into a separate patch which can be NAK'd separatelly :) Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-05 Thread Marek Vasut
this driver out of staging then ;-) Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel