On Monday, July 20, 2015 at 09:00:32 AM, Dan Carpenter wrote:
> On Mon, Jul 20, 2015 at 12:06:11AM +0200, Marek Vasut wrote:
> > On Sunday, July 19, 2015 at 10:49:47 PM, Dan Carpenter wrote:
> > > On Sun, Jul 19, 2015 at 11:33:43PM +0300, Dan Carpenter wrote:
> > > >
On Sunday, July 19, 2015 at 11:45:29 AM, Jonathan Cameron wrote:
> On 18/07/15 16:38, Marek Vasut wrote:
> > On Saturday, July 18, 2015 at 02:30:40 PM, Stefan Wahren wrote:
> >> This patch series does some clean up in mxs-lradc and finally add the
> >> datasheet nam
Uh, OK, I wasn't aware of this.
> Anyway, I don't see Reviewed-by tags as a reward, only as added
> responsibility.
Yeah, that's a good point. If you review code and it turns out to be crap,
then the value of your R-B and A-B decreases.
Best regards,
Marek Vasut
2 insertions(+), 42 deletions(-)
Entire series
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Saturday, July 18, 2015 at 02:30:45 PM, Stefan Wahren wrote:
> This patch reorder the header includes alphabetically.
You call that operation "sort" :)
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverpro
On Friday, June 05, 2015 at 03:57:03 PM, Stefan Wahren wrote:
> Am 05.06.2015 um 15:43 schrieb Marek Vasut:
> > On Thursday, June 04, 2015 at 08:44:31 PM, Stefan Wahren wrote:
> >> In order to provide a channel name to in kernel consumers add the
> >> datasheet names
On Thursday, June 04, 2015 at 08:44:31 PM, Stefan Wahren wrote:
> In order to provide a channel name to in kernel consumers add the
> datasheet names for every usable AD channel.
Hi!
Did you check those channel names for both MX28 and MX23? Note
that they do differ IIRC ;-)
Best regards,
-by: Rickard Strandqvist
Makes sense, thanks!
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sunday, January 25, 2015 at 05:28:18 PM, Kristina Martšenko wrote:
> These patches fix some issues with using the touchscreen and reading
> other ADC channels at the same time.
[...]
Hi!
Thanks!
Entire series
Reviewed-by: Marek Vasut
Best regards,
Marek
resistive touchscreen, when push comes to shove, Stefan can always
use a couple of variable resistors to simulate it (haha) :)
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Monday, January 19, 2015 at 08:02:03 PM, Kristina Martšenko wrote:
> On 18/01/15 02:19, Marek Vasut wrote:
> > On Saturday, January 17, 2015 at 01:22:08 AM, Kristina Martšenko wrote:
> >
> > Hi!
>
> Hi!
Hi!
> > Good stuff, thank you! Just minor nitpicks bel
a more precise advice from Kristina . Hope it helps
at least a bit ;-)
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ossible
sources . Is such a thing common in the ADC/DAC world ? Would it be worth to
implement generic helper to handle this kind of a N:M mapping ? What do you all
think please ?
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nabled). Since the touchscreen uses different
> channels (6 and 7), it no longer gets turned off.
>
> This is tested and fixes the issue on i.MX28, but hasn't been tested on
> i.MX23.
>
> Signed-off-by: Kristina Martšenko
Reviewed-by: Marek Vasut
Be
> arrives, including when the buffer's own conversions have not yet
> finished. So let's only push to the buffer when its conversions are
> ready.
>
> Signed-off-by: Kristina Martšenko
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
___
S_VCH2 6
Please fix the indent in 1/4 , so you don't have to change it again this patch.
Reviewed-by: Marek Vasut
Thanks!
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
dc/mxs-lradc.ko]
> undefined!
>
>
> Signed-off-by: Chen Gang
Acked-by: Marek Vasut
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t; "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! ERROR:
> "devm_ioremap_resource" [drivers/input/serio/olpc_apsp.ko] undefined!
> ERROR: "devm_ioremap_resource" [drivers/input/serio/arc_ps2.ko] undefined!
This stuff should go through different trees, so
While I don't have much experience with the TS part of the code but I
> > can investigate if you don't have any idea.
>
> You are right. I have seen the same behaviour here a few times. Currently
> I'm short in time to dig deeper into this issue, but I will try to
efined in
> their .dts files, the patch does not change the behaviour of this
> driver on the affected platforms.
>
> Signed-off-by: Lothar Waßmann
Looks OK to me, thanks.
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
___
devel mailing
On Tuesday, December 03, 2013 at 12:44:52 PM, Shawn Guo wrote:
> On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:
> > Add DRM flags for the LCD display clock polarity so the pixelclk-active
> > DT property can be properly handled by drivers using the DRM API.
> &g
On Thursday, December 05, 2013 at 07:28:10 PM, Denis Carikli wrote:
> The CMO-QVGA, DVI-SVGA and DVI-VGA are added.
>
> Cc: Shawn Guo
> Cc: Sascha Hauer
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: Eric Bénard
> Signed-off-by: Denis Carikli
> ---
> ChangeLog v3->v5:
> - Updated to new GPIO
On Thursday, December 05, 2013 at 07:28:09 PM, Denis Carikli wrote:
> Cc: Dan Carpenter
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Cc: Stephen Warren
> Cc: Ian Campbell
> Cc: devicet...@vger.kernel.org
> Cc: Greg Kroah-Hartman
> Cc: driverdev-devel@linuxdriverproject.org
> Cc: D
On Thursday, December 05, 2013 at 07:28:08 PM, Denis Carikli wrote:
> If de-active and/or pixelclk-active properties were set in the
> display-timings DT node, they were not used.
>
> Instead the data-enable and the pixel data clock polarity
> were hardcoded.
>
> This change is needed for making
On Thursday, December 05, 2013 at 07:28:07 PM, Denis Carikli wrote:
[...]
Can you please explain the correction here ? Why is it needed ? What was the
problem ?
Thanks!
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
Hello Russell,
> On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:
> > Add DRM flags for the LCD display clock polarity so the pixelclk-active
> > DT property can be properly handled by drivers using the DRM API.
>
> I still say that not even this should be part o
Add DRM flags for the LCD display clock polarity so the pixelclk-active DT
property can be properly handled by drivers using the DRM API.
Signed-off-by: Marek Vasut
Cc: Dave Airlie
Cc: Greg Kroah-Hartman
Cc: Philipp Zabel
Cc: Sascha Hauer
Cc: Shawn Guo
---
drivers/gpu/drm/drm_modes.c | 5
Change the DISP_CLK line polarity on M53EVK to work correctly after
the following commit:
commit f0ac9bebf19001f38afbb93e2dc719a15dfb75e5
Author: Fabio Estevam
Date: Tue Oct 29 19:42:22 2013 -0200
imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity
Signed-off-by: Marek Vasut
Cc: Dave
This patch makes the LCD display clock polarity configurable via DT so in case
board needs different DISP_CLK clock polarity, it can use the 'pixelclk-active'
DT prop to do such adjustment.
Signed-off-by: Marek Vasut
Cc: Dave Airlie
Cc: Greg Kroah-Hartman
Cc: Philipp Zabel
Cc: Sa
reflected in the sign off trail and in fact a
> couple of the patch descriptions say that they are untested on i.MX28.
>
> Jonathan
>
Tested-by: Marek Vasut
on M28EVK
Best regards,
Marek Vasut
___
devel mailing list
de..
ter access functions to make the existing code more readable
> - adding some functions to distinguish the SoCs at run-time to avoid
> if-else contructs whenever differences in the register layout between
> i.MX23 and i.MX28 must be handled
>
> Comments are welcome.
On M28EVK:
Tested-b
Dear Jürgen Beisert,
> Hi Marek,
>
> On Monday 23 September 2013 09:55:58 Jürgen Beisert wrote:
> > On Monday 23 September 2013 01:55:04 Marek Vasut wrote:
> > > > The following series replaces the current busy loop touchscreen
> > > > implementation for
either.
Right now, I'm somehow on a tight schedule, but I'd like to see this resolved
ASAP. Do you have any hint for me ?
btw. the touchscreen connection on M28EVK is pretty much the same as on MX28EVK.
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Dear Jürgen Beisert,
> Hi Marek,
>
> On Monday 16 September 2013 16:23:48 Marek Vasut wrote:
> > > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> > > > On 09/11/13 09:18, Juergen Beisert wrote:
> > > > > For battery driven
> Signed-off-by: Juergen Beisert
> > > CC: linux-arm-ker...@lists.infradead.org
> > > CC: de...@driverdev.osuosl.org
> > > CC: Marek Vasut
> > > CC: Fabio Estevam
> > > CC: Jonathan Cameron
> >
> > While this driver is placed in IIO within
RADC)
> > > + return LRADC_CTRL0_MX23_YP | LRADC_CTRL0_MX23_XM;
> > >
> > > return LRADC_CTRL0_MX28_YPPSW | LRADC_CTRL0_MX28_XNNSW;
> >
> > Whilst it obviously doesn't actually matter, having an else
> > in th
@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 204
> +--- 1 file changed, 120 insertions(+), 84
> deletions(-)
>
> diff --git a/drivers/staging/iio/adc/mxs
Dear Jürgen Beisert,
> Hi Marek,
>
> On Monday 09 September 2013 18:04:19 Marek Vasut wrote:
> > > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC
> > > at least for the 4 wire touchscreen.
> > >
> > > Signed-off
Dear Jürgen Beisert,
> Hi Marek,
>
> On Tuesday 10 September 2013 10:22:36 Marek Vasut wrote:
> > > On Monday 09 September 2013 18:04:19 Marek Vasut wrote:
> > > > > Distinguish i.MX23 and i.MX28 at runtime and do the same for both
> > > &
; complained.
Looks like Jurgen can now start cursing me ;-)
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Dear Juergen Beisert,
> Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at
> least for the 4 wire touchscreen.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
>
gt; > Gar. I meant to comment on this the first time this patch was sent.
> >
> > Please remove the pr_devel() calls. They are nonsense.
>
> They are very helpful for development to monitor the statemachine... :) But
> you are right, I will remove them.
You can put them
gt; > + writel(val, lradc->base + chan + STMP_OFFSET_REG_SET);
> > +}
> > +
> > +static void lradc_reg_clear(struct mxs_lradc *lradc, u32 val, size_t
> > chan) +{
> > + writel(val, lradc->base + chan + STMP_OFFSET_REG_CLR);
> > +}
>
> Ma
especially in staging, it's our favorite
> thing. :P
About time to move this driver out of staging then ;-)
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Dear Juergen Beisert,
> In order to support i.MX23 and i.MX28 within one driver we need to separate
> the register definitions which differ in both SoC variants.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: de...@driverdev.osuosl.org
Dear Dan Carpenter,
> "map" needs to be signed for the error handling to work. In the success
> case then it holds a small non-negative value.
>
> Signed-off-by: Dan Carpenter
Nice catch and quick glance over the source makes it seem right
Acked-by: Marek Vasut
46 matches
Mail list logo
