Em Mon, 17 May 2021 10:05:27 +0200
Pavel Machek escreveu:
> No. Take a look at triggers; for example hdd monitor should look very
> much like existing disk trigger.
Hmm... after looking at triggers, I'm not sure if this is the right
interface, nor if we're talking about the same thing.
See, at
Em Mon, 17 May 2021 10:57:49 +0200
Mauro Carvalho Chehab escreveu:
> Em Mon, 17 May 2021 10:05:27 +0200
> Pavel Machek escreveu:
> > No. Take a look at triggers; for example hdd monitor should look very
> > much like existing disk trigger.
Btw, is there a way to trigger b
Em Mon, 17 May 2021 10:18:57 +0200
Greg KH escreveu:
> On Sun, May 16, 2021 at 12:53:28PM +0200, Mauro Carvalho Chehab wrote:
> > Hi Greg,
> >
> > This series add support for the LEDs found at Intel NUCs since
> > NUC version 6.
> >
> > On several N
Em Mon, 17 May 2021 10:05:27 +0200
Pavel Machek escreveu:
> Hi!
>
> > > > - Need to validate the uAPI and document it before moving
> > > >this driver out of staging.
> > >
> > > > - Stabilize and document its sysfs interface.
> > >
> > > Would you mind starting with this on
Hi Pavel,
Em Sun, 16 May 2021 20:21:50 +0200
Pavel Machek escreveu:
> Hi!
>
> > - Need to validate the uAPI and document it before moving
> >this driver out of staging.
>
> > - Stabilize and document its sysfs interface.
>
> Would you mind starting with this one?
Do you mean wri
Tests on NUC6 or NUC7 are required;
- On a suspend test, I noticed that some controls were reset
to the default at resume time. It is required to check
what's happening there and address it properly.
- Need to validate the uAPI and document it before moving
this driver out of staging.
name, each with support
for each NUC family.
Let's start a new driver from scratch, using the x86 platform
WMI core and the LED class.
This initial version is compatible with NUCi8 and above, and it
was tested with a Hades Canyon NUC (NUC8i7HNK).
Signed-off-by: Mauro Carvalho Chehab
---
M
producing exactly the WMI query as the NUC6 OOT driver at:
https://github.com/milesp20/intel_nuc_led/
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 134 +++---
1 file changed, 106 insertions(+), 28 deletions(-)
diff --git a/drivers/s
Improve the logic in order to support not only S0 brightness,
but also the brightness for other indicators and for all
power states.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 369 --
1 file changed, 249 insertions(+), 120 deletions
The NUC6 WMI API is really simple: it has just 2 messages,
that retrieves everything for a LED, and it has just 2 LEDs.
Add support for retrieving and set brightness and color.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 198 --
1
Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 269 +-
1 file changed, 267 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nuc-led/nuc-wmi.c
b/drivers/staging/nuc-led/nuc-wmi.c
index 78b0a3279f25..5bc4dcec3ea8 100644
--- a/drivers/staging/nuc-le
The is_visible logic for it is plain wrong:
1. it is used only during devnode creation;
2. it was using the wrong field (id, instead of indicator).
Fix it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 30 --
1 file changed, 12
to map the
control option values, it is easy to extend it to support
the new definitions: all we need to do is to add the
V1.0 tables and ensure that the right table will be used.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 119 +-
1
Add routines to allow seeing and changing the LED colors.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 244 --
1 file changed, 228 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/nuc-led/nuc-wmi.c
b/drivers/staging/nuc
The hardware blink logic works for both Power State and Software
controlled LEDs.
Just like brightness, there is one different blink behavior
per different power state. Due to that, the logic is somewhat
more complex than what it would be expected otherwise.
Signed-off-by: Mauro Carvalho Chehab
There are two possible values for HDD activity behavior:
- 0 Normally off, ON when active
- 1 Normally on, OFF when active
Implement a logic to set it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 77 +++
1 file
The power limit indicator may have 2 behaviors:
1. Its color gradually changes from green to red;
2. It displays a single color
Add support for it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 93 +++
1 file changed, 93 insertions
The Ethernet type indicator can be configured to show the status
of LAN1, LAN1 or both. Add support for it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 89 +++
1 file changed, 89 insertions(+)
diff --git a/drivers/staging/nuc-led/nuc
drivers, I'm opting to submit this first to staging.
This should allow adjusting the uAPI if needed, and to get feedback from
people using it on NUC6, NUC10 and on other NUC models that would be
compatible with it.
Mauro Carvalho Chehab (17):
staging: add support for NUC WMI LEDs
staging
t.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/staging/nuc-led/nuc-wmi.c
b/drivers/staging/nuc-led/nuc-wmi.c
index 5bc4dcec3ea8..1a6e2b17c888 100644
--- a/drivers/staging/nuc-led/nuc-w
drivers/staging/nuc-led/nuc-wmi.c: In function ‘nuc_nmi_cmd’:
drivers/staging/nuc-led/nuc-wmi.c:242:6: warning: variable ‘size’ set
but not used [-Wunused-but-set-variable]
242 | int size, ret;
| ^~~~
Signed-off-by: Mauro Carvalho Chehab
/content/dam/support/us/en/documents/intel-nuc/WMI-Spec-Intel-NUC-NUC10ixFNx.pdf
Add a logic to detect between them, preventing the driver
to work with an unsupported version.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 30 +++---
1 file
Now that the core logic is in place, let's add support to
adjust the S0 brightness level.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/nuc-led/nuc-wmi.c | 79 +++
1 file changed, 79 insertions(+)
diff --git a/drivers/staging/nuc-led/nuc-wmi.c
b/dr
Em Wed, 28 Apr 2021 17:50:08 +0200
Johan Hovold escreveu:
> On Wed, Apr 28, 2021 at 04:51:21PM +0200, Mauro Carvalho Chehab wrote:
> > 1. despite its name, this is actually a PM runtime resume call,
> >but some developers didn't seem to realize that, as I got this
&g
Em Wed, 28 Apr 2021 17:09:57 +0200
Johan Hovold escreveu:
> On Wed, Apr 28, 2021 at 04:51:41PM +0200, Mauro Carvalho Chehab wrote:
> > The pm_runtime_get_sync() internally increments the
> > dev->power.usage_count without decrementing it, even on errors.
> &g
Em Wed, 28 Apr 2021 14:17:50 -0300
Ezequiel Garcia escreveu:
> Hi Mauro,
>
> Thanks a lot for taking care of this.
>
> On Wed, 2021-04-28 at 16:52 +0200, Mauro Carvalho Chehab wrote:
> > The device_run() first enables the clock and then
> > tries to resume PM r
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
r to properly decrement the usage counter and avoid memory
leaks.
Reviewed-by: Ezequiel Garcia
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/rkvdec/rkvdec.c
b/drivers/
're getting rid of the pm_runtime_get_sync() call all over
the media subsystem, let's remove the last occurrence on this
driver.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/hantro/hantro_drv.c | 23 ---
1 file changed, 16 insertions(+), 7 deleti
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
The device_run() first enables the clock and then
tries to resume PM runtime, checking for errors.
Well, if for some reason the pm_runtime can not resume,
it would be better to detect it beforehand.
So, change the order inside device_run().
Signed-off-by: Mauro Carvalho Chehab
---
drivers
s are now more conservative in order to avoid causing
regressions.
v3:
- fix a compilation error;
v2:
- addressed pointed issues and fixed a few other PM issues.
Mauro Carvalho Chehab (79):
media: venus: fix PM runtime logic at venus_sys_error_handler()
media: s6p_cec: decrement usage
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Miguel Silva
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c
b/drivers/staging/media/imx/imx7-mipi-csis.c
index 025fdc488bd6..1dc680d94a46
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Em Tue, 27 Apr 2021 14:47:01 +0300
Dmitry Osipenko escreveu:
> 27.04.2021 13:26, Mauro Carvalho Chehab пишет:
> > @@ -1088,8 +1090,9 @@ static int tegra_vde_remove(struct platform_device
> > *pdev)
> > {
> > struct tegra_vde *vde = platform_get_drvdata(pdev);
Em Wed, 28 Apr 2021 08:27:42 +0200
Mauro Carvalho Chehab escreveu:
> Em Tue, 27 Apr 2021 12:18:32 -0300
> Ezequiel Garcia escreveu:
>
> > On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote:
> > > On 2021-04-27 11:27, Mauro Carvalho Chehab wrote:
> > &
Em Tue, 27 Apr 2021 12:18:32 -0300
Ezequiel Garcia escreveu:
> On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote:
> > On 2021-04-27 11:27, Mauro Carvalho Chehab wrote:
> > > Despite other *_get()/*_put() functions, where usage count is
> > > incremen
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Miguel Silva
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c
b/drivers/staging/media/imx/imx7-mipi-csis.c
index 025fdc488bd6..1dc680d94a46
m;
patches 21 to 78 repaces pm_runtime_get_sync() by
pm_runtime_resume_and_get();
Patch 79 (and a hunk on patch 78) documents the two exceptions
where pm_runtime_get_sync() will still be used for now.
---
v3: - fix a compilation error;
v2: - addressed pointed issues and fixed a few other PM issues
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
onale for
keep using pm_runtime_get_sync().
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/hantro/hantro_drv.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/media/hantro/hantro_drv.c
b/drivers/staging/media/hantro/hantro_drv.c
index 595e82a
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
r to properly decrement the usage counter and avoid memory
leaks.
Reviewed-by: Ezequiel Garcia
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/rkvdec/rkvdec.c
b/drivers/
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
onale for
keep using pm_runtime_get_sync().
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/hantro/hantro_drv.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/media/hantro/hantro_drv.c
b/drivers/staging/media/hantro/hantro_drv.c
index 595e82a
r to properly decrement the usage counter and avoid memory
leaks.
Reviewed-by: Ezequiel Garcia
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/rkvdec/rkvdec.c
b/drivers/
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Miguel Silva
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c
b/drivers/staging/media/imx/imx7-mipi-csis.c
index 025fdc488bd6..1dc680d94a46
m;
patches 21 to 78 repaces pm_runtime_get_sync() by
pm_runtime_resume_and_get();
Patch 79 (and a hunk on patch 78) documents the two exceptions
where pm_runtime_get_sync() will still be used for now.
Mauro Carvalho Chehab (79):
media: venus: fix PM runtime logic at venus_sys_error_handler()
media:
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Hi Dmitry,
Em Sat, 24 Apr 2021 10:35:22 +0300
Dmitry Osipenko escreveu:
> 24.04.2021 09:44, Mauro Carvalho Chehab пишет:
> > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal
> > with usage counter")
> > added pm_runtime_resume_and_get() i
Em Mon, 26 Apr 2021 14:33:27 +0200
Mauro Carvalho Chehab escreveu:
> Em Sat, 24 Apr 2021 20:23:53 -0300
> Ezequiel Garcia escreveu:
>
> > Hi Mauro,
> >
> > On Sat, 2021-04-24 at 08:44 +0200, Mauro Carvalho Chehab wrote:
> > > Commit dd8088d5a896 ("P
Em Sat, 24 Apr 2021 20:23:53 -0300
Ezequiel Garcia escreveu:
> Hi Mauro,
>
> On Sat, 2021-04-24 at 08:44 +0200, Mauro Carvalho Chehab wrote:
> > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal
> > with usage counter")
> > added pm
newer ones.
compile-tested only.
Mauro Carvalho Chehab (78):
media: atmel: properly get pm_runtime
media: marvel-ccic: fix some issues when getting pm_runtime
media: mdk-mdp: fix pm_runtime_get_sync() usage count
media: rcar_fdp1: fix usage count
media: mdk-mdp: fix pm_runtime_get_sync() u
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
Use the new API, in order to cleanup the error check logic.
Signed-off-by: M
r to properly decrement the usage counter and avoid memory
leaks.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/rkvdec/rkvdec.c
b/drivers/staging/media/rkvdec/rkvdec.c
index
Em Sat, 17 Apr 2021 21:06:27 +0530
Ashish Kalra escreveu:
> Upon running sparse, "warning: dubious: !x | !y" is brought to notice
> for this file. Logical and bitwise OR are basically the same in this
> context so it doesn't cause a runtime bug. But let's change it to
> logical OR to make it cl
Em Fri, 5 Feb 2021 16:19:47 -0600
Rob Herring escreveu:
> On Tue, Jan 19, 2021 at 05:10:43PM +0100, Mauro Carvalho Chehab wrote:
> > The Hisilicon 6421v600 SPMI driver is ready for mainstream.
> >
> > So, move it from staging.
> >
> > Signed-off-by: Mauro Carva
Em Mon, 14 Dec 2020 12:01:56 +0100
Philipp Gerlesberger escreveu:
> Logical continuations should be on the previous line
>
> Co-developed-by: Andrey Khlopkov
> Signed-off-by: Andrey Khlopkov
> Signed-off-by: Philipp Gerlesberger
> ---
> drivers/staging/media/atomisp/pci/runtime/queue/src/que
Em Mon, 14 Dec 2020 12:01:50 +0100
Philipp Gerlesberger escreveu:
> Remov defines, they don't make sense.
> The programmer should know what things need to be static and what not.
> Also leave "inline" out and let the compiler decide
>
> Co-developed-by: Andrey Khlopkov
> Signed-off-by: Andrey K
A previous cleanup patch removed the usage of the ret var.
So, drop it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c
b/drivers/staging/media
regulator,
SPMI controller and MFD.
I'll submit the final patch with USB bindings after having
everything set (e.g. after 5.12-rc1).
-
v8: contains a fix for REGMAP dependencies and for a build breakage.
Mauro Carvalho Chehab (14):
staging: hikey9xx: spmi driver: convert to regmap
st
Now that the driver was ported to use regmap, let's use
some help functions in order to simplify the code a little
bit.
Suggested-by: Mark Brown
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/hi6421v600-regulator.c | 45 ++-
1 file changed, 3 insertions(+
This driver is ready for mainstream. So, move it out of staging.
Signed-off-by: Mauro Carvalho Chehab
---
.../mfd}/hisilicon,hi6421-spmi-pmic.yaml | 0
MAINTAINERS| 7 +++
drivers/mfd/Kconfig| 16
The phy USB3 driver for Hisilicon 970 (hi3670) is ready
for mainstream. Mode it from staging into the main driver's
phy/ directory.
Signed-off-by: Mauro Carvalho Chehab
---
.../bindings/phy/hisilicon,hi3670-usb3.yaml | 0
MAINTAINERS
The Hisilicon 6421v600 SPMI driver is ready for mainstream.
So, move it from staging.
Signed-off-by: Mauro Carvalho Chehab
---
.../spmi}/hisilicon,hisi-spmi-controller.yaml | 0
MAINTAINERS | 7 +++
drivers/spmi/Kconfig
This driver is ready for mainstream. Move it out of staging.
Signed-off-by: Mauro Carvalho Chehab
---
MAINTAINERS | 7 +--
drivers/regulator/Kconfig| 9 +
drivers/regulator/Makefile | 1
The conversion to regmap introduced a regression at the code
which reads from the IRQ register. Address that.
Fixes: 8148fe6afb24 ("staging: hikey9xx: spmi driver: convert to regmap")
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 2 +-
1 file
Cleanup the error handling code, making the messages more
consistent and removing an uneeded call to free_irq().
While here, also remove debug messages and make the
error messages more consistent.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 50
- When referring to regmap, rename map to regmap
- inside hi6421-spmi-pmic, call private data struct as
ddata.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 104 +-
.../staging/hikey9xx/hi6421v600-regulator.c
At PMIC subsystem, C89 comments are preferred over C99.
While here, also update the copyrights of the header file.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 14 +++---
include/linux/mfd/hi6421-spmi-pmic.h| 1 +
2 files changed, 8
Remove the IRQ list from the header, as this is used only
inside the driver itself. Also, get rid of two unused
defines.
The net result is that only struct hi6421_spmi_pmic remains
on it, as this is used by the regulator driver.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx
- Use BIT() and GENMASK();
- Remove duplicated mask definitions;
- Simplify the code under IRQ handler;
- Add a few extra blank lines to make easier to see
spin_lock/spin_unlock;
- Remove debug code;
- Fix a few minor coding style issues.
Signed-off-by: Mauro Carvalho Chehab
---
drivers
Make it clearer about how the IRQ registers are filled by adding
a table with them, with two macros used to calculate the mask
register.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 39 +
1 file changed, 32 insertions(+), 7 deletions
Instead of doing its own SPMI I/O implementation, use the
already-existing regmap one.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/Kconfig | 2 +
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 115 ++
.../staging/hikey9xx/hi6421v600
Em Fri, 29 Jan 2021 16:45:11 +0100
Greg Kroah-Hartman escreveu:
> On Fri, Jan 29, 2021 at 04:03:36PM +0100, Mauro Carvalho Chehab wrote:
> > Instead of doing its own SPMI I/O implementation, use the
> > already-existing regmap one.
> >
> > Signed-of
The Hisilicon 6421v600 SPMI driver is ready for mainstream.
So, move it from staging.
Signed-off-by: Mauro Carvalho Chehab
---
.../spmi/hisilicon,hisi-spmi-controller.yaml | 75
MAINTAINERS | 7 +
drivers/spmi/Kconfig | 9
regulator,
SPMI controller and MFD.
I'll submit the final patch with USB bindings after having
everything set (e.g. after 5.12-rc1).
Mauro Carvalho Chehab (14):
staging: hikey9xx: spmi driver: convert to regmap
staging: hikey9xx: hi6421v600-regulator: use some regmap helpers
st
The phy USB3 driver for Hisilicon 970 (hi3670) is ready
for mainstream. Mode it from staging into the main driver's
phy/ directory.
Signed-off-by: Mauro Carvalho Chehab
---
.../bindings/phy/hisilicon,hi3670-usb3.yaml | 73 ++
MAINTAINERS | 9 +-
dr
This driver is ready for mainstream. So, move it out of staging.
Signed-off-by: Mauro Carvalho Chehab
---
.../mfd/hisilicon,hi6421-spmi-pmic.yaml | 135
MAINTAINERS | 7 +
drivers/mfd/Kconfig | 15 +
drivers/mfd
Make it clearer about how the IRQ registers are filled by adding
a table with them, with two macros used to calculate the mask
register.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 38 +
1 file changed, 31 insertions(+), 7 deletions
Now that the driver was ported to use regmap, let's use
some help functions in order to simplify the code a little
bit.
Suggested-by: Mark Brown
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/hi6421v600-regulator.c | 45 ++-
1 file changed, 3 insertions(+
- When referring to regmap, rename map to regmap
- inside hi6421-spmi-pmic, call private data struct as
ddata.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 104 +-
.../staging/hikey9xx/hi6421v600-regulator.c
This driver is ready for mainstream. Move it out of staging.
Signed-off-by: Mauro Carvalho Chehab
---
MAINTAINERS | 7 +-
drivers/regulator/Kconfig | 8 +
drivers/regulator/Makefile| 1 +
drivers/regulator
1 - 100 of 920 matches
Mail list logo
