Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket

2015-03-24 Thread Nick Krause
On Tue, Mar 24, 2015 at 9:20 AM, Joe Perches wrote: > On Tue, 2015-03-24 at 16:00 +0300, Dan Carpenter wrote: >> On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote: >> > Just one more question, is that patch going to be merged or should I >> > resubmit >> > it as a series of one patc

Re: [PATCHv3] staging: Check for Null allocated skb in fw_download_code

2014-08-11 Thread Nick Krause
On Mon, Aug 11, 2014 at 7:12 PM, Nicholas Krause wrote: > I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461. > This entry states that we are not checking the skb allocated in > fw_download_code > for NULL and after checking it ,I fixed it to check for the NULL value be

Re: [PATCHv2] staging: Check against NULL in fw_download_code

2014-08-11 Thread Nick Krause
On Mon, Aug 11, 2014 at 5:48 PM, Jerry Snitselaar wrote: > On Mon Aug 11 14, Nicholas Krause wrote: >> I am fixing the bug entry , >> https://bugzilla.kernel.org/show_bug.cgi?id=60461. >> This entry states that we are not checking the skb allocated in >> fw_download_code >> and after checking I

Re: [PATCH] staging: Check against NULL in fw_download_code

2014-08-11 Thread Nick Krause
Thanks Randy for checking this I am going to resend as a v2 patch. Regards Nick On Mon, Aug 11, 2014 at 3:40 PM, Randy Dunlap wrote: > On 08/11/14 12:18, Nick Krause wrote: >> >> Thanks Randy for your help otherwise is my patch good? Please let me >> known if there

Re: [PATCH] staging: Check against NULL in fw_download_code

2014-08-11 Thread Nick Krause
On Mon, Aug 11, 2014 at 3:04 PM, Randy Dunlap wrote: > On 08/11/14 11:55, Nick Krause wrote: >> On Mon, Aug 11, 2014 at 2:45 PM, Randy Dunlap wrote: >>> On 08/11/14 11:26, Nick Krause wrote: >>>> On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap >>>> w

Re: [PATCH] staging: Check against NULL in fw_download_code

2014-08-11 Thread Nick Krause
On Mon, Aug 11, 2014 at 2:45 PM, Randy Dunlap wrote: > On 08/11/14 11:26, Nick Krause wrote: >> On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap wrote: >>> On 08/11/14 11:04, Nick Krause wrote: >>>> On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause >>>&

Re: [PATCH] staging: Check against NULL in fw_download_code

2014-08-11 Thread Nick Krause
On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap wrote: > On 08/11/14 11:04, Nick Krause wrote: >> On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause wrote: >>> I am fixing the bug entry , >>> https://bugzilla.kernel.org/show_bug.cgi?id=60461. >>> This entry sta

Re: [PATCH] staging: Check against NULL in fw_download_code

2014-08-11 Thread Nick Krause
On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause wrote: > I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461. > This entry states that we are not checking the skb allocated in > fw_download_code > and after checking I fixed it to check for the NULL value before using th

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 11:34 PM, Chen Gang wrote: > > > On 07/25/2014 11:30 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 11:13 AM, Nick Krause wrote: >>>> On Thu, Jul 24, 2014 at 11:

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote: > > > On 07/25/2014 11:13 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 10:53 AM, Nick Krause wrote: >>>> On Thu, Jul 24, 2014 at 10:

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: > > > On 07/25/2014 10:53 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 10:20 AM, Nick Krause wrote: >>>> On Thu, Jul 24, 2014 at 10:1

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: > > > On 07/25/2014 10:20 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: >>> >>> Excuse me, I did not see the patch details, but I guess it is about >>> whether welcome

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: > > Excuse me, I did not see the patch details, but I guess it is about > whether welcome a new member to upstream kernel. For me, I have 3 ideas > about it if I am a newbie or a normal kernel developer: > > - Do I have enough basic skills for it

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger > wrote: >> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >>> Steve, >>> I have programming a lot in other areas just not the kernel. >>> You a

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger wrote: > On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >> Steve, >> I have programming a lot in other areas just not the kernel. >> You are right through I need to test my code better through. > > Nick, > &

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 1:48 PM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 10:30:51 -0700 > Harvey Harrison wrote: > >> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: >> > On Thu, 24 Jul 2014 12:50:31 -0400 >> > Nick Krause wrote: >> >>

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 12:47 PM, Måns Rullgård wrote: > Nick Krause writes: > >> On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: >>> Nick Krause writes: >>> >>>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >>>>> Steve

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: > Nick Krause writes: > >> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >>> Steven Rostedt writes: >>> >>>> On Thu, 24 Jul 2014 10:47:25 -0400 >>>> Steven Rostedt wrote: >

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: > Steven Rostedt writes: > >> On Thu, 24 Jul 2014 10:47:25 -0400 >> Steven Rostedt wrote: >> >>> The three parameters are the number of elements, the size of each individual >>> element, and then finally the flags used on how to allocate tha

Re: staging: Unwritten function for ion_carveout_heap.c

2014-07-23 Thread Nick Krause
On Wed, Jul 23, 2014 at 4:10 PM, Colin Cross wrote: > On Wed, Jul 23, 2014 at 1:04 PM, Nick Krause wrote: >> Hey Greg and others. >> Sorry for another email but it seems the function, >> ion_carveout_heap_unmap_dma is >> just returning and not doing anything useful. F

staging: Unwritten function for ion_carveout_heap.c

2014-07-23 Thread Nick Krause
Hey Greg and others. Sorry for another email but it seems the function, ion_carveout_heap_unmap_dma is just returning and not doing anything useful. Furthermore I am new so I don't known how to write this function but this may be causing some rather serious bugs as if the dma heap is not unmaped

Re: [PATCH] staging: Fix a Fix me in tranzport.c

2014-07-19 Thread Nick Krause
On Sat, Jul 19, 2014 at 5:14 AM, Dan Carpenter wrote: > On Sat, Jul 19, 2014 at 12:09:53PM +0300, Dan Carpenter wrote: >> On Sat, Jul 19, 2014 at 01:26:52AM -0400, Nicholas Krause wrote: >> > This patch add a atomic lock in usb_tranzport_usb for preventing >> > a tiny race in this function. >> > >

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Nick Krause
Is this patch being merged or is this not an issue. I am confused did I make a mistake in my patch or is there being a different patch being merged. Thank Nick On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote: > On Fri, 2014-06-20 at 22:26 -0400, Nick Krause wrote: >> Thanks for the

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Nick Krause
Thanks for the feedback I will resend the patch fixed. Otherwise please use Larry's idea. Cheers Nick On Fri, Jun 20, 2014 at 4:08 PM, Joe Perches wrote: > On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote: >> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote: >> > Rewrites the

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-20 Thread Nick Krause
This patch is old I thought I fixed it and resent. Cheers Nick On Thu, Jun 19, 2014 at 5:25 PM, Joe Perches wrote: > On Thu, 2014-06-19 at 15:29 -0400, Nicholas Krause wrote: > >> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c >> b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmw

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nick Krause
Our you Guys just removing me from your emails I have checked this patch and it seems right. If you don't want to accept it , the less you can do is give me a reply. Nick On Thu, Jun 19, 2014 at 10:12 PM, Nick Krause wrote: > If anyone able to check this patch it would be great. >

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nick Krause
If anyone able to check this patch it would be great. Thanks Nick On Thu, Jun 19, 2014 at 5:18 PM, Nicholas Krause wrote: > Checks for Null return from dev_skb_alloc if it returns Null, > fw_download returns false. Otherwise it returns true.Also > removed rt_status due to returning true of false

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nick Krause
Thanks Joe, I need to read my patches more carefully. Nick :) On Thu, Jun 19, 2014 at 4:53 PM, Joe Perches wrote: > On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote: >> Hey Guys, >> So Sorry about wasting your time with bad patchs. >> I feel bad about that. I hope this

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nick Krause
Hey Guys, So Sorry about wasting your time with bad patchs. I feel bad about that. I hope this patch is O.K. now. :( Nicholas Krause On Thu, Jun 19, 2014 at 4:18 PM, Nicholas Krause wrote: > Checks for Null return from dev_skb_alloc if it returns Null, > fw_download returns false. Otherwise it re

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-19 Thread Nick Krause
Hey guys, Sorry about no reply, my power supply died last night, have to get a new one. I will be RMAing the old old in order to get a packup in case this PSU dies. Cheers Nick On Thu, Jun 19, 2014 at 1:29 AM, Dan Carpenter wrote: > On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrot

Re: [PATCH] Checks for Null return of skb_alloc in function fw_download_code

2014-06-18 Thread Nick Krause
So sorry Greg, I pulled the git in this morning for kernel-3.16-r2 ,I will resend the patch from the clean tree. I will also fix the tabs.' Sorry :( Nick On Wed, Jun 18, 2014 at 2:14 PM, Greg KH wrote: > On Wed, Jun 18, 2014 at 01:53:00PM -0400, Nicholas Krause wrote: >> Signed-off-by: Nicholas K

PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]

2014-06-11 Thread Nick Krause
Hey Fellow Developers, This is my first patch so if there are any errors please reply as i will fix them. Below is the patch. -- drivers/vme/bridges/vme_ca91cx42.h.orig    2014-06-11 22:50:29.339671939 -0400 +++ drivers/vme/bridges/vme_ca91cx42.h    2014-06-11 23:15:36.027685173 -0400 @@ -526,7