[PATCH] drivers: staging: lustre: replace variable length array by dynamic allocation

Fixes the following sparse warnings: drivers/staging/lustre/lustre/llite/xattr.c:89:62: warning: Variable length array is used. drivers/staging/lustre/lustre/llite/xattr.c:366:62: warning: Variable length array is used. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- d

[PATCH] drivers: staging: ccree: ISO C forbids casting to and from non-scalar

: cast from non-scalar Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/ccree/ssi_hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c index 162d17dee2cd..8585f7

[PATCH staging/rtl8712] staging: rtl8712: checkpatch cleanup: block comments using a trailing */

Fix checkpatch.pl warning "Block comments use a trailing */ on a separate line" on multiple files of the driver by editing the affected comments. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8712/rtl8712_led.c | 12 -- drivers

[PATCHv4 2/2] staging: rtl8192u: r8192U_core: reuse local temporary variables to keep lines under 80 characters

Reuse some local temporary variables to reduce line length under the maximum of 80 characters, as per the kernel code style. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [PATCHv3 02/15] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

2015-09-20 22:16 GMT-04:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>: > On Sun, Sep 20, 2015 at 01:14:14PM -0400, Raphaël Beamonte wrote: >> Add some temporary variables to reduce line length under the maximum >> of 80 characters, as per the kernel code style. >>

[PATCHv3 02/15] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

Add some temporary variables to reduce line length under the maximum of 80 characters, as per the kernel code style. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 139 ++--- 1 file changed, 94 inse

[PATCHv3 01/15] staging: rtl8192u: r8192U_core: add line breaks to keep lines under 80 characters

Add line breaks in multiple lines to keep them under 80 characters, as to follow the kernel code style. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 608 ++--- 1 file changed, 409 insertions(+

[PATCHv3 00/15] staging: rtl8192u: code clean up

an existing variable (patch 02) Thanks, - R. Raphaël Beamonte (15): staging: rtl8192u: r8192U_core: add line breaks to keep lines under 80 characters staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters staging: rtl8192u: r8192U_core: reverse

[PATCHv3 03/15] staging: rtl8192u: r8192U_core: reverse conditions to get lines under 80 characters

Reverse some conditions to clean the code and allow to have lines under 80 characters, as to follow the kernel code style. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 48 ++ 1 file chang

[PATCHv3 05/15] staging: rtl8192u: r8192U_core: rtl8192_read_eeprom_info: reorganize function

Refactor code to avoid multiple check of same boolean value, and to make the code clearer. This patches also implements the necessary changes for the code lines in this function to be under 80 chars. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rt

[PATCHv3 07/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_index to sb_index

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rt

[PATCHv3 04/15] staging: rtl8192u: r8192U_core: rtl8192_adapter_start: reorganize function

Reverse conditions and use goto in the function rtl8192_adapter_start to have most of it under 80 characters per line. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 91 ++ 1 file changed, 47 inse

[PATCHv3 15/15] staging: rtl8192u: remove all code framed by symbol TO_DO_LIST

The symbol TO_DO_LIST was used in the code to frame sections of code unused or unusable. This patch remove all code framed by that symbol in this driver. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 +- drivers/s

[PATCHv3 09/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: remove unneeded variable

Local variable last_beacon_adc_pwdb was used to store a value that wasn't used after. This patch removes that variable. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCHv3 10/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable rfpath to rfp

Rename variable to a shorter name to allow easier code refactoring in following patches. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff

[PATCHv3 11/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: reorganize function

Reorganize function to make it cleaner, and respect the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 140 +++-- 1 file changed, 81 insertions(+), 59 deletions(-)

[PATCHv3 08/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_statistics to sb_stats

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rt

[PATCHv3 06/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable pprevious_stats to prev_stats

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 84 +- 1 file changed, 42 insertions(+), 42 deletions(-) diff

[PATCHv3 12/15] staging: rtl8192u: r8192U_core: rtl8192_tx: replace some inline conditions

Replace some inline conditions by a full if-else statement to make the source clearer and follow the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 16 +++- 1 file changed, 11 inse

[PATCHv3 13/15] staging: rtl8192u: r8192U_core: rtl8192_ioctl: reorganize function

Reorganize function rtl8192_ioctl to replace a switch with only one case besides the default by an if statement. This also allows to follow the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c

Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

2015-09-17 1:18 GMT-04:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>: > On Thu, Sep 17, 2015 at 01:06:33AM -0400, Raphaël Beamonte wrote: >> 2015-09-17 0:57 GMT-04:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>: >> >> >> @@ -1748,8 +1755,9 @@ static

Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

2015-09-17 0:57 GMT-04:00 Greg Kroah-Hartman : >> @@ -1748,8 +1755,9 @@ static short rtl8192_usb_initendpoints(struct >> net_device *dev) >> oldaddr = priv->oldaddr; >> align = ((long)oldaddr) & 3; >> if (align) { >> -

Re: [PATCH] staging/rtl8192u: remove unused function

2015-09-14 14:00 GMT-04:00 Nicolas Joseph : > Remove N_DBPSOfRate used in ComputeTxTime, remove by > commit 742728f97a99 ("staging: rtl8192u: remove unused function.") > > Signed-off-by: Nicolas Joseph > --- >

[PATCHv2 11/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable rfpath to rfp

Rename variable to a shorter name to allow easier code refactoring in following patches. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff

[PATCHv2 14/16] staging: rtl8192u: r8192U_core: rtl8192_ioctl: reorganize function

Reorganize function rtl8192_ioctl to replace a switch with only one case besides the default by an if statement. This also allows to follow the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c

[PATCHv2 16/16] staging: rtl8192u: remove all code framed by symbol TO_DO_LIST

The symbol TO_DO_LIST was used in the code to frame sections of code unused or unusable. This patch remove all code framed by that symbol in this driver. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 +- drivers/s

[PATCHv2 15/16] staging: rtl8192u: r8192U_core: replace else { if() {} } by else if () {}

An else block only contained an if statement. Replace that else block by an else if block instead. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/d

[PATCHv2 12/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: reorganize function

Reorganize function to make it cleaner, and respect the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 140 +++-- 1 file changed, 81 insertions(+), 59 deletions(-)

[PATCHv2 07/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable pprevious_stats to prev_stats

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 84 +- 1 file changed, 42 insertions(+), 42 deletions(-) diff

[PATCHv2 08/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_index to sb_index

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rt

[PATCHv2 13/16] staging: rtl8192u: r8192U_core: rtl8192_tx: replace some inline conditions

Replace some inline conditions by a full if-else statement to make the source clearer and follow the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 16 +++- 1 file changed, 11 inse

[PATCHv2 10/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: remove unneeded variable

Local variable last_beacon_adc_pwdb was used to store a value that wasn't used after. This patch removes that variable. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCHv2 09/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_statistics to sb_stats

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rt

[PATCHv2 06/16] staging: rtl8192u: r8192U_core: rtl8192_read_eeprom_info: reorganize function

Refactor code to avoid multiple check of same boolean value, and to make the code clearer. This patches also implements the necessary changes for the code lines in this function to be under 80 chars. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rt

[PATCHv2 02/16] staging: rtl8192u: r8192U_core: add line breaks to keep lines under 80 characters

Add line breaks in multiple lines to keep them under 80 characters, as to follow the kernel code style. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 626 ++--- 1 file changed, 421 insertions(+

[PATCHv2 05/16] staging: rtl8192u: r8192U_core: rtl8192_adapter_start: reorganize function

Reverse conditions and use goto in the function rtl8192_adapter_start to have most of it under 80 characters per line. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 91 ++ 1 file changed, 47 inse

[PATCHv2 04/16] staging: rtl8192u: r8192U_core: reverse conditions to get lines under 80 characters

Reverse some conditions to clean the code and allow to have lines under 80 characters, as to follow the kernel code style. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 48 ++ 1 file chang

[PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

Add some temporary variables to reduce line length under the maximum of 80 characters, as per the kernel code style. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c | 139 ++--- 1 file changed, 94 inse

[PATCHv2 01/16] staging: rtl8192u: r8192U_core: fix comments lines over 80 characters

Move, replace and reorganize comments to stay under 80 characters per line, as to follow the kernel code style. Some unuseful comments have been removed. Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_core.c

[PATCHv2 00/16] staging: rtl8192u: code clean up

the original content. The last patch gets rid of the last WARNING of checkpatch about the 80 lines, as well as the TO_DO_LIST macro that was used in that module to comment out unused or unusable code. Thanks, - R. [1]: https://lkml.org/lkml/2015/8/19/173 Raphaël Beamonte (16): staging: rtl8192u

Re: [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER()

Oh well. Actually you did it. I answered while pulling the git... Sorry for that unuseful mail! :) 2015-09-05 12:25 GMT-04:00 Raphaël Beamonte <raphael.beamo...@gmail.com>: > 2015-09-02 21:19 GMT-04:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>: >> Turns out this fil

Re: [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER()

2015-09-02 21:19 GMT-04:00 Greg Kroah-Hartman : > Turns out this file is never even built, you should just remove it :) You're right, although it seems that is one of the "To-dos" of that module, as the references I find about the config variable to allow the compiling

Re: [PATCHv2 18/19] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

2015-09-03 13:00 GMT-04:00 Greg Kroah-Hartman : > You need to prove that they are aligned before I can take this patch :( Right! I looked at those structs using pahole. The structs used are net_device from include/linux/netdevice.h and sockaddr from

[PATCHv2] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

drivers/net/ethernet/intel/i40e/i40e_main.c drivers/net/ethernet/mellanox/mlx5/core/en_main.c drivers/net/usb/lan78xx.c net/8021q/vlan_dev.c net/batman-adv/soft-interface.c net/dsa/slave.c Signed-off-by: Raphaël Beamonte <raphael.beamo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_

Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

2015-08-18 1:44 GMT-04:00 Sudip Mukherjee sudipm.mukher...@gmail.com: I think that will be better, since you are sending the patch for consistent spacing. Actually, going through the bunch of patches, it seems that the whitespace neatening one is taking care of that. That one patch was mostly

[PATCHv2 02/19] staging: rtl8192u: r8192U_core: fix space before close parenthesis code style error

A space existed before the close parenthesis of an if statement. This patch removes it to follow the kernel code style. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv2 13/19] staging: rtl8192u: r8192U_core: fix unnecessary parentheses code style issue

Two sets of parentheses were used to contain the same statement. In those cases, one of them has been removed, as unnecessary. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCHv2 18/19] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b

[PATCHv2 12/19] staging: rtl8192u: r8192U_core: fix unnecessary check before kfree code style issue

kfree(NULL) is safe and the checks were not required. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging

[PATCHv2 17/19] staging: rtl8192u: r8192U_core: fix quoted string split across lines code style issue

Quoted strings should not be split to help text grep in the source. All quoted strings that were split have thus been merged to one unique quoted string each to follow the code style. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 8

[PATCHv2 09/19] staging: rtl8192u: r8192U_core: remove return statement of void function

void function return statement was not useful in this case. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c

[PATCHv2 19/19] staging: rtl8192u: r8192U_core: fix line over 80 characters code style issue

Light code refactoring to keep the lines under 80 characters to follow the kernel code style. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 1248 ++-- 1 file changed, 850 insertions(+), 398 deletions(-) diff

[PATCHv2 10/19] staging: rtl8192u: r8192U_core: fix unecessary braces code style issue

braces {} are not necessary for any arm of a statement containing one statement on each side. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging

Re: [PATCHv3] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

2015-08-18 5:15 GMT-04:00 Dan Carpenter dan.carpen...@oracle.com: To be honest, I have lost track of this patchset. If you are planning to redo the other patches can you send it in a new thread? Actually, Greg already included the return statement and DECLARE_WILC_BUFFER ones. The replacement

[PATCHv2 08/19] staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h

Use #include linux/uaccess.h instead of asm/uaccess.h Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u

[PATCHv2 06/19] staging: rtl8192u: r8192U_core: whitespace neatening to fix consistent spacing code style errors

Clean-up the file by using a cleaner spacing around symbols and words. Mostly use the automatic checkpatch whitespacing fixes. This takes care of the consistent spacing errors reported by checkpatch. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u

[PATCHv2 01/19] staging: rtl8192u: r8192U_core: fix switch and case indent code style error

Some switch and case were not be at the same indent level. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 190 - 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCHv2 04/19] staging: rtl8192u: r8192U_core: fix else following close brace code style error

Fix else should follow close brace checkpatch error. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u

[PATCHv2 05/19] staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing code style error

A missing struct keyword in variable declaration triggered a need consistent spacing around '*' code style error. The struct keyword thus has been added everywhere for the rtl8192_rx_info struct, and therefore its typedef removed as not needed anymore. Signed-off-by: Raphaël Beamonte

[PATCHv2 11/19] staging: rtl8192u: r8192U_core: remove forward declarations in .c file

Checkpatch was giving a externs should be avoided in .c files because of these forward declarations. As these were not useful in this case, they have been removed. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 6 -- 1 file changed, 6

[PATCHv2 07/19] staging: rtl8192u: r8192U_core: clean C99 // comments

Replace C99 // comments by /* comments */ to follow the kernel code style. Remove some unuseful comments. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 636 - 1 file changed, 316 insertions(+), 320

[PATCHv2 15/19] staging: rtl8192u: r8192U_core: fix unnecessary whitespace code style issue

Whitespaces are not necessary before a quoted newline. Remove those. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b

[PATCHv2 16/19] staging: rtl8192u: r8192U_core: fix missing blank line after declarations code style issue

Adds whitespaces to separate the variables declarations and the function content. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 44 +++--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCHv2 00/19] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports

, 4909 lines checked And after patches: total: 0 errors, 0 warnings, 5379 lines checked Please let me know if there is anything else I can do to improve these patches! Thanks, Raphaël Raphaël Beamonte (19): staging: rtl8192u: r8192U_core: fix switch and case indent code style error

[PATCHv2 14/19] staging: rtl8192u: r8192U_core: fix unnecessary else after return code style issue

An else statement is not useful after a return. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b

[PATCHv4 0/2] staging: wilc1000: code improvements

Hi, As requested, here are the two remaining ready patches of this patchset. I pulled and rebased against staging-testing just now. They should thus be usable without problem! Thanks, Raphaël Raphaël Beamonte (2): staging: wilc1000: remove FREE_WILC_BUFFER() staging: wilc1000: replace

[PATCHv4 2/2] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't take care of possible memory leaks and subsequent bugs when it was failing after succeeding some allocations. This patch corrects this behavior. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging

[PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER()

It was just a wrapper around kfree(), so call that instead. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c b

Re: [PATCHv2 5/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

2015-08-17 15:41 GMT-04:00 Arend van Spriel ar...@broadcom.com: Probable MACRO_WILC_BUFFER should be MALLOC_WILC_BUFFER here. Good catch! There is really no need to print an error message here. kmalloc will blurb enough info when it fails. Ok! So these buffers are globals? So does this

[PATCHv3] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't take care of possible memory leaks and subsequent bugs when it was failing after succeeding some allocations. This patch corrects this behavior. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging

[PATCHv3] staging: wilc1000: use netdev_* instead of printk

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- drivers/staging/wilc1000/linux_wlan.c| 8 drivers/staging/wilc1000/linux_wlan_common.h | 28 ++-- drivers/staging/wilc1000

Re: [PATCH 1/3] staging: wilc1000: code style: fix macro with multiple statements

2015-08-17 5:08 GMT-04:00 Dan Carpenter dan.carpen...@oracle.com: Pull it in one indent level... But actually this macro has a return in the middle of it, so it just introduces bugs all over the place like eating cookies in bed. We should just delete it instead. You're right! I'll clean

Re: [PATCH 12/20] staging: rtl8192u: r8192U_core: fix externs in .c file code style issue

2015-08-18 1:30 GMT-04:00 Sudip Mukherjee sudipm.mukher...@gmail.com: These are not externs. These are forward declarations. I copied the message from checkpatch. Will edit that to make it more accurate! Thanks, Raphaël ___ devel mailing list

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-18 0:24 GMT-04:00 Sudip Mukherjee sudipm.mukher...@gmail.com: + netdev_err([Sendconfigpkt]Get Timed out\n); This will not compile. you can not just replace printk with netdev_*, you need to mention a net_device. You're right! I'm making a lot of mistakes. It

Re: [PATCH 4/5] staging: wilc1000: use pr_* instead of printk

2015-08-17 13:47 GMT-04:00 Dan Carpenter dan.carpen...@oracle.com: - printk([Sendconfigpkt]Get Timed out\n); + pr_debug([Sendconfigpkt]Get Timed out\n); Possibly pr_err()? Yep. My mistake. I'll do the same for Set Timed Out also! -

[PATCH 4/5] staging: wilc1000: use pr_* instead of printk

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- drivers/staging/wilc1000/linux_wlan.c| 8 +++ drivers/staging/wilc1000/linux_wlan_common.h | 32 ++-- drivers/staging/wilc1000

[PATCH 1/5] staging: wilc1000: remove DECLARE_WILC_BUFFER()

It was just a wrapper to initialize a variable. Initialize it directly instead. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/wilc_exported_buf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 3/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

The MACRO_WILC_BUFFER() macro was using a return statement, and didn't take care of possible memory leaks and subsequent bugs when it was failing after succeeding some allocations. This patch corrects this behavior. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging

[PATCH 5/5] staging: wilc1000: remove void function return statements that are not useful

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/host_interface.c| 4 drivers/staging/wilc1000/linux_wlan.c| 1 - drivers/staging/wilc1000/wilc_exported_buf.c | 2 -- drivers/staging/wilc1000/wilc_wlan.c | 3 --- drivers/staging

[PATCHv2 0/5] staging: wilc1000: code improvements

Hi, Following comments from Dan Carpenter, please find the following revised patches. Raphaël Raphaël Beamonte (5): staging: wilc1000: remove void function return statements that are not useful staging: wilc1000: use pr_* instead of printk staging: wilc1000: remove

[PATCHv2 1/5] staging: wilc1000: remove void function return statements that are not useful

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/host_interface.c| 4 drivers/staging/wilc1000/linux_wlan.c| 1 - drivers/staging/wilc1000/wilc_exported_buf.c | 4 +--- drivers/staging/wilc1000/wilc_wlan.c | 3 --- drivers/staging

[PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- drivers/staging/wilc1000/linux_wlan.c| 8 drivers/staging/wilc1000/linux_wlan_common.h | 28 ++-- drivers/staging/wilc1000

[PATCHv2 5/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

The MACRO_WILC_BUFFER() macro was using a return statement, and didn't take care of possible memory leaks and subsequent bugs when it was failing after succeeding some allocations. This patch corrects this behavior. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging

[PATCHv2 4/5] staging: wilc1000: remove FREE_WILC_BUFFER()

It was just a wrapper around kfree(), so call that instead. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c b

[PATCHv2 3/5] staging: wilc1000: remove DECLARE_WILC_BUFFER()

It was just a wrapper to initialize a variable. Initialize it directly instead. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 0/5] staging: wilc1000: code improvements

driver. Raphaël Raphaël Beamonte (5): staging: wilc1000: remove DECLARE_WILC_BUFFER() staging: wilc1000: remove FREE_WILC_BUFFER() staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak staging: wilc1000: use pr_* instead of printk staging: wilc1000: remove

[PATCH 2/5] staging: wilc1000: remove FREE_WILC_BUFFER()

It was just a wrapper around kfree(), so call that instead. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/wilc_exported_buf.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c

[PATCH 00/20] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports

: total: 0 errors, 0 warnings, 5379 lines checked Thanks, Raphaël Raphaël Beamonte (20): staging: rtl8192u: r8192U_core: fix switch and case indent code style error staging: rtl8192u: r8192U_core: fix consistent spacing code style error staging: rtl8192u: t8192U_core: fix space before

[PATCH 09/20] staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h

Use #include linux/uaccess.h instead of asm/uaccess.h Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u

[PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

Fix multiple occurences of the need consistent spacing code style error Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging

[PATCH 18/20] staging: rtl8192u: r8192U_core: fix quoted string split across lines code style issue

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 511e979..0048cff 100644

[PATCH 06/20] staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing code style error

A missing struct keyword in variable declaration triggered a need consistent spacing around '*' code style error. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 05/20] staging: rtl8192u: r8192U_core: fix else following close brace code style error

Fix else should follow close brace code style error. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u

[PATCH 04/20] staging: rtl8192u: r8192U_core: fix code indent using spaces code style error

Fix code indent should use tabs where possible code style error Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging

[PATCH 03/20] staging: rtl8192u: t8192U_core: fix space before close parenthesis code style error

A space existed before the close parenthesis of an if statement. This patch removes it to follow the kernel code style. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 11/20] staging: rtl8192u: r8192U_core: fix unecessary braces code style issue

braces {} are not necessary for any arm of a statement containing one statement on each side. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging

[PATCH 1/3] staging: wilc1000: code style: fix macro with multiple statements

Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/wilc_exported_buf.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 2/3] staging: wilc1000: code style: fix globals initialized to false

Globals should not be initialized to 0 or NULL. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 3/3] staging: wilc1000: code style: fix open brace { on wrong line

Open braces should be on the same line as if and for statements. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/linux_wlan.c | 3 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions

[PATCH 0/3] staging: wilc1000: code style patches

Hello, Please find in following emails code style patches for the driver wilc1000 in staging. Raphaël Raphaël Beamonte (3): staging: wilc1000: code style: fix macro with multiple statements staging: wilc1000: code style: fix globals initialized to false staging: wilc1000: code style: fix

  1   2   >