Hello,
Colin King, le mer. 28 nov. 2018 16:12:32 +, a ecrit:
> - [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly",
> + [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically",
Mmm, clearly an english typo. Speakup people, do you think there might
be any down
Arnd Bergmann, le lun. 10 déc. 2018 22:41:50 +0100, a ecrit:
> In this driver, both function the same way, but we want to eventually
> kill off semaphores, so a completion is the better choice here.
>
> Signed-off-by: Arnd Bergmann
Reviewed-by: Samuel Thibault
> ---
> drive
Greg KH, le mar. 08 janv. 2019 15:25:07 +0100, a ecrit:
> On Tue, Jan 08, 2019 at 09:15:02AM -0500, Kyungtae Kim wrote:
> > On Tue, Jan 8, 2019 at 8:50 AM Greg KH wrote:
> > >
> > > On Tue, Jan 08, 2019 at 08:37:37AM -0500, Kyungtae Kim wrote:
> > > > We report a bug in linux-4.20: "general protec
, tiocmset and input
> functionality for tty")
> Cc: stable # 4.13
> Cc: Okash Khawaja
> Cc: Samuel Thibault
> Signed-off-by: Johan Hovold
Indeed.
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/spk_ttyio.c | 6 --
> 1 file changed,
We often receive patches which erroneously try to use kstrtoul in these
places.
Signed-off-by: Samuel Thibault
---
drivers/staging/speakup/kobjects.c|2 ++
drivers/staging/speakup/main.c|1 +
drivers/staging/speakup/varhandlers.c |1 +
3 files changed, 4 insertions
Bharath Vedartham, le dim. 24 févr. 2019 01:01:21 +0530, a ecrit:
> simple_strtoul is obsolete. Change it to kstrtoul. Kernel is building
> and booting successfully.
Please recheck your patch, temp is used after the simple_strtoul call.
Samuel
___
devel
Hello, and thanks for your patch,
Bharath Vedartham, le dim. 24 févr. 2019 01:51:17 +0530, a ecrit:
> @@ -148,7 +148,7 @@ config SPEAKUP_SYNTH_KEYPC
>
> config SPEAKUP_SYNTH_LTLK
> tristate "DoubleTalk LT/LiteTalk synthesizer support"
> help---
> +help
I'd say while at it, align it w
Greg KH, le dim. 24 févr. 2019 08:59:21 +0100, a ecrit:
> On Sat, Feb 23, 2019 at 08:42:19PM +0100, Samuel Thibault wrote:
> > We often receive patches which erroneously try to use kstrtoul in these
> > places.
> >
> > Signed-off-by: Samuel Thibault
>
> Awe,
Bharath Vedartham, le dim. 24 févr. 2019 18:41:42 +0530, a ecrit:
> Fix the checkpatch.pl warning to replace ---help--- with help in
> Kconfig.
>
> Signed-off-by: Bharath Vedartham
Reviewed-by: Samuel Thibault
Thanks!
> ---
> Changes since v1:
> - Allign help
k from the speakup mailing list, I guess fixing
the typo is fine.
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/i18n.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index cea87
Chris Brannon, le ven. 15 mars 2019 18:19:39 -0700, a ecrit:
> Okash Khawaja writes:
> > Finally there is an issue where text in output buffer sometimes gets
> > garbled on SMP systems, but we can continue working on it after the
> > driver is moved out of staging, if that's okay. Basically we nee
Hello,
Please keep the lists in Cc, so that not only I have the information
(in particular since I will probably *not* have the time to investigate
myself).
Samuel Thibault, le sam. 16 mars 2019 10:35:43 +0100, a ecrit:
> The problem is that neither Okash nor I are even casual users of
> s
Alan Cox, le mar. 19 mars 2019 16:31:21 +, a ecrit:
> On Sat, 16 Mar 2019 10:35:43 +0100
> Samuel Thibault wrote:
> > Chris Brannon, le ven. 15 mars 2019 18:19:39 -0700, a ecrit:
> > > Okash Khawaja writes:
> > > > Finally there is an issue where tex
Colin King, le mar. 30 oct. 2018 11:09:59 +, a ecrit:
> From: Colin Ian King
>
> Trivial fix to clean up indentation issues across the driver
>
> Signed-off-by: Colin Ian King
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c | 2 +-
>
Panir.Nyan, le Wed 24 Dec 2014 04:07:31 +, a écrit :
> Split the comment to fit the length.
>
> Signed-off-by: Panir Nyan
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/synth.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff
Panir.Nyan, le Wed 24 Dec 2014 04:07:32 +, a écrit :
> Combine the consecutive string
>
> Signed-off-by: Panir Nyan
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
Hello,
Okash Khawaja, le sam. 14 sept. 2019 22:08:35 +0100, a ecrit:
> 2. We are still missing descriptions for i18n/ directory. I have added
> filenames below. can someone can add description please:
There are some descriptions in the "14.1. Files Under the i18n
Subdirectory" section of spkguid
Okash Khawaja, le dim. 15 sept. 2019 19:41:30 +0100, a ecrit:
> I have attached the descriptions.
Attachment is missing :)
Samuel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-deve
Greg KH, le jeu. 04 avril 2019 22:35:49 +0200, a ecrit:
> On Thu, Apr 04, 2019 at 08:45:29PM +0100, Okash Khawaja wrote:
> > diff --git a/include/linux/selection.h b/include/linux/selection.h
> > index a8f5b97b216f..171d77dfc825 100644
> > --- a/include/linux/selection.h
> > +++ b/include/linux/sel
Hello,
Madhumitha Prabakaran, le dim. 05 mai 2019 02:26:45 -0500, a ecrit:
> Replace return type and remove the respective assignment.
I prefer to keep it the way it was, it looks more straightforward for
the reader.
Samuel
> Issue found by Coccinelle.
>
> Signed-off-by: Madhumitha Prabakaran
deed the result of f79b0d9c223ca09cefffc72304a7bcbc401a1c6f
("staging: speakup: Fixed warning instead of
") which didn't take care of the inclusion above.
I believe only is fine, the important part is in
drivers/staging/speakup/serialio.c which really needs to include
asm/serial.h to get SERIAL_PORT_D
e Coccinelle software.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/main.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> in
Hello,
To readers of the linux-speakup: could you help on this so we can get
Speakup in mainline? Neither Okash or I completely know what user
consequences the files in /sys/accessibility/speakup/ have, so could
people give brief explanations for each file (something like 3-6 lines
of explanation
of spk_do_catch_up.
Signed-off-by: Samuel Thibault
Index: linux-4.15/drivers/staging/speakup/spk_types.h
===
--- linux-4.15.orig/drivers/staging/speakup/spk_types.h
+++ linux-4.15/drivers/staging/speakup/spk_types.h
@@ -151,6 +151,7
For software speech syntheses to be able to manage concurrent audio card
access, they need to know when speakup stops emitting text to be spoken
because the console has switched to graphical mode. This introduces a
PAUSE command to do so.
Signed-off-by: Samuel Thibault
Index: linux-4.15
For software speech syntheses to be able to manage concurrent audio card
access, they need to know when speakup stops emitting text to be spoken
because the console has switched to graphical mode. This introduces a
PAUSE command to do so.
Signed-off-by: Samuel Thibault
Index: linux-4.15
For software speech syntheses to be able to manage concurrent audio card
access, they need to know when speakup stops emitting text to be spoken
because the console has switched to graphical mode. This introduces a
PAUSE command to do so.
Signed-off-by: Samuel Thibault
---
Difference from v1
Greg KH, le mar. 08 mai 2018 13:31:31 +0200, a ecrit:
> On Mon, May 07, 2018 at 10:14:27PM +0200, Samuel Thibault wrote:
> > For software speech syntheses to be able to manage concurrent audio card
> > access, they need to know when speakup stops emitting text to be spoken
> >
Signed-off-by: Samuel Thibault
---
drivers/staging/speakup/buffers.c |3 ++-
drivers/staging/speakup/main.c|5 ++---
2 files changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -78,7 +78,8 @@ void
Signed-off-by: Samuel Thibault
---
drivers/staging/speakup/buffers.c |2 +-
drivers/staging/speakup/main.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -80,7 +80,7 @@ void synth_buffer_add
erity: ("Unused value")
> Signed-off-by: Colin Ian King
Indeed, thanks!
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/keyhelp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/keyhelp.c
> b/drivers/staging/
Zhenzhong Duan, le jeu. 05 mars 2020 15:21:51 +0800, a ecrit:
> When softsynthu device fails the register, "/dev/softsynthu" should be
> printed instead of "/dev/softsynth".
Reviewed-by: Samuel Thibault
Thanks!
> Signed-off-by: Zhenzhong Duan
> Cc: William
Hello,
MugilRaj, le ven. 22 mai 2020 14:46:28 +0530, a ecrit:
> fix checkpatch.pl warning, which is Use of volatile is usually wrong: see
> Documentation/process/volatile-considered-harmful.rst
Yes, but the proper fix is usually not to just remove the volatile
qualifier, which will not fix anythi
Joe Perches, le ven. 22 mai 2020 09:36:05 -0700, a ecrit:
> On Fri, 2020-05-22 at 13:34 +0300, Dan Carpenter wrote:
> > On Fri, May 22, 2020 at 02:46:28PM +0530, MugilRaj wrote:
> > > fix checkpatch.pl warning, which is Use of volatile is usually wrong: see
> > > Documentation/process/volatile-cons
Joe Perches, le ven. 22 mai 2020 10:22:03 -0700, a ecrit:
> > Put another way: I don't think putting any hint here would help, on the
> > contrary, somebody has to really look at what protection is needed,
> > without getting influenced by rules-of-thumb.
>
> checkpatch newbies/robots will submit
Aldo Iljazi, le Tue 03 Dec 2013 22:08:03 +0200, a écrit :
> Line 468: Removed a space before a semicolon.
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Samuel
___
devel mailing list
de...@linuxdriverproject.o
for tty")
> Signed-off-by: Dan Carpenter
Reviewed-by: Samuel Thibault
> diff --git a/drivers/staging/speakup/spk_ttyio.c
> b/drivers/staging/speakup/spk_ttyio.c
> index 6e0f042f6a44..8ed7c71c712f 100644
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/spea
Greg KH, on mer. 14 juin 2017 12:15:41 +0200, wrote:
> Ah, no, nevermind, you just need the major/minor. So why not just take
> that as the input here, and not a string?
Because real users don't know about major/minor numbers.
Samuel
___
devel mailing
Greg KH, on mer. 14 juin 2017 13:48:02 +0200, wrote:
> On Wed, Jun 14, 2017 at 01:26:09PM +0200, Samuel Thibault wrote:
> > Greg KH, on mer. 14 juin 2017 12:15:41 +0200, wrote:
> > > Ah, no, nevermind, you just need the major/minor. So why not just take
> > > that a
Andy Shevchenko, on mer. 14 juin 2017 15:36:30 +0300, wrote:
> On Wed, Jun 14, 2017 at 3:18 PM, Samuel Thibault
> wrote:
> > Greg KH, on mer. 14 juin 2017 13:48:02 +0200, wrote:
> >> On Wed, Jun 14, 2017 at 01:26:09PM +0200, Samuel Thibault wrote:
> >> > Greg
Okash Khawaja, on sam. 17 juin 2017 10:46:41 +0100, wrote:
> This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
> defined. This was supposed to have been included in commit
> 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
> tty_open_by_driver"). The patch follows conven
t;). The patch follows convention for other such
> functions and returns NULL.
>
> Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
>
> ---
> include/linux/tty.h |3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/include/linux/tty.h
> +++ b/include
walter harms, on mer. 28 juin 2017 16:49:03 +0200, wrote:
> Am 28.06.2017 15:13, schrieb Colin King:
> > diff --git a/drivers/staging/speakup/spk_ttyio.c
> > b/drivers/staging/speakup/spk_ttyio.c
> > index 442f191a017e..ed8e96b06ead 100644
> > --- a/drivers/staging/speakup/spk_ttyio.c
> > +++ b/dr
Jaya Durga, on mer. 12 juil. 2017 16:53:53 +0530, wrote:
> Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
IIRC synth_immediate is meant to be usable in atomic contexts too, so
usleep can't be used.
Samuel
___
devel mailing list
de..
;
> Signed-off-by: Pranay Kr. Srivastava
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/main.c | 27 +++
> 1 file changed, 19 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
>
> Also change the prototype of speakup_allocate to take
> extra argument of gfp_* flags. Thus not requiring
> GFP_ATOMIC during initialization.
>
> Signed-off-by: Pranay Kr. Srivastava
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/main.c | 19
;
> Signed-off-by: Pranay Kr. Srivastava
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/main.c | 27 +++
> 1 file changed, 19 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
>
;
> Signed-off-by: Pranay Kr. Srivastava
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/main.c | 11 ---
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index a1d5b66..ca817ca 100644
led in.
>
> Signed-off-by: Pranay Kr. Srivastava
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/main.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
>
put 16bit characters and strings.
Signed-off-by: Samuel Thibault
Index: linux-4.10/drivers/staging/speakup/spk_priv.h
===
--- linux-4.10.orig/drivers/staging/speakup/spk_priv.h
+++ linux-4.10/drivers/staging/speakup/spk_priv.h
yet, for
simplicity for now it will ignore 16bit characters.
For simplicity again, speakup messages are left in latin1 for now.
Some coding style is fixed along the way.
Signed-off-by: Samuel Thibault
Index: linux-4.10/drivers/staging/speakup/main.c
hardcode the UTF-8 encoding.
Signed-off-by: Samuel Thibault
Index: linux-4.10/drivers/staging/speakup/speakup_soft.c
===
--- linux-4.10.orig/drivers/staging/speakup/speakup_soft.c
+++ linux-4.10/drivers/staging/speakup/speakup_soft.c
Hello,
This patch series adds 16bit unicode support to speakup, through three
patches:
- extend synth buffer to 16bit unicode characters
- convert screen reading to 16bit characters
- add unicode variant of /dev/softsynth
Samuel
--
Samuel
hm. I've lost a machine.. literally _lost_. it respond
Marcin Ciupak, on jeu. 02 mars 2017 15:28:23 +0100, wrote:
> - int val;
> + int ret;
>
> - val = simple_strtoul(skip_spaces(start), &start, 10);
> + ret = kstrtou8(skip_spaces(start), 10, dest);
This is not the same, you need to have start properly move, since it's
used below:
>
yet, for
simplicity for now it will ignore 16bit characters.
For simplicity again, speakup messages are left in latin1 for now.
Some coding style is fixed along the way.
Signed-off-by: Samuel Thibault
Reviewed-by: Okash Khawaja
Index: linux-4.10/drivers/staging/speakup/main.c
hardcode the UTF-8 encoding.
Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
Index: linux-4.10/drivers/staging/speakup/speakup_soft.c
===
--- linux-4.10.orig/drivers/staging/speakup/speakup_soft.c
+++ linux-4.10/drivers
Hello,
This patch series adds 16bit unicode support to speakup, through three
patches:
- extend synth buffer to 16bit unicode characters
- convert screen reading to 16bit characters
- add unicode variant of /dev/softsynth
Samuel
--
Samuel
"...Unix, MS-DOS, and Windows NT (also known as the Goo
put 16bit characters and strings.
Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
Index: linux-4.10/drivers/staging/speakup/spk_priv.h
===
--- linux-4.10.orig/drivers/staging/speakup/spk_priv.h
+++ linux-4.10/drivers
Greg KH, on jeu. 09 mars 2017 17:25:51 +0100, wrote:
> This is the second version of this series, correct? Next time, please
> put a "v2" in them so that I know which to apply.
Ah, yes, sorry. The only difference was the Reviewed-by lines.
Thanks!
Samuel
_
Hello,
This patch series fixes a couple of issues of the previous "support 16bit
unicode screen reading" series:
- fix infinite loop on word spelling
- actually get unicode characters when reviewing console text.
Samuel
--
Samuel
How do I type "for i in *.dvi do xdvi i done" in a GUI?
(Discuss
meter to 1.
Reported-by: Zahari Yurukov
Signed-off-by: Samuel Thibault
Tested-by: Zahari Yurukov
Index: linux-2.6/drivers/staging/speakup/main.c
===
--- linux-2.6.orig/drivers/staging/speakup/main.c
+++ linux-2.6/drivers/stagi
er pointer.
Reported-by: Zahari Yurukov
Signed-off-by: Samuel Thibault
Tested-by: Zahari Yurukov
Index: linux-2.6/drivers/staging/speakup/main.c
===
--- linux-2.6.orig/drivers/staging/speakup/main.c
+++ linux-2.6/drivers/staging/spea
meter to 1.
Signed-off-by: Samuel Thibault
Tested-by: Zahari Yurukov
Index: linux-2.6/drivers/staging/speakup/main.c
===
--- linux-2.6.orig/drivers/staging/speakup/main.c
+++ linux-2.6/drivers/staging/speakup/main.c
@@ -483,7 +483,7
This supports spelling unicode characters by just passing them to
the speech synthesis in direct mode.
Signed-off-by: Samuel Thibault
Index: linux-4.10/drivers/staging/speakup/main.c
===
--- linux-4.10.orig/drivers/staging/speakup
Hello,
This patch series fixes a couple of issues of the previous "support 16bit
unicode screen reading" series:
- actually get unicode characters when reviewing console text.
- fix unicode character spelling
Samuel
--
Samuel
CN > J'ai enseigné l'algorythmique.
GLG> C'est quoi l'algorythmiq
Dan Carpenter, on lun. 13 mars 2017 15:46:34 +0300, wrote:
> Run your patches through scripts/checkpatch.pl
D'oh. For such a small patch, I didn't bother doing it indeed. Anyway,
that's superseded by version 2 I have submitted (speakup: Support
spelling unicode characters)
Samuel
Hello,
Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
> > This patchset introduces a TTY-based way for the synths to communicate
> > with devices as an alternate for direct serial comms used by the synths
> > at the m
Greg KH, on mar. 14 mars 2017 07:43:03 +0800, wrote:
> > Well, for a start that didn't exist when Okash worked on the TTY part :)
>
> Fair enough, but it has been discussed for many months now on the
> linux-serial mailing list.
I have not had time for years to actually work on this subject, so I
Samuel Thibault, on lun. 13 mars 2017 23:26:08 +0100, wrote:
> > That should make this a lot easier than your patchset from what I can
> > see.
>
> Will serdev support modem line control? We need this for some devices.
"serdev: add serdev_device_set_rts" seems
Hello Okash,
I'd say for a start already, rebase and submit patches 2-5, since they
are refactoring that makes sense anyway. And we can discuss about serdev
while that gets integrated, and thus serdev-equivalents of patches 1 and
6 will then be immediatetly applicable.
Samuel
Hello,
Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
> > This patchset introduces a TTY-based way for the synths to communicate
> > with devices as an alternate for direct serial comms used by the synths
> > at the m
Samuel Thibault, on mar. 14 mars 2017 01:47:01 +0100, wrote:
> Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> > On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
> > > This patchset introduces a TTY-based way for the synths to communicate
> &
commit 33590c185299 ("speakup: Support spelling unicode characters")
mistakenly passed unicode characters to IS_CHAR(), which only
supports latin1. Let's assume non-latin1 is lower case, like is done
in spell_word().
Signed-off-by: Samuel Thibault
diff --git a/drivers/staging/s
Chris Brannon, on mar. 14 mars 2017 09:06:36 -0700, wrote:
> This is going to misidentify some Unicode characters >= 0x100 as
> capital. You probably want to add ch < 0x100 tests to the if
Indeed, I've submitted a correction, thanks!
Samuel
___
devel m
Rob Herring, on mer. 15 mars 2017 09:45:59 -0500, wrote:
> On Mon, Mar 13, 2017 at 8:18 PM, Samuel Thibault
> wrote:
> > Samuel Thibault, on mar. 14 mars 2017 01:47:01 +0100, wrote:
> >> Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> >> > On Mon,
Hello,
Also, could serdev also provide an send_xchar function similar to the
send_xchar tty driver function? We need this to send high-priority
characters.
Samuel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.o
: Samuel Thibault
Tested-by: Zahari Yurukov
Index: linux-4.10/drivers/staging/speakup/main.c
===
--- linux-4.10.orig/drivers/staging/speakup/main.c
+++ linux-4.10/drivers/staging/speakup/main.c
@@ -448,20 +448,17 @@ static void speak_char
Hello,
So Rob, how do you see this going? Shall we introduce a serdev_device
*tty_port_register_serdev_device(tty, device)? Will you work on it or
should I give it a try?
Samuel
Samuel Thibault, on mer. 15 mars 2017 16:03:23 +0100, wrote:
> Rob Herring, on mer. 15 mars 2017 09:45:59 -0
Gustavo A. R. Silva, on lun. 27 mars 2017 01:37:29 -0500, wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
>
> Signed-off-by: Gustavo A. R. Silva
Yes, indeed.
Reviewed-by: Samuel Thibault
Thanks
> ---
&
Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> Thanks for this :) Could you also move the function higher in the same
> file - above line 139 where all static functions are defined?
I'd say no need for this. spk_serial_in is just above. Moving functions
just for the sake of static v
Pranay Kr. Srivastava, on mar. 21 févr. 2017 17:24:42 +0530, wrote:
> Retain the previous error values as debug messages
> instead.
Well, they are not really useful because they are actually undocumented.
> + if (version != KEY_MAP_VER) {
> + pr_debug("Version mismatch %d\n", -1);
Pranay Kr. Srivastava, on mar. 21 févr. 2017 19:14:38 +0530, wrote:
> + if (key_data_len + SHIFT_TBL_SIZE + 4 >= sizeof(spk_key_buf)) {
> + pr_debug("key_data_len = %d, SHIFT_TBL_SIZE + 4 = %d,\t"
> + "sizeof(spk_key_buf) = %lu\n", key_data_len,
> +
GFP_ATOMIC during initialization.
>
> Signed-off-by: Pranay Kr. Srivastava
Reviewed-by: Samuel Thibault
Just add in the log that it's unnecessary because the for loop below
does the initialization already.
> ---
> drivers/staging/speakup/main.c | 19 ---
>
f
> the NULL to the synths array. Make the synths array MAXSYNTHS + 1
> elements in size to allow for the final NULL sentinal to avoid the
> out-of-bounds write.
>
> Issue found wit CoverityScan, CID#744671
>
> Signed-off-by: Colin Ian King
Reviewed-by: Samuel Thibault
>
Markus Mayer, on Thu 30 Jun 2016 16:50:11 -0700, wrote:
> After introducing generic strtolower(), spk_strlwr() is no longer
> needed.
>
> Signed-off-by: Markus Mayer
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c| 2 +-
> drivers/staging/speak
Markus Mayer, on Fri 08 Jul 2016 15:43:11 -0700, wrote:
> After introducing generic strltolower() and strtolower(), spk_strlwr()
> is no longer needed.
>
> Signed-off-by: Markus Mayer
Acked-by: Samuel Thibault
> ---
>
> Samuel, I left off your ACK, since the implemen
Hello,
Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote:
> There is a potential race in drivers/staging/speakup/speakup.ko.
> All operations with global pointers buff_in and buff_out are performed
> without any locks. Thus, a simultaneous write (via synth_buffer_clear or
> synth_buffer_ad
Pavel Andrianov, on Mon 05 Sep 2016 12:54:10 +0300, wrote:
> 05.09.2016 12:43, Samuel Thibault пишет:
> >Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote:
> >>There is a potential race in drivers/staging/speakup/speakup.ko.
> >>All operations with global pointe
Pavel Andrianov, on Mon 05 Sep 2016 13:33:33 +0300, wrote:
> synth_direct_store may be called via device_attributes interface.
Ah, right.
> In which function the lock should be added?
That'd be synth_direct_store then, around the while loop.
Samuel
__
drianov
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/speakup/kobjects.c
> b/drivers/staging/speakup/kobjects.c
> index 528cbdc..7fedee3 100644
> --- a/drivers/staging/
e.
>
> Signed-off-by: Gustavo A. R. Silva
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/selection.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/speakup/selection.c
> b/drivers/staging/speakup/selection
Hello,
Gabriel Fedel, le sam. 26 mai 2018 16:03:35 -0300, a ecrit:
> Replace simple_strtoul() with kstrtoul(), because simple_strtoul() is
> obsolete.
Well, rather than putting again a dozen lines of code, if simple_strtoul
is really considered to be obsolete, a replacement should be defined so
Hello,
Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit:
> The synths[] array is a collection of synths acting like a list.
> There is no need for synths to be an array, so refactor synths[] to use
> standard kernel list_head API, instead, and modify the usages to suit.
> As a side-effe
t; As a side-effect, the maximum number of synths has also become redundant.
This looks good to me,
Reviewed-by: Samuel Thibault
Did you test to e.g. insmod speakup_soft ; insmod speakup_dummy ; rmmod
speakup_soft ; rmmod speakup_dummy
to make sure it did work correctly?
I'd also rather see
Hello,
Samuel Thibault, le mer. 06 juin 2018 15:26:28 +0200, a ecrit:
> I'd also rather see it tested in the real wild before committing. Could
> somebody on the speakup mailing list test the patch? (which I have
> re-attached as a file for conveniency).
Anybody up for testing plea
Gregory Nowak, le lun. 11 juin 2018 16:51:22 -0700, a ecrit:
> On Tue, Jun 12, 2018 at 12:57:03AM +0200, Samuel Thibault wrote:
> > Anybody up for testing please?
> >
> > If people want to see speakup get mainlined instead of staging, please
> > help.
>
>
Thanks for the tests!
Samuel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Justin Skists, le lun. 18 juin 2018 09:41:44 +0100, a ecrit:
> > On 18 June 2018 at 06:34 Gregory Nowak wrote:
> > With /sys/accessibility/speakup/synth set to bns, I am getting output
> > alternately from the bns and from soft. It's as if speakup can't make
> > up its mind which synthesizer is be
Justin Skists, le lun. 18 juin 2018 09:55:32 +0100, a ecrit:
> When I was going through the driver code, to become familiar with it, there
> were a few places that I thought needed a closer look.
Yes, cleanup work is probably needed in various places.
Samuel
__
e copied has already been determined with strlen(). Replace strncpy()
> with memcpy() to address the warning and optimize the code a little.
>
> Signed-off-by: Guenter Roeck
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c | 4 ++--
> 1 file changed, 2 inser
1 - 100 of 127 matches
Mail list logo
