[Outreachy kernel] [PATCH v2] Staging: rtl8188eu: hal: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~staging$ git diff -w drivers/staging

Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: Add space around operators

On Mon, 2020-03-23 at 02:04 +0100, Stefano Brivio wrote: > Hi Shreeya, > > On Mon, 23 Mar 2020 04:48:08 +0530 > Shreeya Patel wrote: > > > On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote: > > > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wro

Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: Add space around operators

On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote: > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote: Hi Greg and Joe, > > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote: > > > Add space around operators for improving the code > > > readability. >

[Outreachy kernel] [PATCH 11/11] Staging: rtl8188eu: rtl8188eu_xmit: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 10/11] Staging: rtl8188eu: rtl8188e_rxdesc: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 09/11] Staging: rtl8188eu: rtl8188e_hal_init: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 08/11] Staging: rtl8188eu: rtl8188e_cmd: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 07/11] Staging: rtl8188eu: rf_cfg: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 06/11] Staging: rtl8188eu: rf: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 05/11] Staging: rtl8188eu: pwrseqcmd: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 04/11] Staging: rtl8188eu: phy: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 03/11] Staging: rtl8188eu: odm_hwconfig: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 02/11] Staging: rtl8188eu: odm: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH 00/11] Staging: rtl8188eu: hal: Add space around operators

This patchset adds space around operators and removes all the checkpatch warnings for the same from the files present under drivers/staging/rtl8188eu/hal/ directory. Shreeya Patel (11): Staging: rtl8188eu: hal_com: Add space around operators Staging: rtl8188eu: odm: Add space around operators

Re: [Outreachy kernel] [PATCH v2] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions

On Fri, 2020-03-13 at 14:21 -0700, Joe Perches wrote: Hi Joe, > On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote: > > Remove unnecessary if and else conditions since both are leading to > > the > > initialization of "phtpriv->ampdu_enable" wit

[Outreachy kernel] [PATCH] Staging: wilc1000: cfg80211: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Shreeya Patel --- drivers/staging/wilc1000/cfg80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/cfg80211.c b/drivers/staging/wilc1000/cfg80211.c index 54e02807cebf..4bdcbc5fd2fd 100644 --- a/drivers

[Outreachy kernel] [PATCH v2] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions

Remove if and else conditions since both are leading to the initialization of "valueDMATimeout" and "valueDMAPageCount" with the same value. Found using coccinelle script. Signed-off-by: Shreeya Patel --- Changes in v2 - Remove unnecessary comments. drivers/s

[Outreachy kernel] [PATCH v2] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions

Remove if and else conditions since both are leading to the initialization of "valueDMATimeout" and "valueDMAPageCount" with the same value. Found using coccinelle script. Signed-off-by: Shreeya Patel --- Changes in v2 - Remove unnecessary comments. drivers/s

[Outreachy kernel] [PATCH v2] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions

Remove unnecessary if and else conditions since both are leading to the initialization of "phtpriv->ampdu_enable" with the same value. Also, remove the unnecessary else-if condition since it does nothing. Signed-off-by: Shreeya Patel --- Changes in v2 - Remove unnecessary commen

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions

On Fri, 2020-03-13 at 10:20 +0300, Dan Carpenter wrote: > On Wed, Mar 11, 2020 at 07:08:11PM +0530, Shreeya Patel wrote: > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c > > b/drivers/staging/rtl8723bs/hal/sdio_halinit.c > > index e813382e78a6..643592b0bd38 100

Re: [Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators

On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio wrote: Hey Stefano, >On Wed, 11 Mar 2020 18:47:42 +0530 >Shreeya Patel wrote: > >> Add space around operators for improving the code >> readability. >> Reported by checkpatch.pl >> >> g

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions

Hey Joe, On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches wrote: >On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote: >> Remove if and else conditions since both are leading to the >> initialization of "valueDMATimeout" and "valueDMAPageCount" w

[Outreachy kernel] [PATCH] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions

Remove unnecessary if and else conditions since both are leading to the initialization of "phtpriv->ampdu_enable" with the same value. Signed-off-by: Shreeya Patel --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-

[Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions

Remove if and else conditions since both are leading to the initialization of "valueDMATimeout" and "valueDMAPageCount" with the same value. Found using coccinelle script. Signed-off-by: Shreeya Patel --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 +---

[Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl git diff -w shows no difference. diff of the .o files before and after the changes shows no difference. Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers

[Outreachy kernel] [PATCH v3] Staging: rtl8188eu: rtw_mlme: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl Signed-off-by: Shreeya Patel --- shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers/staging/rtl8188eu/core/ shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w shows no difference

[Outreachy kernel] [PATCH v2] Staging: rtl8188eu: rtw_mlme: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl Signed-off-by: Shreeya Patel --- rtw_mlme_old.o - Previously produced object file before making any changes to the source code. rtw_mlme.o - Object file produced after compiling the changes done in source

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

On Mon, 2020-03-09 at 08:35 +0100, Julia Lawall wrote: > On Mon, 9 Mar 2020, Shreeya Patel wrote: > > > On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > > > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > > > Add space around operators for impro

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > Add space around operators for improving the code > > readability. > > Hello again Shreeya. > I have some questions here... > The subject isn't real

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > Add space around operators for improving the code > > readability. > > Hello again Shreeya. > > The subject isn't really quite appropriate as you > a

[Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

Add space around operators for improving the code readability. Reported by checkpatch.pl Signed-off-by: Shreeya Patel --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/core

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator

On Sun, 2020-03-08 at 21:17 +0100, Julia Lawall wrote: > > On Mon, 9 Mar 2020, Shreeya Patel wrote: > > > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote: > > > > Hi Joe, > > > > > On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote: >

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator

On Sun, 2020-03-08 at 13:19 -0700, Joe Perches wrote: > On Mon, 2020-03-09 at 01:40 +0530, Shreeya Patel wrote: > > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote: > > Hi Joe, > > Hello. > [] > > > > > diff --git a/drivers/staging/rtl8188eu/core

[Outreachy kernel] [PATCH] Staging: rtl8723bs: Remove comparison to true

Remove comparison to "true" from if statement to maintain the kernel coding style. Reported by checkpatch.pl Signed-off-by: Shreeya Patel --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/r

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator

On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote: Hi Joe, > On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote: > > On Mon, 9 Mar 2020, Shreeya Patel wrote: > > > > > Add space around & operator for improving the code > > > readability. > > I g

[Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator

Add space around & operator for improving the code readability. Signed-off-by: Shreeya Patel --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_ml

[PATCH v4 2/3] Staging: iio: adt7316: Remove multi read and write functions

Currently, adt7316 doesn't use multi read and multi write functions hence remove the redundant code and make the necessary changes in the code. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 40 - drivers/staging/iio/addac/adt7316-spi.c | 31

[PATCH v4 3/3] Staging: iio: adt7316: Add regmap support

Both i2c and spi drivers have functions for reading and writing to/from registers. Remove this redundant and common code by using regmap API. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 56 +++--- drivers/staging/iio/addac/adt7316-spi.c | 74

[PATCH v4 0/3] adt7316 regmap implementation

greg's testing branch. Changes in v3 -Fetch the changes from remote and rebase to have it in the current working directory. Changes in v2 -Change the val_bits to 8 and add two more patches having a different change before the final implemetation of regmap. Shreeya Patel (3): Staging: iio

[PATCH v4 1/3] Staging: iio: adt7316: Remove irq from bus structure

interrupt request is not needed to be present in the bus structure. It is a good option to pass it as a parameter in the probe function instead of having it in the bus structure. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 3 +-- drivers/staging/iio/addac/adt7316

Re: [PATCH v3 0/3] adt7316 regmap implementation

On Sat, 2019-01-26 at 10:42 +0530, Shreeya Patel wrote: > On Fri, 2019-01-25 at 18:22 -0700, Jeremy Fertic wrote: > > On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote: > > > This patchset consist of some initial patches for heading > > > towards the reg

Re: [PATCH v3 0/3] adt7316 regmap implementation

On Fri, 2019-01-25 at 18:22 -0700, Jeremy Fertic wrote: > On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote: > > This patchset consist of some initial patches for heading > > towards the regmap implementation and also the final patch > > which enables the driver t

[PATCH v3 3/3] Staging: iio: adt7316: Add regmap support

Both i2c and spi drivers have functions for reading and writing to/from registers. Remove this redundant and common code by using regmap API. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 56 +++--- drivers/staging/iio/addac/adt7316-spi.c | 74

[PATCH v3 2/3] Staging: iio: adt7316: Remove multi read and write functions

Currently, adt7316 doesn't use multi read and multi write functions hence remove the redundant code and make the necessary changes in the code. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 40 - drivers/staging/iio/addac/adt7316-spi.c | 31

[PATCH v3 0/3] adt7316 regmap implementation

directory. Changes in v2 -Change the val_bits to 8 and add two more patches having a different change before the final implemetation of regmap. Shreeya Patel (3): Staging: iio: adt7316: Remove irq from bus structure Staging: iio: adt7316: Remove multi read and write functions Staging: iio

[PATCH v3 1/3] Staging: iio: adt7316: Remove irq from bus structure

interrupt request is not needed to be present in the bus structure. It is a good option to pass it as a parameter in the probe function instead of having it in the bus structure. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 3 +-- drivers/staging/iio/addac/adt7316

Re: [PATCH v2 0/3] adt7316 regmap implementation

On Sat, 2019-01-19 at 19:04 +, Jonathan Cameron wrote: > On Sun, 20 Jan 2019 00:09:29 +0530 > Shreeya Patel wrote: > > > This patchset consist of some initial patches for heading > > towards the regmap implementation and also the final patch > > which enables t

[PATCH v2 2/3] Staging: iio: adt7316: Remove multi read and write functions

Currently, adt7316 doesn't use multi read and multi write functions hence remove the redundant code and make the necessary changes in the code. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 40 - drivers/staging/iio/addac/adt7316-spi.c | 31

[PATCH v2 3/3] Staging: iio: adt7316: Add regmap support

Both i2c and spi drivers have functions for reading and writing to/from registers. Remove this redundant and common code by using regmap API. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 60 +++ drivers/staging/iio/addac/adt7316-spi.c | 74

[PATCH v2 1/3] Staging: iio: adt7316: Remove irq from bus structure

interrupt request is not needed to be present in the bus structure. It is a good option to pass it as a parameter in the probe function instead of having it in the bus structure. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 3 +-- drivers/staging/iio/addac/adt7316

[PATCH v2 0/3] adt7316 regmap implementation

This patchset consist of some initial patches for heading towards the regmap implementation and also the final patch which enables the driver to use regmap API thus removing the redundant and common code. Shreeya Patel (3): Staging: iio: adt7316: Remove irq from bus structure Staging: iio

[PATCH] Staging: iio: adt7316: Add regmap support

Both i2c and spi drivers have functions for reading and writing to/from registers. Remove this redundant and common code by using regmap API. Also remove multi_read and multi_write functions from i2c and spi driver as they are not being used anywhere. Signed-off-by: Shreeya Patel --- drivers

[PATCH v4] Staging: iio: adt7316: Add all irq related code in adt7316_irq_setup()

. irq_type = IRQF_TRIGGER_LOW Move devm_request_threaded_irq() and assignment of chip->config1 into the adt7316_setup_irq() to unclutter the code in probe function. Signed-off-by: Shreeya Patel --- Changes in v4 - Merge patches *[1/3 v3], *[2/3 v3] and *[3/3 v3] to make it less complex to rev

Re: [PATCH v3 2/3] Staging: iio: adt7316: Move interrupt related code

On Sat, 2018-12-08 at 16:12 +, Jonathan Cameron wrote: > On Sat, 8 Dec 2018 20:46:37 +0530 > Shreeya Patel wrote: > > > There is a function adt7316_irq_setup() where irq_type is being > > set. It would be good to move devm_request_threaded_irq() function > > and

Re: [PATCH] Revert "Staging: iio: adt7316: Add an extra check for 'ret' equals to 0"

On Sat, 2018-12-08 at 11:17 +, Jonathan Cameron wrote: > On Sat, 08 Dec 2018 00:07:21 +0530 > Shreeya Patel wrote: > > > On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote: > > > On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote: > > > >

[PATCH v3 2/3] Staging: iio: adt7316: Move interrupt related code

There is a function adt7316_irq_setup() where irq_type is being set. It would be good to move devm_request_threaded_irq() function and assignment of chip->config1 in adt7316_irq_setup() to unclutter the code in probe function. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt731

[PATCH v3 0/3] Remove platform data and introduce DT bindings

about the error. Shreeya Patel (3): Staging: iio: adt7316: Use device tree data to assign irq_type Staging: iio: adt7316: Move interrupt related code Staging: iio: adt7316: Add a dev_err() message drivers/staging/iio/addac/adt7316.c | 52 + 1 file changed, 38

[PATCH v3 1/3] Staging: iio: adt7316: Use device tree data to assign irq_type

this is implemented in a new function called adt7316_setup_irq. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index

[PATCH v3 3/3] Staging: iio: adt7316: Add a dev_err() message

Add a dev_err() message "failed to request irq" for describing what went wrong when an error contition is statisfied. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac

Re: [PATCH] Revert "Staging: iio: adt7316: Add an extra check for 'ret' equals to 0"

On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote: > On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote: > > On Thu, Dec 06, 2018 at 01:25:55AM +0530, Shreeya Patel wrote: > > > On Tue, 2018-12-04 at 18:49 -0700, Jeremy Fertic wrote: > >

Re: [PATCH] Revert "Staging: iio: adt7316: Add an extra check for 'ret' equals to 0"

On Tue, 2018-12-04 at 18:49 -0700, Jeremy Fertic wrote: > This reverts commit 00426e99789357dbff7e719a092ce36a3ce49d94. > > i2c_smbus_read_byte() returns 0 when a byte with the value 0 is read > from > the device. This is a valid read so revert the check for 0. > > Signed-off-by: Jeremy Fertic

Re: [PATCH v2 5/5] Staging: iio: adt7316: Use device tree data to assign irq_type

On Wed, 2018-11-21 at 08:21 +, Ardelean, Alexandru wrote: > On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote: > > ADT7316 driver no more uses platform data and hence use device tree > > data instead of platform data for assigning irq_type field. > > Switch case

[PATCH v2 5/5] Staging: iio: adt7316: Use device tree data to assign irq_type

-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index 9c72538baf9e..c647875a64f5 100644 --- a/drivers/staging/iio/addac/adt7316.c

[PATCH v2 4/5] Staging: iio: adt7316: Change the name from irq_flags to irq_type

Most of the drivers in IIO uses irq_type as the name for storing the interrupt type and hence change the name from irq_flags to irq_type for maintaining the consistency. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v2 3/5] Staging: iio: adt7316: Switch irq_flags to a local variable

There is no need to store irq_flags into the structure as it is always set to the same thing. Hence switch irq_flags to a local variable. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 1 - drivers/staging/iio/addac/adt7316-spi.c | 1 - drivers/staging/iio/addac

[PATCH v2 2/5] Staging: iio: adt7316: Use device tree data to set ldac_pin

Make the driver use device tree instead of the platform data. Hence, use devm_gpiod_get_optional function to get the data from device tree for ldac-pin and accordingly make the needed changes in the driver. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 14

[PATCH v2 1/5] Staging: iio: adt7316: Add of_device_id table

then there should be a fall back path with which desired kernel modules can be loaded. Hence, add of_device_id table in the i2c driver to be able to use when there is no dt table. Signed-off-by: Shreeya Patel --- Changes in v2: - Make the commit message appropriate and assign of_match_table in the driver

[PATCH v2 0/5] Remove platform data and introduce DT bindings

] appropriate. Shreeya Patel (5): Staging: iio: adt7316: Add of_device_id table Staging: iio: adt7316: Use device tree data to set ldac_pin Staging: iio: adt7316: Switch irq_flags to a local variable Staging: iio: adt7316: Change the name from irq_flags to irq_type Staging: iio: adt7316: Use device

[PATCH 7/7] Staging: iio: adt7316: Use device tree data to assign irq_type

-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index 9c72538baf9e..c647875a64f5 100644 --- a/drivers/staging/iio/addac/adt7316.c

[PATCH 6/7] Staging: iio: adt7316: Change the name from irq_flags to irq_type

Most of the drivers in IIO uses irq_type as the name for storing the interrupt type and hence change the name from irq_flags to irq_type for maintaining the consistency. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 5/7] Staging: iio: adt7316: Switch irq_flags to a local variable

There is no need to store irq_flags into the structure as it is always set to the same thing. Hence switch irq_flags to a local variable. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 1 - drivers/staging/iio/addac/adt7316-spi.c | 1 - drivers/staging/iio/addac

[PATCH 4/7] Staging: iio: adt7316: Use device tree data to set ldac_pin

Make the driver use device tree instead of the platform data. Hence, use devm_gpiod_get_optional function to get the data from device tree for ldac-pin and accordingly make the needed changes in the driver. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316.c | 14

[PATCH 3/7] Staging: iio: adt7316: Add of_device_id table

for ADT7316, add of_device_id table which specifies the supported devices through compatible property. Note that there is a fall back path in i2c that will result in i2c_device_id table being used if there is no of_devcie_id table. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c

[PATCH 2/7] Staging: iio: adt7316: Add an extra check for 'ret' equals to 0

ret = 0 indicates a case of no error but no data read from the bus which is an invalid case. This case doesn't ever happen in reality. It should perhaps be handled for correctness though. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 4 1 file changed, 4

[PATCH 1/7] Staging: iio: adt7316: Set the data field

adt7316_i2c_read function nowhere sets the data field. It is necessary to have an appropriate value for it. Hence, assign the value stored in 'ret' variable to data field. Signed-off-by: Shreeya Patel --- drivers/staging/iio/addac/adt7316-i2c.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 0/7] Remove platform data and introduce DT bindings

This patchset introduces device tree bindings for adt7316 driver and removes the usage of platform data from it. Also, it sets the data field to it's appropriate value in the i2c read function which was nowhere being set before. Shreeya Patel (7): Staging: iio: adt7316: Set the data field

Re: [PATCH] staging: iio: adt7316: Switch to the gpio descriptor interface

On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface for ldac_pin. > > Signed-off-by: Nishad Kamdar > --- Hi Nishad, I have been working on implementing device tree bindings for this driver and removing

Re: [PATCH] Staging iio/adc: fixes parenthesis alignment

On Tue, 2018-10-16 at 13:01 -0300, Marcelo Schmitt wrote: > Fixes close parenthesis alignment to match open parenthesis at > iio/drivers/staging/iio/adc/ad7606.c line 379. > > Signed-of-by: Marcelo Schmitt Hi Marcelo, Some suggestions from my side 1) Your subject line should look like

[PATCH] Staging: lustre: Use kmemdup() instead of kzalloc and memcpy

,flag); if (to==NULL || ...) S - memcpy(to, from, size); Signed-off-by: Shreeya Patel --- drivers/staging/lustre/lnet/lnet/api-ni.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c

[PATCH v6 6/6] Staging: iio: adis16209: Move adis16209 driver out of staging

Move the adis16209 driver out of staging directory and merge to the mainline IIO subsystem. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v6 -Move driver adis16209 from staging to mainline IIO subsystem after complete cleanup of it. drivers/iio/accel/K

[PATCH v6 5/6] Staging: iio: adis16209: Use GENMASK

Use GENMASK to improve readability and remove the local variables used to store intermediate data. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v6 -Introduce this new patch in the series. drivers/staging/iio/accel/adis16209.c | 19 ---

[PATCH v6 4/6] Staging: iio: adis16209: Remove unused headers

Remove few unused header files since the adis core handles the sysfs and buffer support. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v6 -Introduce this new patch in the series. drivers/staging/iio/accel/adis16209.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH v6 3/6] Staging: iio: adis16209: Add a blank line after return statements

Add a blank line after return statements to improve the code readability. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v6 -Introduce this new patch in the series. drivers/staging/iio/accel/adis16209.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

[PATCH v6 2/6] Staging: iio: adis16209: Prefer reverse christmas tree ordering

Prefer reverse christmas tree ordering of declarations to improve readability. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v6 -Introduce this new patch in the series. drivers/staging/iio/accel/adis16209.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v6 1/6] Staging: iio: adis16209: Indent the field definitions

Have indentation in field definitions to make them clearly different from the register addresses. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v5 -Change some macro names and have indentation in the field definitions. Changes in v6 -Have inden

[PATCH v6 0/6] adis16209 driver cleanup

introduced for more cleanup and from the previous version, patch *[1/6] has been included in this patch series. Shreeya Patel (6): Staging: iio: adis16209: Indent the field definitions Staging: iio: adis16209: Prefer reverse christmas tree ordering Staging: iio: adis16209: Add blank lines

Re: [PATCH v2] Staging: iio: adis16209: Move adis16209 driver out of staging

On 10 March 2018 21:27:31 GMT+05:30, Jonathan Cameron <ji...@kernel.org> Hi Jonathan >On Sat, 10 Mar 2018 15:50:23 +0530 >Shreeya Patel <shreeya.patel23...@gmail.com> wrote: > >> Move the adis16209 driver out of staging directory and merge to the >> mainline

Re: [PATCH v2] Staging: iio: adis16209: Move adis16209 driver out of staging

On 16 March 2018 00:31:53 GMT+05:30, Shreeya Patel <shreeya.patel23...@gmail.com> wrote: >On Sat, 2018-03-10 at 15:57 +, Jonathan Cameron wrote: > >Hi Jonathan, > >> On Sat, 10 Mar 2018 15:50:23 +0530 >> Shreeya Patel <shreeya.patel23...@gmail.com> wrot

[PATCH v2] Staging: iio: adis16209: Move adis16209 driver out of staging

Move the adis16209 driver out of staging directory and merge to the mainline IIO subsystem. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v2 -Re-send the patch after having some cleanups in the file included in this patch. drivers/iio/accel/K

[PATCH v5] Staging: iio: adis16209: Change some macro names

Make some of the macro names according to the names given in the datasheet of the adis16209 driver and have slight indentation in field definitions to make them clearly different from the register addresses. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v5 -R

Re: [PATCH v4] Staging: iio: adis16209: Change some macro names

On 9 March 2018 00:41:12 GMT+05:30, Himanshu Jha <himanshujha199...@gmail.com> wrote: >On Thu, Mar 08, 2018 at 11:46:17PM +0530, Shreeya Patel wrote: >> Make some of the macro names according to the names >> given in the datasheet of the adis16209 driver and >> have

[PATCH] Staging: iio: adis16209: Move adis16209 driver out of staging

Move the adis16209 driver out of staging directory and merge to the mainline IIO subsystem. --- drivers/iio/accel/Kconfig | 12 ++ drivers/iio/accel/Makefile| 1 + drivers/iio/accel/adis16209.c | 334 ++

[PATCH v4] Staging: iio: adis16209: Change some macro names

Make some of the macro names according to the names given in the datasheet of the adis16209 driver and have slight indentation in field definitions to make them clearly different from the register addresses. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v4

Re: [PATCH 03/11] Staging: iio: accel: Remove unnecessary comments

On Mon, 2018-03-05 at 13:19 +0530, Himanshu Jha wrote: > Remove unnecessary comments since the definitions are pretty clear > with their macro names. > > Signed-off-by: Himanshu Jha > --- >  drivers/staging/iio/accel/adis16201.c | 82 +-- >

Re: [PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

On Sun, 2018-03-04 at 18:26 +0530, Himanshu Jha wrote: > Hi Shreeya, > > On Sun, Mar 04, 2018 at 06:06:22PM +0530, Shreeya Patel wrote: > > > > Remove some unnecessay comments and group the control > > register and register field macros together. > > Some of the

[PATCH v3 4/4] Staging: iio: adis16209: Use sign_extend32 function

Use sign_extend32 function instead of manually coding it. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v3 -After split patch. drivers/staging/iio/accel/adis16209.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio

[PATCH v3 3/4] Staging: iio: adis16209: Adjust a switch statement

Adjust a switch block to explicitly match channels and return -EINVAL as default case which makes the code semantically more clear. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v3 -After split patch. drivers/staging/iio/accel/adis16209.c | 10 --

[PATCH v3 2/4] Staging: iio: adis16209: Change some macro names

Make some of the macro names according to the names given in the datasheet of the adis16209 driver. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v3 -Introduce this new patch for v3 of the series. drivers/staging/iio/accel/adis16209.

[PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

information, so expand those comments. Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com> --- Changes in v3 -This patch is the combination of two patches from the previous series. Also add some more comments. drivers/staging/iio/accel/adis16209.c

  1   2   >