[PATCH 09/11] staging: dgnc: remove parenthesis

checkpatch was warning us about extra unneeded parenthesis. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/dgnc/dgnc_neo.c | 2 +- drivers/staging/dgnc/dgnc_sysfs.c | 48 +++ drivers/staging/dgnc/dgnc_tty.c | 14 ++---

[PATCH 04/11] staging: dgnc: remove blankline after brace

Blank lines are not needed after opening braces. checkpatch was giving us warnings about this. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/dgnc/dgnc_cls.c| 4 drivers/staging/dgnc/dgnc_driver.c | 3 --- drivers/staging/dgnc/dgnc_mgmt.c | 1 - d

[PATCH 10/11] staging: dgnc: remove initialization of global

globals variable will be initialied to 0 and the global pointers will be to NULL. No need to initialize them separately. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/dgnc/dgnc_driver.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/stagin

[PATCH 06/11] staging: dgnc: change style of NULL comparison

Change the NULL comparison style as warned by checkpatch. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/dgnc/dgnc_tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c

Re: Bosto 14WA graphics tablet driver

On Sat, Oct 03, 2015 at 06:10:18PM +1300, Leslie Viljoen wrote: > I've read some of the guides and attempted to change the style of the > driver's code to "kernel" style. Style is almost ok. Some of the parts still needs to be modified but that will not take more than 10 - 11 patch. I have not

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > On 09/28/2015 06:18 AM, Sudip Mukherjee wrote: > >On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: > >>On 09/26/2015 11:49 AM, Punit Vara wrote: > >>>This patch is to the rtl871x_ioctl_l

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: > On 09/26/2015 11:49 AM, Punit Vara wrote: > >This patch is to the rtl871x_ioctl_linux.c that fixes up following > >warning reported by checkpatch.pl : > > > >- Comparisons should place the constant on the right side of the test > > >

Re: [PATCH] staging: rtl8723au: Fix resource leak

On Sun, Sep 27, 2015 at 09:30:54PM +0200, Mateusz Kulikowski wrote: > Firmware was not released properly if kmemdup fails. > > Addresses-Coverity-Id: 1269118 > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- > 1

Re: [PATCH v2] staging: rtl8723au: Fix resource leak

On Sun, Sep 27, 2015 at 09:48:19PM +0200, Mateusz Kulikowski wrote: > Firmware was not released properly if kmemdup fails. > > Addresses-Coverity-Id: 1269118 > Signed-off-by: Mateusz Kulikowski > --- Not seen your v2 while replying to your v1. Sorry for the noise.

Re: [PATCH] Removed extra spaces, and error from checkpatch.pl

On Sun, Sep 27, 2015 at 05:44:16AM +0530, Pinkesh Badjatiya wrote: > Removed trailing spaces. > Fixed some errors from checkpatch.pl verification. > No changes made to actual functional code. > > Signed-off-by: Pinkesh Badjatiya > --- And you have done more than one

Re: [PATCH] Staging: lustre: Fix warning detected by coccicheck

On Sun, Sep 27, 2015 at 11:15:21AM +0530, Jayavant Kenjalkar wrote: > From: Jayavant Kenjalkar You do not need this From line here. This is needed only for those who can not configure their corporate mail servers. regards sudip

Re: [PATCH] Staging: lustre: ptlrpc: Make struct static

On Sat, Sep 26, 2015 at 12:22:34AM +0530, Shraddha Barke wrote: > Make struct static and remove definition from header file since the > struct is accessed only in this particular file > > Signed-off-by: Shraddha Barke > --- Build fails with this patch with the error: In

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote: > > On 02/09/15 15:48, Sudip Mukherjee wrote: > > > Is there a public datasheet for the HW? I could not find one in Silicon Motion website. I will try to find else I can talk to them and keep it in my github. And ca

Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote: > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote: > > This is a patch to the rtl871x_mp.h that fixes up following warnings > > reported by checkpatch.pl : > > > > -Block comments use a trailing */ on a separate line > > >

Re: [PATCH] Staging: rtl8712: rtl871x_sta_mgt.c: Coding style warning fix for block comment

On Thu, Sep 24, 2015 at 02:38:26AM +0530, Punit Vara wrote: > This is a patch to the rtl871x_sta_mgt.c file that fixes up following > warning reported by checkpatch.pl: > > -Block comments use a trailing */ on a separate line > > Signed-off-by: Punit Vara > --- When you are

Re: [PATCH v3 1/1] staging: dgnc: take lock when storing value in dgnc_po ll_tick

On Thu, Sep 24, 2015 at 08:28:50PM +0100, Salah Triki wrote: > On Wed, Sep 23, 2015 at 11:37:37AM +0530, Sudip Mukherjee wrote: > > On Wed, Sep 23, 2015 at 03:28:07AM +0100, Salah Triki wrote: > > > dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store ne

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

On Wed, Sep 23, 2015 at 07:32:52PM +0530, punit vara wrote: > On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha <j...@innercoder.com> wrote: > > > > On 09/23/2015 12:31 AM, Sudip Mukherjee wrote: > >> > >> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

On Wed, Sep 23, 2015 at 09:51:23PM +0530, punit vara wrote: > On Wed, Sep 23, 2015 at 9:04 PM, Sudip Mukherjee > <sudipm.mukher...@gmail.com> wrote: > > On Wed, Sep 23, 2015 at 07:32:52PM +0530, punit vara wrote: > >> On Wed, Sep 23, 2015 at 12:55 PM, Jaime A

Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments

On Thu, Sep 24, 2015 at 01:22:33AM +0530, Punit Vara wrote: > This patch is to the rtl871x_io.h file that fixes up following warning > reported by checkpatch.pl : > > Signed-off-by: Punit Vara > --- You missed copying the warning after mentioning "following warning" in your

Re: [PATCH v3 1/1] staging: dgnc: take lock when storing value in dgnc_po ll_tick

On Wed, Sep 23, 2015 at 03:28:07AM +0100, Salah Triki wrote: > dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to > take the > lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the > appropriate lock, since it is intended for poll scheduling and

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

On Wed, Sep 23, 2015 at 11:22:09PM +0530, punit vara wrote: > On Wed, Sep 23, 2015 at 10:25 PM, punit vara wrote: > > Thank you very much sir I will definitely follow that. I have seen so > > many people fixing patches over here. Now I know process of submitting > > patches.I

Re: [PATCH 19/37] staging/lustre: use 64-bit time for procfs output

On Wed, Sep 23, 2015 at 09:13:42PM +0200, Arnd Bergmann wrote: > This time is only printed in procfs, and can be easily converted > to 64-bit to avoid overflowing on 32-bit systems in 2038. > > Signed-off-by: Arnd Bergmann > --- This introduces new build warnings:

Re: [PATCH] staging: dgap: fix returned errno code in dgap_parsefile()

On Tue, Sep 22, 2015 at 08:38:43AM +0200, Javier Martinez Canillas wrote: > Hello Sudip, > > On 09/22/2015 06:52 AM, Sudip Mukherjee wrote: > > On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote: > >> The driver is using -1 instead of the -ENOMEM

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote: > This patch is to rtl8712_gp_bitdef.h file that fixes up following > warning reported by checkpatch : > > -Block comments use a trailing */ on a separate line > > Signed-off-by: Punit Vara > --- I am getting

Re: [PATCH] staging: wicl1000: fix dereference after free in wilc_wlan_cleanup()

On Tue, Sep 22, 2015 at 12:24:50PM +0200, Javier Martinez Canillas wrote: > The wilc_wlan_cleanup() function iterates over the list of transmission > buffers freeing all of them and then iterates over the receive buffers > list to free all of them as well. > > But on the receive loop a pointer to

Re: [PATCH 1/2] staging: dgnc: take lock when accessing to dgnc_poll_tick

On Tue, Sep 22, 2015 at 12:55:02PM +0100, Salah Triki wrote: > On Mon, Sep 21, 2015 at 07:17:08PM +0300, Dan Carpenter wrote: > > On Sun, Sep 06, 2015 at 08:00:10PM -0700, Greg KH wrote: > > > On Sat, Sep 05, 2015 at 01:12:01PM +0100, Salah Triki wrote: > So please ignore this patch and consider

Re: [PATCH] staging: dgap: fix returned errno code in dgap_parsefile()

On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify > that a buffer allocation failed. Since the error number is propagated, > the caller will get a -EPERM which is the wrong error condition. Just a

Re: [PATCH] staging/rtl8188eu/core/rtw_ap.c comment fix

On Fri, Sep 18, 2015 at 01:06:42PM -0600, BryanSPaul wrote: > fixed block comment use * on subsequent lines fix > > --- Same problem like the previous patch. Missing Signed-off-by. regards sudip ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging/rtl8188eu/core/rtw_cmd.c Compare constants from left fix

On Fri, Sep 18, 2015 at 12:21:07PM -0600, BryanSPaul wrote: > altered to compare constants from left > > --- Missing Signed-off-by. regards sudip ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 2662/2662] Staging: android: Fix 80 character length

On Fri, Sep 18, 2015 at 12:38:21PM +0530, Punit Vara wrote: > This patch is to the Kconfig file which fixes up lines which > exceeded the standard 80 character limitation. > This file also fixes up 3 warnings regarding paragraph. > > Signed-off-by: Punit Vara

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

On Thu, Sep 17, 2015 at 09:09:35AM +0530, Ronit Halder wrote: > On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > > > I don't remember, that was many hundreds of patches ago, sorry. Try it > > yourself to see if I messed up. Perhaps

Re: [PATCH V2 1/8] staging: wilc1000: remove INLINE macro

On Thu, Sep 17, 2015 at 04:48:42PM +0900, Chaehyun Lim wrote: > This patch removes INLINE macro that is used anymore. used? if used then why are you removing it? :) regards sudip ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH V2 3/8] staging: wilc1000: replace int8_t with int

On Thu, Sep 17, 2015 at 04:48:44PM +0900, Chaehyun Lim wrote: > This patch replaces int8_t with int. just use return type as int. > > Signed-off-by: Chaehyun Lim > --- but isn't int8_t is defined as char? regards sudip ___

Re: [PATCH 1/2] Staging: rtl8192u: r8192U_core.c: Eliminate use of MSECS macro

On Thu, Sep 17, 2015 at 03:46:38PM +0530, Shraddha Barke wrote: > Use msecs_to_jiffies instead of driver specific macro > MSECS. > > Signed-off-by: Shraddha Barke > --- This will not apply. please rebase on the current staging tree. regards sudip

[PATCH 1/4] staging: slicoss: return status of slic_link_event_handler

slic_link_event_handler() issues command READ_LINK_STATUS to be executed asynchronously, which is followed by UP configuration write command. But it can fail while setting up the command and in that case the link will not be up. Lets check the status and return it. Signed-off-by: Sudip Mukherjee

[PATCH 2/4] staging: slicoss: use status in slic_if_init

While initializing the interface if we are not able to setup the command to UP the link then we release everything and return the error code. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/slicoss/slicoss.c | 17 - 1 file changed, 16 insertions

[PATCH 3/4] staging: slicoss: use status in slic_ioctl

In the ioctl function if we are not able to UP the link after setting the new parameters then return an error code to the userspace. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/slicoss/slicoss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 4/4] staging: slicoss: use status in isr

If we are not able to setup the LINK UP command then don't increment the interrupt count. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- This is placed at the last as I am not sure if we should be decrement the count. We got the interrupt but we could not service it pr

[PATCH] staging: unisys: remove reference of visorutil

commit 53490b545cb0 ("staging: unisys: move periodic_work.c into the visorbus directory") has removed the visorutil directory but missed removing the reference in the Makefile. Fixes: 53490b545cb0 ("staging: unisys: move periodic_work.c into the visorbus directory")

Re: [PATCH] staging: wlan-ng: prism2fw: coding style: Fixed too long lines.

On Tue, Sep 15, 2015 at 08:09:54PM -0300, Marcos Canán wrote: > This is a patch to the prism2fw.c file that fixes > too long lines. > > Signed-off-by: Marcos Canán > --- This will not apply because of cfa6954ced97 ("staging: wlan-ng: fix long line"). Which tree you have used?

Re: [PATCH] staging: wilc1000: Removed curly braces

On Tue, Sep 15, 2015 at 07:24:00PM +0530, Aparna Karuthodi wrote: > Removed the curly braces of a single statement if block to remove a > coding style warning detected by checkpatch. > The warning is given below: > WARNING: braces {} are not necessary for single statement blocks > >

Re: [PATCH 17/19] staging/lustre: Remove IS_SERVER and all users

On Tue, Sep 15, 2015 at 08:30:41PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > Since the client can never be server, this is all dead code. > > Signed-off-by: Oleg Drokin > --- OOPS.. build fails with error: error: ‘lsi’ undeclared

Re: [PATCH 01/13] staging: wilc1000: replace WILC_ERRORREPORT with return

On Tue, Sep 15, 2015 at 10:27:04AM +0300, Mike Rapoport wrote: > On Tue, Sep 15, 2015 at 10:47:57AM +0530, Sudip Mukherjee wrote: > > On Mon, Sep 14, 2015 at 10:00:43PM +0300, Mike Rapoport wrote: > > > In cases where WILC_ERRORREPORT does not require cleanup actions, but >

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: > From: Glen Lee > > g_num_total_switches is never used so just delete it. > > Signed-off-by: Glen Lee > Signed-off-by: Tony Cho > --- you only deleted from the .h file but it

Re: [PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket

On Tue, Sep 15, 2015 at 02:33:55PM +0900, Tony Cho wrote: > From: Glen Lee > > SendRawpacket is declared but not implemented. It is not used also. > So just delete it. > > Signed-off-by: Glen Lee > Signed-off-by: Tony Cho > --- Still

[PATCH] staging: rtl8192e: fix memory leak

If the size of the firmware is not as expected then we are jumping to the error path but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

On Tue, Sep 15, 2015 at 06:46:25AM -0700, Greg KH wrote: > On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote: > > > > > > On 2015년 09월 15일 16:13, Sudip Mukherjee wrote: > > >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: > >

Re: [PATCH] Staging: wilc1000: Use NULL instead of zero

On Mon, Sep 14, 2015 at 05:37:45PM +0530, Ronit Halder wrote: > I checked but it didn't show me any warning. > Can you please specify the warning? try with --strict option of checkpatch. regards sudip ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: ft1000: code style cleanup

On Mon, Sep 14, 2015 at 07:33:47AM -0700, Greg KH wrote: > On Mon, Sep 14, 2015 at 01:48:09PM +0530, Sudip Mukherjee wrote: > > On Sun, Sep 13, 2015 at 12:55:42AM +0200, lucasg wrote: > > > There was a stray '*' in a comment block. > > > > > > Signed-off-b

Re: [PATCH 01/13] staging: wilc1000: replace WILC_ERRORREPORT with return

On Mon, Sep 14, 2015 at 10:00:43PM +0300, Mike Rapoport wrote: > In cases where WILC_ERRORREPORT does not require cleanup actions, but > causes immediate return from the function it can be replaced with return > statement. > > Signed-off-by: Mike Rapoport > --- Have you

Re: [PATCH] staging: netlogic: platform: Fix miscellaneous coding style issues

On Mon, Sep 14, 2015 at 10:31:05PM +, Martin Pietryka wrote: > This patch fixes all alignment issues, as well as a multiple > assignment and multiple blank lines issues. These are too many things to be included in a single patch. Please break them into a series. One patch should do only one

Re: [PATCH] drivers: stating: wilc1000: Add a check for SPI availability

On Mon, Sep 14, 2015 at 10:21:14PM +0530, Chandra S Gorentla wrote: > NULL pointer deference is observed in the wilc1000.ko module > with bus type SPI and when SPI is not ready. > > Signed-off-by: Chandra S Gorentla > --- A small spelling mistake in the subject. It should

Re: [PATCH 1/4] Staging: rtl8192u: space required before open parentheses

On Mon, Sep 14, 2015 at 08:48:04AM -0800, Mike Dupuis wrote: > > In your previous patches this From: line was not there. Why now? > > I did not do that by hand. I changed some SSMTP and git configuration > settings recently-- perhaps that is related. If this is a problem, I will > correct it. The

Re: [PATCH] Staging: lustre: lustre: lclient: lcommon_cl.c: Fixed coding style error

On Mon, Sep 14, 2015 at 02:53:11PM +0530, Sakshi Vaid wrote: > Fixed the following error. > WARNING: More than 80 characters in a line. > > Signed-off-by: Sakshi Vaid > --- This has already been done by 159dc4bff27a ("staging: lustre: lclient: remove extra

Re: [PATCH] Staging: wilc1000: Use NULL instead of zero

On Mon, Sep 14, 2015 at 11:03:34AM +0530, Ronit Halder wrote: > This patch fixes the warning generated by sparse > "Using plain integer as NULL pointer" by using NULL > instead of zero. > > Signed-off-by: Ronit halder > --- This fixes sparse warning but introduces new

Re: [PATCH] staging: ft1000: code style cleanup

On Sun, Sep 13, 2015 at 12:55:42AM +0200, lucasg wrote: > There was a stray '*' in a comment block. > > Signed-off-by: lucasg > --- Greg has already applied your patch, but next time you send a patch please use your full name in the From and Signed-off-by. regards

Re: [PATCH 1/4] Staging: rtl8192u: space required before open parentheses

On Sun, Sep 13, 2015 at 10:42:44PM -0800, mike dupuis wrote: > From: Mike Dupuis In your previous patches this From: line was not there. Why now? regards sudip ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 3/3] staging: fbtft: use pr_fmt

On Thu, Sep 10, 2015 at 06:45:15PM +0200, Noralf Trønnes wrote: > > 10.09.2015 06:54, skrev Sudip Mukherjee: > >On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote: > >>Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: > >>>On Sat, Sep 05, 2015 at 07:13:

[PATCH 3/3] staging: fbtft: change log level

Reduce the log level of some of the pr_* calls and remove 2 pr_debug calls which just prints "init" and "exit". Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/fbtft/fbtft_device.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletion

[PATCH 1/3] staging: fbtft: use dev_*

Use dev_* family of macros where we have a reference of a device. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- Greg, In fbtft_device_spi_delete() you told to make that as dev_debug, but since that dev_info is already under verbose so I kept it as it is. drivers/staging

Re: [PATCH] staging: slicoss: remove unused variables

On Wed, Sep 09, 2015 at 11:31:37AM -0700, Greg Kroah-Hartman wrote: > On Fri, Sep 04, 2015 at 06:53:18PM +0530, Sudip Mukherjee wrote: > > These variables were only assigned some values but they were never used. > > > > Signed-off-by: Sudip Mukherjee <su...@vectorindia.o

[PATCH 1/2] staging: dgap: fix possible NULL dereference

The return pointer from dgap_getword() is used in strcmp() where it is dereferenced. But dgap_getword() can return NULL. Lets put a check there and return 0 as error. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/dgap/dgap.c | 2 ++ 1 file changed, 2 inse

[PATCH 2/2] staging: dgap: remove unused variable

These variables were assigned some values but they were never used. Removed them but kept one call to ioread8() as it might affect the hardware. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/dgap/dgap.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)

Re: [PATCH 4/5] staging: wilc1000: wilc_msgqueue.c: use kmalloc with GFP_ATOMIC

On Tue, Sep 08, 2015 at 12:36:38AM +0900, Chaehyun Lim wrote: > This patch use kmalloc with GFP_ATOMIC instead of WILC_MALLOC. > It is inside the spin lock region. > > Signed-off-by: Chaehyun Lim > --- Its not related to your patch, but while seeing your patch I thought

Re: [PATCH 3/3] staging: fbtft: use pr_fmt

On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote: > > Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: > >On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: > >>Instead of defining DRVNAME and using it in all calls to pr_* family of > >>

[PATCH 1/2] staging: lustre: lov: fix dereference of ERR_PTR

. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/lustre/lustre/lov/lov_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/lustre/lustre/lov/lov_io.c b/drivers/staging/lustre/lustre/lov/lov_io.c index bf36291..b5b2580 100644 --- a/drivers/s

[PATCH 2/2] staging: lustre: lov: remove always false condition

The member qc_idx of struct if_quotactl is unsigned and hence it can never be less than zero. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/lustre/lustre/lov/lov_obd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/

Re: [PATCH 2/2] staging: lustre: lov: remove always false condition

On Tue, Sep 08, 2015 at 09:53:09AM -0700, Joe Perches wrote: > On Tue, 2015-09-08 at 21:53 +0530, Sudip Mukherjee wrote: > > if (qctl->qc_valid == QC_OSTIDX) { > > - if (qctl->qc_idx < 0 || count <= qctl->qc_idx) > > +

Re: [PATCH 10/15] Staging: rtl8192u: open braces should appear on the appropriate line in ieee80211_softmac_wx.c

On Sat, Sep 05, 2015 at 07:24:38PM +, Mike Dupuis wrote: > This is a patch to the ieee80211_softmac_wx.c file that corrects instances > where open braces appear on the incorrect line as identified by checkpatch.pl > > Signed-off-by: Mike Dupuis > --- This patch will

Re: [PATCH v2 3/5] staging/rtl* Remove unused macro definitions.

On Fri, Sep 04, 2015 at 02:00:31PM -0700, Anish Bhatt wrote: > WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN > are unused, duplicate or unnecessary, remove. > > Signed-off-by: Anish Bhatt > --- Please do not mix up different drivers in a single patch. And why do you have

Re: [PATCH 12/15] Staging: rt8192u: add spaces around assignment operators in ieee80211_softmac_wx.c

On Sat, Sep 05, 2015 at 07:29:14PM +, Mike Dupuis wrote: > This is a patch to add spaces around assignment operators as identifed by > checkpatch.pl > > Signed-off-by: Mike Dupuis > --- same problem as in 10/15 regards sudip

[PATCH 1/2] staging: gdm72xx: fix memory leak

We were successfully requesting the firmware but on error it was not being released. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/gdm72xx/usb_boot.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm72xx/usb_boo

[PATCH 2/2] staging: gdm72xx: NULL comparison style

checkpatch complains if NULL comparison is done as if (var == NULL) Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- drivers/staging/gdm72xx/gdm_sdio.c | 20 ++-- drivers/staging/gdm72xx/gdm_usb.c

Re: [PATCH 3/5] staging: most: remove driver owner

On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote: > On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > > The platform driver core will set the owner value, we do not need to do > > it in the module. > > > > Signed-off-by: Sudip Mukhe

Re: [PATCH] staging: slicoss: remove unused variables

On Fri, Sep 04, 2015 at 11:13:00AM -0700, David Matlack wrote: > On Fri, Sep 4, 2015 at 6:23 AM, Sudip Mukherjee > <sudipm.mukher...@gmail.com> wrote: > > These variables were only assigned some values but they were never used. > > > > Signed-off-by: Sudip Mu

[PATCH 3/3] staging: fbtft: use pr_fmt

Instead of defining DRVNAME and using it in all calls to pr_* family of macros lets start using pr_fmt. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/fbtft/fbtft_device.c | 79 1 file changed, 35 insertions(+), 44 del

[PATCH 1/3] staging: fbtft: use strncpy instead of strcpy

Using strcpy() is a security risk as the destination buffer size is not checked and we may over-run the buffer. Use strncpy() instead, while mentioning the buffer size leaving place for the NULL termination. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging

[PATCH 2/3] staging: fbtft: do not use magic numbers

Using magic numbers are not good coding practise. Use FBTFT_GPIO_NAME_SIZE as defined in the header files. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 2/5] staging: most: return NULL instead of integer

The return type of get_aim_dev() is a pointer but we were returning 0 incase of failure. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/most/aim-v4l2/video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/aim-v4l2/vide

[PATCH 5/5] staging: most: style of bool comparison

BOOLEAN tests do not need any comparison to TRUE or FALSE. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/most/hdm-usb/hdm_usb.c | 10 +- drivers/staging/most/mostcore/core.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/d

[PATCH 4/5] staging: most: remove unneeded NULL check

The loop cursor of list_for_each_entry_safe() can never be NULL. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/most/mostcore/core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/stagin

[PATCH 3/5] staging: most: remove driver owner

The platform driver core will set the owner value, we do not need to do it in the module. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/d

[PATCH 1/5] staging: most: remove always true comparison

channel->dev has already been checked for NULL and if it was NULL then we have returned with -EPIPE. So at this point it can not be NULL. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/most/aim-cdev/cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 5/5] staging/wilc100 : Use BIT() macro where possible

On Fri, Sep 04, 2015 at 02:08:08AM -0700, Anish Bhatt wrote: > Replace (1 << x) by BIT(x) as recommended by > checkpatch.pl > > Signed-off-by: Anish Bhatt > --- You need to refresh your tree. This patch is not applying because of some other changes. regards sudip

[PATCH] staging: wilc1000: fix freeing of ERR_PTR

If memdup_user() fails then it will return the error code in ERR_PTR. We were checking it with IS_ERR but then again trying to free it on the error path. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/wilc1000/linux_wlan.c | 6 ++ 1 file changed, 2 inse

Re: [PATCH 4/5] staging/rtl* Remove duplicated BIT() definitions

On Fri, Sep 04, 2015 at 02:08:07AM -0700, Anish Bhatt wrote: > The BIT() macro is already defined in bitops.h, > remove duplicate definitions. > > Signed-off-by: Anish Bhatt > --- This patch is adding new build warnings. regards sudip

[PATCH] staging: slicoss: remove unused variables

These variables were only assigned some values but they were never used. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/slicoss/slicoss.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/staging/slicoss/sli

Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes

On Fri, Sep 04, 2015 at 09:58:10AM -0400, Ben Romer wrote: > On 09/04/2015 09:41 AM, Sudip Mukherjee wrote: > >Any new developments can only go in rc1 release. 4.3 merge window is > >already open so new developments cannot be added to 4.3-rc1. New codes > >has to go to 4.4-

Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes

On Fri, Sep 04, 2015 at 09:20:23AM -0400, Ben Romer wrote: > On 09/02/2015 08:40 PM, Greg KH wrote: > >These aren't all "fixes" so I can't just add them to the 4.3-final > >release, but some look like they should go there. So please split this > >into two different series and resend, one for

Re: [PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver

On Thu, Sep 03, 2015 at 01:13:14PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- I think you need to

Re: [PATCH][RESEND] staging/wlan-ng : Partial checkpatch cleanups

On Tue, Sep 01, 2015 at 01:11:53PM -0700, Anish Bhatt wrote: > * Replace memcmp(... ETH_ALEN) with ether_addr_equal_unaligned() > * Replace memcpy(... ETH_ALEN) with ether_addr_copy() > > Fixes : > * CHECK : No space is necessary after a cast > * CHECK : Please don't use multiple blank lines > *

Re: [PATCHv2] staging: amso1100: change occurrences of foo* to foo *

On Thu, Sep 03, 2015 at 06:37:11PM -0700, Greg KH wrote: > On Thu, Sep 03, 2015 at 09:33:24AM +0300, Ivan Radanov Ivanov wrote: > > As per the Linux coding style, when declaring a pointer or a > > function that returns a pointer, the use of '*' should be > > adjacent to the data name or function

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

On Tue, Sep 01, 2015 at 04:27:24PM +0300, Tomi Valkeinen wrote: > > > On 18/07/15 07:08, Sudip Mukherjee wrote: > > Now since all cleanups are done and the code is ready to be merged lets > > move it out of staging into fbdev location. > > Have you considered writing

Re: [PATCH 7/8] staging: unisys: stop device registration before visorbus registration

On Tue, Aug 25, 2015 at 08:33:55AM -0400, Jes Sorensen wrote: Sudip Mukherjee sudipm.mukher...@gmail.com writes: On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote: In cases where visorbus is compiled directly into the kernel, if visorbus registration fails for any reason

[PATCH v2] staging: most: NULL comparison style

checkpatch complains when a variable comparison to NULL is written as: variable == NULL or variable != NULL. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- drivers/staging/most/aim-cdev/cdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers

Re: [PATCH 0/6] fix drivers/staging/android some coding style issues

On Fri, Aug 21, 2015 at 02:13:51PM +0800, Peng Sun wrote: patches based on commit f0359ead9129821e4b3b5486e7837d3001a95574 linux-next next-20150820 you have almost similar subject for all patches in the series and please mention which coding style you have changed. regards sudip

Re: [PATCH] staging: fbtft: Removed a space before comma

On Thu, Aug 20, 2015 at 08:57:57PM +0530, Aparna Karuthodi wrote: Removed a space before coma to remove a coding style error detected by checkpatch. The error is given below: drivers/staging/fbtft/fb_ili9340.c:47: ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Aparna

Re: [PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote: poll_tick is declared global, so dgnc_driver_pollrate_store needs to take the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the appropriate lock, since it is intended for poll scheduling and dgnc_poll_tick

Re: [PATCH] staging: fbtft: Removed space before parenthesis

On Fri, Aug 21, 2015 at 09:05:47PM +0530, Aparna Karuthodi wrote: Removed space before parenthesis in two different lines to remove coding style errors detected by checkpatch. The errors are given below: drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before that close

Re: [PATCH] staging: fbtft: Made into two lines

On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: Made the comment into a new lineto remove a coding style error detected by checkpatch. The warning is given below: drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters Signed-off-by: Aparna Karuthodi

<    1   2   3   4   5   6   7   8   9   10   >