reach out to the needy

2022-04-12 Thread Milan A Elizabeth
Peace, mercy and blessings of God be upon you, my beloved. I am happy to meet you here as friends. My name is Melena Alicia I am a Canadian but I live in the USA. I am 48 years old. I used to work for foreign petroleum exploration company and also engaged in business investments before my

[no subject]

2022-04-02 Thread We have an offer to invest in your country under a joint venture partnership please reply for more details
___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[no subject]

2022-04-02 Thread We have an offer to invest in your country under a joint venture partnership please reply for more details
___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [kbuild-all] Re: [driver-core:driver-core-testing 28/31] WARNING: modpost: vmlinux.o(.text.unlikely+0x156c): Section mismatch in reference from the function bitmap_equal() to the variable .init.da

2021-08-18 Thread Chen, Rong A
) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?id

[PATCH][next] staging: rtl8188eu: Replace one-element array with flexible-array in struct ndis_802_11_var_ie

2021-03-03 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Use

Re: [PATCH 1/2] staging: rtl8192e: Pass array value to memcpy instead of struct pointer

2021-02-20 Thread Gustavo A. R. Silva
On 2/20/21 12:21, Atul Gopinathan wrote: > The variable "info_element" is of the following type: > struct rtllib_info_element *info_element > > rtllib_info_element is a struct containing the following fields as > defined in drivers/staging/rtl8192e/rtllib.h: >

Re: [PATCH][next] staging: rtl8723bs: Replace one-element array with flexible-array member in struct ndis_80211_var_ie

2021-02-11 Thread Gustavo A. R. Silva
On 2/11/21 05:06, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 04:49:37PM -0600, Gustavo A. R. Silva wrote: >> There is a regular need in the kernel to provide a way to declare having >> a dynamically sized set of trailing elements in a structure. Kernel code >> should

[PATCH][next] staging: rtl8723bs: Replace one-element array with flexible-array member in struct ndis_80211_var_ie

2021-02-10 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-01 Thread Gustavo A. R. Silva
On Tue, Dec 01, 2020 at 12:52:27AM -0500, Martin K. Petersen wrote: > > Gustavo, > > > This series aims to fix almost all remaining fall-through warnings in > > order to enable -Wimplicit-fallthrough for Clang. > > Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. Awesome! :) Thanks, Mart

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Gustavo A. R. Silva
On Mon, Nov 23, 2020 at 08:38:46PM +, Mark Brown wrote: > On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote: > > This series aims to fix almost all remaining fall-through warnings in > > order to enable -Wimplicit-fallthrough for Clang. > > > > In prepa

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Gustavo A. R. Silva
On Mon, Nov 23, 2020 at 04:03:45PM -0400, Jason Gunthorpe wrote: > On Fri, Nov 20, 2020 at 12:21:39PM -0600, Gustavo A. R. Silva wrote: > > > IB/hfi1: Fix fall-through warnings for Clang > > IB/mlx4: Fix fall-through warnings for Clang > > IB/qedr: Fix fall-th

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
Hi, On 11/20/20 12:53, Jakub Kicinski wrote: > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote: >> This series aims to fix almost all remaining fall-through warnings in >> order to enable -Wimplicit-fallthrough for Clang. >> >> In preparation to enable

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
On 11/20/20 12:28, Joe Perches wrote: > On Fri, 2020-11-20 at 12:21 -0600, Gustavo A. R. Silva wrote: >> Hi all, >> >> This series aims to fix almost all remaining fall-through warnings in >> order to enable -Wimplicit-fallthrough for Clang. >> >> In prepa

[PATCH 128/141] staging: vt6656: Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/staging/vt6656/main_usb.c | 1

[PATCH 127/141] staging: qlge: Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/staging/qlge/qlge_main.c | 1

[PATCH 094/141] media: atomisp: Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/staging/media/atomisp/pci

[PATCH 024/141] staging: vt6655: Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH 023/141] staging: rtl8723bs: core: Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH 000/141] Fix fall-through warnings for Clang

2020-11-20 Thread Gustavo A. R. Silva
through to the next case. Notice that in order to enable -Wimplicit-fallthrough for Clang, this change[1] is meant to be reverted at some point. So, this patch helps to move in that direction. Something important to mention is that there is currently a discrepancy between GCC and Clang when dealing with

[PATCH v3 net] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-16 Thread Alexander A Sverdlin
From: Alexander Sverdlin Currently in case of alignment or FCS error if the packet cannot be corrected it's still not dropped. Report the error properly and drop the packet while making the code around a little bit more readable. Fixes: 80ff0fd3ab ("Staging: Add octeon-ethernet dr

[PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-16 Thread Alexander A Sverdlin
From: Alexander Sverdlin Currently in case of alignment or FCS error if the packet cannot be corrected it's still not dropped. Report the error properly and drop the packet while making the code around a little bit more readable. Signed-off-by: Alexander Sverdlin Fixes: 80ff0fd3ab (&qu

[PATCH v2 net] staging: octeon: repair "fixed-link" support

2020-10-16 Thread Alexander A Sverdlin
/staging/octeon/ethernet-mdio.c | 6 -- drivers/staging/octeon/ethernet.c | 9 + 2 files changed, 9 insertions(+), 6 deletions(-) Changes in v2: - removed the usage of non-upstream local variable "r" diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/oct

[PATCH] stating: octeon: Drop on uncorrectable alignment or FCS error

2020-10-09 Thread Alexander A Sverdlin
From: Alexander Sverdlin Currently in case of alignment or FCS error if the packet cannot be corrected it's still not dropped. Report the error properly and drop the packet while making the code around a little bit more readable. Signed-off-by: Alexander Sverdlin Fixes: 80ff0fd3ab (&qu

[PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread Alexander A Sverdlin
/staging/octeon/ethernet-mdio.c | 6 -- drivers/staging/octeon/ethernet.c | 10 ++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c index cfb673a..0bf54584 100644 --- a/drivers/staging/octeon/

[PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread Alexander A Sverdlin
/staging/octeon/ethernet-mdio.c | 6 -- drivers/staging/octeon/ethernet.c | 10 ++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c index cfb673a..0bf54584 100644 --- a/drivers/staging/octeon/

IMPORTANT INFORMATION

2020-09-12 Thread F C A
To Email Owner, Attn: Fund Beneficiary, This message is from the central working committee on foreign payment Unit of the Financial Conduct Authority. there is an approved fund for you, kindly confirm this your e-mail address is active for further information . We hope you find this improvem

Re: [PATCH v2] staging: atomisp: Remove unnecessary 'fallthrough'

2020-08-31 Thread Gustavo A. R. Silva
On Mon, Aug 31, 2020 at 04:51:04PM +0300, Cengiz Can wrote: > commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from > Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments > with 'fallthrough' pseudo-keyword. > > However, i

[PATCH] staging: most: dim2: Add missing identifier name to function argument

2020-08-02 Thread Nícolas F . R . A . Prado
A function definition argument should have an identifier name according to checkpatch: WARNING: function definition argument 'struct platform_device *' should also have an identifier name Name it pdev as that name is already used throughout the code. Signed-off-by: Nícolas F. R

[PATCH][next] staging: wfx: Use flex_array_size() helper in memcpy()

2020-07-29 Thread Gustavo A. R. Silva
Make use of the flex_array_size() helper to calculate the size of a flexible array member within an enclosing structure. This helper offers defense-in-depth against potential integer overflows, while at the same time makes it explicitly clear that we are dealing with a flexible array member

[PATCH][next] staging: rtl8192e: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH][next] staging: gdm724x: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH][next] staging: rtl8723bs: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH][next] staging: ks7010: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH][next] staging: rtl8712: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH][next] staging: comedi: s526: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH][next] staging: qlge: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH][next] staging: vc04_services: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH] staging: comedi: Replace HTTP links with HTTPS ones

2020-07-23 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master

[PATCH] staging: comedi: cb: Replace HTTP links with HTTPS ones

2020-07-23 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master

[PATCH] staging: comedi: adv: Replace HTTP links with HTTPS ones

2020-07-23 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master

[PATCH] staging: comedi: adl: Replace HTTP links with HTTPS ones

2020-07-23 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master

[PATCH] staging: comedi: pcm: Replace HTTP links with HTTPS ones

2020-07-21 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] staging: comedi: pcl: Replace HTTP links with HTTPS ones

2020-07-21 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] staging: comedi: ni: Replace HTTP links with HTTPS ones

2020-07-21 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] staging: comedi: dt: Replace HTTP links with HTTPS ones

2020-07-21 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] staging: comedi: das: Replace HTTP links with HTTPS ones

2020-07-21 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] staging: comedi: amplc: Replace HTTP links with HTTPS ones

2020-07-21 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] staging: comedi: addi: Replace HTTP links with HTTPS ones

2020-07-21 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH for v5.9] staging: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH for v5.9] media: omap: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] Staging: speakup: Replace HTTP links with HTTPS ones

2020-07-13 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

Re: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-10 Thread Gustavo A. R. Silva
sertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > index ca98274ae390..d9bdd4fb9dc3 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > +++ b/drivers/staging/rtl8723bs/core

[PATCH] staging: rts5208: Assign array_size() to a variable

2020-07-10 Thread Gustavo A. R. Silva
Assign array_size() to variable _size_ and use it in multiple places. This issue was found with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva --- drivers/staging/rts5208/rtsx_chip.c | 12

[PATCH] Staging: nvec: Replace HTTP links with HTTPS ones

2020-07-08 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] Replace HTTP links with HTTPS ones: STAGING - NVIDIA COMPLIANT EMBEDDED CONTROLLER INTERFACE (nvec)

2020-07-08 Thread Alexander A. Klimov
(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov --- Continuing my work started at 93431e0607e5.

[PATCH] staging: vt6655: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging/vt6655/channel.c |2 +- drivers/staging/vt6655/key.c |6 +++--- drivers/staging/vt6656/channel.c |2 +- drivers/staging/vt6656/key.c |2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH] staging: rtl8188eu: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|2 +- drivers/staging/rtl8188eu/hal/usb_halinit.c |2 +- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-16 Thread Jason A. Donenfeld
he "crypto: Remove unnecessary memzero_explicit()" patch for > > now as there can be a bit more discussion on what is best. It will be > > introduced as a separate patch later on after this one is merged. > > To this larger audience a

[PATCH v2][next] staging: rts5208: Use array_size() helper in vmalloc() and memset()

2020-06-16 Thread Gustavo A. R. Silva
/issues/83 Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Fix subject line and commit message. Previously, part of the subject line, unintentionally, sneaked into the commit message. drivers/staging/rts5208/ms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH][next] staging: rts5208: Use array_size() helper in vmalloc()

2020-06-16 Thread Gustavo A. R. Silva
On Tue, Jun 16, 2020 at 01:13:12PM +0300, Dan Carpenter wrote: > On Mon, Jun 15, 2020 at 06:08:11PM -0500, Gustavo A. R. Silva wrote: > > and memset() > > Please don't start the commit message in the middle of a sentence. It's > That was, certainly, unintentional

[PATCH][next] staging: rts5208: Use array_size() helper in vmalloc()

2020-06-15 Thread Gustavo A. R. Silva
://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva --- drivers/staging/rts5208/ms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c index d53dd138a356..9001570a8c94 100644 --- a/drivers/staging/rts5208

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-04-14 Thread Jason A. Donenfeld
On 4/13/20 3:15 PM, Waiman Long wrote: As said by Linus: A symmetric naming is only helpful if it implies symmetries in use. Otherwise it's actively misleading. In "kzalloc()", the z is meaningful and an important part of what the caller wants. In "kzfree()

Re: [kbuild-all] Re: [staging:staging-testing 41/41] drivers/staging/vt6655/baseband.c:1711:15: warning: The scope of the variable 'preamble' can be reduced. [variableScope]

2020-04-05 Thread Chen, Rong A
eresting thing to consider, but really, solves almost nothing. It will do nothing but cause a lot of pointless churn. greg k-h Hi Greg, Thanks for the advice, we'll blacklist the warning and don't report it. Best Regards, Rong Chen

Re: [PATCH] staging: qlge: add braces on all arms of if-else

2020-02-21 Thread Gustavo A. R. Silva
On 2/21/20 14:29, Kaaira Gupta wrote: > fix all checkpatch.pl warnings of 'braces {} should be used on all arms > of this statement' in the file qlge_ethtool.c by adding the braces. > > Signed-off-by: Kaaira Gupta Acked-by: Gustavo A. R. Silva Thanks for

Re: [PATCH] staging: Replace zero-length array with flexible-array member

2020-02-20 Thread Gustavo A. R. Silva
Hi, On 2/20/20 13:04, adham.aboza...@microchip.com wrote: > Hi Gustavo > > On 2/20/20 6:29 AM, Gustavo A. R. Silva wrote: >> The current codebase makes use of the zero-length array language >> extension to the C90 standard, but the preferred mechanism to declare >> va

[PATCH] staging: Replace zero-length array with flexible-array member

2020-02-20 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By

Re: [greybus-dev] [PATCH] staging: greybus: Replace zero-length array with flexible-array member

2020-02-11 Thread Gustavo A. R. Silva
On 2/11/20 16:15, Alex Elder wrote: > On 2/11/20 3:12 PM, Gustavo A. R. Silva wrote: >> The current codebase makes use of the zero-length array language >> extension to the C90 standard, but the preferred mechanism to declare >> variable-length types such as these one

[PATCH] staging: unisys: visorinput: Replace zero-length array with flexible-array member

2020-02-11 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By

[PATCH] staging: greybus: Replace zero-length array with flexible-array member

2020-02-11 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By

Re: [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start

2020-01-13 Thread zhangxiaoxu (A)
p1-isp.c:(.text+0x1238): undefined reference to `phy_mipi_dphy_get_default_config' make: *** [vmlinux] Error 1 Signed-off-by: Zhang Xiaoxu --- drivers/staging/media/rkisp1/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/

Did you get my last mail?

2019-09-29 Thread A. Douglas McGregor
Is this email still active? I have something important to discuss with you. Please contact me on my personal e-mail on: / a.douglas.mcgregory(@)gmail.com / Please remove the brackets (@) on your reply. A. Douglas McGregor ___ devel mailing list de

Re: [kbuild-all] [staging:staging-testing 314/401] drivers/iio/common/hid-sensors/hid-sensor-attributes.c:312: undefined reference to `__udivdi3'

2019-09-06 Thread Chen, Rong A
473d12f7638c93acbd9296a8cd455b203d5eb528 # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): So, as far as I understood it wasn't compiled on 32-bit before, so, it&

Re: [PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake

2019-04-26 Thread Gustavo A. R. Silva
Hi Vatsala, On 4/26/19 3:43 AM, Vatsala Narang wrote: > Replace explicitely with explicitly to get rid of checkpatch warning. > > Signed-off-by: Vatsala Narang > --- > Changes in v2: > -added this patch to patchset to fix spelling mistake. > When you create a series,

Re: [PATCH] staging: rtl8192u: ieee80211: Replace bit shifting with BIT macro

2019-04-25 Thread Gustavo A. R. Silva
< c) > +BIT(c) > > Signed-off-by: Vatsala Narang > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c > b/drivers/staging/rtl81

[PATCH] staging: most: core: replace strcpy() by strscpy()

2019-04-22 Thread Gustavo A. R. Silva
0 ("Copy into fixed size buffer") Fixes: 131ac62253db ("staging: most: core: use device description as name") Signed-off-by: Gustavo A. R. Silva --- drivers/staging/most/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/cor

Re: [PATCH v2] staging: greybus: power_supply: use struct_size() helper

2019-04-18 Thread Gustavo A. R. Silva
On 4/18/19 1:27 AM, Johan Hovold wrote: > On Wed, Apr 17, 2019 at 01:44:40PM -0500, Gustavo A. R. Silva wrote: >> Make use of the struct_size() helper instead of an open-coded version >> in order to avoid any potential type mistakes, in particular in the >> context in whi

[PATCH v2] staging: greybus: power_supply: use struct_size() helper

2019-04-17 Thread Gustavo A. R. Silva
) with: struct_size(resp, props, props_count) This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Rebase on top of 47830c1127ef ("staging: greybus: power_supply: fix prop-descriptor request size") drivers/staging/greybus/power_su

Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper

2019-04-10 Thread Gustavo A. R. Silva
Johan, On 4/4/19 2:24 AM, Johan Hovold wrote: > On Thu, Apr 04, 2019 at 08:09:51AM +0100, Rui Miguel Silva wrote: >> Hi Gustavo, >> Thanks a lot for the patch. >> >> On Wed 03 Apr 2019 at 21:58, Gustavo A. R. Silva wrote: >>> Make use of the struct_si

Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper

2019-04-10 Thread Gustavo A. R. Silva
Hi Johan, On 4/4/19 1:57 AM, Johan Hovold wrote: > > This patch looks good, but I noticed a bug here in the current code, > which should be fixed before applying this clean up. > > sizeof(req) should have been sizeof(*req) above. > Good catch. >> -

[PATCH] staging: greybus: power_supply: Use struct_size() helper

2019-04-03 Thread Gustavo A. R. Silva
) with: struct_size(resp, props, props_count) This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/staging/greybus/power_supply.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/power_supply.c b/drivers

[PATCH] staging: ralink-gdma: Use struct_size() in kzalloc()

2019-04-03 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; size = sizeof(struct foo

Re: [PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-18 Thread Gustavo A. R. Silva
Hi Sasha, On 2/18/19 3:14 PM, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 58dd7c0a2a6e Staging: comedi: add ni_660x driver. > > The bot has tested the

[PATCH] staging: vt6656: key: Mark expected switch fall-throughs

2019-02-18 Thread Gustavo A. R. Silva
vel 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/staging/vt6656/key.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/key.c b/driv

Re: [PATCH v2] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-13 Thread Gustavo A. R. Silva
On 2/13/19 4:41 AM, Ian Abbott wrote: > On 12/02/2019 18:44, Gustavo A. R. Silva wrote: >> Add missing break statement in order to prevent the code from falling >> through to the default case and return -EINVAL every time. >> >> This bug was found thanks to th

Re: [PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-12 Thread Gustavo A. R. Silva
Hi, Please, drop this. I've just sent v2 with the right Fixes tag: https://lore.kernel.org/patchwork/patch/1041301/ Thanks -- Gustavo On 2/12/19 12:08 PM, Gustavo A. R. Silva wrote: > Add missing break statement in order to prevent the code from falling > through to the defau

[PATCH v2] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-12 Thread Gustavo A. R. Silva
uting()") Cc: sta...@vger.kernel.org Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Fix Fixes tag. drivers/staging/comedi/drivers/ni_660x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c index e7

[PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-12 Thread Gustavo A. R. Silva
;) Cc: sta...@vger.kernel.org Signed-off-by: Gustavo A. R. Silva --- drivers/staging/comedi/drivers/ni_660x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c index e70a461e723f..405573e927cf 100644 --- a/drivers/staging/come

Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

2019-02-01 Thread Xiaqing (A)
On 2019/2/1 16:15, Dan Carpenter wrote: On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote: In the first loop, gfp_flags will be modified to high_order_gfp_flags, and there will be no chance to change back to low_order_gfp_flags. Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spea

Re: [PATCH] staging: android: ion: move map_kernel to ion_dma_buf_kmap

2019-01-17 Thread Xiaqing (A)
vers/staging/android/ion/ion.c | 46 ++-   1 file changed, 21 insertions(+), 25 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 9907332..f7e2812 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/a

RE: [PATCH v3] binderfs: fix error return code in binderfs_fill_super()

2019-01-16 Thread weiyongjun (A)
Sorry, please ignore this patch, missing reviewed-by line, I will send a new version. > -Original Message- > From: weiyongjun (A) > Sent: Wednesday, January 16, 2019 6:39 PM > To: gre...@linuxfoundation.org; a...@android.com; tk...@android.com; > m...@android.com; j...@jo

[PATCH] staging: rtl8188eu: Replace kzalloc with kcalloc

2019-01-14 Thread Gustavo A. R. Silva
Replace kzalloc() function with its 2-factor argument form, kcalloc(). This patch replaces cases of: kzalloc(a * b, gfp) with: kcalloc(a, b, gfp) This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/staging/rtl8188eu/core

[PATCH] staging: mt7621-dma: Use struct_size() in devm_kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = devm_kzalloc(dev, sizeof

[PATCH] staging: wilc1000: fix memory leak in wilc_add_rx_gtk

2018-12-22 Thread Gustavo A. R. Silva
In case *mode* happens to be different than WILC_AP_MODE and WILC_STATION_MODE, gtk_key is not released, hence leanding to a memory leak. So, in this case it is safer to release gtk_key just before returning to callers. Addresses-Coverity-ID: 1476020 ("Resource leak") Signed-off-by: Gu

Re: [PATCH 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-10-16 Thread Gustavo A. R. Silva
e it turns out >> the userland hv_kvp_daemon needs the info of operation, adapter_id and >> addr_family. With the incorrect fc62c3b1977d, the host can't get the >> VM's IP via KVP. >> >> And, fc62c3b1977d added a "break;", but actually forgot to initialize >

Re: [PATCH] staging: comedi: tio: fix multiple missing break in switch bugs

2018-10-12 Thread Gustavo A. R. Silva
On 10/12/18 11:04 AM, Ian Abbott wrote: > On 11/10/2018 20:05, Gustavo A. R. Silva wrote: >> Currently, there are multiple missing break statements in two switch code >> blocks. This makes the execution path to fall all the way down through >> to the default cases, whi

[PATCH] staging: comedi: tio: fix multiple missing break in switch bugs

2018-10-11 Thread Gustavo A. R. Silva
;Structurally dead code") Fixes: 347e244884c3 ("staging: comedi: tio: implement global tio/ctr routing") Signed-off-by: Gustavo A. R. Silva --- drivers/staging/comedi/drivers/ni_tio.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/d

Re: [PATCH] staging: erofs: adds a space around '*'

2018-10-08 Thread Gustavo A. R. Silva
nzip_vle_lz4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/erofs/unzip_vle_lz4.c > b/drivers/staging/erofs/unzip_vle_lz4.c > index f5b665f..501cfe0 100644 > --- a/drivers/staging/erofs/unzip_vle_lz4.c > +++ b/drivers/sta

Re: [PATCH] staging: emxx_udc: remove unused code

2018-10-08 Thread Gustavo A. R. Silva
Hi, On 10/8/18 9:33 AM, Loic Tourlonias wrote: > Remove useless code inside if_0 endif > > Signed-off-by: Loic Tourlonias > --- > drivers/staging/emxx_udc/emxx_udc.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.h >

Re: [PATCH] Staging: rts5208: rtsx_card: Fixed multiple coding style issues

2018-10-06 Thread Gustavo A. R. Silva
Thanks -- Gustavo > Signed-off-by: Maxime Desroches > --- > drivers/staging/rts5208/rtsx_card.c | 96 +++-- > 1 file changed, 37 insertions(+), 59 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx_card.c > b/drivers/staging/rts5208/rtsx_

Re: [PATCH] staging/rtlwifi: Fixing formatting warnings.

2018-10-05 Thread Gustavo A. R. Silva
On 10/5/18 10:58 PM, Scott Tracy wrote: > Signed-off-by: Scott Tracy > --- > drivers/staging/rtlwifi/core.c | 5 +++-- > drivers/staging/rtlwifi/efuse.c | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtlwifi/core.c b/dr

  1   2   3   4   5   >