On 8/26/19 11:36 AM, Laura Abbott wrote:
> On 8/23/19 10:28 PM, Alexey Skidanov wrote:
>> In ion_cma_heap, the allocated buffer is represented by a single
>> struct scatterlist instance. The length field of this struct is
>> 32 bit, hence the maximal size of requested buf
requested size might be greater than 4GB and in this case
the field length of the struct scatterlist is initialized incorrectly.
To fix this, we check that requested size may fit into
the field length of the struct scatterlist
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.h
is scanned. If RBT
defines the memory type for the requested PFN, this memory type is used,
otherwise the PFN is mapped as uncachable.
Is it x86 specific issue?
I have implemented and tested the fix for this issue, but it looks like
it should be submitted to the PAT.
Thanks,
Alexey
think.
Thanks,
Alexey
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> -Original Message-
> From: Liam Mark [mailto:lm...@codeaurora.org]
> Sent: Friday, January 04, 2019 19:42
> To: Skidanov, Alexey
> Cc: Laura Abbott ; Greg KH ;
> de...@driverdev.osuosl.org; tk...@android.com; r...@android.com; linux-
> ker...@vger.kernel.
> -Original Message-
> From: Laura Abbott [mailto:labb...@redhat.com]
> Sent: Friday, January 04, 2019 03:58
> To: Skidanov, Alexey ; gre...@linuxfoundation.org;
> Sumit
> Semwal
> Cc: de...@driverdev.osuosl.org
> Subject: Re: [PATCH] staging: andro
On 1/3/19 12:37 AM, Laura Abbott wrote:
> On 12/20/18 1:29 PM, Alexey Skidanov wrote:
>>
>>
>> On 12/20/18 10:36 PM, Laura Abbott wrote:
>>> On 12/16/18 2:46 AM, Alexey Skidanov wrote:
>>>> Chunk heap instantiation should be supported for device tr
On 12/20/18 10:36 PM, Laura Abbott wrote:
> On 12/16/18 2:46 AM, Alexey Skidanov wrote:
>> Chunk heap instantiation should be supported for device tree platforms
>> and
>> non device tree platforms. For device tree platforms, it's a platform
>> specific code res
On 12/17/18 20:42, Liam Mark wrote:
> On Sun, 16 Dec 2018, Alexey Skidanov wrote:
>
>>
>>
>> On 12/16/18 7:20 AM, Liam Mark wrote:
>>> On Tue, 6 Feb 2018, Alexey Skidanov wrote:
>>>
>>>>
>>>>
>>>> On 02/07/2018 01:
forms, there is no defined way to create the heaps.
This patch provides the way of chunk heaps creation using
"ion_chunk_heap=name:size@start" kernel boot parameter.
Link:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-November/128495.html
Signed-off-by:
On 12/16/18 7:20 AM, Liam Mark wrote:
> On Tue, 6 Feb 2018, Alexey Skidanov wrote:
>
>>
>>
>> On 02/07/2018 01:56 AM, Laura Abbott wrote:
>>> On 01/31/2018 10:10 PM, Alexey Skidanov wrote:
>>>>
>>>> On 01/31/2018 03:00 PM, Greg KH wrot
On 11/29/18 8:25 AM, Alexey Skidanov wrote:
>
>
> On 11/29/18 3:30 AM, Laura Abbott wrote:
>> On 11/27/18 12:07 PM, Alexey Skidanov wrote:
>>>
>>>
>>> On 11/27/18 9:20 PM, Laura Abbott wrote:
>>>> On 11/26/18 10:43 AM, Alexey Skidanov wrot
On 11/29/18 3:30 AM, Laura Abbott wrote:
> On 11/27/18 12:07 PM, Alexey Skidanov wrote:
>>
>>
>> On 11/27/18 9:20 PM, Laura Abbott wrote:
>>> On 11/26/18 10:43 AM, Alexey Skidanov wrote:
>>>>
>>>>
>>>> On 11/26/18 6:39 PM, La
On 11/27/18 9:20 PM, Laura Abbott wrote:
> On 11/26/18 10:43 AM, Alexey Skidanov wrote:
>>
>>
>> On 11/26/18 6:39 PM, Laura Abbott wrote:
>>> On 11/25/18 2:02 PM, Alexey Skidanov wrote:
>>>>
>>>>
>>>> On 11/25/18 11:40 PM, La
On 11/26/18 6:39 PM, Laura Abbott wrote:
> On 11/25/18 2:02 PM, Alexey Skidanov wrote:
>>
>>
>> On 11/25/18 11:40 PM, Laura Abbott wrote:
>>> On 11/25/18 1:22 PM, Alexey Skidanov wrote:
>>>>
>>>>
>>>> On 11/25/18 10:51 PM, Lau
On 11/25/18 11:40 PM, Laura Abbott wrote:
> On 11/25/18 1:22 PM, Alexey Skidanov wrote:
>>
>>
>> On 11/25/18 10:51 PM, Laura Abbott wrote:
>>> On 11/11/18 11:29 AM, Alexey Skidanov wrote:
>>>> Create chunk heap of specified size and base address by addi
On 11/25/18 10:51 PM, Laura Abbott wrote:
> On 11/11/18 11:29 AM, Alexey Skidanov wrote:
>> Create chunk heap of specified size and base address by adding
>> "ion_chunk_heap=size@start" kernel boot parameter.
>>
>> Signed-off-by: Alexey Skidanov
&g
Create chunk heap of specified size and base address by adding
"ion_chunk_heap=size@start" kernel boot parameter.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion_chunk_heap.c | 40
1 file changed, 40 insertions(+)
diff --git a/drive
On 11/8/18 9:41 PM, Laura Abbott wrote:
> On 11/8/18 11:34 AM, Alexey Skidanov wrote:
>>
>>
>> On 11/8/18 9:15 PM, Laura Abbott wrote:
>>> On 10/22/18 2:15 PM, Alexey Skidanov wrote:
>>>> Heap name is mundatory.
>>>>
>>>
>>>
On 11/8/18 9:15 PM, Laura Abbott wrote:
> On 10/22/18 2:15 PM, Alexey Skidanov wrote:
>> Heap name is mundatory.
>>
>
> I'm wary of this and the other change because it misses the
> broader problem of dealing with the carveout heaps.
> I still want to remove th
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Tuesday, October 23, 2018 08:33
> To: Skidanov, Alexey
> Cc: Laura Abbott ; gre...@linuxfoundation.org;
> de...@driverdev.osuosl.org
> Subject: Re: [PATCH] staging: android: ion
Heap name is mundatory.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion_carveout_heap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion_carveout_heap.c
b/drivers/staging/android/ion/ion_carveout_heap.c
index e129237..e89b464 100644
--- a
On 10/22/18 17:32, Laura Abbott wrote:
> On 10/22/2018 07:02 AM, Alexey Skidanov wrote:
>> The heap name might be uninitialized and access might crash the
>> kernel.
>>
>
> The heap name should never be null so this seems like this is being
> fixed in the wrong p
The heap name might be uninitialized and access might crash the
kernel.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index
.
Signed-off-by: Alexey Skidanov
---
v3:
Removed debugfs_create_dir() return value checking
v4:
Added spinlock to protect heap statistics
v5:
Rebased on staging-next
drivers/staging/android/ion/ion.c | 50 ---
drivers/staging/android/ion
> -Original Message-
> From: Laura Abbott [mailto:labb...@redhat.com]
> Sent: Monday, October 08, 2018 21:26
> To: Skidanov, Alexey ;
> de...@driverdev.osuosl.org
> Cc: Sumit Semwal
> Subject: Re: staging: android: ion: aligned allocation support
>
> On
On 10/03/2018 09:07 PM, Laura Abbott wrote:
> On 10/02/2018 07:27 AM, Alexey Skidanov wrote:
>> Hi,
>>
>> Sometimes HW requires memory buffer to be aligned in order to be used
>> properly. Of course, we may overcome the lack of aligned allocation
>> support, but
,
Alexey
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
.
Signed-off-by: Alexey Skidanov
---
v3:
Removed debugfs_create_dir() return value checking
v4:
Added spinlock to protect heap statistics
drivers/staging/android/ion/ion.c | 50 ---
drivers/staging/android/ion/ion.h | 10 +++-
2 files changed
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/staging/axis-fifo/axis-fifo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c
b/drivers/staging/axis-fifo/axis-fifo.c
index abeee0ecc122
On 09/21/2018 05:40 PM, Laura Abbott wrote:
> On 09/11/2018 04:29 AM, Alexey Skidanov wrote:
>> Heap statistics have been removed and currently even basics statistics
>> are missing.
>>
>> This patch creates per heap debugfs directory
>> /sys/kernel/debug/
&
.
Signed-off-by: Alexey Skidanov
---
v3:
Removed debugfs_create_dir() return value checking
drivers/staging/android/ion/ion.c | 46 ---
drivers/staging/android/ion/ion.h | 6 ++---
2 files changed, 41 insertions(+), 11 deletions(-)
diff --git a/drivers
On 09/11/2018 12:31 PM, Greg KH wrote:
> On Tue, Sep 11, 2018 at 12:11:23PM +0300, Alexey Skidanov wrote:
>>
>>
>> On 09/11/2018 11:59 AM, Greg KH wrote:
>>> On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote:
>>>> On Tue, Sep 11, 2018
On 09/11/2018 12:15 PM, Dan Carpenter wrote:
> On Tue, Sep 11, 2018 at 12:11:23PM +0300, Alexey Skidanov wrote:
>>
>>
>> On 09/11/2018 11:59 AM, Greg KH wrote:
>>> On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote:
>>>> On Tue, Sep 11, 2018
On 09/11/2018 11:59 AM, Greg KH wrote:
> On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote:
>> On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote:
>>> @@ -546,6 +556,38 @@ void ion_device_add_heap(struct ion_heap *heap)
>>> }
&g
.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.c | 50 ---
drivers/staging/android/ion/ion.h | 6 ++---
2 files changed, 45 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
On 09/10/2018 11:21 PM, Laura Abbott wrote:
> On 09/10/2018 03:00 AM, Alexey Skidanov wrote:
>>
>>
>> On 09/10/2018 12:36 PM, Dan Carpenter wrote:
>>> On Sun, Sep 09, 2018 at 01:44:31AM +0300, Alexey Skidanov wrote:
>>>> The heap statistics h
On 09/10/2018 06:57 PM, Greg KH wrote:
> On Mon, Sep 10, 2018 at 06:51:18PM +0300, Alexey Skidanov wrote:
>> On 09/10/2018 05:21 PM, Greg KH wrote:
>>> On Mon, Sep 10, 2018 at 01:46:13PM +0300, Alexey Skidanov wrote:
>>>> On 09/10/2018 11:27 AM, Greg KH wrote:
On 09/10/2018 05:21 PM, Greg KH wrote:
> On Mon, Sep 10, 2018 at 01:46:13PM +0300, Alexey Skidanov wrote:
>>
>>
>> On 09/10/2018 11:27 AM, Greg KH wrote:
>>> On Sun, Sep 09, 2018 at 01:44:31AM +0300, Alexey Skidanov wrote:
>>>> The heap statistics h
On 09/10/2018 11:27 AM, Greg KH wrote:
> On Sun, Sep 09, 2018 at 01:44:31AM +0300, Alexey Skidanov wrote:
>> The heap statistics have been removed and currently even basics statistics
>> are missing.
>>
>> This patch creates per heap debugfs directory /sys/kernel/debu
On 09/10/2018 12:36 PM, Dan Carpenter wrote:
> On Sun, Sep 09, 2018 at 01:44:31AM +0300, Alexey Skidanov wrote:
>> The heap statistics have been removed and currently even basics statistics
>> are missing.
>
> Remind me why did we remove them? What was the git hash?
1
The heap statistics have been removed and currently even basics statistics
are missing.
This patch creates per heap debugfs directory /sys/kernel/debug/
and adds two counters - the number of allocated buffers and number of
allocated bytes.
Signed-off-by: Alexey Skidanov
---
drivers/staging
On 09/08/2018 09:42 PM, Dan Carpenter wrote:
> On Sat, Sep 08, 2018 at 07:33:40PM +0300, Alexey Skidanov wrote:
>> Label unlock is defined but not used
>>
>> Signed-off-by: Alexey Skidanov
>
> There is no Fixes tag. I don't understand how the compile warnin
Label unlock is defined but not used
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 5fa5363..080ff1c 100644
--- a/drivers
ION had supported heap debug info under /sys/kernel/debug/ion/.
This support have been removed but some leftovers (dead code) still exist.
This patch removes the existing dead code.
Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and ion_client")
Signed-off-by: Alexe
On 09/04/2018 09:23 PM, Laura Abbott wrote:
> On 08/26/2018 01:08 PM, Alexey Skidanov wrote:
>> ION had supported heap debug info under
>> /sys/kernel/debug/ion/.
>> This support have been removed but some leftovers (dead code) still
>> exist.
>>
>> Th
ION had supported heap debug info under /sys/kernel/debug/ion/.
This support have been removed but some leftovers (dead code) still exist.
This patch removes the existing dead code.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.h | 5 -
drivers/staging
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.h | 5 -
drivers/staging/android/ion/ion_system_heap.c | 24
2 files changed, 29 deletions(-)
diff --git a/drivers/staging/android/ion/ion.h
b/drivers/staging/android/ion/ion.h
index
> 4 июня 2018 г., в 7:15, Andreas Dilger написал(а):
>
> On Jun 3, 2018, at 9:59 PM, Alexey Lyashkov wrote:
>>
>>> On Sun, Jun 03 2018, Dilger, Andreas wrote:
>>>
>>>> LNet is originally based on a high-performance networking stack called
>&
> 4 июня 2018 г., в 6:54, NeilBrown написал(а):
>
> On Sun, Jun 03 2018, Dilger, Andreas wrote:
>
>> On Jun 1, 2018, at 17:19, NeilBrown wrote:
>>>
>>> On Fri, Jun 01 2018, Doug Oucharek wrote:
>>>
Would it makes sense to land LNet and LNDs on their own first? Get
the networking h
On Sun, May 06, 2018 at 06:45:31PM +0100, Al Viro wrote:
> On Sun, May 06, 2018 at 08:19:49PM +0300, Alexey Dobriyan wrote:
> > @@ -62,9 +62,9 @@ struct proc_dir_entry {
> > umode_t mode;
> > u8 namelen;
> > #ifdef CONFIG_64BIT
> > -#define SI
On Wed, Apr 25, 2018 at 05:47:47PM +0200, Christoph Hellwig wrote:
> Changes since V1:
> - open code proc_create_data to avoid setting not fully initialized
>entries live
> - use unsigned int for state_size
Need this to maintain sizeof(struct proc_dir_entry):
Otherwise ACK fs/proc/ part.
d
And I very much disagree with a tradeoff that keeps 5000 lines of
> > > code vs a few new helpers.
> >
> > OK, the curiosity and suspense are killing me. What the heck is
> > "function overloading with _b_c_e()"?
>
> The way I understood Alexey was to u
> git://git.infradead.org/users/hch/misc.git proc_create
I want to ask if it is time to start using poorman function overloading
with _b_c_e(). There are millions of allocation functions for example,
all slightly difference, and people will add more. Seeing /proc interfaces
doubled like this
On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote:
> Variant of proc_create_data that directly take a struct seq_operations
> --- a/fs/proc/internal.h
> +++ b/fs/proc/internal.h
> @@ -45,6 +45,7 @@ struct proc_dir_entry {
> const struct inode_operations *proc_iops;
> co
On Thu, Apr 19, 2018 at 02:41:15PM +0200, Christoph Hellwig wrote:
> Variant of proc_create_data that directly take a seq_file show
> +struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
> + struct proc_dir_entry *parent,
> + int (*show)(struct seq
On Thu, Apr 19, 2018 at 02:41:03PM +0200, Christoph Hellwig wrote:
> Variants of proc_create{,_data} that directly take a struct seq_operations
> argument and drastically reduces the boilerplate code in the callers.
> +static int proc_seq_open(struct inode *inode, struct file *file)
> +{
> + s
On 02/17/2018 01:54 AM, Laura Abbott wrote:
> On 02/16/2018 04:17 AM, Alexey Skidanov wrote:
>>
>>
>> On 02/16/2018 01:48 AM, Laura Abbott wrote:
>>> On 02/12/2018 02:33 PM, Alexey Skidanov wrote:
>>>> Current ion kernel mapping implementation uses vmap(
On 02/16/2018 10:49 PM, Greg KH wrote:
> On Fri, Feb 16, 2018 at 10:43:03PM +0200, Alexey Skidanov wrote:
>>
>>
>> On 02/16/2018 04:46 PM, Greg KH wrote:
>>> On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov wrote:
>>>> Current ion kernel
On 02/16/2018 04:46 PM, Greg KH wrote:
> On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov wrote:
>> Current ion kernel mapping implementation uses vmap() to map previously
>> allocated buffers into kernel virtual address space.
>>
>> On 32-bit platforms,
On 02/16/2018 01:48 AM, Laura Abbott wrote:
> On 02/12/2018 02:33 PM, Alexey Skidanov wrote:
>> Current ion kernel mapping implementation uses vmap() to map previously
>> allocated buffers into kernel virtual address space.
>>
>> On 32-bit platforms, vmap() might fail
On 02/13/2018 08:40 PM, Laura Abbott wrote:
> On 02/12/2018 11:24 PM, Alexey Skidanov wrote:
>> Hello,
>>
>> Correct me if I'm wrong, but there is no user space interface, similar
>> to the dma_buf_start_cpu_access()/dma_buf_end_cpu_access() to handle IO
>>
- DMA read
or
- DMA write
- read from the buffer
may be problematic.
Thanks,
Alexey
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
time.
To fix this, kmap()/kmap_atomic() is used to implement the appropriate
interfaces.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.c | 97 +++
drivers/staging/android/ion/ion.h | 1 -
2 files changed, 48 insertions(+), 50 deletions
On 02/12/2018 10:46 PM, Laura Abbott wrote:
> On 02/12/2018 12:22 PM, Alexey Skidanov wrote:
>>
>>
>> On 02/12/2018 09:52 PM, Laura Abbott wrote:
>>> On 02/12/2018 11:11 AM, Alexey Skidanov wrote:
>>>>
>>>> On 02/12/2018 08:42 PM, Laura Abbot
On 02/12/2018 10:09 PM, Laura Abbott wrote:
> On 02/12/2018 11:21 AM, Alexey Skidanov wrote:
>>
>>
>> On 02/12/2018 08:30 PM, Laura Abbott wrote:
>>> On 02/10/2018 01:43 AM, Alexey Skidanov wrote:
>>>> Hi,
>>>>
>>>> Curre
On 02/12/2018 09:52 PM, Laura Abbott wrote:
> On 02/12/2018 11:11 AM, Alexey Skidanov wrote:
>>
>> On 02/12/2018 08:42 PM, Laura Abbott wrote:
>>> On 02/10/2018 02:17 AM, Alexey Skidanov wrote:
>>>> Current ion defined allocation ioctl doesn't allow to s
On 02/12/2018 08:30 PM, Laura Abbott wrote:
> On 02/10/2018 01:43 AM, Alexey Skidanov wrote:
>> Hi,
>>
>> Current ion kernel mapping implementation uses vmap() to map previously
>> allocated buffers into kernel virtual address space. On 32 bit
>> platforms,
On 02/12/2018 08:42 PM, Laura Abbott wrote:
> On 02/10/2018 02:17 AM, Alexey Skidanov wrote:
>> Current ion defined allocation ioctl doesn't allow to specify the
>> requested
>> allocation alignment. CMA heap allocates buffers aligned on buffer size
>> page order
emory fragmentation
and in some cases it may avoid the allocation request failure.
To fix this, we add an alignment parameter to the allocation ioctl.
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion-ioctl.c | 3 ++-
drivers/staging/android/ion/ion.c
at a time.
So, probably it's better to implement dma_buf_kmap() by kmap() and not
by vmap()?
Thanks,
Alexey
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 02/07/2018 05:32 PM, Laura Abbott wrote:
> On 02/07/2018 07:10 AM, Alexey Skidanov wrote:
>>
>>
>> On 02/07/2018 04:58 PM, Laura Abbott wrote:
>>> On 02/06/2018 11:05 PM, Alexey Skidanov wrote:
>>>>
>>>>
>>>>> Yup, you
On 02/07/2018 04:58 PM, Laura Abbott wrote:
> On 02/06/2018 11:05 PM, Alexey Skidanov wrote:
>>
>>
>>> Yup, you've hit upon a key problem. Having fallbacks be stable
>>> was always a problem and the recommendation these days is to
>>> not rel
rrent API (allocation IOCTL) requires to specify the particular heap
object by using heap id. From the other hand, the user space doesn't
control the heaps creation order and heap id assignment. So it may be
tricky, especially when more than o
On 02/07/2018 01:56 AM, Laura Abbott wrote:
> On 01/31/2018 10:10 PM, Alexey Skidanov wrote:
>>
>> On 01/31/2018 03:00 PM, Greg KH wrote:
>>> On Wed, Jan 31, 2018 at 02:03:42PM +0200, Alexey Skidanov wrote:
>>>> Any driver may access shared buffers, created
On 01/31/2018 03:00 PM, Greg KH wrote:
On Wed, Jan 31, 2018 at 02:03:42PM +0200, Alexey Skidanov wrote:
Any driver may access shared buffers, created by ion, using dma_buf_vmap and
dma_buf_vunmap dma-buf API that maps/unmaps previosuly allocated buffers into
the kernel virtual address space
Any driver may access shared buffers, created by ion, using dma_buf_vmap and
dma_buf_vunmap dma-buf API that maps/unmaps previosuly allocated buffers into
the kernel virtual address space. The implementation of these API is missing in
the current ion implementation.
Signed-off-by: Alexey Skidanov
On 01/31/2018 12:15 AM, Greg KH wrote:
On Tue, Jan 30, 2018 at 10:39:13PM +0200, Alexey Skidanov wrote:
dma_buf_vmap and dma_buf_vunmap allow drivers to access buffers, created by ion.
But why would anyone ever want to do that? What is wrong with the
existing interfaces that drivers use to
dma_buf_vmap and dma_buf_vunmap allow drivers to access buffers, created by ion.
Signed-off-by: Alexey Skidanov
---
Changes in v1:
- Added changelog text
drivers/staging/android/ion/ion.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/android/ion/ion.c
b
Signed-off-by: Alexey Skidanov
---
drivers/staging/android/ion/ion.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index f480885..4f1dc7f 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers
depends on the
order of linkage. Probably, it's better to let the user to define the
fall back order (and NOT to be dependent on the linkage order at all)
?
Thanks,
Alexey
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.lin
-by: Alexey Khoroshilov
---
drivers/staging/iio/cdc/ad7152.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index dc6ecd824365..ff10d1f0a7e4 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/stag
data(dev);
int ret;
ret = clk_prepare_enable(cec->clk);
if (ret < 0)
return ret;
return 0;
}
Is it ok to enable/disable clock in rusume/suspend only?
Or have I missed anything?
--
Thank you,
Alexey Khoroshilov
Linux Verification Center, ISPRAS
That patch adds support for SSD1305 controller.
That is monochrome OLED display controller present in several
displays eq: Winstar WEX012864
Signed-off-by: Alexey Mednyy
---
drivers/staging/fbtft/Kconfig | 6 ++
drivers/staging/fbtft/Makefile | 1 +
drivers/staging/fbtft/fb_ssd1305
That patch adds support for SSD1325 controller.
That is 4bpp grayscale OLED display controller present in several
displays eq: Winstar WEX012864
Signed-off-by: Alexey Mednyy
---
drivers/staging/fbtft/Kconfig | 6 ++
drivers/staging/fbtft/Makefile | 1 +
drivers/staging/fbtft
On 01/27/2016 02:36 AM, Greg KH wrote:
> On Tue, Jan 26, 2016 at 07:31:16PM +0300, Alexey Mednyy wrote:
>> Signed-off-by: Alexey Mednyy
> Why?
Sorry, that was required by some other project I sent patches to.
>
> I can't take patches without any changelog entries, sor
display,
+ .set_addr_win = set_addr_win,
+ .blank = blank,
+ .set_gamma = set_gamma,
+ },
+};
+
+FBTFT_REGISTER_DRIVER(DRVNAME, "solomon,ssd1305", &display);
+
+MODULE_ALIAS("spi:&qu
ght = HEIGHT,
+ .txbuflen = WIDTH * HEIGHT / 2,
+ .gamma_num = GAMMA_NUM,
+ .gamma_len = GAMMA_LEN,
+ .gamma = DEFAULT_GAMMA,
+ .fbtftops = {
+ .write_vmem = write_vmem,
+ .init_display = init_display,
+ .set_addr_win = set_addr_win,
+ .
Signed-off-by: Alexey Mednyy
---
drivers/staging/fbtft/Kconfig | 6 ++
drivers/staging/fbtft/Makefile | 1 +
drivers/staging/fbtft/fb_ssd1325.c | 205 +
3 files changed, 212 insertions(+)
create mode 100644 drivers/staging/fbtft/fb_ssd1325.c
Signed-off-by: Alexey Mednyy
---
drivers/staging/fbtft/Kconfig | 6 ++
drivers/staging/fbtft/Makefile | 1 +
drivers/staging/fbtft/fb_ssd1305.c | 216 +
3 files changed, 223 insertions(+)
create mode 100644 drivers/staging/fbtft/fb_ssd1305.c
On 01/26/2016 05:09 PM, Dan Carpenter wrote:
Same stuff. Run checkpatch.pl.
+ gpio_set_value(par->gpio.dc, 1);
+ /* Write data */
+
+ ret =
+ par->fbtftops.write(par, par->txbuf.buf,
+ par->info->var.xres * par->info->var.yres / 2
On 01/26/2016 05:00 PM, Dan Carpenter wrote:
The subject should be:
[PATCH] Staging: fbtft: added ssd1305 controller support
On Tue, Jan 26, 2016 at 04:07:24PM +0300, Alexey Mednyy wrote:
Signed-off-by: Alexey Mednyy
---
drivers/staging/fbtft/Kconfig | 6 +
drivers/staging/fbtft
Signed-off-by: Alexey Mednyy
---
drivers/staging/fbtft/Kconfig | 6 +
drivers/staging/fbtft/Makefile | 1 +
drivers/staging/fbtft/fb_ssd1325.c | 266 +
3 files changed, 273 insertions(+)
create mode 100644 drivers/staging/fbtft/fb_ssd1325.c
diff
Signed-off-by: Alexey Mednyy
---
drivers/staging/fbtft/Kconfig | 6 +
drivers/staging/fbtft/Makefile | 1 +
drivers/staging/fbtft/fb_ssd1305.c | 271 +
3 files changed, 278 insertions(+)
create mode 100644 drivers/staging/fbtft/fb_ssd1305.c
diff
If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(),
it calls release_bus() and continues execution. But it leads to double
release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Ale
If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(),
it calls release_bus() and continues execution. But it leads to double
release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Ale
ect (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/staging/wilc1000/wilc_wlan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc1000/wilc_wlan.c
index c02665747705..cd7f52a51173 100644
--- a/drivers/staging/wilc1
test_bit and set_bit take the bit number to operate on, rather than a
mask. This patch fixes the DEVICE_FLAGS_* definitions so that they represent
the bit index in priv->flags as opposed to the mask returned by the
BIT macro.
Signed-off-by: Alexey Tulia
---
drivers/staging/vt6656/device.h
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1377 check_assoc_AP() warn:
inconsistent indenting
Signed-off-by: Alexey Tulia
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b
n project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
Fixes: af8a819a2513 ("[media] lirc_imon: simplify error handling code")
---
drivers/staging/media/lirc/lirc_imon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/media/lirc/lirc_imon.c
b/drivers
1 - 100 of 126 matches
Mail list logo
